Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v5]

2021-12-22 Thread Erik Joelsson
On Wed, 22 Dec 2021 19:34:48 GMT, Andrew Leonard wrote: >> If "reproducible build" is enabled, then utilize the new --date option in >> the building of jar's and jmods. >> Validating the boot jdk supports --date for the building of the jars. >> >> Signed-off-by: Andrew Leonard > > Andrew

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v5]

2021-12-22 Thread Andrew Leonard
> If "reproducible build" is enabled, then utilize the new --date option in the > building of jar's and jmods. > Validating the boot jdk supports --date for the building of the jars. > > Signed-off-by: Andrew Leonard Andrew Leonard has updated the pull request incrementally with one additional

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v4]

2021-12-22 Thread Andrew Leonard
On Wed, 22 Dec 2021 17:30:36 GMT, Erik Joelsson wrote: >> Andrew Leonard has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - 8278766: Enable OpenJDK build support for reproducible jars and jmods >> using --date >> >>

[jdk18] Integrated: JDK-8278967 rmiregistry fails to start because SecurityManager is disabled

2021-12-22 Thread Stuart Marks
On Fri, 17 Dec 2021 20:01:27 GMT, Stuart Marks wrote: > Enable the security manager in rmiregistry's launcher arguments. This pull request has now been integrated. Changeset: 04ee9211 Author:Stuart Marks URL:

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v3]

2021-12-22 Thread Erik Joelsson
On Wed, 22 Dec 2021 15:34:23 GMT, Andrew Leonard wrote: >> @erikj79 fixed it I think, problems is above not enough $'s !! for >> $(shell... > > resolved, thanks Ah, the default diff view didn't show me enough context. This is part of a macro body, then yes, you need to double all the $ to

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v4]

2021-12-22 Thread Erik Joelsson
On Wed, 22 Dec 2021 15:44:39 GMT, Andrew Leonard wrote: >> If "reproducible build" is enabled, then utilize the new --date option in >> the building of jar's and jmods. >> Validating the boot jdk supports --date for the building of the jars. >> >> Signed-off-by: Andrew Leonard > > Andrew

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder)

2021-12-22 Thread Tyler
On Wed, 22 Dec 2021 02:59:43 GMT, Erik Gahlin wrote: >> Just in time for the holidays I have completed an implementation of the JFR >> functionality for AIX. As a side note, this is my first submission to >> OpenJDK  >> >> ### Implementation notes and alternatives considered >> >> After

Integrated: Merge jdk18

2021-12-22 Thread Jesper Wilhelmsson
On Wed, 22 Dec 2021 16:03:43 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 18 -> JDK 19 This pull request has now been integrated. Changeset: f1fbba23 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/f1fbba23ebdb28a32977241f8e85b60e10878cbc Stats: 260

Re: RFR: Merge jdk18 [v2]

2021-12-22 Thread Jesper Wilhelmsson
> Forwardport JDK 18 -> JDK 19 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 104 commits: - Merge - 8279063: Consolidate push and push_if_necessary in PreservedMarks Reviewed-by: rkennke, mli, tschatzl

RFR: Merge jdk18

2021-12-22 Thread Jesper Wilhelmsson
Forwardport JDK 18 -> JDK 19 - Commit messages: - Merge - 8274315: JFR: One closed state per file or stream - 8271447: java.nio.file.InvalidPathException: Malformed input or input contains unmappable characters - 8278987: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v4]

2021-12-22 Thread Andrew Leonard
On Fri, 17 Dec 2021 20:04:20 GMT, Andrew Leonard wrote: >> make/common/MakeBase.gmk line 148: >> >>> 146: ifeq ($(SOURCE_DATE_ISO_8601), ) >>> 147: # GNU date format did not work, try BSD date options >>> 148: SOURCE_DATE_ISO_8601 := $(shell $(DATE) -u -j -f "%s" >>>

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v3]

2021-12-22 Thread Andrew Leonard
On Wed, 22 Dec 2021 15:28:52 GMT, Andrew Leonard wrote: >> make/InitSupport.gmk line 317: >> >>> 315: export SOURCE_DATE_EPOCH := $$(SOURCE_DATE) >>> 316: ifeq ($$(IS_GNU_DATE), yes) >>> 317: SOURCE_DATE_ISO_8601 := $(shell $(DATE) --utc >>> --date="@$(SOURCE_DATE_EPOCH)"

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v4]

2021-12-22 Thread Andrew Leonard
On Fri, 17 Dec 2021 17:47:02 GMT, Erik Joelsson wrote: >> Andrew Leonard has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - 8278766: Enable OpenJDK build support for reproducible jars and jmods >> using --date >> >>

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v4]

2021-12-22 Thread Andrew Leonard
> If "reproducible build" is enabled, then utilize the new --date option in the > building of jar's and jmods. > Validating the boot jdk supports --date for the building of the jars. > > Signed-off-by: Andrew Leonard Andrew Leonard has updated the pull request incrementally with three

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v4]

2021-12-22 Thread Andrew Leonard
On Fri, 17 Dec 2021 20:08:43 GMT, Andrew Leonard wrote: >> But I think the code in InitSupport will be executed always; Init.gmk is our >> "bootstrapper" / "trampoline" which wraps all calls to make (and >> InitSupport.gmk contains gory implementation details of Init.gmk). > > @magicus don't

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v3]

2021-12-22 Thread Andrew Leonard
On Wed, 22 Dec 2021 13:41:53 GMT, Erik Joelsson wrote: >> Andrew Leonard has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8278766: Enable OpenJDK build support for reproducible jars and jmods >> using --date >> >> Signed-off-by:

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v3]

2021-12-22 Thread Andrew Leonard
On Wed, 22 Dec 2021 13:41:53 GMT, Erik Joelsson wrote: >> Andrew Leonard has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8278766: Enable OpenJDK build support for reproducible jars and jmods >> using --date >> >> Signed-off-by:

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v3]

2021-12-22 Thread Andrew Leonard
On Wed, 22 Dec 2021 13:50:32 GMT, Andrew Leonard wrote: >> make/InitSupport.gmk line 317: >> >>> 315: export SOURCE_DATE_EPOCH := $$(SOURCE_DATE) >>> 316: ifeq ($$(IS_GNU_DATE), yes) >>> 317: SOURCE_DATE_ISO_8601 := $(shell $(DATE) --utc >>> --date="@$(SOURCE_DATE_EPOCH)"

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v3]

2021-12-22 Thread Andrew Leonard
On Wed, 22 Dec 2021 13:41:53 GMT, Erik Joelsson wrote: >> Andrew Leonard has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8278766: Enable OpenJDK build support for reproducible jars and jmods >> using --date >> >> Signed-off-by:

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v3]

2021-12-22 Thread Erik Joelsson
On Wed, 22 Dec 2021 13:21:52 GMT, Andrew Leonard wrote: >> If "reproducible build" is enabled, then utilize the new --date option in >> the building of jar's and jmods. >> Validating the boot jdk supports --date for the building of the jars. >> >> Signed-off-by: Andrew Leonard > > Andrew

Re: [jdk18] RFR: JDK-8278967 rmiregistry fails to start because SecurityManager is disabled [v2]

2021-12-22 Thread Erik Joelsson
On Wed, 22 Dec 2021 01:18:58 GMT, Stuart Marks wrote: >> Enable the security manager in rmiregistry's launcher arguments. > > Stuart Marks has updated the pull request incrementally with one additional > commit since the last revision: > > Change java.security.manager to "allow"; filter

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v3]

2021-12-22 Thread Andrew Leonard
> If "reproducible build" is enabled, then utilize the new --date option in the > building of jar's and jmods. > Validating the boot jdk supports --date for the building of the jars. > > Signed-off-by: Andrew Leonard Andrew Leonard has updated the pull request incrementally with one additional

Re: RFR: 8278766: Enable OpenJDK build support for reproducible jars and jmods using --date [v2]

2021-12-22 Thread Andrew Leonard
> If "reproducible build" is enabled, then utilize the new --date option in the > building of jar's and jmods. > Validating the boot jdk supports --date for the building of the jars. > > Signed-off-by: Andrew Leonard Andrew Leonard has updated the pull request incrementally with three

Re: [jdk18] RFR: JDK-8278967 rmiregistry fails to start because SecurityManager is disabled [v2]

2021-12-22 Thread Alan Bateman
On Wed, 22 Dec 2021 01:18:58 GMT, Stuart Marks wrote: >> Enable the security manager in rmiregistry's launcher arguments. > > Stuart Marks has updated the pull request incrementally with one additional > commit since the last revision: > > Change java.security.manager to "allow"; filter

Re: [Ping?] [8u] RFR: 8210283: Support git as an SCM alternative in the build

2021-12-22 Thread Severin Gehwolf
On Fri, 2021-12-10 at 15:11 +0100, Severin Gehwolf wrote: > Hi, > > Please review this adaptation of the corresponding JDK 11 patch. The > JDK 11u patch didn't apply because the build system is widely different > between these two releases. > > The main difference is make/common/MakeBase.gmk