This patch adds clickable link to commit messages in IntelliJ's git log.
Example result:
-
Commit messages:
- JIRA integration
Changes:
On Mon, 11 Apr 2022 21:03:22 GMT, Magnus Ihse Bursie wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8284661: Reproducible assembly builds without relative linking
>>
>> Signed-off-by: Andrew Leonard
>
>
On Mon, 11 Apr 2022 12:04:41 GMT, Maurizio Cimadamore
wrote:
>> src/hotspot/share/prims/scopedMemoryAccess.cpp line 141:
>>
>>> 139:
>>> 140: /*
>>> 141: * This function performs a thread-local handshake against all threads
>>> running at the time
>>
>> Nit: thread-local??
>
> I was
On Mon, 11 Apr 2022 15:41:20 GMT, Andrew Leonard wrote:
>> This PR removes the need for relative object file linking introduced by
>> JDK-8284437 for linux libraries, by specifying
>> .file directives in the linux .S source files. The
>> source files specify a .file ASSEMBLY_SRC_FILE
>> where
On Mon, 11 Apr 2022 21:03:22 GMT, Magnus Ihse Bursie wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8284661: Reproducible assembly builds without relative linking
>>
>> Signed-off-by: Andrew Leonard
>
>
On Mon, 11 Apr 2022 15:41:20 GMT, Andrew Leonard wrote:
>> This PR removes the need for relative object file linking introduced by
>> JDK-8284437 for linux libraries, by specifying
>> .file directives in the linux .S source files. The
>> source files specify a .file ASSEMBLY_SRC_FILE
>> where
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Mon, 11 Apr 2022 17:40:58 GMT, Erik Joelsson wrote:
>> @erikj79 As far as I can see only AIX is the exception of not being Linux
>> and using .debuginfo suffix, are there others?
>> I am currently testing AIX, so I will see if it passes, as you say, I would
>> have my doubts it will!
>
>
On Mon, 11 Apr 2022 17:26:12 GMT, Andrew Leonard wrote:
>> test/jdk/build/AbsPathsInImage.java line 167:
>>
>>> 165: if (Files.isSymbolicLink(file)) {
>>> 166: return super.visitFile(file, attrs);
>>> 167: } else if (fileName.endsWith(".pdb"))
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Mon, 11 Apr 2022 16:58:38 GMT, Erik Joelsson wrote:
> > thanks @erikj79 Not familiar with AbsPathsInImage, could you give some
> > background please? wondering why it's not found these paths before, maybe
> > it's not running on debugimages? What tier does it get run in?
>
> I wrote this
On Mon, 11 Apr 2022 16:53:41 GMT, Erik Joelsson wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8284661: Reproducible assembly builds without relative linking
>>
>> Signed-off-by: Andrew Leonard
>
>
On Mon, 11 Apr 2022 16:17:08 GMT, Andrew Leonard wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8284661: Reproducible assembly builds without relative linking
>>
>> Signed-off-by: Andrew Leonard
>
>
On Mon, 11 Apr 2022 12:55:16 GMT, Erik Joelsson wrote:
>> This PR removes the need for relative object file linking introduced by
>> JDK-8284437 for linux libraries, by specifying
>> .file directives in the linux .S source files. The
>> source files specify a .file ASSEMBLY_SRC_FILE
>> where
On Mon, 11 Apr 2022 15:41:20 GMT, Andrew Leonard wrote:
>> This PR removes the need for relative object file linking introduced by
>> JDK-8284437 for linux libraries, by specifying
>> .file directives in the linux .S source files. The
>> source files specify a .file ASSEMBLY_SRC_FILE
>> where
On Mon, 11 Apr 2022 15:41:20 GMT, Andrew Leonard wrote:
>> This PR removes the need for relative object file linking introduced by
>> JDK-8284437 for linux libraries, by specifying
>> .file directives in the linux .S source files. The
>> source files specify a .file ASSEMBLY_SRC_FILE
>> where
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato wrote:
> This is to upgrade the CLDR data from version 39 to version 41 which was
> released yesterday. The vast majority of the changes are basically replacing
> the CLDR data, along with tools/testcase alignments. Here is the link to CLDR
> v41's
> This PR removes the need for relative object file linking introduced by
> JDK-8284437 for linux libraries, by specifying
> .file directives in the linux .S source files. The
> source files specify a .file ASSEMBLY_SRC_FILE
> where ASSEMBLY_SRC_FILE is defined by the NativeCompliation.gmk.
>
> This PR removes the need for relative object file linking introduced by
> JDK-8284437 for linux libraries, by specifying
> .file directives in the linux .S source files. The
> source files specify a .file ASSEMBLY_SRC_FILE
> where ASSEMBLY_SRC_FILE is defined by the NativeCompliation.gmk.
>
On Mon, 11 Apr 2022 14:50:37 GMT, Andrew Leonard wrote:
>> Non-determinism in .debuginfo straight away makes .so libraries
>> non-deterministic due to the embedded debuginfo CRC value.
>> @erikj79 i'll try removing .debuginfo from the exceptions and try it...
>
>> @andrew-m-leonard This change
On Mon, 11 Apr 2022 14:50:37 GMT, Andrew Leonard wrote:
>> Non-determinism in .debuginfo straight away makes .so libraries
>> non-deterministic due to the embedded debuginfo CRC value.
>> @erikj79 i'll try removing .debuginfo from the exceptions and try it...
>
>> @andrew-m-leonard This change
On Mon, 11 Apr 2022 14:05:54 GMT, Andrew Leonard wrote:
>> This PR removes the need for relative object file linking introduced by
>> JDK-8284437 for linux libraries, by specifying
>> .file directives in the linux .S source files. The
>> source files specify a .file ASSEMBLY_SRC_FILE
>> where
On Mon, 11 Apr 2022 14:05:54 GMT, Andrew Leonard wrote:
>> This PR removes the need for relative object file linking introduced by
>> JDK-8284437 for linux libraries, by specifying
>> .file directives in the linux .S source files. The
>> source files specify a .file ASSEMBLY_SRC_FILE
>> where
On Mon, 11 Apr 2022 12:55:16 GMT, Erik Joelsson wrote:
>> This PR removes the need for relative object file linking introduced by
>> JDK-8284437 for linux libraries, by specifying
>> .file directives in the linux .S source files. The
>> source files specify a .file ASSEMBLY_SRC_FILE
>> where
On Mon, 11 Apr 2022 09:43:37 GMT, Andrew Leonard wrote:
> This PR removes the need for relative object file linking introduced by
> JDK-8284437 for linux libraries, by specifying
> .file directives in the linux .S source files. The
> source files specify a .file ASSEMBLY_SRC_FILE
> where
On Mon, 11 Apr 2022 09:43:37 GMT, Andrew Leonard wrote:
> This PR removes the need for relative object file linking introduced by
> JDK-8284437 for linux libraries, by specifying
> .file directives in the linux .S source files. The
> source files specify a .file ASSEMBLY_SRC_FILE
> where
On Mon, 11 Apr 2022 10:33:54 GMT, David Holmes wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix TestLinkToNativeRBP
>
> src/hotspot/share/prims/scopedMemoryAccess.cpp line 141:
>
>> 139:
>> 140: /*
>>
On Mon, 4 Apr 2022 14:57:30 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Mon, 11 Apr 2022 09:43:37 GMT, Andrew Leonard wrote:
> This PR removes the need for relative object file linking introduced by
> JDK-8284437 for linux libraries, by specifying
> .file directives in the linux .S source files. The
> source files specify a .file ASSEMBLY_SRC_FILE
> where
This PR removes the need for relative object file linking introduced by
JDK-8284437 for linux libraries, by specifying
.file directives in the linux .S source files. The
source files specify a .file ASSEMBLY_SRC_FILE
where ASSEMBLY_SRC_FILE is defined by the NativeCompliation.gmk.
On Mon, 11 Apr 2022 00:48:34 GMT, Tim Prinzing wrote:
>> Created a test called NullCallerGetResource to test
>> Module::getResourceAsStream and Class::getResourceAsStream from the native
>> level.
>>
>> At the java level the test builds a test module called 'n' which opens the
>> package
31 matches
Mail list logo
