Re: RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests

2022-06-07 Thread Jonathan Gibbons
On Tue, 7 Jun 2022 20:05:26 GMT, Jonathan Gibbons wrote: >> With project Skara, the ability to run a set of sanity build and test jobs >> on selected platforms was added. This functionality was driven by >> `.github/workflows/submit.yml`. This file unfortunately lacks any real >> structure,

Re: RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests

2022-06-07 Thread Jonathan Gibbons
On Tue, 7 Jun 2022 13:05:49 GMT, Magnus Ihse Bursie wrote: > With project Skara, the ability to run a set of sanity build and test jobs on > selected platforms was added. This functionality was driven by > `.github/workflows/submit.yml`. This file unfortunately lacks any real > structure, and

RFR: 8287894: Use fixed timestamp as an alternative of __DATE__ macro in jdk.jdi to make Windows build reproducible

2022-06-07 Thread Alexey Pavlyutkin
Hi! Here is a fix to jdk.jdi that fixes reproducible build for Windows. The idea of the fix is to re-use value of --with-hotspot-build-time option to generate deterministic timestamp exactly like it's done to hotspot component. Verification (Windows-10/MSVS-2019): ```bash ./configure

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v4]

2022-06-07 Thread Leo Korinth
On Tue, 7 Jun 2022 17:48:30 GMT, Ioi Lam wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> wip > > make/RunTests.gmk line 357: > >> 355: $(subst .java,,$(subst .java,,$(suffix $(notdir $1 >> 356: >> 357: #

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v5]

2022-06-07 Thread Leo Korinth
> One can select a testcase by ID when running a jtreg test case directly from > jtreg (using the testcase.java#testID syntax). However, this has not been > possible to do when launching jtreg indirectly from make. > > This fix attempts to address this issue. I have not tested this thoroughly

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v4]

2022-06-07 Thread Ioi Lam
On Tue, 7 Jun 2022 17:39:14 GMT, Leo Korinth wrote: >> One can select a testcase by ID when running a jtreg test case directly from >> jtreg (using the testcase.java#testID syntax). However, this has not been >> possible to do when launching jtreg indirectly from make. >> >> This fix attempts

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make

2022-06-07 Thread Leo Korinth
On Mon, 6 Jun 2022 16:20:18 GMT, Ioi Lam wrote: >> Let me ask the obvious "dumb" question ... why does this have to be so >> complicated? Why isn't the name of the test simply passed through to jtreg >> as typed? > >> Let me ask the obvious "dumb" question ... why does this have to be so >>

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v4]

2022-06-07 Thread Leo Korinth
> One can select a testcase by ID when running a jtreg test case directly from > jtreg (using the testcase.java#testID syntax). However, this has not been > possible to do when launching jtreg indirectly from make. > > This fix attempts to address this issue. I have not tested this thoroughly

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v3]

2022-06-07 Thread Leo Korinth
On Tue, 7 Jun 2022 13:45:47 GMT, Leo Korinth wrote: >> One can select a testcase by ID when running a jtreg test case directly from >> jtreg (using the testcase.java#testID syntax). However, this has not been >> possible to do when launching jtreg indirectly from make. >> >> This fix attempts

Integrated: 8287811: JFR: jfr configure error message should not print stack trace

2022-06-07 Thread Erik Gahlin
On Fri, 3 Jun 2022 15:54:47 GMT, Erik Gahlin wrote: > Could I have a review of PR that removes a printStackTrace() for the jfr > tool. > > Testing: jdk/jfr/tool > > Thanks > Erik This pull request has now been integrated. Changeset: 41d5809c Author:Erik Gahlin URL:

Integrated: 8287745 jni/nullCaller/NullCallerTest.java fails with "exitValue = 1"

2022-06-07 Thread Tim Prinzing
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote: > Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest This pull request has now been integrated. Changeset: 96641c0c Author:Tim Prinzing Committer: Mandy Chung URL:

Re: RFR: 8287745 jni/nullCaller/NullCallerTest.java fails with "exitValue = 1"

2022-06-07 Thread Mandy Chung
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote: > Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest There are a few C++ tests under `test/jdk/java/foreign` as well. - PR: https://git.openjdk.java.net/jdk/pull/9010

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v3]

2022-06-07 Thread Erik Joelsson
On Tue, 7 Jun 2022 13:45:47 GMT, Leo Korinth wrote: >> One can select a testcase by ID when running a jtreg test case directly from >> jtreg (using the testcase.java#testID syntax). However, this has not been >> possible to do when launching jtreg indirectly from make. >> >> This fix attempts

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v3]

2022-06-07 Thread Leo Korinth
On Mon, 6 Jun 2022 07:55:09 GMT, Erik Joelsson wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> wip > > make/RunTests.gmk line 444: > >> 442: $(strip $(foreach parser,ParseCustomTestSelection >>

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v3]

2022-06-07 Thread Leo Korinth
On Tue, 7 Jun 2022 13:45:47 GMT, Leo Korinth wrote: >> One can select a testcase by ID when running a jtreg test case directly from >> jtreg (using the testcase.java#testID syntax). However, this has not been >> possible to do when launching jtreg indirectly from make. >> >> This fix attempts

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v3]

2022-06-07 Thread Leo Korinth
> One can select a testcase by ID when running a jtreg test case directly from > jtreg (using the testcase.java#testID syntax). However, this has not been > possible to do when launching jtreg indirectly from make. > > This fix attempts to address this issue. I have not tested this thoroughly

Re: RFR: 8287745 jni/nullCaller/NullCallerTest.java fails with "exitValue = 1"

2022-06-07 Thread David Holmes
On Mon, 6 Jun 2022 15:56:47 GMT, Tim Prinzing wrote: > The idea was to reduce duplicate code. Changing to use objects to encapsulate > the up calls got rid of a lot of repeated code and made things simpler and > clearer. Objects are created with the class, method, and signature strings > and

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v2]

2022-06-07 Thread Leo Korinth
On Tue, 7 Jun 2022 13:26:52 GMT, Leo Korinth wrote: >> make/RunTests.gmk line 47: >> >>> 45: define IfPrepend >>> 46: $(if $(strip $1),$(strip $2)$(strip $1),) >>> 47: endef >> >> These two probably fits better in make/common/Utils.gmk. >> >> Also please have a look at the [Code Conventions

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v2]

2022-06-07 Thread Leo Korinth
On Mon, 6 Jun 2022 06:50:44 GMT, Erik Joelsson wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> wip > > make/RunTests.gmk line 39: > >> 37: >>

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v2]

2022-06-07 Thread Leo Korinth
> One can select a testcase by ID when running a jtreg test case directly from > jtreg (using the testcase.java#testID syntax). However, this has not been > possible to do when launching jtreg indirectly from make. > > This fix attempts to address this issue. I have not tested this thoroughly

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make

2022-06-07 Thread Leo Korinth
On Sat, 4 Jun 2022 01:51:20 GMT, Leo Korinth wrote: > One can select a testcase by ID when running a jtreg test case directly from > jtreg (using the testcase.java#testID syntax). However, this has not been > possible to do when launching jtreg indirectly from make. > > This fix attempts to

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v9]

2022-06-07 Thread openjdk-notifier[bot]
On Thu, 2 Jun 2022 11:29:58 GMT, Christian Hagedorn wrote: >>> Thanks Thomas for doing the testing! >> >> Hi Christian, >> >> I can see no problems on ppcle attributable to your test. However, I may >> overlook something since tests are still failing all over the place because >> of loom.

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v11]

2022-06-07 Thread Christian Hagedorn
> When printing the native stack trace on Linux (mostly done for hs_err files), > it only prints the method with its parameters and a relative offset in the > method: > > Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x7f6e01838110, free > space=1020k > Native frames: (J=compiled