On Fri, 12 Feb 2021 12:22:09 GMT, Vladimir Kempik wrote:
>> Where did this come from - some snippet/example/tech note code? Maybe other
>> people can help figure it out if we provide more info.
>
> This is the version of w^x on-demand switch implemented by microsoft guys.
> This is enabled
On Wed, 3 Feb 2021 22:48:33 GMT, Gerard Ziemski wrote:
>> I don't like the idea of using masks on architectures that do not require
>> them. How about something like this?
>>
>> `#if defined(__APPLE__)`
>> ` // lldb (gdb) installs both standard BSD signal handlers, and mach
>> exception`
>>
On Wed, 3 Feb 2021 20:29:48 GMT, Gerard Ziemski wrote:
>> Part of the comment said `This work-around is not necessary for 10.5+, as
>> CrashReporter no longer intercedes on caught fatal signals.` so I thought it
>> was no longer needed, but it sounds like the part about `gdb` still applies
>>
On Tue, 2 Feb 2021 18:23:04 GMT, Gerard Ziemski wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> support macos_aarch64 in hsdis
>
> src/hotspot/os/posix/signals_posix.cpp line 1297:
>
>> 1295: kern_return_t kr;
On Mon, 25 Jan 2021 17:43:35 GMT, Phil Race wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Address feedback for signature generators
>> - Enable -Wformat-nonliteral back
>
>
On Tue, 26 Jan 2021 16:07:19 GMT, Vladimir Kempik wrote:
>> src/java.desktop/share/native/libharfbuzz/hb-common.h line 113:
>>
>>> 111:
>>> 112: #define HB_TAG(c1,c2,c3,c4)
>>>
On Mon, 25 Jan 2021 13:30:55 GMT, Vladimir Kempik wrote:
>> make/modules/jdk.hotspot.agent/Lib.gmk line 34:
>>
>>> 32:
>>> 33: else ifeq ($(call isTargetOs, macosx), true)
>>> 34: SA_CFLAGS := -D_GNU_SOURCE -mno-omit-leaf-frame-pointer \
>>
>> Is this really proper for macos-x64? I thought
On Mon, 23 Nov 2020 09:35:40 GMT, Bernhard Urban-Forster
wrote:
> This adds the cross-compiled build only, as no Windows+Arm64 machines are
> available on GitHub Action that we could use to run the tests.
>
> Due to cross-compilation a build JDK is required. Initially I add
re jobs depend on the x64 build first.
>
> Let's see how it works out in the long-run. A Windows+AArch64 build takes
> 40-50min.
Bernhard Urban-Forster has updated the pull request with a new target base due
to a merge or a rebase. The pull request now contains 12 commits:
- remove g
On Tue, 8 Dec 2020 06:59:23 GMT, Aleksey Shipilev wrote:
>> Minor nits.
>
> Also merge from master to get the clean workflow run everywhere?
Thank you @shipilev for your comments, I've updated the PR.
-
PR: https://git.openjdk.java.net/jdk/pull/1379
re jobs depend on the x64 build first.
>
> Let's see how it works out in the long-run. A Windows+AArch64 build takes
> 40-50min.
Bernhard Urban-Forster has updated the pull request incrementally with one
additional commit since the last revision:
merge mistakes
-
Changes:
re jobs depend on the x64 build first.
>
> Let's see how it works out in the long-run. A Windows+AArch64 build takes
> 40-50min.
Bernhard Urban-Forster has updated the pull request with a new target base due
to a merge or a rebase. The pull request now contains ten commits:
- change defaul
On Sat, 5 Dec 2020 01:13:34 GMT, Magnus Ihse Bursie wrote:
>> For the build to work on Windows, we need a unix compatibility layer (known
>> as the "winenv" in the build system). This can be e.g. Cygwin or Msys. The
>> build system then needs to adapt various aspect to get the build to work in
On Sat, 5 Dec 2020 01:13:34 GMT, Magnus Ihse Bursie wrote:
>> For the build to work on Windows, we need a unix compatibility layer (known
>> as the "winenv" in the build system). This can be e.g. Cygwin or Msys. The
>> build system then needs to adapt various aspect to get the build to work in
re jobs depend on the x64 build first.
>
> Let's see how it works out in the long-run. A Windows+AArch64 build takes
> 40-50min.
Bernhard Urban-Forster has updated the pull request with a new target base due
to a merge or a rebase. The pull request now contains six commits:
- todo n
On Mon, 23 Nov 2020 12:37:47 GMT, Magnus Ihse Bursie wrote:
>> .github/workflows/submit.yml line 1367:
>>
>>> 1365: git apply p.patch
>>> 1366: working-directory: jdk
>>> 1367: shell: bash
>>
>> This should be in the mainline repo instead. Yes, the absence of this
On Mon, 23 Nov 2020 12:01:14 GMT, Aleksey Shipilev wrote:
>> This adds the cross-compiled build only, as no Windows+Arm64 machines are
>> available on GitHub Action that we could use to run the tests.
>>
>> Due to cross-compilation a build JDK is required. Initially I added EA
>> builds to be
This adds the cross-compiled build only, as no Windows+Arm64 machines are
available on GitHub Action that we could use to run the tests.
Due to cross-compilation a build JDK is required. Initially I added EA builds
to be downloaded from https://jdk.java.net/16/ and used for that, but then I
On Wed, 18 Nov 2020 13:35:14 GMT, Erik Joelsson wrote:
>> The change from grep to awk in JDK-8244248 and further bug fixed in
>> JDK-8244756 still has invalid syntax. This causes some awk (most notably
>> gawk, the most commonly used) to complain:
>>
>> gawk: cmd. line:1: warning: regexp
Hello Magnus,
Sorry for the late reply! This is awesome work and I don't want to see that to
bit rot :-)
I rebased your changes on top of current master:
https://github.com/openjdk/jdk/compare/master...lewurm:winenv-testing
This branch is by no means ready to be reviewed, it's just whatever
On Thu, 15 Oct 2020 15:00:47 GMT, Bernhard Urban-Forster
wrote:
> Use r18 as allocatable register on Linux only.
>
> A bootstrap works now (it has been crashing before due to r18 being
> allocated):
> $ ./windows-aarch64-server-fastdebug/bin/java.exe
> -XX:+UnlockExperim
On Mon, 2 Nov 2020 20:22:21 GMT, Vladimir Kozlov wrote:
>> Bernhard Urban-Forster has updated the pull request with a new target base
>> due to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull req
On Mon, 2 Nov 2020 19:33:39 GMT, Vladimir Kozlov wrote:
>> Bernhard Urban-Forster has updated the pull request with a new target base
>> due to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull req
On Mon, 2 Nov 2020 17:43:31 GMT, Andrew Haley wrote:
>> https://github.com/openjdk/jdk/pull/1013
>
>> @lewurm
>> This patch seems to break on linux-aarch64 with gcc:
>
> Builds cleanly on Linux/GCC or me.
@theRealAph what gcc version?
I can reproduce with
$ gcc --version
gcc (Ubuntu
On Mon, 2 Nov 2020 16:16:25 GMT, Magnus Ihse Bursie wrote:
>> @magicus I did test the initial version of this PR on linux+arm64, but not
>> the latest iteration. sorry about that
>>
>> What is the policy here? Submit a revert right away or investigate a fix?
>
> @lewurm Open a new JBS issue
On Mon, 2 Nov 2020 15:41:06 GMT, Magnus Ihse Bursie wrote:
>> Thank you Andrew.
>
> @lewurm
> This patch seems to break on linux-aarch64 with gcc:
> open/src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp:1501:52: error:
> comparison of integer expressions of different signedness: 'size_t' {aka
On Mon, 2 Nov 2020 13:41:53 GMT, Andrew Haley wrote:
>> Marked as reviewed by aph (Reviewer).
>
>> Would you mind to sponsor it @theRealAph or @magicus?
>
> Hmm, I think you have to integrate it first.
>
On Tue, 6 Oct 2020 18:09:05 GMT, Bernhard Urban-Forster
wrote:
> I organized this PR so that each commit contains the warning emitted by MSVC
> as commit message and its relevant fix.
>
> Verified on
> * Linux+ARM64: `{hotspot,jdk,langtools}:tier1`, no failures.
> * Window
On Tue, 27 Oct 2020 14:04:04 GMT, Andrew Haley wrote:
>> Bernhard Urban-Forster has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - uppercase suffix
>> - add assert
>
> Marked as reviewed by aph
On Tue, 27 Oct 2020 14:04:04 GMT, Andrew Haley wrote:
>> Bernhard Urban-Forster has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - uppercase suffix
>> - add assert
>
> Marked as reviewed by aph (R
On Sun, 18 Oct 2020 09:07:17 GMT, Magnus Ihse Bursie wrote:
>> Bernhard Urban-Forster has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - uppercase suffix
>> - add assert
>
> Build changes look fin
K 64-Bit Server VM (fastdebug build
> 16-internal+0-adhoc.NORTHAMERICAbeurba.openjdk-jdk, mixed mode)
>
> Jtreg tests `test/hotspot/jtreg/compiler/jvmci` are passing as well.
Bernhard Urban-Forster has updated the pull request with a new target base due
to a merge or a rebase. The incremental
webrev
On Mon, 19 Oct 2020 11:03:46 GMT, Magnus Ihse Bursie wrote:
>> Bernhard Urban-Forster has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - rename argument to canUsePlatformRegister
>> - comment for platformR
K 64-Bit Server VM (fastdebug build
> 16-internal+0-adhoc.NORTHAMERICAbeurba.openjdk-jdk, mixed mode)
>
> Jtreg tests `test/hotspot/jtreg/compiler/jvmci` are passing as well.
Bernhard Urban-Forster has updated the pull request incrementally with two
additional commits since the last revis
On Thu, 15 Oct 2020 17:24:56 GMT, Stuart Monteith wrote:
>> Bernhard Urban-Forster has updated the pull request with a new target base
>> due to a merge or a rebase. The pull request
>> now contains 20 commits:
>> - disable warning only for hotspot
>> - Merge re
On Thu, 15 Oct 2020 09:57:14 GMT, Andrew Haley wrote:
> Fine, but please assert JavaThread::stack_shadow_zone_size() ==
> (int)JavaThread::stack_shadow_zone_size().
Done.
> Adding casts to shut up compilers is a very risky business, because often (if
> not in this case) the programmer
internal macOS+ARM64 port: build without `--disable-warnings-as-errors`
> still works. Just mentioning this here, because
> it's yet another toolchain (Xcode / clang) that needs to be kept happy
> [going
> forward](https://openjdk.java.net/jeps/391).
Bernhard Urban-For
Use r18 as allocatable register on Linux only.
A bootstrap works now (it has been crashing before due to r18 being allocated):
$
./windows-aarch64-server-fastdebug/bin/java.exe
-XX:+UnlockExperimentalVMOptions -XX:+UseJVMCICompiler -XX:+BootstrapJVMCI
-version
Bootstrapping
On Mon, 12 Oct 2020 10:29:23 GMT, Magnus Ihse Bursie wrote:
>> Bernhard Urban-Forster has updated the pull request with a new target base
>> due to a merge or a rebase. The pull request
>> now contains 18 commits:
>> - Merge remote-tracking branch 'upstream/master' into
On Mon, 12 Oct 2020 10:29:11 GMT, Magnus Ihse Bursie wrote:
>> Bernhard Urban-Forster has updated the pull request with a new target base
>> due to a merge or a rebase. The pull request
>> now contains 18 commits:
>> - Merge remote-tracking branch 'upstream/master' into
internal macOS+ARM64 port: build without `--disable-warnings-as-errors`
> still works. Just mentioning this here, because
> it's yet another toolchain (Xcode / clang) that needs to be kept happy
> [going
> forward](https://openjdk.java.net/jeps/391).
Bernhard Urban-Forster has up
internal macOS+ARM64 port: build without `--disable-warnings-as-errors`
> still works. Just mentioning this here, because
> it's yet another toolchain (Xcode / clang) that needs to be kept happy
> [going
> forward](https://openjdk.java.net/jeps/391).
Bernhard Urban-Forster has up
On Tue, 6 Oct 2020 18:09:05 GMT, Bernhard Urban-Forster
wrote:
> I organized this PR so that each commit contains the warning emitted by MSVC
> as commit message and its relevant fix.
>
> Verified on
> * Linux+ARM64: `{hotspot,jdk,langtools}:tier1`, no failures.
> * Window
On Wed, 7 Oct 2020 08:02:59 GMT, Xin Liu wrote:
>> Can you separate LLVM and binutils from hsdis.cpp?
>>
>> I guess you say that the problem is both GCC and binutils are not available
>> on Windows AArch64. Is it right?
>> 1 question: binutils seems to support Windows AArch64. Did you try
On Fri, 25 Sep 2020 12:44:37 GMT, Andrew Haley wrote:
>> Monica Beckwith has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - os_windows: remove duplicated UMA handling
>> - test_safefetch{32,N} works fine on win+aarch64
>
> Marked as
On Mon, 28 Sep 2020 19:28:10 GMT, Vladimir Kempik wrote:
>> The idea is that the naming should suggest that `r18` shouldn't be used on
>> that particular platform. Same is true for
>> macOS, but the ABI docs suggest a different usage, hence we have something
>> like that in our internal branch
On Mon, 28 Sep 2020 17:37:32 GMT, Vladimir Kempik wrote:
>> Monica Beckwith has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now
>> contains 24 commits:
>> - Merge remote-tracking branch 'upstream/master' into jdk-windows
>> - SA: update
On Thu, 24 Sep 2020 15:43:10 GMT, Chris Plummer wrote:
>> Monica Beckwith has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull
>> request contains 17 additional
On Thu, 24 Sep 2020 04:52:22 GMT, David Holmes wrote:
>> Monica Beckwith has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update orderAccess_windows_aarch64.hpp
>>
>> changing from Acq-reL to Sequential Consistency to avoid compiler
On Thu, 24 Sep 2020 04:45:16 GMT, David Holmes wrote:
>> Monica Beckwith has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update orderAccess_windows_aarch64.hpp
>>
>> changing from Acq-reL to Sequential Consistency to avoid compiler
On Mon, 21 Sep 2020 08:15:20 GMT, Bernhard Urban-Forster
wrote:
>> Hey @erikj79, thank you so much for giving it a try!
>>
>>> Our linux-aarch64 build fails with this:
>>> cc: error: unrecognized command line option '-std=c++14'
>>> when compiling
&
On Fri, 18 Sep 2020 18:38:34 GMT, Bernhard Urban-Forster
wrote:
>> Our linux-aarch64 build fails with this:
>> cc: error: unrecognized command line option '-std=c++14'
>> when compiling
>> build/linux-aarch64/buildjdk/hotspot/variant-server/libjvm/objs/precomp
On Fri, 18 Sep 2020 20:34:55 GMT, Erik Joelsson wrote:
> I assume you need the rest of the PATH on Windows.
Doesn't look like it actually. I've reverted it, thanks for catching it.
-
PR: https://git.openjdk.java.net/jdk/pull/212
On Fri, 18 Sep 2020 15:34:26 GMT, Erik Joelsson wrote:
>> Build changes look good to me. I will take this branch for a spin.
>
> Our linux-aarch64 build fails with this:
> cc: error: unrecognized command line option '-std=c++14'
> when compiling
>
Good observation David, the change in adlc is just fixing a symptom. The
difference to a regular macOS build is that technically, despite running on the
same machine, it's actually cross compiling due to Rosetta being the
--build=x86_64 system.
Being a cross-compile, we therefore hit this
55 matches
Mail list logo
