Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v4]

2022-06-07 Thread Leo Korinth
On Tue, 7 Jun 2022 17:48:30 GMT, Ioi Lam wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> wip > > make/RunTests.gmk line 357: > >> 355: $(subst .java,,$(subst .java,,$

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v5]

2022-06-07 Thread Leo Korinth
ose instead. If they do not exist, they might be useful > elsewhere and maybe should be placed in a common make file instead of the > RunTests.gmk file. Leo Korinth has updated the pull request incrementally with one additional commit since the last revision: use test

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make

2022-06-07 Thread Leo Korinth
On Mon, 6 Jun 2022 16:20:18 GMT, Ioi Lam wrote: >> Let me ask the obvious "dumb" question ... why does this have to be so >> complicated? Why isn't the name of the test simply passed through to jtreg >> as typed? > >> Let me ask the obvious "dumb" question ... why does this have to be so >> co

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v4]

2022-06-07 Thread Leo Korinth
ose instead. If they do not exist, they might be useful > elsewhere and maybe should be placed in a common make file instead of the > RunTests.gmk file. Leo Korinth has updated the pull request incrementally with one additional commit since the last revision: wip - Change

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v3]

2022-06-07 Thread Leo Korinth
On Tue, 7 Jun 2022 13:45:47 GMT, Leo Korinth wrote: >> One can select a testcase by ID when running a jtreg test case directly from >> jtreg (using the testcase.java#testID syntax). However, this has not been >> possible to do when launching jtreg indirectly from make. >&g

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v3]

2022-06-07 Thread Leo Korinth
On Mon, 6 Jun 2022 07:55:09 GMT, Erik Joelsson wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> wip > > make/RunTests.gmk line 444: > >> 442: $(strip $(

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v3]

2022-06-07 Thread Leo Korinth
On Tue, 7 Jun 2022 13:45:47 GMT, Leo Korinth wrote: >> One can select a testcase by ID when running a jtreg test case directly from >> jtreg (using the testcase.java#testID syntax). However, this has not been >> possible to do when launching jtreg indirectly from make. >&g

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v3]

2022-06-07 Thread Leo Korinth
ose instead. If they do not exist, they might be useful > elsewhere and maybe should be placed in a common make file instead of the > RunTests.gmk file. Leo Korinth has updated the pull request incrementally with one additional commit since the last revision: wip - Change

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v2]

2022-06-07 Thread Leo Korinth
On Tue, 7 Jun 2022 13:26:52 GMT, Leo Korinth wrote: >> make/RunTests.gmk line 47: >> >>> 45: define IfPrepend >>> 46: $(if $(strip $1),$(strip $2)$(strip $1),) >>> 47: endef >> >> These two probably fits better in make/common/Utils.gmk. >

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v2]

2022-06-07 Thread Leo Korinth
On Mon, 6 Jun 2022 06:50:44 GMT, Erik Joelsson wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> wip > > make/

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v2]

2022-06-07 Thread Leo Korinth
ose instead. If they do not exist, they might be useful > elsewhere and maybe should be placed in a common make file instead of the > RunTests.gmk file. Leo Korinth has updated the pull request incrementally with one additional commit since the last revision: wip - Change

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make

2022-06-07 Thread Leo Korinth
On Sat, 4 Jun 2022 01:51:20 GMT, Leo Korinth wrote: > One can select a testcase by ID when running a jtreg test case directly from > jtreg (using the testcase.java#testID syntax). However, this has not been > possible to do when launching jtreg indirectly from make. > > This

RFR: 8287828: Fix so that one can select jtreg test case by ID from make

2022-06-03 Thread Leo Korinth
One can select a testcase by ID when running a jtreg test case directly from jtreg (using the testcase.java#testID syntax). However, this has not been possible to do when launching jtreg indirectly from make. This fix attempts to address this issue. I have not tested this thoroughly yet, I want

Re: RFR: 8232365: Implementation for JEP 363: Remove the Concurrent Mark Sweep (CMS) Garbage Collector

2019-10-29 Thread Leo Korinth
On 29/10/2019 10:50, Magnus Ihse Bursie wrote: On 2019-10-24 20:03, Leo Korinth wrote: Fixes after suggestions from Coleen, David, Erik, Igor and Kim: http://cr.openjdk.java.net/~lkorinth/8232365/00_01/ (incremental) http://cr.openjdk.java.net/~lkorinth/8232365/01/ (full) Build changes now

Re: RFR: 8232365: Implementation for JEP 363: Remove the Concurrent Mark Sweep (CMS) Garbage Collector

2019-10-22 Thread Leo Korinth
Hi! I will add "cmsgc" like so: DEPRECATED_JVM_FEATURES="trace cmsgc" Should I file a reminder bug for later removal of that feature (I guess not)? If I should, at what version should it be removed? Thanks for finding this! /Leo On 21/10/2019 17:45, Erik Joelsson wrote: On 2019-10-21 02:4

Re: 8200246 : AIX build fails after adjustments of src/hotspot/share/trace/traceEventClasses.xsl

2018-03-28 Thread Leo Korinth
Adding the template parameter to TraceEvent makes xlc happy too. http://cr.openjdk.java.net/~mbaesken/webrevs/8200246/ Are you fine with this change ? Observe that this is not a review. I have tested that your fix should compile on linux, solaris, windows and mac. Thanks, Leo Bes