Hi Martin,
Trivial adaptions. Looks good.
Best regards
Goetz.
From: Doerr, Martin
Sent: Thursday, January 14, 2021 5:50 PM
To: jdk-updates-...@openjdk.java.net; build-dev@openjdk.java.net
Cc: Lindenmaier, Goetz ; Langer, Christoph
Subject: [11u] RFR: 8257633: Missing -mmacosx-version-min=X
HI,
Thanks for the hint! Sounds good, I'll give it a try.
... I removed some emails to reduce traffic.
Best regads,
Goetz.
-Original Message-
From: Ningsheng Jian
Sent: Montag, 7. September 2020 08:51
To: Lindenmaier, Goetz ; Andrew Dinn
; hotspot-compiler-...@openjdk.java.net
Hi
Since that change was pushed, the vm crashes in the build:
To suppress the following error report, specify this argument
# after -XX: or in .hotspotrc: SuppressErrorAt=/type.cpp:1022
#
# A fatal error has been detected by the Java Runtime Environment:
#
# Internal Error (/usr/work/...
Hi,
I didn't get the RFR mails. Probably the known hotspot-dev Mailing List
Problem?
But I saw the RFR in the pipermail archive.
I had a look at the change. It looks good, and
I consider it trivial.
Best regards,
Goetz.
Hi Christoph,
The change looks good. Reviewed.
I think Volker wants to bring the FindFiles/CacheFind change to 11,
which is in the problematic contexts. But I think we should not
wait for that, as this is a oracle parity change. It's trivial to resolve
anyways.
As Severin I think it's fine
Hi,
+1
I think this is a candidate for the label "openjdk-na" then.
Best regards,
Goetz.
> -Original Message-
> From: jdk-updates-dev On
> Behalf Of Langer, Christoph
> Sent: Montag, 9. März 2020 17:29
> To: Erik Joelsson ; jdk-updates-
> d...@openjdk.java.net
> Cc: build-dev
>
Hi Matthias,
change looks good.
The context is different because "8209817: stack is executable when
building with Clang on Linux" is missing in 11. This is a special build fix
for google.
Best regards,
Goetz.
> -Original Message-
> From: jdk-updates-dev On
> Behalf Of Baesken,
a.net>
> Cc: 2d-...@openjdk.java.net; Lindenmaier, Goetz
>
> Subject: Re: RFR [XS]: 8234795: ix build fails on macOS lower than 10.13 after
> 8214578 was: build fails on macOS 10.12 after 8214578: [macos] Problem with
> backslashes on macOS/JIS keyboard: Java ignores system settings
>
mark the test with @key intermittent if it depends
on the system setup that much?
Best regards,
Goetz.
> -Original Message-
> From: Martin Balao
> Sent: Tuesday, May 14, 2019 6:41 PM
> To: Lindenmaier, Goetz ; 'Severin Gehwolf'
> ; Langer, Christoph ;
> jdk-updates-..
019 18:27
> To: Lindenmaier, Goetz ; 'Severin Gehwolf'
> ; Langer, Christoph ; jdk-
> updates-...@openjdk.java.net
> Cc: 2d-dev <2d-...@openjdk.java.net>; build-dev@openjdk.java.net; Martin
> Balao Alonso
> Subject: Re: [11u] java/awt/FontMetrics/MaxAdvanceIsMax.java test
of 11.0.3 and jdk/jdk are scheduled
on a SLES 12.3, therefor they don't show the problem.
I'll send you a jtr file of the failure off-list.
Best regards,
Goetz.
> -Original Message-
> From: Severin Gehwolf
> Sent: Tuesday, May 7, 2019 5:20 PM
> To: Lindenmaier, Goetz ; Lange
Hi Christoph,
I had a look at this change.
The integration is good.
I thought about the adaptions you had to do.
They look good for the compilers you mention, and I
would assume they also work with more recent ones.
I guess nobody uses more recent compilers on Solaris.
On AIX I know further
Looks good to me, thanks for downporting.
Best regards,
Goetz.
> -Original Message-
> From: jdk-updates-dev On
> Behalf Of Langer, Christoph
> Sent: Freitag, 22. März 2019 10:32
> To: Baesken, Matthias ; 'build-
> d...@openjdk.java.net' ; jdk-updates-
> d...@openjdk.java.net
>
looks good, thanks for the adjustment!
Best regards,
Goetz.
> -Original Message-
> From: Baesken, Matthias
> Sent: Dienstag, 5. Februar 2019 17:56
> To: Lindenmaier, Goetz ; David Holmes
> ; 'hotspot-...@openjdk.java.net' d...@openjdk.java.net>; 'magnus.ihse.bur...@o
Hi Matthias,
The demangle fix is kind of preliminary, but to get the compiler
working it is acceptable to skip this code for now.
The old xlc stuff is good to be removed.
Could you please remove USE_XLC_PREFETCH_WRITE_BUILTIN
altogether and replace its only use by USE_XLC_BUILTINS?
Also, I
Pushed.
Best regards,
Goetz
> -Original Message-
> From: Ichiroh Takiguchi
> Sent: Dienstag, 29. Januar 2019 11:30
> To: Lindenmaier, Goetz
> Cc: build-dev ; ppc-aix-port-dev d...@openjdk.java.net>; core-libs-...@openjdk.java.net; Baesken, Matthias
>
> Subj
Hi,
this looks good, the build works with this patch.
Do you need a sponsor?
Best regards,
Goetz.
> -Original Message-
> From: Ichiroh Takiguchi
> Sent: Dienstag, 29. Januar 2019 02:21
> To: Lindenmaier, Goetz
> Cc: build-dev ; ppc-aix-port-dev d...@openjdk.java.
Hi Ichiroh,
just open a bug, like "Fix aix build after 8214533" and post a RFR for it.
I assume the fix is quite trivial so we can review it quick.
Best regards,
Goetz.
> -Original Message-
> From: ppc-aix-port-dev On
> Behalf Of Ichiroh Takiguchi
> Sent: Montag, 28. Januar 2019
Hi Volker,
I had a look at your change. It looks good.
I appreciate a lot you added a check in configure.
Maybe it would be better to pass a WITHOUT_XRANDR
or the like to the build, and check for such a define
in the code.
But I think we should push this change for now to fix the build.
A
Still looks good (now touches much more scenarios, but we should
get this straight.)
Best regards,
Goetz.
> -Original Message-
> From: hotspot-runtime-dev boun...@openjdk.java.net> On Behalf Of Volker Simonis
> Sent: Montag, 8. Oktober 2018 12:11
> To: Doerr, Martin
> Cc: build-dev
Hi Volker, Aleksey,
Voker, your change looks good.
I also think CDS should be turned off on minimal VM,
and also the case for zero a few lines below should
be removed in a similar manner. But I'll leave to you
whether you want to handle that in a separate fix.
Best regards,
Goetz.
>
ag, 4. Oktober 2018 23:01
> To: Lindenmaier, Goetz
> Cc: hotspot-dev developers ; build-dev
> ; core-libs-...@openjdk.java.net
> Subject: Re: JEP JDK-8208089: Implement C++14 Language Features
>
> > On Oct 4, 2018, at 2:59 AM, Lindenmaier, Goetz
> wrote:
> >
> > Hi,
> &
Thanks!
I'm fine for this to go to 8.
Best regards,
Goetz.
> -Original Message-
> From: Severin Gehwolf
> Sent: Donnerstag, 4. Oktober 2018 16:40
> To: Lindenmaier, Goetz ; Erik Joelsson
> ; hotspot-dev d...@openjdk.java.net>; ppc-aix-port-dev d...@openjdk.ja
Hi,
I appreciate this is handled in a JEP and well communicated!
XLc, the compiler we use for AIX, might be a bottleneck here.
But we currently have no compiler-constraints by products on
our aix port of jdk12 (for jdk11 we must stay with the current
compiler xlc 12 which does not support
nal Message-
> From: Severin Gehwolf
> Sent: Dienstag, 2. Oktober 2018 15:00
> To: Lindenmaier, Goetz ; Erik Joelsson
> ; hotspot-dev d...@openjdk.java.net>; ppc-aix-port-dev d...@openjdk.java.net>; build-dev
> Subject: Re: [PING] [8u] RFR: 8073139: PPC64: Use
. Oktober 2018 13:09
> To: Lindenmaier, Goetz ; Erik Joelsson
> ; hotspot-dev d...@openjdk.java.net>; ppc-aix-port-dev d...@openjdk.java.net>; build-dev
> Subject: Re: [PING] [8u] RFR: 8073139: PPC64: User-visible arch directory and
> os.arch value on ppc64le cause issues with
Hi,
I'm fine with this.
If I remember correctly, this was proposed before but
never pushed in the end.
Did you test this on ppc64 be, too?
Best regards,
Goetz.
> -Original Message-
> From: ppc-aix-port-dev On
> Behalf Of Severin Gehwolf
> Sent: Dienstag, 2. Oktober 2018 12:34
>
Hi,
We are only talking about reducing O3 to O2 for the compilation
step of fdlibm, right?
As I know, this is being replaced by Java coding, anyways.
Therefore I don't have a strong opinion for any of the
choices.
Best regards,
Goetz.
> -Original Message-
> From: core-libs-dev On
Yes, that's fine.
I can sponsor it tomorrow. I'm not in the office today.
Best regards,
Goetz.
> -Original Message-
> From: Andrew Leonard
> Sent: Donnerstag, 6. September 2018 12:29
> To: Magnus Ihse Bursie ; Lindenmaier, Goetz
>
> Cc: 2d-dev <2d-...@ope
: Freitag, 31. August 2018 12:07
> To: Lindenmaier, Goetz ; hotspot compiler
> ; build-dev (build-
> d...@openjdk.java.net)
> Subject: Re: Configure: Does enabling graal automatically disable cmsgc?
>
> On 2018-08-31 11:39, Lindenmaier, Goetz wrote:
> > Hi,
> >
>
Hi,
I'm just fixing jtreg/runtime/appcds/sharedStrings/IncompatibleOptions.java
It is not checking correctly whether ZGC is enabled.
I found this code in the test:
if (!Compiler.isGraalEnabled()) { // Graal does not support CMS
testExec(8, "-XX:+UseConcMarkSweepGC", "", "", false);
}
I
Hi,
https://wiki.openjdk.java.net/display/Build/Supported+Build+Platforms
is quite outdated, listing only jdk9.
Is there a different site now listing this information?
(I'll also update our information on this site.)
Because of https://bugs.openjdk.java.net/browse/JDK-8210194
we think about
Hi Leonard,
Whom should I add as reviewers? (Besides me :))
Best regards,
Goetz.
> -Original Message-
> From: Andrew Leonard
> Sent: Donnerstag, 30. August 2018 17:02
> To: Lindenmaier, Goetz
> Cc: Brian Burkhalter ; build-dev (build-
> d...@openjdk.java.net
Hi Leonard,
the change looks good to me.
I'll test it tonight, to make sure it runs with our compilers.
Did you run it through jdk-submit?
If you supply a patch with all the changeset information (like
from hg export) that jchecks fine, I'll sponsor this for you.
Best regards,
Goetz.
>
-...@openjdk.java.net' ;
'build-dev@openjdk.java.net'
Cc: Lindenmaier, Goetz ; Doerr, Martin
Subject: RFR : 8210205 : build fails on AIX in hotspot cpp tests (for example
getstacktr001.cpp)
Hello, please review this small fix to repair our AIX build .
Recent changes to jdk/jdk broke
Thanks Erik!
Best regards,
Goetz.
> -Original Message-
> From: Erik Joelsson
> Sent: Donnerstag, 19. Juli 2018 19:33
> To: Vladimir Kozlov ; Lindenmaier, Goetz
> ; hotspot-dev developers d...@openjdk.java.net>
> Cc: build-dev
> Subject: Re: 8207830: [a
other part is unchanged.
Best regards,
Goetz.
> -Original Message-
> From: Vladimir Kozlov
> Sent: Thursday, July 19, 2018 7:22 PM
> To: Lindenmaier, Goetz ; hotspot-dev
> developers
> Cc: build-dev
> Subject: Re: 8207830: [aix] disable jfr in build and tests
Hi Thomas,
thanks for fixing and doing the cleanup right away.
Looks good.
Best regards,
Goetz.
> -Original Message-
> From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-
> boun...@openjdk.java.net] On Behalf Of Thomas Stüfe
> Sent: Mittwoch, 13. Juni 2018 08:14
> To: build-dev ;
Hi Thomas,
this looks good and will simplify building on AIX.
Thanks,
Goetz.
> -Original Message-
> From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-
> boun...@openjdk.java.net] On Behalf Of Thomas Stüfe
> Sent: Donnerstag, 26. April 2018 16:04
> To: build-dev
Thanks Magnus and Volker!
Best regards,
Goetz.
> -Original Message-
> From: Magnus Ihse Bursie [mailto:magnus.ihse.bur...@oracle.com]
> Sent: Montag, 16. April 2018 14:56
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; build-dev (build-
> d...@openjdk
ontag, 16. April 2018 14:00
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; build-dev (build-
> d...@openjdk.java.net) <build-dev@openjdk.java.net>
> Subject: Re: RFR(XS): 8201584: Fix configure on SLES 11 after 8201483
>
> On 2018-04-16 11:16, Lindenmaier, Goetz wrote
Hi,
could I please get reviewes for this tiny fix?
Grep does not grok the syntax of the replacement of space to newline.
It causes configure failures on SLES 11.
http://cr.openjdk.java.net/~goetz/wr18/8201584-fixSLES11configure/01/
Best regards,
Goetz.
HI Thomas,
looks good, thanks!
Best regards,
Goetz.
> -Original Message-
> From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-
> boun...@openjdk.java.net] On Behalf Of Thomas Stüfe
> Sent: Donnerstag, 8. Februar 2018 15:42
> To: ppc-aix-port-...@openjdk.java.net; build-dev
Hi Lance,
Would you mind to add similar change as for
test/jdk/tools/launcher/VersionCheck.java
also for
test/jdk/tools/launcher/HelpFlagsTest.java
That test is pretty recent which is why you may have missed it.
It will not fail though, there will just be left over stuff in it.
Best regards,
Hi Steve,
I think this is an error.
We never decided not to generate a jre image as far as I know.
Best regards,
Goetz.
> -Original Message-
> From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-
> boun...@openjdk.java.net] On Behalf Of Steve Groeger
> Sent: Mittwoch, 18. Oktober 2017
ebrev is just rebased to the new repo.
>
> I am unclear whether I am allowed to push this on my own? Does the build
> group this?
>
> Kind Regards, Thomas
>
>
> On Thu, Sep 7, 2017 at 2:33 PM, Thomas Stüfe <thomas.stu...@gmail.com
> <mailto:thomas.stu...@gmail.com&
Hi David,
thanks a lot!
Best regards,
Goetz.
> -Original Message-
> From: David Holmes [mailto:david.hol...@oracle.com]
> Sent: Dienstag, 26. September 2017 05:29
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; hotspot-runtime-
> d...@openjdk.java.net;
Hi,
I updated my webrev to the directory structure:
http://cr.openjdk.java.net/~goetz/wr17/8187045-execstackLink/webrev.02/
I also ran it through our tests again.
Could someone please sponsor this change?
Thanks,
Goetz.
> -Original Message-
> From: Lindenmaier, Goetz
Hi Thomas,
Looks good.
Best regards,
Goetz.
> -Original Message-
> From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-
> boun...@openjdk.java.net] On Behalf Of Thomas Stüfe
> Sent: Donnerstag, 7. September 2017 12:02
> To: ppc-aix-port-...@openjdk.java.net; build-dev
Hi David,
thanks for looking at my change!
> Hi Goetz,
>
> On 1/09/2017 11:05 PM, Lindenmaier, Goetz wrote:
> > Hi,
> >
> > I found that not all libraries are linked with -z,noexecstack.
> > This lead to errors with our linuxppc64 build. The linker omitt
Hi David,
thanks for sponsoring the change!
Best regards,
Goetz.
> -Original Message-
> From: David Holmes [mailto:david.hol...@oracle.com]
> Sent: Donnerstag, 31. August 2017 23:15
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; 'Magnus Ihse Bursie'
regards,
Goetz.
> -Original Message-
> From: Magnus Ihse Bursie [mailto:magnus.ihse.bur...@oracle.com]
> Sent: Montag, 4. September 2017 10:42
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; hotspot-runtime-
> d...@openjdk.java.net; build-dev <build-dev@openjdk
age-
> From: Magnus Ihse Bursie [mailto:magnus.ihse.bur...@oracle.com]
> Sent: Thursday, August 31, 2017 3:35 PM
> To: David Holmes <david.hol...@oracle.com>; Lindenmaier, Goetz
> <goetz.lindenma...@sap.com>; hotspot-runtime-...@openjdk.java.net;
> build-dev (build-de
Hi,
Tests for class data sharing (cds) are enabled if @requires vm.cds is true.
The property vm.cds depends on the preprocessor macro ENABLE_CDS.
This can not yet be switched by configure. It's only disabled automatically
for the minimal build.
This change introduces enable-cds with default
Ah, ok, so this is fine.
Best regards,
Goetz.
> -Original Message-
> From: Erik Joelsson [mailto:erik.joels...@oracle.com]
> Sent: Montag, 21. November 2016 14:27
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; Vladimir Kozlov
> <vladimir.koz...@oracle.co
nal Message-
> From: Lindenmaier, Goetz
> Sent: Montag, 21. November 2016 12:35
> To: 'Vladimir Kozlov' <vladimir.koz...@oracle.com>; Erik Joelsson
> <erik.joels...@oracle.com>; build-dev <build-dev@openjdk.java.net>;
> core-libs-dev <core-libs-...@openjdk.java.
Hi,
we appreciate this change a lot, and also if /server would go away.
I built and tested it on linuxppcle, aixppc and linuxs390.
There is still a place that refers to a removed variables
and breaks the build:
jdk/src/java.base/unix/native/libjli/ergo.c:94 LIBARCHNAME
You can probably just
Kozlov [mailto:vladimir.koz...@oracle.com]
> Sent: Thursday, October 13, 2016 1:09 AM
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; Volker Simonis
> <volker.simo...@gmail.com>
> Cc: s390x-port-...@openjdk.java.net; porters-...@openjdk.java.net; build-
> dev <build
13, 2016 8:32 AM
> To: Vladimir Kozlov <vladimir.koz...@oracle.com>
> Cc: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; s390x-port-
> d...@openjdk.java.net; porters-...@openjdk.java.net; build-dev d...@openjdk.java.net>; HotSpot Open Source Developers d...@openjdk.jav
Hi Vladimir,
This webrev contains all the changes to hotspot needed for the port:
http://cr.openjdk.java.net/~goetz/wr16/8166730-linuxs390-all/hotspot.wr01/
It includes
http://cr.openjdk.java.net/~goetz/wr16/8166560-basic_s390/hotspot.wr03/
Hi Volker,
I had a look at your changes. Good that 'warning as errors' already
lead to a fix :)
Note that your changes might break the old build, as you remove the
endianess check in flags.m4 etc.. I think this is ok, though, as else dead code
will remain in the file.
Looks good, reviewed.
Hi Andrew,
I know about this problem ... I guess a change of mine causes these warnings.
While I found a row of good fixes, these with ShouldNotReachHere are annoying.
What you propose has been discussed in April: 8065585: Change
ShouldNotReachHere() to never return.
I didn't follow the
Hi David,
this change is good, I appreciate it a lot!
Best regards,
Goetz.
-Original Message-
From: hotspot-dev [mailto:hotspot-dev-boun...@openjdk.java.net] On Behalf Of
David Holmes
Sent: Montag, 6. Juli 2015 11:11
To: hotspot-dev developers; build-dev
Subject: (XXS)RFR: 8076581:
Hi,
builds and runs on ppc linux be / aix.
Best regards,
Goetz.
-Original Message-
From: Alexander Smundak [mailto:asmun...@google.com]
Sent: Monday, March 24, 2014 9:10 PM
To: David Holmes
Cc: Lindenmaier, Goetz; build-dev; HotSpot Open Source Developers
Subject: Re: RFR (M
Hi Sasha,
I tried to test your change (02), but it does not work.
On linux ppc be;) I get
make[4]: Leaving directory
`/net/usr.work/d045726/oJ/builds/8036767-comp-ld9502-dbg/linux_ppc64_compiler2/debug'
make[4]: Entering directory
-
From: David Holmes [mailto:david.hol...@oracle.com]
Sent: Friday, March 21, 2014 12:08 PM
To: Lindenmaier, Goetz; 'Alexander Smundak'
Cc: 'build-dev'; 'HotSpot Open Source Developers'
Subject: Re: RFR (M): 8036767 PPC64: Support for little endian execution model
On 21/03/2014 7:06 PM, Lindenmaier
' was
compared
with 'big'. Make is strange ...
After fixing that, tested linuxppc64, aix and linuxx86_64, they all work.
Best regards,
Goetz.
-Original Message-
From: Alexander Smundak [mailto:asmun...@google.com]
Sent: Friday, March 21, 2014 10:02 PM
To: Lindenmaier, Goetz
Cc: David Holmes
of a different build path.
Best regards,
Goetz.
-Original Message-
From: Vladimir Kozlov [mailto:vladimir.koz...@oracle.com]
Sent: Tuesday, March 18, 2014 2:36 AM
To: Lindenmaier, Goetz; Magnus Ihse Bursie; David Holmes
Cc: build-dev; HotSpot Open Source Developers; Alexander Smundak
Hi Magnus,
The change keeps target cpu and target cpu arch as is. The C-code uses
-DLITTLE_ENDIAN to distinguish implementation differences.
As I understand, we discuss the setting of BUILDARCH in the makefiles.
Indirectly it is set from uname, which returns ppc64le on these machines.
This
Hi,
having said what I wanted to say about the build output directory path,
I'm fine with both solutions. In the end it affects only a few line
in shared make files.
Best regards,
Goetz
-Original Message-
From: hotspot-dev [mailto:hotspot-dev-boun...@openjdk.java.net] On Behalf Of
70 matches
Mail list logo
