Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v5]

2022-06-08 Thread Magnus Ihse Bursie
On Tue, 7 Jun 2022 18:15:30 GMT, Leo Korinth wrote: >> One can select a testcase by ID when running a jtreg test case directly from >> jtreg (using the testcase.java#testID syntax). However, this has not been >> possible to do when launching jtreg indirectly from make. >> >> This fix attempts

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v5]

2022-06-08 Thread Erik Joelsson
On Tue, 7 Jun 2022 18:15:30 GMT, Leo Korinth wrote: >> One can select a testcase by ID when running a jtreg test case directly from >> jtreg (using the testcase.java#testID syntax). However, this has not been >> possible to do when launching jtreg indirectly from make. >> >> This fix attempts

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v4]

2022-06-07 Thread Leo Korinth
On Tue, 7 Jun 2022 17:48:30 GMT, Ioi Lam wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> wip > > make/RunTests.gmk line 357: > >> 355: $(subst .java,,$(subst .java,,$(suffix $(notdir $1 >> 356: >> 357: # T

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v5]

2022-06-07 Thread Leo Korinth
> One can select a testcase by ID when running a jtreg test case directly from > jtreg (using the testcase.java#testID syntax). However, this has not been > possible to do when launching jtreg indirectly from make. > > This fix attempts to address this issue. I have not tested this thoroughly >

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v4]

2022-06-07 Thread Ioi Lam
On Tue, 7 Jun 2022 17:39:14 GMT, Leo Korinth wrote: >> One can select a testcase by ID when running a jtreg test case directly from >> jtreg (using the testcase.java#testID syntax). However, this has not been >> possible to do when launching jtreg indirectly from make. >> >> This fix attempts

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make

2022-06-07 Thread Leo Korinth
On Mon, 6 Jun 2022 16:20:18 GMT, Ioi Lam wrote: >> Let me ask the obvious "dumb" question ... why does this have to be so >> complicated? Why isn't the name of the test simply passed through to jtreg >> as typed? > >> Let me ask the obvious "dumb" question ... why does this have to be so >> co

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v4]

2022-06-07 Thread Leo Korinth
> One can select a testcase by ID when running a jtreg test case directly from > jtreg (using the testcase.java#testID syntax). However, this has not been > possible to do when launching jtreg indirectly from make. > > This fix attempts to address this issue. I have not tested this thoroughly >

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v3]

2022-06-07 Thread Leo Korinth
On Tue, 7 Jun 2022 13:45:47 GMT, Leo Korinth wrote: >> One can select a testcase by ID when running a jtreg test case directly from >> jtreg (using the testcase.java#testID syntax). However, this has not been >> possible to do when launching jtreg indirectly from make. >> >> This fix attempts

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v3]

2022-06-07 Thread Erik Joelsson
On Tue, 7 Jun 2022 13:45:47 GMT, Leo Korinth wrote: >> One can select a testcase by ID when running a jtreg test case directly from >> jtreg (using the testcase.java#testID syntax). However, this has not been >> possible to do when launching jtreg indirectly from make. >> >> This fix attempts

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v3]

2022-06-07 Thread Leo Korinth
On Mon, 6 Jun 2022 07:55:09 GMT, Erik Joelsson wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> wip > > make/RunTests.gmk line 444: > >> 442: $(strip $(foreach parser,ParseCustomTestSelection >> ParseGtestTestSelec

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v3]

2022-06-07 Thread Leo Korinth
On Tue, 7 Jun 2022 13:45:47 GMT, Leo Korinth wrote: >> One can select a testcase by ID when running a jtreg test case directly from >> jtreg (using the testcase.java#testID syntax). However, this has not been >> possible to do when launching jtreg indirectly from make. >> >> This fix attempts

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v3]

2022-06-07 Thread Leo Korinth
> One can select a testcase by ID when running a jtreg test case directly from > jtreg (using the testcase.java#testID syntax). However, this has not been > possible to do when launching jtreg indirectly from make. > > This fix attempts to address this issue. I have not tested this thoroughly >

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v2]

2022-06-07 Thread Leo Korinth
On Tue, 7 Jun 2022 13:26:52 GMT, Leo Korinth wrote: >> make/RunTests.gmk line 47: >> >>> 45: define IfPrepend >>> 46: $(if $(strip $1),$(strip $2)$(strip $1),) >>> 47: endef >> >> These two probably fits better in make/common/Utils.gmk. >> >> Also please have a look at the [Code Conventions f

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v2]

2022-06-07 Thread Leo Korinth
On Mon, 6 Jun 2022 06:50:44 GMT, Erik Joelsson wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> wip > > make/RunTests.gmk line 39: > >> 37: >> ###

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v2]

2022-06-07 Thread Leo Korinth
> One can select a testcase by ID when running a jtreg test case directly from > jtreg (using the testcase.java#testID syntax). However, this has not been > possible to do when launching jtreg indirectly from make. > > This fix attempts to address this issue. I have not tested this thoroughly >

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make

2022-06-07 Thread Leo Korinth
On Sat, 4 Jun 2022 01:51:20 GMT, Leo Korinth wrote: > One can select a testcase by ID when running a jtreg test case directly from > jtreg (using the testcase.java#testID syntax). However, this has not been > possible to do when launching jtreg indirectly from make. > > This fix attempts to ad

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make

2022-06-06 Thread Ioi Lam
On Mon, 6 Jun 2022 10:48:05 GMT, David Holmes wrote: > Let me ask the obvious "dumb" question ... why does this have to be so > complicated? Why isn't the name of the test simply passed through to jtreg as > typed? Is it because `#` is treated as comment by the shell? Could it be encoded by s

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make

2022-06-06 Thread David Holmes
On Sat, 4 Jun 2022 01:51:20 GMT, Leo Korinth wrote: > One can select a testcase by ID when running a jtreg test case directly from > jtreg (using the testcase.java#testID syntax). However, this has not been > possible to do when launching jtreg indirectly from make. > > This fix attempts to ad

Re: RFR: 8287828: Fix so that one can select jtreg test case by ID from make

2022-06-06 Thread Erik Joelsson
On Sat, 4 Jun 2022 01:51:20 GMT, Leo Korinth wrote: > One can select a testcase by ID when running a jtreg test case directly from > jtreg (using the testcase.java#testID syntax). However, this has not been > possible to do when launching jtreg indirectly from make. > > This fix attempts to ad

RFR: 8287828: Fix so that one can select jtreg test case by ID from make

2022-06-03 Thread Leo Korinth
One can select a testcase by ID when running a jtreg test case directly from jtreg (using the testcase.java#testID syntax). However, this has not been possible to do when launching jtreg indirectly from make. This fix attempts to address this issue. I have not tested this thoroughly yet, I want