Hello, I checked the zlib config settings and found the following :
make/autoconf/lib-bundled.m4 states :
# Setup bundled libraries.
#
# For libjpeg, giflib, libpng, lcms2 and zlib, the source is present in the
#
>
> Looks good, thanks!
>
> /Erik
>
> On 2019-05-14 03:16, Baesken, Matthias wrote:
> > Hi Erik, here is the updated webrev :
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8130017.2/
> >
> >
> > Best regards, Matthias
> >
> &
Hi Erik, here is the updated webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8130017.2/
Best regards, Matthias
> -Original Message-
> From: Erik Joelsson
> Sent: Freitag, 10. Mai 2019 16:29
> To: Baesken, Matthias ; David Holmes
> ; 'build-dev@openj
Hello, I wonder if some people already have looked into using Windows
"control flow guard" in OpenJDK,
and can share the info they got.
See :
https://docs.microsoft.com/en-us/windows/desktop/SecBP/control-flow-guard
"Control Flow Guard (CFG) is a highly-optimized platform security feature
Hello, please review this small AIX - specific change .
Currently we use by default the bundled zlib (= zlib coming with OpenJDK) on
Windows, on other platforms the system zlib.
However it is possible to switch to the bundled zlib in the configure process .
We had some build issues on AIX
(with our internally used gcc's we are always > 4.6 in jdk/jdk )
Best regards, Matthias
> -Original Message-
> From: Erik Joelsson
> Sent: Donnerstag, 9. Mai 2019 15:18
> To: Baesken, Matthias ; David Holmes
> ; 'build-dev@openjdk.java.net' d...@openjdk.java.net>
&
Thanks !
Great you found more info in the good old redbook.
Best regards , Matthias
From: Doerr, Martin
Sent: Donnerstag, 9. Mai 2019 16:04
To: Baesken, Matthias ;
ppc-aix-port-...@openjdk.java.net; build-dev@openjdk.java.net
Cc: Steve Groeger
Subject: RE: FW: RFR: 8223307: enable the Stack
ias,
>
> On 2019-05-08 06:27, Baesken, Matthias wrote:
> > Hello,I looked a bit more into it .
> > It seems to me , that when -ffp-contract=off is available which is
> > the
> case with current gcc versions , we want to optimize the 2 special f
; unrelated to my change ; I noticed that already in OpenJDK 11 ).
>
>
> Best regards, Matthias
>
>
>
>
> >
> > Hi Matthias,
> >
> > On 8/05/2019 6:05 pm, Baesken, Matthias wrote:
> > > Hello, here is a webrev, I used the existing bug
gt; Hi Matthias,
>
> On 8/05/2019 6:05 pm, Baesken, Matthias wrote:
> > Hello, here is a webrev, I used the existing bug
> > "JDK-8130017 : use _FORTIFY_SOURCE in gcc fastdebug builds"
> >
> > Hope that’s fine .
>
> That is fine, but please add a c
4, ppc64le , s390x) fastdebug
builds are fine with the added flag .
Best Regards, Matthias
> -Original Message-
> From: Baesken, Matthias
> Sent: Dienstag, 7. Mai 2019 16:55
> To: 'Erik Joelsson' ; 'build-
> d...@openjdk.java.net'
> Cc: 'Kim Barrett' ; Zeller
of this.
FILE* pfile = posix::FOpen(premature_exit_filepath, "w");
- fwrite("0", 1, 1, pfile);
+ size_t cnt= fwrite("0", 1, 1, pfile);
+ assert(cnt == (size_t)1);
fclose(pfile);
}
}
> -Original Message-
> From: Erik Joelsson
>
Hello Kim and Erik, thanks for pointing me at
https://bugs.openjdk.java.net/browse/JDK-8050803
https://bugs.openjdk.java.net/browse/JDK-8130017
I noticed too that the flag needs to be set together with optimization flags
(which is pointed out in these 2 bugs).
Performance seems to be not
Hello.
maybe some of you are aware of the gcc FORTIFY_SOURCE application security
flags.
Developers can enable compile and also runtime checks for some string / memory
related operations with the flag.
See details :
https://access.redhat.com/blogs/766093/posts/1976213
Have you tried
ev :
https://bugs.openjdk.java.net/browse/JDK-8223307
http://cr.openjdk.java.net/~mbaesken/webrevs/8223307.0/
Thanks, Matthias
> -Original Message-
> From: Erik Joelsson
> Sent: Freitag, 12. April 2019 15:30
> To: Baesken, Matthias ; ppc-aix-port-
> d...@openjdk.java.net; 'build-de
Hi Severin, looks okay to me (not a reviewer however).
In our proprietary JVM8 we hadset (on Linux)
BUILD_LIBFDLIBM_OPTIMIZATION := HIGH and FDLIBM_CFLAGS +=
-ffp-contract=offfor a long time and did not observe any issues .
(but we always build with gcc 4.8.x so cannot
16:18
To: Baesken, Matthias ;
ppc-aix-port-...@openjdk.java.net; 'build-dev@openjdk.java.net'
Subject: RE: AIX : -bnorwexec linker flag
Hi
Maybe that the patch is good, but the original code, though working fine, is
bad.
--- a/make/autoconf/flags-ldflags.m4
-BASIC_LDFLAGS="
Thanks !
Let's see what other AIX developers say about it .
Best regards, Matthias
> -Original Message-
> From: Erik Joelsson
> Sent: Freitag, 12. April 2019 15:30
> To: Baesken, Matthias ; ppc-aix-port-
> d...@openjdk.java.net; 'build-dev@openjdk.java.net' d...@o
Hello, I have a question regarding the AIX -bnorwexec linker flag .
I think it is related to an AIX security feature SED , see also :
https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.aix.security/stack_exec_disable_flags.htm
When building with the additional -bnorwexec
Hi Christoph / Götz , thanks for the reviews !
Best Regards, Matthias
> -Original Message-
> From: Lindenmaier, Goetz
> Sent: Freitag, 22. März 2019 11:08
> To: Langer, Christoph ; Baesken, Matthias
> ; 'build-dev@openjdk.java.net' d...@openjdk.java.ne
ybe you ping me, when
> you're going to push, then we can check things together
Sure, good idea .
Best regards, Matthias
> -Original Message-
> From: Langer, Christoph
> Sent: Freitag, 22. März 2019 10:32
> To: Baesken, Matthias ; 'build-
> d...@openjd
Hello, please review this change.
It is a downport of jdk13 change
https://bugs.openjdk.java.net/browse/JDK-8215710 to 11u .
JDK-8215710 removed the disabling of C99 on Solaris in jdk13.
Reason was :
"Currently we disable C99 in the Solaris build by setting -xc99=%none%.
This differs
Looks good (not a Reviewer however).
One minor comment :
The old documentation mentioned an exact XLC version ( AIX, V12.1
(5765-J02, 5725-C72) Version: 12.01..0017) .
Maybe we have to be so specific as well on the build wiki page, to avoid
people running into "bad" compiler
Hi Erik, thanks for the comment .
New webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8219920.2/
May I add you and Magnus as reviewers ?
Best regards, Matthias
> -Original Message-
> From: Erik Joelsson
> Sent: Montag, 4. März 2019 18:21
> To: Baesken, Matthias ;
://cr.openjdk.java.net/~mbaesken/webrevs/8219920.1/
Best regards, Matthias
From: Baesken, Matthias
Sent: Freitag, 1. März 2019 15:17
To: 'Magnus Ihse Bursie' ;
'build-dev@openjdk.java.net'
Cc: Simonis, Volker ; Zeller, Arno
Subject: RE: RFR: 8219920: dependency help output in configure-step : support
zypper
. For the
jdk/jdk it probably does not make much sense and the URLs are the way to go .
Best regards, Matthias
From: Magnus Ihse Bursie
Sent: Freitag, 1. März 2019 14:46
To: Baesken, Matthias ; 'build-dev@openjdk.java.net'
Cc: Simonis, Volker ; Zeller, Arno
Subject: Re: RFR: 8219920: dependency help
could try to test on a fresh OpenSUSE .
Best regards,
Matthias
From: Magnus Ihse Bursie
Sent: Freitag, 1. März 2019 14:44
To: Baesken, Matthias ; 'build-dev@openjdk.java.net'
Cc: Simonis, Volker ; Zeller, Arno
Subject: Re: RFR: 8219920: dependency help output in configure-step
Hi Phil , are you aware of any minimum compiler version requirements coming
with HarfBuzz 2.3.1 ?
Best regards, Matthias
> From: Philip Race
> To: 2d-dev <2d-...@openjdk.java.net>, build-dev
>
> Subject: RFR: 8210782: Upgrade HarfBuzz to the latest 2.3.1
> Message-ID:
stall openjdk-8-jdk" ;;
96 alsa)
97 PKGHANDLER_COMMAND="sudo apt-get install libasound2-dev" ;;
I think we would need jdk11 by now (or soon jdk12, but I am not sure
about package availability at the various distros for 12).
Best regards, Matthias
From: Ba
Hello, please review the following change .
Currently the configure-step outputs help for a number of packages +
related installation calls in case of missing dependencies (like cups / alsa
etc.) .
This help output step covers a few tools (like apt-get).
However the OpenSUSE /
uction of the C++11/14 features in the
code base .
New webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8218965.1/
Best Regards, Matthias
From: Magnus Ihse Bursie
Sent: Montag, 18. Februar 2019 11:18
To: Baesken, Matthias ; 'build-dev@openjdk.java.net'
Cc: Doerr, Martin
Subj
mes
).
Best regards, Matthias
> -Original Message-
> From: Magnus Ihse Bursie
> Sent: Freitag, 15. Februar 2019 13:32
> To: Baesken, Matthias ; 'build-
> d...@openjdk.java.net'
> Cc: Doerr, Martin
> Subject: Re: RFR : 8218965: aix: support xlclang++ in the compiler
01..0001
(and some-strange-hex-string is the same for both)
Best regards, Matthias
> -Original Message-
> From: Magnus Ihse Bursie
> Sent: Freitag, 15. Februar 2019 12:37
> To: Baesken, Matthias ; 'build-
> d...@openjdk.java.net'
> Subject: Re: RFR :
Hi Magnus , I think it is not a separate toolchain , just another compiler
frontend offered by the xlc toolchain of xlc16 .
Our current toolchains are :
# These toolchains are valid on different platforms
VALID_TOOLCHAINS_linux="gcc clang"
VALID_TOOLCHAINS_solaris="solstudio"
Hello,
please review this small change .
On AIX, it adds detection of xlc16 / clangto the build environment.
The xlc16 package contains 2 compiler frontends :
* The legacy xlc
* The new clang-based xlclang++
For older xlc (12 / 13) we should for now still support
Thanks .
A second review would be great .
Best regards, Matthias
> -Original Message-
> From: Magnus Ihse Bursie
> Sent: Mittwoch, 6. Februar 2019 17:38
> To: Baesken, Matthias ; 'hotspot-
> d...@openjdk.java.net' ; 'build-
> d...@openjdk.java.net'
> Subject: R
Hello, please review this small change .
I noticed (when looking into AIX xlc16 / xlclang++) the following:in the
case that clang is used for compilation,HOTSPOT_BUILD_COMPILER claims to
be a gcc .
This is a bit misleading.
This change adjusts the setting for clang usage on AIX
Thank's Götz !
David + Magnus may I add you as reviewers ?
Best regards, Matthias
> -Original Message-
> From: Lindenmaier, Goetz
> Sent: Dienstag, 5. Februar 2019 18:05
> To: Baesken, Matthias ; David Holmes
> ; 'hotspot-...@openjdk.java.net' d...@openjdk.java.net>
> From: Lindenmaier, Goetz
> Sent: Dienstag, 5. Februar 2019 09:59
> To: Baesken, Matthias ; David Holmes
> ; 'hotspot-...@openjdk.java.net' d...@openjdk.java.net>; 'magnus.ihse.bur...@oracle.com'
>
> Cc: 'build-dev@openjdk.java.net'
> Subject: RE: RFR : 8218136: minor h
10).
New webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8218136.2/
Best regards, Matthias
> -Original Message-
> From: David Holmes
> Sent: Freitag, 1. Februar 2019 13:49
> To: Baesken, Matthias ; 'hotspot-
> d...@openjdk.java.net' ;
> 'magnus.ihse.bur...@orac
New webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8218136.1/
- adjusted globalDefinitions_xlc.hpp
- fixed some copyright years
Best regards, Matthias
> -Original Message-
> From: Baesken, Matthias
> Sent: Freitag, 1. Februar 2019 11:16
> To: 'David Holmes' ; '
om: David Holmes
> Sent: Freitag, 1. Februar 2019 05:24
> To: Baesken, Matthias ; 'hotspot-
> d...@openjdk.java.net'
> Cc: 'build-dev@openjdk.java.net'
> Subject: Re: RFR : 8218136: minor hotspot adjustments for xlclang++ from
> xlc16 on AIX
>
> Hi Matthias,
>
>
” .
* It would be really nice if we could align the xlc options more closely to
gcc/clang.
In the long run this should be possible .
Best regards, Matthias
From: Magnus Ihse Bursie
Sent: Donnerstag, 31. Januar 2019 21:19
To: Baesken, Matthias
Cc: build-dev@openjdk.java.net
Subject: Re
Please review this small webrev . It contains a few changes for building
hotspot on AIX with xlclang++ / xlc16 .
( most likely switching to xlclang++ / xlc16will be a must once we
introduce C++11/14 features )
Some comments on the changes :
- porting_aix.cpp : workaround
Thanks Magnus !
May I get a second review please ?
Best regards, Matthias
> -Original Message-
> From: Magnus Ihse Bursie
> Sent: Mittwoch, 30. Januar 2019 14:42
> To: Baesken, Matthias ; 'build-
> d...@openjdk.java.net'
> Subject: Re: RFR : [XS] 8218046: us
Hello, please review this small change .
It adjusts the freetype default on AIX to "bundled"(means : use the
bundled freetype if not configured otherwise) .
Currently only windows and macosx use the bundled freetype, the other platforms
by default use the system freetype (see
Thanks !
May I get a second review please ?
Best regards, Matthias
> -Original Message-
> From: Erik Joelsson
> Sent: Dienstag, 29. Januar 2019 17:57
> To: Baesken, Matthias ; 'build-
> d...@openjdk.java.net'
> Subject: Re: [XS] RFR : 8217979: lib-freetype related
Hello, please review this small fix.
It changes wrong configure output messages related to freetype .
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-8217979
http://cr.openjdk.java.net/~mbaesken/webrevs/8217979.0/
Thanks, Matthias
.@openjdk.java.net; Baesken,
> Matthias
> Subject: RE: JDK-8217880 AIX build issue about JDK-8214533
>
> Hello Goetz.
>
> Thank you for build testing.
>
> Yes, I need a sponsor.
> If possible, could you handle it ?
>
> Thanks,
> Ichiroh Takiguchi
>
Hello, seems 8214533 got pushed recently into jdk/jdk. Now we see
build errors on AIX , are they related to this change ?
/nb/rs6000_64/nightly/output-jdk-test/support/gensrc/jdk.charsets/sun/nio/cs/ext/EUC_JP_LINUX.java:63:
error: Decoder is not public in EUC_JP; cannot be
May I have a second review please ?
Best regards, Matthias
From: Baesken, Matthias
Sent: Mittwoch, 16. Januar 2019 11:08
To: 'Steve Groeger'
Cc: 'build-dev@openjdk.java.net' ;
ppc-aix-port-...@openjdk.java.net; ppc-aix-port-dev
Subject: RE: RFR [XS] 8217233: Update build settings for AIX
Hi Steve,
from my experience the situation is similar to Linux (small performance
change).
Best regards, Matthias
From: Steve Groeger
Sent: Mittwoch, 16. Januar 2019 10:49
To: Baesken, Matthias
Cc: 'build-dev@openjdk.java.net' ;
ppc-aix-port-...@openjdk.java.net; ppc-aix-port-dev
Hello, please review this small fix .
It adds stack protection compile flags for xlc/AIX .
See :
https://www.ibm.com/support/knowledgecenter/SSGH2K_12.1.0/com.ibm.xlc121.aix.doc/compiler_ref/opt_stackprotect.html
"Provides protection against malicious code or programming errors that
id tested it Oracle-internally with success .
Can I add you and David as reviewers ?
Best regards, Matthias
> -Original Message-
> From: Magnus Ihse Bursie
> Sent: Montag, 17. Dezember 2018 16:11
> To: Baesken, Matthias
> Cc: 2d-...@openjdk.java.net; erik.joels..
Holmes
> Sent: Dienstag, 18. Dezember 2018 09:45
> To: Baesken, Matthias ; 2d-
> d...@openjdk.java.net; erik.joels...@oracle.com; 'build-
> d...@openjdk.java.net' ; awt-
> d...@openjdk.java.net; 'magnus.ihse.bur...@oracle.com'
>
> Subject: Re: RFR: [OpenJDK 2D-Dev] JDK
+ style comments
// decl.
int a = 1;
printf("a: %d \n", a);
return 0;
}
Best regards, Matthias
> -Original Message-----
> From: David Holmes
> Sent: Dienstag, 18. Dezember 2018 01:24
> To: Baesken, Matthias ; 2d-
> d...@openjdk.java.net; erik
jdk-submit (hopefully it works ).
Best regards, Matthias
> -Original Message-
> From: Magnus Ihse Bursie
> Sent: Montag, 17. Dezember 2018 16:11
> To: Baesken, Matthias
> Cc: 2d-...@openjdk.java.net; erik.joels...@oracle.com; build-
> d...@openjdk.java.net;
Hello, please review
http://cr.openjdk.java.net/~mbaesken/webrevs/8215296.0/
in my change just -xc99=%none is removed, so we do not forbid c99 coding.
The -Xa compile flag is kept, no special additional settings are needed to
compile png/awt .
Thanks, Matthias
>
Hi Magnus , thanks for working on this ! The patch looks good to me (not a
Reviewer however).
I put your patch into our internal build/test patch queue , will come
back in case I notice any issues .
Best regards, Matthias
> Date: Wed, 12 Dec 2018 19:28:39 -0500
> From: Kim Barrett
Hello, I created :
https://bugs.openjdk.java.net/browse/JDK-8215296
8215296: do not disable c99 on Solaris
Best regards, Matthias
> -Original Message-
> From: Kim Barrett
> Sent: Mittwoch, 12. Dezember 2018 16:41
> To: Magnus Ihse Bursie
> Cc: Baesken, Matthias
ml/E37074/bjapp.html#OSSCGgnjmw
–std=value (–std=c99)
?
Best regards, Matthias
> -Original Message-
> From: Magnus Ihse Bursie
> Sent: Mittwoch, 12. Dezember 2018 14:22
> To: Baesken, Matthias ; David Holmes
> ; Erik Joelsson ;
> 'build-dev@openjdk.java.net' ; K
1. Dezember 2018 23:16
> To: Erik Joelsson ; Baesken, Matthias
> ; 'build-dev@openjdk.java.net' d...@openjdk.java.net>
> Subject: Re: disabled c99 in Solaris builds
>
> On 12/12/2018 3:27 am, Erik Joelsson wrote:
> > Hello,
> >
> > I do not know why this flag wa
Hello , it seems that currently the Solaris Oracle Studio Build environment
is the only one that explicitly
forbids C99 C code by setting -xc99=%none .
The current Linux/Mac/AIX/Windows build envs had no issues with the coding.
For example I was running into an error with the C variable
Otherwise "8214063: [AIX] Disable symbol visibility flags"
looks fine to me (not a Reviewer however) .
Best regards, Matthias
> -Original Message-
> From: Baesken, Matthias
> Sent: Dienstag, 27. November 2018 16:57
> To: 'Volker Simonis' ; build-dev d...@
> Change "8202322: AIX: symbol visibility flags not support on xlc 12.1"
> [1] blindly introduced these flags for all xlC compiler versions >
Hello, probably you did not look correctly at my change 8202322 .
It did NOT "blindly" introduce visibility flags for all xlC compilers,
but
HI Michal , tested on my Windows 10 machine , works nicely !
Best regards, Matthias
> -Original Message-
> From: Michal Vala
> Sent: Montag, 12. November 2018 05:25
> To: Thomas Stüfe
> Cc: Erik Joelsson ; Baesken, Matthias
> ; Chris Hegarty ;
> build-dev
018 18:05
> To: Baesken, Matthias ; Chris Hegarty
> ; 'build-dev@openjdk.java.net' d...@openjdk.java.net>; maurizio.cimadam...@oracle.com
> Subject: Re: bin/idea.sh and Cygwin
>
> A patch fixing idea.sh so that it works on Windows would certainly be
> welcome.
>
> /Erik
?
Best regards, Matthias
> -Original Message-
> From: Chris Hegarty
> Sent: Donnerstag, 8. November 2018 12:52
> To: Baesken, Matthias ; 'build-
> d...@openjdk.java.net' ;
> maurizio.cimadam...@oracle.com
> Subject: Re: bin/idea.sh and Cygwin
>
>
Hello, I tried to use bin/idea.sh with Cygwin to generate project files for
IDEA IntelliJ Community .
The project file generation seems to work and outputs the .idea - folder
with lots of xml files in it .
However , when opening the project from IDEA, it fails with a message :
Hi Magnus / Erik , thanks for explaning !
Best regards, Matthias
> -Original Message-
> From: Magnus Ihse Bursie
> Sent: Donnerstag, 1. November 2018 11:36
> To: Baesken, Matthias ; Aleksey Shipilev
> ; 'build-dev@openjdk.java.net' d...@openjdk.java.net>
> Sub
hipilev
> Sent: Mittwoch, 31. Oktober 2018 16:49
> To: Baesken, Matthias ; 'build-
> d...@openjdk.java.net'
> Subject: Re: minimal gcc version for jdk/jdk and usage of -Wno-int-in-bool-
> context flag in HS build
>
> On 10/31/2018 04:40 PM, Baesken, Matthias wrote:
Hello, I noticed that we currently set flags for gcc to disable warnings.
See
https://hg.openjdk.java.net/jdk/jdk/file/896e80158d35/make/hotspot/lib/CompileJvm.gmk
DISABLED_WARNINGS_gcc := extra parentheses comment unknown-pragmas address \
delete-non-virtual-dtor char-subscripts
age-
> From: Erik Joelsson
> Sent: Mittwoch, 10. Oktober 2018 18:08
> To: Baesken, Matthias ; 'build-
> d...@openjdk.java.net'
> Subject: Re: gcc 7.3.1 build - warnings as errors in harfbuzz
>
> I think that's fine. This is the granularity we have.
>
> /Erik
>
>
>
> Sent: Mittwoch, 10. Oktober 2018 17:33
> To: Baesken, Matthias ; 'build-
> d...@openjdk.java.net'
> Subject: Re: gcc 7.3.1 build - warnings as errors in harfbuzz
>
> In this case, disabling the warning seems like the right thing to do.
>
> /Erik
>
>
> On 20
Hello , when compiling jdk/jdk with gcc 7.3.1on linux x86_64 (or
also on linux ppc64) I run into this build error :
/open_jdk/jdk_just_clone/jdk/src/java.desktop/share/native/libfontmanager/harfbuzz/hb-common.cc:
In function 'void hb_variation_to_string(hb_variation_t*, char*,
(and your ) patch .
Best regards, Matthias
> -Original Message-
> From: Aleksey Shipilev
> Sent: Donnerstag, 27. September 2018 20:03
> To: Baesken, Matthias ; Thomas Schatzl
> ; 'hotspot-...@openjdk.java.net' d...@openjdk.java.net>; 'build-dev@openjdk.java.net' d..
rstag, 27. September 2018 16:32
> To: Baesken, Matthias ; 'hotspot-
> d...@openjdk.java.net' ; 'build-
> d...@openjdk.java.net'
> Subject: Re: RFR : 8211213: fix aix build after 8196341: Add JFR events for
> parallel phases of G1
>
> Hi,
>
> On Thu, 2018-09-27 at 14:16 +
removed/guarded
by macros ?
Best regards, Matthias
From: Baesken, Matthias
Sent: Donnerstag, 27. September 2018 14:13
To: 'hotspot-...@openjdk.java.net' ;
'build-dev@openjdk.java.net'
Cc: 'Leo Korinth'
Subject: RFR : 8211213: fix aix build after 8196341: Add JFR events for
parallel phases of G
Hello ,
please review this small change that fixes our AIX build after “8196341:
Add JFR events for parallel phases of G1”was pushed .
After 8196341 , compile errors occurred, example :
/openjdk/nb/rs6000_64/nightly/jdk/src/hotspot/share/gc/g1/g1CollectedHeap.cpp",
line 3185.15:
Hi Martin, the change looks OK (and fixes our AIX build).
(not a Reviewer however)
Best regards, Matthias
>
> Message: 4
> Date: Wed, 26 Sep 2018 13:26:19 +
> From: "Doerr, Martin"
> To: "'build-dev@openjdk.java.net'"
> Subject: RFR(XS): 8211097: aix: fix build after JDK-8210919
>
Hi Thomas, I think your understanding is correct :
"#ifdef "
or
"#if defined()"
Are ok while
"#if "
or
"#elif "
Lead to the compile error on gcc with current warnings.
Best regards, Matthias
> >>
> > This looks okay to me although I could imagine this issue coming back again
> > with
Hello, please review this small build fix .
After the recent changes to the gcc compile flags with 8211029, most
of our Linux builds stopped working .
Error :
=== Output from failing command(s) repeated here ===
* For target support_native_java.base_libnet_DatagramPacket.o:
In file
Thanks for the heads-up, we've seen this one too but noticed that you had
already a bug opened .
Best regards, Matthias
> -Original Message-
> From: Roman Kennke
> Sent: Dienstag, 25. September 2018 17:05
> To: Baesken, Matthias ; 'build-
> d...@openjdk.java.ne
ht need improvement however the test should be like #elif
defined(__solaris__) )
Best regards, Matthias
From: Baesken, Matthias
Sent: Dienstag, 25. September 2018 16:34
To: 'build-dev@openjdk.java.net'
Cc: Schmidt, Lutz ; Doerr, Martin
Subject: build issues after 8211029 on gcc4.8 a
Hello, it looks like
8211029: Have a common set of enabled warnings for all native libraries
breaks a lot of our Linux based builds.
Our gcc 4.8 misses some of the introduced command line options :
cc1plus: error: unrecognized command line option "-Wno-misleading-indentation"
[-Werror]
, I asked our local
Visual Studio experts for help, maybe I overlooked something .
Best regards, Matthias
> --
>
> Message: 4
> Date: Wed, 5 Sep 2018 09:57:06 -0700
> From: Erik Joelsson
> To: "Baesken, Matthias" ,
> &quo
Hello, when compilingjdk/jdk on Windows, (with VS2017 update level 15.8
and not disabling warnings as errors )
I came across this warning leading to build error :
C:/jdk-just-clone/src/hotspot/share/runtime/flags/jvmFlagRangeList.cpp(341):
error C2220: warning treated as error - no
Thanks , can I have a second review please ?
Best regards, Matthias
From: Lindenmaier, Goetz
Sent: Donnerstag, 30. August 2018 14:17
To: Baesken, Matthias ;
'hotspot-...@openjdk.java.net' ;
'build-dev@openjdk.java.net'
Cc: Doerr, Martin
Subject: RE: RFR : 8210205 : build fails on AIX
Hello, please review this small fix to repair our AIX build .
Recent changes to jdk/jdk broke the build .
We get clashes with defines from system headers in a few compilation units,
for example :
Thanks for the review!
> -Original Message-
> From: David Holmes
> Sent: Montag, 13. August 2018 09:00
> To: Baesken, Matthias ; Phil Race
>
> Cc: awt-...@openjdk.java.net; 'build-dev@openjdk.java.net' d...@openjdk.java.net>
> Subject: Re: [RFR]: 8209115: adju
Thank‘s !
Can I have a second review please ?
Best regards, Matthias
From: Phil Race
Sent: Freitag, 10. August 2018 20:12
To: Baesken, Matthias
Cc: 'build-dev@openjdk.java.net' ;
awt-...@openjdk.java.net
Subject: Re: [RFR]: 8209115: adjust libsplashscreen linux ppc64le builds for
easier
Hello , here is a new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8209115.1/
I set PNG_POWERPC_VSX_OPTnow only on the linux ppc platforms .
Best regards, Matthias
From: Baesken, Matthias
Sent: Donnerstag, 9. August 2018 08:48
To: 'Philip Race'
Cc: 'build-dev@openjdk.java.net
. it has to be
PNG_POWERPC_VSX_OPT not PNG_POWERPC_VSX
☹ - my mistake .
For some reason the current setting still builds on our ppc64 (le) test machine
in the current codebase , strange !
Best regards, Matthias
From: Philip Race
Sent: Donnerstag, 9. August 2018 04:09
To: Baesken, Matthias
on linuxppc64 le .
Webrev/bug :
http://cr.openjdk.java.net/~mbaesken/webrevs/8209115.0/
https://bugs.openjdk.java.net/browse/JDK-8209115
Thanks ,
Matthias
From: Philip Race
Sent: Dienstag, 7. August 2018 17:15
To: Baesken, Matthias
Cc: Doerr, Martin ; 2d-...@openjdk.java.net; Simonis
review !
Thanks, Matthias
> -Original Message-
> From: David Holmes
> Sent: Freitag, 3. August 2018 02:56
> To: Magnus Ihse Bursie ; Baesken,
> Matthias
> Cc: build-dev@openjdk.java.net
> Subject: Re: unneeded -DUSE_MMAP in JDK native libs builds
>
> On 3/0
Hello I noticed that -DUSE_MMAP is set for these JDK native libs, but I
cannot find it in the code (for libzip it is different there the flag shows
up in the code too ) :
Lib-jdk.jdi.gmk :
32 $(eval $(call SetupJdkLibrary, BUILD_LIBDT_SHMEM, \
..
35 CFLAGS := $(CFLAGS_JDKLIB)
Hi Thomas , looks good (however I am not a Reviewer) !
> From: Thomas Stüfe
> Date: Wed, Jun 20, 2018 at 10:00 AM
> Subject: RFR(xxs): 8205407: [windows, vs<2017] C4800 after 8203197
> To: build-dev
>
>
> Hi all,
>
> May I please have reviews for this small build fix?
>
>
Hi , thanks for looking into it.
I think I will use STAT_IMPL .
Best regards, Matthias
> -Original Message-
> From: René Schünemann [mailto:rene.schuenem...@gmail.com]
> Sent: Freitag, 15. Juni 2018 11:08
> To: Baesken, Matthias
> Cc: build-dev@openjdk.ja
Please review this small change that fixes the AIX build after "8203641:
Refactor String Deduplication into shared".
We are getting this compilation error :
/build_ci_jdk_jdk_rs6000_64/src/hotspot/share/gc/shared/stringdedup/stringDedup.hpp",
line 107.38: 1540-0063 (S) The text "1" is
Hi Thomas , thanks for fixing it, looks good ( not a Reviewer however) .
Best regards, Matthias
> -Original Message-
> From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-
> boun...@openjdk.java.net] On Behalf Of Thomas Stüfe
> Sent: Mittwoch, 13. Juni 2018 08:14
> To: build-dev ;
101 - 200 of 266 matches
Mail list logo
