On Thu, 14 Aug 2025 23:59:23 GMT, Saint Wesonga wrote:
> [ml64](https://learn.microsoft.com/en-us/cpp/assembler/masm/ml-and-ml64-command-line-reference?view=msvc-170)
> is set as the assembler for the Windows platform but is specific to the x64
> platform. The
> [armasm64](https://learn.micros
On Thu, 14 Aug 2025 19:13:18 GMT, Kim Barrett wrote:
> But `-fno-exceptions` _is_ used for gcc
-fno-exceptions to my knowledge is only set in TOOLCHAIN_CFLAGS_JVM and for
adlc compiled for Linux. That must mean gtest uses the same flags that the
regular JVM does. I was not aware of that, so th
On Wed, 13 Aug 2025 14:23:37 GMT, Manuel Hässig wrote:
>> This PR adds a basic configuration for the [Oracle Java VSCode
>> extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java)
>> to the `vscode-project-*` targets.
>
> Manuel Hässig has updated the pull request inc
> This PR adds a basic configuration for the [Oracle Java VSCode
> extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java)
> to the `vscode-project-*` targets.
Manuel Hässig has updated the pull request incrementally with one additional
commit since the last revision:
On Thu, 14 Aug 2025 14:44:21 GMT, Julian Waters wrote:
>> According to
>> https://github.com/openjdk/jdk/pull/26661#issuecomment-3162014034, we should
>> not build gtest with `/EHsc`.
>>
>> I can honestly say I don't fully understand the consequences of this change,
>> but at least it passes
On Fri, 15 Aug 2025 04:33:59 GMT, Leonid Mesnik wrote:
>> The fix added JVMTI stress testing mode.
>>
>> This mode enables stress agent that could be executed with jtreg test and
>> help to ensure that jvmti functionality doesn't break the other JVM/JDK
>> functionality.
>>
>> I filed few iss
> The fix added JVMTI stress testing mode.
>
> This mode enables stress agent that could be executed with jtreg test and
> help to ensure that jvmti functionality doesn't break the other JVM/JDK
> functionality.
>
> I filed few issues and more are coming. I want to push the agent so it is
> po
[ml64](https://learn.microsoft.com/en-us/cpp/assembler/masm/ml-and-ml64-command-line-reference?view=msvc-170)
is set as the assembler for the Windows platform but is specific to the x64
platform. The
[armasm64](https://learn.microsoft.com/en-us/cpp/assembler/arm/arm-assembler-command-line-refere
On Mon, 11 Aug 2025 09:55:20 GMT, Magnus Ihse Bursie wrote:
> According to
> https://github.com/openjdk/jdk/pull/26661#issuecomment-3162014034, we should
> not build gtest with `/EHsc`.
>
> I can honestly say I don't fully understand the consequences of this change,
> but at least it passes
On Thu, 14 Aug 2025 19:24:21 GMT, Kim Barrett wrote:
> My guess is that MSVC C4530 needs to be disabled when building libgtest even
> when we're not enabling exceptions for the same reason that I expected that
> warning from our jfr/test_networkUtilization.cpp.
>
> That jfr test includes ``, a
On Thu, 14 Aug 2025 19:49:24 GMT, Erik Joelsson wrote:
> I think this new option should be documented in testing.md/html.
Yes, I agree. I tried to ask for this above. @lmesnik When you have updated the
markdown file, run `make update-build-docs` to generate the html version.
-
PR
On Thu, 14 Aug 2025 19:44:59 GMT, Leonid Mesnik wrote:
>> The fix added JVMTI stress testing mode.
>>
>> This mode enables stress agent that could be executed with jtreg test and
>> help to ensure that jvmti functionality doesn't break the other JVM/JDK
>> functionality.
>>
>> I filed few iss
On Thu, 14 Aug 2025 17:57:47 GMT, Leonid Mesnik wrote:
>> The fix added JVMTI stress testing mode.
>>
>> This mode enables stress agent that could be executed with jtreg test and
>> help to ensure that jvmti functionality doesn't break the other JVM/JDK
>> functionality.
>>
>> I filed few iss
> The fix added JVMTI stress testing mode.
>
> This mode enables stress agent that could be executed with jtreg test and
> help to ensure that jvmti functionality doesn't break the other JVM/JDK
> functionality.
>
> I filed few issues and more are coming. I want to push the agent so it is
> po
On Thu, 14 Aug 2025 19:26:29 GMT, Volkan Yazici wrote:
> Synchronize `make/RunTests.gmk` keyword variables with
> `doc/testing.{md,html}`.
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/26789#pullrequestreview-3121900093
On Wed, 13 Aug 2025 14:22:08 GMT, Leo Korinth wrote:
>> This changes the timeout factor from 4 to 1. Most of the changes add
>> timeouts to individual test cases so that I am able to run them with a
>> timeout factor of 0.7 (some margin to the checked in factor of one)
>>
>> In addition to cha
Synchronize `make/RunTests.gmk` keyword variables with `doc/testing.{md,html}`.
-
Commit messages:
- Synchronize `make/RunTests.gmk` keyword variables with
`doc/testing.{md,html}`
Changes: https://git.openjdk.org/jdk/pull/26789/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&
On Mon, 11 Aug 2025 09:55:20 GMT, Magnus Ihse Bursie wrote:
> According to
> https://github.com/openjdk/jdk/pull/26661#issuecomment-3162014034, we should
> not build gtest with `/EHsc`.
>
> I can honestly say I don't fully understand the consequences of this change,
> but at least it passes
On Thu, 14 Aug 2025 14:44:21 GMT, Julian Waters wrote:
> I did take a brief look at the other Pull Request, but I still don't really
> understand this fully. Doesn't the gtest framework itself use C++ exceptions
> (As Thomas mentioned)? After all, this is likely why -fno-exceptions is not
> us
On Mon, 11 Aug 2025 09:55:20 GMT, Magnus Ihse Bursie wrote:
> According to
> https://github.com/openjdk/jdk/pull/26661#issuecomment-3162014034, we should
> not build gtest with `/EHsc`.
>
> I can honestly say I don't fully understand the consequences of this change,
> but at least it passes
On Thu, 14 Aug 2025 14:06:07 GMT, Thomas Stuefe wrote:
> googletest uses C++ exceptions:
>
> ```
> thomas@starfish:/shared/projects/openjdk/gtest/googletest-1.14.0$ ack 'throw
> [a-zA-Z]' | wc -l
> 68
That just says there is source code that could potentially use exceptions,
depending on conf
> The fix added JVMTI stress testing mode.
>
> This mode enables stress agent that could be executed with jtreg test and
> help to ensure that jvmti functionality doesn't break the other JVM/JDK
> functionality.
>
> I filed few issues and more are coming. I want to push the agent so it is
> po
On Thu, 14 Aug 2025 11:19:02 GMT, David Beaumont wrote:
> Allows files or directories called .git to indicate likely use of Git for VCS
> in IntelliJ.
> Tested locally in a worktree and normal repository. It produces:
>
>
>
>
>
>
> in both cases, as expected.
This pull request
On Thu, 14 Aug 2025 15:21:29 GMT, David Beaumont wrote:
>> Allows files or directories called .git to indicate likely use of Git for
>> VCS in IntelliJ.
>> Tested locally in a worktree and normal repository. It produces:
>>
>>
>>
>>
>>
>>
>> in both cases, as expected.
>
> David
On Thu, 14 Aug 2025 15:21:29 GMT, David Beaumont wrote:
>> Allows files or directories called .git to indicate likely use of Git for
>> VCS in IntelliJ.
>> Tested locally in a worktree and normal repository. It produces:
>>
>>
>>
>>
>>
>>
>> in both cases, as expected.
>
> David
On Wed, 13 Aug 2025 14:24:28 GMT, Manuel Hässig wrote:
> > I would suggest to drop: `"jdk.advanced.disable.nbjavac": true,`
>
> Can you elaborate on the surprising results? When developing the JDK we will
> most probably use features not supported by the `nbjavac`.
In general, it can be anythi
> Allows files or directories called .git to indicate likely use of Git for VCS
> in IntelliJ.
> Tested locally in a worktree and normal repository. It produces:
>
>
>
>
>
>
> in both cases, as expected.
David Beaumont has updated the pull request incrementally with one additiona
On Thu, 14 Aug 2025 14:54:43 GMT, Aleksey Shipilev wrote:
>> Allows files or directories called .git to indicate likely use of Git for
>> VCS in IntelliJ.
>> Tested locally in a worktree and normal repository. It produces:
>>
>>
>>
>>
>>
>>
>> in both cases, as expected.
>
> bin
On Thu, 14 Aug 2025 11:19:02 GMT, David Beaumont wrote:
> Allows files or directories called .git to indicate likely use of Git for VCS
> in IntelliJ.
> Tested locally in a worktree and normal repository. It produces:
>
>
>
>
>
>
> in both cases, as expected.
LGTM, if you fix t
On Wed, 13 Aug 2025 14:23:37 GMT, Manuel Hässig wrote:
>> This PR adds a basic configuration for the [Oracle Java VSCode
>> extension](https://marketplace.visualstudio.com/items?itemName=Oracle.oracle-java)
>> to the `vscode-project-*` targets.
>
> Manuel Hässig has updated the pull request inc
On Thu, 14 Aug 2025 11:19:02 GMT, David Beaumont wrote:
> Allows files or directories called .git to indicate likely use of Git for VCS
> in IntelliJ.
> Tested locally in a worktree and normal repository. It produces:
>
>
>
>
>
>
> in both cases, as expected.
bin/idea.sh line 1
On Mon, 11 Aug 2025 09:55:20 GMT, Magnus Ihse Bursie wrote:
> According to
> https://github.com/openjdk/jdk/pull/26661#issuecomment-3162014034, we should
> not build gtest with `/EHsc`.
>
> I can honestly say I don't fully understand the consequences of this change,
> but at least it passes
On Mon, 11 Aug 2025 09:55:20 GMT, Magnus Ihse Bursie wrote:
> According to
> https://github.com/openjdk/jdk/pull/26661#issuecomment-3162014034, we should
> not build gtest with `/EHsc`.
>
> I can honestly say I don't fully understand the consequences of this change,
> but at least it passes
On Mon, 11 Aug 2025 09:55:20 GMT, Magnus Ihse Bursie wrote:
> According to
> https://github.com/openjdk/jdk/pull/26661#issuecomment-3162014034, we should
> not build gtest with `/EHsc`.
>
> I can honestly say I don't fully understand the consequences of this change,
> but at least it passes
On Thu, 14 Aug 2025 11:19:02 GMT, David Beaumont wrote:
> Allows files or directories called .git to indicate likely use of Git for VCS
> in IntelliJ.
> Tested locally in a worktree and normal repository. It produces:
>
>
>
>
>
>
> in both cases, as expected.
Marked as reviewed
On Mon, 11 Aug 2025 09:55:20 GMT, Magnus Ihse Bursie wrote:
> According to
> https://github.com/openjdk/jdk/pull/26661#issuecomment-3162014034, we should
> not build gtest with `/EHsc`.
>
> I can honestly say I don't fully understand the consequences of this change,
> but at least it passes
On Mon, 11 Aug 2025 09:55:20 GMT, Magnus Ihse Bursie wrote:
> According to
> https://github.com/openjdk/jdk/pull/26661#issuecomment-3162014034, we should
> not build gtest with `/EHsc`.
>
> I can honestly say I don't fully understand the consequences of this change,
> but at least it passes
On Thu, 14 Aug 2025 11:19:02 GMT, David Beaumont wrote:
> Allows files or directories called .git to indicate likely use of Git for VCS
> in IntelliJ.
> Tested locally in a worktree and normal repository. It produces:
>
>
>
>
>
>
> in both cases, as expected.
Marked as reviewed
On Tue, 12 Aug 2025 10:51:06 GMT, Roman Marchenko
wrote:
> This change fixes the test artifact path on Alpine as `'[_*1000]'` is not
> recognized as a correct pattern, at least on Alpine 3.11.
>
> Without this fix, on Alpine the command `make test-prebuilt` generated paths
> like the followin
While not directly applicable to the JDK, this is still interesting from
a general reproducible build perspective.
/Magnus
Forwarded Message
Subject:DALEQ: An Open-Source Tool for Assessing Java Binary Equivalence
Date: Fri, 8 Aug 2025 03:42:47 +
From: Jens Diet
On Thu, 14 Aug 2025 11:19:02 GMT, David Beaumont wrote:
> Allows files or directories called .git to indicate likely use of Git for VCS
> in IntelliJ.
> Tested locally in a worktree and normal repository. It produces:
>
>
>
>
>
>
> in both cases, as expected.
Marked as reviewed
Allows files or directories called .git to indicate likely use of Git for VCS
in IntelliJ.
Tested locally in a worktree and normal repository. It produces:
in both cases, as expected.
-
Commit messages:
- Simple fix (just checking file)
Changes: https://git.openjdk
On Tue, 12 Aug 2025 10:51:06 GMT, Roman Marchenko
wrote:
> This change fixes the test artifact path on Alpine as `'[_*1000]'` is not
> recognized as a correct pattern, at least on Alpine 3.11.
>
> Without this fix, on Alpine the command `make test-prebuilt` generated paths
> like the followin
On Mon, 11 Aug 2025 17:20:30 GMT, Erik Joelsson wrote:
>> This solution was modeled on how we create `module-included-libs.txt`. I
>> agree that it is a bit hacky to inject this kind of stuff in ModuleWrapper,
>> but I can't see how we can do it more cleanly. That's the only point at
>> which
On Tue, 12 Aug 2025 20:09:15 GMT, Erik Joelsson wrote:
> The explanation for this can be found here:
> https://mail.openjdk.org/pipermail/build-dev/2017-November/020334.html
Thank you for digging that out! I was just about to check why in the world we
could ever have written something so wonky.
On Tue, 12 Aug 2025 10:51:06 GMT, Roman Marchenko
wrote:
> This change fixes the test artifact path on Alpine as `'[_*1000]'` is not
> recognized as a correct pattern, at least on Alpine 3.11.
>
> Without this fix, on Alpine the command `make test-prebuilt` generated paths
> like the followin
On Mon, 11 Aug 2025 09:55:20 GMT, Magnus Ihse Bursie wrote:
> According to
> https://github.com/openjdk/jdk/pull/26661#issuecomment-3162014034, we should
> not build gtest with `/EHsc`.
>
> I can honestly say I don't fully understand the consequences of this change,
> but at least it passes
On Thu, 14 Aug 2025 06:46:46 GMT, Kim Barrett wrote:
>> `-ftrivial-auto-var-init=pattern` [1] supported by gcc-12 was added recently
>> to help detect uses of uninitialized memory. [2] Under this extension mode,
>> `__builtin_clear_padding` is called to clear the padding bits in object
>> repr
On Mon, 11 Aug 2025 19:32:39 GMT, Leonid Mesnik wrote:
> Thank you feedback, I explained the usage of
> JTREG_JVMTI_STRESS_AGENT
> and applied your changes.
I can't see any updates to this PR? Did you forget to push your commits?
-
PR Comment: https://git.openjdk.org/jdk/pull/26360
On Tue, 12 Aug 2025 11:32:42 GMT, Francesco Andreuzzi wrote:
>> In this PR I propose to refresh the included headers in hotspot
>> `precompiled.hpp`. The current set of precompiled headers was refreshed in
>> 2018, 7 years ago. I repeated the same operations and measurements after
>> refreshin
On Wed, 6 Aug 2025 18:05:24 GMT, Saint Wesonga wrote:
> https://github.com/openjdk/jdk/commit/0054bbed7fce5b8566655d6910b09b10c952e609
> (from https://bugs.openjdk.org/browse/JDK-8343756) caused the gtest death
> tests to fail on Windows with the error message "Caught
> std::exception-derived
Thanks, it worked! All I needed to do was run the flag you gave me on my
bash configure, then reattempt the make images command, and it worked!
Building the JDK has gotten easier than the last time I tried it.
On Tue, Aug 12, 2025 at 10:46 AM Kim Barrett wrote:
> On 8/11/25 8:16 PM, David Alayac
On Wed, 13 Aug 2025 09:16:15 GMT, Fei Gao wrote:
> `-ftrivial-auto-var-init=pattern` [1] supported by gcc-12 was added recently
> to help detect uses of uninitialized memory. [2] Under this extension mode,
> `__builtin_clear_padding` is called to clear the padding bits in object
> representati
53 matches
Mail list logo
