On 05/11/11 10:50, Kelly O'Hair wrote:
On May 11, 2011, at 10:47 AM, Alan Bateman wrote:
Q2: Does it belong somewhere other than the bin directory?
The script can be used to tunnel RMI calls over HTTP. Probably legacy
now and I'm pretty sure that java-rmi.cgi is just meant to be an
examp
On 12/16/2011 9:26 AM, Kelly O'Hair wrote:
You are correct. This changeset was wrong.
Chris - good find.
Mandy was asking me about this a while back
That was Wednesday - not long ago.jigsaw build has a similar issue:
http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/diff/459b6cbb0de7/ma
On 2/2/2012 7:13 PM, David Holmes wrote:
Okay two questions :) : do you know when this will get modularized and
show up in the jigsaw repositories?
FWIW. We have been sync'ing up jigsaw forest with jdk8 periodically and
hope to do it in a regular basis. It's currently sync'ed with
jdk8-b2
Great. That would give a good starting point.
Mandy
On 2/2/2012 7:34 PM, Brian Goetz wrote:
The main ASM distribution is broken into 5 jars, based on how people
tend to use it; this is probably a good starting candidate for module
boundaries.
On 2/2/2012 10:33 PM, Mandy Chung wrote:
On 2
I agree with Jon. SKIP_BOOT_CYCLE=false has been a useful and handy
test case (building JDK with the newly built JDK) to catch issues early
on.Such functionality makes it easy and convenient to do the skip
boot cycle build via JPRT or our automated nightly builds. FWIW - skip
boot cycle b
I need a reviewer to fix this build problem that only affects partial build.
make/common/internal/Defs-jaxws.gmk maintains an explicit list of
JAXWS packages to import from a JDK for a partial JDK. However,
the list was not up-to-date and missing some JAXWS classes. You can
reproduce the proble
On 10/17/2012 11:29 AM, Kelly O'Hair wrote:
Looks ok to me. Did you plan on integrating it into jdk8/build?
I can do that. Thanks for reminding me - my local repo is a clone of
jdk8/tl.
Mandy
-kto
On Oct 17, 2012, at 11:11 AM, Mandy Chung wrote:
I need a reviewer to fix this
On 10/17/2012 11:53 AM, Kelly O'Hair wrote:
On Oct 17, 2012, at 11:44 AM, Alan Bateman wrote:
On 17/10/2012 19:33, Mandy Chung wrote:
On 10/17/2012 11:29 AM, Kelly O'Hair wrote:
Looks ok to me. Did you plan on integrating it into jdk8/build?
I can do that. Thanks for remindi
This review request (add a new jdeps tool in the JDK) include changes in
langtools and the jdk build. I would need reviewers from the langtools
and the build-infra team.
Webrev for review:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/jdeps/langtools-webrev.02/
http://cr.openjdk.java.n
eps to some exception lists in compare script. (jdeps,
like most executables, contains the version string.)
With these changes, I don't see any new regressions in the compare
script on my machine.
/Erik
On 2012-12-06 02:36, Mandy Chung wrote:
This review request (add a new jdeps
Looks good to me.
Mandy
On 3/18/13 10:48 PM, Mike Duigou wrote:
A two small changes to review:
If approved I will commit to TL (or someone else can commit to build for me)
Mike
JDK-8010267 : Add test-clean for cleaning of testoutput directory from output
directory.
diff --git a/common/make
On 4/15/2013 3:42 PM, David Holmes wrote:
FYI updated webrev at same location, removing the dead code Erik spotted.
http://cr.openjdk.java.net/~dholmes/8010280/webrev/
Looks good to me. Nit: CopyFiles.gmk line 340 - you may want to remove
the extra space to align with the next line.
I'v
On 4/16/2013 7:34 PM, David Holmes wrote:
A "simple" sanity test? ;-) This would involve finding all the
libjvm's in a JRE and extracting their names, then finding and reading
the jvm.cfg file in the JRE, then invoking the VM with all the
possible entries in jvm.cfg and using the version stri
Looks good to me.
Mandy
On 5/7/2013 6:05 AM, Alan Bateman wrote:
I'd like to propose adding javax.script to the compact1 builds (it has
been in compact3 to date). The rational is to provide a supported way
for applications running on the smallest profile make use of scripting
languages. The
Looks good.
Mandy
On 5/8/2013 9:00 PM, Mike Duigou wrote:
Hello all;
Small issue for review. Some of the Main.gmk targets aren't mentioned in the
PHONY targets as they should be.
http://cr.openjdk.java.net/~mduigou/JDK-8014269/0/webrev/
Mike
On Mon, 7 Dec 2020 19:31:59 GMT, Jonathan Gibbons wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move to share/data, and move jdwp.spec to java.se
>
> I have reviewed all lines in the patch file with or near
On Tue, 8 Dec 2020 16:19:05 GMT, Magnus Ihse Bursie wrote:
>> Is there a plan to move make/jdk/src/classes/build/tools/intpoly into
>> java.base as well?
>>
>> Update: I see all subdirs in tools are still there.
>
> @wangweij Moving build tools is a related, but separate, question, which is
>
On Tue, 8 Dec 2020 18:16:15 GMT, Mandy Chung wrote:
>> @wangweij Moving build tools is a related, but separate, question, which is
>> addressed by https://bugs.openjdk.java.net/browse/JDK-8241463.
>>
>> I send out a review earlier this year (see
>> https://m
On Tue, 8 Dec 2020 17:10:30 GMT, Joe Darcy wrote:
>> Start of JDK 17 updates.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains 12 addi
On Tue, 15 Dec 2020 20:32:05 GMT, Magnus Ihse Bursie wrote:
>> I thought it was a consistent and clear naming scheme. :-) But I guess to
>> each their own...
>>
>> Would `classloader-modules.conf`, `docs-modules.conf` and
>> `build-modules.con` be better? Otherwise you'll need to come up with
On Tue, 15 Dec 2020 22:47:16 GMT, Mandy Chung wrote:
>> As for `JRE_TOOL_MODULES`, I understand what you mean but it is at least
>> kind of a "sibling" to the others. After all, we use these sets of modules
>> together to form the set of modules for the JRE:
&g
On Tue, 15 Dec 2020 22:58:47 GMT, Mandy Chung wrote:
>> `JRE_TOOL_MODULES` started with more than one modules in JDK 9:
>>
>> JRE_TOOL_MODULES += \
>> jdk.jdwp.agent \
>> jdk.pack \
>> jdk.scripting.nashorn.shell \
>> #
>>
>&
On Wed, 16 Dec 2020 14:40:14 GMT, Alan Bateman wrote:
> javadoc-modules.conf is probably okay although someone finding this in the
> repo might initially think it's the configuration for the javadoc modules.
> That plus it sets DOCS_MODULES, so maybe it should be apidocs-modules.conf.
I'm okay
On Wed, 16 Dec 2020 18:36:25 GMT, Magnus Ihse Bursie wrote:
>> The hard-coded list of modules in `make/common/Modules.gmk` has always been
>> a wart in the build system. We pride ourself on using discovery instead of
>> hard-coded list. In this case, it is not possible to do do auto-discovery,
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Ahead-of-Time Compiler from JDK:
>>
>> - `jdk.aot` module — the `jaotc` tool
>> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
On Thu, 13 May 2021 16:37:38 GMT, Vladimir Kozlov wrote:
> [JDK-8264806](https://bugs.openjdk.java.net/browse/JDK-8264806) changes
> removed sources and also removed JVMCI compiler from list of upgradable
> modules. JVMCI compiler modules should be upgradable in JDK to work with
> GraalVM.
>
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Fri, 4 Jun 2021 09:46:31 GMT, Jan Lahoda wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
>> http://cr.openjdk.java.net/~gbierman/je
GenGraphs tool generates the module graph. It currently supports the
configuration via javadoc-graphs.properties. However,
`make/jdk/src/classes/build/tools/jigsaw/javadoc-graphs.properties` only
documents two properties. It should be updated to cover all configurable
properties.
There are a c
On Fri, 24 Sep 2021 23:07:33 GMT, Mandy Chung wrote:
> GenGraphs tool generates the module graph. It currently supports the
> configuration via javadoc-graphs.properties. However,
> `make/jdk/src/classes/build/tools/jigsaw/javadoc-graphs.properties` only
> documents two propertie
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote:
>> As a follow up of JEP 411, we will soon disallow security manager by
>> default. jtreg 6.1 does not set its own security manager if JDK version is
>> >= 18.
>
> Weijun Wang has updated the pull request incrementally with one additional
>
On Fri, 11 Feb 2022 20:36:26 GMT, Tim Prinzing wrote:
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Thanks for taking on these null caller issue.
To give more context to this issue, the spec of
`ClassLoader::isRegisteredAsParallelCapable` returns true if
On Mon, 14 Feb 2022 11:56:16 GMT, Alan Bateman wrote:
>> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
>
> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 121:
>
>> 119: Class c = Reflection.getCallerClass();
>> 120: if (c == null) {
>> 121
On Mon, 14 Feb 2022 18:28:09 GMT, Mandy Chung wrote:
>> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
>
> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 121:
>
>> 119: Class c = Reflection.getCallerClass();
>> 120:
On Fri, 11 Feb 2022 20:32:46 GMT, Tim Prinzing wrote:
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
This needs a CSR and the spec needs update.
The test name could be shortened to
`s/exeNullCallerMethodHandlesLookup/exeNullCallerLookup/`.
src/java.base/share/classes/jav
On Tue, 15 Feb 2022 00:10:44 GMT, Tim Prinzing wrote:
>> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
>
> Tim Prinzing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remove excess description
Looks good.
-
On Tue, 15 Feb 2022 22:17:53 GMT, Tim Prinzing wrote:
>> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
>> null
>
> Tim Prinzing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Changes from feedback.
>
> -
On Tue, 15 Feb 2022 23:05:30 GMT, Mandy Chung wrote:
>> Tim Prinzing has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Changes from feedback.
>>
>> - Copyright dates fixed
>> - IllegalCalle
On Wed, 16 Feb 2022 21:39:20 GMT, Tim Prinzing wrote:
>> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
>> null
>
> Tim Prinzing has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 10 commits:
>
> - Merge
On Wed, 2 Mar 2022 18:56:40 GMT, Tim Prinzing wrote:
> The caller class returned by Reflection::getCallerClass was used to gain
> access to it's module in most cases and class loader in one case. I added a
> method to translate the caller class to caller module so that the decision of
> what m
On Wed, 2 Mar 2022 21:53:01 GMT, Tim Prinzing wrote:
>> The caller class returned by Reflection::getCallerClass was used to gain
>> access to it's module in most cases and class loader in one case. I added a
>> method to translate the caller class to caller module so that the decision
>> of wh
On Thu, 3 Mar 2022 16:55:46 GMT, Tim Prinzing wrote:
>> The caller class returned by Reflection::getCallerClass was used to gain
>> access to it's module in most cases and class loader in one case. I added a
>> method to translate the caller class to caller module so that the decision
>> of wh
On Mon, 21 Mar 2022 16:29:25 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Thu, 14 Apr 2022 13:59:57 GMT, Claes Redestad wrote:
>> This patch examines and optimizes `Wrapper` lookups.
>>
>> First wrote a few simple microbenchmarks to verify there are actual speedups
>> from using perfect hash tables in `sun.invoke.util.Wrapper` compared to
>> simpler lookup mechan
On Mon, 11 Apr 2022 00:48:34 GMT, Tim Prinzing wrote:
>> Created a test called NullCallerGetResource to test
>> Module::getResourceAsStream and Class::getResourceAsStream from the native
>> level.
>>
>> At the java level the test builds a test module called 'n' which opens the
>> package 'ope
On Wed, 20 Apr 2022 01:03:23 GMT, Tim Prinzing wrote:
>> Created a test called NullCallerGetResource to test
>> Module::getResourceAsStream and Class::getResourceAsStream from the native
>> level.
>>
>> At the java level the test builds a test module called 'n' which opens the
>> package 'ope
On Wed, 4 May 2022 23:44:08 GMT, Maurizio Cimadamore
wrote:
>> Another option would be to treat calls to `ensureNativeAccess` with `null`
>> caller class as coming from unnamed module.
>
> Looking deeper, `System::loadLibrary` seems to search the boot loader
> libraries when invoked with a `nu
On Thu, 5 May 2022 16:22:41 GMT, Mandy Chung wrote:
>> Looking deeper, `System::loadLibrary` seems to search the boot loader
>> libraries when invoked with a `null` caller class, so replicating that
>> behavior should be safe.
>
> `BootLoader` is what you want in th
On Thu, 5 May 2022 20:54:53 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Fri, 6 May 2022 16:48:11 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-424 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Mon, 30 May 2022 05:37:16 GMT, Alan Bateman wrote:
> I don't think jdk/nullCaller is right location for this. Maybe jni/nullCaller
> could work. You'll probably need to add the location to an appropriate
> group/tier in test/jdk/TEST.groups, otherwise it won't be run.
I also think `test/jdk
On Mon, 30 May 2022 00:10:50 GMT, Tim Prinzing wrote:
>> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
>> a test module with some resources in it for the actual tests that occur at
>> the native level. The native part was switched to c++ instead of c to make
>> i
On Wed, 1 Jun 2022 00:59:33 GMT, Tim Prinzing wrote:
>> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
>> a test module with some resources in it for the actual tests that occur at
>> the native level. The native part was switched to c++ instead of c to make
>> it
On Wed, 1 Jun 2022 03:01:35 GMT, Tim Prinzing wrote:
>> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
>> a test module with some resources in it for the actual tests that occur at
>> the native level. The native part was switched to c++ instead of c to make
>> it
On Wed, 1 Jun 2022 19:27:33 GMT, Tim Prinzing wrote:
>> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
>> a test module with some resources in it for the actual tests that occur at
>> the native level. The native part was switched to c++ instead of c to make
>> it
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
Marked as reviewed by mchung (Reviewer).
make/test/JtregNativeJdk.gmk line 67:
> 65: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exeNullCallerTest := $(LIBCXX) jvm.lib
> 66: BUILD_JD
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
Thanks for doing the run, Dan.
-
PR: https://git.openjdk.java.net/jdk/pull/9010
On Fri, 3 Jun 2022 22:40:52 GMT, Tim Prinzing wrote:
>> make/test/JtregNativeJdk.gmk line 67:
>>
>>> 65: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exeNullCallerTest := $(LIBCXX)
>>> jvm.lib
>>> 66: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exerevokeall := advapi32.lib
>>> 67: BUILD_JDK_JTREG_EXECUTABLES_CF
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
There are a few C++ tests under `test/jdk/java/foreign` as well.
-
PR: https://git.openjdk.java.net/jdk/pull/9010
Hi Erik,
On 10/16/17 6:12 AM, Erik Joelsson wrote:
To generate the new modules, I copy the module-info.java files to a
new gensrc dir and sed replace the module names. I also generate a new
ToolProvider.java so that the default tools are taken from the interim
modules.
:
Webrev: http://cr
The ctsym generator in Gendata-jdk.compiler.gmk looks up the tool
using the ToolProvider. That part of the change was just a reaction to
ctsym generation failing.
/Erik
On 2017-10-17 17:47, mandy chung wrote:
Hi Erik,
On 10/16/17 6:12 AM, Erik Joelsson wrote:
To generate the new modul
avoid the ServiceLoader lookup.
Worth trying this and I think this needs --limit-modules to hide
jdk.compiler and other interim modules.
Does this build tool just depend on javac? Does it need all system
modules to be observable?
Mandy
Jan
On 17.10.2017 19:04, mandy chung wrote:
It'
On 10/18/17 2:29 AM, Erik Joelsson wrote:
New webrev again: http://cr.openjdk.java.net/~erikj/8189094/webrev.03/
Looks fine to me.
Thanks
Mandy
On 10/18/17 1:26 AM, Erik Joelsson wrote:
On 2017-10-18 10:04, Magnus Ihse Bursie wrote:
The file jvmticmlr.h is stored twice in the repo, both in hotspot and
in java.base. They are both identical, and only the java.base version
is included in the final product. This might arguably have been
Looks good.
Mandy
On 10/19/17 8:29 AM, Erik Joelsson wrote:
In the change for JDK-8189094 I accidentally broke testing in Mach 5.
The problem is in jib-profiles.js where the definition of
boot_jdk_home is no longer defined globally in the common object, and
because of this, JT_JAVA does not g
Looks good.
Mandy
On 10/19/17 8:40 PM, Kumar Srinivasan wrote:
Hello,
Please review build change to enable the javadoc tool to produce
concise API
documentation for those classes that override a method without
changing its
specification see [2], this change simply enables that feature in the
On 10/26/17 2:57 AM, Magnus Ihse Bursie wrote:
A third option is to remove the support for link-time-opt entirely, if
it's not really used.
* src/java.base/unix/native/include/jvm_md.h and
src/java.base/windows/native/include/jvm_md.h:
These files define a public API, and contain non-trivi
On 10/26/17 1:34 PM, coleen.phillim...@oracle.com wrote:
On 10/26/17 2:47 PM, mandy chung wrote:
On 10/26/17 2:57 AM, Magnus Ihse Bursie wrote:
A third option is to remove the support for link-time-opt entirely,
if it's not really used.
* src/java.base/unix/native/include/jvm_md.
On 10/27/17 7:08 AM, coleen.phillim...@oracle.com wrote:
On 10/27/17 9:37 AM, David Holmes wrote:
The one file that is needed is a hotspot file - jvm.h defines the
interface that hotspot exports via jvm.cpp.
If you leave jvm.h in hotspot/prims then a very large chunk of your
boilerplate
On 11/1/17 11:09 AM, coleen.phillim...@oracle.com wrote:
So, we have a variety of opinions. Please open another ticket to
discuss this.
https://bugs.openjdk.java.net/browse/JDK-8190484
Mandy
This is a follow-up on JDK-8189611 that defines a new public API to
return a stream of versioned entries and to return the real name of a
JAR entry. JDK-8189611 leaves jdeps untouched because jdeps is compiled
with the boot JDK.
This patch includes:
(1) changes the build not to build jdk.jdep
jconsole checks if it uses windows LAF (
com.sun.java.swing.plaf.windows.WindowsLookAndFeel class. And also
reflectively access the fields in
com.sun.java.swing.plaf.windows.TMSchema$Part to workaround some issue.
Mandy
On 11/28/17 1:38 PM, Phil Race wrote:
I see this opens was moved to plat
On 12/4/17 9:33 AM, Erik Joelsson wrote:
Hello Magnus,
The -copy targets are currently only being generated for
modules that have make/copy/Copy-.gmk makefiles present. By
removing make/copy/Copy-jdk.accessibility.gmk and
make/copy/Copy-jdk.jdwp.agent.gmk, those targets are no longer create
On 12/4/17 12:40 PM, Magnus Ihse Bursie wrote:
Technically, it's of course possible. But it does not fit very well
with the current DeclareRecipesForPhase. I agree with Erik, that for
now the reasonable approach is to have files that only include
CopyCommon. We can consider for future updates
This looks fine to me.
Mandy
On 12/4/17 3:21 PM, Erik Joelsson wrote:
To be able to bump the classfile version in JDK 10, we need to be able
to build certain jar files using the newly built jar tool during the
build. This patch enables overriding of the jar cmd in the build.
Bug: https://bugs
Looks good to me.
Mandy
On 12/4/17 3:48 PM, Erik Joelsson wrote:
We have a race when building jdk.rmic.interim. This is caused by
CompileInterimLangtools.gmk and CompileInterimRmic.gmk using the same
modular output directory ($(BUILDTOOLS_OUTPUTDIR)/interim_modules),
and then makefiles runnin
On 12/4/17 3:59 PM, Magnus Ihse Bursie wrote:
And classfile_constants.h is also distributed with the image. I am
unsure of the intent/history. To play it safe i will just bump the
number.
Hmmm - that seems wrong. jvm.h is not an exported external interface
AFAIK. And we just moved it so I do
$MODULE-graph.png to $MODULE/module-graph.png change looks fine.
Mandy
On 2/2/18 1:42 PM, Jonathan Gibbons wrote:
Please review changes, including a couple of small build changes, to
reorganize the generated
documentation into per-module directories.
Build folk: the changes are just to move t
+1 Mandy
On 2/5/18 5:25 PM, David Holmes wrote:
It's time to increment the actual version to 11 for JDK 11.
Joe Darcy and I have worked through numerous test issues that delayed
the update and I've been addressing a number of issues in hotspot
related to obsolete/expired flag warnings. I hav
Hi Lance,
Great to see this JEP moving along. I reviewed all changes except
test/langtools/tools/javac tests.
Looks fine overall. Minor comments:
src/java.base/share/lib/security/default.policy
- no change in this file.
test/jdk/tools/jmod/hashes/HashesTest.java
test/jdk/tools/launcher/modul
Jon, Kumar,
This is a regression from JDK-8195795 that generates
but module-summary.html
is under ${MODULE} directory. The correct link should be
a href="module-graph.png">...
Lance - I include make/Docs.gmk fix here since the docs hangs.
Are you going to push a fix for it? If not, I can crea
Good. I see you pushed the fix to Docs.gmk.
Kumar, Jon - can you please review this patch?
diff --git a/make/jdk/src/classes/build/tools/taglet/ModuleGraph.java
b/make/jdk/src/classes/build/tools/taglet/ModuleGraph.java
--- a/make/jdk/src/classes/build/tools/taglet/ModuleGraph.java
+++ b/make/j
+1
Mandy
On 2/14/18 1:45 PM, sangheon.kim wrote:
Hi all,
Could I have some reviews for CMM removal?
This is closed CR but some public codes also need small modifications.
This CR is for removing stuff related to an Oracle JDK module/package.
Changes are just removing CMM from lists or in a te
+1
Mandy
On 2/20/18 11:47 AM, Magnus Ihse Bursie wrote:
The file jdk.internal.vm.compiler/module-info.java.extra is generated
on build time. On systems with non-sorted output from ls and find, the
file contents will change and thus not be reproducible.
Fix is to sort file system information
+1
Mandy
On 3/12/18 11:26 AM, Claes Redestad wrote:
Hi,
during build we use an interim image to generate some optimization
information,
e.g., the input for generate-jli-classes jlink plugin for the real
build. Turns out
jlinking the interim-image picks up the output from such training
runs,
Looks okay.
Mandy
On 3/14/18 5:56 AM, Chris Hegarty wrote:
This is a review request to remove remaining vestiges of
Java_sun_reflect_Reflection_getCallerClass.
JDK-8179424 removed terminally deprecated
jdk.unsupported/sun.reflect.Reflection.getCallerClass(int), these
references are to the no
This is a very good change and no more mapfile to maintain!!
Please do file JBS issues for the component teams to clean up their
exports.
Mandy
On 3/23/18 7:30 AM, Erik Joelsson wrote:
I have looked at the build changes and they look good.
Will you file followups for each component team to
On 4/13/18 4:15 AM, Jonathan Gibbons wrote:
Please review an initial implementation for the feature described in
JEP 330: Launch Single-File Source-Code Programs.
The work is described in the JEP and CSR, and falls into various parts:
* The part to handle the new command-line options is in t
On 4/25/18 8:53 AM, Jonathan Gibbons wrote:
On 04/12/2018 10:20 PM, mandy chung wrote:
This looks quite good to me. One small comment on the source
launcher Main class:
122 } catch (InvocationTargetException e) {
123 // leave VM to handle the stacktrace, in the
On 5/4/18 2:59 PM, Jonathan Gibbons wrote:
Here's an update to the previously proposed patch for JEP 330: Launch
Single-File Source-Code Programs.
It includes all review feedback so far. The changes are mostly minor,
but with the addition of more test cases.
The webrev includes a delta-webre
I reviewed the delta-webrev (v3). Looks good. Thanks for fixing
missing newlines in launcher.properties
Mandy
On 5/30/18 12:00 PM, Jonathan Gibbons wrote:
Please review a minor update to the proposed implementation of JEP 330.
The primary change is to disallow the use of the "shebang" featur
Looks good. The build is much simplified.
Modules.gmk
include_in_jdk can be removed since it should always be true.
In fact build.properties support can be removed some day.
Mandy
On 6/1/18 3:02 PM, Erik Joelsson wrote:
Since JDK 9 and modules, the idea of a prebuilt JRE is no longer
prov
+1
Mandy
On 6/15/18 11:12 AM, Erik Joelsson wrote:
Due to a typo in spec.gmk.in, the platform specific include files have
lost their platform sub directory in the jdk image include dir.
Bug: https://bugs.openjdk.java.net/browse/JDK-8203667
Webrev: http://cr.openjdk.java.net/~erikj/8203667/we
http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8205627/webrev.00
ExtLink taglet generates an external link to a JDK documentation page of
a specific release. This patch replaces the hardcoded value with the
value of a system property "extlink.spec.version" passed to the javadoc
at runtime.
+1
Mandy
On 6/27/18 12:48 PM, Daniel Fuchs wrote:
Hi,
My fix for 8205397 [1] includes a change to
make/gensrc/Gensrc-jdk.hotspot.agent.gmk that was not intended:
diff --git a/make/gensrc/Gensrc-jdk.hotspot.agent.gmk
b/make/gensrc/Gensrc-jdk.hotspot.agent.gmk
--- a/make/gensrc/Gensrc-jdk.
"docs-reference" target fails with `extlink.spec.version` system
property not set. It's a regression caused by JDK-8205627.
docs-reference is built with BootJDK javadoc that also uses
ExtLink taglet and so make/Docs.gmk needs to be adjusted to set
the system property in $JAVADOC_CMD.
The fix is
Thanks. I removed the extra line.
Mandy
On 7/3/18 10:52 AM, Erik Joelsson wrote:
Looks good to me. There is an extra newline added at 104 which probably
shouldn't be there.
/Erik
On 2018-07-03 10:48, mandy chung wrote:
"docs-reference" target fails with `extlink.spec.
Hi Jiangli,
On 6/28/18 4:15 PM, Jiangli Zhou wrote:> webrev:
http://cr.openjdk.java.net/~jiangli/8202035/webrev.00/
RFE: https://bugs.openjdk.java.net/browse/JDK-8202035?filter=14921
Good work. I'm glad to see a pretty good startup improvement.
I reviewed java.base change that looks good.
+1
Mandy
On 7/9/18 9:40 AM, Erik Joelsson wrote:
Hello,
The docs bundle is missing some of the legal notices from the
jdk.javadoc module. It should just include all the legal files from that
module. This patch removes the explicit list and uses wildcard to get
all the files instead.
Bug:
1 - 100 of 443 matches
Mail list logo
