Re: [rfc] macros and macro usage

2008-06-14 Thread Denys Vlasenko
On Saturday 14 June 2008 21:20, Cristian Ionescu-Idbohrn wrote: Shouldn't this: USE_FEATURE_UDHCPC_ARPING(OPTBIT_a,) be prefered, instead of this: #if ENABLE_FEATURE_UDHCPC_ARPING OPTBIT_a, #endif Yes, generally, if USE_xxx(foo) doesn't stretch across more than one line.

Re: [rfc] macros and macro usage

2008-06-15 Thread Denys Vlasenko
On Sunday 15 June 2008 16:48, Cristian Ionescu-Idbohrn wrote: On Sun, 15 Jun 2008, Bernhard Fischer wrote: USE_IF_FEATURE_X and SKIP_IF_FEATURE_X would be better. I don't think explicitely adding the implied _IF buys anything. True. Costs 3 extra characters, but makes more obvious

Re: [RFC] strrstr function in libbb failes on some corner cases

2008-06-15 Thread Denys Vlasenko
On Sunday 15 June 2008 23:06, Tito wrote: Hi, while inspecting the last changes in busybox code I hit some issues in libbb/strrstr.c. The strrtstr function fails on some corner cases of a little test program I wrote (and bombs out on NULL pointers): char* strrstr(const char *haystack, const

Re: pxe server support.

2008-06-16 Thread Denys Vlasenko
On Thursday 24 April 2008 11:26, Pascal Bellard wrote: Hello, Please find attached a patch-file to add pxe server support. Used by http://www.slitaz.org/en function old new delta tftp_protocol 1465

Re: udhcpc in 1.10.3 doesn't like my WLAN card

2008-06-16 Thread Denys Vlasenko
On Monday 16 June 2008 16:18, SAMUEL Dinesh wrote: Hello We have the same problem as described in this link. http://busybox.net/lists/busybox/2008-June/031835.html We don't use WLAN card. Just the two Ethernet cards included in the taihu evaluation board (ppc 405ep). We tried the

Re: Busybox-1.10.3: ENABLE_FEATURE_TASKSET_FANCY - cpu_set_t undefined

2008-06-17 Thread Denys Vlasenko
On Tuesday 17 June 2008 05:48, [EMAIL PROTECTED] wrote: Hi; I turn on ENABLE_FEATURE_TASKSET_FANCY and cpu_set_t is undefined. Linux kernel source has cpumask_t defined in include/linux/cpumask.h. Please advise. Against which libc (glibc? uclibc? version?) do you build? -- vda

Re: udhcpc in 1.10.3 doesn't like my WLAN card

2008-06-17 Thread Denys Vlasenko
On Tuesday 17 June 2008 15:41, Alexander Griesser wrote: Denys Vlasenko wrote: | I've attached this strace output. | | Hmmm. Does it help if you delete this code block? Can't test this at the moment, because I switched to the opensource ralink driver which works a treat. But when I get

Re: udhcpc in 1.10.3 doesn't like my WLAN card

2008-06-17 Thread Denys Vlasenko
On Tuesday 17 June 2008 15:45, Alexander Griesser wrote: Denys Vlasenko wrote: | We tried the solution supplied in the topic linked below and it worked for | us. | | I see nothing linked below. Please let me know what exactly did you try, | I want to make this fix available to others. I

Re: [PATCH] fix last corner case in strrstr.c

2008-06-18 Thread Denys Vlasenko
On Tuesday 17 June 2008 21:38, Tito wrote: this patch fixes this with no size increase: ./test 'baaabaaab' vs. 'aaa' : PASSED 'baaabb' vs. 'aaa' : PASSED 'baaabaab' vs. 'aaa' : PASSED 'aaa'vs. 'aaa' : PASSED 'aaa'vs. 'a' : PASSED

Re: udhcpc in 1.10.3 doesnt like my WLAN card

2008-06-19 Thread Denys Vlasenko
On Thursday 19 June 2008 14:43, Cristian Ionescu-Idbohrn wrote: The problem seems to be that your wlan-card does not see/catch the dhcp-offer. Cristian, this is not true. In tcpdump I see This is the packet from us: 14:20:27.629001 IP (tos 0x0, ttl 64, id 0, offset 0, flags [none], proto:

Re: udhcpc in 1.10.3 doesnt like my WLAN card

2008-06-20 Thread Denys Vlasenko
On Thursday 19 June 2008 22:22, Cristian Ionescu-Idbohrn wrote: On Thu, 19 Jun 2008, Denys Vlasenko wrote: On Thursday 19 June 2008 14:43, Cristian Ionescu-Idbohrn wrote: The problem seems to be that your wlan-card does not see/catch the dhcp-offer. Cristian, this is not true

Re: udhcpc in 1.10.3 doesnt like my WLAN card

2008-06-20 Thread Denys Vlasenko
On Friday 20 June 2008 09:18, SAMUEL Dinesh wrote: Hello, Hope you remember that the problem I have is not on a Wireless Card. The kernel and all the tools that I am using are not fancy tools. The problem must come from 'BPF filter' because when I comment this line the DHCPC works

Re: MODPROBE: next generation

2008-06-20 Thread Denys Vlasenko
On Tuesday 17 June 2008 19:24, [EMAIL PROTECTED] wrote: 0. Intro depmod + modprobe is some kind of complicated codec. Though the syntax of modprobe.conf and friends is human-friendly most of module dependencies is intrinsic and are hardly a subject to be customized manually. du modules.*

Re: Ответ: MODPROBE: next generation

2008-06-20 Thread Denys Vlasenko
On Thursday 19 June 2008 18:15, Vladimir Dronnikov wrote: 2. BB depmod right now generates (having FEATURE_ALIAS defined, my case) modules.dep which can not be parsed correctly with BB modprobe. This is modprobe's issue. Sounds like depmod issue to me. The goal should be depmod generates

Re: start-stop daemon regession

2008-06-20 Thread Denys Vlasenko
On Friday 20 June 2008 17:04, walter harms wrote: Can you test current svn? If that works, we can just go ahead and backport it. hi denis, yep that is what we have done. we just replaced the 10.3 version with the svn version. at least no more daemons can be started :) FYI: while

Re: MODPROBE: next generation

2008-06-20 Thread Denys Vlasenko
On Friday 20 June 2008 17:05, Bernhard Fischer wrote: On Fri, Jun 20, 2008 at 04:58:04PM +0200, Denys Vlasenko wrote: We already have open_transformer(), so you just call fd = open_transformer(gzfile_fd, unpack_gz_stream, gunzip); and voila - you can gunzip file on the fly :) Can we

Re: BB vi bug

2008-06-20 Thread Denys Vlasenko
On Friday 20 June 2008 17:42, walter harms wrote: Hello Denys, can you please look at vi.c coredump mail ? I found that that stupid_insert() can return NULL (what is never checked) and therefore can crash vi. it is not a security issue but very annoying. unfortunately is that a core

Re: [PATCH]: Create vim - vi alias

2008-06-20 Thread Denys Vlasenko
On Friday 20 June 2008 19:10, [EMAIL PROTECTED] wrote: On Jun 20 2008, Bernhard Fischer wrote: On Fri, Jun 20, 2008 at 11:55:17AM -0500, [EMAIL PROTECTED] wrote: Hello, I'm not sure if this would be useful to anyone else. On our embedded product we don't have support for shell

Re: RTC and date command

2008-06-21 Thread Denys Vlasenko
On Saturday 21 June 2008 07:11, Midhun A wrote: I am working on Freescale's i.MX21 RTC. I have a driver which does the basic initialization of the RTC and sets and reads time from the RTC. The RTC is working perfectly fine. When I use the date command of busybox, it seems that busybox picks up

Re: BB vi bug

2008-06-21 Thread Denys Vlasenko
On Saturday 21 June 2008 16:04, walter harms wrote: Since text_hole_make() does not return NULL anymore this function can be simplified also; btw: since text_hole_make(p,x) never changes p it could become void. This will necessitate p++ at each callsite. #if ENABLE_FEATURE_VI_YANKMARK \

Re: back to square 2

2008-06-21 Thread Denys Vlasenko
On Saturday 21 June 2008 16:29, walter harms wrote: hi denis, it seems that the patch has exposed some other error also: again clipping some data into vi it crashes. Now by a different reason: Program received signal SIGSEGV, Segmentation fault. 0x0804f27c in char_insert (p=0x4018b006 ,

Re: [PATCH] dpkg: create_list: zero terminate list in loop

2008-06-21 Thread Denys Vlasenko
On Thursday 05 June 2008 13:53, Peter Korsgaard wrote: From: Peter Korsgaard [EMAIL PROTECTED] Saves a few bytes: function old new delta create_list 124 103 -21

Re: [patch] editors/vi.c: compile error

2008-06-22 Thread Denys Vlasenko
On Sunday 22 June 2008 12:45, Cristian Ionescu-Idbohrn wrote: editors/vi.c: In function 'do_cmd': editors/vi.c:3643: error: expected ')' before 'readonly_mode' editors/vi.c:3643: error: expected statement before ')' token Attached patch, possible workaround. Applied both, thanks! -- vda

Re: BB vi bug

2008-06-23 Thread Denys Vlasenko
On Monday 23 June 2008 17:43, walter harms wrote: hi list, since i was unable to find the root cause for the crash. I suspected this could be a compiler error. So i have tried this on an other computer (other version glibc, gcc, 64bit etc) and the bug occurs again. so i guess its a real bug.

Re: BB vi bug

2008-06-23 Thread Denys Vlasenko
On Monday 23 June 2008 19:18, walter harms wrote: hi list, while testing to find a more easy way to produce the bug i notice that odd behavier here: 1. please note the ^@ i can produce that with a i cr in the first line 2. there are clearly 3 lines but the systems thinks i am in line 4

Re: startx from init

2008-06-24 Thread Denys Vlasenko
On Tuesday 24 June 2008 12:49, Antoine Martin wrote: Hi, I'm trying to start X from either /etc/init.d/rcS or from /etc/inittab But whatever command I use (startx, xinit or just plain Xorg) it seems the server cannot get hold of the mouse and keyboard... If I login via ssh and run the

Re: BB vi bug

2008-06-24 Thread Denys Vlasenko
On Tuesday 24 June 2008 09:59, walter harms wrote: Denys Vlasenko wrote: On Monday 23 June 2008 19:18, walter harms wrote: hi list, while testing to find a more easy way to produce the bug i notice that odd behavier here: 1. please note the ^@ i can produce that with a i cr

Re: MODPROBE: next generation

2008-06-24 Thread Denys Vlasenko
On Monday 23 June 2008 19:02, [EMAIL PROTECTED] wrote: Hello, Denys! Made a patch: 1. lsmod, modprobe, rmmod, depmod retain compatible interface: 1717 octets for all. Wow. 2. insmod: do we really need to publish it as applet? Ja ja. We love our users, we don't want to upset them by

Re: MODPROBE: next generation

2008-06-24 Thread Denys Vlasenko
On Tuesday 24 June 2008 18:00, Denys Vlasenko wrote: On Monday 23 June 2008 19:02, [EMAIL PROTECTED] wrote: Hello, Denys! Made a patch: 1. lsmod, modprobe, rmmod, depmod retain compatible interface: 1717 octets for all. Wow. 2. insmod: do we really need to publish it as applet

Re: mount command fails with 'relatime' kernel option

2008-06-24 Thread Denys Vlasenko
Soory for extra late reply. On Tuesday 18 December 2007 17:29, Michele Sanges wrote: Pity, you did non specify strace -s 512 option and we don't see full strings. Can you redo it? Yes, are the attached files strace_1 and strace_2 respectively. Can you also check whether busybox's

Re: BB vi bug

2008-06-24 Thread Denys Vlasenko
On Tuesday 24 June 2008 18:30, walter harms wrote: hi Denys, i guess the memmove is not needed at all. Then ^@ seems to appear only when i run vi in gdb. i am somewhat confused as i has never see this before. I reproduced it. memmove is needed. on the other since i can still reproduce my

Re: BUG in mount nfs, proto=xyz

2008-06-24 Thread Denys Vlasenko
On Friday 13 June 2008 16:47, T. Eichstädt wrote: Hello, I have discovered an error in mount.c. When trying to mount a nfs share with the option -o proto=tcp... the mount command bails out with an error that indicates that it can't convert tcp into a numeric value. That error occurs

Re: MODPROBE: next generation

2008-06-24 Thread Denys Vlasenko
On Tuesday 24 June 2008 23:48, [EMAIL PROTECTED] wrote: Hello, Denys! Made a new patch. Tried to fix the issues you pointed out. + do { + /* search for the first char in word */ + ptr = memchr(ptr, *word, len - (ptr - (char*)the_module)); + if

1.11.0 and 1.10.4 are out

2008-06-25 Thread Denys Vlasenko
Sizes of busybox-1.10.4 and busybox-1.11.0 (with equivalent config, static uclibc build): textdata bss dec hex filename 800675 6367080 808391 c55c7 busybox-1.10.4 798392 6116900 805903 c4c0f busybox-1.11.0 New applets: inotify (Vladimir Dronnikov), man

Re: Bummer, could not run '/etc/init.d/rcS': No such file or directory

2008-06-26 Thread Denys Vlasenko
On Thursday 26 June 2008 12:32, Hinko Kocevar wrote: Juliana Su wrote: Hi, Is anybody familiar with the Bummer, could not run '/etc/init.d/rcS': No such file or directory error message? You run busybox older than 1.3.0, The message is coming from here: /* Now run it.

Re: 1.11.0 and 1.10.4 are out

2008-06-26 Thread Denys Vlasenko
On Thursday 26 June 2008 14:30, Cristian Ionescu-Idbohrn wrote: Great :) But could you please fix this too: http://busybox.net/downloads/fixes-1.10.4/ The requested URL /downloads/fixes-1.10.4/ was not found on this server. Why? There is nothing so far... -- vda

Re: 1.11.0 and 1.10.4 are out

2008-06-26 Thread Denys Vlasenko
On Thursday 26 June 2008 10:30, Marc Leeman wrote: 798392 6116900 805903 c4c0f busybox-1.11.0 modutils doesn't seem to compile on powerpc, att'd patch. I stuck with the 1.10.3 implementation that didn't include the defines in the patch, adding a powerpc define would also solve

Re: Bummer, could not run '/etc/init.d/rcS': No such file or directory

2008-06-26 Thread Denys Vlasenko
On Thursday 26 June 2008 16:19, Juliana Su wrote: Hi All, Thanks for your quick responses. Yes, /etc/init.d/rcS does exist and it is executable. I doubt it is executable at that point. It is a script, right? Does its #!/path/to/interpreter line point to existing (at that point) executable?

Re: 1.11.0 and 1.10.4 are out

2008-06-26 Thread Denys Vlasenko
On Thursday 26 June 2008 16:20, Cristian Ionescu-Idbohrn wrote: On Thu, 26 Jun 2008, Denys Vlasenko wrote: On Thursday 26 June 2008 14:30, Cristian Ionescu-Idbohrn wrote: Great :) But could you please fix this too: http://busybox.net/downloads/fixes-1.10.4/ The requested URL

Re: 1.11.0 and 1.10.4 are out

2008-06-26 Thread Denys Vlasenko
On Thursday 26 June 2008 16:16, Marc Leeman wrote: Strange. 1.10.3 has absolutely the same modutils. right? nope. [EMAIL PROTECTED] diff]$ diff -Nrup busybox-1.10.3/modutils/ busybox-1.11.0/modutils/ |wc -l 911 You said I stuck with the 1.10.3 implementation and I understood it as

Re: ping illegal instruction error in buidroot with busybox

2008-06-26 Thread Denys Vlasenko
On Thursday 26 June 2008 20:23, Ram kumar wrote: hi, I have built the filesystem with buildroot snapshot.When i connect my arm AT91SAM9260 target and type a ping command in the console it says illegal instruction.My ifconfig,modprobe,hostname all are working fine.But iam not able to

Re: prevent bufer underflow

2008-06-26 Thread Denys Vlasenko
On Monday 23 June 2008 17:49, walter harms wrote: hi list, this patch adds a check that the address p is larger the current buffer adress text when accessing p-1 because at begining p==text is possible. the first place have a dottext (cursor pos) it could be that p=q is assumed no idea if

Re: [PATCH]: (resend) httpd.c allow serverroot setting in configfile

2008-06-26 Thread Denys Vlasenko
On Thursday 26 June 2008 09:11, walter harms wrote: hi list, i had the local request to add the serverroot setting into the configfile to allow configuration in one place, for more easy deployment. I hesitate to apply it, it seems to be a case of featuritis. Is it really so useful? -- vda

Re: problems to compile busybox 1.10.4

2008-06-27 Thread Denys Vlasenko
On Friday 27 June 2008 13:59, Reinhard Thies wrote: Hi, I am cross compiling busybox using eldk 4.1 (ARCH=ppc CROSS_COMPILE=ppc_4xx- ) and got the following error: CC libbb/bb_qsort.o CC libbb/bb_strtonum.o libbb/bb_strtonum.c: In function 'ret_ERANGE':

Re: Some patchs

2008-06-27 Thread Denys Vlasenko
On Thursday 26 June 2008 16:17, Pascal Bellard wrote: Hello, Udhcpc: do not hang when network is down http://hg.slitaz.org/wok/raw-file/be0892d9efd5/busybox/stuff/busybox-1.11.0-dhcpc.u Actually, I want to hang (actually, retry forever) when network is down. I run udhcpc indefinitely, and I

Re: Some patchs

2008-06-27 Thread Denys Vlasenko
On Thursday 26 June 2008 16:17, Pascal Bellard wrote: unlzma: memory leak http://hg.slitaz.org/wok/raw-file/be0892d9efd5/busybox/stuff/busybox-1.11.0-unlzma.u Good catch. @@ -491,10 +491,14 @@ if (full_write(dst_fd, buffer, buffer_pos) != (ssize_t)buffer_pos) { bad: -

Re: Some patchs

2008-06-27 Thread Denys Vlasenko
On Thursday 26 June 2008 16:17, Pascal Bellard wrote: New feature: stat -m displays file map http://hg.slitaz.org/wok/raw-file/be0892d9efd5/busybox/stuff/busybox-1.11.0-stat.u Does this mimic GNU stat? -- vda ___ busybox mailing list

Re: bunzip2 failure

2008-06-28 Thread Denys Vlasenko
On Saturday 28 June 2008 08:10, Rob Landley wrote: I see. Someone (you or Manuel) optimized variable bitfield reading by reading ahead and changing limit[] format a bit. It's there where bug was hiding. Sometimes limit was ending up being 0x. Which is ok if you look at it as an

Re: SENDMAIL

2008-06-28 Thread Denys Vlasenko
On Saturday 28 June 2008 12:23, [EMAIL PROTECTED] wrote: Here comes the second part of compatibility patch for sendmail. Got rid of -U -P. Instead to authenticate we will use standard url notation: [user:[EMAIL PROTECTED]:port]. M.b. make a libbb func for that? wget will use it. Renamed

Re: fdisk fails to compile

2008-06-28 Thread Denys Vlasenko
On Sunday 29 June 2008 05:57, Poly-p man wrote: I just checked out the svn tree from earlier today... this bug has been present for quite a while, though. I have a toolchain for i486-linux-uclibc- set up and working (thanks to buildroot). When I manually (with the cross-compiler config

Re: fdisk fails to compile

2008-06-28 Thread Denys Vlasenko
On Sunday 29 June 2008 06:44, Poly-p man wrote: On Sun, Jun 29, 2008 at 06:38:11AM +0200, Denys Vlasenko wrote: Liar. :) You have this in your .config: CONFIG_FDISK_SUPPORT_LARGE_DISKS=y -- vda wow... you mean I've been missing that option for 4 months straight??? Yup. You needed

Re: Ответ: SENDMAIL

2008-06-30 Thread Denys Vlasenko
On Sunday 29 June 2008 11:31, Vladimir Dronnikov wrote: Q: I'm getting crazy of what people meant when they invented sendmail interface: where sender address is supposed to be obtained from? From OPTIONAL -f parameter? From 'From: ' header? From $USER being appended by ?$HOSTNAME? From

Re: missing vi on busybox

2008-06-30 Thread Denys Vlasenko
On Monday 30 June 2008 17:44, Darek wrote: Hi, I have BB v. 06 on my router, and there's no vi editor out there. How can I get one and install it? which version should be that? Download http://busybox.net/downloads/busybox-1.11.0.tar.bz2, run make menuconfig and set needed options (correct

Re: missing vi on busybox

2008-06-30 Thread Denys Vlasenko
On Monday 30 June 2008 18:21, Darek wrote: how can I download it to my router? wget does not seem to work. # wget http://www.busybox.net/downloads/busybox-1.11.0.tar.bz2 wget: www.busybox.net: Unknown host I meant download to your PC. You surely can't compile stuff on the router, you don't

Re: [PATCH] start-stop-daemon: close extra fds on --background

2008-07-01 Thread Denys Vlasenko
On Tuesday 01 July 2008 10:27, Andreas Wetzel wrote: hi again, in start-stop-daemon, if --background is given, i think we should completely detach the called process, including closing all extra file-descriptors. for non-mmu, this seems to be the case. but if BB_MMU is set, we do not

Re: [PATCH] start-stop-daemon: close extra fds on --background

2008-07-01 Thread Denys Vlasenko
On Tuesday 01 July 2008 10:53, Roy Marples wrote: On Tuesday 01 July 2008 09:27:22 Andreas Wetzel wrote: hi again, in start-stop-daemon, if --background is given, i think we should completely detach the called process, including closing all extra file-descriptors. for non-mmu, this

Re: [PATCH] start-stop-daemon: close extra fds on --background

2008-07-01 Thread Denys Vlasenko
On Tuesday 01 July 2008 12:25, Roy Marples wrote: On Tuesday 01 July 2008 13:01:56 Denys Vlasenko wrote: ssd: do not stat -x EXECUTABLE, it is not needed anymore Then userland won't catch an error with ssd --background when the file does not exit :/ Please re-consider

Re: [PATCH] start-stop-daemon: close extra fds on --background

2008-07-01 Thread Denys Vlasenko
On Tuesday 01 July 2008 12:55, Roy Marples wrote: On Tuesday 01 July 2008 13:44:52 Denys Vlasenko wrote: On Tuesday 01 July 2008 12:25, Roy Marples wrote: On Tuesday 01 July 2008 13:01:56 Denys Vlasenko wrote: ssd: do not stat -x EXECUTABLE, it is not needed anymore Then userland

Re: tar -cjf

2008-07-01 Thread Denys Vlasenko
On Tuesday 01 July 2008 17:21, Vladimir Dronnikov wrote: Oops! # tar -cjf tar.bz2 some-dir Segmentation fault File tar.bz2 is created and contains the only line bzip2: bunzip error 0 But # strace -f -v 22 /bin/tar -cjf tar.bz2 some-dir creates perfectly valid archive. The point

Re: busybox ping not able to reach public IP

2008-07-02 Thread Denys Vlasenko
On Wednesday 02 July 2008 18:59, Ram kumar wrote: I have a ethernet controller,in which the ping works fine. ping 192.168.1.1(my default gateway)i get.. 64 bytes from 192.168.1.1: seq=0 ttl=64 time=46.315 ms the same way when i ping google

Re: busybox ping not able to reach public IP

2008-07-02 Thread Denys Vlasenko
On Wednesday 02 July 2008 21:43, Ram kumar wrote: hi, Wait a second. If you have two interfaces, typically only one of these interfaces is connected to the network which eventually is connected to Internet. That's the network where your default gateway machine is. Why are you trying

Re: busybox ping not able to reach public IP

2008-07-02 Thread Denys Vlasenko
On Wednesday 02 July 2008 23:14, Ram kumar wrote: Please show output of ip a l and ip r l commands. Here is the output... # ip a l 1: lo: LOOPBACK,UP,1 mtu 16436 qdisc noqueue link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo 2:

Re: powerpc: question concerning insmod

2008-07-03 Thread Denys Vlasenko
On Thursday 03 July 2008 21:57, [EMAIL PROTECTED] wrote: Hello, I am attempting to build busybox-1.11.0 for powerpc. I have unsuccessfully tried: 1) custom-built cross compiling toolchain built with crosstool (gcc 4.1.0, glibc 2.3.6) 2) vendor-provided cross compiling toolchain (gcc

Re: -sh: can't access tty; job control turned off - busybox v1.6.0

2008-07-03 Thread Denys Vlasenko
On Thursday 03 July 2008 16:40, Roberto A. Foglietta wrote: 2008/1/12 Roberto A. Foglietta [EMAIL PROTECTED]: 2008/1/12, Tallam, Sreenivas [EMAIL PROTECTED]: Hi All, This has been discussed in the forum before but all of them were focused with a busybox version lower than what I am

Re: BusyBox 1.11.0 man patch for cat

2008-07-04 Thread Denys Vlasenko
On Friday 04 July 2008 09:55, Jason Curl wrote: Hello, I'd like to welcome comments on my first bb patch It's using spaces for indentation. Otherwise looks ok. (it's the first I've needed to do since I've started using 1.0.0). I like the new man applet, but it needs nroff and gtbl.

Re: BusyBox 1.11.0 man patch for cat

2008-07-04 Thread Denys Vlasenko
On Friday 04 July 2008 22:36, Jason Curl wrote: Denys Vlasenko wrote: On Friday 04 July 2008 09:55, Jason Curl wrote: Hello, I'd like to welcome comments on my first bb patch It's using spaces for indentation. Otherwise looks ok. OK, I'll fix this. (it's

Re: BusyBox 1.11.0 man patch for cat

2008-07-05 Thread Denys Vlasenko
On Saturday 05 July 2008 11:02, Jason Curl wrote: I've checked your fix Denys and it also works (I don't get segfaults anymore). I've taken the code from my second patch, checked it against the latest snapshot and found I can reduce the size of man a bit more by removing the two instances

Re: Patch going boing in 1.11.0.

2008-07-06 Thread Denys Vlasenko
On Saturday 05 July 2008 22:40, Rob Landley wrote: The attached patch applies to the linux-2.6.25 kernel source with Kubuntu's patch (and the one in toybox), but busybox patch fails. With patch 2.5.4: # patch -p1 /usr/srcdevel/bbox/fix/busybox.t1/linux-2.6.13-cmdline.patch -R --dry-run

Re: mdev scan

2008-07-06 Thread Denys Vlasenko
On Sunday 06 July 2008 01:13, Rob Landley wrote: On Friday 04 July 2008 17:07:20 Denys Vlasenko wrote: On Friday 04 July 2008 13:39, Holland, John wrote: Hi, I'm having problems scanning usb_endpoint '/dev's on older kernels, 2.6.13 in particular. The usb_endpoints are beyond

Re: MODPROBE: next generation

2008-07-06 Thread Denys Vlasenko
[CC: [EMAIL PROTECTED] On Sunday 06 July 2008 08:27, Vladimir Dronnikov wrote: Hello, Denys! Looked through modutils-small.c. Could you explain the changes you made? I see the code became 500 bytes larger... I made the following changes: * directory scannig is done just once * if we find

Re: Ответ: MODPROBE: next generation

2008-07-06 Thread Denys Vlasenko
On Sunday 06 July 2008 09:38, Vladimir Dronnikov wrote: Understood. Well done! The only spiky edge I see in the following. At system startup when udevtrigger is called (or another technique of populating /dev is used) a lot of modprobes is called in parallel and they all have no plain

Re: Ответ: Ответ: MODPROBE: next generation

2008-07-06 Thread Denys Vlasenko
On Sunday 06 July 2008 13:31, Vladimir Dronnikov wrote: Exactly. And the use of fnmatch() is definitely required, or we loose many modules, particularly PCI. Like this? /* modname alias1 symbol:sym1 alias2 symbol:sym2 */ desc = xstrdup(modinfo[i].desc);

Re: mdev -s fails to create /dev entries

2008-07-06 Thread Denys Vlasenko
On Sunday 06 July 2008 16:06, Vladimir Dronnikov wrote: In particular /sys/block/loop* are the symlinks and mdev -s ceased to mknod /dev/loop*. Are you sure? # ls -l /sys/block/ drwxr-xr-x5 root root0 Jul 6 15:27 hdb drwxr-xr-x4 root root0 Jul 6 15:27

Re: [PATCH] indent comments in /etc/network/interfaces

2008-07-07 Thread Denys Vlasenko
On Monday 07 July 2008 16:40, Natanael Copa wrote: Hi, Angry user reported that after upgrade (of my busybox/uclibc based distro Alpine) the ifup and ifdown utilites choked on his /etc/network/interfaces whenever comments where not on first comlumn. The comment in the code says:

Re: LIBBB: parse_config()

2008-07-07 Thread Denys Vlasenko
[CC: [EMAIL PROTECTED] On Monday 07 July 2008 21:31, [EMAIL PROTECTED] wrote: Please, comment and consider applying. +static void FAST_FUNC replace(char *s, char what, char with) You do not need FAST_FUNCs on static functions. gcc does it itself. At least I try to believe gcc will pick the

Re: LIBBB: parse_config()

2008-07-07 Thread Denys Vlasenko
On Tuesday 08 July 2008 05:47, Denys Vlasenko wrote: [CC: [EMAIL PROTECTED] On Monday 07 July 2008 21:31, [EMAIL PROTECTED] wrote: Please, comment and consider applying. Another comment: the return value should be NULL if file can't be opened; should contain at least one element (NULL

Re: mdev scan

2008-07-07 Thread Denys Vlasenko
Hi, I see that this mdev stuff is not so simple. On Monday 07 July 2008 23:25, Holland, John wrote: I'm having problems scanning usb_endpoint '/dev's on older kernels, 2.6.13 in particular. The usb_endpoints are beyond the constant MAX_SYSFS_DEPTH somewhere under /sys. How much is

Re: Ответ: Ответ: Ответ: MODPROBE: next generation

2008-07-08 Thread Denys Vlasenko
On Sunday 06 July 2008 13:58, Vladimir Dronnikov wrote: Yes. You see some kind of grepping of all modules is needed at startup, so why not to perform it explicitly? On my system it is about 20 modprobe calls with pci: aliases. The time to resolve them currently is an order of magnitude longer

Re: Ответ: Ответ: Ответ: MODPROBE: next generation

2008-07-09 Thread Denys Vlasenko
On Tuesday 08 July 2008 12:16, Vladimir Dronnikov wrote: 3. not read - become a master. open .modules.dep.do-not-edit!!! for exclusive write. all other concurrent modprobes have to wait till the master closes the file. This exclusive write stuff is notorious for breaking on non-local

Re: Ответ: Ответ: Ответ: MODPROBE: next generation

2008-07-09 Thread Denys Vlasenko
2008/7/9 Denys Vlasenko [EMAIL PROTECTED]: On Tuesday 08 July 2008 12:16, Vladimir Dronnikov wrote: 3. not read - become a master. open .modules.dep.do-not-edit!!! for exclusive write. all other concurrent modprobes have to wait till the master closes the file. This exclusive write stuff

Re: Missing libbb/xrealloc_vector.c

2008-07-09 Thread Denys Vlasenko
On Wednesday 09 July 2008 08:58, Cristian Ionescu-Idbohrn wrote: On Tue, 8 Jul 2008, Loïc Grenié wrote: Halp ! A file is missing from last svn. There seems to be more to it: modutils/insmod.c: In function 'obj_allocate_commons': modutils/insmod.c:3085: error: too many arguments

Re: Missing libbb/xrealloc_vector.c

2008-07-09 Thread Denys Vlasenko
On Wednesday 09 July 2008 21:54, Denys Vlasenko wrote: On Wednesday 09 July 2008 08:58, Cristian Ionescu-Idbohrn wrote: On Tue, 8 Jul 2008, Loïc Grenié wrote: Halp ! A file is missing from last svn. There seems to be more to it: modutils/insmod.c: In function

Re: AW: mdev scan

2008-07-09 Thread Denys Vlasenko
On Wednesday 09 July 2008 20:46, Malek wrote: Hi all, there are almost 1 year since I sent my patch to improve mdev and I note that there is always the same problems (symlinks, max depth, CONFIG_SYSFS_DEPRECATED_V2...). My version works well with or without CONFIG_SYSFS_DEPRECATED_V2, I

Re: ifenslave

2008-07-09 Thread Denys Vlasenko
On Wednesday 09 July 2008 17:02, Richard Kojedzinszky wrote: I found that this patch helps ifenslave to work correctly. Kojedzinszky Richard TvNetWork Nyrt. E-mail: krichy (at) tvnetwork [dot] hu PGP: 0x24E79141 Fingerprint = 6847 ECFF EF58 0C09 18A5 16CF 270F 0C6F 24E7 9141

Re: mdev scan

2008-07-10 Thread Denys Vlasenko
On Thursday 10 July 2008 00:18, Bernhard Fischer wrote: What's ACTION_FOLLOWLINKS? I don't see it in the 1.10.0 util-linux/mdev.c... Here: ... recursive_action(/sys/block, ACTION_RECURSE | ACTION_FOLLOWLINKS,

Re: Ответ: Ответ: Ответ: MODPROBE: next generation

2008-07-10 Thread Denys Vlasenko
Vladimir, can you try these two patches on top on current svn? In my limited testing they work. This one fixes a small buglet with gpl and strings finding their way into depfile, and also makes depmod usable. depmod is needed for people which build kernel and install modules, then reboot with

Re: Ответ: Ответ: Ответ: MODPROBE: next generation

2008-07-10 Thread Denys Vlasenko
[CC [EMAIL PROTECTED] 2008/7/10 Vladimir Dronnikov [EMAIL PROTECTED]: and also makes depmod usable... depmod should be synonym to rm -f /path/modules.dep.bb; modprobe, IMO. Tell this to somebody who will be bitten by depmod -F System.map -ae 2.6.30 not working as expected during kernel build.

Re: Ответ: Ответ: Ответ: MODPROBE: next generation

2008-07-10 Thread Denys Vlasenko
THe discussion have to happen on the mailing list! Please CC [EMAIL PROTECTED] 2008/7/10 Vladimir Dronnikov [EMAIL PROTECTED]: I liked the idea of not needing depfile at all and still being reasonably fast. And it's actually YOUR idea - I based my work on your depfile-less patch. :) The

Re: [PATCH] start-stop-daemon: close extra fds on --background

2008-07-10 Thread Denys Vlasenko
Historically, surprising percentage of Unix admins have no clue why $PATH is useful. Whenever they meet a configuration problem causing PATH search to not find their utility, they fix it by using full path. Whereas correct fix is to fix $PATH or copy/move/symplink executable to one of the

Re: [patch] modutils/Config.in: small typo

2008-07-10 Thread Denys Vlasenko
On Thursday 10 July 2008 18:34, Cristian Ionescu-Idbohrn wrote: Index: modutils/Config.in === --- busybox-svn/modutils/Config.in(revision 22766) +++ busybox-svn/modutils/Config.in(working copy) @@ -35,7 +35,7 @@

Re: [PATCH] start-stop-daemon: close extra fds on --background

2008-07-11 Thread Denys Vlasenko
On Fri, Jul 11, 2008 at 9:31 AM, Natanael Copa [EMAIL PROTECTED] wrote: You misunderstood me. I said If something can be made to use PATH in a sense if a program needs to start another program, for God's sake, do NOT hardcode [/usr/][s]bin prefix! In other words: execve(/bin/vi...); // BAD

Re: Unable to compile busybox with latest patches

2008-07-11 Thread Denys Vlasenko
On Fri, Jul 11, 2008 at 3:18 AM, Gururaja Hebbar K R [EMAIL PROTECTED] wrote: Hi, I am trying to build Busybox v 1.11.0 with latest patches on arm9 processor using CodeSourcery arm9 toolchain. Since using 1.11.0 version, i am getting an error saying, unable to find file mkmakefile with

Re: wget error message parsing.

2008-07-11 Thread Denys Vlasenko
On Fri, Jul 11, 2008 at 4:01 PM, Alex Owen [EMAIL PROTECTED] wrote: Hello, I notice that at SVN commit 16528 wget lost the feature where it returned the error status number: http://busybox.net/cgi-bin/viewcvs.cgi/trunk/busybox/networking/wget.c?rev=16528r1=16463r2=16528 This is a real

Re: wget error message parsing.

2008-07-11 Thread Denys Vlasenko
On Friday 11 July 2008 17:25, Alex Owen wrote: Hi there, Thanks for your response. I had done some checking and done a binary chop search of svn to find when the code had changed, and looked at the latest released tag in svn. I purposefully did not submit a bug report as I thought a

Re: cpio does not unpack hardlink to empty files

2008-07-11 Thread Denys Vlasenko
On Friday 11 July 2008 21:54, Bernhard Fischer wrote: Hi, Just mentioning this bug http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=466771 mkdir test touch test/solo touch test/empty echo -n x test/nonempty ln test/empty test/empty1 ln test/nonempty test/nonempty1 mkdir z find test

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=394805 just fixed in svn

2008-07-11 Thread Denys Vlasenko
-- vda ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

Re: Ответ: Static build

2008-07-11 Thread Denys Vlasenko
On Friday 11 July 2008 20:21, Vladimir Dronnikov wrote: I wonder what eats less memory: e.g. running a bunch of static svlogds from runit or run a bunch of BB svlogds? Test it. for example, try scripts/memusage. Standalone static svlogd will use ~8..12kb less than static svlogd from busybox.

Re: mdev remove events not deleting renamed (=) devices nodes

2008-07-12 Thread Denys Vlasenko
On Friday 11 July 2008 19:51, Holland, John wrote: Hi, The attached patch remedies the problem. Applied, thanks! -- vda ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

Re: Ответ: ?????: mdev -s fails to create /dev entries

2008-07-12 Thread Denys Vlasenko
On Saturday 12 July 2008 12:02, Vladimir Dronnikov wrote: It is simple. In order to be compatible to most of kernels mdev has to know what kernel parameters was used: version, SYSFS_DEPRECATED, ... That way we can configure workaround branches in mdev.c at configuration time. As always a user

Re: mdev -s fails to create /dev entries

2008-07-12 Thread Denys Vlasenko
On Saturday 12 July 2008 10:06, Holland, John wrote: That is when you stay within /sys/class or /sys/block. Operating on the whole of /sys and following non-symlinks only will and does find all dev files reliably (don't know about the above mentioned loop devices). Ok, I'll bite. If you

<    3   4   5   6   7   8   9   10   11   12   >