>>>>> "rep" == rep dot nop writes:
> On 14 December 2023 08:22:36 CET, Peter Korsgaard
> wrote:
>>>>>>> "Aleksander" == Aleksander Mazur writes:
>>
>> > Hi,
>> > AFAIR similar problem appli
s, lsusb/lspci are really simple applets, but given that they already
exist we might as well make them more useful.
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
35
.rodata 32683294 +26
--
(add/remove: 5/0 grow/shrink: 2/0 up/down: 379/0) Total: 379 bytes
Signed-off-by: Peter Korsgaard
---
util-linux/lsusb.c | 28 +++-
1 file c
>>>>> "Denys" == Denys Vlasenko writes:
> Applied with some edits, please test current git.
Looks sensible from a quick look. Notice that you added a s/PILE/FILE/
typo:
+//usage: "\n-O PILE Append stdout and stderr t
gt; +xdup2(output_fd, STDERR_FILENO);
> +}
-O is documented to only work with the -b, so wouldn't it make more
sense to add this logic around bb_daemon_helper() instead, then you also
don't have to clean it up again?
--
Bye, Peter Korsgaard
_
https://gitlab.com/buildroot.org/buildroot/-/commit/f1d7155952d9abcad4d5d75b56508114469c2a1c
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
dle.
Apache is running, but it sometimes ends up running out of workers:
[mpm_worker:error] [pid 21136:tid 3080316736] AH00286: server reached
MaxRequestWorkers setting, consider raising the MaxRequestWorkers
setting
Raising MaxRequestWorkers has to be done carefully as othe
ke, Client hello (1):
>>
> The same for buildroot:
> $ curl --verbose https://git.buildroot.net/
> * Trying 140.211.167.122:443...
> curl --verbose https://busybox.net/
> * Trying 140.211.167.122:443...
Yes, it is the same machine.
--
Bye, Peter Korsgaard
it connects and waits too.
I've restarted Apache on the VM, which seems to have improved things
somewhat.
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
t please
provide some more details about what exactly you are trying to do.
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
>>>>> "Peter" == Peter Korsgaard writes:
> GNU binutils in deterministic mode (ar rD or built with
> --enable-deterministic-archives) hard codes file mode to 0644 (NOT 0100644)
> since https://github.com/bminor/binutils-gdb/commit/36e4dce69dd2
> This co
20 20 20 20 20 30 20 20 20 20 20 20 20 |644 0 |
0040 20 20 60 0a | `.|
As a workaround, force the mode bits to S_IFREG, as nothing else makes sense
for ar.
Signed-off-by: Peter Korsgaard
---
archival/libarchive/get_header_ar.c | 6 +-
1
atest" tag is used.
Sorry, I have no idea who owns/builds that docker image, but given that
this was added after 1.32.1 was tagged, I would NOT expect it to be
included in a 1.32.1 build:
https://git.buildroot.org/busybox/log/?h=1_32_stable
--
Bye, Peter Korsgaard
_
>>>>> "Christophe" == Christophe Leroy writes:
Hi,
> As far as I can see, that commit is in 1_32_stable
> See https://git.busybox.net/busybox/commit/?h=1_32_stable
But strangely enough not in 1_33_stable.
--
Bye, Peter Korsgaard
den
< Date: Fri, 15 May 2020 21:54:11 GMT
< Server: Apache
< Strict-Transport-Security: max-age=63072000; includeSubDomains
< Content-Length: 292
< Content-Type: text/html; charset=iso-8859-1
Any ideas?
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
defined and what it is contained.
I don't know about that patch (which hasn't been merged), but you can
run syslogd with the -t option to get it to re-timestamp syslog messages
with the timestamp using whatever timezone syslogd is running under.
--
Bye, Peter Korsgaard
_
--
(add/remove: 0/0 grow/shrink: 1/0 up/down: 7/0) Total: 7 bytes
Signed-off-by: Peter Korsgaard
---
sysklogd/syslogd.c | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/sysklogd/syslogd.c b/sysklogd/syslogd.c
>>>>> "Denys" == Denys Vlasenko writes:
> Should be fixed now (web page updates in ~1 hour)
Thanks!
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
Hi,
I see there is a 1.31.1 tarball
(https://busybox.net/downloads/busybox-1.31.1.tar.bz2), but no git tag
or any mention of it on the website?
Denys, did you perhaps forget to push the tag?
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox
;> > Commit 943e81f5d should be backported to the stable branch. It applies
>> > as-is.
>>
>> very good, this fits my observation - see bugreport:
>> https://bugs.busybox.net/show_bug.cgi?id=12266
> Applied to 1_31_stable, do you guys want the 1.31.1 re
call(__NR_clock_gettime, CLOCK_REALTIME, );
> +#elif ENABLE_FEATURE_DATE_NANO && __TIMESIZE == 64
> +/* Let's only suppor the 64 suffix syscalls for 64-bit time_t.
s/suppor/support/
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
h a new way to apply our old
> patch, I figured I'd share it with the community in case it is useful
> to others.
Why not just add a shell script wrapper that does the chmod after tftp
get?
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
t on "attr" and
> "busybox".
Committed to 2019.02.x and 2019.05.x, thanks.
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
>>>>> "Markus" == Markus Mayer writes:
> dosfstools and busybox may each install mkfs.vfat, so dosfstools must
> be installed before busybox.
> Signed-off-by: Markus Mayer
Committed, thanks.
--
Bye, Peter Korsgaard
__
> mdev as hotplug helper or using the uevent applet.
-s is already scan. Did you mean -d?
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
s. I don't know of any other
solutions besides using a hardcoded max-fd. I believe the classic
limit used by select is 1024.
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
>>>>> "Peter" == Peter Korsgaard writes:
Ping?
Comments, feedback?
> Some syslog producers provide inconsistent timestamps, so provide an option
> to ignore the message timestamps and always locally timestamp. In order to
> implement this, invert the v
ink: 4/0 up/down: 81/0) Total: 81 bytes
Signed-off-by: Peter Korsgaard
---
sysklogd/syslogd.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/sysklogd/syslogd.c b/sysklogd/syslogd.c
index 4265f4f90..e966208c2 100644
--- a/sysklogd/syslog
BROADCAST $NETMASK
> +if [ -n "$ipv6" ] ; then
> +echo "waiting for default ipv6 route set"
> + wait_for_ipv6_default_route
> +fi
> if [ -n "$router" ] ; then
> echo "deleting routers"
> --
> 2.17.1
> ___
> busybox mailing list
> busybox@busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
For some setups (E.G. for supporting different screen resolutions),
positioning the image somewhere else than the top left corner may be
interesting.
Add support for IMG_LEFT/IMG_TOP settings to specify the image location,
similar to how it is done for the progress bar.
Signed-off-by: Peter
: 0x007fac3478c0 ***
Signed-off-by: Peter Korsgaard <pe...@korsgaard.com>
---
archival/dpkg.c | 4
1 file changed, 4 deletions(-)
diff --git a/archival/dpkg.c b/archival/dpkg.c
index 1cd45eda4..da3b0864e 100644
--- a/archival/dpkg.c
+++ b/archival/dpkg.c
@@ -1938,10 +1938,6 @@ int dpk
iginal.
True, but generally you will run into a number of issues when you
combine SW components of significant different "age". E.G. lots of
modern user space requires new kernel features, either explicitly or
simply because nobody has tested it on such old systems.
--
Bye, Peter Korsgaard
___
.de>
Does it really make sense to mix such an ancient kernel with a modern
busybox? Why not just backport this kernel commit?
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
/git.busybox.net/busybox/plain/docs/mdev.txt
> only mentions $MDEV .
That is because those environment variables comes from the kernel when
it invokes the hotplug helper (mdev):
http://lxr.free-electrons.com/source/Documentation/driver-model/porting.
options. It is up to you to supply either
> "ifconfig", "route" and "run-parts" or the "ip" command, either
> via busybox or via standalone utilities.
heh, indeed.
> It's possible
>>>>> "Bernhard" == Bernhard Reutner-Fischer <rep.dot@gmail.com> writes:
> On 17 September 2016 08:07:01 CEST, Peter Korsgaard <pe...@korsgaard.com>
> wrote:
>>>>>>> "David" == David Henderson <dhender...@digi
>>>>> "David" == David Henderson <dhender...@digital-pipe.com> writes:
> Good morning Peter, thanks for your reply. C/C++ is not my forte and
> while it may be readable for you, it may not be for others.
Then use strace as I
>>>>> "David" == David Henderson <dhender...@digital-pipe.com> writes:
> Good morning all, just following up with this!
Please just have a look at networking/ifupdown.c, it is IMHO quite
readable.
Alternative, run strace -f -e execve ifup to see the exact
ted, and not should I add this
> applet into my BB compile. I was just letting the community know
> about the "problem".
Yes indeed, I think CONFIG_IFUPDOWN should select CONFIG_RUN_PARTS.
--
Bye, Peter Korsgaard
___
busybox mailing l
as not installed. Should this
> applet the automatically added to the config when the ifup/down
> commands were added?
As the errors executing run-parts aren't ignored, I would say yes.
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox
ng the wstrdup() fixes the
> issue.
> Signed-off-by: Francis Rounds <francis.rou...@4bridgeworks.com>
Argh, indeed :/
Acked-by: Peter Korsgaard <pe...@korsgaard.com>
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
-fpga: add ts4900-fpga package
> configs: add defconfig for TS-4900
Ehh, I think you wanted to mail buildr...@buildroot.org, not
busybox@busybox.net ;)
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
The udhcpc script may be used to setup fallback configuration (E.G. IPv4LL,
fixed IP address, ..) that also needs to be cleaned up on release (E.G.
when SIGUSR2 is called or on shutdown with -R), so unconditionally call
deconfig.
Signed-off-by: Peter Korsgaard <pe...@korsgaard.
obuild.buildroot.org/?reason=busybox-1.24.1
> I assume you run builds with parallel make (-j X) enabled?
Yes. If you click on the 'end log' links you can see the exact
invocation. Most of our autobuilders afaik use -j4.
--
Bye, Peter Korsgaard
___
.24.1? Do you apply any
patches on top of 1.24.1?
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
nfig.
Mike, have you had a chance to look into it?
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
ypt cronjob :/ Mike, care to
take a look?
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
n anymore to keep using mdev+coldplug.
.. except if you want to run custom scripts when devices are created and
these devices may or may not be added before mdev is configured as the
hotplug handler.
--
Bye, Peter Korsgaard
___
busybox mailing list
bus
t;,
> +* but that's the most seen use-case.
> +*/
> + if (hostname[0] && hostname[0] != '?')
safe_gethostname() already ensures that hostname[0] isn't 0, so the
first check can be removed.
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
e */
>> + if (*s != '\0')
>> + s++; /* skip trailing quote */
> bug, you must be thinking about using strchrnul().
Argh, indeed - Sorry about that.
> Applied with small changes, thanks
Thanks!
--
Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
Similar to the big util-linux version. For !DMESG_PRETTY, the option is
accepted
(but ignored) as well, for compatibility reasons.
Signed-off-by: Peter Korsgaard pe...@korsgaard.com
---
util-linux/dmesg.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/util-linux
From: Peter Korsgaard pe...@korsgaard.com
Similar to the optimization in flashcp. On a Micron n25q128, this speeds up
flash erase from ~180s to ~120s, and allows userspace to do useful work
while erasing as the kernel driver returns as soon as the erase command is
sent to the chip.
bloat-o-meter
for /tmp or similar)
where you can add a handy symlink to the wrapper?
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
walter == walter harms wha...@bfs.de writes:
walter Am 10.09.2013 11:52, schrieb Peter Korsgaard:
ar fields are fixed length text strings (padded with spaces). Ensure
bb_strtou doesn't read past the field in case the full width is used.
The fields are only read once, so the simplest
29 36 +7
--
(add/remove: 0/0 grow/shrink: 2/0 up/down: 27/0) Total: 27 bytes
Signed-off-by: Peter Korsgaard jac...@sunsite.dk
---
If we don't want
To prevent other init scripts from being delayed, udhcpc should
Mark instantly go into background mode (see [1]).
The normal approach is to use ifplugd (the busybox applet) to run the
ifup in the background when it detects a link, and not stall the rest of
the boot process.
--
Bye, Peter Korsgaard
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
Denys == Denys Vlasenko vda.li...@googlemail.com writes:
Denys On Wed, Feb 27, 2013 at 2:14 PM, Peter Korsgaard jac...@sunsite.dk
wrote:
The big run-parts supports a handy --exit-on-error to stop execution on
errors, so lets support it as well.
Upstream doesn't have a short option
Commit 1e43a381 (run-parts: stop providing incompatible short options)
replaced some of the dashes in the usage output with funky unicode versions,
causing garbled output on simple terminals.
Signed-off-by: Peter Korsgaard jac...@sunsite.dk
---
debianutils/run_parts.c |6 +++---
1 file
The big run-parts supports a handy --exit-on-error to stop execution on
errors, so lets support it as well.
Upstream doesn't have a short option for it, but I've used '-e' for busybox.
Signed-off-by: Peter Korsgaard jac...@sunsite.dk
---
debianutils/run_parts.c | 13 ++---
1 file
will probably cause some confusion.
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
Mike == Mike Frysinger vap...@gentoo.org writes:
Mike On Saturday 05 January 2013 18:07:19 Peter Korsgaard wrote:
+#else
+void kmsg_init(void);
+void kmsg_cleanup(void);
+void log_to_kmsg(int pri, const char *msg);
+#endif /* FEATURE_KMSG_SYSLOG
Mike == Mike Frysinger vap...@gentoo.org writes:
Hi,
Mike On Saturday 05 January 2013 18:07:19 Peter Korsgaard wrote:
Why invent our own shared memory circular buffer when the kernel has a
perfectly fine one already?
This can be used as a smaller/simpler alternative to the syslogd IPC
, 7Peer 86.165.245.161:29833/597...,
131072) = 285
Mike write(1, Peer 86.165.245.161:29833/59757..., 279) = 279
Mike maybe the buf[++in] should be buf[in++]
Argh, indeed. So much for last minute fixups. Thanks for the review,
will fixup and resend.
--
Bye, Peter Korsgaard
Mike == Mike Frysinger vap...@gentoo.org writes:
Mike On Tuesday 18 December 2012 14:49:20 Peter Korsgaard wrote:
+ /*
+ kernel 3.5 expects single char printk KERN_* priority prefix,
+ from 3.5 onwards the full syslog facility/priority format is supported
+ */
Mike
490 525 +35
--
(add/remove: 0/0 grow/shrink: 1/0 up/down: 35/0) Total: 35 bytes
Signed-off-by: Peter Korsgaard jac...@sunsite.dk
---
sysklogd/klogd.c |7
-by: Peter Korsgaard jac...@sunsite.dk
---
util-linux/dmesg.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/util-linux/dmesg.c b/util-linux/dmesg.c
index 6505da5..81ba1c9 100644
--- a/util-linux/dmesg.c
+++ b/util-linux/dmesg.c
@@ -59,16 +59,15 @@ int dmesg_main(int
937-933
bb_common_bufsiz1 8193 - -8193
--
(add/remove: 2/26 grow/shrink: 1/6 up/down: 149/-11829)Total: -11680 bytes
Signed-off-by: Peter Korsgaard jac...@sunsite.dk
support which uses it.
Changes since v1:
- Rebased against master
- Reworked based on Mike's feedback:
- Fixed off-by-one in dmesg
- Move kernel version check to kmsg_init()
- Added kmsg_cleanup() similar to ipcsyslog_cleanup()
--
Bye, Peter Korsgaard
On Tue, Dec 18, 2012 at 8:49 PM, Peter Korsgaard jac...@sunsite.dk wrote:
Hi,
Linux 3.5 extended the /dev/kmsg interface for injecting log messages
from user space into the kernel printk buffer to accept (and store) the
full syslog facility/priority value.
The following patch series updates
package)? Arnout,
you mentioned something about a gst-fsl package, which presumably only
works with gstreamer 0.1?
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
Tito == Tito farmat...@tiscali.it writes:
Hi,
Tito Are sure this is busybox stuff? ;-)
Yeah, I also just noticed ;)
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
490 525 +35
--
(add/remove: 0/0 grow/shrink: 1/0 up/down: 35/0) Total: 35 bytes
Signed-off-by: Peter Korsgaard jac...@sunsite.dk
---
sysklogd/klogd.c |7
525 --525
bb_common_bufsiz1 8193 - -8193
--
(add/remove: 2/17 grow/shrink: 0/7 up/down: 84/-10531) Total: -10447 bytes
Signed-off-by: Peter Korsgaard jac
-by: Peter Korsgaard jac...@sunsite.dk
---
util-linux/dmesg.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/util-linux/dmesg.c b/util-linux/dmesg.c
index 6505da5..8641ed6 100644
--- a/util-linux/dmesg.c
+++ b/util-linux/dmesg.c
@@ -59,16 +59,15 @@ int dmesg_main(int
Peter == Peter Korsgaard jac...@sunsite.dk writes:
Hi Denys,
It seems this never got committed?
Timo == Timo Teräs timo.te...@iki.fi writes:
Timo commit e4fa7b7 (limit progress bar flicker) made the progress bar
Timo counter unsigned causing i=0 to never come true.
Peter s/true/false
Timo == Timo Teräs timo.te...@iki.fi writes:
Timo commit e4fa7b7 (limit progress bar flicker) made the progress bar
Timo counter unsigned causing i=0 to never come true.
s/true/false/.
With that changed:
Acked-by: Peter Korsgaard jac...@sunsite.dk
Notice: This bug was not in the patch I
forget the trailing '/' - E.G. compare
http://git.buildroot.net/buildroot/ vs
http://git.buildroot.net/buildroot
Neither I or the osuosl guys have been able to figure out what the
problem is though :/
--
Bye, Peter Korsgaard
___
busybox mailing list
fixed in one of the 3.0.x stable
releases, but that didn't happen.
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
devtmpfs on the embedded devices, but don't right away
see what the problem is).
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
and got the impression
Natanael that they don't work together?
Natanael Maybe I was wrong.
We're atleast doing devtmpfs together with mdev in Buildroot, but as I
mentioned it isn't a configuration that I use personally.
--
Bye, Peter Korsgaard
the default root:root
660 permissions / names are enough, you can get rid of mdev/udev and
still not have to mess around with static device nodes in your rootfs.
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman
to understand? If you target doesn't have a FPU (and
you don't build your kernel with FPU emulation) things are bound to go
wrong when you configure uClibc to use one.
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net
, I'll send an updated patch shortly.
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
) Total: 18 bytes
Signed-off-by: Peter Korsgaard jac...@sunsite.dk
---
networking/httpd.c | 27 +++
networking/httpd_indexcgi.c | 25 +++--
2 files changed, 34 insertions(+), 18 deletions(-)
diff --git a/networking/httpd.c b/networking
REQUEST_URI instead.
Denys Applied, thanks!
Thanks. Any reason why you dropped most of my commit message? Don't you
use 'git am -s' to apply it?
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman
Denys == Denys Vlasenko vda.li...@googlemail.com writes:
Hi,
so looks like wget does something strange with the host header on
the redirection.
Denys Should be fixed by commit 93b4a605263612cf32ad9de746a4fafaf4515115
Something for fixes-1.19.3?
--
Bye, Peter Korsgaard
argument to send_cgi_and_exit() and use it to set
the environment variable correctly.
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
to code.
True. query strings are fairly short, so it probably wouldn't be
significant (and only for the few people using httpd without CGI
support) - Denys, what do you say?
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http
, tptr);
+#else
g_query = tptr;
+#endif
Denys Let's just use xstrcpy().
I don't see any xstrcpy in busybox. Did you perhaps mean xstrdup or
strdupa?
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman
because of send_file_and_exit() / send_cgi_and_exit(). What
is the reason you don't like alloca / strdupa?
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
The memory pointed to by g_query gets overwritten when the index_page
is used, causing URL arguments to get dropped when we fall back to
/cgi-bin/index.cgi.
Work around it by making g_query a deep copy of urlp when CGI support
is enabled, rather than silently dropping them.
Signed-off-by: Peter
The memory pointed to by g_query gets overwritten when the index_page
is used, causing URL arguments to get dropped when we fall back to
/cgi-bin/index.cgi.
Work around it by making g_query a deep copy of urlp when CGI support
is enabled, rather than silently dropping them.
Signed-off-by: Peter
*)g_query, tptr);
Paulius Why not use strdup() instead?
Because we then need to cleanup. We're already using alloca for urlcopy
just above.
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo
walter == walter harms wha...@bfs.de writes:
Hi,
Why not use strdup() instead?
walter Why not use strdupa() instead?
Because I wasn't aware of it. I see we aren't using it anywhere in
busybox today, how portable is it?
--
Bye, Peter Korsgaard
. From a quick look it only seems to only be needed for
start-stop-daemon as the other users either don't exec or do another
fork before executing programs.
I'll send an updated patch shortly.
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox
http://www.win.tue.nl/~aeb/linux/lk/lk-10.html#ss10.3
Signed-off-by: Peter Korsgaard jac...@sunsite.dk
---
debianutils/start_stop_daemon.c |2 +-
include/libbb.h |1 +
libbb/vfork_daemon_rexec.c |7 +++
3 files changed, 9 insertions(+), 1 deletions(-)
diff --git
-by: Peter Korsgaard jac...@sunsite.dk
---
libbb/vfork_daemon_rexec.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/libbb/vfork_daemon_rexec.c b/libbb/vfork_daemon_rexec.c
index a75eafb..40a82e3 100644
--- a/libbb/vfork_daemon_rexec.c
+++ b/libbb/vfork_daemon_rexec.c
://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.17.5503rep=rep1type=pdf
Which does exactly like you propose - So I'll shut up ;)
Thanks!
--
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
1 - 100 of 209 matches
Mail list logo