staniek added a comment.
I've ported quite a few libs to Qt5 and cmake, DEFINE_SYMBOL is not needed at
all.
If this is a way to avoid merge conflicts... well this becoming complex
workaround on its own :) If this was for 2.9 I would't care.
In 3.x there shouldn't exist any *_export.h files if
abrahams added a comment.
OK, I understand now. The problem with doing it personally is that
maintaining separate 2.9 and 3.0 builds on Windows is a huge challenge, and
since installing Windows 10 I have not bothered with 2.9 anymore. It's not
simply adding the export headers, but the many
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/128/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 12 Aug 2015 13:21:07 +
Build duration: 48 min
CHANGE SET
Revision
staniek added a comment.
Like skipping the changes for kexi/, I propose to split the final patch: skip
the proper changes in krita/ and in whatever dirs keeps krita touch for
calligra/2.9 (pigment, some libs/?). And then commit the non-kexi/non-krita
things.
Regarding the exporting extra
kossebau added a comment.
In https://phabricator.kde.org/D183#4278, @abrahams wrote:
OK, I understand now. The problem with doing it personally is that
maintaining separate 2.9 and 3.0 builds on Windows is a huge challenge, and
since installing Windows 10 I have not bothered with 2.9
abrahams added a comment.
Hi Friedrich: thanks for the help. Again since CMake documentation is so
sparse most of this task was mindless replacing for me to get something that
worked. It is easy to simply get rid of the DEFINE_SYMBOLS as long as you are
sure they are redundant.
Things are
abrahams added a comment.
Yes, with the recent change that became the ultimate goal: delete the
xxx_exports.h files. I know the patch is big and messy, but you can see it
includes about half a dozen such deletions. That's the reason why splitting it
into two parts is awkward.
I'll go ahead
kossebau added a comment.
In https://phabricator.kde.org/D183#4272, @abrahams wrote:
Things are not as simple as renaming krita_export.h to kritaimage_export.h.
The former was actually a collection of different symbol definitions. The
intermediate change you're proposing would mean you
kossebau added a comment.
In https://phabricator.kde.org/D183#4274, @staniek wrote:
In 3.x there shouldn't exist any *_export.h files if you ask me.
Yes, multiple persons already changed a few files to be generated, so that
seems an agreed goal :) The initial patch just was only about a
abrahams added a comment.
In https://phabricator.kde.org/D183#4279, @kossebau wrote:
In https://phabricator.kde.org/D183#4278, @abrahams wrote:
OK, I understand now. The problem with doing it personally is that
maintaining separate 2.9 and 3.0 builds on Windows is a huge challenge, and
abrahams added a comment.
In https://phabricator.kde.org/D183#4283, @staniek wrote:
Like skipping the changes for kexi/, I propose to split the final patch: skip
the proper changes in krita/ and in whatever dirs keeps krita touch for
calligra/2.9 (pigment, some libs/?). And then commit the
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=NoOpenGL,compiler=gcc/130/
Project: PLATFORM=Linux,Variation=NoOpenGL,compiler=gcc
Date of build: Wed, 12 Aug 2015 23:31:29 +
Build duration: 10 min
CHANGE SET
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=NoOpenGL,compiler=gcc/130/
Project: PLATFORM=Linux,Variation=NoOpenGL,compiler=gcc
Date of build: Wed, 12 Aug 2015 23:31:29 +
Build duration: 10 min
CHANGE SET
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/130/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 12 Aug 2015 23:31:29 +
Build duration: 53 min
CHANGE SET
Revision
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/calligra%20master%20latest-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/76/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Thu, 13 Aug 2015 02:01:15 +
Build duration: 52 min
CHANGE SET
Revision
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/131/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Thu, 13 Aug 2015 02:44:40 +
Build duration: 49 min
CHANGE SET
Revision
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=NoOpenGL,compiler=gcc/131/
Project: PLATFORM=Linux,Variation=NoOpenGL,compiler=gcc
Date of build: Thu, 13 Aug 2015 02:44:40 +
Build duration: 20 min
CHANGE SET
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=NoOpenGL,compiler=gcc/131/
Project: PLATFORM=Linux,Variation=NoOpenGL,compiler=gcc
Date of build: Thu, 13 Aug 2015 02:44:40 +
Build duration: 20 min
CHANGE SET
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/132/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Thu, 13 Aug 2015 04:24:11 +
Build duration: 51 min
CHANGE SET
Revision
Thanks,
One observation: depending on kdelibs4support causes crashes in kdbus when
nothing like dbus installed/configured. If you use KActionCollection,
global accel implementation uses dbus - crash on startup :/.
(KActionCollection is actually the only reason for Kexi to use libkxmlgui).
I
Hi,
Kexi 3 Alpha has just landed on Windows.
It's an native app with all functionality of the Linux version.
I think some more cleaning up is needed before downloads are available :)
See the screenshots for an early look:
https://forum.kde.org/viewtopic.php?f=220t=127422#p339639
--
regards,
On Wed, 12 Aug 2015, Jaroslaw Staniek wrote:
Thanks,
One observation: depending on kdelibs4support causes crashes in kdbus when
nothing like dbus
installed/configured. If you use KActionCollection, global accel implementation
uses dbus - crash on
startup :/. (KActionCollection is actually the
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/124/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 12 Aug 2015 07:26:15 +
Build duration: 46 min
CHANGE SET
Revision
Congrats! That's looking good :-)
On Wed, 12 Aug 2015, Jaroslaw Staniek wrote:
Hi,
Kexi 3 Alpha has just landed on Windows.
It's an native app with all functionality of the Linux version.
I think some more cleaning up is needed before downloads are available :)
See the screenshots for an
bcooksley changed the visibility of this Differential Revision from All Users
to Public (No Login Required).
REPOSITORY
rCALLIGRA Calligra
REVISION DETAIL
https://phabricator.kde.org/D183
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: abrahams,
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/125/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 12 Aug 2015 08:55:21 +
Build duration: 48 min
CHANGE SET
Revision
On 11 August 2015 at 22:16, Boudewijn Rempt b...@valdyas.org wrote:
I am a bit tired... But how's that related to
https://phabricator.kde.org/D183 ?
Ah, missed this because subscribers were not filled with calligra-devel
entry :/
It's good to do that.
So - good work, Michael please read my
staniek added a subscriber: Calligra-Devel-list.
staniek changed the visibility of this Differential Revision from Public (No
Login Required) to All Users.
REPOSITORY
rCALLIGRA Calligra
REVISION DETAIL
https://phabricator.kde.org/D183
EMAIL PREFERENCES
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/126/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 12 Aug 2015 10:19:20 +
Build duration: 52 min
CHANGE SET
Revision
staniek added a comment.
Yes, a simple macro CalligraAddTestExportMacro.cmake having
calligra_add_test_export_macro(libbasename) macro could be added to
calligra/cmake/modules/. Feel free to add a task for developing it together
with the rest of the patch.
REPOSITORY
rCALLIGRA Calligra
abrahams added a task: T563: Fix Calligra Export Definitions.
REPOSITORY
rCALLIGRA Calligra
REVISION DETAIL
https://phabricator.kde.org/D183
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: abrahams, dkazakov, staniek, rempt, kossebau
Cc:
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/129/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 12 Aug 2015 15:41:35 +
Build duration: 47 min
CHANGE SET
Revision
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/calligra%20calligra-2.9%20stable-qt4/PLATFORM=Linux,Variation=All,compiler=gcc/127/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 12 Aug 2015 11:38:23 +
Build duration: 47 min
CHANGE SET
Revision
33 matches
Mail list logo
