Am 24.04.2015 um 22:52 schrieb Sage Weil:
On Fri, 24 Apr 2015, Danny Al-Gaaf wrote:
Am 24.04.2015 um 19:37 schrieb Sage Weil:
[...]
-- systemd --
Most of the daemons can just get the User=ceph and Group=cpeh lines in the
unit files. The OSD is tricky, though, since we want the prestart
Am 25.04.2015 um 01:34 schrieb Sage Weil:
On Fri, 24 Apr 2015, Ken Dreyer wrote:
Oh, my bad, sorry I missed that part of the pull request! Looks good to me.
Still missing ceph.spec file changes, if you're up for it. :)
I can change the spec files, but do we have finally some user/group IDs
Am 24.04.2015 um 19:37 schrieb Sage Weil:
[...]
-- systemd --
Most of the daemons can just get the User=ceph and Group=cpeh lines in the
unit files. The OSD is tricky, though, since we want the prestart script
to run as root so that it can chown the disk contents if necessary. We
have
Am 10.03.2015 um 09:02 schrieb Loic Dachary:
Hi Danny,
On 10/03/2015 06:59, Danny Al-Gaaf wrote:
Am 10.03.2015 um 00:06 schrieb Loic Dachary:
[...]
Do you know what changes have been done in hammer in src/gmock
?
It seems as if there was no change to src/gmock in hammer
Hi Loic,
this one is a tricky one. I didn't find a smooth/automatic solution yet.
This seems to work:
git checkout master
git merge --no-ff origin/hammer
git mergetool
- for the conflict: select 'local' for src/gmock (this should keep
the changes im master and ignore changes from hammer)
Am 09.03.2015 um 20:35 schrieb Mark Nelson:
On 03/09/2015 02:06 PM, Deneau, Tom wrote:
I'm trying to gather information on what it would take to get packages
for an architecture other than x86_64 up on http://download.ceph.com
What we've done in the past for certain non-X86 architectures
Am 10.03.2015 um 00:06 schrieb Loic Dachary:
On 09/03/2015 18:31, Danny Al-Gaaf wrote:
Hi Loic,
this one is a tricky one. I didn't find a smooth/automatic
solution yet.
This seems to work:
git checkout master git merge --no-ff origin/hammer git
mergetool - for the conflict: select
Am 05.03.2015 um 22:14 schrieb Loic Dachary:
Hi Danny,
Unfortunately it looks like submodule deinit requires a version of
git that's not in precise.
http://gitbuilder.sepia.ceph.com/gitbuilder-ceph-deb-precise-amd64-basic/log.cgi?log=9a0ac62a9cf27573d5345143a3bc6c6b737031db
+ git
Am 05.03.2015 um 19:09 schrieb Loic Dachary:
Hi Danny,
The build of master shows linkage errors:
http://gitbuilder.sepia.ceph.com/gitbuilder-ceph-deb-trusty-amd64-basic/log.cgi?log=60e2bec73ff3970e0c6b44250ce465e6c5dde56f
error: dpkg-shlibdeps: couldn't find library
Am 04.03.2015 um 15:12 schrieb Csaba Henk:
Hi Danny,
- Original Message -
From: Danny Al-Gaaf danny.al-g...@bisect.de To: OpenStack
Development Mailing List (not for usage questions)
openstack-...@lists.openstack.org, ceph-devel@vger.kernel.org
Sent: Sunday, March 1, 2015 3:07:36
Am 04.03.2015 um 05:19 schrieb Deepak Shetty:
On Wed, Mar 4, 2015 at 5:10 AM, Danny Al-Gaaf
danny.al-g...@bisect.de wrote:
Am 03.03.2015 um 19:31 schrieb Deepak Shetty: [...]
[...]
I was curious to understand. IIUC Neutron provides private and
public networks and for VMs to access external
Am 03.03.2015 um 19:31 schrieb Deepak Shetty:
[...]
For us security is very critical, as the performance is too. The
first solution via ganesha is not what we prefer (to use CephFS
via p9 and NFS would not perform that well I guess). The second
solution, to use CephFS directly to the VM would
Am 27.02.2015 um 23:10 schrieb Sage Weil:
This is the first release candidate for Hammer, and includes all
of the features that will be present in the final release. We
welcome and encourage any and all testing in non-production
clusters to identify any problems with functionality, stability,
Am 27.02.2015 um 01:04 schrieb Sage Weil:
[sorry for ceph-devel double-post, forgot to include
openstack-dev]
Hi everyone,
The online Ceph Developer Summit is next week[1] and among other
things we'll be talking about how to support CephFS in Manila. At
a high level, there are basically
Am 09.01.2015 um 16:26 schrieb Sage Weil:
On Fri, 9 Jan 2015, scan-ad...@coverity.com wrote:
** CID 1262114: Uninitialized scalar field (UNINIT_CTOR)
/messages/MOSDRepOp.h: 107 in MOSDRepOp::MOSDRepOp()()
** CID 1262115: Uninitialized scalar field (UNINIT_CTOR)
Hi,
these can be ignored, they are caused by the ASSERT_* handling of the
gtest framework.
Danny
Am 28.10.2014 um 14:16 schrieb scan-ad...@coverity.com:
Hi,
Please find the latest report on new defect(s) introduced to ceph
found with Coverity Scan.
2 new defect(s) introduced to ceph
Hi all,
I've added some new blueprints for Hammer:
* Ceph Security
https://wiki.ceph.com/Planning/Blueprints/Hammer/Ceph_Security
* How to make Ceph enterprise ready:
https://wiki.ceph.com/Planning/Blueprints/Hammer/How_to_make_Ceph_enterprise_ready
* rados: improve ex-/import functionality
...@inktank.com wrote:
Have I mentioned how exciting that is?
Mark
On 04/30/2014 04:14 PM, Samuel Just wrote:
Cool. Looks like we read the same guide on the autotools bit :P. I'm
focusing on instrumenting the OSD op life cycle.
-Sam
On Wed, Apr 30, 2014 at 6:19 AM, Danny Al-Gaaf danny.al-g
Am 03.06.2014 20:55, schrieb Sushma R:
Haomai,
I'm using the latest ceph master branch.
ceph_smalliobench is a Ceph internal benchmarking tool similar to rados
bench and the performance is more or less similar to that reported by fio.
I tried to use fio with rbd ioengine (
Am 30.04.2014 04:21, schrieb Haomai Wang:
So cool!
I remember a telekomcloud guy is also worked for it since last summit.
Correct ... our initial version is/was this:
https://github.com/dalgaaf/ceph/commits/wip-master-bp-systemtap
Danny
On Wed, Apr 30, 2014 at 6:17 AM, Samuel Just
Am 30.04.2014 14:18, schrieb Sage Weil:
Today we are announcing some very big news: Red Hat is acquiring Inktank.
We are very excited about what this means for Ceph, the community, the
team, our partners, and our customers. Ceph has come a long way in the ten
years since the first line of
Hi,
Am 28.02.2014 03:45, schrieb Haomai Wang:
[...]
I use fio which rbd supported from
TelekomCloud(https://github.com/TelekomCloud/fio/commits/rbd-engine)
to test rbd.
I would recommend to no longer use this branch, it's outdated. The rbd
engine got contributed back to upstream fio and is
Hi Sage,
since firefly is frozen and the task is now to focus on stabilization:
how do you plan to handle it on the coverity side?
Is Coverity able use the firefly branch instead of master to get
everything checked on regular bases for the next stable release?
The last Coverity check was Jan
Am 18.10.2013 11:20, schrieb hjwsm1989-gmail:
Hi,all
I get ceph from g...@github.com:ceph/ceph.git
But when I try to build rpm package from the master branch,
It runs error like : No target to Make.
I found there are no file or dirs under src/libs3/ in my mater and next
branch.(all my
Am 17.10.2013 22:29, schrieb Andrew Woodward:
We need to have a reasonable license on this preferably Apache 2.0.
the enovance module is AGPL which can't come in contact with nearly
anything with out causing massive license issues. Starting with any of
the enovance code is a Non-starter as it
Hi,
I've overseen this call, sorry. Is there any meeting results or a log?
I asked because we (Deutsche Telekom AG) forked our puppet-ceph module
from the enovance puppet-ceph (deploying ceph without ceph-deploy) and
we plan to contribute our code back to the community into the source
project.
Hi,
I've opened a pull request with some additional fixes for this issue:
https://github.com/ceph/ceph/pull/478
Danny
Am 30.07.2013 09:53, schrieb Erik Logtenberg:
Hi,
This patch adds two buildrequires to the ceph.spec file, that are needed
to build the rpms under Fedora. Danny Al-Gaaf
Hi,
I think this is a bug in packaging of the leveldb package in this case
since the spec-file already sets dependencies on on leveldb-devel.
leveldb depends on snappy, therefore the leveldb package should set a
dependency on snappy-devel for leveldb-devel (check the SUSE spec file
for leveldb:
, Danny Al-Gaaf wrote:
Hi,
I think this is a bug in packaging of the leveldb package in this case
since the spec-file already sets dependencies on on leveldb-devel.
leveldb depends on snappy, therefore the leveldb package should set a
dependency on snappy-devel for leveldb-devel (check the SUSE
Hi Sage,
no problem I'll review the pull request.
Danny
Am 03.07.2013 07:12, schrieb Sage Weil:
Hi Danny,
Can you review wip-5492? The original ceph_sbindir was introduced by your
patch fixing up python install locations,
4d16f38f48e276497190c8bc03abc55c40e18eed.
Hi Sage,
I would like to take a look at the issues.
Danny
Am 09.05.2013 18:26, schrieb Sage Weil:
We were added to coverity's awesome scan program a while back, which gives
free access to their static analysis tool to open source projects.
Currently it identifies 421 issues. We've
Hi Sage,
cloud someone please update also the Mailing lists IRC webpage at
ceph.com (http://ceph.com/resources/mailing-list-irc/)?
The issues are:
- ceph-commit: points still to ceph-com...@lists.ceph.newdream.net
Note: you may need to add a link to the old archives or you need to
merge the
Am 10.02.2013 07:04, schrieb Sage Weil:
On Fri, 8 Feb 2013, Danny Al-Gaaf wrote:
[...]
//dout(5) SyntheticClient::write_fd: writing to fd fd dendl;
- if (fd 0) return fd;
+ if (fd 0) {
+return fd;
+delete[] buf;
oops, wrong order...
I know, that's why I've send another
Am 10.02.2013 07:02, schrieb Sage Weil:
Hey Danny-
These look good, modulo those 2 comments. Do you have a public git tree
with these patches I can cherry-pick or pull from? It's a bit faster than
yanking them off the list for merge (although posting to the list for
review is still
Fix some memory leaks in packet-ceph.c. Error from cppcheck was:
[wireshark/ceph/packet-ceph.c:215]: (error) Memory leak: plop
[wireshark/ceph/packet-ceph.c:237]: (error) Memory leak: plop
[wireshark/ceph/packet-ceph.c:543]: (error) Memory leak: fsid_dec
Signed-off-by: Danny Al-Gaaf danny.al-g
Fix 4K memory leak in case RGWClientIO::read() fails in
read_all_chunked_input().
Error from cppcheck was:
Checking src/rgw/rgw_rest.cc...
[src/rgw/rgw_rest.cc:688]: (error) Memory leak: data
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/rgw/rgw_rest.cc | 4 +++-
1 file changed
Here some patches to fix memory leaks in Ceph found by cppcheck.
Danny Al-Gaaf (6):
common/fiemap.cc: fix realloc memory leak
os/FileStore.cc: fix realloc memory leak in error case
rgw/rgw_xml.cc: fix realloc memory leak in error case
wireshark: fix some memory leaks
SyntheticClient.cc
Fix error from cppcheck:
[src/os/FileStore.cc:512]: (error) Common realloc mistake: 'fiemap'
nulled but not freed upon failure
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/os/FileStore.cc | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/os
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/client/SyntheticClient.cc | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/src/client/SyntheticClient.cc b/src/client/SyntheticClient.cc
index b2a936f..0da8bed 100644
--- a/src/client
Fix error from cppcheck:
[src/rgw/rgw_xml.cc:212]: (error) Common realloc mistake: 'buf'
nulled but not freed upon failure
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/rgw/rgw_xml.cc | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/rgw
Fix error from cppcheck:
[src/common/fiemap.cc:73]: (error) Common realloc mistake: 'fiemap'
nulled but not freed upon failure
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/common/fiemap.cc | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/common
Am 08.02.2013 17:25, schrieb Danny Al-Gaaf:
Fix some memory leaks in case of error handling due to failed
client-open() calls.
Error from cppcheck was:
[src/client/SyntheticClient.cc:1980]: (error) Memory leak: buf
[src/client/SyntheticClient.cc:2040]: (error) Memory leak: buf
[src/client
---
v2: - fix order in two cases
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/client/SyntheticClient.cc | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/src/client/SyntheticClient.cc b/src/client/SyntheticClient.cc
index b2a936f..0da8bed 100644
Here another set of patches to fix issues found by clang/clang++
and cppchecker.
Danny Al-Gaaf (15):
kv_flat_btree_async.cc: use vector instead of VLA's
common/config.h: declaration of config_option as struct
src/msg/msg_types.h: pass function parameter by reference
fuse_ll.cc: fix -Wgnu
Fix 'const static struct fuse_lowlevel_ops fuse_ll_oper' related
-Wgnu-designator warning from clang(++):
client/fuse_ll.cc:537:2: warning: use of GNU old-style field
designator extension [-Wgnu-designator]
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/client/fuse_ll.cc | 68
]: (performance) Possible inefficient
checking for 'queue' emptiness.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/common/AsyncReserver.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/common/AsyncReserver.h b/src/common/AsyncReserver.h
index 8cc2258..638bfb3 100644
]: (performance) Possible inefficient
checking for 'queue' emptiness.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/common/WorkQueue.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/common/WorkQueue.h b/src/common/WorkQueue.h
index b19a6a2..ced952c 100644
--- a/src
Fix Function parameter 'm' should be passed by reference. from cppchecker.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/msg/msg_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/msg/msg_types.h b/src/msg/msg_types.h
index 8f3d74b..e80639e 100644
Fix warning from clang(++):
test/mon/test_mon_workloadgen.cc:311:23: warning: in-class
initializer for static data member of type 'const double' is
a GNU extension [-Wgnu]
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/test/mon/test_mon_workloadgen.cc | 3 ++-
1 file changed, 2
Fix (performance) Function parameter 'm' should be passed by reference.
from cppchecker.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/msg/Messenger.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/msg/Messenger.h b/src/msg/Messenger.h
index b75e442
checking for
'objects' emptiness.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/osd/PG.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/osd/PG.h b/src/osd/PG.h
index ba80f81..3c95058 100644
--- a/src/osd/PG.h
+++ b/src/osd/PG.h
@@ -596,7 +596,7
Fix (performance) Function parameter 'e' should be passed by reference.
from cppchecker.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/osd/osd_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/osd/osd_types.h b/src/osd/osd_types.h
index e068057
Hi,
any comments on these patches?
Danny
Am 04.02.2013 18:22, schrieb Danny Al-Gaaf:
The ceph-test package contains files which are installed to /usr/bin,
but these files have names which don't give any hint that they are
part of ceph.
Rename the files of the ceph-test package to indicate
Fix variable length array of non-POD element type error. (-Wvla)
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/common/obj_bencher.cc | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/common/obj_bencher.cc b/src/common/obj_bencher.cc
index
Replace C-style pointer casting with correct static_cast().
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/common/WorkQueue.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/common/WorkQueue.h b/src/common/WorkQueue.h
index 9fb215b..b19a6a2 100644
Fix Function parameter 'v' should be passed by reference. from cppchecker.
Use 'const pairA,B v' similar to the other operator in this file.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/include/types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src
These patches fix some issues found by using cppchecker/clang++.
---
v2: - [4/8]: don't copy append_buffer and last_p
- [7/8]: use C++ initalize syntax for constructor
Danny Al-Gaaf (8):
WorkQueue.h: fix cast
ceph_crypto.cc: remove unused shutdown() outside crypto ifdef's
Fix out-of-line declaration of a member must be a definition
[-Wout-of-line-declaration]. Remove ceph::crypto::shutdown() outside
the crypto related ifdef's. Without nss or cryptopp configure will
fail anyways.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/common/ceph_crypto.cc
Replace C-style pointer casting with correct static_cast().
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/include/xlist.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/include/xlist.h b/src/include/xlist.h
index 5c2bf03..5384561 100644
--- a/src
Replace C-style pointer casting with correct static_cast().
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/msg/Message.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/msg/Message.h b/src/msg/Message.h
index 5bdd4d4..5e2b4f5 100644
--- a/src/msg
Fix operator=: return iterator instead of 'iterator'. Check if 'this'
equals 'other' before set anything.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/include/buffer.h | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/include/buffer.h b/src/include
= rbd_images; im != NULL; i++, im = im-next) {
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/rbd_fuse/rbd-fuse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/rbd_fuse/rbd-fuse.c b/src/rbd_fuse/rbd-fuse.c
index 0b28f63..5bdaba3 100644
--- a/src/rbd_fuse/rbd
/, otherwise they match files with the same name in
subdirectories as well.
For example, putting Makefile in .gitignore will also ignore static
makefiles in the qa subdirectories. Some of the existing entries are
already missing this leading /.
On 02/04/2013 09:22 AM, Danny Al-Gaaf wrote:
Cleanup
Fix out-of-line declaration of a member must be a definition
[-Wout-of-line-declaration]. Remove ceph::crypto::shutdown() outside
the crypto related ifdef's. Without nss or cryptopp configure will
fail anyways.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/common/ceph_crypto.cc
Fix variable length array of non-POD element type error. (-Wvla)
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/common/obj_bencher.cc | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/common/obj_bencher.cc b/src/common/obj_bencher.cc
index
Fix Function parameter 'v' should be passed by reference. from cppchecker.
Use 'const pairA,B v' similar to the other operator in this file.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/include/types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src
Replace C-style pointer casting with correct static_cast().
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/common/WorkQueue.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/common/WorkQueue.h b/src/common/WorkQueue.h
index 9fb215b..b19a6a2 100644
Initialize chunky and deep bool member variables in the constructor
with false.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/messages/MOSDRepScrub.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/messages/MOSDRepScrub.h b/src/messages/MOSDRepScrub.h
index
Fix operator=: return iterator instead of 'iterator'. Also set last_p and
other.append_buffer and check if 'this' equals 'other' before set anything.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/include/buffer.h | 10 +++---
1 file changed, 7 insertions(+), 3 deletions
Replace C-style pointer casting with correct static_cast().
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/msg/Message.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/msg/Message.h b/src/msg/Message.h
index 5bdd4d4..5e2b4f5 100644
--- a/src/msg
These patches fix some issues found by using cppchecker/clang++.
Danny Al-Gaaf (8):
WorkQueue.h: fix cast
ceph_crypto.cc: remove unused shutdown() outside crypto ifdef's
obj_bencher.cc: use vector instead of VLA's
include/buffer.h: fix operator=
include/types.h: change operator function
Cleanup includes, remove twice included common/errno.h.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/mds/MDS.cc | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/mds/MDS.cc b/src/mds/MDS.cc
index 4153417..0dd3f1b 100644
--- a/src/mds/MDS.cc
+++ b/src/mds/MDS.cc
@@ -73,7
Cleanup includes, remove twice included common/debug.h
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/test/filestore/workload_generator.cc | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/test/filestore/workload_generator.cc
b/src/test/filestore/workload_generator.cc
index
Cleanup includes, remove twice included iostream.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/test/old/testxattr.cc | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/test/old/testxattr.cc b/src/test/old/testxattr.cc
index 65bb4b1..b1ef126 100644
--- a/src/test/old
Cleanup includes, remove twice included sys/stat.h.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/testmsgr.cc | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/testmsgr.cc b/src/testmsgr.cc
index eb716b9..4de779b 100644
--- a/src/testmsgr.cc
+++ b/src/testmsgr.cc
@@ -33,7
This patch series cleanup twice included header files.
Danny Al-Gaaf (10):
MDS.cc: remove twice included common/errno.h
small_io_bench*.cc: remove twice included iostream
tp_bench.cc: remove twice included iostream
test_idempotent.cc: remove twice included os/FileStore.h
Cleanup includes, remove twice included iostream.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/test/bench/tp_bench.cc | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/test/bench/tp_bench.cc b/src/test/bench/tp_bench.cc
index daee790..31a4db3 100644
--- a/src/test/bench
Cleanup includes, remove twice included os/FileStore.h.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/test/filestore/test_idempotent.cc | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/test/filestore/test_idempotent.cc
b/src/test/filestore/test_idempotent.cc
index f49aded
Cleanup includes, remove twice included iostream.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/tools/ceph-filestore-dump.cc | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/tools/ceph-filestore-dump.cc b/src/tools/ceph-filestore-dump.cc
index 224ef32..2dfa1e5 100644
Cleanup includes, remove twice included iostream.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/test/bench/small_io_bench.cc | 1 -
src/test/bench/small_io_bench_dumb.cc | 1 -
src/test/bench/small_io_bench_fs.cc | 1 -
src/test/bench/small_io_bench_rbd.cc | 1 -
4 files
Cleanup includes, remove twice included time.h.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
src/test/xattr_bench.cc | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/test/xattr_bench.cc b/src/test/xattr_bench.cc
index 3a4b423..d212f55 100644
--- a/src/test/xattr_bench.cc
+++ b
The files from the ceph-test subpackage are installed to /usr/bin,
give them more useful names to make sure that the user know they
belong to ceph. add a 'ceph_' prefix and change some test* binaries
to ceph_test_*.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
.gitignore
Don't install rest-bench twice, it's already part of the rest-bench package.
Add some files which are part of the ceph-test package on RPM based
distributions already: ceph_test_mon_workloadgen, ceph_rgw_jsonparser,
ceph_test_objectcacher_stress.
Signed-off-by: Danny Al-Gaaf danny.al-g
to update.
Update and cleanup .gitignore files.
Danny Al-Gaaf (3):
ceph-test: give binaries from ceph-test package useful names
.gitignore: cleanup and sort entries
ceph-test.install: updated filelist
.gitignore | 77 ++--
ceph.spec.in
Cleanup old entries and sort the existing entries. Remove no longer
existing entries/files. Move src/* entries from top level .gitignore
to the correct subdir .gitignore file.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
.gitignore | 78 ++-
doc
Hi Gary,
seems to work fine. Feel free to check [1] for build results
(i586/x86_64) on openSUSE 11.4-Factory, SLE11-SP2, Fedora 16-18, RHEL6,
CentOS6, Ubuntu 12.10 (the source of the package is currently a merge of
master and wip-rpm-update3).
Danny
[1]
Am 31.01.2013 08:43, schrieb Stefan Priebe - Profihost AG:
Hello,
while compiling the bobtail branch i've seen this warning:
mon/PGMap.cc: In member function ‘void
PGMap::apply_incremental(CephContext*, const PGMap::Incremental)’:
mon/PGMap.cc:247: warning: comparison between signed and
Don't use po::valuestring()-required() since this breaks build on
RHEL/CentOs6. Check if the options are set as in the code of other
ceph parts.
Move some checks up in the code to validate options as soon
as possible. Remove printing 'help' twice.
Signed-off-by: Danny Al-Gaaf danny.al-g
Fix -Wsign-compare compiler warning:
mon/PGMap.cc: In member function 'void PGMap::apply_incremental
(CephContext*, const PGMap::Incremental)':
mon/PGMap.cc:247:30: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare]
Signed-off-by: Danny Al-Gaaf danny.al-g
/CentOS in the openSUSE build service.
Danny Al-Gaaf (6):
Revert Don't install rbd-fuse binary
ceph.spec.in: add rbd-fuse
ceph.spec.in: move libcephfs_jni.so to ceph-devel
ceph.spec.in: don't move libcephfs_jni files around
ceph.spec.in: extend fix for libedit-devel on special SUSE versions
Add %{_bindir}/rbd-fuse to the ceph-fuse subpackage.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
ceph.spec.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/ceph.spec.in b/ceph.spec.in
index b98ae06..38aef98 100644
--- a/ceph.spec.in
+++ b/ceph.spec.in
@@ -392,6 +392,7 @@ fi
Don't move libcephfs_jni files around from %{_libdir} to /usr/lib/jni/
in the buildroot. They should be placed in %{_libdir} as all libs.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
ceph.spec.in | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/ceph.spec.in
Move libcephfs_jni.so to the ceph-devel package since so-files they
shouldn't be part of the library package.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
ceph.spec.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ceph.spec.in b/ceph.spec.in
index 38aef98
This reverts commit 35e5d74e5c5786bc91df5dc10b5c08c77305df4e.
- fix build instead
---
src/Makefile.am | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/Makefile.am b/src/Makefile.am
index 996fd4e..c30c0c1 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -26,8 +26,6
Extend fix for libedit-devel on special SUSE versions, use ncurses
also on src/ocf/Makefile and src/java/Makefile
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
ceph.spec.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ceph.spec.in b/ceph.spec.in
index f6a9006..0db7792 100644
Create needed dirs (/usr/lib/ocf/resource.d/ceph) for the ceph-resource-agents
subpackage.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
ceph.spec.in | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ceph.spec.in b/ceph.spec.in
index 0db7792..668edca 100644
--- a/ceph.spec.in
Am 30.01.2013 19:07, schrieb Gregory Farnum:
On Wednesday, January 30, 2013 at 10:00 AM, Danny Al-Gaaf wrote:
This set fixes some issues in the spec file.
I'm not sure what the reason for
#35e5d74e5c5786bc91df5dc10b5c08c77305df4e was. But I would revert
it and fix the underlaying issues
Hi,
could someone cherry-pick this patch to the bobtail branch? I see the
same issue there.
Thanks!
Danny
Am 27.01.2013 21:57, schrieb Danny Al-Gaaf:
Fix compiler warning:
./include/utime.h: In member function 'void utime_t::sleep()':
./include/utime.h:139:50: warning: narrowing conversion
Check for fuse_getgroups() only in case we have found libfuse already.
Moved the check to the check for --with-fuse.
Small fix: fix string for NO_ATOMIC_OPS, don't use '.
Signed-off-by: Danny Al-Gaaf danny.al-g...@bisect.de
---
configure.ac | 8
1 file changed, 4 insertions(+), 4
Here three patches to fix some issues with the new rbd-fuse
code and an issues with the fuse handling in configure.
Danny Al-Gaaf (3):
configure: fix check for fuse_getgroups()
rbd-fuse: fix usage of conn-want
rbd-fuse: fix printf format for off_t and size_t
configure.ac| 8
1 - 100 of 161 matches
Mail list logo
