r231931 - Add builtins for the 64-bit vector integer arithmetic instructions added in POWER8.

2015-03-11 Thread Kit Barton
Author: kbarton Date: Wed Mar 11 10:57:19 2015 New Revision: 231931 URL: http://llvm.org/viewvc/llvm-project?rev=231931view=rev Log: Add builtins for the 64-bit vector integer arithmetic instructions added in POWER8. These are the Clang-related changes for the instructions added to LLVM in

r231932 - OpenCL: CL2.0 atomic types

2015-03-11 Thread Anastasia Stulova
Author: stulova Date: Wed Mar 11 10:57:53 2015 New Revision: 231932 URL: http://llvm.org/viewvc/llvm-project?rev=231932view=rev Log: OpenCL: CL2.0 atomic types OpenCL C Spec v2.0 Section 6.13.11 - Made c11 _Atomic being accepted only for c11 compilations - Implemented CL2.0 atomics by aliasing

Re: [PATCH] Use clock_gettime()'s CLOCK_REALTIME instead of gettimeofday() where possible

2015-03-11 Thread Ed Schouten
Comment at: src/chrono.cpp:42 @@ -35,2 +41,3 @@ +#endif // __APPLE__ } mclow.lists wrote: Apple does not provide `clock_gettime`, but It's not clear to me that this should be an Apple vs. everyone else test. Are there other systems that do not provide

Re: [PATCH] libc++ locale: Disable cat*() on CloudABI. Also make tiny cleanups.

2015-03-11 Thread Marshall Clow
This looks OK to me. http://reviews.llvm.org/D8163 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [PATCH] Use clock_gettime()'s CLOCK_REALTIME instead of gettimeofday() where possible

2015-03-11 Thread Jonathan Roelofs
Please upload your diffs with more context (i.e. `git diff -U999`)... it'll make the reviews a bit easier. How about defining `_LIBCPP_HAS_NO_REALTIME_CLOCK`, similarly to the existing one for monotonic clocks in `include/__config` under the appropriate guards? (i.e. it would be defined on

RE: FW: [Patch] Bugfix for pointer address space in atomic builtins

2015-03-11 Thread Anastasia Stulova
Hi Matt, Any more comments here? Thanks, Anastasia From: Anastasia Stulova [mailto:anastasia.stul...@arm.com] Sent: 05 March 2015 18:15 To: 'Matt Arsenault'; cfe-commits@cs.uiuc.edu Cc: Stellard, Thomas Subject: RE: FW: [Patch] Bugfix for pointer address space in atomic builtins

[libcxx] r231937 - Disable cat*() on CloudABI. Also make tiny cleanups.

2015-03-11 Thread Ed Schouten
Author: ed Date: Wed Mar 11 11:39:36 2015 New Revision: 231937 URL: http://llvm.org/viewvc/llvm-project?rev=231937view=rev Log: Disable cat*() on CloudABI. Also make tiny cleanups. On a new platform that I am working on (https://github.com/NuxiNL/cloudlibc) I am not implementing the

Re: [clang-tools-extra] r231938 - [clang-tidy] Clean up misc-use-override warning. NFC

2015-03-11 Thread David Blaikie
On Wed, Mar 11, 2015 at 9:47 AM, Alexander Kornienko ale...@google.com wrote: Author: alexfh Date: Wed Mar 11 11:47:27 2015 New Revision: 231938 URL: http://llvm.org/viewvc/llvm-project?rev=231938view=rev Log: [clang-tidy] Clean up misc-use-override warning. NFC Modified:

[clang-tools-extra] r231938 - [clang-tidy] Clean up misc-use-override warning. NFC

2015-03-11 Thread Alexander Kornienko
Author: alexfh Date: Wed Mar 11 11:47:27 2015 New Revision: 231938 URL: http://llvm.org/viewvc/llvm-project?rev=231938view=rev Log: [clang-tidy] Clean up misc-use-override warning. NFC Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.h Modified:

Re: [PATCH] Use clock_gettime()'s CLOCK_REALTIME instead of gettimeofday() where possible

2015-03-11 Thread Ed Schouten
Comment at: src/chrono.cpp:42 @@ -35,2 +41,3 @@ +#endif // __APPLE__ } hfinkel wrote: ed wrote: mclow.lists wrote: Apple does not provide `clock_gettime`, but It's not clear to me that this should be an Apple vs. everyone else test. Are there

Re: [PATCH] Use clock_gettime()'s CLOCK_REALTIME instead of gettimeofday() where possible

2015-03-11 Thread Ed Schouten
In http://reviews.llvm.org/D8253#138862, @jroelofs wrote: I think the new bits here need to be guarded on a check for `#if (defined(_POSIX_TIMERS) _POSIX_TIMERS 0)`, and otherwise fall back on the original implementation. Checking against _POSIX_TIMERS would be a bit problematic in my

Re: [PATCH] libc++ locale: Disable cat*() on CloudABI. Also make tiny cleanups.

2015-03-11 Thread Ed Schouten
REPOSITORY rL LLVM http://reviews.llvm.org/D8163 Files: libcxx/trunk/include/__config libcxx/trunk/include/locale Index: libcxx/trunk/include/locale === --- libcxx/trunk/include/locale +++ libcxx/trunk/include/locale @@

r231939 - revert r231700 (designated initializer patch) which broke

2015-03-11 Thread Fariborz Jahanian
Author: fjahanian Date: Wed Mar 11 11:59:48 2015 New Revision: 231939 URL: http://llvm.org/viewvc/llvm-project?rev=231939view=rev Log: revert r231700 (designated initializer patch) which broke several projects. rdar://20120666. Modified: cfe/trunk/include/clang/AST/DeclObjC.h

Re: [PATCH] Use clock_gettime()'s CLOCK_REALTIME instead of gettimeofday() where possible

2015-03-11 Thread Ed Schouten
http://reviews.llvm.org/D8253 Files: src/chrono.cpp EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ Index: src/chrono.cpp === --- src/chrono.cpp +++ src/chrono.cpp @@ -8,15 +8,22 @@

Re: [PATCH] Use clock_gettime()'s CLOCK_REALTIME instead of gettimeofday() where possible

2015-03-11 Thread Ed Schouten
In http://reviews.llvm.org/D8253#138984, @jroelofs wrote: Please upload your diffs with more context (i.e. `git diff -U999`)... it'll make the reviews a bit easier. Sure! Will do that as of now. Still trying to get used to Phabricator. How about defining `_LIBCPP_HAS_NO_REALTIME_CLOCK`,

Re: bug 22836 : atomics in shared_ptr (ThreadSanitizer)

2015-03-11 Thread Howard Hinnant
On Mar 11, 2015, at 11:38 AM, Oleg Smolsky o...@smolsky.net wrote: On 2015-03-10 15:31, Howard Hinnant wrote: On Mar 7, 2015, at 11:06 PM, Oleg Smolsky o...@smolsky.net wrote: Hi there, I reported a TSan issue that resulted in the following bug report against libc++:

Re: [PATCH] Use clock_gettime()'s CLOCK_REALTIME instead of gettimeofday() where possible

2015-03-11 Thread Marshall Clow
Please include me on all libc++ code reviews. Comment at: src/chrono.cpp:42 @@ -35,2 +41,3 @@ +#endif // __APPLE__ } Apple does not provide `clock_gettime`, but It's not clear to me that this should be an Apple vs. everyone else test. Are there other

RE: [OpenCL][Patch] This patch adds OpenCL checks in OpenCL address space conversion rules

2015-03-11 Thread Anastasia Stulova
Ping2 From: cfe-commits-boun...@cs.uiuc.edu [mailto:cfe-commits-boun...@cs.uiuc.edu] On Behalf Of Anastasia Stulova Sent: 17 February 2015 10:41 To: cfe-commits@cs.uiuc.edu Subject: FW: [OpenCL][Patch] This patch adds OpenCL checks in OpenCL address space conversion rules Ping! From:

Re: [PATCH] Use clock_gettime()'s CLOCK_REALTIME instead of gettimeofday() where possible

2015-03-11 Thread Jonathan Roelofs
Indeed, I added `_LIBCPP_HAS_NO_MONOTONIC_CLOCK` for exactly the situation @hfinkel describes: my platform doesn't have access to a monotonic clock. Originally (and in my local fork) it had checks for `_POSIX_TIMERS` and `_POSIX_MONOTONIC_CLOCK` but those seem to have gone away upstream. Sorry

Re: [PATCH] [clang-tidy] Static Analyzer checker configuration options passthrough

2015-03-11 Thread Gábor Horváth
http://reviews.llvm.org/D8164 Files: clang-tidy/ClangTidy.cpp test/clang-tidy/static-analyzer-config.cpp Index: clang-tidy/ClangTidy.cpp === --- clang-tidy/ClangTidy.cpp +++ clang-tidy/ClangTidy.cpp @@ -204,6 +204,17 @@ } }

Re: [PATCH] Use clock_gettime()'s CLOCK_REALTIME instead of gettimeofday() where possible

2015-03-11 Thread Ed Schouten
http://reviews.llvm.org/D8253 Files: src/chrono.cpp EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ Index: src/chrono.cpp === --- src/chrono.cpp +++ src/chrono.cpp @@ -8,15 +8,22 @@

Re: [PATCH] [PPC64] Add 64-bit Vector Integer Arithmetic Instructions

2015-03-11 Thread Kit Barton
Committed revision 231931. http://reviews.llvm.org/D8041 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

[libcxx] r231940 - Fix ctype_bynamewchar_t::do_is() mask checking.... again

2015-03-11 Thread Jonathan Roelofs
Author: jroelofs Date: Wed Mar 11 12:00:28 2015 New Revision: 231940 URL: http://llvm.org/viewvc/llvm-project?rev=231940view=rev Log: Fix ctype_bynamewchar_t::do_is() mask checking again This basically reverts the revert in r216508, and fixes a few more cases while I'm at it. Reading my

Re: [PATCH] clang-format: Recognize .ts files as JavaScript (TypeScript is a dialect of JavaScript).

2015-03-11 Thread Daniel Jasper
Submitted as r231926. http://reviews.llvm.org/D8190 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: bug 22836 : atomics in shared_ptr (ThreadSanitizer)

2015-03-11 Thread Oleg Smolsky
On 2015-03-10 15:31, Howard Hinnant wrote: On Mar 7, 2015, at 11:06 PM, Oleg Smolsky o...@smolsky.net wrote: Hi there, I reported a TSan issue that resulted in the following bug report against libc++: http://llvm.org/bugs/show_bug.cgi?id=22836 Could you folks take a look at the

Re: [PATCH] [OPENMP] CodeGen - 'omp for' with dynamic schedule kinds

2015-03-11 Thread Alexander Musman
Hi John, Thank you for review! I've fixed all the issues. I think a similar refactoring can be done for OMPRTL__kmpc_for_static_init_*, I can do it in follow-up commit. Best regards, Alexander http://reviews.llvm.org/D7138 Files: lib/CodeGen/CGOpenMPRuntime.cpp

Re: [PATCH] Fix ctype_bynamewchar_t::do_is() mask checking.... again

2015-03-11 Thread Marshall Clow
LGTM. http://reviews.llvm.org/D8237 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: r231787 - Allow -target= and --target options

2015-03-11 Thread Chandler Carruth
On Wed, Mar 11, 2015 at 2:10 PM, Richard Barton richard.bar...@arm.com wrote: Hi Chandler Gabor’s patch seems uncontroversial to me and the new behaviour matches many other applications using unix getopt. Could you say why you think it is a mistake? Because I think it is better to

r231950 - [modules] When merging the pattern of a class template definition into a prior

2015-03-11 Thread Richard Smith
Author: rsmith Date: Wed Mar 11 13:21:02 2015 New Revision: 231950 URL: http://llvm.org/viewvc/llvm-project?rev=231950view=rev Log: [modules] When merging the pattern of a class template definition into a prior definition, be sure to update the definition data on all declarations, not just the

Re: r231787 - Allow -target= and --target options

2015-03-11 Thread Renato Golin
I originally disliked the change but failed to come up with a strong technical argument and other folks seemed all happy. Maybe we should come up with a draft on what we want for options? I don't have a strong opinion and am fine either way. Cheers, Renato On 11 Mar 2015 21:16, Chandler Carruth

Re: r231787 - Allow -target= and --target options

2015-03-11 Thread Richard Smith
On Wed, Mar 11, 2015 at 2:16 PM, Chandler Carruth chandl...@google.com wrote: On Wed, Mar 11, 2015 at 2:10 PM, Richard Barton richard.bar...@arm.com wrote: Hi Chandler Gabor’s patch seems uncontroversial to me and the new behaviour matches many other applications using unix getopt.

Re: r231787 - Allow -target= and --target options

2015-03-11 Thread Chandler Carruth
On Wed, Mar 11, 2015 at 2:20 PM, Renato Golin renato.go...@linaro.org wrote: I originally disliked the change but failed to come up with a strong technical argument and other folks seemed all happy. We should have a single unambiguous spelling for long options in the absence of compatibility

Re: r231787 - Allow -target= and --target options

2015-03-11 Thread Chandler Carruth
On Tue, Mar 10, 2015 at 6:58 AM, Renato Golin renato.go...@linaro.org wrote: Allow -target= and --target options Using clang as a cross-compiler with the 'target' option could be confusing for those inexperienced in the realm of cross compiling. This patch would allow the use of all these

r231935 - OpenCL: CL2.0 atomic type diagnostics

2015-03-11 Thread Anastasia Stulova
Author: stulova Date: Wed Mar 11 11:23:10 2015 New Revision: 231935 URL: http://llvm.org/viewvc/llvm-project?rev=231935view=rev Log: OpenCL: CL2.0 atomic type diagnostics Added restictions for atomic type usage from OpenCL C Spec Section 6.13.11.8 Modified:

Re: [PATCH] Use clock_gettime()'s CLOCK_REALTIME instead of gettimeofday() where possible

2015-03-11 Thread hfin...@anl.gov
Comment at: src/chrono.cpp:42 @@ -35,2 +41,3 @@ +#endif // __APPLE__ } ed wrote: mclow.lists wrote: Apple does not provide `clock_gettime`, but It's not clear to me that this should be an Apple vs. everyone else test. Are there other systems that do

RE: r231787 - Allow -target= and --target options

2015-03-11 Thread Richard Barton
Hi Chandler Gabor’s patch seems uncontroversial to me and the new behaviour matches many other applications using unix getopt. Could you say why you think it is a mistake? Do you object to relaxing the mandatory ‘=’ or allowing both single and double – versions or both? Rich

Re: [PATCH] [clang-tidy] Static Analyzer checker configuration options passthrough

2015-03-11 Thread Alexander Kornienko
Looks good! http://reviews.llvm.org/D8164 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

r231926 - clang-format: Recognize the .ts (TypeScript) extension as JavaScript.

2015-03-11 Thread Daniel Jasper
Author: djasper Date: Wed Mar 11 09:58:38 2015 New Revision: 231926 URL: http://llvm.org/viewvc/llvm-project?rev=231926view=rev Log: clang-format: Recognize the .ts (TypeScript) extension as JavaScript. Patch by Martin Probst. Thank you. Modified: cfe/trunk/lib/Format/Format.cpp

r231960 - [PowerPC] ABI support for the QPX vector instruction set

2015-03-11 Thread Hal Finkel
Author: hfinkel Date: Wed Mar 11 14:14:15 2015 New Revision: 231960 URL: http://llvm.org/viewvc/llvm-project?rev=231960view=rev Log: [PowerPC] ABI support for the QPX vector instruction set Support for the QPX vector instruction set, used on the IBM BG/Q supercomputer, has recently been added to

Re: r230255 - Only lower __builtin_setjmp / __builtin_longjmp to

2015-03-11 Thread John McCall
On Tue, Mar 10, 2015 at 7:16 PM, Joerg Sonnenberger jo...@britannica.bec.de wrote: On Tue, Mar 10, 2015 at 07:03:16PM -0700, John McCall wrote: On Tue, Mar 10, 2015 at 6:37 PM, Joerg Sonnenberger jo...@britannica.bec.de wrote: On Tue, Mar 10, 2015 at 05:44:00PM -0700, John McCall

Re: FW: [Patch] Bugfix for pointer address space in atomic builtins

2015-03-11 Thread Matt Arsenault
On 03/11/2015 09:24 AM, Anastasia Stulova wrote: Hi Matt, Any more comments here? Thanks, Anastasia Not really. Tom is still working on a solution for __builtin_nan ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

Re: [clang-tools-extra] r231938 - [clang-tidy] Clean up misc-use-override warning. NFC

2015-03-11 Thread David Blaikie
On Wed, Mar 11, 2015 at 12:25 PM, Alexander Kornienko ale...@google.com wrote: On Wed, Mar 11, 2015 at 8:23 PM, David Blaikie dblai...@gmail.com wrote: On Wed, Mar 11, 2015 at 11:22 AM, Alexander Kornienko ale...@google.com wrote: On Wed, Mar 11, 2015 at 6:29 PM, David Blaikie

Re: [PATCH] libc++: Add option to disable access to the global filesystem namespace

2015-03-11 Thread Ed Schouten
Hi Jonathan, As you proposed, I have inverted the logic. We now have a flag _LIBCPP_HAS_GLOBAL_FILESYSTEM_NAMESPACE. I temporarily added -D_LIBCPP_HAS_GLOBAL_FILESYSTEM_NAMESPACE to test/libcxx/test/config.py, so I've been able to mark all the tests that require the global filesystem

r231971 - Don't overconstrain a FileCheck pattern

2015-03-11 Thread David Majnemer
Author: majnemer Date: Wed Mar 11 16:50:09 2015 New Revision: 231971 URL: http://llvm.org/viewvc/llvm-project?rev=231971view=rev Log: Don't overconstrain a FileCheck pattern Modified: cfe/trunk/test/CodeGenCXX/microsoft-abi-throw.cpp Modified:

RE: FW: [OpenCL][Patch] This patch adds OpenCL checks in OpenCL address space conversion rules

2015-03-11 Thread Anastasia Stulova
Yes. I will change that to be consistent with the rest! Thanks, Anastasia -Original Message- From: Pekka Jääskeläinen [mailto:pekka.jaaskelai...@tut.fi] Sent: 11 March 2015 18:30 To: cfe-commits@cs.uiuc.edu; Anastasia Stulova Subject: Re: FW: [OpenCL][Patch] This patch adds OpenCL

Re: [PATCH] Use clock_gettime()'s CLOCK_REALTIME instead of gettimeofday() where possible

2015-03-11 Thread Jonathan Roelofs
I think the new bits here need to be guarded on a check for `#if (defined(_POSIX_TIMERS) _POSIX_TIMERS 0)`, and otherwise fall back on the original implementation. REPOSITORY rL LLVM http://reviews.llvm.org/D8253 EMAIL PREFERENCES

Re: [PATCH] Fix ctype_bynamewchar_t::do_is() mask checking.... again

2015-03-11 Thread Jonathan Roelofs
r231940 http://reviews.llvm.org/D8237 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r231938 - [clang-tidy] Clean up misc-use-override warning. NFC

2015-03-11 Thread David Blaikie
On Wed, Mar 11, 2015 at 10:21 AM, Alexander Kornienko ale...@google.com wrote: On Wed, Mar 11, 2015 at 5:57 PM, David Blaikie dblai...@gmail.com wrote: On Wed, Mar 11, 2015 at 9:47 AM, Alexander Kornienko ale...@google.com wrote: Author: alexfh Date: Wed Mar 11 11:47:27 2015 New

Re: [clang-tools-extra] r231938 - [clang-tidy] Clean up misc-use-override warning. NFC

2015-03-11 Thread Alexander Kornienko
On Wed, Mar 11, 2015 at 6:29 PM, David Blaikie dblai...@gmail.com wrote: On Wed, Mar 11, 2015 at 10:21 AM, Alexander Kornienko ale...@google.com wrote: On Wed, Mar 11, 2015 at 5:57 PM, David Blaikie dblai...@gmail.com wrote: On Wed, Mar 11, 2015 at 9:47 AM, Alexander Kornienko

Re: [clang-tools-extra] r231938 - [clang-tidy] Clean up misc-use-override warning. NFC

2015-03-11 Thread Alexander Kornienko
On Wed, Mar 11, 2015 at 5:57 PM, David Blaikie dblai...@gmail.com wrote: On Wed, Mar 11, 2015 at 9:47 AM, Alexander Kornienko ale...@google.com wrote: Author: alexfh Date: Wed Mar 11 11:47:27 2015 New Revision: 231938 URL: http://llvm.org/viewvc/llvm-project?rev=231938view=rev Log:

Re: [PATCH] Use clock_gettime()'s CLOCK_REALTIME instead of gettimeofday() where possible

2015-03-11 Thread Marshall Clow
Indeed, I added _LIBCPP_HAS_NO_MONOTONIC_CLOCK for exactly the situation @hfinkel describes: my platform doesn't have access to a monotonic clock. Note that if you don't have a monotonic clock, none of the thread/mutex/etc stuff will compile. The only way that @jroelofs does this is to also

[PATCH] [clang-tidy] Remove google-readability-function check.

2015-03-11 Thread Alexander Kornienko
Hi djasper, The relevant style rule is going to be removed, thus the check is no longer needed. http://reviews.llvm.org/D8261 Files: clang-tidy/google/CMakeLists.txt clang-tidy/google/GoogleTidyModule.cpp clang-tidy/google/NamedParameterCheck.cpp clang-tidy/google/NamedParameterCheck.h

[clang-tools-extra] r231941 - [clang-tidy] Static Analyzer checker configuration options pass-through.

2015-03-11 Thread Gabor Horvath
Author: xazax Date: Wed Mar 11 12:25:22 2015 New Revision: 231941 URL: http://llvm.org/viewvc/llvm-project?rev=231941view=rev Log: [clang-tidy] Static Analyzer checker configuration options pass-through. Reviewed by: Alexander Kornienko Differential Revision: http://reviews.llvm.org/D8164

Re: FW: [OpenCL][Patch] This patch adds OpenCL checks in OpenCL address space conversion rules

2015-03-11 Thread Pekka Jääskeläinen
LGTM except lhsPtr should start with a capital letter? ;] On 02/17/2015 12:40 PM, Anastasia Stulova wrote: Ping! *From:*cfe-commits-boun...@cs.uiuc.edu [mailto:cfe-commits-boun...@cs.uiuc.edu] *On Behalf Of *Anastasia Stulova *Sent:* 12 February 2015 17:27 *To:* cfe-commits@cs.uiuc.edu

Re: [clang-tools-extra] r231938 - [clang-tidy] Clean up misc-use-override warning. NFC

2015-03-11 Thread David Blaikie
On Wed, Mar 11, 2015 at 11:22 AM, Alexander Kornienko ale...@google.com wrote: On Wed, Mar 11, 2015 at 6:29 PM, David Blaikie dblai...@gmail.com wrote: On Wed, Mar 11, 2015 at 10:21 AM, Alexander Kornienko ale...@google.com wrote: On Wed, Mar 11, 2015 at 5:57 PM, David Blaikie

Re: [PATCH] [clang-tidy] Static Analyzer checker configuration options passthrough

2015-03-11 Thread Phabricator
REPOSITORY rL LLVM http://reviews.llvm.org/D8164 Files: clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp clang-tools-extra/trunk/test/clang-tidy/static-analyzer-config.cpp Index: clang-tools-extra/trunk/test/clang-tidy/static-analyzer-config.cpp

Re: [PATCH] MS ABI: Implement copy-ctor closures, finish implementing throw

2015-03-11 Thread Reid Kleckner
lgtm Comment at: include/clang/Basic/ABI.h:28-29 @@ -29,1 +27,4 @@ + Ctor_Comdat, /// The COMDAT used for ctors + Ctor_CopyingClosure, /// Copying closure variant of a ctor + Ctor_DefaultClosure, /// Default closure variant of a ctor }; rnk wrote:

r231952 - MS ABI: Implement copy-ctor closures, finish implementing throw

2015-03-11 Thread David Majnemer
Author: majnemer Date: Wed Mar 11 13:36:39 2015 New Revision: 231952 URL: http://llvm.org/viewvc/llvm-project?rev=231952view=rev Log: MS ABI: Implement copy-ctor closures, finish implementing throw This adds support for copy-constructor closures. These are generated when the C++ runtime has to

Re: [clang-tools-extra] r231938 - [clang-tidy] Clean up misc-use-override warning. NFC

2015-03-11 Thread Alexander Kornienko
On Wed, Mar 11, 2015 at 8:23 PM, David Blaikie dblai...@gmail.com wrote: On Wed, Mar 11, 2015 at 11:22 AM, Alexander Kornienko ale...@google.com wrote: On Wed, Mar 11, 2015 at 6:29 PM, David Blaikie dblai...@gmail.com wrote: On Wed, Mar 11, 2015 at 10:21 AM, Alexander Kornienko

r231942 - Reverted OpenCL2.0 atomic type commits r231932, r231935

2015-03-11 Thread Anastasia Stulova
Author: stulova Date: Wed Mar 11 12:26:37 2015 New Revision: 231942 URL: http://llvm.org/viewvc/llvm-project?rev=231942view=rev Log: Reverted OpenCL2.0 atomic type commits r231932, r231935 (caused undesirable update of -std flag to use _Atomic) Removed:

Re: [PATCH] MS ABI: Implement copy-ctor closures, finish implementing throw

2015-03-11 Thread David Majnemer
REPOSITORY rL LLVM http://reviews.llvm.org/D8225 Files: cfe/trunk/include/clang/AST/ASTContext.h cfe/trunk/include/clang/AST/Mangle.h cfe/trunk/include/clang/Basic/ABI.h cfe/trunk/lib/AST/ASTContext.cpp cfe/trunk/lib/AST/CXXABI.h cfe/trunk/lib/AST/ItaniumCXXABI.cpp

r231953 - MS ABI: Mark 'throw' as implemented in the compatibility doc

2015-03-11 Thread David Majnemer
Author: majnemer Date: Wed Mar 11 13:38:51 2015 New Revision: 231953 URL: http://llvm.org/viewvc/llvm-project?rev=231953view=rev Log: MS ABI: Mark 'throw' as implemented in the compatibility doc Modified: cfe/trunk/docs/MSVCCompatibility.rst Modified: cfe/trunk/docs/MSVCCompatibility.rst

Re: [PATCH] [clang-tidy] Static Analyzer checker configuration options passthrough

2015-03-11 Thread Alexander Kornienko
Comment at: clang-tidy/ClangTidy.cpp:214 @@ +213,3 @@ + continue; +StringRef AnalyzerCheckName = OptName.substr(AnalyzerPrefix.size()); +AnalyzerOptions-Config[AnalyzerCheckName] = Opt.second; It's not a check name now. And I think, you can just

[PATCH] [X86] replace vextractf128 intrinsics with generic shuffles

2015-03-11 Thread Sanjay Patel
Hi craig.topper, chandlerc, RKSimon, andreadb, This is very much like D8088 (checked in here: http://llvm.org/viewvc/llvm-project?rev=231794view=rev ). Now that we've replaced the vinsertf128 intrinsics, do the same for their extract twins. http://reviews.llvm.org/D8275 Files:

Re: [PATCH] Add support for a few Objective-C matchers.

2015-03-11 Thread Dean F. Sutherland
Ping! I'd really appreciate it if someone with commit privs could land these changes for me! Dean http://reviews.llvm.org/D7710 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list

Re: [PATCH] libc++: Add option to disable access to the global filesystem namespace

2015-03-11 Thread Jonathan Roelofs
I'd still like to see some test cases added (like the ones I mentioned before), as well as the changes needed to config.py, lit.site.in, CMakeLists.txt, etc. so that this can be tested on platforms that **do** have the global filesystem namespace. Then it should be simple to add another

r231986 - Under duress, move check for target support of __builtin_setjmp/

2015-03-11 Thread Joerg Sonnenberger
Author: joerg Date: Wed Mar 11 18:46:32 2015 New Revision: 231986 URL: http://llvm.org/viewvc/llvm-project?rev=231986view=rev Log: Under duress, move check for target support of __builtin_setjmp/ __builtin_longjmp to Sema as requested by John McCall. Added:

Re: [PATCH] Pass -mglobal-merge as a module flag metadata.

2015-03-11 Thread Ahmed Bougacha
Eric, thoughts? -Ahmed ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

r231989 - Driver: Print the clang version and original command in crash scripts

2015-03-11 Thread Justin Bogner
Author: bogner Date: Wed Mar 11 19:14:35 2015 New Revision: 231989 URL: http://llvm.org/viewvc/llvm-project?rev=231989view=rev Log: Driver: Print the clang version and original command in crash scripts When a crash report script doesn't work for a reproduction on your machine for one reason or

[PATCH] [analyzer] Implementation of potential undefbehavior.ZeroAllocDereference checker.

2015-03-11 Thread Антон Ярцев
Hi zaks.anna, Proposed patch implements undefbehavior.ZeroAllocDereference checker as part of unix.Malloc and cplusplus.NewDelete checkers. The patch doesn't handle zero-size realloc()s due to specifics of current handling of realloc() by unix.Malloc that need to be discussed. Please review!

r231978 - [analyzer] www: +progress for undefbehavior.ZeroAllocDereference

2015-03-11 Thread Anton Yartsev
Author: ayartsev Date: Wed Mar 11 17:29:32 2015 New Revision: 231978 URL: http://llvm.org/viewvc/llvm-project?rev=231978view=rev Log: [analyzer] www: +progress for undefbehavior.ZeroAllocDereference Modified: cfe/trunk/www/analyzer/potential_checkers.html Modified:

r231994 - docs: Document byte arrays.

2015-03-11 Thread Peter Collingbourne
Author: pcc Date: Wed Mar 11 19:30:41 2015 New Revision: 231994 URL: http://llvm.org/viewvc/llvm-project?rev=231994view=rev Log: docs: Document byte arrays. Modified: cfe/trunk/docs/ControlFlowIntegrityDesign.rst Modified: cfe/trunk/docs/ControlFlowIntegrityDesign.rst URL:

r231907 - Prevent test from accessing files.

2015-03-11 Thread Daniel Jasper
Author: djasper Date: Wed Mar 11 01:01:01 2015 New Revision: 231907 URL: http://llvm.org/viewvc/llvm-project?rev=231907view=rev Log: Prevent test from accessing files. Modified: cfe/trunk/test/CodeGenCXX/mangle-fail.cpp Modified: cfe/trunk/test/CodeGenCXX/mangle-fail.cpp URL:

Re: [PATCH] Add fveclib option and add several entries to table of vectorizable functions.

2015-03-11 Thread hfin...@anl.gov
As per our IRC discussion, setting the linking flags for the Accelerate library when provided -fveclib=Accelerate will be added in follow-up. This LGTM. http://reviews.llvm.org/D8097 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/

r231912 - Add target information for CloudABI on x86-64.

2015-03-11 Thread Ed Schouten
Author: ed Date: Wed Mar 11 03:42:46 2015 New Revision: 231912 URL: http://llvm.org/viewvc/llvm-project?rev=231912view=rev Log: Add target information for CloudABI on x86-64. CloudABI can be identified by the __CloudABI__ preprocessor definition. The system uses ELF executables. CloudABI uses

r231914 - Enable security checks for arc4random() on CloudABI as well.

2015-03-11 Thread Ed Schouten
Author: ed Date: Wed Mar 11 03:48:55 2015 New Revision: 231914 URL: http://llvm.org/viewvc/llvm-project?rev=231914view=rev Log: Enable security checks for arc4random() on CloudABI as well. CloudABI also supports the arc4random() function. We can enable compiler warnings for rand(), random() and

Re: r231901 - [modules] Avoid accidentally completing the redeclaration chain when updating

2015-03-11 Thread Vassil Vassilev
This made me think, is there a way to automatically find out redundant deserializations? Eg. switch to text mode, build dependency graph and compare against the dependency graph in -fmodules mode. Or even a more brute force: store the states of the key objects (AST, identifiers, lookups,

r231913 - Fix up default header paths for CloudABI.

2015-03-11 Thread Ed Schouten
Author: ed Date: Wed Mar 11 03:46:01 2015 New Revision: 231913 URL: http://llvm.org/viewvc/llvm-project?rev=231913view=rev Log: Fix up default header paths for CloudABI. CloudABI is a pure cross compilation target. This means that we should not add /usr/include and /usr/local/include. Instead,

[PATCH] [OPENMP] Initial codegen for 'omp sections' and 'omp section' directives.

2015-03-11 Thread Alexey Bataev
Hi rjmccall, hfinkel, fraggamuffin, ejstotzer, If only one section is found in the sections region, it is emitted just like single region. Otherwise it is emitted as a static non-chunked loop. ``` #pragma omp sections { #pragma omp section {1} ... #pragma omp section {n} } ``` is translated to

Re: [PATCH] [PATCH v3] [PowerPC] Add Hardware Transaction Memory builtins support

2015-03-11 Thread hfin...@anl.gov
Please upload this patch with full context, see: http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface for instructions. http://reviews.llvm.org/D8226 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/

r231920 - clang-format: Fix incorrect recognition.

2015-03-11 Thread Daniel Jasper
Author: djasper Date: Wed Mar 11 07:59:49 2015 New Revision: 231920 URL: http://llvm.org/viewvc/llvm-project?rev=231920view=rev Log: clang-format: Fix incorrect recognition. Before: if (a (b = c)) .. After: if (a (b = c)) .. Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp

Re: [PATCH] [clang-tidy] Static Analyzer checker configuration options passthrough

2015-03-11 Thread Alexander Kornienko
Comment at: clang-tidy/ClangTidy.cpp:218 @@ +217,3 @@ +OptName.substr(AnalyzerPrefix.size(), Pos - AnalyzerPrefix.size()); +AnalyzerOptions-Config[(Twine(AnalyzerCheckName) + : + + OptName.substr(Pos + 1)).str()] = Opt.second;

Re: [PATCH] [PATCH v3] [PowerPC] Add Hardware Transaction Memory builtins support

2015-03-11 Thread Adhemerval Zanella
I will update with full context and with correct patch. http://reviews.llvm.org/D8226 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu

[PATCH] [PATCH v4] [PowerPC] Add Hardware Transaction Memory builtins support

2015-03-11 Thread Adhemerval Zanella
Hi hfinkel, kbarton, nemanjai, wschmidt, This patch adds Hardware Transaction Memory (HTM) support supported by ISA 2.07 (POWER8). The intrinsic support is based on GCC one [1], with both 'PowerPC HTM Low Level Built-in Functions' and 'PowerPC HTM High Level Inline Functions' implemented. Along

[PATCH] Let Clang invoke CloudABI's linker

2015-03-11 Thread Ed Schouten
Hi echristo, Now that CloudABI's target information and header search logic for Clang has been submitted, the only thing that remains to be done is adding support for CloudABI's linker. CloudABI uses Binutils ld, although there is some work to use lld instead. This means that this code is

Re: [PATCH] [clang-tidy] Static Analyzer checker configuration options passthrough

2015-03-11 Thread Gábor Horváth
Comment at: clang-tidy/ClangTidy.cpp:218 @@ +217,3 @@ +OptName.substr(AnalyzerPrefix.size(), Pos - AnalyzerPrefix.size()); +AnalyzerOptions-Config[(Twine(AnalyzerCheckName) + : + + OptName.substr(Pos + 1)).str()] = Opt.second;

r231999 - Update copyright year to 2015.

2015-03-11 Thread Tanya Lattner
Author: tbrethou Date: Wed Mar 11 20:36:10 2015 New Revision: 231999 URL: http://llvm.org/viewvc/llvm-project?rev=231999view=rev Log: Update copyright year to 2015. Modified: cfe/trunk/LICENSE.TXT Modified: cfe/trunk/LICENSE.TXT URL:

Re: [PATCH] Use clock_gettime()'s CLOCK_REALTIME instead of gettimeofday() where possible

2015-03-11 Thread Marshall Clow
@hfinkel wrote: Sure, but that has little to do with what POSIX calls its 'monotonic clock'. Sorry, I used the wrong terminology. The C++ standard **requires** (and large portions of libc++ depend on), the existence of `std::steady_clock`, which is a clock which only moves forward; and does

Re: r231787 - Allow -target= and --target options

2015-03-11 Thread Chandler Carruth
On Wed, Mar 11, 2015 at 2:27 PM, Richard Smith rich...@metafoo.co.uk wrote: The previous state was that we allowed -target blah and --target=blah, but not -target=blah nor --target blah. This new state seems better than that in some ways, but neither is particularly satisfactory. The support

r231983 - Add deprecation notice for -f(no-)sanitize-recover flags.

2015-03-11 Thread Alexey Samsonov
Author: samsonov Date: Wed Mar 11 18:34:25 2015 New Revision: 231983 URL: http://llvm.org/viewvc/llvm-project?rev=231983view=rev Log: Add deprecation notice for -f(no-)sanitize-recover flags. These flags should be replaced with corresponding -f(no-)sanitize-recover=list flags. Modified:

Re: [PATCH] Use clock_gettime()'s CLOCK_REALTIME instead of gettimeofday() where possible

2015-03-11 Thread hfin...@anl.gov
In http://reviews.llvm.org/D8253#139038, @mclow.lists wrote: Indeed, I added _LIBCPP_HAS_NO_MONOTONIC_CLOCK for exactly the situation @hfinkel describes: my platform doesn't have access to a monotonic clock. Note that if you don't have a monotonic clock, none of the thread/mutex/etc

r231997 - Driver: Keep -isysroot flags in crash scripts if we're dumping a VFS

2015-03-11 Thread Justin Bogner
Author: bogner Date: Wed Mar 11 19:52:56 2015 New Revision: 231997 URL: http://llvm.org/viewvc/llvm-project?rev=231997view=rev Log: Driver: Keep -isysroot flags in crash scripts if we're dumping a VFS For crashes with a VFS (ie, with modules), the -isysroot flag is often necessary to reproduce

RE: r231989 - Driver: Print the clang version and original command in crash scripts

2015-03-11 Thread Robinson, Paul
-Original Message- From: cfe-commits-boun...@cs.uiuc.edu [mailto:cfe-commits- boun...@cs.uiuc.edu] On Behalf Of Justin Bogner Sent: Wednesday, March 11, 2015 5:15 PM To: cfe-commits@cs.uiuc.edu Subject: r231989 - Driver: Print the clang version and original command in crash

[PATCH] Use clock_gettime()'s CLOCK_REALTIME instead of gettimeofday() where possible

2015-03-11 Thread Ed Schouten
Hi jroelofs, The system_clock::now() function currently uses gettimeofday(). The problem with gettimeofday() is that it is an obsolete XSI function, hence unavailable on CloudABI. See: http://pubs.opengroup.org/onlinepubs/9699919799/functions/gettimeofday.html Change this code to use

r231909 - Sema: Properly track mangling number/name for linkage for using decls

2015-03-11 Thread David Majnemer
Author: majnemer Date: Wed Mar 11 01:45:39 2015 New Revision: 231909 URL: http://llvm.org/viewvc/llvm-project?rev=231909view=rev Log: Sema: Properly track mangling number/name for linkage for using decls Using declarations which are aliases to struct types have their name used as the struct

Re: [PATCH] [clang-tidy] Static Analyzer checker configuration options passthrough

2015-03-11 Thread Gábor Horváth
Changes: - Renamed the function that sets analyzer checker configuration option and swapped the parameters - Using the same format for checker options as the -analyzer-config analyzer command-line option. - Minor code tweaks http://reviews.llvm.org/D8164 Files: clang-tidy/ClangTidy.cpp

Re: r231989 - Driver: Print the clang version and original command in crash scripts

2015-03-11 Thread Justin Bogner
Robinson, Paul paul_robin...@playstation.sony.com writes: -Original Message- From: cfe-commits-boun...@cs.uiuc.edu [mailto:cfe-commits- boun...@cs.uiuc.edu] On Behalf Of Justin Bogner Sent: Wednesday, March 11, 2015 5:15 PM To: cfe-commits@cs.uiuc.edu Subject: r231989 - Driver: Print