[cfe-commits] r167219 - in /cfe/trunk: lib/CodeGen/CGExpr.cpp test/CodeGen/catch-undef-behavior.c

2012-11-01 Thread Richard Smith
Author: rsmith Date: Thu Nov 1 02:22:08 2012 New Revision: 167219 URL: http://llvm.org/viewvc/llvm-project?rev=167219view=rev Log: -fcatch-undefined-behavior: Start checking loads and stores for null pointers. We want the diagnostic, and if the load is optimized away, we still want to trap it.

Re: [cfe-commits] [patch] Add a llvm::Triple::CPUArch enum

2012-11-01 Thread David Tweed
Hi Rafael, This looks like a reasonable goal, but obviously the ARM architecture being quite modular there are a lot more actual variants (and a huge number more potential variants) than for other CPUs (and those listed in the table). Is there any nice mechanism for checking if an enum is one

Re: [cfe-commits] [PATCH] Fix x86 android support in clang

2012-11-01 Thread Evgeniy Stepanov
LGTM with the default cpu test Comment at: lib/Driver/Tools.cpp:1091 @@ -1090,2 +1090,3 @@ ArgStringList CmdArgs) const { + const bool isAndroid = getToolChain().getTriple().getEnvironment() == llvm::Triple::Android; if

[cfe-commits] [PATCH] Clean up StmtDumper indentation

2012-11-01 Thread Philip Craig
Hi alexfh, doug.gregor, Create helper functions in StmtDumper for outputting the indentation, newlines, and brackets. This is preparation for adding Decl dumping. http://llvm-reviews.chandlerc.com/D95 Files: lib/AST/StmtDumper.cpp test/Misc/ast-dump-stmt.c test/Misc/ast-dump-stmt.m

[cfe-commits] [PATCH][libcxxabi] loop boundary bug in personality routine when scanning eh table

2012-11-01 Thread 谷汶翰
Dear cfe-commits and libcxxabi developers, I hit a bug in libc++abi when testing on a gcc testsuite sample. This can be fixed simply by this small patch. Please help review it. Thanks in advance! Index: src/cxa_personality.cpp ===

Re: [cfe-commits] [patch] Add a llvm::Triple::CPUArch enum

2012-11-01 Thread Matthieu Monrocq
On Thu, Nov 1, 2012 at 10:04 AM, David Tweed david.tw...@arm.com wrote: Hi Rafael, This looks like a reasonable goal, but obviously the ARM architecture being quite modular there are a lot more actual variants (and a huge number more potential variants) than for other CPUs (and those listed

Re: [cfe-commits] [PATCH] Add unit tests for source locations of AST nodes

2012-11-01 Thread Philip Craig
* added some FIXMEs * removed use of FullSourceLoc Hi klimek, chandlerc, http://llvm-reviews.chandlerc.com/D72 CHANGE SINCE LAST DIFF http://llvm-reviews.chandlerc.com/D72?vs=195id=243#toc Files: unittests/AST/CMakeLists.txt unittests/AST/SourceLocationTest.cpp Index:

Re: [cfe-commits] [PATCH] Add unit tests for source locations of AST nodes

2012-11-01 Thread Philip Craig
Comment at: unittests/AST/SourceLocationTest.cpp:25-27 @@ +24,5 @@ + +/// \brief Base class for verifying some property of nodes found by a matcher. +template typename NodeType +class MatchVerifier : public MatchFinder::MatchCallback { +public: Chandler Carruth

Re: [cfe-commits] [PATCH] PR13788 - sema crash on add initializer

2012-11-01 Thread Brian Brooks
Adding cfe-dev... On Wed, Oct 31, 2012 at 5:26 PM, Brian Brooks brooks.br...@gmail.comwrote: The attached patch needs review please! I suspect that we may need to call RequireCompleteType() to do instantiation *even if* the VDecl is a dependent type. I am not yet able to reason about this

Re: [cfe-commits] [patch] Add a llvm::Triple::CPUArch enum

2012-11-01 Thread David Tweed
This looks like a reasonable goal, but obviously the ARM architecture being quite modular there are a lot more actual variants (and a huge number more potential variants) than for other CPUs (and those listed in the table). Is there any nice mechanism for checking if an enum is one of a list of

Re: [cfe-commits] r167148 - in /cfe/trunk: lib/Headers/altivec.h test/Headers/altivec-header.c

2012-11-01 Thread Ulrich Weigand
Michael Gottesman mgottes...@apple.com wrote on 31.10.2012 21:20:25: After chatting with Hal Finkel, it seems that Ulrich probably has gone home for the day. I fixed the issue and committed it in r167162. Sorry for the breakage; thanks for the quick fix! Bye, Ulrich

Re: [cfe-commits] [PATCH] Clean up StmtDumper indentation

2012-11-01 Thread Manuel Klimek
Comment at: lib/AST/StmtDumper.cpp:33 @@ -32,2 +32,3 @@ unsigned IndentLevel; +bool NeedNewLine; I think it's not immediately clear what cases are handled by this bool - a comment would help me here... After reading the whole patch, it looks like

Re: [cfe-commits] Fix for PR 13127

2012-11-01 Thread Konstantin Tokarev
25.10.2012, 15:50, Konstantin Tokarev annu...@yandex.ru: Hi all, This patch fixes http://llvm.org/bugs/show_bug.cgi?id=13127. Could anyone review it? +cfe-dev -- Regards, KonstantinFrom a2f1462d00d9fdcb0b3ee22da32e258270ca90a2 Mon Sep 17 00:00:00 2001 From: Konstantin Tokarev

Re: [cfe-commits] [PATCH] Simplifying lit script for remove-cstr-calls

2012-11-01 Thread Manuel Klimek
On Wed, Oct 31, 2012 at 12:10 PM, Vane, Edwin edwin.v...@intel.com wrote: From: Matthieu Monrocq [mailto:matthieu.monr...@gmail.com] Sent: Wednesday, October 31, 2012 2:17 PM To: reviews+d92+public+254f3887f2e36...@llvm-reviews.chandlerc.com Cc: chandl...@gmail.com; Vane, Edwin; Clang Dev

Re: [cfe-commits] [PATCH] Simplifying lit script for remove-cstr-calls

2012-11-01 Thread Manuel Klimek
Looks good. Thanks! http://llvm-reviews.chandlerc.com/D92 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [cfe-commits] [patch] Add a llvm::Triple::CPUArch enum

2012-11-01 Thread Matthieu Monrocq
On Thu, Nov 1, 2012 at 1:39 PM, David Tweed david.tw...@arm.com wrote: This looks like a reasonable goal, but obviously the ARM architecture being quite modular there are a lot more actual variants (and a huge number more potential variants) than for other CPUs (and those listed in the

Re: [cfe-commits] [PATCH] Fix for -ast-dump-filter

2012-11-01 Thread Manuel Klimek
Looks good. http://llvm-reviews.chandlerc.com/D93 COMMIT http://llvm-reviews.chandlerc.com/rL167155 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

[cfe-commits] r167232 - in /cfe/trunk: lib/AST/Expr.cpp test/SemaCXX/crashes.cpp

2012-11-01 Thread Rafael Espindola
Author: rafael Date: Thu Nov 1 09:32:20 2012 New Revision: 167232 URL: http://llvm.org/viewvc/llvm-project?rev=167232view=rev Log: Fix an incorrect assert, the LHS can be an LValue. Modified: cfe/trunk/lib/AST/Expr.cpp cfe/trunk/test/SemaCXX/crashes.cpp Modified:

[cfe-commits] Can't Build Clang on AWS Amazon Linux Instance

2012-11-01 Thread st...@steck.com
Hello Clanger's, When trying to build Clang on a standard Amazon Linux instance in the AWS cloud I received this error:   COMPILE:   clang_linux/asan-x86_64/x86_64: /home/ec2-user/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc

Re: [cfe-commits] Can't Build Clang on AWS Amazon Linux Instance

2012-11-01 Thread Kostya Serebryany
+samsonov I think it's time to get rid of this #include new completely... On Thu, Nov 1, 2012 at 7:12 PM, st...@steck.com st...@steck.com wrote: Hello Clanger's, When trying to build Clang on a standard Amazon Linux instance in the AWS cloud I received this error: COMPILE:

Re: [cfe-commits] Can't Build Clang on AWS Amazon Linux Instance

2012-11-01 Thread st...@steck.com
FWIW, I removed the #include new and associated code and the compile completed; but clang++ couldn't build a simple test program. It couldn't find headers and libs...e.g.main.cpp:1:10: fatal error: 'iostream' file not foundOn Nov 01, 2012, Kostya Serebryany k...@google.com wrote:+samsonovI think

[cfe-commits] [libcxx] r167233 - /libcxx/trunk/include/type_traits

2012-11-01 Thread Howard Hinnant
Author: hhinnant Date: Thu Nov 1 11:32:14 2012 New Revision: 167233 URL: http://llvm.org/viewvc/llvm-project?rev=167233view=rev Log: Richard Smith: This fixes a problem in std::is_constructible for incomplete types, and those types with a user-defined operator,(). Modified:

[cfe-commits] Cilk Plus Extension for Clang

2012-11-01 Thread Pan, Wei
Hello All, Our team would like to add the Cilk Plus extension to Clang for C/C++ (http://software.intel.com/file/40297). To meet the requirements that Clang sets, we would like to keep our patches small and upstream our patches as early as possible. We would appreciate any guidance that the

[cfe-commits] [libcxx] r167238 - /libcxx/trunk/include/istream

2012-11-01 Thread Howard Hinnant
Author: hhinnant Date: Thu Nov 1 12:32:07 2012 New Revision: 167238 URL: http://llvm.org/viewvc/llvm-project?rev=167238view=rev Log: peek should set eofbit if sgetc() returns eof. Modified: libcxx/trunk/include/istream Modified: libcxx/trunk/include/istream URL:

[cfe-commits] r167239 - in /cfe/trunk: lib/Lex/PPDirectives.cpp unittests/Lex/CMakeLists.txt unittests/Lex/PPCallbacksTest.cpp

2012-11-01 Thread Argyrios Kyrtzidis
Author: akirtzidis Date: Thu Nov 1 12:52:58 2012 New Revision: 167239 URL: http://llvm.org/viewvc/llvm-project?rev=167239view=rev Log: Make the FilenameRange of the InclusionDirective callback more accurate, preserve the macro location of the range end if the filename came from a macro. Patch

Re: [cfe-commits] [PATCH] Multiple pragmas at the start of a compound statement.

2012-11-01 Thread Lang Hames
Ping. On Thu, Oct 25, 2012 at 1:39 PM, Lang Hames lha...@gmail.com wrote: Hi All, Tim Northover pointed out that there's a flaw in my recent FP_CONTRACT patch (r166383). That patch restricted FP_CONTRACT (or rather tok::annot_pragma_fp_contract) to appearing as the first token in a

Re: [cfe-commits] r164874 - in /cfe/trunk: include/clang/Lex/PPCallbacks.h include/clang/Lex/PreprocessingRecord.h lib/Frontend/DependencyFile.cpp lib/Frontend/DependencyGraph.cpp lib/Lex/PPDirectives

2012-11-01 Thread Argyrios Kyrtzidis
Committed in r167239, with some changes in the test to accommodate clang changes and to eliminate warnings. Thanks! On Oct 29, 2012, at 5:38 AM, Kim Gräsman kim.gras...@gmail.com wrote: Could somebody take a look at this? Getting this behavior fixed and fixated would make our lives as

Re: [cfe-commits] [PATCH][libcxxabi] loop boundary bug in personality routine when scanning eh table

2012-11-01 Thread Howard Hinnant
On Nov 1, 2012, at 5:32 AM, Wen-Han Gu (谷汶翰) wenhan...@gmail.com wrote: Dear cfe-commits and libcxxabi developers, I hit a bug in libc++abi when testing on a gcc testsuite sample. This can be fixed simply by this small patch. Please help review it. Thanks in advance! Index:

Re: [cfe-commits] [PATCH] Update the front end to use minsize attribute

2012-11-01 Thread Quentin Colombet
Ping. On Oct 31, 2012, at 11:55 AM, Quentin Colombet qcolom...@apple.com wrote: On Oct 30, 2012, at 1:40 PM, Dmitri Gribenko griboz...@gmail.com wrote: On Tue, Oct 30, 2012 at 10:29 PM, Quentin Colombet qcolom...@apple.com wrote: On Oct 30, 2012, at 12:36 PM, Dmitri Gribenko

Re: [cfe-commits] [PATCH] Update the front end to use minsize attribute

2012-11-01 Thread Quentin Colombet
Ping. On Oct 31, 2012, at 11:55 AM, Quentin Colombet qcolom...@apple.com wrote: On Oct 30, 2012, at 1:40 PM, Dmitri Gribenko griboz...@gmail.com wrote: On Tue, Oct 30, 2012 at 10:29 PM, Quentin Colombet qcolom...@apple.com wrote: On Oct 30, 2012, at 12:36 PM, Dmitri Gribenko

[cfe-commits] r167241 - in /cfe/trunk: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGBlocks.h lib/CodeGen/CGObjCMac.cpp test/CodeGenObjC/arc-block-ivar-layout.m test/CodeGenObjC/arc-blocks.m test/CodeGenObjC

2012-11-01 Thread Fariborz Jahanian
Author: fjahanian Date: Thu Nov 1 13:32:55 2012 New Revision: 167241 URL: http://llvm.org/viewvc/llvm-project?rev=167241view=rev Log: objective-C block meta-data. This patch completes meta-data generation for captured block variables in arc mode. This includes inlined version of the meta-data

Re: [cfe-commits] [PATCH] Update the front end to use minsize attribute

2012-11-01 Thread Eric Christopher
LGTM, go ahead and anything else can be added incrementally. -eric On Thu, Nov 1, 2012 at 11:15 AM, Quentin Colombet qcolom...@apple.com wrote: Ping. On Oct 31, 2012, at 11:55 AM, Quentin Colombet qcolom...@apple.com wrote: On Oct 30, 2012, at 1:40 PM, Dmitri Gribenko griboz...@gmail.com

Re: [cfe-commits] [PATCH] Update the front end to use minsize attribute

2012-11-01 Thread Douglas Gregor
On Oct 31, 2012, at 11:55 AM, Quentin Colombet qcolom...@apple.com wrote: On Oct 30, 2012, at 1:40 PM, Dmitri Gribenko griboz...@gmail.com wrote: On Tue, Oct 30, 2012 at 10:29 PM, Quentin Colombet qcolom...@apple.com wrote: On Oct 30, 2012, at 12:36 PM, Dmitri Gribenko

[cfe-commits] [PATCH] WIP: catch CFMakeCollectable(NULL) with static analyzer

2012-11-01 Thread Sean McBride
Hi all, Attached is a patch that expands the analyzer's check for CFRelease(NULL) to also catch CFMakeCollectable(NULL). It builds, and the resulting clang does now warn on CFMakeCollectable(NULL), but I have not added a test. I'm pretty sure the test belongs in retain-release.m in f16() and

Re: [cfe-commits] [PATCH] Multiple pragmas at the start of a compound statement.

2012-11-01 Thread John McCall
On Oct 25, 2012, at 1:39 PM, Lang Hames wrote: Tim Northover pointed out that there's a flaw in my recent FP_CONTRACT patch (r166383). That patch restricted FP_CONTRACT (or rather tok::annot_pragma_fp_contract) to appearing as the first token in a compound statement. The problem with my

Re: [cfe-commits] [PATCH] Fix x86 android support in clang

2012-11-01 Thread Edwin Vane
Instead of using 'atom' as default cpu name, after some internal consultation, 'core2' is a better common denominator for x86 android. Added tests to test/Driver/clang-translation.c. Note that gcc doesn't appear to do anything special if you don't explicitly specify which CPU to target

Re: [cfe-commits] [PATCH] Fix x86 android support in clang

2012-11-01 Thread Edwin Vane
Just want to make sure the new default CPUName is ok. http://llvm-reviews.chandlerc.com/D91 ___ cfe-commits mailing list cfe-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Re: [cfe-commits] [PATCH] Fix x86 android support in clang

2012-11-01 Thread Rafael Espíndola
On 1 November 2012 15:59, Edwin Vane edwin.v...@intel.com wrote: Instead of using 'atom' as default cpu name, after some internal consultation, 'core2' is a better common denominator for x86 android. Added tests to test/Driver/clang-translation.c. Why? Can you add a comment saying why

[cfe-commits] r167249 - /cfe/trunk/lib/CodeGen/CGObjCMac.cpp

2012-11-01 Thread Matt Beaumont-Gay
Author: matthewbg Date: Thu Nov 1 15:26:42 2012 New Revision: 167249 URL: http://llvm.org/viewvc/llvm-project?rev=167249view=rev Log: Silence -Wformat on platforms where uint64_t is unsigned long. Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp

Re: [cfe-commits] [PATCH] Fix x86 android support in clang

2012-11-01 Thread Edwin Vane
Sorry for the spam. Uploaded the wrong patch file (i.e. the old one again) last time. Hi eugenis, http://llvm-reviews.chandlerc.com/D91 CHANGE SINCE LAST DIFF http://llvm-reviews.chandlerc.com/D91?vs=245id=246#toc Files: lib/Driver/Tools.cpp test/Driver/clang-translation.c

Re: [cfe-commits] [PATCH] Fix x86 android support in clang

2012-11-01 Thread Rafael Espíndola
lgtm On 1 November 2012 16:29, Edwin Vane edwin.v...@intel.com wrote: Sorry for the spam. Uploaded the wrong patch file (i.e. the old one again) last time. Hi eugenis, http://llvm-reviews.chandlerc.com/D91 CHANGE SINCE LAST DIFF http://llvm-reviews.chandlerc.com/D91?vs=245id=246#toc

Re: [cfe-commits] [PATCH] Update the front end to use minsize attribute

2012-11-01 Thread Quentin Colombet
Hi Doug, On Nov 1, 2012, at 11:46 AM, Douglas Gregor dgre...@apple.com wrote: On Oct 31, 2012, at 11:55 AM, Quentin Colombet qcolom...@apple.com wrote: On Oct 30, 2012, at 1:40 PM, Dmitri Gribenko griboz...@gmail.com wrote: On Tue, Oct 30, 2012 at 10:29 PM, Quentin Colombet

Re: [cfe-commits] [PATCH] Fix x86 android support in clang

2012-11-01 Thread Edwin Vane
Addressed reviewer comments. Hi eugenis, http://llvm-reviews.chandlerc.com/D91 CHANGE SINCE LAST DIFF http://llvm-reviews.chandlerc.com/D91?vs=244id=245#toc Files: lib/Driver/Tools.cpp test/Driver/clang-translation.c test/Driver/linux-ld.c Index: lib/Driver/Tools.cpp

Re: [cfe-commits] [PATCH] Update the front end to use minsize attribute

2012-11-01 Thread Dmitri Gribenko
On Thu, Nov 1, 2012 at 10:31 PM, Quentin Colombet qcolom...@apple.com wrote: On Nov 1, 2012, at 11:46 AM, Douglas Gregor dgre...@apple.com wrote: Also, please add a test involving C++ function templates, to be sure that the attribute gets propagated to the instantiation correctly. It is in

Re: [cfe-commits] r167249 - /cfe/trunk/lib/CodeGen/CGObjCMac.cpp

2012-11-01 Thread jahanian
On Nov 1, 2012, at 1:26 PM, Matt Beaumont-Gay matthe...@google.com wrote: Author: matthewbg Date: Thu Nov 1 15:26:42 2012 New Revision: 167249 URL: http://llvm.org/viewvc/llvm-project?rev=167249view=rev Log: Silence -Wformat on platforms where uint64_t is unsigned long. Thank you. -

Re: [cfe-commits] [PATCH] Update the front end to use minsize attribute

2012-11-01 Thread Quentin Colombet
On Nov 1, 2012, at 1:36 PM, Dmitri Gribenko griboz...@gmail.com wrote: On Thu, Nov 1, 2012 at 10:31 PM, Quentin Colombet qcolom...@apple.com wrote: On Nov 1, 2012, at 11:46 AM, Douglas Gregor dgre...@apple.com wrote: Also, please add a test involving C++ function templates, to be sure that

Re: [cfe-commits] r164083 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/Sema/warn-duplicate-enum.c test/SemaCXX/warn-unique-enum.cpp

2012-11-01 Thread Richard Trieu
On Wed, Oct 3, 2012 at 2:27 PM, Richard Trieu rtr...@google.com wrote: On Mon, Sep 17, 2012 at 5:41 PM, Ted Kremenek kreme...@apple.com wrote: Author: kremenek Date: Mon Sep 17 19:41:42 2012 New Revision: 164083 URL: http://llvm.org/viewvc/llvm-project?rev=164083view=rev Log: Per

[cfe-commits] r167252 - in /cfe/trunk: lib/AST/ASTDiagnostic.cpp test/Misc/diag-template-diffing.cpp

2012-11-01 Thread Richard Trieu
Author: rtrieu Date: Thu Nov 1 16:29:28 2012 New Revision: 167252 URL: http://llvm.org/viewvc/llvm-project?rev=167252view=rev Log: Fix the template type diffing to handle integral template arguments. Modified: cfe/trunk/lib/AST/ASTDiagnostic.cpp

Re: [cfe-commits] [Patch] Add handling of APSInt to Template Type Diffing - Fixes PR14015

2012-11-01 Thread Richard Trieu
On Mon, Oct 22, 2012 at 3:24 PM, Richard Trieu rtr...@google.com wrote: On Mon, Oct 22, 2012 at 2:37 PM, Matthew Curtis mcur...@codeaurora.orgwrote: On 10/8/2012 8:55 PM, Richard Trieu wrote: An assumption during the creation of Template Type Diffing expected that integral arguments

Re: [cfe-commits] Cilk Plus Extension for Clang

2012-11-01 Thread Eli Friedman
On Thu, Nov 1, 2012 at 10:09 AM, Pan, Wei wei@intel.com wrote: Hello All, Our team would like to add the Cilk Plus extension to Clang for C/C++ (http://software.intel.com/file/40297). To meet the requirements that Clang sets, we would like to keep our patches small and upstream our

[cfe-commits] r167260 - /cfe/trunk/lib/CodeGen/CGExprScalar.cpp

2012-11-01 Thread Richard Smith
Author: rsmith Date: Thu Nov 1 17:16:43 2012 New Revision: 167260 URL: http://llvm.org/viewvc/llvm-project?rev=167260view=rev Log: Clean up misapplication of diff. Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp URL:

[cfe-commits] r167259 - in /cfe/trunk/lib/CodeGen: CGExpr.cpp CGExprScalar.cpp CodeGenFunction.h

2012-11-01 Thread Richard Smith
Author: rsmith Date: Thu Nov 1 17:15:34 2012 New Revision: 167259 URL: http://llvm.org/viewvc/llvm-project?rev=167259view=rev Log: Split emission of -ftrapv checks and -fcatch-undefined-behavior checks into separate functions, since they share essentially no code. Modified:

[cfe-commits] r167258 - in /cfe/trunk: lib/CodeGen/CGExprScalar.cpp test/CodeGen/trapv.c

2012-11-01 Thread Richard Smith
Author: rsmith Date: Thu Nov 1 17:13:39 2012 New Revision: 167258 URL: http://llvm.org/viewvc/llvm-project?rev=167258view=rev Log: Remove divison-by-zero checks from -ftrapv. These checks were incompatible with g++'s -ftrapv, failed to call the -ftrapv overflow handler, and are still available

Re: [cfe-commits] Cilk Plus Extension for Clang

2012-11-01 Thread Richard Smith
--- include/clang/Driver/Options.td +++ include/clang/Driver/Options.td @@ -587,6 +587,9 @@ def fobjc_sender_dependent_dispatch : Flag[-], fobjc-sender-dependent-dispat def fobjc : Flag[-], fobjc, Groupf_Group; def fomit_frame_pointer : Flag[-], fomit-frame-pointer, Groupf_Group; def fopenmp :

Re: [cfe-commits] r167258 - in /cfe/trunk: lib/CodeGen/CGExprScalar.cpp test/CodeGen/trapv.c

2012-11-01 Thread Dmitri Gribenko
On Fri, Nov 2, 2012 at 12:13 AM, Richard Smith richard-l...@metafoo.co.uk wrote: Author: rsmith Date: Thu Nov 1 17:13:39 2012 New Revision: 167258 URL: http://llvm.org/viewvc/llvm-project?rev=167258view=rev Log: Remove divison-by-zero checks from -ftrapv. These checks were incompatible

Re: [cfe-commits] [PATCH] Clean up StmtDumper indentation

2012-11-01 Thread Philip Craig
Comment at: lib/AST/StmtDumper.cpp:33 @@ -32,2 +32,3 @@ unsigned IndentLevel; +bool NeedNewLine; Manuel Klimek wrote: I think it's not immediately clear what cases are handled by this bool - a comment would help me here... After reading the

[cfe-commits] r167261 - in /cfe/trunk/lib/CodeGen: CGCall.cpp CGClass.cpp CGDebugInfo.cpp CGDecl.cpp CGDeclCXX.cpp CGExpr.cpp CGExprAgg.cpp CGExprCXX.cpp CGExprComplex.cpp CGExprScalar.cpp CGObjCGNU.c

2012-11-01 Thread Richard Smith
Author: rsmith Date: Thu Nov 1 17:30:59 2012 New Revision: 167261 URL: http://llvm.org/viewvc/llvm-project?rev=167261view=rev Log: Simplify: replace getContext().getLangOpts() with just getLangOpts(). Modified: cfe/trunk/lib/CodeGen/CGCall.cpp cfe/trunk/lib/CodeGen/CGClass.cpp

Re: [cfe-commits] r167258 - in /cfe/trunk: lib/CodeGen/CGExprScalar.cpp test/CodeGen/trapv.c

2012-11-01 Thread Richard Smith
On Thu, Nov 1, 2012 at 3:26 PM, Dmitri Gribenko griboz...@gmail.com wrote: On Fri, Nov 2, 2012 at 12:13 AM, Richard Smith richard-l...@metafoo.co.uk wrote: Author: rsmith Date: Thu Nov 1 17:13:39 2012 New Revision: 167258 URL: http://llvm.org/viewvc/llvm-project?rev=167258view=rev Log:

Re: [cfe-commits] [PATCH] Clean up StmtDumper indentation

2012-11-01 Thread Philip Craig
Deleted flush() method. Hi alexfh, doug.gregor, http://llvm-reviews.chandlerc.com/D95 CHANGE SINCE LAST DIFF http://llvm-reviews.chandlerc.com/D95?vs=242id=248#toc Files: lib/AST/StmtDumper.cpp test/Misc/ast-dump-stmt.c test/Misc/ast-dump-stmt.m Index: lib/AST/StmtDumper.cpp

Re: [cfe-commits] r167249 - /cfe/trunk/lib/CodeGen/CGObjCMac.cpp

2012-11-01 Thread NAKAMURA Takumi
2012/11/2 jahanian fjahan...@apple.com: On Nov 1, 2012, at 1:26 PM, Matt Beaumont-Gay matthe...@google.com wrote: Author: matthewbg Date: Thu Nov 1 15:26:42 2012 New Revision: 167249 URL: http://llvm.org/viewvc/llvm-project?rev=167249view=rev Log: Silence -Wformat on platforms where

Re: [cfe-commits] [PATCH] PR13788 - sema crash on add initializer

2012-11-01 Thread Richard Smith
On Thu, Nov 1, 2012 at 5:36 AM, Brian Brooks brooks.br...@gmail.com wrote: Adding cfe-dev... Dropping cfe-dev via bcc, you were right first time. On Wed, Oct 31, 2012 at 5:26 PM, Brian Brooks brooks.br...@gmail.com wrote: The attached patch needs review please! I suspect that we may need

Re: [cfe-commits] r167249 - /cfe/trunk/lib/CodeGen/CGObjCMac.cpp

2012-11-01 Thread Matt Beaumont-Gay
On Thu, Nov 1, 2012 at 3:48 PM, NAKAMURA Takumi geek4ci...@gmail.com wrote: 2012/11/2 jahanian fjahan...@apple.com: On Nov 1, 2012, at 1:26 PM, Matt Beaumont-Gay matthe...@google.com wrote: Author: matthewbg Date: Thu Nov 1 15:26:42 2012 New Revision: 167249 URL:

Re: [cfe-commits] [PATCH] Update the front end to use minsize attribute

2012-11-01 Thread Douglas Gregor
On Nov 1, 2012, at 1:31 PM, Quentin Colombet qcolom...@apple.com wrote: Hi Doug, On Nov 1, 2012, at 11:46 AM, Douglas Gregor dgre...@apple.com wrote: On Oct 31, 2012, at 11:55 AM, Quentin Colombet qcolom...@apple.com wrote: On Oct 30, 2012, at 1:40 PM, Dmitri Gribenko

Re: [cfe-commits] [PATCH] Update the front end to use minsize attribute

2012-11-01 Thread Quentin Colombet
On Nov 1, 2012, at 3:57 PM, Douglas Gregor dgre...@apple.com wrote: On Nov 1, 2012, at 1:31 PM, Quentin Colombet qcolom...@apple.com wrote: Hi Doug, On Nov 1, 2012, at 11:46 AM, Douglas Gregor dgre...@apple.com wrote: On Oct 31, 2012, at 11:55 AM, Quentin Colombet

Re: [cfe-commits] [PATCH] Update the front end to use minsize attribute

2012-11-01 Thread Douglas Gregor
LGTM, thanks! - Doug On Nov 1, 2012, at 4:43 PM, Quentin Colombet qcolom...@apple.com wrote: On Nov 1, 2012, at 3:57 PM, Douglas Gregor dgre...@apple.com wrote: On Nov 1, 2012, at 1:31 PM, Quentin Colombet qcolom...@apple.com wrote: Hi Doug, On Nov 1, 2012, at 11:46 AM,

[cfe-commits] r167266 - in /cfe/trunk: include/clang/Basic/Attr.td lib/CodeGen/CodeGenModule.cpp lib/Sema/SemaDeclAttr.cpp test/CodeGen/attr-minsize.c test/CodeGen/attr-minsize.cpp test/CodeGenObjC/at

2012-11-01 Thread Quentin Colombet
Author: qcolombet Date: Thu Nov 1 18:55:47 2012 New Revision: 167266 URL: http://llvm.org/viewvc/llvm-project?rev=167266view=rev Log: Update the front end to use minsize attribute Added: cfe/trunk/test/CodeGen/attr-minsize.cpp - copied, changed from r167249,

Re: [cfe-commits] r167249 - /cfe/trunk/lib/CodeGen/CGObjCMac.cpp

2012-11-01 Thread jahanian
On Nov 1, 2012, at 3:59 PM, Matt Beaumont-Gay matthe...@google.com wrote: On Thu, Nov 1, 2012 at 3:48 PM, NAKAMURA Takumi geek4ci...@gmail.com wrote: 2012/11/2 jahanian fjahan...@apple.com: On Nov 1, 2012, at 1:26 PM, Matt Beaumont-Gay matthe...@google.com wrote: Author: matthewbg Date:

[cfe-commits] r167268 - in /cfe/trunk: include/clang/Basic/DiagnosticParseKinds.td include/clang/Parse/Parser.h lib/Parse/ParseExprCXX.cpp test/Parser/colon-colon-parentheses.cpp

2012-11-01 Thread Richard Trieu
Author: rtrieu Date: Thu Nov 1 20:08:58 2012 New Revision: 167268 URL: http://llvm.org/viewvc/llvm-project?rev=167268view=rev Log: When finding a '(' after '::', emit error with hint to remove '(' and matching ')', if found. Don't crash. Fixes PR11852. Added:

Re: [cfe-commits] [Patch] Add checking for '(' after '::' - fixes crash as reported in PR11852

2012-11-01 Thread Richard Trieu
Committed at r167268. On Fri, Oct 5, 2012 at 3:18 PM, David Blaikie dblai...@gmail.com wrote: Minor point: misspelled ColonColon as ColocColon. GetLookAheadToken(0) is synonymous with getCurToken as far as I know ( the latter's infinitely more common) Other than that it all looks reasonable

Re: [cfe-commits] [PATCH][libcxxabi] loop boundary bug in personality routine when scanning eh table

2012-11-01 Thread 谷汶翰
Hello Howard, It did happen on ARM and x86_32, and I guess all targets have this bug. This bug behaves depending on the upcoming entry, might be nothing, infinite loop, other errors... Thanks. 2012/11/2 Howard Hinnant hhinn...@apple.com On Nov 1, 2012, at 5:32 AM, Wen-Han Gu (谷汶翰)

[cfe-commits] r167271 - in /cfe/trunk: include/clang/ASTMatchers/ASTMatchFinder.h lib/ASTMatchers/ASTMatchFinder.cpp unittests/ASTMatchers/ASTMatchersTest.cpp

2012-11-01 Thread Manuel Klimek
Author: klimek Date: Thu Nov 1 20:31:03 2012 New Revision: 167271 URL: http://llvm.org/viewvc/llvm-project?rev=167271view=rev Log: Insert interception point onStartOfTranslationUnit. Often users of the ASTMatchers want to add tasks that are done once per translation unit, for example, cleaning

[cfe-commits] r167273 - in /cfe/trunk: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseDecl.cpp test/SemaCXX/MicrosoftExtensions.cpp

2012-11-01 Thread Eli Friedman
Author: efriedma Date: Thu Nov 1 20:34:28 2012 New Revision: 167273 URL: http://llvm.org/viewvc/llvm-project?rev=167273view=rev Log: Change diagnostics for enums with fixed underlying type so in C++98 mode, we cite C++11. Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td

[cfe-commits] r167274 - in /cfe/trunk: include/clang/Basic/DiagnosticLexKinds.td include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/DiagnosticSemaKinds.td test/Misc/warning-flags.c test/S

2012-11-01 Thread Eli Friedman
Author: efriedma Date: Thu Nov 1 20:40:23 2012 New Revision: 167274 URL: http://llvm.org/viewvc/llvm-project?rev=167274view=rev Log: Tweak wording and add diagnostic groups to misc diagnostics. Modified: cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td

[cfe-commits] r167275 - in /cfe/trunk: include/clang/StaticAnalyzer/Core/BugReporter/ include/clang/StaticAnalyzer/Core/PathSensitive/ lib/StaticAnalyzer/Checkers/ lib/StaticAnalyzer/Core/

2012-11-01 Thread Jordan Rose
Author: jrose Date: Thu Nov 1 20:53:40 2012 New Revision: 167275 URL: http://llvm.org/viewvc/llvm-project?rev=167275view=rev Log: [analyzer] Rename 'EmitReport' to 'emitReport'. No functionality change. Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h

[cfe-commits] r167276 - in /cfe/trunk: include/clang/StaticAnalyzer/Core/PathSensitive/ lib/StaticAnalyzer/Checkers/ lib/StaticAnalyzer/Core/

2012-11-01 Thread Jordan Rose
Author: jrose Date: Thu Nov 1 20:54:06 2012 New Revision: 167276 URL: http://llvm.org/viewvc/llvm-project?rev=167276view=rev Log: [analyzer] Use nice macros for the common ProgramStateTraits (map, set, list). Also, move the REGISTER_*_WITH_PROGRAMSTATE macros to ProgramStateTrait.h. This

[cfe-commits] r167277 - in /cfe/trunk: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h include/clang/StaticAnalyzer/Core/PathSensitive/TaintManager.h lib/StaticAnalyzer/Checkers/NSErrorCh

2012-11-01 Thread Jordan Rose
Author: jrose Date: Thu Nov 1 20:54:42 2012 New Revision: 167277 URL: http://llvm.org/viewvc/llvm-project?rev=167277view=rev Log: [analyzer] Convert some of the harder cases over to ProgramStateTrait macros. Add FIXMEs for the traits visible from multiple translation units. Currently the macros

Re: [cfe-commits] Cilk Plus Extension for Clang

2012-11-01 Thread Pan, Wei
Hi Richard and Eli, Thanks for the comments! I just created a new patch with git format-patch master..mybranch and it should work now. A svn version is also attached. Thanks again! Wei -Original Message- From: meta...@gmail.com [mailto:meta...@gmail.com] On Behalf Of Richard

[cfe-commits] r167278 - /cfe/trunk/examples/analyzer-plugin/MainCallChecker.cpp

2012-11-01 Thread NAKAMURA Takumi
Author: chapuni Date: Thu Nov 1 21:04:01 2012 New Revision: 167278 URL: http://llvm.org/viewvc/llvm-project?rev=167278view=rev Log: analyzer-plugin/MainCallChecker.cpp: Fixup corresponding to r167275. Modified: cfe/trunk/examples/analyzer-plugin/MainCallChecker.cpp Modified:

[cfe-commits] r167279 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td test/Misc/warning-flags.c

2012-11-01 Thread Eli Friedman
Author: efriedma Date: Thu Nov 1 21:14:44 2012 New Revision: 167279 URL: http://llvm.org/viewvc/llvm-project?rev=167279view=rev Log: Add missing diagnostic group to format string warning. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/test/Misc/warning-flags.c

[cfe-commits] r167280 - /cfe/trunk/lib/Serialization/ASTReader.cpp

2012-11-01 Thread Argyrios Kyrtzidis
Author: akirtzidis Date: Thu Nov 1 21:31:22 2012 New Revision: 167280 URL: http://llvm.org/viewvc/llvm-project?rev=167280view=rev Log: [libclang] Correct how the index inside the local preprocessed entities array is getting converted to a global PreprocessedEntityID. Modified:

[cfe-commits] r167281 - /cfe/trunk/include/clang/Basic/DiagnosticGroups.td

2012-11-01 Thread Eli Friedman
Author: efriedma Date: Thu Nov 1 22:35:13 2012 New Revision: 167281 URL: http://llvm.org/viewvc/llvm-project?rev=167281view=rev Log: Delete lines which do nothing from DiagnosticGroups.td. Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td Modified:

[cfe-commits] [PATCH] Reject C++11 attributes that appertain to decl specifiers

2012-11-01 Thread Michael Han
Hi, As previously discussed [1], attached patch enable Clang to reject C++11 attributes that appertain to declaration specifiers. This also conforms to what g++ 4.8 is doing [2]. Please review, thanks! Michael [1]

Re: [cfe-commits] r167268 - in /cfe/trunk: include/clang/Basic/DiagnosticParseKinds.td include/clang/Parse/Parser.h lib/Parse/ParseExprCXX.cpp test/Parser/colon-colon-parentheses.cpp

2012-11-01 Thread Matt Beaumont-Gay
On Thu, Nov 1, 2012 at 6:08 PM, Richard Trieu rtr...@google.com wrote: Author: rtrieu Date: Thu Nov 1 20:08:58 2012 New Revision: 167268 URL: http://llvm.org/viewvc/llvm-project?rev=167268view=rev Log: When finding a '(' after '::', emit error with hint to remove '(' and matching ')', if

Re: [cfe-commits] r164874 - in /cfe/trunk: include/clang/Lex/PPCallbacks.h include/clang/Lex/PreprocessingRecord.h lib/Frontend/DependencyFile.cpp lib/Frontend/DependencyGraph.cpp lib/Lex/PPDirectives

2012-11-01 Thread Kim Gräsman
On Thu, Nov 1, 2012 at 6:54 PM, Argyrios Kyrtzidis kyrtzi...@apple.com wrote: Committed in r167239, with some changes in the test to accommodate clang changes and to eliminate warnings. Thanks! Thanks for your help! - Kim ___ cfe-commits mailing

Re: [cfe-commits] [PATCH] Add -fsanitize= command line argument to control -fcatch-undefined-behavior, -faddress-sanitizer, and -fthread-sanitizer

2012-11-01 Thread Alexander Potapenko
I haven't seen the patch yet, but here are two thoughts: - some tools may be incompatible with each other (e.g. ASan and TSan), so we shouldn't allow to use them together; - there are many users of TSan and ASan, thus we can't easily rename the corresponding command line options. The right thing