r313717 - [Sema][ObjC] Warn about mismatches in attributes between overriding and

Author: ahatanak Date: Tue Sep 19 22:39:18 2017 New Revision: 313717 URL: http://llvm.org/viewvc/llvm-project?rev=313717=rev Log: [Sema][ObjC] Warn about mismatches in attributes between overriding and overridden methods when compiling for non-ARC. Previously, clang would error out when

[PATCH] D37914: [OpenMP] Don't throw cudalib not found error if only front-end is required.

gtbercea updated this revision to Diff 115948. Repository: rL LLVM https://reviews.llvm.org/D37914 Files: lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index: test/Driver/openmp-offload-gpu.c === ---

[PATCH] D38042: EmitAssemblyHelper: CodeGenOpts.DisableLLVMOpts should not overrule CodeGenOpts.VerifyModule.

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. Marking as needing changes to clear dashboard. https://reviews.llvm.org/D38042 ___ cfe-commits mailing list

[PATCH] D37954: Try to shorten system header paths when using -MD depfiles

Lekensteyn updated this revision to Diff 115946. Lekensteyn retitled this revision from "Expand absolute system header paths when using -MD depfiles" to "Try to shorten system header paths when using -MD depfiles". Lekensteyn edited the summary of this revision. Lekensteyn added a comment.

[PATCH] D38040: [OpenMP] Add an additional test for D34888

gtbercea updated this revision to Diff 115947. Repository: rL LLVM https://reviews.llvm.org/D38040 Files: test/OpenMP/target_map_codegen.cpp Index: test/OpenMP/target_map_codegen.cpp === --- test/OpenMP/target_map_codegen.cpp

[PATCH] D38046: [Atomic][X8664] set max atomic inline/promote width according to the target

wmi updated this revision to Diff 115945. wmi added a comment. Address Eli's comment. Repository: rL LLVM https://reviews.llvm.org/D38046 Files: include/clang/Basic/TargetInfo.h lib/Basic/Targets.cpp lib/Basic/Targets/X86.h test/OpenMP/atomic_capture_codegen.cpp

[PATCH] D37913: [OpenMP] Enable the existing nocudalib flag for OpenMP offloading toolchain.

gtbercea updated this revision to Diff 115943. gtbercea added a comment. Don't take into account unknown CUDA archs not even for testing purposes. Repository: rL LLVM https://reviews.llvm.org/D37913 Files: lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index:

[PATCH] D37912: [OpenMP] Bugfix: output file name drops the absolute path where full path is needed.

gtbercea updated this revision to Diff 115941. gtbercea added a comment. Address comment. Repository: rL LLVM https://reviews.llvm.org/D37912 Files: lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index: test/Driver/openmp-offload-gpu.c

[PATCH] D38063: [MSan] Disable sanitization for __sanitizer_dtor_callback.

eugenis added a comment. A test, please. Comment at: clang/lib/CodeGen/CGClass.cpp:1592 + llvm::CallInst *I = CGF.EmitNounwindRuntimeCall(Fn, Args); + I->setMetadata("nosanitize", llvm::MDNode::get(CGF.getLLVMContext(), +

[PATCH] D38060: Remove offset size check in nullptr arithmetic handling

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37914: [OpenMP] Don't throw cudalib not found error if only front-end is required.

hfinkel added inline comments. Comment at: test/Driver/openmp-offload-gpu.c:140 + +/// Check that error is not thrown by toolchain when no cuda lib device is found when using -c -S. +/// Check that the flag is passed when -fopenmp-relocatable-target is used. Do

[PATCH] D38063: [MSan] Disable sanitization for __sanitizer_dtor_callback.

morehouse created this revision. Herald added a subscriber: hiraditya. Eliminate unnecessary instrumentation at __sanitizer_dtor_callback call sites. Fixes https://github.com/google/sanitizers/issues/861. https://reviews.llvm.org/D38063 Files: clang/lib/CodeGen/CGClass.cpp

[PATCH] D38060: Remove offset size check in nullptr arithmetic handling

andrew.w.kaylor created this revision. This patch amends the changes that were committed from https://reviews.llvm.org/D37042 to remove the offset size check in the idiom identification routine. That check was behaving inconsistently (from target to target) because the offset was implicitly

[PATCH] D38042: EmitAssemblyHelper: CodeGenOpts.DisableLLVMOpts should not overrule CodeGenOpts.VerifyModule.

aprantl added a comment. In https://reviews.llvm.org/D38042#875734, @chandlerc wrote: > In https://reviews.llvm.org/D38042#875441, @aprantl wrote: > > > In https://reviews.llvm.org/D38042#875418, @chandlerc wrote: > > > > > Absolutely. I think the verifier should never, under any circumstances,

[PATCH] D37881: [Sema] Prevent InstantiateClass from checking unrelated exception specs.

vsapsai added a comment. Thanks for review. In https://reviews.llvm.org/D37881#875574, @rsmith wrote: > I think we need to clearly identify what state we're saving here and why. > It's the state that is pending from a class that we're currently in the > middle of parsing, so how about

[PATCH] D37856: [refactor] add support for refactoring options

ioeric added a comment. Sorry for the delay (most of us are OOO this week). Comment at: include/clang/Tooling/Refactoring/RefactoringActionRule.h:48 + + virtual void visitRefactoringOptions(RefactoringOptionConsumer ) = 0; }; Please document the behavior

[PATCH] D35235: [libc++] Replace __sync_* functions with __libcpp_atomic_* functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL313694: [libc++] Replace __sync_* functions with __libcpp_atomic_* functions (authored by weimingz). Changed prior to commit: https://reviews.llvm.org/D35235?vs=115918=115922#toc Repository: rL LLVM

[libcxx] r313694 - [libc++] Replace __sync_* functions with __libcpp_atomic_* functions

Author: weimingz Date: Tue Sep 19 16:18:03 2017 New Revision: 313694 URL: http://llvm.org/viewvc/llvm-project?rev=313694=rev Log: [libc++] Replace __sync_* functions with __libcpp_atomic_* functions Summary: This patch replaces __sync_* with __libcpp_atomic_* and adds a wrapper function for

[PATCH] D38059: Rename list::base to list::__base.

dlj created this revision. Herald added a subscriber: sanjoy. Even though the base typedef is private, it still participates in lookup. For example: void base() {} struct X : private std::list { X() { base(); } }; https://reviews.llvm.org/D38059 Files: include/list Index:

[PATCH] D35235: [libc++] Replace __sync_* functions with __libcpp_atomic_* functions

weimingz updated this revision to Diff 115918. weimingz added a comment. minor change https://reviews.llvm.org/D35235 Files: src/exception.cpp src/include/atomic_support.h src/include/refstring.h src/locale.cpp src/new.cpp src/support/runtime/exception_fallback.ipp

[PATCH] D38042: EmitAssemblyHelper: CodeGenOpts.DisableLLVMOpts should not overrule CodeGenOpts.VerifyModule.

chandlerc added a comment. In https://reviews.llvm.org/D38042#875441, @aprantl wrote: > In https://reviews.llvm.org/D38042#875418, @chandlerc wrote: > > > Absolutely. I think the verifier should never, under any circumstances, > > mutate the IR. Think about it, with the current design if a pass

[PATCH] D32520: Support __fp16 vectors

bruno added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1042 +} + +assert(SrcElementTy->isFloatingPointTy() && What happens if the SrcElementTy is float and DstElementTy isn't? Seems like it will hit the assertion below.

r313693 - Add override for ClangDiagnosticHandler::isAnyRemarkEnabled()

Author: anemet Date: Tue Sep 19 16:00:59 2017 New Revision: 313693 URL: http://llvm.org/viewvc/llvm-project?rev=313693=rev Log: Add override for ClangDiagnosticHandler::isAnyRemarkEnabled() This is used by the new closure-based variant of OptimizationRemarkEmitter::emit(). Modified:

[PATCH] D37954: Expand absolute system header paths when using -MD depfiles

thakis added a comment. I think for depfile generation, we generally try to be gcc-compatible (I can link to prior changes in this spirit), so I think this seems like a good thing to do to me. gcc only does this for system headers, yes? Does gcc support the non-negated spelling of this flag

[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

efriedma added a comment. I would rather not make ARM baremetal do something different from every other target... On Linux, for most targets, we don't add the uwtable attribute by default; without the uwtable attribute, non-ARM backends (e.g. aarch64) only emit tables for functions which

[PATCH] D35235: [libc++] Replace __sync_* functions with __libcpp_atomic_* functions

EricWF accepted this revision. EricWF added inline comments. Comment at: src/include/atomic_support.h:153 +_ValueType old; +old = *__target; +*__target = __value; Initialize `old` on the same line it's declared on. https://reviews.llvm.org/D35235

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

efriedma added a comment. I agree, it doesn't add much value. Either way, though, please make sure you address the buildbot failures quickly. Repository: rL LLVM https://reviews.llvm.org/D37042 ___ cfe-commits mailing list

[PATCH] D37629: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare

lebedev.ri reopened this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Reverted due to buildbot failures. Need to investigate. Repository: rL LLVM https://reviews.llvm.org/D37629 ___ cfe-commits mailing

r313684 - Fix 32-bit buildbots by removing tests that are dependent on pointer-size comparisons.

Author: akaylor Date: Tue Sep 19 14:43:01 2017 New Revision: 313684 URL: http://llvm.org/viewvc/llvm-project?rev=313684=rev Log: Fix 32-bit buildbots by removing tests that are dependent on pointer-size comparisons. The recently behavior in the code that these tests were meant to be checking

r313683 - Revert "[Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare"

Author: lebedevri Date: Tue Sep 19 14:40:41 2017 New Revision: 313683 URL: http://llvm.org/viewvc/llvm-project?rev=313683=rev Log: Revert "[Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare" This reverts commit r313677. Buildbots fail with assertion failure Failing Tests (7):

[PATCH] D36150: [clangd] LSP extension to switch between source/header file

Nebiroth added a comment. In https://reviews.llvm.org/D36150#867971, @ilya-biryukov wrote: > Overall looks good, but still needs at least a few tests. I have a test for this commit that uses included source and header files, would that be okay to do or should I generate files dynamically? If

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

andrew.w.kaylor added a comment. This is breaking buildbots for 32-bit targets because the offset in 'nullptr + int8_t_N' is being implicitly cast to an int. That makes the sizeof(offset) == sizeof(ptr) check turn out differently than my tests were assuming. I can get the buildbots green

[PATCH] D37629: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare

This revision was automatically updated to reflect the committed changes. Closed by commit rL313677: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare (authored by lebedevri). Changed prior to commit: https://reviews.llvm.org/D37629?vs=115890=115903#toc Repository: rL

Re: r312750 - [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

On Fri, Sep 8, 2017 at 7:10 PM, Roman Lebedev wrote: > On Fri, Sep 8, 2017 at 3:26 PM, Roman Lebedev wrote: >> On Fri, Sep 8, 2017 at 2:48 PM, Sam McCall wrote: >> Hi. >> >>> Nice fix! >> Thank you! >> >>> It catches a lot of new

r313677 - [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare

Author: lebedevri Date: Tue Sep 19 14:11:35 2017 New Revision: 313677 URL: http://llvm.org/viewvc/llvm-project?rev=313677=rev Log: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare Summary: As requested by Sam McCall: > Enums (not new I guess). Typical case: if (enum < 0 ||

[PATCH] D38049: [OpenMP] fix seg-faults printing diagnostics with invalid ordered(n) values

This revision was automatically updated to reflect the committed changes. Closed by commit rL313675: [OpenMP] fix seg-faults printing diagnostics with invalid ordered(n) values (authored by rcraik). Changed prior to commit: https://reviews.llvm.org/D38049?vs=115876=115901#toc Repository: rL

r313675 - [OpenMP] fix seg-faults printing diagnostics with invalid ordered(n) values

Author: rcraik Date: Tue Sep 19 14:04:23 2017 New Revision: 313675 URL: http://llvm.org/viewvc/llvm-project?rev=313675=rev Log: [OpenMP] fix seg-faults printing diagnostics with invalid ordered(n) values When the value specified for n in ordered(n) is larger than the number of loops a

[PATCH] D37629: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rL LLVM https://reviews.llvm.org/D37629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37881: [Sema] Prevent InstantiateClass from checking unrelated exception specs.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D37881#871556, @vsapsai wrote: > I don't like name `SavePendingDelayedStateRAII` as too vague. Hope you'll be > able to suggest something better or I'll have

[PATCH] D35235: [libc++] Replace __sync_* functions with __libcpp_atomic_* functions

weimingz updated this revision to Diff 115891. weimingz added a comment. Moved the inclusion from stdexcept.cpp into refstring.h For exception.cpp and new.cpp, I think it's better to keep the inclusion there. Those files include new_handler_fallback.ipp, exception_fallback.ipp, which need the

[PATCH] D37629: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare

lebedev.ri updated this revision to Diff 115890. lebedev.ri added a comment. Simplify `CheckTautologicalComparisonWithZero()` as per review notes. Less LOC. Repository: rL LLVM https://reviews.llvm.org/D37629 Files: include/clang/Basic/DiagnosticGroups.td

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

This revision was automatically updated to reflect the committed changes. Closed by commit rL313666: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc (authored by akaylor). Changed prior to commit: https://reviews.llvm.org/D37042?vs=115262=115889#toc Repository: rL LLVM

r313666 - Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

Author: akaylor Date: Tue Sep 19 13:26:40 2017 New Revision: 313666 URL: http://llvm.org/viewvc/llvm-project?rev=313666=rev Log: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc Differential Revision: https://reviews.llvm.org/D37042 Added:

[PATCH] D38049: [OpenMP] fix seg-faults printing diagnostics with invalid ordered(n) values

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D38049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37629: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare

aaron.ballman added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8605 - return Match; + const char *Cmp; // Simplified, pretty-printed comparison string + // Similar to E->getOpcodeStr(), but with extra 0 on either LHS or RHS I'd drop this comment

[PATCH] D37955: [libcxx] Fix invert negative bracket match.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. All the tests pass now (on Mac OS) Thanks! https://reviews.llvm.org/D37955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

Rakete updated this revision to Diff 115881. Rakete added a project: clang. Rakete added a comment. Used better diagnostic id. https://reviews.llvm.org/D36357 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseExprCXX.cpp

[PATCH] D38049: [OpenMP] fix seg-faults printing diagnostics with invalid ordered(n) values

rcraik created this revision. When the value specified for //n// in ordered(//n//) is larger than the number of loops a segmentation fault can occur in one of two ways when attempting to print out a diagnostic for an associated depend(sink : //vec//): 1. The iteration vector //vec// contains

[PATCH] D37544: [ubsan] Skip alignment checks which are folded away

vsk updated this revision to Diff 115879. vsk added a comment. - Use a better test case. This one was lifted from an actual example in X86CallingConv.h:86. https://reviews.llvm.org/D37544 Files: lib/CodeGen/CGExpr.cpp test/CodeGenCXX/ubsan-suppress-checks.cpp Index:

[PATCH] D38042: EmitAssemblyHelper: CodeGenOpts.DisableLLVMOpts should not overrule CodeGenOpts.VerifyModule.

aprantl added a comment. In https://reviews.llvm.org/D38042#875418, @chandlerc wrote: > In https://reviews.llvm.org/D38042#875412, @aprantl wrote: > > > In https://reviews.llvm.org/D38042#875334, @chandlerc wrote: > > > > > In https://reviews.llvm.org/D38042#875328, @aprantl wrote: > > > > > > >

[PATCH] D37466: D37461: fixups for existing InlineAsm tests + adding new ones

rnk added inline comments. Comment at: test/CodeGen/ms-inline-asm.cpp:37-38 - int lvar = 10; - __asm mov eax, offset Foo::ptr - __asm mov eax, offset Foo::Bar::ptr -// CHECK-LABEL: define void @_Z2t2v() These don't seem tested anywhere now Repository: rL

[PATCH] D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rL LLVM https://reviews.llvm.org/D37413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37629: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare

lebedev.ri updated this revision to Diff 115877. lebedev.ri added a comment. 1. Correctly added `TautologicalUnsignedEnumZeroCompare` to `TautologicalCompare` group (sigh) 2. Hopefully fixed spelling of the comments and added a bit better comments 3. Fixed variable names to comply with the

[PATCH] D37903: Fix assume-filename handling in clang-format.el

werbitt updated this revision to Diff 115875. werbitt edited the summary of this revision. werbitt added a comment. Rename assume-file to assume-file-name and update documentation https://reviews.llvm.org/D37903 Files: tools/clang-format/clang-format.el Index:

[PATCH] D38042: EmitAssemblyHelper: CodeGenOpts.DisableLLVMOpts should not overrule CodeGenOpts.VerifyModule.

aprantl added a comment. In https://reviews.llvm.org/D38042#875412, @aprantl wrote: > In https://reviews.llvm.org/D38042#875334, @chandlerc wrote: > > > In https://reviews.llvm.org/D38042#875328, @aprantl wrote: > > > > > In https://reviews.llvm.org/D38042#875303, @chandlerc wrote: > > > > > > >

[PATCH] D38048: [clangd] Add textDocument/signatureHelp

rwols created this revision. Makes clangd respond to a client's "textDocument/signatureHelp" request by presenting function/method overloads. Still need to add tests. Also, there is duplicate code in clangd::codeComplete and clangd::signatureHelp now, maybe refactor this to a common function?

[PATCH] D38042: EmitAssemblyHelper: CodeGenOpts.DisableLLVMOpts should not overrule CodeGenOpts.VerifyModule.

chandlerc added a comment. In https://reviews.llvm.org/D38042#875412, @aprantl wrote: > In https://reviews.llvm.org/D38042#875334, @chandlerc wrote: > > > In https://reviews.llvm.org/D38042#875328, @aprantl wrote: > > > > > In https://reviews.llvm.org/D38042#875303, @chandlerc wrote: > > > > > >

[PATCH] D38042: EmitAssemblyHelper: CodeGenOpts.DisableLLVMOpts should not overrule CodeGenOpts.VerifyModule.

aprantl added a comment. In https://reviews.llvm.org/D38042#875334, @chandlerc wrote: > In https://reviews.llvm.org/D38042#875328, @aprantl wrote: > > > In https://reviews.llvm.org/D38042#875303, @chandlerc wrote: > > > > > But, the verifier itself will just "crash". It won't print a stack

[PATCH] D37629: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare

aaron.ballman added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8593 - bool Match = true; + // is this a tautological comparison? if yes, than contains the always-result + llvm::Optional Result; Comments should be complete sentences with

[PATCH] D37897: [StaticAnalyzer] Fix ProgramState for static variables that are not written

NoQ added a comment. The overall idea makes sense to me. I'd like you to join the effort with Peter who during his work on loop widening came up with a matcher-based procedure for finding out if a variable is changed anywhere; it currently lives in `LoopUnrolling.cpp` and we need only once

r313653 - Fix ClangDiagnosticHandler::is*RemarkEnabled members

Author: anemet Date: Tue Sep 19 10:59:40 2017 New Revision: 313653 URL: http://llvm.org/viewvc/llvm-project?rev=313653=rev Log: Fix ClangDiagnosticHandler::is*RemarkEnabled members Apparently these weren't really working. I added test coverage and fixed the typo in the name and the parameter.

[PATCH] D38042: EmitAssemblyHelper: CodeGenOpts.DisableLLVMOpts should not overrule CodeGenOpts.VerifyModule.

chandlerc added a comment. In https://reviews.llvm.org/D38042#875328, @aprantl wrote: > In https://reviews.llvm.org/D38042#875303, @chandlerc wrote: > > > But, the verifier itself will just "crash". It won't print a stack trace, > > but I don't see why that's much better? And this flag is

[PATCH] D38042: EmitAssemblyHelper: CodeGenOpts.DisableLLVMOpts should not overrule CodeGenOpts.VerifyModule.

aprantl added a comment. In https://reviews.llvm.org/D38042#875303, @chandlerc wrote: > But, the verifier itself will just "crash". It won't print a stack trace, but > I don't see why that's much better? And this flag is supposed to be a > developer option and not a user facing one, so I'm

[PATCH] D38040: [OpenMP] Add an additional test for D34888

tra added a comment. LGTM in general. Comment at: test/OpenMP/target_map_codegen.cpp:4845 +///==/// +// RUN: %clang_cc1 -DCK30 -std=c++11 -fopenmp -S -emit-llvm -fopenmp

[PATCH] D37629: [Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare

lebedev.ri added a comment. Ping, would be really nice to get this going :) Would unblock me for working on the second half of the fix for https://bugs.llvm.org/show_bug.cgi?id=34147 Repository: rL LLVM https://reviews.llvm.org/D37629 ___

[PATCH] D38042: EmitAssemblyHelper: CodeGenOpts.DisableLLVMOpts should not overrule CodeGenOpts.VerifyModule.

chandlerc added a comment. But, the verifier itself will just "crash". It won't print a stack trace, but I don't see why that's much better? And this flag is supposed to be a developer option and not a user facing one, so I'm somewhat confused at what the intent is here...

[PATCH] D37912: [OpenMP] Bugfix: output file name drops the absolute path where full path is needed.

tra added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:441 -SmallString<256> Name = llvm::sys::path::filename(II.getFilename()); +SmallString<256> Name = StringRef(II.getFilename()); llvm::sys::path::replace_extension(Name, "cubin");

[PATCH] D36915: [Sema] Diagnose local variables and parameters captured by lambda and block expressions in a default argument

ahatanak added a comment. ping https://reviews.llvm.org/D36915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r313643 - Resubmit "Fix llvm-lit script generation in libcxx."

Author: zturner Date: Tue Sep 19 10:19:10 2017 New Revision: 313643 URL: http://llvm.org/viewvc/llvm-project?rev=313643=rev Log: Resubmit "Fix llvm-lit script generation in libcxx." After speaking with the libcxx owners, they agreed that this is a bug in the bot that needs to be fixed by the bot

[PATCH] D37913: [OpenMP] Enable the existing nocudalib flag for OpenMP offloading toolchain.

tra added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:255-257 CudaArch gpu_arch = StringToCudaArch(GPUArchName); - assert(gpu_arch != CudaArch::UNKNOWN && + assert((gpu_arch != CudaArch::UNKNOWN || + Args.hasArg(options::OPT_nocudalib)) &&

[PATCH] D38042: EmitAssemblyHelper: CodeGenOpts.DisableLLVMOpts should not overrule CodeGenOpts.VerifyModule.

aprantl created this revision. This patch fixes a regression introduced by r290392 (https://reviews.llvm.org/D28047 — Make '-disable-llvm-optzns' an alias for '-disable-llvm-passes'.) After r290392, CodeGenOpts.DisableLLVMOpts implicitly disables CodeGenOpts.VerifyModule, because the Verifier

[PATCH] D37955: [libcxx] Fix invert negative bracket match.

timshen updated this revision to Diff 115851. timshen added a comment. Fixed. Those tests were XFAILing on linux-gnu. I also created https://reviews.llvm.org/D38041 to XFAIL only on the failing ones. https://reviews.llvm.org/D37955 Files: libcxx/include/regex

[PATCH] D38041: [libc++] Separate locale tests that are XFAIL on linux-gnu from others

timshen created this revision. Herald added a subscriber: sanjoy. Herald added a reviewer: EricWF. The tests don't pass on linux-gnu. Move them out, so that the others don't have to be XFAIL. https://reviews.llvm.org/D38041 Files: libcxx/test/std/re/re.alg/re.alg.match/basic.pass.cpp

[PATCH] D37925: Allow specifying sanitizers in blacklists

vlad.tsyrklevich marked an inline comment as done. vlad.tsyrklevich added inline comments. Comment at: docs/SanitizerSpecialCaseList.rst:57 + +Sections are regular expressions written in square brackets that denote which +sanitizer the following entries apply to. For example,

[PATCH] D37804: [OpenCL] Handle address space conversion while setting type alignment

Anastasia added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:957 -return Builder.CreateBitCast(Addr, ConvertType(E->getType())); +return Builder.CreatePointerBitCastOrAddrSpaceCast( +Addr, ConvertType(E->getType()));

[PATCH] D37925: Allow specifying sanitizers in blacklists

vlad.tsyrklevich updated this revision to Diff 115849. vlad.tsyrklevich added a comment. - Refactor to make compile() not virtual again - Refactor a confusing use of ASanMask into individual uses of SanitizerKind::{Address,KernelAddress} - 'Sections' -> 'Section names'

[PATCH] D36101: Fix usage of right shift operator in fold expressions

Rakete updated this revision to Diff 115846. Rakete added a comment. Used the correct return type, even if it doesn't really matter to the compiler. https://reviews.llvm.org/D36101 Files: lib/Parse/ParseExpr.cpp test/Parser/cxx1z-fold-expressions.cpp Index:

[PATCH] D38040: [OpenMP] Add an additional test for D34888

gtbercea created this revision. Test for checking if the mapping is performed correctly. This is a test initially included in Patch https://reviews.llvm.org/D29905 Repository: rL LLVM https://reviews.llvm.org/D38040 Files: test/OpenMP/target_map_codegen.cpp Index:

[PATCH] D35743: [clang-format] Adjust space around &/&& of structured bindings

klimek added a comment. Ok, we still need to fix structured bindings in the UnwrappedLineParser. Unfortunately isCppStructuredBinding requires a "previous token" function, which we don't really have in the UnwrappedLineParser. /me goes thinking more about that part of the problem. That should

[PATCH] D36101: Fix usage of right shift operator in fold expressions

Rakete updated this revision to Diff 115842. Rakete added a project: clang. Rakete added a comment. Added the tests to the existing test file for fold operators that I didn't notice before :) https://reviews.llvm.org/D36101 Files: lib/Parse/ParseExpr.cpp

[PATCH] D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true.

curdeius added a comment. I confirm what I observed before: when invoking tests in `unittests/Format/NamespaceEndCommentsFixerTest.cpp`, the `const AnnotatedLine *line` parameter in `getNamespaceToken` gets one big line that includes both `namespace` and `{` (something like

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

Alexander-Shukaev added a comment. Mark, just wanted to check if the review is still somewhere on your radar. Repository: rL LLVM https://reviews.llvm.org/D15465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc added a comment. Hey @jyknight I heard from @erichkeane that you may want a couple more changes to this patch. Please let me know if you have some changes to recommend. @joerg thought this was OK for submission. Thanks --Melanie https://reviews.llvm.org/D34158

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

zibi added a comment. Please be aware that I don't have the commit permission yet since this is my first patch. I will rely on somebody to push it to the trunk. https://reviews.llvm.org/D37861 ___ cfe-commits mailing list

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

zibi updated this revision to Diff 115838. zibi added a comment. original + review changes https://reviews.llvm.org/D37861 Files: include/clang/Lex/PPCallbacks.h lib/Frontend/PrintPreprocessedOutput.cpp lib/Lex/Pragma.cpp test/Preprocessor/pragma_assume_nonnull.c Index:

[PATCH] D37980: [clang-format] Better parsing of lambda captures with initializer expressions.

curdeius abandoned this revision. curdeius added a comment. Ok. Nice patch. You can close https://bugs.llvm.org/show_bug.cgi?id=19986 now. https://reviews.llvm.org/D37980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37955: [libcxx] Fix invert negative bracket match.

mclow.lists requested changes to this revision. mclow.lists added a comment. This revision now requires changes to proceed. When I applied this patch locally, some of the other tests started failing. Specifically: Assertion failed: (!std::regex_match(s, m, std::regex("^[a-f]$",

[PATCH] D37903: Fix assume-filename handling in clang-format.el

phst accepted this revision. phst added a comment. This revision is now accepted and ready to land. Your use case sounds good to me. Please be sure to document the new parameter, though. Comment at: tools/clang-format/clang-format.el:154 +

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

klimek added a comment. I find the current semantics of the functions a bit surprising, specifically: ... reflowProtrudingToken(..., bool Reflow) is really confusing me :) I'd have expected something like this where we currently call breakProtrudingToken(): if (CanBreak) { ReflowPenalty

[PATCH] D37903: Fix assume-filename handling in clang-format.el

phst added inline comments. Comment at: tools/clang-format/clang-format.el:125 If called interactively uses the region or the current statement if there is no active region. If no style is given uses `clang-format-style'." (interactive Please document the

r313628 - [Sema] Disallow assigning record lvalues with nested const-qualified fields.

Author: bjope Date: Tue Sep 19 06:10:30 2017 New Revision: 313628 URL: http://llvm.org/viewvc/llvm-project?rev=313628=rev Log: [Sema] Disallow assigning record lvalues with nested const-qualified fields. Summary: According to C99 6.3.2.1p1, structs and unions with nested const-qualified fields

[PATCH] D37254: [Sema] Disallow assigning record lvalues with nested const-qualified fields.

This revision was automatically updated to reflect the committed changes. Closed by commit rL313628: [Sema] Disallow assigning record lvalues with nested const-qualified fields. (authored by bjope). Changed prior to commit: https://reviews.llvm.org/D37254?vs=114340=115831#toc Repository: rL

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Typz updated this revision to Diff 115830. Typz added a comment. Remove `Reflow` from LineState, and perform the decision again during reconstruction phase. https://reviews.llvm.org/D33589 Files: lib/Format/ContinuationIndenter.cpp lib/Format/ContinuationIndenter.h

[PATCH] D37972: [clangd] Introduced Logger interface.

malaperle accepted this revision. malaperle added a comment. This revision is now accepted and ready to land. Look good. Thank you! https://reviews.llvm.org/D37972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Typz added a comment. > I am still trying to get to the bottom of this assertion, any hint where to > look for? OK, got it. The issue is that we will actually need to run the wrapping 3 times when DryRun = false : call reflowProtrudingToken() twice with DryRun=true to find out the better

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Typz added a comment. In https://reviews.llvm.org/D33589#875039, @djasper wrote: > I think doing the computation twice is fine. Or at least, I'd need a test > case where it actually shows substantial overhead before doing what you are > doing here. Understand that creating more States and

[PATCH] D37903: Fix assume-filename handling in clang-format.el

werbitt added a comment. Hi, Thank you very much for your feedback. I submitted a bug here: https://bugs.llvm.org/show_bug.cgi?id=34667 I made the changes you suggested, but I left the assume-filename optional argument for now. My current use-case is that when I'm editing a source block in

[PATCH] D37903: Fix assume-filename handling in clang-format.el

werbitt updated this revision to Diff 115827. werbitt added a comment. Clean up call-process-region - Quote call-process-region with #', this will cause a compile time error if call-process-region is undefined - Pass positional arguments normally (exclude from the list) - Instead of using

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

djasper added a comment. I think doing the computation twice is fine. Or at least, I'd need a test case where it actually shows substantial overhead before doing what you are doing here. Understand that creating more States and making the State object itself larger also has cost and that cost

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Typz added a comment. For one thing, we need to update the state to store the "decision" of the reflowing mode, which is performed only in DryRun=true mode, to avoid doing the computation multiple times. Apart from this, the decision is conceptually internal to breakProtrudingToken(). But the

  1   2   >