[PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

george.karpenkov added subscribers: dcoughlin, bogner, NoQ, vlad.tsyrklevich. george.karpenkov added a comment. Yes, investigating. Will rollback if not fixed in a few hours. Repository: rC Clang https://reviews.llvm.org/D50594 ___ cfe-commits

[PATCH] D50571: [clangd] add an extension field to LSP to transfer the diagnostic's category

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Let's watch out for possible breakages in any of the clients, though. I've checked VSCode and it seems to be fine with the added fields. Repository: rCTE Clang Tools

[PATCH] D50691: [CMake] Fix the LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY option

This revision was automatically updated to reflect the committed changes. Closed by commit rL339697: [CMake] Fix the LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY option (authored by mstorsjo, committed by ). Herald added subscribers: llvm-commits, christof. Changed prior to commit:

Re: [PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

Yes, investigating. Will rollback if not fixed in a few hours. > On Aug 14, 2018, at 3:17 AM, Yvan Roux via Phabricator > wrote: > > yroux added a comment. > > Notice that the affected bots run two times the test cases where one > execution passes and one fails, as you can see in (search >

[PATCH] D21767: Fix instantiation of friend function templates

sepavloff added a comment. In https://reviews.llvm.org/D21767#1197783, @rjmccall wrote: > Shouldn't there just be a link in the AST from the instantiated > `FunctionTemplateDecl ` back to the original pattern? Maybe a generalization > of `InstantiatedFromMember` in

[PATCH] D50564: Add support for SEH unwinding on Windows.

cdavis5x added a comment. In https://reviews.llvm.org/D50564#1195985, @cdavis5x wrote: > In https://reviews.llvm.org/D50564#1195794, @mstorsjo wrote: > > > > Special thanks to KJK::Hyperion for his excellent series of articles on > > > how EH works on x86-64 Windows. (Seriously, check it out.

[PATCH] D50564: Add support for SEH unwinding on Windows.

mstorsjo added a comment. In https://reviews.llvm.org/D50564#1199285, @rnk wrote: > In https://reviews.llvm.org/D50564#1198996, @cdavis5x wrote: > > > Could somebody verify that the `DISPATCHER_CONTEXT` struct is defined in > > `` for the Win8 and Win10 SDKs? I can't install them right now. > >

[PATCH] D50724: SafeStack: Disable Darwin support

vlad.tsyrklevich added a comment. In https://reviews.llvm.org/D50724#1199345, @kubamracek wrote: > Doesn't this need any tests to be updated? Otherwise, LGTM. There were no Darwin-specific safestack driver tests. I ran check-clang just to make sure and it passes. Repository: rC Clang

RE: r339693 - We have in place support for parsing #pragma FENV_ACCESS, but that

It's a very small incremental change and I'm not sure it can be tested at this granularity. I see we have tests for FP_CONTRACT in tools/clang/tests/CodeGen/fp-contract* but I don't know how to run them. If you can tell me how to run them I can start on making FENV_ACCESS versions of them and

[PATCH] D50724: SafeStack: Disable Darwin support

kubamracek added a comment. Doesn't this need any tests to be updated? Otherwise, LGTM. Repository: rC Clang https://reviews.llvm.org/D50724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50724: SafeStack: Disable Darwin support

vlad.tsyrklevich created this revision. vlad.tsyrklevich added reviewers: pcc, kubamracek. Herald added a subscriber: cfe-commits. Darwin support does not appear to be used as evidenced by the fact that the runtime has never supported non-trivial programs. Repository: rC Clang

[PATCH] D50564: Add support for SEH unwinding on Windows.

zturner added a comment. In https://reviews.llvm.org/D50564#1199285, @rnk wrote: > In https://reviews.llvm.org/D50564#1198996, @cdavis5x wrote: > > > Could somebody verify that the `DISPATCHER_CONTEXT` struct is defined in > > `` for the Win8 and Win10 SDKs? I can't install them right now. > >

Re: r339693 - We have in place support for parsing #pragma FENV_ACCESS, but that

No test? On Tue, Aug 14, 2018 at 8:06 PM, Kevin P. Neal via cfe-commits wrote: > Author: kpn > Date: Tue Aug 14 10:06:56 2018 > New Revision: 339693 > > URL: http://llvm.org/viewvc/llvm-project?rev=339693=rev > Log: > > We have in place support for parsing #pragma FENV_ACCESS, but that >

[PATCH] D49865: Inform the AST of #pragma FENV_ACCESS use

This revision was automatically updated to reflect the committed changes. Closed by commit rL339693 (authored by kpn, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49865?vs=158351=160626#toc Repository: rL LLVM

r339693 - We have in place support for parsing #pragma FENV_ACCESS, but that

Author: kpn Date: Tue Aug 14 10:06:56 2018 New Revision: 339693 URL: http://llvm.org/viewvc/llvm-project?rev=339693=rev Log: We have in place support for parsing #pragma FENV_ACCESS, but that information is then discarded with a warning to the user that we don't support it. This patch gets us

[PATCH] D50564: Add support for SEH unwinding on Windows.

rnk added a comment. In https://reviews.llvm.org/D50564#1198996, @cdavis5x wrote: > Could somebody verify that the `DISPATCHER_CONTEXT` struct is defined in > `` for the Win8 and Win10 SDKs? I can't install them right now. I checked both, and they are available, so I think we should guard the

r339691 - Revert test commit

Author: kpn Date: Tue Aug 14 09:57:10 2018 New Revision: 339691 URL: http://llvm.org/viewvc/llvm-project?rev=339691=rev Log: Revert test commit Modified: cfe/trunk/lib/Parse/ParseAST.cpp Modified: cfe/trunk/lib/Parse/ParseAST.cpp URL:

r339690 - Test commit

Author: kpn Date: Tue Aug 14 09:56:25 2018 New Revision: 339690 URL: http://llvm.org/viewvc/llvm-project?rev=339690=rev Log: Test commit Modified: cfe/trunk/lib/Parse/ParseAST.cpp Modified: cfe/trunk/lib/Parse/ParseAST.cpp URL:

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

owenpan updated this revision to Diff 160622. owenpan added a comment. Simplified the test case. Repository: rC Clang https://reviews.llvm.org/D50699 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

ldionne added a comment. The goal of this commit is to fix build bot failures here: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv7-linux-noexceptions/builds/286/steps/test.libcxx/logs/stdio. This failure was introduced when I fixed some unit tests that were no-ops in

[PATCH] D50526: Model type attributes as regular Attrs

rnk added a comment. The issue was related to ignored calling convention attributes on Win64: int a(int, const int *, int, int, __int64); class b { public: typedef int c; }; template void AtlAxDialogCreateT(int, d, int, int, __int64); int g, i, j, k; char *h; void l() {

[PATCH] D50719: [libc++] Fix incorrect definition of TEST_HAS_C11_FEATURES

ldionne created this revision. ldionne added a reviewer: mclow.lists. Herald added a reviewer: EricWF. Herald added subscribers: cfe-commits, dexonsmith, christof. The macro was not defined in C++11 mode when it should have been, at least according to how _LIBCPP_HAS_C11_FEATURES is defined.

[PATCH] D50672: [ASTImporter] Change the return result of Decl import to Optional

martong added a comment. Roughly, this is the direction where we are heading with `Expected`: https://github.com/Ericsson/clang/pull/457/commits/783b7f5cce9de589a5c3c3ae983398cf499077ec (If you are interested, here is our whole thought process: https://github.com/Ericsson/clang/pull/457)

[PATCH] D49244: Always search sysroot for GCC installs

greened added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D49244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50715: [AST] Store the OwnedTagDecl as a trailing object in ElaboratedType.

riccibruno created this revision. riccibruno added reviewers: rsmith, rjmccall, erichkeane. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. The `TagDecl *OwnedTagDecl` in `ElaboratedType` is quite commonly null (at least when parsing all of Boost, it is non-null for

[PATCH] D50713: [AST] Pack the unsigned of SubstTemplateTypeParmPackType into Type

erichkeane added inline comments. Comment at: include/clang/AST/Type.h:1634 + +/// The number of template arguments in \c Arguments. +/// Intentionally not a bitfield since we have plenty of space left. I would love it if we commented what a reasonable

[clang-tools-extra] r339687 - NFC: Enforce good formatting across multiple clang-tools-extra files

Author: omtcyfz Date: Tue Aug 14 09:03:32 2018 New Revision: 339687 URL: http://llvm.org/viewvc/llvm-project?rev=339687=rev Log: NFC: Enforce good formatting across multiple clang-tools-extra files This patch improves readability of multiple files in clang-tools-extra and enforces LLVM Coding

[PATCH] D50707: NFC: Enforce good formatting across multiple clang-tools-extra files

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE339687: NFC: Enforce good formatting across multiple clang-tools-extra files (authored by omtcyfz, committed by ). Changed prior to commit: https://reviews.llvm.org/D50707?vs=160605=160607#toc

[PATCH] D50707: NFC: Enforce good formatting across multiple clang-tools-extra files

kbobyrev updated this revision to Diff 160605. kbobyrev added a comment. I have updated the patch so that it only affects comments, header guards and inserts few newlines. Actual source code is not affected so that `git blame` log could be less cryptic. https://reviews.llvm.org/D50707 Files:

[PATCH] D50713: [AST] Pack the unsigned of SubstTemplateTypeParmPackType into Type

riccibruno created this revision. riccibruno added reviewers: rsmith, rjmccall, erichkeane. riccibruno added a project: clang. Herald added a reviewer: javed.absar. Herald added subscribers: cfe-commits, chrib, kristof.beyls. The bit-fields of `Type` have enough space for the member `unsigned

[PATCH] D50246: [RISCV] Add support for computing sysroot for riscv32-unknown-elf

lewis-revill updated this revision to Diff 160602. lewis-revill added a comment. Fixed this issue by adding -nostdsysteminc to the Clang target options, preventing the frontend from generating additional include paths. Repository: rC Clang https://reviews.llvm.org/D50246 Files:

[PATCH] D50712: [AST] Pack the unsigned of DependentTemplateSpecializationType into Type

riccibruno created this revision. riccibruno added reviewers: rsmith, rjmccall, erichkeane. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. The bit-fields of `Type` have enough space for the member `unsigned NumArgs` of DependentTemplateSpecializationType Repository:

[PATCH] D50711: [AST] Pack the unsigned of PackExpansionType into Type

riccibruno created this revision. riccibruno added reviewers: rsmith, rjmccall, erichkeane. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. The bit-fields of Type have enough space for the `unsigned NumExpansions` of PackExpansionType Repository: rC Clang

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth added inline comments. Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191 +void templated_thrower() { throw T{}(); } +// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an exception whose type 'int' is not derived from 'std::exception' +

[PATCH] D50709: [clang-doc] Fix unused var

This revision was automatically updated to reflect the committed changes. Closed by commit rL339685: [clang-doc] Fix unused variable (authored by juliehockett, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50709?vs=160593=160600#toc

[clang-tools-extra] r339685 - [clang-doc] Fix unused variable

Author: juliehockett Date: Tue Aug 14 08:38:59 2018 New Revision: 339685 URL: http://llvm.org/viewvc/llvm-project?rev=339685=rev Log: [clang-doc] Fix unused variable Differential Revision: https://reviews.llvm.org/D50709 Modified: clang-tools-extra/trunk/clang-doc/Mapper.cpp Modified:

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

gtbercea updated this revision to Diff 160598. gtbercea added a comment. Herald added a subscriber: jholewinski. Add __NO_MATH_INLINES macro for the NVPTX toolchain to prevent any host assembly from seeping onto the device. Repository: rC Clang https://reviews.llvm.org/D47849 Files:

[PATCH] D50709: [clang-doc] Fix unused var

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Looks like NFC. https://reviews.llvm.org/D50709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50403: [clang-format]AlignConsecutiveAssignments

PDoakORNL added a comment. So it's been a week, is there an owner for clang/lib/Format? Repository: rC Clang https://reviews.llvm.org/D50403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50709: [clang-doc] Fix unused var

juliehockett created this revision. juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri. juliehockett added a project: clang-tools-extra. https://reviews.llvm.org/D50709 Files: clang-tools-extra/clang-doc/Mapper.cpp Index: clang-tools-extra/clang-doc/Mapper.cpp

[PATCH] D50691: [CMake] Fix the LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY option

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rCXX libc++ https://reviews.llvm.org/D50691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50641: [clangd][test] Fix exit messages in tests

ilya-biryukov added a comment. Haven't noticed Alex's comments, sorry for a duplicate suggestion about exiting with failure error code Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50641 ___ cfe-commits mailing list

[PATCH] D50641: [clangd][test] Fix exit messages in tests

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Many thanks for fixing this. Adding some failure monitoring seems like a nice idea. On the other hand, polluting every test with stderr redirection doesn't look like a

[PATCH] D50697: [clang-format] fix PR38557 - comments between "default" and ':' causes the case label to be treated as an identifier

owenpan updated this revision to Diff 160591. owenpan added a comment. Updated the test case. Repository: rC Clang https://reviews.llvm.org/D50697 Files: lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D50707: NFC: Enforce good formatting across multiple clang-tools-extra files

ioeric added a comment. Fixing header guards and file comments is fine, but I'm not a fan of reformatting-only changes in source code as they tends to make `git blame` harder. https://reviews.llvm.org/D50707 ___ cfe-commits mailing list

[PATCH] D50564: Add support for SEH unwinding on Windows.

cdavis5x added a comment. Could somebody verify that the `DISPATCHER_CONTEXT` struct is defined in `` for the Win8 and Win10 SDKs? I can't install them right now. Repository: rUNW libunwind https://reviews.llvm.org/D50564 ___ cfe-commits

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

deannagarcia added inline comments. Comment at: test/clang-tidy/abseil-duration-division.cpp:58 + // CHECK-MESSAGES: [[@LINE-4]]:45: warning: operator/ on absl::Duration objects + // CHECK-FIXES: double DoubleDivision(T t1, T t2) {return + // absl::FDivDuration(t1, t2);}

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

deannagarcia updated this revision to Diff 160582. https://reviews.llvm.org/D50389 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/DurationDivisionCheck.cpp clang-tidy/abseil/DurationDivisionCheck.h docs/ReleaseNotes.rst

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

gtbercea added a comment. Thanks @Hahnfeld for your suggestions. Unfortunately doing the lowering in the backend one would need to replace the math function calls with calls to libdevice function calls. I have not been able to do that in an elegant way. Encoding the interface to libdevice is

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

owenpan updated this revision to Diff 160577. owenpan added a comment. Added a test case. Repository: rC Clang https://reviews.llvm.org/D50699 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D50337: [clangd] DexIndex implementation prototype

kbobyrev updated this revision to Diff 160576. kbobyrev added a comment. Don't separate the logic for "long" and "short" queries: https://reviews.llvm.org/D50517 (https://reviews.llvm.org/rCTE339548) introduced incomplete trigrams which can be used on for "short" queries, too.

[PATCH] D50652: [libcxx] By default, do not use internal_linkage to hide symbols from the ABI

ldionne added a comment. In https://reviews.llvm.org/D50652#1198893, @ldionne wrote: > In https://reviews.llvm.org/D50652#1198885, @hans wrote: > > > Oh, or could we do > > > > -D_LIBCPP_HIDE_FROM_ABI= > > > > > > and just get regular odr linkage for these functions? > > > No, you do need to

r339678 - [OpenCL] Add test for constant sampler argument

Author: svenvh Date: Tue Aug 14 06:56:52 2018 New Revision: 339678 URL: http://llvm.org/viewvc/llvm-project?rev=339678=rev Log: [OpenCL] Add test for constant sampler argument Modified: cfe/trunk/test/SemaOpenCL/sampler_t.cl Modified: cfe/trunk/test/SemaOpenCL/sampler_t.cl URL:

[PATCH] D50652: [libcxx] By default, do not use internal_linkage to hide symbols from the ABI

ldionne added a comment. In https://reviews.llvm.org/D50652#1198885, @hans wrote: > Oh, or could we do > > -D_LIBCPP_HIDE_FROM_ABI= > > > and just get regular odr linkage for these functions? No, you do need to use `_LIBCPP_HIDDEN _LIBCPP_ALWAYS_INLINE` because of the issue described in

[PATCH] D50652: [libcxx] By default, do not use internal_linkage to hide symbols from the ABI

hans added a comment. If we think the symbol/string table size increase is acceptable for most user's, I suppose Chromium could just do -D_LIBCPP_HIDE_FROM_ABI=_LIBCPP_ALWAYS_INLINE to get back the old behaviour and unblock us? And this could also be suggested in the release notes as a

[PATCH] D50703: [clangd] NFC: Mark Workspace Symbol feature complete in the documentation

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: arphaman, jkorous, MaskRay. Workspace Symbol implementation was introduced in https://reviews.llvm.org/D44882 and should be complete now.

[PATCH] D50674: [libc++] Add missing #include in C11 features tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL339675: [libc++] Add missing #include in C11 features tests (authored by ldionne, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[libcxx] r339675 - [libc++] Add missing #include in C11 features tests

Author: ldionne Date: Tue Aug 14 06:29:17 2018 New Revision: 339675 URL: http://llvm.org/viewvc/llvm-project?rev=339675=rev Log: [libc++] Add missing #include in C11 features tests Summary: These #includes are quite important, since otherwise any #if TEST_STD_VER > 14 &&

[PATCH] D50341: [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions

ldionne added a comment. In https://reviews.llvm.org/D50341#1198339, @vsapsai wrote: > What about defining a feature for unsupported configurations? I've tried > > if '__cpp_aligned_new' not in macros or \ > intMacroValue(macros['__cpp_aligned_new']) < 201606: >

[PATCH] D50652: [libcxx] By default, do not use internal_linkage to hide symbols from the ABI

hans added a comment. In https://reviews.llvm.org/D50652#1197775, @rnk wrote: > I'd prefer not to do this, since internal_linkage generates smaller, more > debuggable code by default. IIUC, this is what we had before though, so it's a conservative "revert to safety" approach until a better

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

owenpan updated this revision to Diff 160564. owenpan added a comment. Updated the patch to include lib/Format path prefix. Repository: rC Clang https://reviews.llvm.org/D50699 Files: lib/Format/ContinuationIndenter.cpp Index: lib/Format/ContinuationIndenter.cpp

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 160562. hugoeg marked an inline comment as done. https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDepsCheck.cpp clang-tidy/abseil/NoInternalDepsCheck.h

[PATCH] D50674: [libc++] Add missing #include in C11 features tests

hiraditya accepted this revision. hiraditya added a comment. This revision is now accepted and ready to land. Good catch! Repository: rCXX libc++ https://reviews.llvm.org/D50674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

JonasToth added a comment. In https://reviews.llvm.org/D50699#1198813, @owenpan wrote: > Updated patch created by "svn diff --diff-cmd=diff -x -U99" The patch seems not to be in the correct path (the `lib/Format` thing is missing). Could you check that again? If you plan to add more

[PATCH] D50672: [ASTImporter] Change the return result of Decl import to Optional

martong added a comment. > Do you think we can hold back this patch for a few days until Balazs prepares > the Expected based version? Then I think we could compare the patches and > we could merge the best from the two of them. I mean, once Balazs is also ready, then we can create a combined

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

owenpan updated this revision to Diff 160561. owenpan added a comment. Updated patch created by "svn diff --diff-cmd=diff -x -U99" Repository: rC Clang https://reviews.llvm.org/D50699 Files: ContinuationIndenter.cpp Index: ContinuationIndenter.cpp

[PATCH] D50672: [ASTImporter] Change the return result of Decl import to Optional

martong added a comment. Hi Aleksei, Thank you for this patch. With Balazs, we are working on something similar, but with a different, fine grained error value mechanism. Unfortunately we were not aware of that you have been working on error handling, and we didn't say that we are working on

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

hiraditya added a comment. In https://reviews.llvm.org/D50699#1198770, @owenpan wrote: > Test case: > F6937162: BreakBeforeBinaryOperators.cpp Please add a testcase in the source and add checks to verify the changes. Repository: rC Clang

[PATCH] D50699: Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

JonasToth added a comment. Please create the diffs with full context (git diff -U 999) and add an test-case. Repository: rC Clang https://reviews.llvm.org/D50699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: Fwd: patch file for bug 38557

Hi Jonas, Thank you very much! I just created a phabricator account and created a revision for another bug (https://reviews.llvm.org/D50699). I don't know exactly how to add my test case like you did for me, so I just uploaded it. I also added the reviewers listed by bugs.llvm.org. How do I

[PATCH] D50702: [clangd] NFC: Cleanup clangd help message

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE339673: [clangd] NFC: Cleanup clangd help message (authored by omtcyfz, committed by ). Changed prior to commit: https://reviews.llvm.org/D50702?vs=160557=160558#toc Repository: rCTE Clang Tools

[clang-tools-extra] r339673 - [clangd] NFC: Cleanup clangd help message

Author: omtcyfz Date: Tue Aug 14 05:00:39 2018 New Revision: 339673 URL: http://llvm.org/viewvc/llvm-project?rev=339673=rev Log: [clangd] NFC: Cleanup clangd help message Add missed space, fix a typo. Reviewed by: ioeric Differential Revision: https://reviews.llvm.org/D50702 Modified:

[PATCH] D47987: Provide only one declaration of __throw_runtime_error

hiraditya added a comment. Herald added a subscriber: ldionne. Any updates on this one? I like @mclow.lists idea of removing it from __locale. Repository: rCXX libc++ https://reviews.llvm.org/D47987 ___ cfe-commits mailing list

[PATCH] D50702: [clangd] NFC: Cleanup clangd help message

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D50702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50702: [clangd] NFC: Cleanup clangd help message

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: arphaman, jkorous, MaskRay. Add missed space, fix a typo. https://reviews.llvm.org/D50702 Files:

[PATCH] D50699: Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

owenpan added a comment. Test case: F6937162: BreakBeforeBinaryOperators.cpp Repository: rC Clang https://reviews.llvm.org/D50699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:1317 + for (auto *D : FromRD->decls()) { +Decl *ToD = Importer.GetAlreadyImportedOrNull(D); +assert(ToRD == ToD->getDeclContext() && ToRD->containsDecl(ToD)); Is it sure that `ToD` will

[PATCH] D50700: [clangd] Generate better incomplete bigrams for the Dex index

kbobyrev updated this revision to Diff 160555. kbobyrev added a comment. Treat leading underscores as additional signals and don't extract two heads in that case. https://reviews.llvm.org/D50700 Files: clang-tools-extra/clangd/index/dex/Trigram.cpp

[PATCH] D50700: [clangd] Generate better incomplete bigrams for the Dex index

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: arphaman, jkorous, MaskRay. Currently, the query trigram generator would simply yield `u_p` trigram for the `u_p` query. This is not optimal,

[PATCH] D50699: Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

owenpan created this revision. owenpan added a project: clang. See bug report https://bugs.llvm.org/show_bug.cgi?id=38525 for more details. Repository: rC Clang https://reviews.llvm.org/D50699 Files: lib/Format/ContinuationIndenter.cpp Index: lib/Format/ContinuationIndenter.cpp

[PATCH] D50451: [ASTImporter] Fix import of class templates partial specialization

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:4550 + // in the "From" context, but not in the "To" context. + for (auto *FromField : D->fields()) +Importer.Import(FromField); martong wrote: > a_sidorin wrote: > > Importing

[PATCH] D50451: [ASTImporter] Fix import of class templates partial specialization

martong updated this revision to Diff 160552. martong added a comment. - Add new test - Fix indentation Repository: rC Clang https://reviews.llvm.org/D50451 Files: include/clang/ASTMatchers/ASTMatchers.h lib/AST/ASTImporter.cpp lib/ASTMatchers/ASTMatchersInternal.cpp

[PATCH] D50451: [ASTImporter] Fix import of class templates partial specialization

martong marked 3 inline comments as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:4551 + for (auto *FromField : D->fields()) +Importer.Import(FromField); + martong wrote: > a_sidorin wrote: > > The result of import is

[PATCH] D50451: [ASTImporter] Fix import of class templates partial specialization

martong marked 5 inline comments as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:2872 Importer.MapImported(D, FoundField); +// In case of a FieldDecl of a ClassTemplateSpecializationDecl, the +// initializer of a FieldDecl

Re: Fwd: patch file for bug 38557

Hi Owen, thank you for your patch. I created a revision for it to pass review: https://reviews.llvm.org/D50697 If you do have an phabricator account you can take over, otherwise we can get it into trunk for you :) All the best, Jonas Am 14.08.2018 um 12:30 schrieb Owen Pan via cfe-commits: >

[PATCH] D50697: [clang-format] fix PR38557 - comments between "default" and ':' causes the case label to be treated as an identifier

JonasToth updated this revision to Diff 160550. JonasToth added a comment. Using git for the diff, add testcase Repository: rC Clang https://reviews.llvm.org/D50697 Files: lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D49798: [ASTImporter] Adding some friend function related unittests.

balazske updated this revision to Diff 160548. balazske added a comment. - Corrected the code in tests. Repository: rC Clang https://reviews.llvm.org/D49798 Files: unittests/AST/ASTImporterTest.cpp Index: unittests/AST/ASTImporterTest.cpp

[PATCH] D50697: [clang-format] fix PR38557 - comments between "default" and ':' causes the case label to be treated as an identifier

JonasToth created this revision. JonasToth added reviewers: hokein, krasimir, djasper, klimek. The Bug was reported and fixed by Owen Pan. Repository: rC Clang https://reviews.llvm.org/D50697 Files: UnwrappedLineParser.cpp Index: UnwrappedLineParser.cpp

Re: Fwd: patch file for bug 38557

Do you have a phabricator account? Otherwise I will create a revision for you (ofc mentioning your name in the commit message) for review. Am 14.08.2018 um 12:30 schrieb Owen Pan via cfe-commits: > Hi, > > Attached is the patch file for Bug 38557 > (https://bugs.llvm.org/show_bug.cgi?id=38557).

[PATCH] D50641: [clangd][test] Fix exit messages in tests

jkorous added a comment. I think that by introducing different codepath for testing purposes we might end up with fewer bugs in tests but the actual production code could become less tested. Actually, even the -lit-test itself might be not the theoretically most correct approach but I do see

Fwd: patch file for bug 38557

Hi, Attached is the patch file for Bug 38557 ( https://bugs.llvm.org/show_bug.cgi?id=38557). Thanks, Owen Index: UnwrappedLineParser.cpp === --- UnwrappedLineParser.cpp (revision 339102) +++ UnwrappedLineParser.cpp (working copy) @@

[PATCH] D50630: [AST] Update/correct the static_asserts for the bit-fields in Type

riccibruno added a comment. I actually have patches for TemplateSpecializationType, PackExpansionType, DependentTemplateSpecializationType and SubstTemplateTypeParmPackType which move the unsigned to the bit-fields in Type. The same could be done for the others I suppose. This assume that the

[PATCH] D50389: [clang-tidy] Abseil: integral division of Duration check

hokein added a comment. Looks mostly good. Comment at: test/clang-tidy/abseil-duration-division.cpp:58 + // CHECK-MESSAGES: [[@LINE-4]]:45: warning: operator/ on absl::Duration objects + // CHECK-FIXES: double DoubleDivision(T t1, T t2) {return + // absl::FDivDuration(t1,

[PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

yroux added a comment. Notice that the affected bots run two times the test cases where one execution passes and one fails, as you can see in (search Analysis/plist-macros.cpp for instance): http://lab.llvm.org:8011/builders/clang-cmake-armv8-full/builds/5450/steps/ninja%20check%201/logs/stdio

[PATCH] D50559: [gnu-objc] Make selector order deterministic.

This revision was automatically updated to reflect the committed changes. Closed by commit rC339668: [gnu-objc] Make selector order deterministic. (authored by theraven, committed by ). Changed prior to commit: https://reviews.llvm.org/D50559?vs=160312=160545#toc Repository: rC Clang

r339668 - [gnu-objc] Make selector order deterministic.

Author: theraven Date: Tue Aug 14 03:05:25 2018 New Revision: 339668 URL: http://llvm.org/viewvc/llvm-project?rev=339668=rev Log: [gnu-objc] Make selector order deterministic. Summary: This probably fixes PR35277, though there may be other sources of nondeterminism (this was the only case of

r339667 - Add a stub mangling for ObjC selectors in the Microsoft ABI.

Author: theraven Date: Tue Aug 14 03:04:36 2018 New Revision: 339667 URL: http://llvm.org/viewvc/llvm-project?rev=339667=rev Log: Add a stub mangling for ObjC selectors in the Microsoft ABI. This mangling is used only for outlined SEH finally blocks, which have internal linkage. This fixes the

[PATCH] D50438: [clangd] Sort GoToDefinition results.

hokein updated this revision to Diff 160544. hokein marked 3 inline comments as done. hokein added a comment. Address review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50438 Files: clangd/XRefs.cpp unittests/clangd/XRefsTests.cpp Index:

[PATCH] D50246: [RISCV] Add support for computing sysroot for riscv32-unknown-elf

simoncook requested changes to this revision. simoncook added a comment. This revision now requires changes to proceed. Herald added a subscriber: PkmX. I've tested this, regression tests involving linking now mostly pass as crt0 can now be found, but it seems that system headers are still being

[PATCH] D50645: [clangd] Show non-instantiated decls in signatureHelp

This revision was automatically updated to reflect the committed changes. Closed by commit rL339665: [clangd] Show non-instantiated decls in signatureHelp (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D50645

<    1   2   3   >