modocache added a comment.
Here's a compiler explorer link demonstrating that GCC 8.2 and Clang 7.0.0
compile the example code, but Clang trunk emits an error:
https://godbolt.org/z/l3baI_
I realize the proposed "fix" here isn't likely to be exactly correct, but I
thought it could be a good
modocache created this revision.
modocache added reviewers: rsmith, rjmccall, doug.gregor, ahatanak.
In https://reviews.llvm.org/D45898?id=157373, @rsmith advises to move a
`checkMemberDestructor` into `InitListChecker::CheckStructUnionTypes`,
to check base classes for an accessible destructor
phosek added a comment.
In https://reviews.llvm.org/D53787#1279899, @rsmith wrote:
> Replacing the global new and delete is supposed to be a whole-program
> operation (you only get one global allocator). Otherwise you couldn't
> allocate memory in one DSO and deallocate it in another. (And nor
MTC added a comment.
In addition, `clang/lib/StaticAnalyzer/README.txt` and other related docs in
`clang/lib/docs/analyzer` are also out of date.
Comment at: www/analyzer/alpha_checks.html:570
+
+ A StringRef should not be bound to a temporary std::string
+ whose lifetime
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
Replacing the global new and delete is supposed to be a whole-program operation
(you only get one global allocator). Otherwise you couldn't allocate memory in
one DSO and deallocate
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, LG. I bet there's a bunch more places we could change to call these two.
Repository:
rC Clang
https://reviews.llvm.org/D53837
___
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I've actually never noticed this checker until you started updating the website
:)
This might be also covered by @rnkovacs's string buffer escape checker - either
already or eventually, it'll
Author: rsmith
Date: Mon Oct 29 19:02:49 2018
New Revision: 345562
URL: http://llvm.org/viewvc/llvm-project?rev=345562=rev
Log:
PR23833, DR2140: an lvalue-to-rvalue conversion on a glvalue of type
nullptr_t does not access memory.
We now reuse CK_NullToPointer to represent a conversion from a
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/LLVMConventionsChecker.cpp:193-195
static bool AllocatesMemory(QualType T) {
return IsStdVector(T) || IsStdString(T) || IsSmallVector(T);
}
The `StringRef`part of this checker doesn't
Szelethus updated this revision to Diff 171624.
Szelethus added a comment.
Excuse my informality, but `llvm.Conventions` fell flat on its face in my eyes
(details: https://reviews.llvm.org/D53856), so I'm no longer insisting on
including it on this page.
https://reviews.llvm.org/D53069
Szelethus updated this revision to Diff 171623.
Szelethus added a comment.
Added an entry to the website.
https://reviews.llvm.org/D53856
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/LLVMConventionsChecker.cpp
test/Analysis/llvm-conventions.cpp
Szelethus created this revision.
Szelethus added reviewers: george.karpenkov, NoQ, xazax.hun, MTC.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho,
a.sidorin, rnkovacs, szepet, whisperity.
Interestingly, this many year old (when I last looked I remember 2010ish)
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345558: [analyzer] Allow padding checker to traverse simple
class hierarchies (authored by alexshap, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53206
Files:
Author: alexshap
Date: Mon Oct 29 18:20:37 2018
New Revision: 345558
URL: http://llvm.org/viewvc/llvm-project?rev=345558=rev
Log:
[analyzer] Allow padding checker to traverse simple class hierarchies
The existing padding checker skips classes that have any base classes.
This patch allows the
phosek created this revision.
phosek added a reviewer: mcgrathr.
Herald added a reviewer: EricWF.
Herald added a subscriber: cfe-commits.
This avoids introducing unnecessary DT_NEEDED entries when using
C++ driver for linking C code or C++ code that doesn't use C++
standard library.
Repository:
rnk added a comment.
This seems pretty inconsistent with how -fvisibility=hidden behaves with
normal, user written declarations. Consider this code:
void foo();
void bar() { foo(); }
We get this IR:
$ clang -S -emit-llvm --target=x86_64-linux t.c -o - -fvisibility=hidden
...
define
craig.topper added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:9013
Features, llvm::ConstantInt::get(Int32Ty, FeaturesMask));
return Builder.CreateICmpNE(Bitset, llvm::ConstantInt::get(Int32Ty, 0));
}
This code looks to be out of date. It's
pirama edited reviewers, added: echristo, craig.topper; removed: pirama.
pirama added subscribers: srhines, pirama, cfe-commits.
pirama added a comment.
Adding reviewers suggested by 'arc cover'.
https://reviews.llvm.org/D53850
___
cfe-commits
rsmith added inline comments.
Comment at: test/SemaCXX/unknown-type-name.cpp:1
-// RUN: %clang_cc1 -fsyntax-only -verify %s
-// RUN: %clang_cc1 -fsyntax-only -verify -std=c++98 %s
-// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 %s
+// RUN: %clang_cc1 -Wc++2a-compat
rsmith added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:3105
+ isClassTemplateDeductionContext(DSContext),
+ /*AllowImplicitTypename=*/true);
This looks overly broad: shouldn't this depend on
Rakete updated this revision to Diff 171612.
Rakete added a comment.
Fix easy errors in tests that I missed by adding explicit template
instantations.
Repository:
rC Clang
https://reviews.llvm.org/D53847
Files:
include/clang/Basic/DiagnosticSemaKinds.td
Szelethus marked 2 inline comments as done.
Szelethus added a comment.
Thanks! :)
Comment at: lib/FrontendTool/ExecuteCompilerInvocation.cpp:255
+ento::printAnalyzerConfigList(llvm::outs());
+return true;
+ }
george.karpenkov wrote:
> Hm, should we
Szelethus updated this revision to Diff 171611.
Szelethus added a comment.
Hardcoded the first entry as suggested by @george.karpenkov.
https://reviews.llvm.org/D53296
Files:
include/clang/Driver/CC1Options.td
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
Rakete updated this revision to Diff 171609.
Rakete added a comment.
Remove unneeded -Wc++2a-compat flag in tests.
Repository:
rC Clang
https://reviews.llvm.org/D53847
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Parse/ParseDecl.cpp
Rakete added inline comments.
Comment at: test/CXX/temp/temp.res/p5.cpp:71
+
+// FIXME: This is ok.
+template
I think the below is well-formed according to the quote above, but I'm not sure
I understand it correctly.
Repository:
rC Clang
Rakete created this revision.
Rakete added a reviewer: rsmith.
This patch implements P0634r3 that removes the need for 'typename' in certain
contexts.
For example,
template
using foo = T::type; // ok
This is also allowed in previous language versions as an extension, because I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345552: [CMake][Fuchsia] Drop the
LIBCXX_HIDE_FROM_ABI_PER_TU_BY_DEFAULT (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: phosek
Date: Mon Oct 29 16:10:49 2018
New Revision: 345552
URL: http://llvm.org/viewvc/llvm-project?rev=345552=rev
Log:
[CMake][Fuchsia] Drop the LIBCXX_HIDE_FROM_ABI_PER_TU_BY_DEFAULT
Now that libc++ uses __exclude_from_explicit_instantiation__ attribute,
this is no longer needed.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345551: [compiler-rt][builtins] Dont #include
CoreFoundation in os_version_check.c (authored by epilk, committed by ).
Herald added a subscriber: delcypher.
Changed prior to commit:
ldionne accepted this revision.
ldionne added a comment.
Please LMK if you see nice consequences of this. I'm trying to gather "real
stories" where this helped.
Repository:
rC Clang
https://reviews.llvm.org/D53839
___
cfe-commits mailing list
russellmcc added a comment.
Bump! Thanks for your time
https://reviews.llvm.org/D40988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eandrews added a comment.
In https://reviews.llvm.org/D52998#1259602, @lebedev.ri wrote:
> In https://reviews.llvm.org/D52998#1258962, @eandrews wrote:
>
> > Yes. I understand. At the moment, exception handling flags are generated
> > based on `BENCHMARK_ENABLE_EXCEPTIONS` in
Szelethus added a comment.
In https://reviews.llvm.org/D33672#1279520, @ZaMaZaN4iK wrote:
> Thank you for the roadmap! Honestly I am not so familiar with Clang AST and
> Clang Static Analyzer details (all my experience is writing some simple
> checkers for clang-tidy and watching some videos
ZaMaZaN4iK added a comment.
In https://reviews.llvm.org/D33672#1279305, @NoQ wrote:
> Thanks! I like where this is going. Let's land the patch and continue
> developing it incrementally in trunk.
>
> The next steps for this checker are, in my opinion:
>
> - Do the visitor thingy that i
phosek created this revision.
phosek added reviewers: jakehehrlich, mcgrathr.
Herald added subscribers: cfe-commits, mgorny.
Now that libc++ uses __exclude_from_explicit_instantiation__ attribute,
this is no longer needed.
Repository:
rC Clang
https://reviews.llvm.org/D53839
Files:
lebedev.ri updated this revision to Diff 171583.
lebedev.ri added a comment.
Add an opt-in option to diagnose such command-line-based macros.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53817
Files:
clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp
lebedev.ri created this revision.
lebedev.ri added reviewers: rsmith, aaron.ballman.
lebedev.ri added a project: clang.
Herald added subscribers: kbarton, nemanjai.
So we can keep that not-so-great logic in one place.
Repository:
rC Clang
https://reviews.llvm.org/D53837
Files:
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
I don't think a new PathGenerationScheme is needed, unless you plan changes to
BugReporter.cpp.
The code is fine otherwise, but could we try to use `diff` for
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345545: [ASTImporter] Reorder fields after structure import
is finished (authored by a.sidorin, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44100?vs=160477=171578#toc
Author: a.sidorin
Date: Mon Oct 29 14:46:18 2018
New Revision: 345545
URL: http://llvm.org/viewvc/llvm-project?rev=345545=rev
Log:
[ASTImporter] Reorder fields after structure import is finished
There are multiple reasons why field structures can be imported
in wrong order. The simplest is the
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
This LGTM with a couple of nitpicks.
Comment at: compiler-rt/lib/builtins/os_version_check.c:183
CFStringRef ProductVersion =
Fair enough - pity we couldn't readily have a single implementation or at
least semantics for modular debug info between implicit and explicit modes
(I mean, my fault in part for building a separate/new system when I did
modular codegen anyway) but hopefully we'll move to explicit modules across
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChecker.cpp:36
+ const ProgramStateRef PS;
+ SValBuilder
+
NoQ wrote:
> ZaMaZaN4iK wrote:
> > Szelethus wrote:
> > > You can acquire `SValBuilder` from `ProgramState`:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345540: [Driver] Include missing touch files for sanitized
library paths (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: phosek
Date: Mon Oct 29 14:04:12 2018
New Revision: 345540
URL: http://llvm.org/viewvc/llvm-project?rev=345540=rev
Log:
[Driver] Include missing touch files for sanitized library paths
These were forgotten in r345537 causing test failures on Clang builders.
Differential Revision:
phosek created this revision.
phosek added reviewers: jakehehrlich, juliehockett.
Herald added subscribers: cfe-commits, javed.absar, kubamracek.
These were forgotten in r345537 causing test failures on Clang builders.
Repository:
rC Clang
https://reviews.llvm.org/D53833
Files:
tekknolagi updated this revision to Diff 171568.
tekknolagi added a comment.
Skip non-definitions in `VisitRecord`
Repository:
rC Clang
https://reviews.llvm.org/D53206
Files:
lib/StaticAnalyzer/Checkers/PaddingChecker.cpp
test/Analysis/padding_inherit.cpp
Index:
astrelni updated this revision to Diff 171566.
astrelni added a comment.
Reply to comments: add check for language being c++, explicitly name type in
declaration, alphabetize release notes.
https://reviews.llvm.org/D53830
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
Author: phosek
Date: Mon Oct 29 13:37:52 2018
New Revision: 345537
URL: http://llvm.org/viewvc/llvm-project?rev=345537=rev
Log:
[Driver] Support sanitized libraries on Fuchsia
When using sanitizers, add //lib/
to the list of library paths to support using sanitized version of
runtime libraries
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345537: [Driver] Support sanitized libraries on Fuchsia
(authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53487?vs=170805=171564#toc
Repository:
rC Clang
Author: rjmccall
Date: Mon Oct 29 13:32:36 2018
New Revision: 345536
URL: http://llvm.org/viewvc/llvm-project?rev=345536=rev
Log:
In swiftcall, don't merge FP/vector types within a chunk.
Modified:
cfe/trunk/include/clang/CodeGen/SwiftCallingConv.h
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp:22
+ast_matchers::MatchFinder *Finder) {
+ // For the arithmetic calls, we match only the uses of the templated
operators
+ // where the template parameter is not a
NoQ accepted this revision.
NoQ added a comment.
Thanks! I like where this is going. Let's land the patch and continue
developing it incrementally in trunk.
The next steps for this checker are, in my opinion:
- Do the visitor thingy that i requested in inline-311373
astrelni created this revision.
astrelni added reviewers: ahedberg, hokein.
astrelni added a project: clang-tools-extra.
Herald added subscribers: jfb, xazax.hun, mgorny.
Introduce a new check to upgrade user code based on upcoming API breaking
changes to absl::Duration.
The check finds calls
pcc added a comment.
In https://reviews.llvm.org/D53524#1279288, @tejohnson wrote:
> In https://reviews.llvm.org/D53524#1276038, @pcc wrote:
>
> > In https://reviews.llvm.org/D53524#1274505, @tejohnson wrote:
> >
> > > In https://reviews.llvm.org/D53524#1271387, @tejohnson wrote:
> > >
> > > >
tejohnson added a comment.
In https://reviews.llvm.org/D53524#1276038, @pcc wrote:
> In https://reviews.llvm.org/D53524#1274505, @tejohnson wrote:
>
> > In https://reviews.llvm.org/D53524#1271387, @tejohnson wrote:
> >
> > > In https://reviews.llvm.org/D53524#1271357, @pcc wrote:
> > >
> > > >
Szelethus closed this revision.
Szelethus added a comment.
Commited in https://reviews.llvm.org/rC345531. Oops.
https://reviews.llvm.org/D53810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: szelethus
Date: Mon Oct 29 13:06:30 2018
New Revision: 345531
URL: http://llvm.org/viewvc/llvm-project?rev=345531=rev
Log:
[analyzer][NFC] Refactor PlistDiagnostics to use a class instead of passing 9
parameters around
This has been a long time coming. Note the usage of AnalyzerOptions:
efriedma added subscribers: vsk, efriedma.
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D53514
___
cfe-commits mailing list
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345527: [OpenMP] Fix condition. (authored by gbercea,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53827?vs=171558=171559#toc
Repository:
rC Clang
Author: gbercea
Date: Mon Oct 29 12:44:25 2018
New Revision: 345527
URL: http://llvm.org/viewvc/llvm-project?rev=345527=rev
Log:
[OpenMP] Fix condition.
Summary: Iteration variable must be strictly less than the number of
iterations. This fixes a bug introduced by previous patch D53448.
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
Rename, the patch, it is not an NFC.
Repository:
rC Clang
https://reviews.llvm.org/D53827
___
cfe-commits mailing list
gtbercea updated this revision to Diff 171558.
gtbercea added a comment.
Add tests.
Repository:
rC Clang
https://reviews.llvm.org/D53827
Files:
lib/Sema/SemaOpenMP.cpp
test/OpenMP/distribute_parallel_for_codegen.cpp
test/OpenMP/distribute_parallel_for_simd_codegen.cpp
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:82
-static void EmitRanges(raw_ostream ,
- const ArrayRef Ranges,
- const FIDMap& FM,
- const Preprocessor ,
-
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:82
-static void EmitRanges(raw_ostream ,
- const ArrayRef Ranges,
- const FIDMap& FM,
- const Preprocessor ,
-
gtbercea created this revision.
Herald added subscribers: cfe-commits, guansong.
gtbercea added reviewers: ABataev, caomhin.
Iteration variable must be strictly less than the number of iterations.
Repository:
rC Clang
https://reviews.llvm.org/D53827
Files:
lib/Sema/SemaOpenMP.cpp
Index:
devnexen added a comment.
Things might differ between NetBSD and FreeBSD about the feasibility. So maybe
for the former it is more reachable (only would need to set specific
application mappings maybe ?).
- So once the non writable addresses are created, it processes the working sets
to make
> On Oct 29, 2018, at 11:26 AM, David Blaikie wrote:
>
> Is this a workaround for now with the intent to fix this to allow such
> implicit specializations to have their debug info modularized? I believe this
> does work correctly in modular debug info with expliict modules, would
> probably
JonasToth added a comment.
This is usually not done in the LLVM codebase, as its not a
pointer/reference.
Am 29.10.18 um 20:29 schrieb Alexander Zaitsev via Phabricator:
> ZaMaZaN4iK added inline comments.
>
>
> Comment at:
ZaMaZaN4iK added inline comments.
Comment at: clang-tidy/readability/IsolateDeclarationCheck.cpp:119
+ const LangOptions ) {
+ std::size_t DeclCount = std::distance(DS->decl_begin(), DS->decl_end());
+ if (DeclCount < 2)
Mark `DeclCount` as const
neerajksingh added a comment.
In https://reviews.llvm.org/D53457#1278579, @hans wrote:
> The `-Xclang` option has the same issue, and I think `/clang:` should work
> similarly, i.e. `/clang:-MF /clang:`. It's not pretty, but at least
> it's consistent. Yes, that means processing consecutive
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Wow thanks! Great point.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:82
-static void EmitRanges(raw_ostream ,
- const ArrayRef Ranges,
-
krytarowski added a comment.
In https://reviews.llvm.org/D52610#1279176, @devnexen wrote:
> - FreeBSD does not have real Linux's clone equivalent.
> - Hangs or crashes during the final report (the shadow mapping is similar as
> Linux's though).
NetBSD has a clone compatibility syscall... but
devnexen added a comment.
- FreeBSD does not have real Linux's clone equivalent.
- Hangs or crashes during the final report (the shadow mapping is similar as
Linux's though).
Repository:
rC Clang
https://reviews.llvm.org/D52610
___
cfe-commits
steveire marked 2 inline comments as done.
steveire added inline comments.
Comment at: clang-query/QueryParser.cpp:285
+if (VarStr.empty())
+ return new InvalidQuery("expected variable name");
+if (Var == PQV_Invalid)
aaron.ballman wrote:
> This
It seems like it caused a bug:
https://bugs.llvm.org/show_bug.cgi?id=39486
From: cfe-commits on behalf of Matt
Arsenault via cfe-commits
Sent: 03 October 2018 03:01
To: cfe-commits@lists.llvm.org
Subject: r343653 - OpenCL: Mark printf format string argument
krytarowski added a comment.
In https://reviews.llvm.org/D52610#1278743, @devnexen wrote:
> ping working-set on FreeBSD does not seem doable.
Rationale? I don't feel convinced.
Repository:
rC Clang
https://reviews.llvm.org/D52610
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345522: [clang-query] Add non-exclusive output API (authored
by steveire, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: steveire
Date: Mon Oct 29 11:59:56 2018
New Revision: 345522
URL: http://llvm.org/viewvc/llvm-project?rev=345522=rev
Log:
[clang-query] Add non-exclusive output API
Summary:
Add granular options for AST dumping, text printing and diagnostics.
This makes it possible to
* Have both diag
On Mon, Oct 29, 2018 at 11:46 AM Keane, Erich wrote:
>
>
>
>
> *From:* David Blaikie [mailto:dblai...@gmail.com]
> *Sent:* Monday, October 29, 2018 11:41 AM
> *To:* Keane, Erich
> *Cc:* Eric Christopher ; cfe-commits@lists.llvm.org
>
>
> *Subject:* Re: r344957 - Give Multiversion-inline
From: David Blaikie [mailto:dblai...@gmail.com]
Sent: Monday, October 29, 2018 11:41 AM
To: Keane, Erich
Cc: Eric Christopher ; cfe-commits@lists.llvm.org
Subject: Re: r344957 - Give Multiversion-inline functions linkonce linkage
On Mon, Oct 29, 2018 at 11:30 AM Keane, Erich
On Mon, Oct 29, 2018 at 11:30 AM Keane, Erich wrote:
> GCC actually doesn’t support function multiversioning in C mode, so this
> fix is part of our extension to support C with multiversioning.
>
Ah, what's the motivation for that?
> I perhaps wonder if this is part of the reason GCC only
aaron.ballman updated this revision to Diff 171545.
aaron.ballman marked 3 inline comments as done.
aaron.ballman added a comment.
Updated based on initial review feedback, and added more context to the patch.
https://reviews.llvm.org/D53814
Files:
Analysis/diagnostics/sarif-check.py
GCC actually doesn’t support function multiversioning in C mode, so this fix is
part of our extension to support C with multiversioning. I perhaps wonder if
this is part of the reason GCC only supports it in C++ mode...
From: David Blaikie [mailto:dblai...@gmail.com]
Sent: Monday, October 29,
Is this a workaround for now with the intent to fix this to allow such
implicit specializations to have their debug info modularized? I believe
this does work correctly in modular debug info with expliict modules, would
probably be sort of nice to have these things be consistent/similar?
On Tue,
Does this match GCC's approach here?
(I ask this sort of as throwaway/conversation starter - because the
linkage/behavior around multiversion functions and their inlining is full
of sharp corners/risks of code moving out of the areas appropriately
restricted based on the cpu features)
On Mon,
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:787-791
+ // Acquire the macro's name.
+ Token TheTok;
+ RawLexer.LexFromRawLexer(TheTok);
+
+ std::string MacroName = PP.getSpelling(TheTok);
NoQ wrote:
> Not sure,
twoh added a comment.
@rsmith @dblaikie Thank you for the comments! It seems that this is not the
appropriate way to handle the issue. I'll find different way to resolve the
problem.
Repository:
rC Clang
https://reviews.llvm.org/D38061
___
Szelethus added a comment.
@NoQ did you have time to ping Devin about this? (Sorry for the early ping, but
this patch is blocking a lot of my other patches.)
https://reviews.llvm.org/D53276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rupprecht resigned from this revision.
rupprecht added a comment.
I'm not familiar with this code or anything windows related, and it looks like
@rnk is, so I'll remove myself and let him approve
Repository:
rL LLVM
https://reviews.llvm.org/D53066
JonasToth updated this revision to Diff 171538.
JonasToth added a comment.
- Merge branch 'master' into experiment_isolate_decl
- adjust doc slighty to comment
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51949
Files:
clang-tidy/readability/CMakeLists.txt
rjmccall added a comment.
In https://reviews.llvm.org/D53705#1279068, @svenvh wrote:
> Unlikely, since address spaces are provided in a different way in OpenCL C++
> vs OpenCL C.
>
> OpenCL C provides qualifiers such as `global` as part of the language.
> OpenCL C++ provides template classes
rjmccall added a comment.
In https://reviews.llvm.org/D53738#1278528, @ebevhan wrote:
> In https://reviews.llvm.org/D53738#1278078, @rjmccall wrote:
>
> > I don't think we should add *types* just for this, but if you need to make
> > a different kind of `BinaryOperator` that represents that the
aaron.ballman added a comment.
In https://reviews.llvm.org/D53817#1279053, @JonasToth wrote:
> > I personally haven't yet seen this check firing on *predefined* macros.
>
> I did specifically check the compiler defined macros I could see in the AST
> and they were not diagnosed from the
Author: epilk
Date: Mon Oct 29 10:38:42 2018
New Revision: 345517
URL: http://llvm.org/viewvc/llvm-project?rev=345517=rev
Log:
Revert "Revert "Support for groups of attributes in #pragma clang attribute""
This reverts commit r345487, which reverted r345486. I think the crashes were
caused by an
Typz added a comment.
In https://reviews.llvm.org/D50147#1272742, @sammccall wrote:
> Being able to discover the right style from the filesystem is powerful, and
> if I was going to use this flag, I'd consider symlinking the style-file to
> `subproject/.clang_format` instead. That way the
svenvh added a comment.
Unlikely, since address spaces are provided in a different way in OpenCL C++ vs
OpenCL C.
OpenCL C provides qualifiers such as `global` as part of the language. OpenCL
C++ provides template classes such as `cl::global` through a header file.
Repository:
rC Clang
sammccall added a comment.
In https://reviews.llvm.org/D50147#1279056, @Typz wrote:
> In https://reviews.llvm.org/D50147#1272742, @sammccall wrote:
>
> > The idea here does seem to be a natural extension of -style, at least for
> > the case when the arg is a filename directly. I'm not opposed,
JonasToth added a comment.
> I personally haven't yet seen this check firing on *predefined* macros.
I did specifically check the compiler defined macros I could see in the AST and
they were not diagnosed from the beginning.
I would guess, only the compiler-flag macros are passed in the
Typz added a comment.
In https://reviews.llvm.org/D50147#1272742, @sammccall wrote:
> The idea here does seem to be a natural extension of -style, at least for the
> case when the arg is a filename directly. I'm not opposed, happy to review
> this.
>
> I do want to probe the use case a bit
1 - 100 of 175 matches
Mail list logo
