[PATCH] D56585: [clang-tidy] Treat references to smart pointers correctly in use-after-move.

This revision was automatically updated to reflect the committed changes. Closed by commit rL351303: [clang-tidy] Treat references to smart pointers correctly in use-after-move. (authored by mboehme, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE

[clang-tools-extra] r351303 - [clang-tidy] Treat references to smart pointers correctly in use-after-move.

Author: mboehme Date: Tue Jan 15 23:53:25 2019 New Revision: 351303 URL: http://llvm.org/viewvc/llvm-project?rev=351303=rev Log: [clang-tidy] Treat references to smart pointers correctly in use-after-move. Summary: Previously, we weren't recognizing these as smart pointers and thus weren't

[PATCH] D56463: [SEH] Pass the frame pointer from SEH finally to finally functions

This revision was automatically updated to reflect the committed changes. Closed by commit rC351302: [SEH] Pass the frame pointer from SEH finally to finally functions (authored by ssijaric, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56463/new/

r351302 - [SEH] Pass the frame pointer from SEH finally to finally functions

Author: ssijaric Date: Tue Jan 15 23:39:44 2019 New Revision: 351302 URL: http://llvm.org/viewvc/llvm-project?rev=351302=rev Log: [SEH] Pass the frame pointer from SEH finally to finally functions Pass the frame pointer that the first finally block receives onto the nested finally block, instead

[PATCH] D56585: [clang-tidy] Treat references to smart pointers correctly in use-after-move.

mboehme added a comment. In D56585#1358477 , @JonasToth wrote: > LGTM, is there a bug report for this issue? If yes please close that too :) Thanks for the reminder! This was a bug that was reported internally, so there is no LLVM bug for this.

r351301 - [X86] Correct the type string for __builtin_ia32_gathersiv16sf to make the indices an integer type not an FP type.

Author: ctopper Date: Tue Jan 15 23:17:14 2019 New Revision: 351301 URL: http://llvm.org/viewvc/llvm-project?rev=351301=rev Log: [X86] Correct the type string for __builtin_ia32_gathersiv16sf to make the indices an integer type not an FP type. The element count and width remain the same. This

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

Quuxplusone added a comment. In D56731#1359190 , @rsmith wrote: > we need to keep in mind while making that decision that a warning that is > either off-by-default or turned off by nearly everyone delivers much less > value Agreed. I would expect the

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

Yes, the behavior of the compiler doesn’t match what’s explained in the documentation anymore.Please take a look at the attached patch, which updates the documentation. trivial-abi-docs.patch Description: Binary data CC’ing a couple more people who commented on the original patch.On Jan 10, 2019,

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

tamur added a comment. This patch seems to have broken the compilation. I get the following error on a linux platform: [12/14] Linking CXX executable bin/clangd FAILED: bin/clangd : && /usr/local/google/home/tamur/src/llvm/2018_nov_12/llvm/Stable/bin/clang++ -fPIC -fvisibility-inlines-hidden

[PATCH] D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

EricWF updated this revision to Diff 181974. EricWF added a comment. Add the requested tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55500/new/ https://reviews.llvm.org/D55500 Files: include/clang/Basic/Builtins.def lib/AST/ExprConstant.cpp lib/Basic/Builtins.cpp

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 181973. jyu2 marked an inline comment as done. jyu2 added a comment. Change error message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Expr.h include/clang/AST/ExprCXX.h

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

EricWF updated this revision to Diff 181972. EricWF added a comment. Address review comments. - Use "%0 maybe not intend to support ctad" like warning text. - Add note about suppression. - Rename `-Wimplicit-ctad` -> `-Wctad-maybe-unsupported` (Perhaps it should be `-Wctad-maybe-unintended`?)

r351298 - [WebAssembly] COWS has been renamed to WASI.

Author: djg Date: Tue Jan 15 21:23:57 2019 New Revision: 351298 URL: http://llvm.org/viewvc/llvm-project?rev=351298=rev Log: [WebAssembly] COWS has been renamed to WASI. Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/test/Driver/wasm-toolchain.c

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

EricWF marked 10 inline comments as done. EricWF added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2129 +def warn_class_template_argument_deduction_no_user_defined_guides : Warning< + "using class template argument deduction for %0 that has no

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. Wow, thanks for the cleanups. This is much easier to read as a consequence. And sorry it took a while to get you another round of review. Comments below.

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall added a comment. In D56411#1352602 , @yaxunl wrote: > In D56411#1352332 , @rjmccall wrote: > > > This patch still doesn't make any sense. You don't need to do any special > > validation when passing a

[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

rjmccall added a comment. It's an interesting idea at least, and it does seem like there ought to be some way to express it, at least internally. A `-cc1` option is fine for your purposes, right? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53153/new/

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm updated this revision to Diff 181964. dankm marked an inline comment as done. dankm added a comment. Enforce path mapping. This requires LLVM review D56769 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/

r351294 - [SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03

Author: ericwf Date: Tue Jan 15 18:34:36 2019 New Revision: 351294 URL: http://llvm.org/viewvc/llvm-project?rev=351294=rev Log: [SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03 When -faligned-allocation is specified in C++03 libc++ defines std::align_val_t as an unscoped

[PATCH] D56760: Add a new builtin: __builtin_dynamic_object_size

george.burgess.iv added a comment. Thanks for this! > Would it make sense to model this as an (optional) extra flag bit for > __builtin_object_size rather than as a new builtin? +1. That way, we could avoid making a `pass_dynamic_object_size` (assuming we wouldn't want to have a different API

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker added a comment. In D56424#1357484 , @MyDeveloperDay wrote: > In D56424#1357481 , @lebedev.ri > wrote: > > > In D56424#1357471 , > > @MyDeveloperDay wrote: > > >

[PATCH] D56632: [analyzer] Track region liveness only through base regions.

NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:390 - // FIXME: Remove when we migrate over to just using ValueManager. SymbolManager () { return SymMgr; } baloghadamsoftware wrote: > Is this comment

[PATCH] D56632: [analyzer] Track region liveness only through base regions.

NoQ updated this revision to Diff 181961. NoQ marked 12 inline comments as done. NoQ added a comment. Fix stuff. In D56632#1356163 , @baloghadamsoftware wrote: > Did you measure decrease in the false-positive rate or an increase in the > true-positive

[PATCH] D56732: [clang] [test] Disable Python binding tests w/ LLVM_ENABLE_PIC=OFF

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! I can't easily test this since only some of our bots see this and I don't have a Linux box at hand, but it looks like it should work and I can verify on the bots once this is in :)

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

rsmith added a comment. [This discussion should probably move to cfe-dev@, since it's not directly relevant for this patch.] In D56731#1358907 , @Quuxplusone wrote: > > Concretely, I think we could warn if, during template instantiation from a > >

[PATCH] D56766: [Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction.

vsapsai created this revision. vsapsai added a reviewer: rsmith. Herald added subscribers: dexonsmith, jkorous. Fixes `-emit-header-module` when GenerateHeaderModuleAction is wrapped by another frontend action. rdar://problem/47302588 https://reviews.llvm.org/D56766 Files:

[PATCH] D56746: [Fixed Point Arithmetic] Add APFixedPoint to APValue

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56746/new/ https://reviews.llvm.org/D56746 ___

[PATCH] D56760: Add a new builtin: __builtin_dynamic_object_size

rsmith added a comment. Thanks, this seems like a useful feature to me. Would it make sense to model this as an (optional) extra flag bit for `__builtin_object_size` rather than as a new builtin? It'd seem reasonable to me to ask on the gcc dev list if they'd be interested in such an extension

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. I think that's the right direction, yeah. I thought I told you it was fine to commit this patch under that assumption awhile ago. Did I just never click "accept"? Repository: rC

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

gromer added a comment. In D56731#1358926 , @jdennett wrote: > In D56731#1358907 , @Quuxplusone > wrote: > > > For my own use-cases, I will continue to want a 100% comprehensive > > `-Wctad`. All these

[PATCH] D56748: [EH] Rename llvm.x86.seh.recoverfp intrinsic to llvm.eh.recoverfp

This revision was automatically updated to reflect the committed changes. Closed by commit rL351284: [EH] Rename llvm.x86.seh.recoverfp intrinsic to llvm.eh.recoverfp (authored by efriedma, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r351284 - [EH] Rename llvm.x86.seh.recoverfp intrinsic to llvm.eh.recoverfp

Author: efriedma Date: Tue Jan 15 16:50:44 2019 New Revision: 351284 URL: http://llvm.org/viewvc/llvm-project?rev=351284=rev Log: [EH] Rename llvm.x86.seh.recoverfp intrinsic to llvm.eh.recoverfp This is the clang counterpart to D56747. Patch by Mandeep Singh Grang. Differential Revision:

[PATCH] D56760: Add a new builtin: __builtin_dynamic_object_size

erik.pilkington created this revision. erik.pilkington added reviewers: george.burgess.iv, ahatanak, rjmccall, rsmith. Herald added subscribers: kristina, dexonsmith, jkorous. This builtin has the same UI as `__builtin_object_size`, but has the potential to be evaluated dynamically. It is meant

Re: r351222 - [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

This change was causing MSan/ASan failures on the sanitizer bots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/28272 I reverted it in r351282. On Tue, Jan 15, 2019 at 11:09 AM Haojian Wu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hokein > Date: Tue

r351282 - Revert "[Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database."

Author: vlad.tsyrklevich Date: Tue Jan 15 16:37:39 2019 New Revision: 351282 URL: http://llvm.org/viewvc/llvm-project?rev=351282=rev Log: Revert "[Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database." This reverts commits r351222 and r351229, they

[PATCH] D56748: [EH] Rename llvm.x86.seh.recoverfp intrinsic to llvm.eh.recoverfp

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56748/new/ https://reviews.llvm.org/D56748 ___

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE351280: [clangd] XPC transport layer (authored by jkorous, committed by ). Changed prior to commit: https://reviews.llvm.org/D54428?vs=180809=181925#toc Repository: rCTE Clang Tools Extra CHANGES

[clang-tools-extra] r351280 - [clangd] XPC transport layer

Author: jkorous Date: Tue Jan 15 16:24:22 2019 New Revision: 351280 URL: http://llvm.org/viewvc/llvm-project?rev=351280=rev Log: [clangd] XPC transport layer - New transport layer for macOS. - XPC Framework - Test client Framework and client were written by Alex Lorenz. Differential Revision:

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

nickdesaulniers added a comment. With this patch, DD53765, and one out of tree kernel patch to work around a separate issue , I can confirm that I can compile, link, and boot an x86_64 Linux kernel with

[PATCH] D56746: [Fixed Point Arithmetic] Add APFixedPoint to APValue

leonardchan updated this revision to Diff 181918. leonardchan marked an inline comment as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56746/new/ https://reviews.llvm.org/D56746 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/Type.h

[PATCH] D38430: Enable -pie and --enable-new-dtags by default on Android.

danalbert added inline comments. Comment at: cfe/trunk/lib/Driver/ToolChains/Linux.cpp:814 +bool Linux::isPIEDefault() const { + return (getTriple().isAndroid() && !getTriple().isAndroidVersionLT(16)) || + getSanitizerArgs().requiresPIE(); pcc wrote: >

Re: r351160 - [X86] Make _xgetbv/_xsetbv on non-windows platforms

This isn't blocking anything. Just doing some archaeology because I noticed we had an intrinsic in the backend, but it wasn't used by the frontend due to a previous revert a couple years ago. ~Craig On Tue, Jan 15, 2019 at 3:47 PM Benjamin Kramer wrote: > I think the only viable solution is

[PATCH] D56752: [ASTDump] Mark BlockDecls which capture this with a tag

steveire updated this revision to Diff 181909. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56752/new/ https://reviews.llvm.org/D56752 Files: lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp

[PATCH] D56753: [ASTDump] Mark null params with a tag rather than a child node

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56753 Files: lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp

Re: r351160 - [X86] Make _xgetbv/_xsetbv on non-windows platforms

I think the only viable solution is to make v8 not define reserved identifiers & reland this change. That will take some time, so unless this is blocking something important I'd prefer to reland after the release cut so the world can catch up before the next release. I can take care of sending v8

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

jdennett added a comment. In D56731#1358907 , @Quuxplusone wrote: > For my own use-cases, I will continue to want a 100% comprehensive `-Wctad`. > All these "heuristics" you're proposing seem very ad-hoc, and make a lot of > work for the compiler

[PATCH] D56752: [ASTDump] Mark BlockDecls which capture this with a tag

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Removal of the child node makes it easier to separate traversal from output generation. Repository: rC Clang https://reviews.llvm.org/D56752 Files: lib/AST/ASTDumper.cpp

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

Quuxplusone added a comment. > Concretely, I think we could warn if, during template instantiation from a > type-dependent initializer, we select the copy deduction candidate and there > was another viable candidate (the `optional o(x)` case, the `tuple > t{args...}` case, etc), maybe under a

[PATCH] D56751: [ASTDump] Mark variadic declarations with a tag instead of child node

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. This makes it easier to separate traversal of the AST from output generation. Repository: rC Clang https://reviews.llvm.org/D56751 Files: lib/AST/ASTDumper.cpp

[PATCH] D38430: Enable -pie and --enable-new-dtags by default on Android.

pcc added inline comments. Comment at: cfe/trunk/lib/Driver/ToolChains/Linux.cpp:814 +bool Linux::isPIEDefault() const { + return (getTriple().isAndroid() && !getTriple().isAndroidVersionLT(16)) || + getSanitizerArgs().requiresPIE(); eugenis wrote: >

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/tools/libclang/CXType.cpp:132 + if (!(TU->ParsingOptions & CXTranslationUnit_IncludeAttributedTypes) && + ATT->getAttrKind() != attr::AddressSpace) { return

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan updated this revision to Diff 181902. leonardchan marked an inline comment as done. Herald added a subscriber: arphaman. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55447/new/ https://reviews.llvm.org/D55447 Files: clang/include/clang/Sema/Sema.h

[PATCH] D53541: [COFF, ARM64] Do not emit x86_seh_recoverfp intrinsic

mgrang added a comment. I have renamed llvm.x86.seh.recoverfp intrinsic to llvm.eh.recoverfp in D56747 and D56748 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53541/new/ https://reviews.llvm.org/D53541

[PATCH] D56748: [EH] Rename llvm.x86.seh.recoverfp intrinsic to llvm.eh.recoverfp

mgrang created this revision. mgrang added reviewers: rnk, efriedma. This is the clang counterpart to D56747 . Repository: rC Clang https://reviews.llvm.org/D56748 Files: lib/CodeGen/CGException.cpp test/CodeGen/exceptions-seh.c

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

rsmith added a comment. I like @Quuxplusone's suggestions for more heuristics here, but I think they should probably live under a different warning flag (collectively grouped under `-Wctad` as @lebedev.ri suggested). Concretely, I think we could warn if, during template instantiation from a

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. In D53738#1358249 , @rjmccall wrote: > In D53738#172 , @rjmccall wrote: > > > In D53738#1333276 , @leonardchan > > wrote: > > > > > In

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

rjmccall added a comment. Okay, so is this ready to re-review independently? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55850/new/ https://reviews.llvm.org/D55850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56746: [Fixed Point Arithmetic] Add APFixedPoint to APValue

rjmccall added a comment. One nit-pick, then this is good to go. Comment at: clang/include/clang/AST/APValue.h:183 +setFixedPoint(std::move(FX)); + } explicit APValue(const APValue *E, unsigned N) : Kind(Uninitialized) { I know this is the established

[PATCH] D38430: Enable -pie and --enable-new-dtags by default on Android.

eugenis marked an inline comment as done. eugenis added inline comments. Comment at: cfe/trunk/lib/Driver/ToolChains/Linux.cpp:814 +bool Linux::isPIEDefault() const { + return (getTriple().isAndroid() && !getTriple().isAndroidVersionLT(16)) || +

[PATCH] D55394: Re-order type param children of ObjC nodes

This revision was automatically updated to reflect the committed changes. Closed by commit rL351272: Re-order type param children of ObjC nodes (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r351272 - Re-order type param children of ObjC nodes

Author: steveire Date: Tue Jan 15 15:07:30 2019 New Revision: 351272 URL: http://llvm.org/viewvc/llvm-project?rev=351272=rev Log: Re-order type param children of ObjC nodes Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55394 Modified:

r351271 - NFC: Some cleanups that I missed in the previous commit

Author: steveire Date: Tue Jan 15 15:05:11 2019 New Revision: 351271 URL: http://llvm.org/viewvc/llvm-project?rev=351271=rev Log: NFC: Some cleanups that I missed in the previous commit Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL:

[PATCH] D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation

leonardchan updated this revision to Diff 181897. leonardchan marked 10 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55868/new/ https://reviews.llvm.org/D55868 Files: clang/include/clang/AST/Expr.h

[PATCH] D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation

leonardchan added a comment. In D55868#1358208 , @rjmccall wrote: > Yeah, I would recommend splitting the `APFixedPoint` in `APValue` changes > into a separate patch. Added D56746 as a child revision of this that has

Re: r351269 - Re-order overrides in FunctionDecl dump

On 15/01/2019 23:00, Aaron Ballman wrote: On Tue, Jan 15, 2019 at 5:54 PM Stephen Kelly via cfe-commits wrote: Author: steveire Date: Tue Jan 15 14:50:37 2019 New Revision: 351269 URL: http://llvm.org/viewvc/llvm-project?rev=351269=rev Log: Re-order overrides in FunctionDecl dump Output all

[PATCH] D56746: [Fixed Point Arithmetic] Add APFixedPoint to APValue

leonardchan added a comment. Regarding tests, I couldn't actually find any under clang/unittests that test APValue specifically. Is it worth it to add some still? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56746/new/ https://reviews.llvm.org/D56746

[PATCH] D56746: [Fixed Point Arithmetic] Add APFixedPoint to APValue

leonardchan created this revision. leonardchan added reviewers: rjmccall, ebevhan, bjope. leonardchan added a project: clang. This adds APFixedPoint to the union of values that can be represented with an APValue. Repository: rC Clang https://reviews.llvm.org/D56746 Files:

Re: r351269 - Re-order overrides in FunctionDecl dump

On Tue, Jan 15, 2019 at 5:54 PM Stephen Kelly via cfe-commits wrote: > > Author: steveire > Date: Tue Jan 15 14:50:37 2019 > New Revision: 351269 > > URL: http://llvm.org/viewvc/llvm-project?rev=351269=rev > Log: > Re-order overrides in FunctionDecl dump > > Output all content which is local to

[PATCH] D55083: Re-arrange content in FunctionDecl dump

This revision was automatically updated to reflect the committed changes. Closed by commit rC351269: Re-order overrides in FunctionDecl dump (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D55083?vs=181744=181892#toc Repository: rC Clang CHANGES

r351269 - Re-order overrides in FunctionDecl dump

Author: steveire Date: Tue Jan 15 14:50:37 2019 New Revision: 351269 URL: http://llvm.org/viewvc/llvm-project?rev=351269=rev Log: Re-order overrides in FunctionDecl dump Output all content which is local to the FunctionDecl before traversing to child AST nodes. This is necessary so that all of

[PATCH] D38430: Enable -pie and --enable-new-dtags by default on Android.

pcc added inline comments. Herald added a subscriber: llvm-commits. Comment at: cfe/trunk/lib/Driver/ToolChains/Linux.cpp:814 +bool Linux::isPIEDefault() const { + return (getTriple().isAndroid() && !getTriple().isAndroidVersionLT(16)) || +

r351268 - NFC: Replace iterator loop with cxx_range_for

Author: steveire Date: Tue Jan 15 14:45:46 2019 New Revision: 351268 URL: http://llvm.org/viewvc/llvm-project?rev=351268=rev Log: NFC: Replace iterator loop with cxx_range_for Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL:

Re: r351160 - [X86] Make _xgetbv/_xsetbv on non-windows platforms

any suggestions on how to proceed here? ~Craig On Tue, Jan 15, 2019 at 10:56 AM Benjamin Kramer wrote: > I think the main issue is that libstdc++ 4.9 includes x86intrin.h > transitively from . That's probably broken with all compilers :( > > On Tue, Jan 15, 2019 at 7:31 PM Craig Topper >

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

Quuxplusone added inline comments. Comment at: test/SemaCXX/cxx1z-class-template-argument-deduction.cpp:426 +// expected-warning@+1 {{class template argument deduction for 'NoExplicit' that has no user defined deduction guides}} +NoExplicit ne(42); + EricWF

[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

scott.linder added a comment. It sounds like `-fextern-visiblity=` isn't something we really want, then? I think it would have to be implemented in the abstract linkage computer. Would a patch to add an option to apply the normal visibility calculations to extern decls be reasonable, then?

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

This revision was automatically updated to reflect the committed changes. Closed by commit rL351261: [clang-tidy] add options documentation to readability-identifier-naming checker (authored by paulhoad, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r351261 - [clang-tidy] add options documentation to readability-identifier-naming checker

Author: paulhoad Date: Tue Jan 15 14:06:49 2019 New Revision: 351261 URL: http://llvm.org/viewvc/llvm-project?rev=351261=rev Log: [clang-tidy] add options documentation to readability-identifier-naming checker Summary: The documentation for this clang-checker did not explain what the options

[PATCH] D40854: [clang-tidy] WIP implement cppcoreguidelines check for mixed integer arithmetic

JonasToth updated this revision to Diff 181877. JonasToth added a comment. - Merge branch 'master' into check_mixed_arithmetic, a lot has happened... Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40854/new/ https://reviews.llvm.org/D40854 Files:

[PATCH] D56658: [MSP430] Add msp430 toochain

asl added inline comments. Comment at: cfe/trunk/lib/CodeGen/CodeGenModule.cpp:141 + (!CodeGenOpts.RelaxedAliasing && CodeGenOpts.OptimizationLevel > 0)) { +fprintf(stderr, "TBAA enabled\n"); TBAA.reset(new CodeGenTBAA(Context, TheModule, CodeGenOpts,

[PATCH] D56658: [MSP430] Add msp430 toochain

nathanchance marked an inline comment as done. nathanchance added inline comments. Comment at: cfe/trunk/lib/CodeGen/CodeGenModule.cpp:141 + (!CodeGenOpts.RelaxedAliasing && CodeGenOpts.OptimizationLevel > 0)) { +fprintf(stderr, "TBAA enabled\n"); TBAA.reset(new

Re: r351241 - CodeGen: Remove debug printf unintentionally added in r351228.

Thanks! On Wed, Jan 16, 2019 at 12:03 AM Peter Collingbourne via cfe-commits wrote: > > Author: pcc > Date: Tue Jan 15 12:59:59 2019 > New Revision: 351241 > > URL: http://llvm.org/viewvc/llvm-project?rev=351241=rev > Log: > CodeGen: Remove debug printf unintentionally added in r351228. > >

r351249 - [clang-cl] Alias /Zc:alignedNew[-] to -f[no-]aligned-allocation

Author: rnk Date: Tue Jan 15 13:24:55 2019 New Revision: 351249 URL: http://llvm.org/viewvc/llvm-project?rev=351249=rev Log: [clang-cl] Alias /Zc:alignedNew[-] to -f[no-]aligned-allocation Implements PR40180. clang-cl has one minor behavior difference with cl with this change. Clang allows the

[PATCH] D56658: [MSP430] Add msp430 toochain

asl added inline comments. Comment at: cfe/trunk/lib/CodeGen/CodeGenModule.cpp:141 + (!CodeGenOpts.RelaxedAliasing && CodeGenOpts.OptimizationLevel > 0)) { +fprintf(stderr, "TBAA enabled\n"); TBAA.reset(new CodeGenTBAA(Context, TheModule, CodeGenOpts,

[PATCH] D56663: [MSP430] Improve support of 'interrupt' attribute

krisb updated this revision to Diff 181866. krisb added a comment. Addressed feedback. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56663/new/ https://reviews.llvm.org/D56663 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/TargetInfo.cpp

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 marked 2 inline comments as done. jyu2 added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:470 +if (NS->isGCCAsmGoto() && +Exprs[ConstraintIdx]->getStmtClass() == Stmt::AddrLabelExprClass) + break; efriedma wrote: > jyu2 wrote: > >

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

aaron.ballman added inline comments. Comment at: clang/tools/libclang/CXType.cpp:132 + if (!(TU->ParsingOptions & CXTranslationUnit_IncludeAttributedTypes) && + ATT->getAttrKind() != attr::AddressSpace) { return MakeCXType(ATT->getModifiedType(), TU);

[PATCH] D56658: [MSP430] Add msp430 toochain

nathanchance added inline comments. Comment at: cfe/trunk/lib/CodeGen/CodeGenModule.cpp:141 + (!CodeGenOpts.RelaxedAliasing && CodeGenOpts.OptimizationLevel > 0)) { +fprintf(stderr, "TBAA enabled\n"); TBAA.reset(new CodeGenTBAA(Context, TheModule, CodeGenOpts,

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

ormris added a comment. Hi Ilya, This commit is causing a test failure on the PS4 bot. Could you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/42251 Thanks, Matthew Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/tools/libclang/CXType.cpp:132 + if (!(TU->ParsingOptions & CXTranslationUnit_IncludeAttributedTypes) && + ATT->getAttrKind() != attr::AddressSpace) { return

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

JonasToth added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnCheck.cpp:33 +const LangOptions ) { + // we start with the location of the closing parenthesis. + const TypeSourceInfo *TSI = F.getTypeSourceInfo(); Nit: s/we/We

r351245 - Enable IAS for OpenBSD SPARC.

Author: brad Date: Tue Jan 15 13:04:36 2019 New Revision: 351245 URL: http://llvm.org/viewvc/llvm-project?rev=351245=rev Log: Enable IAS for OpenBSD SPARC. Modified: cfe/trunk/lib/Driver/ToolChains/Gnu.cpp cfe/trunk/test/Driver/openbsd.c Modified: cfe/trunk/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/tools/libclang/CXType.cpp:132 + if (!(TU->ParsingOptions & CXTranslationUnit_IncludeAttributedTypes) && + ATT->getAttrKind() != attr::AddressSpace) { return

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 181862. jyu2 added a comment. I add additional test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Expr.h include/clang/AST/ExprCXX.h include/clang/AST/ExprObjC.h

r351241 - CodeGen: Remove debug printf unintentionally added in r351228.

Author: pcc Date: Tue Jan 15 12:59:59 2019 New Revision: 351241 URL: http://llvm.org/viewvc/llvm-project?rev=351241=rev Log: CodeGen: Remove debug printf unintentionally added in r351228. Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp

[PATCH] D56663: [MSP430] Improve support of 'interrupt' attribute

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:277-280 +def warn_msp430_interrupt_attribute : Warning< + "MSP430 'interrupt' attribute only applies to functions that have " + "%select{no parameters|a 'void' return type}0">, +

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

aaron.ballman added inline comments. Comment at: clang/tools/libclang/CXType.cpp:132 + if (!(TU->ParsingOptions & CXTranslationUnit_IncludeAttributedTypes) && + ATT->getAttrKind() != attr::AddressSpace) { return MakeCXType(ATT->getModifiedType(), TU);

[PATCH] D56663: [MSP430] Improve support of 'interrupt' attribute

krisb added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:277-280 +def warn_msp430_interrupt_attribute : Warning< + "MSP430 'interrupt' attribute only applies to functions that have " + "%select{no parameters|a 'void' return type}0">, + InGroup;

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. However, please hold off on committing this until *after* the 8.0 branch happens. While I don't expect there to be issues with this patch, it

[PATCH] D56709: Implement BlockDecl::Capture dump in terms of visitors

This revision was automatically updated to reflect the committed changes. Closed by commit rC351239: Implement BlockDecl::Capture dump in terms of visitors (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56709?vs=181751=181859#toc Repository: rC

r351239 - Implement BlockDecl::Capture dump in terms of visitors

Author: steveire Date: Tue Jan 15 12:41:37 2019 New Revision: 351239 URL: http://llvm.org/viewvc/llvm-project?rev=351239=rev Log: Implement BlockDecl::Capture dump in terms of visitors Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D56709

  1   2   3   >