[PATCH] D62282: [X86] Add ENQCMD intrinsics.

tianqing updated this revision to Diff 202856. tianqing added a comment. Added doxygen comments of intrinsics in enqcmdintrin.h. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62282/new/ https://reviews.llvm.org/D62282 Files: docs/ClangCommandLineReference.rst

[PATCH] D62839: [WIP] [clangd] Index API and implementations for relations

nridge added a comment. This isn't quite ready for a thorough review, but I have a question for now: in `BackgroundIndex::update`, there is a step where we partition symbols and references into files. For relations, should we include a copy in both the file containing the definition of the

[PATCH] D62839: [WIP] [clangd] Index API and implementations for relations

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Remaining work: - BackgroundIndex implementation - Dex implementation Repository: rG LLVM Github Monorepo

[PATCH] D62471: [clangd] SymbolCollector support for relations

This revision was automatically updated to reflect the committed changes. Closed by commit rL362467: [clangd] SymbolCollector support for relations (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

hubert.reinterpretcast added a subscriber: cfe-commits. https://reviews.llvm.org/rL358949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D62471: [clangd] SymbolCollector support for relations

nridge added a comment. In D62471#1527085 , @kadircet wrote: > LGTM, thanks! Thanks for the reviews so far! > I suppose there are only two patches left now? > > - Exposing relations in `SymbolIndex`. > - Implementing children resolution using that

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

george.burgess.iv added a comment. Will submit once gribozavr indicates that they're happy with the new test names. Thanks again for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61967/new/ https://reviews.llvm.org/D61967

[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

aheejin added a comment. Oh, can we have a test case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62830/new/ https://reviews.llvm.org/D62830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

jfb added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:5447 + +case APValue::LValue: { + LValue LVal; rsmith wrote: > jfb wrote: > > rsmith wrote: > > > This will permit bitcasts from `nullptr_t`, providing a zero value. I > > > think

[PATCH] D62835: support -march=cooperlake (clang part)

skan created this revision. skan added reviewers: craig.topper, LuoYuanke, xiangzhangllvm, pengfei. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D62835 Files: include/clang/Basic/X86Target.def

[PATCH] D62533: Build with _XOPEN_SOURCE defined on AIX

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. @daltenty, I believe that you have had a good number of patches committed into the project already (rL360898 , rL361410

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

jcai19 marked an inline comment as done. jcai19 added a comment. Thanks for all the comments. george.burgess.iv will submit this change for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61967/new/ https://reviews.llvm.org/D61967

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

jcai19 updated this revision to Diff 202835. jcai19 added a comment. Update the test function names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61967/new/ https://reviews.llvm.org/D61967 Files:

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:5447 + +case APValue::LValue: { + LValue LVal; jfb wrote: > rsmith wrote: > > This will permit bitcasts from `nullptr_t`, providing a zero value. I think > > that's wrong; the bit

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 202833. jkorous added a comment. linux implementation - factory method for SemaphorePipe - *_CLOEXEC flags CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files:

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous marked 3 inline comments as done. jkorous added a comment. I fixed the rest. There are still some questions you raised that I just responded to and kept them as not Done. Feel free to take a look. If nothing comes up I'll commit this on Wednesday. Comment at:

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 updated this revision to Diff 202832. jcai19 added a comment. Fix a typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62049/new/ https://reviews.llvm.org/D62049 Files: clang-tools-extra/clang-tidy/android/AndroidTidyModule.cpp

[PATCH] D43226: __threading_support: Remove (void) in favor of ().

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This looks fine to me. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43226/new/ https://reviews.llvm.org/D43226

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 marked 4 inline comments as done. jcai19 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp:20 + pipe2(pipefd, O_NONBLOCK); + // CHECK-MESSAGES: :[[@LINE-1]]:27: warning: 'pipe2' should use O_CLOEXEC where possible

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 updated this revision to Diff 202830. jcai19 added a comment. Update description based on comments and remove CHECK-MESSAGES-NOT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62049/new/ https://reviews.llvm.org/D62049 Files:

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

beanz added a comment. I have a thought for how we can make the CMake interface for this better. Instead of `LLVM_EXTENSIONS` being a global property if it were a pre-defined list like `LLVM_ALL_PROJECTS`, then the `LLVM_LINK__INTO_TOOLS` variables can be generated by LLVM's configuration

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

jfb added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:5447 + +case APValue::LValue: { + LValue LVal; rsmith wrote: > This will permit bitcasts from `nullptr_t`, providing a zero value. I think > that's wrong; the bit representation of

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:37 +void DynamicStaticInitializersCheck::registerMatchers(MatchFinder *Finder) { + // FIXME: Add matchers. + if (!getLangOpts().CPlusPlus)

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

rsmith added a comment. Can we also use the same bit reader/writer implementation to generalize the current implementation of `__builtin_memcpy` and friends? (I don't think we can remove the existing implementation, sadly, since we allow copying arrays of the same trivially-copyable type today

[PATCH] D62643: [CodeGen][ObjC] Convert '[self alloc]' in a class method to 'objc_alloc(self)'

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. I thinks this looks good, aside from a null concern. Comment at: lib/CodeGen/CGObjC.cpp:460 + const Expr *SelfInClassMethod = nullptr; + if (const auto

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

jfb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9716 +def err_bit_cast_non_trivially_copyable : Error< + "__builtin_bit_cast %select{source|destination}0 type must be a trivially copyable">; +def err_bit_cast_type_size_mismatch : Error<

[PATCH] D61729: [docs] Fix example for Allman brace breaking style

jkorous added a comment. Thanks, I didn't know it's generated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61729/new/ https://reviews.llvm.org/D61729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61729: [docs] Fix example for Allman brace breaking style

jkorous updated this revision to Diff 202827. jkorous added a comment. Fix in the header file from which the documentation is actually generated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61729/new/ https://reviews.llvm.org/D61729 Files: clang/docs/ClangFormatStyleOptions.rst

r362464 - Add a release note entry for the change made in r362034.

Author: ahatanak Date: Mon Jun 3 16:48:14 2019 New Revision: 362464 URL: http://llvm.org/viewvc/llvm-project?rev=362464=rev Log: Add a release note entry for the change made in r362034. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL:

[PATCH] D62533: Build with _XOPEN_SOURCE defined on AIX

daltenty updated this revision to Diff 202822. daltenty added a comment. Fix grammar in comments. Fix up the way we define the macros for Google Test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62533/new/ https://reviews.llvm.org/D62533 Files:

[PATCH] D62643: [CodeGen][ObjC] Convert '[self alloc]' in a class method to 'objc_alloc(self)'

ahatanak updated this revision to Diff 202821. ahatanak marked an inline comment as done. ahatanak added a comment. Just set `isClassMessage` instead of passing a separate flag to `tryGenerateSpecializedMessageSend`. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:7762-7787 // Ensure none of the TypoExprs have multiple typo correction candidates // with the same edit length that pass all the checks and filters. //

[PATCH] D62831: [CodeGen][ObjC] Add attribute "arc_retain_agnostic" to ObjC globals that are retain-agnostic

ahatanak created this revision. ahatanak added reviewers: rjmccall, erik.pilkington, pete, gottesmm. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. This is needed to enable the optimization in this patch: https://reviews.llvm.org/D62433 Repository: rC Clang

[PATCH] D62133: test/CodeGen/builtin-stackaddress.c duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL362462: Remove test/CodeGen/builtin-stackaddress.c as it duplicates (authored by echristo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62133: test/CodeGen/builtin-stackaddress.c duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c

echristo added a comment. done thusly: echristo@jhereg ~/s/llvm-project> git llvm push Pushing 1 commit: d91813ca8c7 Remove test/CodeGen/builtin-stackaddress.c as it duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c. Deleting cfe/trunk/test/CodeGen/builtin-stackaddress.c

r362463 - Fix windows build for commit r362459

Author: arphaman Date: Mon Jun 3 16:17:21 2019 New Revision: 362463 URL: http://llvm.org/viewvc/llvm-project?rev=362463=rev Log: Fix windows build for commit r362459 Modified: cfe/trunk/lib/Lex/DependencyDirectivesSourceMinimizer.cpp Modified:

r362462 - Remove test/CodeGen/builtin-stackaddress.c as it duplicates

Author: echristo Date: Mon Jun 3 16:16:06 2019 New Revision: 362462 URL: http://llvm.org/viewvc/llvm-project?rev=362462=rev Log: Remove test/CodeGen/builtin-stackaddress.c as it duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c. Differential Revision:

[PATCH] D62830: [WebAssembly] Support Leak Sanitizer on Emscripten

quantum created this revision. quantum added reviewers: tlively, aheejin. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. LSan is currently being ported to Emscripten and mostly works. Enabling the support in upstream would

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rL362459: Add clang source minimizer that reduces source to directives (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62829: [clang-tidy] Check for dynamically initialized statics in headers.

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp:40 +return; + Finder->addMatcher(varDecl().bind("var"), this); +} Most of the matching should be done here, not in `check()`.

r362459 - Add clang source minimizer that reduces source to directives

Author: arphaman Date: Mon Jun 3 15:59:17 2019 New Revision: 362459 URL: http://llvm.org/viewvc/llvm-project?rev=362459=rev Log: Add clang source minimizer that reduces source to directives that might affect the dependency list for a compilation This commit introduces a dependency directives

[PATCH] D62780: msabi: Fix exponential mangling time for even more contrived inputs

thakis marked an inline comment as done. thakis added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:819-823 ArgBackRefMap::iterator Found = TemplateArgBackReferences.find(ND); if (Found == TemplateArgBackReferences.end()) { - // Mangle full

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, jfb, rjmccall. Herald added subscribers: llvm-commits, kristina, arphaman, dexonsmith, jkorous, hiraditya. Herald added projects: clang, LLVM. http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0476r2.html

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur requested changes to this revision. Meinersbur added a comment. This revision now requires changes to proceed. It still fails with the same error. `LINK_POLLY_INTO_TOOLS` is only set after the polly subdirectory is processed. Because it is an `option`, the ON value will be stored in

[PATCH] D62557: [analyzer] Modernize CStringChecker to use CallDescriptions.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62557/new/ https://reviews.llvm.org/D62557 ___

[PATCH] D62556: [analyzer] NFC: CallDescription: Implement describing C library functions.

a_sidorin added a comment. Hi Artem, Looks mostly good, but I have some comments inline. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1064 // e.g. "{a, b}" represent the qualified names, like "a::b". std::vector QualifiedName;

[PATCH] D60691: [ARM] Replace fp-only-sp and d16 with fp64 and d32.

JamesNagurne added a comment. Hi Simon et. al., I'm working on a downstream ARM toolchain and have downstreamed this change into our codebase. We saw that you've fixed the -mfpu=none issue and have taken that as well, but are still running into some issues. Prior to your change, the optionset

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

philip.pfaffe added a subscriber: beanz. philip.pfaffe added a comment. I fear you'll need to plan at least for new pm right now. Otherwise your change will be obsolete in half a year. What is it really that LINK_X_INTO_TOOLS is supposed to do? Effectively bake in something that's consumable by

[PATCH] D60974: Clang IFSO driver action.

alexshap added inline comments. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:30 +uint8_t Binding; +MangledSymbol() = delete; +MangledSymbol(const std::string , const std::string , would be nice to have a newline before the ctor

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 202795. serge-sans-paille added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - provide minimal documentation - fix testing configuration - validate locally with both shared and static libraries, using monorepo or

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh updated this revision to Diff 202790. lildmh edited the summary of this revision. lildmh added a comment. Implement the new mapper codegen scheme CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59474/new/ https://reviews.llvm.org/D59474 Files: include/clang/AST/GlobalDecl.h

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ added a comment. I disabled tests on Windows for now (rC362343 -> rC362347 ), but other than that the tests are working well, there was nothing to worry about. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

rsmith added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:7762-7787 // Ensure none of the TypoExprs have multiple typo correction candidates // with the same edit length that pass all the checks and filters. // TODO: Properly handle various permutations

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

gtbercea added a comment. Could you check what the difference is between the same kernel in today's SPMD mode vs the SPMD mode produced via this method? Number of registers, instructions, checking everything gets optimized out as expected. The LLVM-IR should be almost identical. Repository:

r362443 - Fix test failure from r362435

Author: erichkeane Date: Mon Jun 3 12:57:52 2019 New Revision: 362443 URL: http://llvm.org/viewvc/llvm-project?rev=362443=rev Log: Fix test failure from r362435 Apparently I forgot to do an open brace in a namespace, so we get an error about an extra closing brace. Modified:

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

gtbercea added a comment. Could you add some tests for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59319/new/ https://reviews.llvm.org/D59319 ___ cfe-commits mailing list

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

gtbercea added a comment. Could you check if there is any change in the number of registers new scheme vs. old scheme? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59424/new/ https://reviews.llvm.org/D59424

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 202775. dgoldman marked an inline comment as done. dgoldman added a comment. - Fix discarded correction test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files:

Re: r362005 - Fix an unused-variable error.

If this is the only use of 'S', might be better/good to roll the expression into the assertion? On Wed, May 29, 2019 at 11:33 AM Haojian Wu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hokein > Date: Wed May 29 11:36:54 2019 > New Revision: 362005 > > URL:

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:7713-7714 + // Add the newly created typos to the TypoExprs list, even if they + // failed to apply. This allows them to be reaped although they

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 202772. dgoldman added a comment. - Fix diagnostics for ignored TypoExprs Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp

Re: [PATCH] D62133: test/CodeGen/builtin-stackaddress.c duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c

Will do. On Sun, Jun 2, 2019 at 5:43 AM A. Skrobov via Phabricator wrote: > > t.yomitch added a comment. > > Thanks Eric! > I don't have commit access; could someone please commit this for me? > > > Repository: > rC Clang > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D62133/new/ >

[PATCH] D62780: msabi: Fix exponential mangling time for even more contrived inputs

rnk added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:819-823 ArgBackRefMap::iterator Found = TemplateArgBackReferences.find(ND); if (Found == TemplateArgBackReferences.end()) { - // Mangle full template name into temporary buffer. -

r362435 - Make NoThrow FunctionLike, make FunctionLike include references, fix

Author: erichkeane Date: Mon Jun 3 11:36:33 2019 New Revision: 362435 URL: http://llvm.org/viewvc/llvm-project?rev=362435=rev Log: Make NoThrow FunctionLike, make FunctionLike include references, fix prettyprint __declspec(nothrow) should work on function pointers as well as function

r362434 - Permit Exception Spec mismatch with NoThrow on inherited Virtual

Author: erichkeane Date: Mon Jun 3 11:36:26 2019 New Revision: 362434 URL: http://llvm.org/viewvc/llvm-project?rev=362434=rev Log: Permit Exception Spec mismatch with NoThrow on inherited Virtual As reported here: https://bugs.llvm.org/show_bug.cgi?id=42100 This fairly common pattern ends up

[PATCH] D62574: Initial draft of target-configurable address spaces.

Anastasia added a comment. In D62574#1527126 , @ebevhan wrote: > In D62574#1523835 , @Anastasia wrote: > > > > This patch does not address the issue with the accessors > > > on Qualifiers

[PATCH] D62623: Reduce memory consumption of coverage dumps

vsk added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1393 + size_t CoverageMappingSize = 0; + for (auto : CoverageMappings) { +CoverageMappingSize += S.size(); It doesn't look like the CoverageMappings std::vector is needed at

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

thakis added a comment. From what I can tell, the only client of OpenCLBuiltins.td is currently lib/Sema. Do you expect that to change? If not, does it make more sense to move the .td file to there? Do you expect OpenCLBuiltins.td to include other files in the future? At the moment, the `-I

[PATCH] D62730: [RFC] Alternate implementation of D53157 IRBuilder for Constrained FP using enumeration vs MDNode and add support for fp-model and fp-speculation language options

mibintc abandoned this revision. mibintc added a comment. I'm abandoning this patch in deference to @kpn 's patch under review D53157 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62730/new/ https://reviews.llvm.org/D62730

Re: r356569 - [NFC][clang][astdump] Some baseline tests for OpenMP

On Fri, 31 May 2019 at 16:20, Roman Lebedev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Sat, Jun 1, 2019 at 2:00 AM Richard Smith > wrote: > > > > These are change detector tests ( > https://testing.googleblog.com/2015/01/testing-on-toilet-change-detector-tests.html) > and create a

[PATCH] D62440: [analyzer] NFC: Change evalCall() to provide a CallEvent.

Szelethus accepted this revision. Szelethus added a comment. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62440/new/ https://reviews.llvm.org/D62440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/TreeTransform.h:5363 +if (ResultType.getAddressSpace() != LangAS::Default && +(ResultType.getAddressSpace() != LangAS::opencl_private)) {

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia added a comment. In D62584#1522438 , @rjmccall wrote: > I think the right approach here is probably to make sure you're applying > deduction during instantiation as well. I agree I think we might need to extend the template instantiation

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia updated this revision to Diff 202753. Anastasia retitled this revision from "[OpenCL][PR42033] Deducing addr space of pointer/reference with template parameter types" to "[OpenCL][PR42033] Deducing addr space with template parameter types". Anastasia edited the summary of this

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

ilya-biryukov added a comment. Do we care about pointers or references to lambda types? Comment at: clang-tools-extra/clangd/XRefs.cpp:662 + if (const DecltypeType *DT = + llvm::dyn_cast(VD->getType().getTypePtr())) +if

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/BuildTree.h:11 +// +// The code is divided in the following way: +// - 'Tree/Cascade.h' defines the basic structure of the syntax tree, This needs an update, will do in the

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov added a comment. I've addressed most of the comments, except the naming ones. We need a convention for naming the language nodes and names for composite and leaf structural nodes. For "language" nodes, I suggest we use `CompoundStatement`, `Recovery`, `TopLevelDeclaration`,

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov updated this revision to Diff 202745. ilya-biryukov marked 24 inline comments as done. ilya-biryukov added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet updated this revision to Diff 202739. kadircet added a comment. - Get rid of wrong check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://reviews.llvm.org/D62814 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62814 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

xingxue updated this revision to Diff 202734. xingxue added a comment. Addressed comments: - Fixed typo _XOPEN_SOUECE->_XOPEN_SOURCE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59253/new/ https://reviews.llvm.org/D59253 Files:

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

xingxue marked 2 inline comments as done. xingxue added inline comments. Comment at: libcxx/test/std/depr/depr.c.headers/stdint_h.sh.cpp:21 +// Test that limits macros are available when is included with +// or without macro _XOPEN_SOUECE=700. +

r362410 - Re-check in clang support gun asm goto after fixing tests.

Author: jyu2 Date: Mon Jun 3 08:57:25 2019 New Revision: 362410 URL: http://llvm.org/viewvc/llvm-project?rev=362410=rev Log: Re-check in clang support gun asm goto after fixing tests. Added: cfe/trunk/test/Analysis/asm-goto.cpp cfe/trunk/test/CodeGen/asm-goto.c

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM with minor comment. Comment at: libcxx/test/std/depr/depr.c.headers/stdint_h.sh.cpp:21 +// Test that limits macros are available when is included with +// or without macro

[PATCH] D62299: [PR41567][Sema] Fixed cast kind in addr space conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rL362409: [PR41567][Sema] Fixed cast kind in addr space conversions (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r362409 - [PR41567][Sema] Fixed cast kind in addr space conversions

Author: stulova Date: Mon Jun 3 08:42:36 2019 New Revision: 362409 URL: http://llvm.org/viewvc/llvm-project?rev=362409=rev Log: [PR41567][Sema] Fixed cast kind in addr space conversions This change sets missing cast kind correctly in the address space conversion case. Differential Revision:

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

lebedev.ri added a comment. In D48866#1527506 , @steakhal wrote: > The problem with the `-Wcast-align` is that it will only fire for C-style > bitcast expressions, not for `reinterpret_cast` ones. example > > Does anyone

[PATCH] D62445: [test] Fix plugin tests

hintonda added a comment. In D62445#1527368 , @davezarzycki wrote: > This broke non-PIC builds. Fixed: r362399 Sorry for the breakage, and thanks for the fix! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62445/new/

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

steakhal added a comment. The problem with the `-Wcast-align` is that it will only fire for C-style bitcast expressions, not for `reinterpret_cast` ones. example Does anyone know why is that behavior? CHANGES SINCE LAST ACTION

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

lebedev.ri added a comment. Also, this kinda feels like this shouldn't be a single check. 1. I'm very much looking forward the alignment part of this, the `reinterpret_cast<>()` specifically. It would be good to have a switch to also diagnose casts from `void*` here. But indeed, if it comes

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Anastasia added inline comments. Comment at: clang/test/CodeGenSYCL/device-functions.cpp:24 +} +// CHECK: define spir_func void @{{.*}}foo +// CHECK: define linkonce_odr spir_func i32 @{{.*}}bar Fznamznon wrote: > Anastasia wrote: > > Fznamznon wrote: > > >

[PATCH] D50989: Remove Darwin support from POWER backend.

kbarton closed this revision. kbarton added a comment. Herald added a subscriber: jsji. This landed in https://reviews.llvm.org/rL340770. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50989/new/ https://reviews.llvm.org/D50989 ___

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert marked an inline comment as done. aaronpuchert added a comment. In D59673#1521413 , @dblaikie wrote: > Might be easier as a few patches - renaming the existing option, adding the > new one, then removing the single split dwarf flag handling

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

lebedev.ri added a comment. Some basic thoughts Comment at: clang-tools-extra/clang-tidy/bugprone/IncorrectPointerCastCheck.cpp:63 + "cast from %0 to %1 may lead to access memory based on invalid memory " + "layout; pointed to type is wider than the allocated

[PATCH] D62591: [OpenCL][PR42031] Prevent deducing addr space in type alias.

Anastasia added a comment. @mantognini Good spot! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62591/new/ https://reviews.llvm.org/D62591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62591: [OpenCL][PR42031] Prevent deducing addr space in type alias.

Anastasia updated this revision to Diff 202721. Anastasia added a comment. - Exclude pointee from early return in addr space deduction - Improved testing: added FileCheck and avoid testing unnecessary bits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62591/new/

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

steakhal updated this revision to Diff 202717. steakhal added a comment. Unfortunately the changes that I've made are not available in a diff because I've moved to the monorepo version. Although, you can see the changes in detail on my llvm-project github fork

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

steakhal commandeered this revision. steakhal added a reviewer: hgabii. steakhal added a comment. If you don't mind I will finish the leftover work. This will still be committed under your name. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 added a comment. Consider other Systems (e.g Darwin, PS4 and FreeBSD) don't want to spend any effort dealing with the ramifications of ABI breaks (as discussed in https://reviews.llvm.org/D60748) at present, I only fix the bug for Linux. If other system wants the fix, the only thing

[PATCH] D62782: Fix -Wdouble-promotion warnings.

mclow.lists added a comment. This looks fine to me; but where were you getting these warnings? Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62782/new/ https://reviews.llvm.org/D62782 ___ cfe-commits mailing list

  1   2   >