[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

mattdr marked an inline comment as done. mattdr added inline comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:366 +std::vector TrimmedNodes(TrimNodes.size()); +for (size_type I = 0; I < TrimNodes.size(); ++I) { + TrimmedNodes[I] = TrimmedNodesSoFar;

[PATCH] D76896: [clangd] Color dependent names based on their heuristic target if they have one

nridge updated this revision to Diff 257596. nridge added a comment. Address final review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76896/new/ https://reviews.llvm.org/D76896 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D76896: [clangd] Color dependent names based on their heuristic target if they have one

This revision was automatically updated to reflect the committed changes. Closed by commit rGd83541d1b8f7: [clangd] Color dependent names based on their heuristic target if they have one (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D76896?vs=257596=257597#toc

[clang-tools-extra] d83541d - [clangd] Color dependent names based on their heuristic target if they have one

Author: Nathan Ridge Date: 2020-04-15T00:57:08-04:00 New Revision: d83541d1b8f75ff44083c8ba1dba1ca7bac330cf URL: https://github.com/llvm/llvm-project/commit/d83541d1b8f75ff44083c8ba1dba1ca7bac330cf DIFF: https://github.com/llvm/llvm-project/commit/d83541d1b8f75ff44083c8ba1dba1ca7bac330cf.diff

Buildbot numbers for the week of 04/05/2020 - 04/11/2020

Hello everyone, Below are some buildbot numbers for the last week of 04/05/2020 - 04/11/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 03/29/2020 - 04/4/2020

Hello everyone, Below are some buildbot numbers for the week of 03/29/2020 - 04/4/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the week of 03/22/2020 - 03/28/2020

Hello everyone, Below are some buildbot numbers for the week of 03/22/2020 - 03/28/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:688 + +op = castE; } ekatz wrote: > rjmccall wrote: > > ekatz wrote: > > > rjmccall wrote: > > > > I liked the structure of the old code better, in case we want to look > > > >

[PATCH] D78163: [AVR][NFC] Move preprocessor tests to Preprocessor directory

rjmccall added a comment. Looks like the established convention would be to just put these tests in `test/Preprocessor` with an `avr-` prefix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78163/new/ https://reviews.llvm.org/D78163

[PATCH] D78125: [AVR] Use the correct address space for non-prototyped function calls

rjmccall added inline comments. Comment at: clang/test/CodeGen/address-space-avr.c:3 + +// CHECK: define void @bar() addrspace(1) +// CHECK: call addrspace(1) void bitcast (void (...) addrspace(1)* @foo to void (i16) addrspace(1)*)(i16 3) MaskRay wrote: > Add a

[PATCH] D78172: [www] Update make_cxx_dr_status for v10; regenerate cxx_dr_status.html

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/www/cxx_dr_status.html:11246 https://wg21.link/cwg1905;>1905 -MAD Dependent types and injected-class-names Haha :)

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

rsmith accepted this revision. rsmith marked an inline comment as done. rsmith added a comment. This revision is now accepted and ready to land. Thanks! I'm happy for you to go ahead landing patches that implement the direction documented here. (Let me know if you want me to review them anyway,

[PATCH] D74813: [RFC] Add hash of block contents to function block names

dexonsmith added a comment. In D74813#1982089 , @alexbdv wrote: > @erik.pilkington / @vsk / @dexonsmith - how block name = > hash(parent_function_name + block_type) ? > So any blocks that are inside the same parent function + have the same type > will

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz marked an inline comment as done. ekatz added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:688 + +op = castE; } rjmccall wrote: > ekatz wrote: > > rjmccall wrote: > > > I liked the structure of the old code better, in case we want to

[PATCH] D77754: [MS] Fix packed struct layout for arrays of aligned non-record types

This revision was automatically updated to reflect the committed changes. Closed by commit rG8da5b9083691: [MS] Fix packed struct layout for arrays of aligned non-record types (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77923: OpenCL: Fix some missing predefined macros

yaxunl added a comment. In D77923#1981698 , @jvesely wrote: > does passing `-U__OPENCL_VERSION__ -D __OPENCL_VERSION__=x.y` on the > commadline work as well? the header trick was my fallback path. Yes the command line option -U or -D override

[clang] 8da5b90 - [MS] Fix packed struct layout for arrays of aligned non-record types

Author: Reid Kleckner Date: 2020-04-14T18:34:52-07:00 New Revision: 8da5b9083691b557f50f72ab099598bb291aec5f URL: https://github.com/llvm/llvm-project/commit/8da5b9083691b557f50f72ab099598bb291aec5f DIFF: https://github.com/llvm/llvm-project/commit/8da5b9083691b557f50f72ab099598bb291aec5f.diff

[PATCH] D77989: Allow disabling of vectorization using internal options

This revision was automatically updated to reflect the committed changes. Closed by commit rG33ffb62e23e7: Allow disabling of vectorization using internal options (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77989/new/

[PATCH] D76646: Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76646/new/ https://reviews.llvm.org/D76646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 33ffb62 - Allow disabling of vectorization using internal options

Author: Teresa Johnson Date: 2020-04-14T18:09:10-07:00 New Revision: 33ffb62e23e7a7bece5618d5a7b54bdb401d0bcf URL: https://github.com/llvm/llvm-project/commit/33ffb62e23e7a7bece5618d5a7b54bdb401d0bcf DIFF:

[PATCH] D78171: Rework how UuidAttr, CXXUuidofExpr, and GUID template arguments and constants are represented.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm There's a lot of stuff going on here, and I didn't review that deeply. Let me know if you want a closer reading of the code. Comment at:

[PATCH] D78125: [AVR] Use the correct address space for non-prototyped function calls

aykevl added a comment. In D78125#1982471 , @MaskRay wrote: > > This fix is necessary to let Clang compile compiler-rt for AVR. > > This suggests that some compiler-rt declarations do not follow the best > practice... What are they? The calls come from

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi updated this revision to Diff 257577. plotfi added a comment. Update for clang-format changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233 Files: clang/include/clang/AST/DeclObjC.h

[PATCH] D78172: [www] Update make_cxx_dr_status for v10; regenerate cxx_dr_status.html

hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added inline comments. Comment at: clang/www/cxx_dr_status.html:14486 +https://wg21.link/cwg2445;>2445 + +Partial ordering with rewritten candidates The status is blank

[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78162/new/ https://reviews.llvm.org/D78162

[PATCH] D78068: [www] Turn 'Clang 10' boxes green in C++ status pages to reflect release

hubert.reinterpretcast marked 3 inline comments as done. hubert.reinterpretcast added inline comments. Comment at: clang/www/cxx_dr_status.html:3 "http://www.w3.org/TR/html4/strict.dtd;> hubert.reinterpretcast wrote: > rsmith wrote: > > Please

[PATCH] D78172: [www] Update make_cxx_dr_status for v10; regenerate cxx_dr_status.html

hubert.reinterpretcast created this revision. hubert.reinterpretcast added a reviewer: rsmith. Herald added a project: clang. hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added inline comments. Comment at: clang/www/cxx_dr_status.html:14486 +

[PATCH] D78171: Rework how UuidAttr, CXXUuidofExpr, and GUID template arguments and constants are represented.

rsmith created this revision. rsmith added a reviewer: rnk. rsmith added a project: clang. Herald added a subscriber: arphaman. Herald added a reviewer: jdoerfert. rsmith added a comment. There are a few cleanups I made along the way here that I'll be factoring out and committing separately.

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur marked an inline comment as done. Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784 +/// This represents the '#pragma omp tile' loop transformation directive. +class OMPTileDirective final +: public OMPLoopDirective, +

[PATCH] D78125: [AVR] Use the correct address space for non-prototyped function calls

MaskRay added a comment. > This fix is necessary to let Clang compile compiler-rt for AVR. This suggests that some compiler-rt declarations do not follow the best practice... What are they? Comment at: clang/test/CodeGen/address-space-avr.c:3 + +// CHECK: define void @bar()

[PATCH] D78171: Rework how UuidAttr, CXXUuidofExpr, and GUID template arguments and constants are represented.

rsmith added a comment. There are a few cleanups I made along the way here that I'll be factoring out and committing separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78171/new/ https://reviews.llvm.org/D78171

[PATCH] D78068: [www] Turn 'Clang 10' boxes green in C++ status pages to reflect release

hubert.reinterpretcast added inline comments. Comment at: clang/www/cxx_dr_status.html:3 "http://www.w3.org/TR/html4/strict.dtd;> rsmith wrote: > Please heed this comment, and check in a matching change to > `make_cxx_dr_status` =) Thanks for

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

rjmccall added a comment. In D78134#1982291 , @rsmith wrote: > In D78134#1981866 , @rsmith wrote: > > > I'm going to take this to CWG. > > > So far, the direction the wind is blowing is that attempting to perform

[PATCH] D77989: Allow disabling of vectorization using internal options

tejohnson updated this revision to Diff 257562. tejohnson added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77989/new/ https://reviews.llvm.org/D77989 Files: clang/test/CodeGen/thinlto-loop-vectorize-pm.c

[PATCH] D77989: Allow disabling of vectorization using internal options

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7618-7621 +: InterleaveOnlyWhenForced(Opts.InterleaveOnlyWhenForced | + !EnableLoopInterleaving), +

[PATCH] D78125: [AVR] Use the correct address space for non-prototyped function calls

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. WFM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78125/new/ https://reviews.llvm.org/D78125

[PATCH] D78000: [ASTImporter] Fix handling of not defined FromRecord in ImportContext(...)

shafik updated this revision to Diff 257552. shafik marked 4 inline comments as done. shafik added a comment. Addressing comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78000/new/ https://reviews.llvm.org/D78000 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D78068: [www] Turn 'Clang 10' boxes green in C++ status pages to reflect release

rsmith added inline comments. Comment at: clang/www/cxx_dr_status.html:3 "http://www.w3.org/TR/html4/strict.dtd;> Please heed this comment, and check in a matching change to `make_cxx_dr_status` =) Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi updated this revision to Diff 257550. plotfi added a comment. Adding a kind_ prefix to avoid any keywords being used in the ObjCPropertyAttribute enum. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

tentzen added a comment. In D77982#1981505 , @efriedma wrote: > Searching LocalDeclMap is less problematic, I guess... but still, it should > be possible to something more straightforward. Maybe make > startOutlinedSEHHelper store the actual

[PATCH] D78163: [AVR][NFC] Move preprocessor tests to Preprocessor directory

MaskRay added a comment. Not sure we need `target-cpu-defines/` You can add a `lit.local.cfg` to avoid `REQUIRES: avr-registered-target` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78163/new/ https://reviews.llvm.org/D78163

[PATCH] D78125: [AVR] Use the correct address space for non-prototyped function calls

aykevl updated this revision to Diff 257548. aykevl added a comment. Update to use the function pointer address space from the function declaration. (This is slightly different from what @rjmccall suggested but I think this is more readable). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

MaskRay added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:266 + const auto BeginningOfTimeUs = SystemTime - ProcessLocalTime; + J.attribute("beginningOfTime", + BeginningOfTimeUs.time_since_epoch().count());

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

rsmith added a comment. In D78134#1981866 , @rsmith wrote: > I'm going to take this to CWG. So far, the direction the wind is blowing is that attempting to perform an lvalue-to-rvalue conversion on an array should be a no-op. (That's weirdly different

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper updated this revision to Diff 257549. craig.topper added a comment. Merge in test case from D77431 since it logically belongs with these changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75936/new/ https://reviews.llvm.org/D75936

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

rsmith added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:749-750 +/// The set of the included headers' UID for the submodule. +std::set IncludedFiles; + A `std::set` is a very heavy object to be copying each time a module is

[PATCH] D77431: [X86] Add tests to clang Driver to ensure that SLH/Retpoline features are not enabled with LVI-hardening

craig.topper commandeered this revision. craig.topper edited reviewers, added: sconstab; removed: craig.topper. craig.topper added a comment. Merged into D75936 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77431/new/ https://reviews.llvm.org/D77431

[PATCH] D78117: [AVR] Define __ELF__

aykevl added a comment. Okay, I have committed this patch and created a new patch to move the files: https://reviews.llvm.org/D78163 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78117/new/ https://reviews.llvm.org/D78117

[PATCH] D78163: [AVR][NFC] Move preprocessor tests to Preprocessor directory

aykevl created this revision. aykevl added reviewers: dylanmckay, rjmccall, MaskRay. Herald added subscribers: cfe-commits, Jim. Herald added a project: clang. MaskRay added a comment. Not sure we need `target-cpu-defines/` You can add a `lit.local.cfg` to avoid `REQUIRES: avr-registered-target`

[PATCH] D78068: [www] Turn 'Clang 10' boxes green in C++ status pages to reflect release

This revision was automatically updated to reflect the committed changes. Closed by commit rG021a333bfca3: [www] Turn Clang 10 boxes green in C++ status pages to reflect release (authored by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78117: [AVR] Define __ELF__

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe06e231ff15: [AVR] Define __ELF__ (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78117/new/ https://reviews.llvm.org/D78117 Files:

[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

george.burgess.iv created this revision. george.burgess.iv added reviewers: efriedma, serge-sans-paille. george.burgess.iv added a project: clang. Herald added a subscriber: cfe-commits. This suboptimality was encountered in Linux (see some discussion on D71082 ,

[clang] 021a333 - [www] Turn 'Clang 10' boxes green in C++ status pages to reflect release

Author: Hubert Tong Date: 2020-04-14T18:38:35-04:00 New Revision: 021a333bfca363ecb672d22dcff6295d4ecee3b7 URL: https://github.com/llvm/llvm-project/commit/021a333bfca363ecb672d22dcff6295d4ecee3b7 DIFF: https://github.com/llvm/llvm-project/commit/021a333bfca363ecb672d22dcff6295d4ecee3b7.diff

[clang] fe06e23 - [AVR] Define __ELF__

Author: Ayke van Laethem Date: 2020-04-15T00:22:53+02:00 New Revision: fe06e231ff1536e7d0a99551590f6de5a38ce23a URL: https://github.com/llvm/llvm-project/commit/fe06e231ff1536e7d0a99551590f6de5a38ce23a DIFF:

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv added a comment. @erik.pilkington / @vsk / @dexonsmith - how block name = hash(parent_function_name + block_type) ? So any blocks that are inside the same parent function + have the same type will get an incremental number to de-duplicate names. CHANGES SINCE LAST ACTION

[PATCH] D76896: [clangd] Color dependent names based on their heuristic target if they have one

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:211 NonConflicting.push_back(TokRef.front()); + else if (auto Resolved =

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:607 + FeatureSVE + ]>; + Not sure how accurate the link you referenced is, but it doesn't mention SVE or Crypto

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv updated this revision to Diff 257508. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 Files: clang/include/clang/AST/Mangle.h clang/lib/AST/Mangle.cpp clang/lib/CodeGen/CGBlocks.cpp clang/lib/CodeGen/CGDecl.cpp

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:688 + +op = castE; } ekatz wrote: > rjmccall wrote: > > I liked the structure of the old code better, in case we want to look > > through other kinds of expressions. Please just

[PATCH] D78131: [SVE] Fix unsigned is always >= 0

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM, thanks for fixing @ctetreau! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78131/new/ https://reviews.llvm.org/D78131

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

sammccall added a comment. In D78100#1981729 , @rsmith wrote: > In D78100#1981620 , @sammccall wrote: > > > Sorry to go back and forth on this, but I'm not sure whether these > > diagnostics are actually spam to

[PATCH] D78148: [CodeGen] make isTriviallyRecursive handle more trivial recursion

george.burgess.iv abandoned this revision. george.burgess.iv added a comment. Nothing in the real world :) I was writing test-cases for a soon-to-be-in-your-inbox patch, and initially wrote `memcpy` recursion in terms of `memcpy`, rather than `__builtin_memcpy`. Wasn't sure if this was an

[PATCH] D77989: Allow disabling of vectorization using internal options

wmi accepted this revision. wmi added a comment. This revision is now accepted and ready to land. There is a comment about the bitwise operator, otherwise LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77989/new/

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: llvm/include/llvm/BinaryFormat/Dwarf.def:915 HANDLE_DW_APPLE_PROPERTY(0x2000, null_resettable) HANDLE_DW_APPLE_PROPERTY(0x4000, class) I have some concerns here too. How would

[clang] 91c8c74 - [CodeGen] clarify a comment; NFC

Author: George Burgess IV Date: 2020-04-14T14:33:01-07:00 New Revision: 91c8c74180ced4b82da02f2544f3978f72003d37 URL: https://github.com/llvm/llvm-project/commit/91c8c74180ced4b82da02f2544f3978f72003d37 DIFF:

[PATCH] D78148: [CodeGen] make isTriviallyRecursive handle more trivial recursion

efriedma added a comment. Could you go into a little more detail what problem you're trying to resolve? isTriviallyRecursive is specifically a narrow hack to handle weird cases where a function is trying to hide the fact that it's calling itself, in ways that would convince gcc that the called

[PATCH] D78155: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in wrapper headers

jdoerfert created this revision. jdoerfert added reviewers: tra, hfinkel. Herald added subscribers: guansong, bollu, yaxunl. Herald added a project: clang. Due to recent changes we cannot use OpenMP in CUDA files anymore (PR45533) as the math handling of CUDA is different when _OPENMP is defined.

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper updated this revision to Diff 257488. craig.topper marked an inline comment as done. craig.topper added a comment. Fix some mistakes I made in the previous upload where I accidentally deleted the pipeline tests instead of updating them. CHANGES SINCE LAST ACTION

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

mgehre added a comment. Thanks for the comments so far. I'm a bit lost now. Which changes that cannot wait for the next PR do you see necessary to get this check merged? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77572/new/

[PATCH] D78027: [TimeProfiler] Emit real process ID and thread names

MaskRay added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:249 + +for (const auto : ThreadTimeTraceProfilerInstances) { + writeMetadataEvent("thread_name", TTP->Tid, TTP->ThreadName); MaskRay wrote: > broadwaylamb wrote: > > MaskRay

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

rsmith added a comment. It seems to me that there's as bug in the C++ specification here. The rules for discarded-value expressions say the lvalue-to-rvalue conversion is applied, whereas the rules for lvalue-to-rvalue conversions say one cannot be applied in this case. It's hard to guess what

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

rjmccall added a comment. That doesn't seem to be how we use it in practice; I'd just change the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78134/new/ https://reviews.llvm.org/D78134 ___

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz updated this revision to Diff 257482. ekatz added a comment. Use the old structure of the algorithm, with the fix, as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78098/new/ https://reviews.llvm.org/D78098 Files: clang/lib/CodeGen/CGExprAgg.cpp

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

b-sumner added a comment. In D77910#1981429 , @arsenm wrote: > In D77910#1976171 , @b-sumner wrote: > > > I don't think we can guarantee this is or will be supported on all devices. > > The language runtime makes

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784 +/// This represents the '#pragma omp tile' loop transformation directive. +class OMPTileDirective final +: public OMPLoopDirective, + private llvm::TrailingObjects {

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz marked an inline comment as done. ekatz added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:688 + +op = castE; } rjmccall wrote: > I liked the structure of the old code better, in case we want to look through > other kinds of

[clang] 9d2d6e7 - Emit Objective-C constructors as writable

Author: Joerg Sonnenberger Date: 2020-04-14T22:32:34+02:00 New Revision: 9d2d6e71f096ad43b178c576adf94fc922034c73 URL: https://github.com/llvm/llvm-project/commit/9d2d6e71f096ad43b178c576adf94fc922034c73 DIFF:

[PATCH] D77115: [WebAssembly] Emit .llvmcmd and .llvmbc as custom sections

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ea1c62cbae2: [WebAssembly] Emit .llvmcmd and .llvmbc as custom sections (authored by sbc100). Changed prior to commit: https://reviews.llvm.org/D77115?vs=253941=257476#toc Repository: rG LLVM

[PATCH] D77903: [SVE] Remove calls to getBitWidth from clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG670f2f694bba: [SVE] Remove calls to getBitWidth from clang (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77903/new/

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper marked 6 inline comments as done. craig.topper added inline comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:366 +std::vector TrimmedNodes(TrimNodes.size()); +for (size_type I = 0; I < TrimNodes.size(); ++I) { + TrimmedNodes[I] =

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 257473. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/ https://reviews.llvm.org/D76932 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D78148: [CodeGen] make isTriviallyRecursive handle more trivial recursion

george.burgess.iv created this revision. george.burgess.iv added reviewers: efriedma, serge-sans-paille. george.burgess.iv added a project: clang. Herald added a subscriber: cfe-commits. This function was not catching all forms of trivial recursion, meaning: void *memcpy(void *a, const void

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

craig.topper updated this revision to Diff 257465. craig.topper added a comment. Address some of the review comments. Primarily the ones in ImmutableGraph. I did de-templatize the method in X86LoadValueInjectionLoadHardening.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75936/new/

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

rsmith added a comment. In D78100#1981620 , @sammccall wrote: > Sorry to go back and forth on this, but I'm not sure whether these > diagnostics are actually spam to be suppressed. I think @adamcz mentioned > these today as reasonable diagnostics we're

[PATCH] D77910: AMDGPU: Define cl_khr_gl_sharing as a supported extension

arsenm updated this revision to Diff 257470. arsenm added a comment. Check triple OS CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77910/new/ https://reviews.llvm.org/D77910 Files: clang/lib/Basic/Targets/AMDGPU.h clang/test/Misc/amdgcn.languageOptsOpenCL.cl Index:

[PATCH] D78134: [Sema] Don't apply an lvalue-to-rvalue conversion to a discarded-value expression if it has an array type

ahatanak added a comment. My first patch just did that and it seems to work. But the comment for `DefaultLvalueConversion` says "This is DefaultFunctionArrayLvalueConversion, except that it assumes the operand isn't of function or array type". It doesn't even have assertions to check that

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69088/new/ https://reviews.llvm.org/D69088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77923: OpenCL: Fix some missing predefined macros

jvesely added a comment. In D77923#1981398 , @arsenm wrote: > In D77923#1979286 , @jvesely wrote: > > > > In D77923#1976497 , @jvesely > > > wrote: > > > > > >>

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. pong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78027: [TimeProfiler] Emit real process ID and thread names

MaskRay added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:77 +static std::string getThreadName() { + SmallString<64> Name; broadwaylamb wrote: > MaskRay wrote: > > You can define ThreadName as `SmallString<0>` to avoid this function. > Then

[clang] 670f2f6 - [SVE] Remove calls to getBitWidth from clang

Author: Christopher Tetreault Date: 2020-04-14T13:29:09-07:00 New Revision: 670f2f694bba24c2c2647d48e0bdf400365c283b URL: https://github.com/llvm/llvm-project/commit/670f2f694bba24c2c2647d48e0bdf400365c283b DIFF:

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb marked an inline comment as done. broadwaylamb added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:266 + const auto BeginningOfTimeUs = SystemTime - ProcessLocalTime; + J.attribute("beginningOfTime", +

[PATCH] D78100: [AST] Suppress the spammy "attempt to use a deleted fucntion" diagnostic.

sammccall added subscribers: adamcz, rsmith. sammccall added a comment. Sorry to go back and forth on this, but I'm not sure whether these diagnostics are actually spam to be suppressed. I think @adamcz mentioned these today as reasonable diagnostics we're enabling. @rsmith do you have an

[PATCH] D78085: [AST] Fix recovery-expr crash on invalid aligned attr.

sammccall added inline comments. Comment at: clang/lib/AST/DeclBase.cpp:400 + for (; I != E; ++I) { +if (!I->isAlignmentDependent()) + Align = std::max(Align, I->getAlignment(Ctx)); This doesn't seem great - previously if e.g. codegen ends up needing

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

SjoerdMeijer added inline comments. Comment at: clang/docs/MatrixTypes.rst:27 +internal layout, overall size and alignment are implementation-defined. +A *matrix element type* must be a real type (as in C99 6.2.5p17) excluding +enumeration types or an implementation-defined

[PATCH] D78117: [AVR] Define __ELF__

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. I agree that these tests are in the wrong directory; please prepare a patch that moves them. This patch is okay to go, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb marked an inline comment as done. broadwaylamb added inline comments. Comment at: llvm/lib/Support/TimeProfiler.cpp:266 + const auto BeginningOfTimeUs = SystemTime - ProcessLocalTime; + J.attribute("beginningOfTime", +

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

Szelethus added a comment. This is a great idea, but the tests just seem to, well, test the new functionality? On a different issue, take a look at how certain help related frontend flags (not `-analyzer-config` ones!) skip the analysis, like `-analyzer-checker-help`, or

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

rjmccall added inline comments. Comment at: clang/docs/MatrixTypes.rst:79 + floating point type, convert the integer or floating point operand to the + underlying element type of the operand of matrix type. + fhahn wrote: > rjmccall wrote: > > You should

  1   2   3   >