[clang-tools-extra] 7c2990b - [clangd] Fix data race in GoToInclude.All test

Author: Kadir Cetinkaya Date: 2020-11-19T08:47:43+01:00 New Revision: 7c2990b8af6f906a431b14951e831647d9bbb090 URL: https://github.com/llvm/llvm-project/commit/7c2990b8af6f906a431b14951e831647d9bbb090 DIFF:

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b1341eb5bb7: [PowerPC] [Clang] Fix alignment of 128-bit float types (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/D91596?vs=305692=306315#toc Repository: rG LLVM Github

[clang] 6b1341e - [PowerPC] [Clang] Fix alignment of 128-bit float types

Author: Qiu Chaofan Date: 2020-11-19T14:22:14+08:00 New Revision: 6b1341eb5bb71a1ce4547165a247b23bb30ef44e URL: https://github.com/llvm/llvm-project/commit/6b1341eb5bb71a1ce4547165a247b23bb30ef44e DIFF: https://github.com/llvm/llvm-project/commit/6b1341eb5bb71a1ce4547165a247b23bb30ef44e.diff

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

qiucf added a comment. In D91596#2404514 , @rjmccall wrote: > I assume this has always been taken care of properly in the backend, so this > is just a fix for va_arg treatment? If so, LGTM. Yes. That's just fix for `va_arg`. Thanks! CHANGES SINCE

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

MaskRay updated this revision to Diff 306312. MaskRay added a comment. Drop an unneeded change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91760/new/ https://reviews.llvm.org/D91760 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D64651: [Driver] Support file paths with -ccc-gcc-name

al3xtjames updated this revision to Diff 306309. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64651/new/ https://reviews.llvm.org/D64651 Files: clang/lib/Driver/ToolChains/Gnu.cpp Index: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks added a comment. In D87216#2356770 , @jamieschmeiser wrote: > The changes are specific to -print-before and -print-after (which is the > intended target and this work originated before -print-changed) but could the > change be made universal?

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks updated this revision to Diff 306307. aeubanks added a comment. rebase now we don't add a new parameter to callbacks, instead let individual instrumentations ask PassInstrumentationCallbacks for pass names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ikudrin added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly updated this revision to Diff 306302. ckennelly added a comment. Added option to allow rewrites for default to value initialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 Files:

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

MaskRay created this revision. MaskRay added reviewers: joerg, psmith, resistor. Herald added subscribers: cfe-commits, danielkiss, mstorsjo, kristof.beyls, krytarowski, arichardson, emaste. Herald added a project: clang. MaskRay requested review of this revision. In GCC, `aarch64-*-linux` and

[PATCH] D87981: [X86] AMX programming model.

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86TileConfig.cpp:223 + LLVM_DEBUG(dbgs() << "** TILE REGISTER CONFIGURE**\n" +<< "** Function: " << mf.getName() << '\n'); + MF = mehdi_amini wrote:

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:783 + let Inst{47-32} = addr{15-0}; // offset + let Inst{11-8} = new; + let Inst{7-4} = BPF_CMPXCHG.Value; ast wrote: > yonghong-song wrote: > > jackmanb wrote: > > > If we

[PATCH] D87981: [X86] AMX programming model.

mehdi_amini added a comment. (Drive by comments) Comment at: llvm/include/llvm/CodeGen/TileShapeInfo.h:27 + +class ShapeT { +public: Can you document the class? Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:30 + +class

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. I assume this has always been taken care of properly in the backend, so this is just a fix for va_arg treatment? If so, LGTM. CHANGES SINCE LAST ACTION

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 306287. tentzen added a comment. per review feedback from John McCall and others, this update includes: - Rename intrinsic eha.scope.begin() with seh.scope.begin(). - Update LangRef.rst with detailed explanation - Add conditional cleanup test case and move

[PATCH] D91047: Add a call super attribute plugin example

psionic12 updated this revision to Diff 306283. psionic12 added a comment. Simplify the test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91047/new/ https://reviews.llvm.org/D91047 Files: clang/examples/CMakeLists.txt

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy updated this revision to Diff 306280. hoy edited the summary of this revision. hoy added a comment. Updating D91756 : [CSSPGO] Pseudo probes for function calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91015: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25f5406f0875: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view. (authored by ckennelly). Repository: rG LLVM Github

[clang-tools-extra] 25f5406 - [clang-tidy] Extend bugprone-string-constructor-check to std::string_view.

Author: Chris Kennelly Date: 2020-11-18T21:16:03-05:00 New Revision: 25f5406f087579d43ca9a82dee7f3e76f0691bad URL: https://github.com/llvm/llvm-project/commit/25f5406f087579d43ca9a82dee7f3e76f0691bad DIFF:

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; gulfem wrote: > aaron.ballman wrote: > > gulfem wrote: > > >

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:150 + const SanitizerArgs = getToolChain().getSanitizerArgs(); + if (LINKER_SUPPORTS_Z_RELAX_TRANSTLS && + getToolChain().getTriple().getArch() == llvm::Triple::x86_64 &&

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:150 + const SanitizerArgs = getToolChain().getSanitizerArgs(); + if (LINKER_SUPPORTS_Z_RELAX_TRANSTLS && + getToolChain().getTriple().getArch() == llvm::Triple::x86_64 &&

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, wenlei, pengfei, hiraditya, mgorny. Herald added projects: clang, LLVM. hoy requested review of this revision. An indirect call site needs to be probed for its potential call targets. With CSSPGO a

[PATCH] D91279: [PowerPC] DForm instructions should be preferred when using zero register

shchenz added a comment. > After a discussion with the group I would like to correct what I said in the > previous post. > There already is a plan to do this in ISel in a different patch. The reason > we also want to do this optimization here is to try to catch situations where > this pattern

[PATCH] D91279: [PowerPC] DForm instructions should be preferred when using zero register

steven.zhang added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCPreEmitPeephole.cpp:418 + // should prefer D-form if LXVX / STXVX uses a ZERO or ZERO8 + if (MI.getOpcode() == PPC::LXVX || MI.getOpcode() == PPC::STXVX) { +LLVM_DEBUG(dbgs()

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo updated this revision to Diff 306263. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

dblaikie added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug

[PATCH] D90889: Remove RemappedFiles param from ASTUnit::LoadFromASTFile, NFC

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90889/new/ https://reviews.llvm.org/D90889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90888: Frontend: Remove redundant call to CompilerInstance::setFileManager, NFC

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90888/new/ https://reviews.llvm.org/D90888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91317: Support: Add RedirectingFileSystem::create from simple list of redirections

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91317/new/ https://reviews.llvm.org/D91317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90887: ARCMigrate: Stop abusing PreprocessorOptions for passing back file remappings, NFC

dexonsmith added a reviewer: jansvoboda11. dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90887/new/ https://reviews.llvm.org/D90887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90733: Frontend: Sink named pipe logic from CompilerInstance down to FileManager

dexonsmith added a reviewer: jansvoboda11. dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90733/new/ https://reviews.llvm.org/D90733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90497: Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and DirectoryName, NFC

dexonsmith added a reviewer: jansvoboda11. dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90497/new/ https://reviews.llvm.org/D90497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

dexonsmith added a reviewer: jansvoboda11. dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90484/new/ https://reviews.llvm.org/D90484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90053: Serialization: Change InputFile to use FileEntryRef and add getVirtualFileRef, NFC

dexonsmith added a reviewer: jansvoboda11. dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90053/new/ https://reviews.llvm.org/D90053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90485: Lex: Update Module::findHeader to return FileEntryRef, NFC

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90485/new/ https://reviews.llvm.org/D90485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91298: Frontend: Always create a new FileManager in ASTUnit::CodeComplete

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91298/new/ https://reviews.llvm.org/D91298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91297/new/ https://reviews.llvm.org/D91297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91296: Frontend: Clarify logic for using the preamble in ASTUnit::CodeComplete, almost NFC

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91296/new/ https://reviews.llvm.org/D91296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang added a comment. In D85808#2403587 , @tejohnson wrote: > Thanks for adding the Driver test. I was thinking of something to test the > CompilerInvocation changes, similar to your test using opt, that ensures the > option has the desired behavior

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang updated this revision to Diff 306256. weiwang added a comment. 1. Add clang test with remarks output. 2. Fix a missing dependency on PSI in legacy pass manager. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith added a comment. In D91311#2403805 , @ldionne wrote: > We can stick with this design, but I'd like to understand why `#if > _LIBCPP_HAS_NO_PREFERRED_NAME` is necessary in ``, and also the CI is > failing on MacOS. You mean the HWAddressSanitizer

[clang] 67f16e9 - [NPM] Remove -enable-npm-optnone flag

Author: Arthur Eubanks Date: 2020-11-18T15:49:16-08:00 New Revision: 67f16e9e91f2f07cdb9813b60c195f5a1cd1f57d URL: https://github.com/llvm/llvm-project/commit/67f16e9e91f2f07cdb9813b60c195f5a1cd1f57d DIFF:

[PATCH] D91743: [NPM] Remove -enable-npm-optnone flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67f16e9e91f2: [NPM] Remove -enable-npm-optnone flag (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

zequanwu created this revision. zequanwu added reviewers: EricWF, rnk, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. zequanwu requested review of this revision. According to https://eel.is/c++draft/cpp.predefined#2.6, `__STDCPP_THREADS__` is a predefined macro.

[PATCH] D91509: [clangd] Add AST config to prebuild ASTs

DaanDeMeyer abandoned this revision. DaanDeMeyer added a comment. Abandoning as the end result is too slow even when including a limited number of files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91509/new/ https://reviews.llvm.org/D91509

[PATCH] D72184: [BPF] support atomic instructions

ast added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:783 + let Inst{47-32} = addr{15-0}; // offset + let Inst{11-8} = new; + let Inst{7-4} = BPF_CMPXCHG.Value; yonghong-song wrote: > jackmanb wrote: > > If we go down the route of

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4616 + if (Args.hasArg(options::OPT_maltivec) && + (Triple.isOSAIX() || Triple.isOSBinFormatXCOFF())) { +for (const Arg *A : Args) { I am wondering what cases are not

[PATCH] D91743: [NPM] Remove -enable-npm-optnone flag

aeubanks created this revision. aeubanks added reviewers: asbirlea, ychen. Herald added subscribers: llvm-commits, cfe-commits, jfb, hiraditya. Herald added projects: clang, LLVM. aeubanks requested review of this revision. It has been on by default for a couple months without complaint.

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

dblaikie added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug

[PATCH] D91669: Don’t break before nested block param when prior param is not a block

kastiglione accepted this revision. kastiglione added a comment. The purpose and the tests LGTM! Hopefully someone will weigh in on the implementation in ContinuationIndenter.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91669/new/

[PATCH] D86853: [modules] Fix crash in call to `FunctionDecl::setPure()`

bruno added a comment. I forgot to follow up, but LGTM too. > @rsmith, @v.g.vassilev hey I stamped this patch assuming it looks ok. But > definitely shout at me if more feedback needs to be addressed. Happy to > follow up. FWIW, this has been working on our code base for sometime now.

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4020 +const Arg *A = Args.getLastArg(options::OPT_gdwarf64); +const llvm::Triple = TC.getTriple(); +if (DWARFVersion < 3) MaskRay wrote: > The variable is only used

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo updated this revision to Diff 306223. ayermolo retitled this revision from "Adding DWARF64 clang flag" to "Adding DWARF64 clang flag: -gdwarf64". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507

[PATCH] D86853: [modules] Fix crash in call to `FunctionDecl::setPure()`

lxfind added a comment. @rsmith, @v.g.vassilev hey I stamped this patch assuming it looks ok. But definitely shout at me if more feedback needs to be addressed. Happy to follow up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86853/new/

[clang] 5f2c554 - Fix assert on valid due to incorrect assumption that a field name must

Author: Richard Smith Date: 2020-11-18T14:04:02-08:00 New Revision: 5f2c5541f78750c21004e0172f13db4632966fd3 URL: https://github.com/llvm/llvm-project/commit/5f2c5541f78750c21004e0172f13db4632966fd3 DIFF: https://github.com/llvm/llvm-project/commit/5f2c5541f78750c21004e0172f13db4632966fd3.diff

[PATCH] D91279: [PowerPC] DForm instructions should be preferred when using zero register

stefanp added a comment. In D91279#2400854 , @stefanp wrote: > In D91279#2390160 , @shchenz wrote: > >> Using dform with offset 0 can save one register r0/X0, this is benefit for >> register allocation? But adding

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

ldionne added a comment. I think this looks good. I must admit I'm a bit worried about any unintended consequences this might have or breakage this might cause in cases where we'd switch from linking against the SDK libc++.dylib to the toolchain one. This would only impact the toolchain

[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

jhuber6 updated this revision to Diff 306210. jhuber6 added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D90507: Adding DWARF64 clang flag

MaskRay added a comment. > Adding DWARF64 clang flag It is important to mention the exact option name: Add `-gdwarf-64` to enable 64-bit DWARF format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507

[PATCH] D90507: Adding DWARF64 clang flag

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4018 + if (Args.hasArg(options::OPT_gdwarf64)) { +const Arg *A = Args.getLastArg(options::OPT_gdwarf64); `if (const Arg *A = Args.getLastArg(options::OPT_gdwarf64)`)

[PATCH] D91311: Add new 'preferred_name' attribute.

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. Actually, apologies -- I might have accepted this too quickly. We can stick with this design, but I'd like to understand why `#if _LIBCPP_HAS_NO_PREFERRED_NAME` is necessary in

[PATCH] D91311: Add new 'preferred_name' attribute.

ldionne accepted this revision as: libc++. ldionne added a comment. This revision is now accepted and ready to land. In D91311#2400998 , @dblaikie wrote: > A concrete/real-world example might be helpful, if you happen to have one on > hand. See what

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to address the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 ___

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:274 +return canonicalRenameDecl(Function); + return D; +} I think we should call `getCanonicalDecl` before returning the final result (calling it at the beginning

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo marked 2 inline comments as done. ayermolo added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64.

[PATCH] D91565: Guard init_priority attribute within libc++

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:384 +def ExcludeTarget : TargetSpec { + let CustomCode = [{ !Target.getTriple().isOSzOS() }]; This is not a very descriptive name -- if this is only supposed to be used for

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:235 +return TM.isPPC64() + ? (Subtarget.hasAltivec() ? CSR_64_AllRegs_Altivec_RegMask + : CSR_PPC64_RegMask) sfertile

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 306187. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 306186. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D91565: Guard init_priority attribute within libc++

zibi updated this revision to Diff 306183. zibi marked an inline comment as done. zibi added a comment. Moving macro to common place as requested. This makes assumption that MS and Apple restrictions were lifted at some point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin added a comment. In D91567#2403544 , @aeubanks wrote: > In D91567#2403252 , @mtrofin wrote: > >> In D91567#2403236 , @aeubanks wrote: >> >>> One thing that would be

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

sfertile added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:235 +return TM.isPPC64() + ? (Subtarget.hasAltivec() ? CSR_64_AllRegs_Altivec_RegMask + : CSR_PPC64_RegMask)

[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

abidh updated this revision to Diff 306180. abidh added a comment. Herald added a subscriber: MaskRay. This update contains following changes. 1. Address issue raised by lenary. I have introduced a static function that checks for the presence of gcc toolchain first by --gcc-toolchain argument

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

tejohnson added a comment. Thanks for adding the Driver test. I was thinking of something to test the CompilerInvocation changes, similar to your test using opt, that ensures the option has the desired behavior when invoked via clang. Looks like there is an existing test

[PATCH] D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params

zinovy.nis added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:968 + } +} + aaron.ballman wrote: > Another test that would be interesting is: > ``` > if (tryToExtinguish(isSet) && isSet) { >

[PATCH] D86853: [modules] Fix crash in call to `FunctionDecl::setPure()`

This revision was automatically updated to reflect the committed changes. Closed by commit rGc6c8d4a13ebd: [modules] Fix crash in call to `FunctionDecl::setPure()` (authored by andrewjcg, committed by lxfind). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c6c8d4a - [modules] Fix crash in call to `FunctionDecl::setPure()`

Author: Andrew Gallagher Date: 2020-11-18T11:55:29-08:00 New Revision: c6c8d4a13ebd5ce1c3c7e8632312ab8c2dc6afa0 URL: https://github.com/llvm/llvm-project/commit/c6c8d4a13ebd5ce1c3c7e8632312ab8c2dc6afa0 DIFF:

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3938 + if ((FLAGS)::CC1Option) { \ +const auto = EXTRACTOR(this->KEYPATH); \ +if (ALWAYS_EMIT || Extracted !=

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

aeubanks added a comment. In D91567#2403252 , @mtrofin wrote: > In D91567#2403236 , @aeubanks wrote: > >> One thing that would be nice would be to have both inliners in the same >> CGSCC pass manager to avoid

[PATCH] D91625: [clang] Do not crash on pointer wchar_t pointer assignment.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91625/new/ https://reviews.llvm.org/D91625

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song updated this revision to Diff 306172. yonghong-song edited the summary of this revision. yonghong-song added a comment. add support for a barrier function. The correspond C code is __sync_synchronize(). If we want to have variant like barrier for read/write/rw, etc. we may need to

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4062 + if ((FLAGS)::CC1Option) { \ +const auto = EXTRACTOR(this->KEYPATH); \ +if (ALWAYS_EMIT || Extracted !=

[PATCH] D91565: Guard init_priority attribute within libc++

ldionne requested changes to this revision. ldionne added inline comments. This revision now requires changes to proceed. Comment at: libcxx/include/experimental/__config:80 +// Detect if the init_priority attribute is supported. +#if (defined(_LIBCPP_COMPILER_GCC) &&

[PATCH] D91673: [PGO] Enable preinline and cleanup when optimize for size

rnk added a comment. Zequan, to build clang with PGO, you can follow the steps in Chrome's script to build clang with PGO: https://source.chromium.org/chromium/chromium/src/+/master:tools/clang/scripts/build.py;l=703?q=clang%2Fscripts%2F%20build.py=chromium Regarding -Oz / minsize / SizeLevel

[PATCH] D83691: Port Comment option flags to new parsing system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM after you fix a couple of nits. Comment at: clang/include/clang/Driver/Options.td:405 +// Comment Options + Nit: please end the comment with

[PATCH] D77598: Integral template argument suffix and cast printing

rsmith added inline comments. Comment at: clang/include/clang/AST/StmtDataCollectors.td:67-75 +if (auto *ParamTypeDecl = dyn_cast(TemplParam)) { + const clang::Type *ParamType = ParamTypeDecl->getTypeForDecl(); + if (auto *autoT =

[PATCH] D17993: [CodeGen] Apply 'nonnull' and 'dereferenceable(N)' to 'this' pointer arguments.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2169 +if (!CodeGenOpts.NullPointerIsValid && +getContext().getTargetAddressSpace(FI.arg_begin()->type) == 0) { + Attrs.addAttribute(llvm::Attribute::NonNull); arichardson

[PATCH] D83693: Port analyzer flags to new option parsing system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83693/new/ https://reviews.llvm.org/D83693

[PATCH] D91565: Guard init_priority attribute within libc++

zibi updated this revision to Diff 306162. zibi marked an inline comment as done. zibi added a comment. Herald added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. I moved the logic from `memory_resource.cpp` to `__config` as since I'm not

[PATCH] D86502: [CSSPGO] A Clang switch -fpseudo-probe-for-profiling for pseudo-probe instrumentation.

hoy added a comment. In D86502#2245734 , @wmi wrote: > In D86502#2245578 , @hoy wrote: > >> In D86502#2245460 , @wmi wrote: >> The early instrumentation also allows the

[PATCH] D91544: [clang-tidy] Allow `TransformerClangTidyCheck` clients to set the rule directly.

This revision was automatically updated to reflect the committed changes. Closed by commit rG068da2c749a5: [clang-tidy] Allow `TransformerClangTidyCheck` clients to set the rule directly. (authored by ymandel). Changed prior to commit: https://reviews.llvm.org/D91544?vs=305516=306151#toc

[clang-tools-extra] 068da2c - [clang-tidy] Allow `TransformerClangTidyCheck` clients to set the rule directly.

Author: Yitzhak Mandelbaum Date: 2020-11-18T18:25:21Z New Revision: 068da2c749a58b46bd59381890a6a137d6e3128e URL: https://github.com/llvm/llvm-project/commit/068da2c749a58b46bd59381890a6a137d6e3128e DIFF: https://github.com/llvm/llvm-project/commit/068da2c749a58b46bd59381890a6a137d6e3128e.diff

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song updated this revision to Diff 306146. yonghong-song edited the summary of this revision. yonghong-song added a comment. add fetch_and_{and,or,xor} support force cmpxchg insn return results in r0 like r0 = cmpxchg(addr, r0, new) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin added a comment. In D91567#2403236 , @aeubanks wrote: > One thing that would be nice would be to have both inliners in the same CGSCC > pass manager to avoid doing SCC construction twice, but that would require > some shuffling of module/cgscc

[PATCH] D91485: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved

njames93 updated this revision to Diff 306143. njames93 added a comment. Added test cases to ensure clang-tidy doesn't crash. Expanded auto out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91485/new/ https://reviews.llvm.org/D91485 Files:

[clang-tools-extra] 130da80 - Revert "Revert "[clangd] Implement textDocument/implementation (Xref layer)""

Author: Utkarsh Saxena Date: 2020-11-18T19:09:16+01:00 New Revision: 130da802ff6e59d59ac5afce9e6a4235f3fe4959 URL: https://github.com/llvm/llvm-project/commit/130da802ff6e59d59ac5afce9e6a4235f3fe4959 DIFF:

  1   2   3   >