[PATCH] D103720: [clang] NFC: Rename rvalue to prvalue

mizvekov updated this revision to Diff 350006. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103720/new/ https://reviews.llvm.org/D103720 Files: clang-tools-extra/clang-tidy/misc/UniqueptrResetReleaseCheck.cpp

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

joerg added inline comments. Comment at: clang/docs/UsersManual.rst:1484 + Where unsafe floating point optimizations are enabled, this option + determines whether the optimizer honors parentheses when floating-point + expressions are evaluated. If unsafe floating point

[PATCH] D103108: [CUDA][HIP] Promote const variables to constant

sbc100 added inline comments. Comment at: clang/test/CodeGenCUDA/device-use-host-var.cu:68 +// NEG-NOT: @_ZL13var_host_only +// NEG-NOT: external tra wrote: > yaxunl wrote: > > sbc100 wrote: > > > This seems to break if the pathname where the llvm checkout

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

xazax.hun added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:147 +class ExpressionHandler; +class StoreHandler; + vsavchenko wrote: > xazax.hun wrote: > > During path sensitive analysis we already have a

[PATCH] D103108: [CUDA][HIP] Promote const variables to constant

tra added inline comments. Comment at: clang/test/CodeGenCUDA/device-use-host-var.cu:68 +// NEG-NOT: @_ZL13var_host_only +// NEG-NOT: external yaxunl wrote: > sbc100 wrote: > > This seems to break if the pathname where the llvm checkout lives contains > > the

[PATCH] D103108: [CUDA][HIP] Promote const variables to constant

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/CodeGenCUDA/device-use-host-var.cu:68 +// NEG-NOT: @_ZL13var_host_only +// NEG-NOT: external sbc100 wrote: > This seems to break if the pathname where the llvm

[PATCH] D103108: [CUDA][HIP] Promote const variables to constant

sbc100 added inline comments. Comment at: clang/test/CodeGenCUDA/device-use-host-var.cu:68 +// NEG-NOT: @_ZL13var_host_only +// NEG-NOT: external This seems to break if the pathname where the llvm checkout lives contains the word "external"

[PATCH] D103722: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText()

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks for adding more tests! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103722/new/ https://reviews.llvm.org/D103722

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added a comment. In D103440#2799629 , @xazax.hun wrote: > I was wondering, if we could try something new with the tests. To increase > our confidence that the expected behavior is correct, how about including a > Z3 proof with each of the test

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

vsavchenko added a comment. In D103605#2799853 , @NoQ wrote: > In D103605#2798581 , @vsavchenko > wrote: > >> In D103605#2798171 , @NoQ wrote: >> >>> - Trackers are

[PATCH] D103722: [clang] NFC: test for undefined behaviour in RawComment::getFormattedText()

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: teemperor, obruns, bruno. DmitryPolukhin requested review of this revision. Herald added a project: clang. This diff adds testcase for the issue fixed in https://reviews.llvm.org/D77468 but regression test was not added in the

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp:180 +// Note: This pointer has type 'const MemRegion *' +REGISTER_TRAIT_WITH_PROGRAMSTATE(EnvPtrRegion, const void *) + balazske wrote: > Is it not possible

[clang] 33ba8bd - [Windows SEH]: Fix -O2 crash for Windows -EHa

Author: Ten Tzen Date: 2021-06-04T14:07:44-07:00 New Revision: 33ba8bd2c942062731a17e1b864b5953e3d79f1a URL: https://github.com/llvm/llvm-project/commit/33ba8bd2c942062731a17e1b864b5953e3d79f1a DIFF: https://github.com/llvm/llvm-project/commit/33ba8bd2c942062731a17e1b864b5953e3d79f1a.diff

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG33ba8bd2c942: [Windows SEH]: Fix -O2 crash for Windows -EHa (authored by tentzen). Repository: rG LLVM Github Monorepo

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

zahiraam added a comment. In D103664#2799944 , @tentzen wrote: > since I cannot repro it locally, let's have this patch in to resolve -EHa -O2 > crashes for now. > I will add more -O2 tests in following patches. Sounds good to me! Repository: rG

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang closed this revision. akhuang added a comment. Committed in 9d070b2f4889887f9ce497592ef01df7b9601a1c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102736/new/

[PATCH] D103372: [InstrProfiling] If no value profiling, make data variable private and (for Windows) use one comdat

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:935 + // data variables can be private. This optimization applies on COFF and ELF. + if (!DataReferencedByCode && !TT.isOSBinFormatMachO()) { +Linkage =

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

tentzen added a comment. since I cannot repro it locally, let's have this patch in to resolve -EHa -O2 crashes for now. I will add more -O2 tests in following patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103664/new/

[PATCH] D103372: [InstrProfiling] If no value profiling, make data variable private and (for Windows) use one comdat

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e51d1f348b9: [InstrProfiling] If no value profiling, make data variable private and (for… (authored by MaskRay). Repository: rG LLVM Github

[PATCH] D103372: [InstrProfiling] If no value profiling, make data variable private and (for Windows) use one comdat

MaskRay updated this revision to Diff 349956. MaskRay added a comment. better description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103372/new/ https://reviews.llvm.org/D103372 Files: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:127 +/// into a special block region. +BlockCapture + }; xazax.hun wrote: > There are some other places were we might have effects that are

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

zahiraam added a comment. In D103664#2799852 , @tentzen wrote: > @zahiraam, are you removing all those CHECKs: > > - CHECK: invoke void @llvm.seh.scope.** > > those are placed there to ensure SEH scope semantic is preserved for Od.. I was just showing

[PATCH] D103372: [InstrProfiling] If no value profiling, make data variable private and (for Windows) use one comdat

MaskRay updated this revision to Diff 349953. MaskRay edited the summary of this revision. MaskRay added a comment. Exclude Mach-O. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103372/new/ https://reviews.llvm.org/D103372 Files:

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

NoQ added a comment. In D103605#2798581 , @vsavchenko wrote: > In D103605#2798171 , @NoQ wrote: > >> - Trackers are attached to bug reports. A single bug report may have >> multiple trackers. >> - Why not

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

tentzen added a comment. @zahiraam, are you removing all those CHECKs: - CHECK: invoke void @llvm.seh.scope.** those are placed there to ensure SEH scope semantic is preserved for Od.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103664/new/

[PATCH] D103184: [AArch64] handle -Wa,-march=

jcai19 added a comment. In D103184#2799732 , @nickdesaulniers wrote: > That looks better, thanks @jcai19 . Based on @DavidSpickett 's LGTM I think > this is now ready to land. > > @DavidSpickett did ask: > >> Also please include in the commit message

[PATCH] D103485: Fix a diagnoses-valid bug with using declarations

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the review! I've commit in ca68f3bc48e48f839142de1461e95d87ae48e9df . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ca68f3b - Fix a diagnoses-valid bug with using declarations

Author: Aaron Ballman Date: 2021-06-04T15:52:07-04:00 New Revision: ca68f3bc48e48f839142de1461e95d87ae48e9df URL: https://github.com/llvm/llvm-project/commit/ca68f3bc48e48f839142de1461e95d87ae48e9df DIFF: https://github.com/llvm/llvm-project/commit/ca68f3bc48e48f839142de1461e95d87ae48e9df.diff

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

xazax.hun added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:110 + /// (inlined defensive checks, returned null). + bool EnableNullFPSuppression = true; +}; I vaguely remember we wanting to put this

[PATCH] D103611: Correct the behavior of va_arg checking in C++

aaron.ballman updated this revision to Diff 349945. aaron.ballman added a comment. Changed the test case to speculatively see if the CI pipeline is happy with this (I'm trying to avoid adding a triple to the test). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103611/new/

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

zahiraam added a comment. In D103664#2799725 , @tentzen wrote: > In D103664#2798732 , @aganea wrote: > >> Thanks for the quick fix! Would you mind fixing the two failing tests >> please? (see above) > > Hmm, I

[PATCH] D103663: [AMDGPU] Add gfx1013 target

rampitec added inline comments. Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.intersect_ray.ll:4 +; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1013 -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s +; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1012

[PATCH] D103184: [AArch64] handle -Wa,-march=

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. That looks better, thanks @jcai19 . Based on @DavidSpickett 's LGTM I think this is now ready to land. @DavidSpickett did ask: > Also please include in the commit message

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

tentzen updated this revision to Diff 349939. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103664/new/ https://reviews.llvm.org/D103664 Files: clang/lib/CodeGen/CGCleanup.cpp clang/lib/Driver/ToolChains/Clang.cpp Index:

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

tentzen added a comment. In D103664#2798732 , @aganea wrote: > Thanks for the quick fix! Would you mind fixing the two failing tests please? > (see above) Hmm, I cannot repro locally.. @zahiraam, currently -EHa is not completely ready yet. we need a

[PATCH] D103184: [AArch64] handle -Wa,-march=

jcai19 updated this revision to Diff 349938. jcai19 marked an inline comment as done. jcai19 added a comment. Update test cases based on comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103184/new/ https://reviews.llvm.org/D103184 Files:

[PATCH] D103082: [AArch64][SVE] Improve codegen for dupq SVE ACLE intrinsics

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103082/new/ https://reviews.llvm.org/D103082

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

xazax.hun added a comment. I was wondering, if we could try something new with the tests. To increase our confidence that the expected behavior is correct, how about including a Z3 proof with each of the test cases? For example: (declare-const a ( _ BitVec 32 )) (declare-const b ( _

[PATCH] D103372: [InstrProfiling] If no value profiling, make data variable private and (for Windows) use one comdat

rnk added a comment. I think MachO doesn't have comdats, so we need to leave the `__profd_` linkage as it was. I think private linkage also prevents atomization, which inhibits GC / dead stripping. I don't think this change really makes sense for MachO, so you could reasonably reland with that

[PATCH] D103707: Add STDC macros

Jake-Egan created this revision. Herald added subscribers: jfb, kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D103707 Files:

[PATCH] D103663: [AMDGPU] Add gfx1013 target

rampitec added a comment. You need to replace HasGFX10_BEncoding with HasGFX10_AEncoding in the BVH and IMAGE_MSAA_LOAD_X. You also need to update llvm.amdgcn.image.msaa.load.x.ll test to include gfx1013. Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:1106 [FeatureGFX10,

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Remains the issue with the alignment, I would like to know @MyDeveloperDay 's opinion on that. Should the values be right aligned, or left aligned? As far as I see all alignment in clang-format is left until now.

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

bmahjour added a comment. As far as I can see, there is no good reason for the special treatment of vector bool/pixel going forward. Could we drop this special treatment, or at least change the default to use a scalar results across the board (consistent with XL's behaviour and clang's current

[PATCH] D101630: [HIP] Fix device-only compilation

yaxunl added a comment. In D101630#2799472 , @tra wrote: > In D101630#2799425 , @yaxunl wrote: > >> But how do we control emitting LLVM IR with or without bundle? `-emit-llvm >> -emit-gpu-object` or `-emit-llvm

[PATCH] D103372: [InstrProfiling] If no value profiling, make data variable private and (for Windows) use one comdat

MaskRay added a comment. @vsk Do you mind investigating macOS `Posix/instrprof-dynamic-one-shared.test` and `Posix/instrprof-dynamic-two-shared.test` failures on https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8845381350758503248/+/steps/package_clang/0/stdout ?

[PATCH] D103372: [InstrProfiling] If no value profiling, make data variable private and (for Windows) use one comdat

MaskRay updated this revision to Diff 349915. MaskRay added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Re-upload after revert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103372/new/

[PATCH] D101630: [HIP] Fix device-only compilation

tra added a comment. In D101630#2799425 , @yaxunl wrote: > But how do we control emitting LLVM IR with or without bundle? `-emit-llvm > -emit-gpu-object` or `-emit-llvm -emit-gpu-bundle`? `-emit-*` is usually for > specifying a specific file type.

[PATCH] D103587: [AIX] Transfer __TOS_AIX__ predefined macro

Jake-Egan updated this revision to Diff 349913. Jake-Egan added a comment. Use this patch to target only __TOS_AIX__. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103587/new/ https://reviews.llvm.org/D103587 Files:

[PATCH] D103184: [AArch64] handle -Wa,-march=

nickdesaulniers requested changes to this revision. nickdesaulniers added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Driver/aarch64-target-as-march.s:29 +// RUN: FileCheck --check-prefix=MULTIPLE-VALUES %s + +// MULTIPLE-VALUES:

[PATCH] D103184: [AArch64] handle -Wa,-march=

jcai19 added a comment. In D103184#2798398 , @DavidSpickett wrote: >> LGTM; any additional thoughts @DavidSpickett ? > > A couple of additional tests just to be safe but otherwise LGTM. > > Also please include in the commit message the "rules" that

[PATCH] D103184: [AArch64] handle -Wa,-march=

jcai19 updated this revision to Diff 349912. jcai19 added a comment. Address the comments and add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103184/new/ https://reviews.llvm.org/D103184 Files:

[PATCH] D103097: Add DWARF address spaces mapping for SPIR

This revision was automatically updated to reflect the committed changes. Closed by commit rG333987b04589: [OpenCL] Add DWARF address spaces mapping for SPIR (authored by jzzheng22, committed by stuart). Changed prior to commit: https://reviews.llvm.org/D103097?vs=348910=349910#toc

[clang] 333987b - [OpenCL] Add DWARF address spaces mapping for SPIR

Author: Jason Zheng Date: 2021-06-04T18:10:54+01:00 New Revision: 333987b0458926332e9a1f96869ef47da25fa9b1 URL: https://github.com/llvm/llvm-project/commit/333987b0458926332e9a1f96869ef47da25fa9b1 DIFF: https://github.com/llvm/llvm-project/commit/333987b0458926332e9a1f96869ef47da25fa9b1.diff

[PATCH] D103658: CUDA/HIP: Change device-use-host-var.cu's NOT "external" check to include "addrspace"

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d9f8527dbfb: CUDA/HIP: Change device-use-host-var.cus NOT external check to include… (authored by kzhuravl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 4d9f852 - CUDA/HIP: Change device-use-host-var.cu's NOT "external" check to include variable name

Author: Konstantin Zhuravlyov Date: 2021-06-04T13:10:00-04:00 New Revision: 4d9f8527dbfbc998baf35eec868c9dec1f8d1224 URL: https://github.com/llvm/llvm-project/commit/4d9f8527dbfbc998baf35eec868c9dec1f8d1224 DIFF:

[PATCH] D101630: [HIP] Fix device-only compilation

yaxunl added a comment. In D101630#2799409 , @tra wrote: > In D101630#2798975 , @yaxunl wrote: > >> For sure we will need -fgpu-bundle-device-output to control bundling of >> intermediate files. Then adding

[PATCH] D103040: Print default template argument if manually specified in typedef declaration.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103040/new/ https://reviews.llvm.org/D103040

[PATCH] D101630: [HIP] Fix device-only compilation

tra added a comment. In D101630#2798975 , @yaxunl wrote: > For sure we will need -fgpu-bundle-device-output to control bundling of > intermediate files. Then adding -emit-gpu-object and -emit-gpu-bundle may be > redundant and can cause confusion. What

[PATCH] D103611: Correct the behavior of va_arg checking in C++

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103611/new/ https://reviews.llvm.org/D103611 ___ cfe-commits mailing list

[PATCH] D102822: [Clang][CodeGen] Set the size of llvm.lifetime to unknown for scalable types.

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/riscv-v-lifetime.cpp:3 +// REQUIRES: riscv-registered-target +// RUN: %clang_cc1 -std=c++11 -triple riscv64 -target-feature +experimental-v \ +// RUN: -emit-llvm -O1 -o - %s | FileCheck %s

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

rjmccall added a comment. Thanks, Akira. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98799/new/ https://reviews.llvm.org/D98799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] b109172 - [clang] use a different name for generated test cdb

Author: Mikhail Goncharov Date: 2021-06-04T18:12:58+02:00 New Revision: b109172d993edacd9853a8bbb8128a94da014399 URL: https://github.com/llvm/llvm-project/commit/b109172d993edacd9853a8bbb8128a94da014399 DIFF:

[PATCH] D103538: [clangd] Run code completion on each token coverd by --check-lines

This revision was automatically updated to reflect the committed changes. Closed by commit rGeba3ee04d450: [clangd] Run code completion on each token coverd by --check-lines (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] eba3ee0 - [clangd] Run code completion on each token coverd by --check-lines

Author: Adam Czachorowski Date: 2021-06-04T17:51:42+02:00 New Revision: eba3ee04d450230f7ac1f88b1abd7b09c600c82d URL: https://github.com/llvm/llvm-project/commit/eba3ee04d450230f7ac1f88b1abd7b09c600c82d DIFF:

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

balazske added a comment. I have not too deep knowledge about checker development but still found (hopefully valid) issues, even if only a part of them. Comment at: clang/docs/analyzer/checkers.rst:2117 +// envp may no longer point to the current environment +

[PATCH] D103097: Add DWARF address spaces mapping for SPIR

stuart added inline comments. Comment at: clang/test/CodeGenOpenCL/spir-debug-info-pointer-address-space.cl:22 +// CHECK-DAG: distinct !DIGlobalVariable(name: "FileVar5", scope: !{{[0-9]+}}, file: !{{[0-9]+}}, line: {{[0-9]+}}, type: ![[DWARF_ADDRESS_SPACE_GLOBAL]], isLocal:

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:12821 +/// Determine whether an expression is constant without emitting diagnostic. +static bool isConstantExpression(Sema , Expr *E) { + struct ConstTripcountDiagnoser : public Sema::VerifyICEDiagnoser {

[PATCH] D103612: [flang][driver] Add `-fno-unparse-typed-exprs`

awarzynski updated this revision to Diff 349881. awarzynski added a comment. Fix build and test failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103612/new/ https://reviews.llvm.org/D103612 Files: clang/include/clang/Driver/Options.td

[PATCH] D99540: [clangd] Preserve diags between tweak enumeration and execution

kadircet added a comment. > Sorry I've lost my context - did we decide to move forward with this patch? I don't think we've came to a conclusion, just decided to postpone until needed. I believe the `cases` design is really a good fit for making tweaks expose multiple code actions. But we've

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

jlpeyton accepted this revision. jlpeyton added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97085/new/ https://reviews.llvm.org/D97085 ___ cfe-commits mailing list

[PATCH] D103664: [Windows SEH]: Fix -O2 crash for Windows -EHa

zahiraam added a comment. wco Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7155 -if (EH.Asynch) - CmdArgs.push_back("-fasync-exceptions"); } Not really sure I understand this change. Isn't the case that if I compile with -EHa, I want the

[PATCH] D103538: [clangd] Run code completion on each token coverd by --check-lines

adamcz updated this revision to Diff 349878. adamcz added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103538/new/ https://reviews.llvm.org/D103538 Files: clang-tools-extra/clangd/tool/Check.cpp

[PATCH] D103538: [clangd] Run code completion on each token coverd by --check-lines

adamcz marked an inline comment as done. adamcz added a comment. I didn't put much thought into where --check-lines goes. It's an interesting thought. I think having all the flags in one place is more valuable than trying to split them in some way. We contain all flags in the same place, close

[clang] f917c5b - Revert test fixups after e9a9c850989e (which reverted a14fc74).

Author: Nico Weber Date: 2021-06-04T10:42:25-04:00 New Revision: f917c5b8d40b7894d52d56052bb18f8e989bad9e URL: https://github.com/llvm/llvm-project/commit/f917c5b8d40b7894d52d56052bb18f8e989bad9e DIFF: https://github.com/llvm/llvm-project/commit/f917c5b8d40b7894d52d56052bb18f8e989bad9e.diff

[PATCH] D103646: [OPENMP]Fix PR50129: omp cancel parallel not working as expected.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, one nit below. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:538 +omp::Directive CanceledDirective, +

[PATCH] D103642: [OPENMP]Fix PR49790: Constexpr values not handled in `omp declare mapper` clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rG827b5c21545a: [OPENMP]Fix PR49790: Constexpr values not handled in `omp declare mapper`… (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 827b5c2 - [OPENMP]Fix PR49790: Constexpr values not handled in `omp declare mapper` clause.

Author: Alexey Bataev Date: 2021-06-04T07:32:14-07:00 New Revision: 827b5c21545aaa820403e9b5cced8c0181349ee2 URL: https://github.com/llvm/llvm-project/commit/827b5c21545aaa820403e9b5cced8c0181349ee2 DIFF: https://github.com/llvm/llvm-project/commit/827b5c21545aaa820403e9b5cced8c0181349ee2.diff

[PATCH] D103612: [flang][driver] Add `-fno-unparse-typed-exprs`

awarzynski updated this revision to Diff 349868. awarzynski added a comment. Rebase on top of main, revert one small change uploaded accidentally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103612/new/ https://reviews.llvm.org/D103612 Files:

[PATCH] D103587: [AIX] Transfer predefined macros

cebowleratibm requested changes to this revision. cebowleratibm added a comment. This revision now requires changes to proceed. I think it makes sense to split the __STDC macro changes and __TOS_AIX__ into different patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

aaron.ballman added inline comments. Comment at: clang/docs/UsersManual.rst:1484 + Where unsafe floating point optimizations are enabled, this option + determines whether the optimizer honors parentheses when floating-point + expressions are evaluated. If unsafe floating

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity marked 5 inline comments as done. whisperity added a comment. In D75041#2799023 , @martong wrote: > Perhaps all conversion related logic should go into their own implementation > file? Seems like it adds up to roughly 1000 lines. That's

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc added a comment. question for @aaron.ballman Comment at: clang/docs/UsersManual.rst:1484 + Where unsafe floating point optimizations are enabled, this option + determines whether the optimizer honors parentheses when floating-point + expressions are evaluated.

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

martong added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:550-551 + if (isUselessSugar(LType.getTypePtr())) { +LLVM_DEBUG(llvm::dbgs() + << "--- calculateMixability. LHS is useless sugar.\n");

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

martong added a comment. Perhaps all conversion related logic should go into their own implementation file? Seems like it adds up to roughly 1000 lines. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:1171 +

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

aaron.ballman added reviewers: rsmith, rjmccall. aaron.ballman added inline comments. Comment at: clang/docs/UsersManual.rst:1484 + Where unsafe floating point optimizations are enabled, this option + determines whether the optimizer honors parentheses when floating-point +

[PATCH] D103685: [clangd] Drop TestTUs dependency on gtest

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:75 + if (llvm::sys::fs::createUniqueDirectory("module-cache", ModuleCachePath)) +llvm_unreachable("Failed to create temp directory for module-cache");

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

martong added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:122 #define FB(Name, K) MIX_##Name = (1ull << (K##ull - 1ull)) whisperity wrote: > martong wrote: > > FB stands for FunnyBitmask? Could you

[clang] 86c2449 - [OpenCL][NFC] Test commit: tidy up whitespace in comment

Author: Stuart Brady Date: 2021-06-04T14:44:12+01:00 New Revision: 86c24493ea666a0ef91b7af884d616b0a181e849 URL: https://github.com/llvm/llvm-project/commit/86c24493ea666a0ef91b7af884d616b0a181e849 DIFF: https://github.com/llvm/llvm-project/commit/86c24493ea666a0ef91b7af884d616b0a181e849.diff

[PATCH] D103587: [AIX] Transfer predefined macros

Jake-Egan updated this revision to Diff 349855. Jake-Egan added a comment. Use LangStandard::isC11() and one C99 test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103587/new/ https://reviews.llvm.org/D103587 Files:

[PATCH] D101630: [HIP] Fix device-only compilation

yaxunl added a comment. In D101630#2792160 , @tra wrote: > In D101630#2792052 , @yaxunl wrote: > >> I think for intermediate outputs e.g. preprocessor expansion, IR, and >> assembly, probably it makes sense not

[PATCH] D103587: [AIX] Transfer predefined macros

Jake-Egan updated this revision to Diff 349854. Jake-Egan marked 3 inline comments as done. Jake-Egan added a comment. Use LangStandard::isC11() and one C99 test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103587/new/

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong added a comment. In D103314#2790868 , @vsavchenko wrote: > Awesome! > I know, I said that we are ready to land, but I think I was too excited about > this change. We probably should have some data on how it performs on > real-life codebases.

[PATCH] D103605: [analyzer] Introduce a new interface for tracking

martong added a comment. In D103605#2798171 , @NoQ wrote: > Ok. Oof. Whoa. That's amazing. > > Let me re-iterate to make sure that my understanding of this patchset is > correct. > > **Chapter 1.** //"A is correlated with B (ρ = 0.56), given C, assuming

[PATCH] D103281: [HIP] Fix spack HIP device lib detection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5dea8701ba9: [HIP] Fix spack HIP device lib detection (authored by yaxunl). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] b5dea87 - [HIP] Fix spack HIP device lib detection

Author: Yaxun (Sam) Liu Date: 2021-06-04T09:12:41-04:00 New Revision: b5dea8701ba98425991d4f1ec3d87bdb98789e04 URL: https://github.com/llvm/llvm-project/commit/b5dea8701ba98425991d4f1ec3d87bdb98789e04 DIFF:

[PATCH] D103519: [clang][deps] Support object files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde07b1e84d8d: [clang][deps] Support object files (authored by jansvoboda11). Changed prior to commit:

[PATCH] D103613: [flang][driver] Add support for `-module-suffix`

This revision was automatically updated to reflect the committed changes. Closed by commit rG20bd2142d465: [flang][driver] Add support for `-module-suffix` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103613/new/

[clang] de07b1e - [clang][deps] Support object files

Author: Jan Svoboda Date: 2021-06-04T14:58:42+02:00 New Revision: de07b1e84d8de948304766df602fee2b845e9532 URL: https://github.com/llvm/llvm-project/commit/de07b1e84d8de948304766df602fee2b845e9532 DIFF: https://github.com/llvm/llvm-project/commit/de07b1e84d8de948304766df602fee2b845e9532.diff

[clang] 20bd214 - [flang][driver] Add support for `-module-suffix`

Author: Andrzej Warzynski Date: 2021-06-04T13:58:04+01:00 New Revision: 20bd2142d46536f4ffd61f28a029d6bda68f1a7f URL: https://github.com/llvm/llvm-project/commit/20bd2142d46536f4ffd61f28a029d6bda68f1a7f DIFF:

  1   2   >