[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead updated this revision to Diff 383970. pcwang-thead added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Removes unnecessary -fno-sized-deallocation and some comments. Repository: rG LLVM Github Monorepo

[PATCH] D112926: run-clang-tidy.py analyze unique files only

serkazi updated this revision to Diff 383959. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112926/new/ https://reviews.llvm.org/D112926 Files: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

aqjune added a comment. I am not familiar with inline assembly, but it seems the output variable (`%0`) is not updated because it does not appear in the code. 1382 __asm__ __volatile__( 1383"mov x0,x2\n" /* flags */ 1384"mov x2,x4\n" /*

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead updated this revision to Diff 383953. pcwang-thead added a comment. - Changes to `Args.AddLastArg(CmdArgs, ...)` - Adds a note to `clang/docs/ReleaseNotes.rst` - Fixs clangd test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109496: [clang] deprecate frelaxed-template-template-args, make it on by default

yaxunl added a comment. This caused regression in Thrust: /long_pathname_so_that_rpms_can_package_the_debug_info/data/driver/rocThrust/thrust/../thrust/detail/type_traits/pointer_traits.h:178:20: error: ambiguous partial specializations of 'pointer_element>' typedef typename

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD updated this revision to Diff 383952. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-arch.c

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0198d76e1e76: [Bazel] Get `//clang` building on Windows with clang-cl. (authored by chandlerc). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

chandlerc added inline comments. Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:1828 ], -copts = [ -"-Wno-uninitialized", -], +copts = select({ +"@bazel_tools//src/conditions:windows": [], rnk wrote: > Enabling

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

chandlerc added a comment. In D112883#3101685 , @GMNGeoffrey wrote: >> Is this breaking actual users? I wouldn't expect it to break unless they >> depend on this target. > > I don't know :-) I just know that people have sent me patches to remove the >

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

rjmccall added a comment. Thanks. @hubert.reinterpretcast, @qiucf, can you verify that other compilers for PPC follow the logic for `TF` / `TC` that we now have with Elizabeth's patch? There are three different type specifiers (`long double`, `__ibm128`, and `float128_t`) which represent

[PATCH] D112903: [C++20] [Module] Fix front end crashes when trying to export a type out of a module

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5748-5750 +else if (isa(Cur)) + Diag(Loc, diag::err_invalid_declarator_in_export) + << Name << cast(DC) << SS.getRange(); aaron.ballman wrote: > I don't believe this is

[PATCH] D112975: Fix complex types declared using mode TC

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. For posterity in case someone tracks down this review: `TC` corresponds to an unspecified 128-bit format, which on some targets is a double-double format (like `__ibm128_t`) and on others

[PATCH] D111477: DO NOT SUBMIT: workaround for context-sensitive use of non-type-template-parameter integer suffixes

shafik added a comment. I think this is fine as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111477/new/ https://reviews.llvm.org/D111477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

eandrews added a comment. In D109950#3097652 , @rjmccall wrote: > In D109950#3097544 , @eandrews > wrote: > >> In D109950#3097161 , @rjmccall >> wrote: >> >>> Oh, yes,

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

GMNGeoffrey added a comment. In D112883#3101665 , @chandlerc wrote: > In D112883#3101645 , @GMNGeoffrey > wrote: > >> :-( Did you try the separate library with `strip_include_prefix`? > > I can add a

[PATCH] D112975: Fix complex types declared using mode TC

eandrews created this revision. eandrews added reviewers: qiucf, rjmccall. eandrews requested review of this revision. This patch reverts incorrect IR - introduced in commit d11ec6f67e45

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

chandlerc added a comment. Thanks, making suggested changes and then landing! Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:364 +# Clang-specific define on non-Windows platforms. +"CLANG_HAVE_RLIMITS=1", +],

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

chandlerc added a comment. In D112883#3101645 , @GMNGeoffrey wrote: > :-( Did you try the separate library with `strip_include_prefix`? I can add a separate library to do that. It would still expose all consumers to `Opcodes.inc` instead of only

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

GMNGeoffrey added inline comments. Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:711 +# headers such as `CXXABI.h`. +"-I$(GENDIR)/external/llvm-project/clang/lib/AST", +"-I$(GENDIR)/external/llvm-project/clang/lib/AST/Interp",

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

GMNGeoffrey added a comment. :-( Did you try the separate library with `strip_include_prefix`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112883/new/ https://reviews.llvm.org/D112883 ___

[PATCH] D112916: Confusable identifiers detection

MaskRay added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-homoglyph.cpp:4 +int fo; +// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: fo is confusable with 퐟o [misc-homoglyph] +int 퐟o; `[[@LINE-1]]` is deprecated lit feature. Use

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

emaste added a comment. In D111863#3100654 , @lhames wrote: > @joerg @dim @emaste Any further comments on this? I have no objection. 2016 (when I patched FreeBSD's in-tree libunwind) is long enough ago that I don't recall any of the context but indeed

[PATCH] D112913: Misleading bidirectional detection

MaskRay added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-misleading-bidirectional.cpp:1 +// RUN: %check_clang_tidy %s misc-misleading-bidirectional %t + The test misses many interesting cases. Repository: rG LLVM Github

[PATCH] D112913: Misleading bidirectional detection

MaskRay requested changes to this revision. MaskRay added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.cpp:19 + +static bool ContainsMisleadingBidi(StringRef Buffer, bool HonorLineBreaks=true) { + const char* CurPtr = Buffer.begin();

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1fdd745d510: Re-introduce `copts` hacks for lib/AST includes. (authored by chandlerc). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo

[PATCH] D112913: Misleading bidirectional detection

MaskRay added a comment. > Context not available. If you don't use `arc diff 'HEAD^'` to upload a Diff, please use -U9 https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at:

[PATCH] D111477: DO NOT SUBMIT: workaround for context-sensitive use of non-type-template-parameter integer suffixes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bf12445383b: DebugInfo: workaround for context-sensitive use of non-type-template-parameter… (authored by dblaikie). Herald added a project:

[clang] 8bf1244 - DebugInfo: workaround for context-sensitive use of non-type-template-parameter integer suffixes

Author: David Blaikie Date: 2021-11-01T17:08:26-07:00 New Revision: 8bf12445383b2f3149a9d095bfbc0f6d5b00dfaa URL: https://github.com/llvm/llvm-project/commit/8bf12445383b2f3149a9d095bfbc0f6d5b00dfaa DIFF: https://github.com/llvm/llvm-project/commit/8bf12445383b2f3149a9d095bfbc0f6d5b00dfaa.diff

[PATCH] D112094: Add support for floating-point option `ffp-eval-method` and for `pragma clang fp eval_method`.

andrew.w.kaylor added a comment. Herald added a subscriber: luke957. I agree that the pragma should also control the evaluation of constant expressions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112094/new/ https://reviews.llvm.org/D112094

[PATCH] D112971: [NFC] Remove LinkAll*.h

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112971/new/ https://reviews.llvm.org/D112971

[PATCH] D112971: [NFC] Remove LinkAll*.h

aeubanks created this revision. Herald added a subscriber: hiraditya. aeubanks requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a reviewer: jdoerfert. Herald added a reviewer: sstefan1. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added a

[PATCH] D95168: [clang-format] Add InsertBraces option

owenpan added a comment. In D95168#3100376 , @HazardyKnusperkeks wrote: > In D95168#3099920 , @owenpan wrote: > >> In D95168#3099739 , @MyDeveloperDay >> wrote: >> >>> -

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:92 -struct AddressSanitizerOptions { - AddressSanitizerOptions() vitalybuka wrote: > Why do we need to remove AddressSanitizerOptions? Adding it back

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov updated this revision to Diff 383921. kstoimenov marked an inline comment as done. kstoimenov added a comment. Update after discussing with vitalybuka@. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/

[PATCH] D100917: [NewPM] Only invalidate modified functions' analyses in CGSCC passes

aeubanks added a comment. Herald added a reviewer: ctetreau. I rebased this and there are still major memory regressions for tramp3d-v4: https://llvm-compile-time-tracker.com/compare.php?from=f63405f6e3d30f33e715ef5ad09136127535a3fb=aec1375e4afe90727f1c30dae1659d11a20d=max-rss Perhaps we

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

yonghong-song added a comment. Just to be sure my understanding is correct. Given an AttributedType node, we do have a way to get the corresponding Attr, is it right? @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99/new/

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

dblaikie added a comment. In D107049#3100630 , @rnk wrote: > So, to back up a bit, do I understand correctly that this change adds tests > to the check-clang test suite that JIT compiles C++ code for the host and > throws C++ exceptions? Can we

[PATCH] D112628: NOT READY FOR REVIEW Nothing to see here, just exporting to show this to someone.

dblaikie added a comment. Rather than sending a review to the lists that you don't need review for, you can create draft reviews that send no mail and share them manually with your intended audience, discussed/documented here:

[PATCH] D112913: Misleading bidirectional detection

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp:61 +CheckFactories.registerCheck( +"misc-misleading-bidirectional"); } Nit: please keep alphabetical order in the list of jobs. Repository:

[PATCH] D112914: Misleading identifier detection

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good as far as it goes (though I've not checked your classification functions are correct). We should have some detection for RTL characters in string literals and comments too, at

[PATCH] D112913: Misleading bidirectional detection

carlosgalvezp requested changes to this revision. carlosgalvezp added a comment. This revision now requires changes to proceed. Nice addition! Please add this check to the documentation (list of available checks + individual page with the documentation for this check), plus mention in the

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5001 + case ISD::INTRINSIC_VOID: { +if (N->getConstantOperandVal(1) == Intrinsic::ppc_tdw || +N->getConstantOperandVal(1) == Intrinsic::ppc_tw) { Might be a good

[PATCH] D112913: Misleading bidirectional detection

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Nits and a suggested approach for invalid code sequences that's probably important to handle better. Please fix the clang-tidy findings too. Otherwise, LGTM. Comment at:

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin added a comment. In D112881#3100214 , @Eugene.Zelenko wrote: > Please mention improvement in Release Notes, in `Changes in existing checks` > section. See example >

[PATCH] D112965: [GlobalDCE][IR] Allow and support multiple !vcall_visibility ranges

kubamracek created this revision. kubamracek added reviewers: pcc, rjmccall, fhahn. kubamracek added a project: LLVM. Herald added subscribers: ormris, dexonsmith, hiraditya. kubamracek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D112916: Confusable identifiers detection

rsmith added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/CMakeLists.txt:9 +add_custom_command( +OUTPUT confusables.h +COMMAND make_confusable_table ${CMAKE_CURRENT_SOURCE_DIR}/ConfusableTable/confusables.txt ${CMAKE_CURRENT_BINARY_DIR}/confusables.h

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin updated this revision to Diff 383905. paulaltin added a comment. Attempting to fix failed patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin updated this revision to Diff 383904. paulaltin added a comment. Attempting to fix failed patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin updated this revision to Diff 383901. paulaltin added a comment. Fix pre-merge tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp

[PATCH] D112001: [Clang] Add min/max reduction builtins.

fhahn updated this revision to Diff 383900. fhahn added a comment. In D112001#3099965 , @aaron.ballman wrote: > Precommit CI looks to be failing. > > > /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/builtins-reduction-math.c:13:9: >

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin updated this revision to Diff 383898. paulaltin added a comment. Updated release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin updated this revision to Diff 383893. paulaltin added a comment. Fix pre-merge tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

craig.topper added a comment. In D105690#3101129 , @craig.topper wrote: > This patch as committed, deleted 5 test files instead of renaming them. I'm > working on restoring them. Deleted tests have been restored by

[PATCH] D112645: [OpenMP] Fix: opposite attributes could be set by -fno-inline

igor.kirillov updated this revision to Diff 383892. igor.kirillov added a comment. Remove my old test for the change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112645/new/ https://reviews.llvm.org/D112645 Files:

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. :( LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112883/new/ https://reviews.llvm.org/D112883 ___ cfe-commits mailing list

[clang] 670c72f - [RISCV] Restore tests for vf(w)redusum.

Author: Craig Topper Date: 2021-11-01T14:35:22-07:00 New Revision: 670c72f6f70434500d1475e1524a7088814fbc73 URL: https://github.com/llvm/llvm-project/commit/670c72f6f70434500d1475e1524a7088814fbc73 DIFF: https://github.com/llvm/llvm-project/commit/670c72f6f70434500d1475e1524a7088814fbc73.diff

[PATCH] D112645: [OpenMP] Fix: opposite attributes could be set by -fno-inline

igor.kirillov updated this revision to Diff 383890. igor.kirillov marked an inline comment as not done. igor.kirillov added a comment. Update test, remove redundant code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112645/new/

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

GMNGeoffrey accepted this revision. GMNGeoffrey added inline comments. This revision is now accepted and ready to land. Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:364 +# Clang-specific define on non-Windows platforms. +

[PATCH] D112664: [clang-format][docs] fix indentation of rst code block

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. This should be Format.h, didn't we recently fix this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112664/new/

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

craig.topper added a comment. Herald added subscribers: VincentWu, luke957. This patch as committed, deleted 5 test files instead of renaming them. I'm working on restoring them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105690/new/

[PATCH] D112492: [HIP] Do not use kernel handle for MSVC target

tra added a comment. As phrased the summary would likely be rather confusing for anyone other than you and me. > Currently Visual Studio 2019 has a linker issue which causes linking error > when a template kernel is instantiated in different compilation units. It's not clear what exactly is

Re: r307232 - [modules ts] Do not emit strong function definitions from the module interface unit in every user.

Ping On Tue, Sep 21, 2021 at 7:58 PM David Blaikie wrote: > Ping > > On Sun, Sep 5, 2021 at 11:28 AM David Blaikie wrote: > >> Hey Richard - was just going back over some of the modular codegen code >> (due to a discussion on the EWG mailing list about file extensions that >> ended up touching

[PATCH] D95168: [clang-format] Add InsertBraces option

MyDeveloperDay added a comment. In D95168#3099920 , @owenpan wrote: > In D95168#3099739 , @MyDeveloperDay > wrote: > >> - Look further into possible Removal (I have an idea for how this might be >> possible, and

[clang] a82a844 - [clang][deps] Keep #pragma push_macro, pop_macro and include_alias when minimizing source code.

Author: Sylvain Audi Date: 2021-11-01T16:04:52-04:00 New Revision: a82a844961a55c8a5879453ce0e78774b33bf06a URL: https://github.com/llvm/llvm-project/commit/a82a844961a55c8a5879453ce0e78774b33bf06a DIFF: https://github.com/llvm/llvm-project/commit/a82a844961a55c8a5879453ce0e78774b33bf06a.diff

[PATCH] D112088: [clang][deps] Keep #pragma push_macro, pop_macro and include_alias when minimizing source code.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa82a844961a5: [clang][deps] Keep #pragma push_macro, pop_macro and include_alias when… (authored by saudi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

lhames added a comment. In D107049#3096727 , @uabelho wrote: > Hi, > > We're seeing a problem with this patch in our downstream (not public) > buildbots. With an asan-built compiler we see the following: > > ... > 10:08:55 [ RUN ]

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

dblaikie added a comment. In D99#3099988 , @aaron.ballman wrote: > In D99#3097692 , @dblaikie > wrote: > >> In D99#3096124 , >> @aaron.ballman wrote: >>

[clang] d51a829 - Revert "[clang] Fortify warning for scanf calls with field width too big."

Author: Michael Benfield Date: 2021-11-01T19:36:45Z New Revision: d51a8296d374122c937df708f5fa1500218baa5c URL: https://github.com/llvm/llvm-project/commit/d51a8296d374122c937df708f5fa1500218baa5c DIFF: https://github.com/llvm/llvm-project/commit/d51a8296d374122c937df708f5fa1500218baa5c.diff

[PATCH] D112645: [OpenMP] Fix: opposite attributes could be set by -fno-inline

jhuber6 added inline comments. Comment at: clang/test/OpenMP/parallel_for_noinline.cpp:1 +// RUN: %clang -O0 -fopenmp -fno-inline %s -S -emit-llvm -o - | FileCheck %s --check-prefixes=CHECK,CHECK-O0 +// RUN: %clang -O1 -fopenmp -fno-inline %s -S -emit-llvm -o - | FileCheck %s

[PATCH] D112645: [OpenMP] Fix: opposite attributes could be set by -fno-inline

igor.kirillov added inline comments. Comment at: clang/test/OpenMP/parallel_for_noinline.cpp:1 +// RUN: %clang -O0 -fopenmp -fno-inline %s -S -emit-llvm -o - | FileCheck %s --check-prefixes=CHECK,CHECK-O0 +// RUN: %clang -O1 -fopenmp -fno-inline %s -S -emit-llvm -o - |

[clang] dfa0981 - Remove an unused parameter; NFC

Author: Aaron Ballman Date: 2021-11-01T14:42:00-04:00 New Revision: dfa098140716cc41cfc8b83f3f083008e7219bf9 URL: https://github.com/llvm/llvm-project/commit/dfa098140716cc41cfc8b83f3f083008e7219bf9 DIFF: https://github.com/llvm/llvm-project/commit/dfa098140716cc41cfc8b83f3f083008e7219bf9.diff

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

vitalybuka added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:92 -struct AddressSanitizerOptions { - AddressSanitizerOptions() Why do we need to remove AddressSanitizerOptions? Comment at:

[PATCH] D112941: [clang] Add support for the new pointer authentication builtins.

ab created this revision. ab added reviewers: rjmccall, ahatanak, bruno, pcc, apazos, kristof.beyls, t.p.northover, pbarrio, chill, danielkiss, psmith. ab added a project: clang. Herald added subscribers: dexonsmith, zzheng, dang, mgorny. ab requested review of this revision. Building on D90868

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

rnk added inline comments. Comment at: utils/bazel/.bazelrc:81 +build:windows --copt=/Oi --host_copt=/Oi +build:windows --cxxopt=/Zc:rvalueCast --host_cxxopt=/Zc:rvalueCast + Try adding `/permissive-` to get more conforming behavior from clang-cl. If that

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

lhames accepted this revision. lhames added a comment. @joerg @dim @emaste Any further comments on this? I'd like @housel to be able to land this this week if possible. It will significantly improve the usability of libunwind for JIT clients by giving us an API with behavior that is consistent

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

rzurob accepted this revision. rzurob added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112847/new/ https://reviews.llvm.org/D112847

[PATCH] D112491: Add `LambdaCapture`-related matchers.

fowles added a comment. This is great! Comment at: clang/docs/LibASTMatchersReference.html:8368 +lambdaExpr(hasAnyCapture(lambdaCapture(capturesVar(hasName("x", +capturesVar(hasName("x")) matches `int x` and `x = 1`. I think this should be "matches `x`

[PATCH] D112890: headers: optionalise some generated resource headers

rnk added a comment. I think this seems reasonable. Generally speaking, we have tests in clang that generate IR for targets that are not enabled in LLVM. It is kind of nice: you don't have to mark the IRGen tests with `REQUIRES: foo-registered-target`. If we want to test these ARM and RISCV

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

rnk added a subscriber: dblaikie. rnk added a comment. So, to back up a bit, do I understand correctly that this change adds tests to the check-clang test suite that JIT compiles C++ code for the host and throws C++ exceptions? Can we reconsider that? We have a policy of not running execution

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

rnk added a comment. Please add a note to clang/docs/ReleaseNotes.rst about the behavior change. The clangd test failure seems related to this change, and the other ones could be as well. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6405 + // by default. + if (Arg *A

[PATCH] D111833: [clang] Fortify warning for scanf calls with field width too big.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a8c1736289f: [clang] Fortify warning for scanf calls with field width too big. (authored by mbenfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5a8c173 - [clang] Fortify warning for scanf calls with field width too big.

Author: Michael Benfield Date: 2021-11-01T17:17:37Z New Revision: 5a8c1736289f2b1df10df38e7a9e4d208a7586a6 URL: https://github.com/llvm/llvm-project/commit/5a8c1736289f2b1df10df38e7a9e4d208a7586a6 DIFF: https://github.com/llvm/llvm-project/commit/5a8c1736289f2b1df10df38e7a9e4d208a7586a6.diff

[PATCH] D112491: Add `LambdaCapture`-related matchers.

jcking1034 updated this revision to Diff 383823. jcking1034 marked 4 inline comments as done. jcking1034 added a comment. Update missed names; remove original implementations of `hasAnyCapture`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112732: [ASan] Removed AddressSanitizerPass function pass class and rolled it into the module pass for the new pass mangager only.

kstoimenov updated this revision to Diff 383819. kstoimenov added a comment. Fixed remaing 2 tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

ASDenysPetrov updated this revision to Diff 383812. ASDenysPetrov added a comment. Updated according to comments. TODO: make the feature `-fno-strict-aliasing` dependent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110927/new/ https://reviews.llvm.org/D110927 Files:

[PATCH] D112850: [clang] 'unused-but-set-variable' warning should not apply to __block objective-c pointers

mbenfield added a comment. This seems reasonable to me, but I don't know Objective C. Presumably someone who does should accept. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112850/new/ https://reviews.llvm.org/D112850

[PATCH] D112932: [WIP] Use llvm.is_fpclass to implement FP classification functions

sepavloff created this revision. sepavloff requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Builtin floating-point number classification functions: - __builtin_isnan, - __builtin_isinf, - __builtin_finite, and - __builtin_isnormal now are

[PATCH] D95168: [clang-format] Add InsertBraces option

HazardyKnusperkeks added a comment. In D95168#3099920 , @owenpan wrote: > In D95168#3099739 , @MyDeveloperDay > wrote: > >> - Look further into possible Removal (I have an idea for how this might be >> possible,

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

ZarkoCA updated this revision to Diff 383805. ZarkoCA added a comment. - Remove comma from product name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112847/new/ https://reviews.llvm.org/D112847 Files:

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

ZarkoCA updated this revision to Diff 383804. ZarkoCA added a comment. - Remove V from version number Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112847/new/ https://reviews.llvm.org/D112847 Files:

[PATCH] D112647: [clang-apply-replacements] Correctly handle relative paths

ymandel added a comment. Overall, this looks ok, but I don't feel like I'm qualified to approve this patch, since I'm not really familiar w/ how this tool is used in practice. Some comments nonetheless: > Those relative paths are meant to be resolved relative to the corresponding > build

[PATCH] D112929: [Clang] For VFE, emit vtable ranges in !vcall_visibility metadata

kubamracek created this revision. kubamracek added reviewers: rjmccall, pcc, fhahn. kubamracek added a project: clang. kubamracek requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112929 Files: clang/lib/CodeGen/CGVTables.cpp

[PATCH] D112492: [HIP] Do not use kernel handle for MSVC target

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112492/new/ https://reviews.llvm.org/D112492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

yaxunl added a comment. ping. I have made changes so that the diagnostics about sanitizer args are only emitted once. Any further changes or concerns? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111443/new/ https://reviews.llvm.org/D111443

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

rzurob requested changes to this revision. rzurob added a comment. This revision now requires changes to proceed. Please change to "IBM XL C/C++ for AIX 16.1.0". i.e. No ", V". Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112847/new/

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

Eugene.Zelenko added a comment. Please mention improvement in Release Notes, in `Changes in existing checks` section. See example . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Please hold a few days to see whether there are inputs from other reviewers. Thanks. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:100 + static SmallDenseMap

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. I checked the reason for failure in address sanitizer tests on the 2-stage aarch64 buildbots. The buildbot failure was occured because the `internal_clone` function of the `compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp` file is being compiled incorrectly.

[PATCH] D112645: [OpenMP] Fix: opposite attributes could be set by -fno-inline

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5370 if (CGM.getCodeGenOpts().OptimizationLevel != 0) Fn->addFnAttr(llvm::Attribute::AlwaysInline); return

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

asavonic updated this revision to Diff 383794. asavonic added a comment. - Added a test for SYCL. - Excluded functions marked with C++ `delete` from the check. - Moved the check function from `ActOnFunctionDeclarator` to `ActOnFinishFunctionBody`, because the deleted/defaulted property is not

  1   2   >