[PATCH] D124818: [clang-format][NFC] Clean up tryToParseLambdaIntroducer()

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124818/new/ https://reviews.llvm.org/D124818

[PATCH] D124611: [RISCV][Clang] add more tests for clang driver. (NFC)

craig.topper added inline comments. Comment at: clang/test/Driver/riscv-arch.c:541 +// RUN: FileCheck -check-prefix=RV32-ZVE32F-GOOD %s +// RV32-ZVE32F-GOOD: "-target-feature" "+zve32f" Do we have tests for zve64*? Repository: rG LLVM Github Monorepo

[PATCH] D120862: Sema: Allow scoped enums as source type for integral conversion.

pcc added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120862/new/ https://reviews.llvm.org/D120862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D124818: [clang-format][NFC] Clean up tryToParseLambdaIntroducer()

owenpan created this revision. owenpan added reviewers: HazardyKnusperkeks, curdeius, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D124816: [Tooling] add ToolingFileManager to force using abs path

Kale created this revision. Herald added a subscriber: dexonsmith. Herald added a project: All. Kale requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ClangTool will make FileManager mix up two header files with the same relative path in

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

qcolombet added a subscriber: vitalybuka. qcolombet added a comment. Hi @thakis , @dyung , @vitalybuka, Thanks for the heads-up and the revert. Fixed clang tests included in the diff. Cheers, -Quentin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124699: [DeadArgElim] Set unused arguments for internal functions

qcolombet updated this revision to Diff 426555. qcolombet added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - includes fixes to clang tests that were missed in the original commit. If someone knows who we can add from the clang side to double check the tests

[PATCH] D124815: [libclang] Fall back to getMainExecutable when dladdr fails

aykevl created this revision. aykevl added reviewers: MaskRay, rsmith. Herald added subscribers: StephenFan, arphaman. Herald added a project: All. aykevl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. musl-libc doesn't support dladdr in

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

LegalizeAdulthood added a comment. In D124650#3486859 , @njames93 wrote: > I've done my own implementation, but its definitely over engineered, WDYT? > D124806 Hey, that looks great at a glance. I need to prepare for

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

tianshilei1992 added inline comments. Comment at: clang/include/clang/AST/ASTNodeTraverser.h:217 void Visit(const OMPClause *C) { +if(OMPFailClause::classof(C)) { + Visit(static_cast(C)); clang-format plz. Comment at:

[PATCH] D123831: [clang][extract-api] Use relative includes

zixuw updated this revision to Diff 426547. zixuw added a comment. Convert file path to use slashes for headermap reverse lookup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123831/new/ https://reviews.llvm.org/D123831 Files:

[clang] 32eb7b8 - [Driver][test] Remove clang{{.*}} when testing -cc1 command lines

Author: Weverything Date: 2022-05-02T17:08:20-07:00 New Revision: 32eb7b863e49222882afae39ca9f2888ee5cc7a0 URL: https://github.com/llvm/llvm-project/commit/32eb7b863e49222882afae39ca9f2888ee5cc7a0 DIFF: https://github.com/llvm/llvm-project/commit/32eb7b863e49222882afae39ca9f2888ee5cc7a0.diff

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

dschuff added a comment. In D123763#3485836 , @sbc100 wrote: > This new test has been failing on the emscripten builders.. seemingly ever > since it landed: This uses a fairly old sysroot. I tried with a new version of libcxx, and it seems to be

[PATCH] D124813: [HLSL] Add clang builtin for HLSL.

python3kgae created this revision. python3kgae added reviewers: anakryiko, ast, yonghong-song, beanz, pow2clk. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D117112: [AArch64] Support for Ampere1 core

philipp.tomsich updated this revision to Diff 426541. philipp.tomsich added a comment. Adds two fixes for issues uncovered by the CI: - The update of NumAArch64CPUArchs had been lost in a "rebase gone wrong" (i.e., another target was added and the previously increased-by-1 value now was the

[PATCH] D123831: [clang][extract-api] Use relative includes

zixuw updated this revision to Diff 426540. zixuw added a comment. - Delete test `known_files_only_hmap` - Handle quoted includes - Attempt to fix Windows fails by converting backslashes before matching the framework regex - Update test `relative_include` Repository: rG LLVM Github Monorepo

[PATCH] D124724: [Clang][OpenMP] Add the support for floating-point variables for specific atomic clauses

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. In D124724#3486921 , @tianshilei1992 wrote: > always use `UIToFP` because that is the only case that `UpdateVal` is a > `ConstantInt`, where

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

kstoimenov added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadataFactory.h:33 + +class SanitizerMetadataFactory { + SanitizerMetadataFactory(const SanitizerMetadataFactory &) = delete; Not sure if this class follows the 'factory' design pattern,

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

jhuber6 added inline comments. Comment at: clang/test/Driver/openmp-offload-gpu-new.c:56 + +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -ccc-print-bindings -fopenmp \ +// RUN: -fopenmp-targets=nvptx64-nvidia-cuda,amdgcn-amd-amdhsa

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadataFactory.h:6 +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===--===// vitalybuka wrote: > can

[PATCH] D124724: [Clang][OpenMP] Add the support for floating-point variables for specific atomic clauses

tianshilei1992 updated this revision to Diff 426532. tianshilei1992 added a comment. always use `UIToFP` because that is the only case that `UpdateVal` is a `ConstantInt`, where we created the constant integer for `++` or `--` operation. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

tra added a comment. Comment at: clang/test/Driver/openmp-offload-gpu-new.c:56 + +// RUN: %clang -### --target=x86_64-unknown-linux-gnu -ccc-print-bindings -fopenmp \ +// RUN: -fopenmp-targets=nvptx64-nvidia-cuda,amdgcn-amd-amdhsa -Xopenmp-target=nvptx64-nvidia-cuda

[PATCH] D124767: [Clang] Map .gcda paths according to -fcoverage-prefix-map

vit9696 added a comment. Got it. To be honest, I cannot imagine a situation where one would prefer to keep separate behaviour, and with GCC it would be exactly just one. In my view, if we introduce -fprofile-prefix-map, it should rather mirror the entire -fcoverage-prefix-map behaviour, not

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

vitalybuka added a comment. In D124493#3477432 , @filcab wrote: > Hi @hctim, thanks for the patch. > I have one question, though. Do you really need to remove the information you > removed? > Some people might be testing ASan binaries without access to

[PATCH] D124767: [Clang] Map .gcda paths according to -fcoverage-prefix-map

keith added a comment. I took this comment from the issue: > Since the feature you're proposing is specific to gcov, using a separate flag > that matches the name used by GCC would be preferable to me. To mean that we should introduce a new flag matching gcc's name. I think in general fewer

[PATCH] D124807: [clang][dataflow] Avoid assert for invalid cast to BoolValue

li.zhe.hua updated this revision to Diff 426528. li.zhe.hua added a comment. Remove else after return Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124807/new/ https://reviews.llvm.org/D124807 Files:

[PATCH] D124807: [clang][dataflow] Avoid assert for invalid cast to BoolValue

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. Herald added subscribers: tschuett, steakhal. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `IgnoreParenImpCasts` will remove

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

kstoimenov added a comment. One meta-observation: can you split this into smaller patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124493/new/ https://reviews.llvm.org/D124493 ___ cfe-commits

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

njames93 added a comment. I've done my own implementation, but its definitely over engineered, WDYT? D124806 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124650/new/ https://reviews.llvm.org/D124650 ___

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

rsmith added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2442 + +This builtin does not return a value. + erichkeane wrote: > I don't know if anyone would be using this value, but I wonder if there is > value to making this a 'sum' of the

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

rsmith updated this revision to Diff 426525. rsmith marked 3 inline comments as done. rsmith added a comment. - Add requested assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124221/new/ https://reviews.llvm.org/D124221 Files:

[PATCH] D124721: [OpenMP] Allow compiling multiple target architectures with OpenMP

jhuber6 updated this revision to Diff 426521. jhuber6 added a comment. Changing slightly, I'm using the `getArgsForToolchain` to only get the `--offload-arch` options for that toolchain. This lets us quality it with options like `-Xopenmp-target=` so we can now specify architectures

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

rsmith updated this revision to Diff 426520. rsmith added a comment. - Use printing policy more, and turn off anonymous tag locations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124221/new/ https://reviews.llvm.org/D124221 Files:

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

rsmith updated this revision to Diff 426517. rsmith marked 5 inline comments as done. rsmith added a comment. - Respond to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124221/new/ https://reviews.llvm.org/D124221 Files:

[PATCH] D124724: [Clang][OpenMP] Add the support for floating-point variables for specific atomic clauses

tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5936-5939 + CGF.Builder.CreateCast(X.getType()->hasSignedIntegerRepresentation() + ? llvm::Instruction::CastOps::SIToFP +

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added a comment. I was able to find a reproduction of the problem: template struct is_same { static constexpr bool value = false; }; template struct is_same { static constexpr bool value = false; }; template concept same_as = is_same::value; template

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:99 + + if (!Current->isLiteral() || isStringLiteral(Current->getKind()) || + !isIntegralConstant(*Current)) {

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:99 + + if (!Current->isLiteral() || isStringLiteral(Current->getKind()) || + !isIntegralConstant(*Current)) { LegalizeAdulthood

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:99 + + if (!Current->isLiteral() || isStringLiteral(Current->getKind()) || + !isIntegralConstant(*Current)) { aaron.ballman

[PATCH] D124767: [Clang] Map .gcda paths according to -fcoverage-prefix-map

vit9696 added a comment. In D124767#3486286 , @keith wrote: > Based on the issue it sounds like this should be gated behind a new > `-fprofile-prefix-map` flag? I assume we'd also want `-ffile-prefix-map` to > apply to it as well, similar to the

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added a comment. In D119544#3486573 , @gulfem wrote: >> Then pipe that to a file (note the -E I added at the end). You should get a >> file that looks like some slightly-wonky C++ code. > > I got the following output after running it via

[PATCH] D124359: [clangd] Add inlay hints for mutable reference parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rG043e96502408: [clangd] Add inlay hints for mutable reference parameters (authored by upsj, committed by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 043e965 - [clangd] Add inlay hints for mutable reference parameters

Author: Tobias Ribizel Date: 2022-05-02T15:57:23-04:00 New Revision: 043e9650240866701bee89922d54bf7af059ed30 URL: https://github.com/llvm/llvm-project/commit/043e9650240866701bee89922d54bf7af059ed30 DIFF:

[PATCH] D104975: Implement P1949

intractabilis added a comment. I hope at least GCC will not implement this arbitrary restriction on math symbols. I would argue a partial derivative symbol in C++ has more sense than a skull emoji. P.S. I would love to see features like `std::jthread` in Clang instead of removing math symbols

[PATCH] D119544: Deferred Concept Instantiation Implementation

gulfem added a comment. > Then pipe that to a file (note the -E I added at the end). You should get a > file that looks like some slightly-wonky C++ code. I got the following output after running it via `-E`.

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

void added a comment. In D123763#3485836 , @sbc100 wrote: > This new test has been failing on the emscripten builders.. seemingly ever > since it landed: > >

[PATCH] D121150: [pseudo][WIP] Implement a GLR parser.

hokein updated this revision to Diff 426493. hokein added a comment. Fix the bad format from lint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121150/new/ https://reviews.llvm.org/D121150 Files:

[PATCH] D124694: [randstruct] Move initializer check to be more effective

void added a comment. In D124694#3486547 , @void wrote: > In D124694#3485585 , @aaron.ballman > wrote: > >> struct t { >> int a, b, c, d, e; >> } x = { .a = 2, 4, 5, 6 }; >> >> This situation seems like

[PATCH] D124694: [randstruct] Move initializer check to be more effective

void added a comment. In D124694#3485585 , @aaron.ballman wrote: > struct t { > int a, b, c, d, e; > } x = { .a = 2, 4, 5, 6 }; > > This situation seems like it should be an error, shouldn't it? The user > specified one designated initializer

[PATCH] D124642: [WIP] Add support for return from an SEH __finally block.

efriedma added a comment. I'm currently thinking it makes sense to introduce an intrinsic "void @llvm.localunwind() noreturn". No arguments. Only valid with SEH personality; must unwind to a catchpad with a filter named __IsLocalUnwind, or something like that. It would basically just lower

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

dblaikie added a comment. In D123319#3474997 , @dblaikie wrote: > In D123319#3473693 , @shafik wrote: > >> In D123319#3473283 , @dblaikie >> wrote: >> >>> ('scuse the

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

mstorsjo added a comment. In D121175#3486104 , @phosek wrote: > In D121175#3481547 , @MaskRay wrote: > >> Probably no from my view, as I got another internal feedback that "this >> seems rather crufty". >> It

[PATCH] D121150: [pseudo][WIP] Implement a GLR parser.

hokein updated this revision to Diff 426488. hokein marked an inline comment as done. hokein added a comment. Herald added a project: clang-tools-extra. Updates: - a derived version of D122408 and D121368 ; - refine the APIs,

[PATCH] D104975: Implement P1949

sdowney added a comment. In D104975#3486313 , @intractabilis wrote: > Can you roll this back and don't support P1949 > ? For some inexplicable reason ∂, 휕 partial > derivative symbols are now not supported. Neither as

[PATCH] D124642: [WIP] Add support for return from an SEH __finally block.

efriedma updated this revision to Diff 426486. efriedma edited the summary of this revision. efriedma added a comment. Figured out the __finally nesting thing; we were missing unwind table entries. (This is a consequence of the fact that our unwind tables don't cover the entire function, just

[PATCH] D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources

akyrtzi added a comment. In D124687#3485710 , @tschuett wrote: > Could you split this into smaller patches? I'll split up the renames to a separate patch so that it is easier to see the code that affects functionality. Not sure if it can be broken

[PATCH] D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources

akyrtzi added inline comments. Comment at: clang/include/clang/Lex/PreprocessorOptions.h:214 + FileEntryRef)> + DependencyDirectivesForFile; jansvoboda11 wrote: > To be honest, I'm not a fan of using `PreprocessorOptions` to carry state > between

[PATCH] D104975: Implement P1949

aaron.ballman added a comment. In D104975#3486313 , @intractabilis wrote: > Can you roll this back and don't support P1949 > ? No; P1949 was adopted for C++23, so this is effectively a

[clang] 4d34c4e - [OpenMP] Fix -Wswitch (due to new OMPC_cancellation_construct_type) after D123828

Author: Fangrui Song Date: 2022-05-02T12:10:09-07:00 New Revision: 4d34c4e0e67d321ac6b52f787648a68ea6d267c0 URL: https://github.com/llvm/llvm-project/commit/4d34c4e0e67d321ac6b52f787648a68ea6d267c0 DIFF: https://github.com/llvm/llvm-project/commit/4d34c4e0e67d321ac6b52f787648a68ea6d267c0.diff

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

cishida added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1036 + +// This file is a system header or C++ unfriendly if the dir is. HFI.DirInfo = CurDir->getDirCharacteristic(); tschuett wrote: > Why did the comment move? It refers to

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added a comment. In D119544#3486385 , @gulfem wrote: > In D119544#3486241 , @erichkeane > wrote: > >> Ah shucks... Thanks for the heads up. Is there any chance to get you to get >> me a

[PATCH] D119544: Deferred Concept Instantiation Implementation

gulfem added a comment. In D119544#3486241 , @erichkeane wrote: > Ah shucks... Thanks for the heads up. Is there any chance to get you to get > me a pre-processed version of this failure to play with? I've not had luck > compiling/running libc++

[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

nhaehnle added a comment. In D124158#3486110 , @jdoerfert wrote: > I agree. As far as I can tell you have two options, both are specific to the > shuffle functions: > > 1. Do not set noundef for calls to them as they allow undef values for all > lanes

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

cishida added a comment. In D124638#3481932 , @jansvoboda11 wrote: > Can you describe how come the check is not reliable without this patch? It > might be worth fixing the underlying reason for the unreliability first. Different search paths alter

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 updated this revision to Diff 426467. jhuber6 added a comment. Updating code generation. Previously we would seg-fault in the case that no offloading entries were created. To solve this we simply check that Begin != End before trying to register anything. Repository: rG LLVM Github

[PATCH] D104975: Implement P1949

intractabilis added a comment. Herald added a project: All. Can you roll this back and don't support P1949 ? For some inexplicable reason ∂, 휕 partial derivative symbols are now not supported. Neither as XID_Start nor as XID_Continue. Where is logic in that? It

[PATCH] D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime

rnk added a comment. Thanks! In D124762#3485478 , @sgraenitz wrote: > I guess testing must be split in two: > > - Clang wants to make sure the "funclet" bundle operand gets emitted for ObjC > ARC runtime calls on Windows. Maybe that fits into >

[PATCH] D124767: [Clang] Map .gcda paths according to -fcoverage-prefix-map

keith added a comment. Based on the issue it sounds like this should be gated behind a new `-fprofile-prefix-map` flag? I assume we'd also want `-ffile-prefix-map` to apply to it as well, similar to the others. And we'll definitely want some tests here! Repository: rG LLVM Github Monorepo

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

yihanaa added a comment. Do we need to do argument promotion here，ahh...maybe i understood wrong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124221/new/ https://reviews.llvm.org/D124221 ___

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae created this revision. python3kgae added reviewers: Anastasia, aaron.ballman, beanz, pow2clk. Herald added a subscriber: dexonsmith. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project:

[clang] 45c07db - Revert "Re-apply 4b6c2cd642 "Deferred Concept Instantiation Implementation"""

Author: Erich Keane Date: 2022-05-02T11:12:14-07:00 New Revision: 45c07db31cc76802a1a2e41bed1ce9c1b8198181 URL: https://github.com/llvm/llvm-project/commit/45c07db31cc76802a1a2e41bed1ce9c1b8198181 DIFF: https://github.com/llvm/llvm-project/commit/45c07db31cc76802a1a2e41bed1ce9c1b8198181.diff

[clang] 2ed0123 - [PS5] Check for HasNativeLLVMSupport

Author: Paul Robinson Date: 2022-05-02T11:06:33-07:00 New Revision: 2ed0123b7fedd6360b0dc06cab9721f108123a98 URL: https://github.com/llvm/llvm-project/commit/2ed0123b7fedd6360b0dc06cab9721f108123a98 DIFF: https://github.com/llvm/llvm-project/commit/2ed0123b7fedd6360b0dc06cab9721f108123a98.diff

[clang] 214265b - [NFC] Add test for HasNativeLLVMSupport

Author: Paul Robinson Date: 2022-05-02T11:06:33-07:00 New Revision: 214265bce9dfe3a86d9e8e8869d58ee7eded20fa URL: https://github.com/llvm/llvm-project/commit/214265bce9dfe3a86d9e8e8869d58ee7eded20fa DIFF: https://github.com/llvm/llvm-project/commit/214265bce9dfe3a86d9e8e8869d58ee7eded20fa.diff

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added a comment. In D119544#3486227 , @gulfem wrote: > We started seeing several test failures after this commit: > https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8815265760499763361/overview > > One example

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

yihanaa added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:573 + // We don't know how to print this field. Print out its address + // with a format specifier that a smart tool will be able to + // recognize and treat specially.

[PATCH] D119544: Deferred Concept Instantiation Implementation

gulfem added a comment. We started seeing several test failures after this commit: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8815265760499763361/overview One example is `nothrow_forward_range.compile.pass.cpp`. Script: -- : 'COMPILED WITH';

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1264 + ()) + << "--"; + }); Get rid of the ——. It’s not a remark and only kind of makes sense

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

scott.linder added a comment. Even with newlines forced via extra remarks, I'm not a big fan of the "---" remark; it doesn't interact well with other random remarks in the output, for example when I enable all remarks using the pattern '.*' I see: remark: foo.cl:27:0:

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

yihanaa added a comment. This implementation looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124221/new/ https://reviews.llvm.org/D124221 ___ cfe-commits mailing list

[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

jdoerfert added a comment. In D124158#3480566 , @efriedma wrote: > In D124158#3480384 , @arsenm wrote: > >> I'm thinking noundef is a bit of red herring here. The real problem seems to >> be arising from the

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

phosek added a comment. In D121175#3481547 , @MaskRay wrote: > Probably no from my view, as I got another internal feedback that "this seems > rather crufty". > It seems that it is the build system maintainer's responsibility. If you add >

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

aaron.ballman added a comment. In D124500#3485924 , @LegalizeAdulthood wrote: > In D124500#3485462 , @aaron.ballman > wrote: > >> I largely agree, but I've found cases where we'll convert correct code to >>

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

amyk added inline comments. Comment at: llvm/test/CodeGen/PowerPC/fast-isel-fcmp-nan.ll:5 ; CHECK-LABEL: TestULT: -; CHECK: xscmpudp +; CHECK: fcmpu ; CHECK: blr nemanjai wrote: > Why do we not emit the VSX instructions here any longer? How are crbits >

[PATCH] D122663: Mark identifier prefixes as substitutable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfed7be096f8e: Mark identifier prefixes as substitutable (authored by hvdijk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fed7be0 - Mark identifier prefixes as substitutable

Author: Harald van Dijk Date: 2022-05-02T18:07:47+01:00 New Revision: fed7be096f8ed5d70029acd712ac19ffc61e04e5 URL: https://github.com/llvm/llvm-project/commit/fed7be096f8ed5d70029acd712ac19ffc61e04e5 DIFF:

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. amyk marked an inline comment as done. Closed by commit rG2534dc120a4c: [PowerPC] Enable CR bits support for Power8 and above. (authored by amyk). Changed prior to

[clang] 2534dc1 - [PowerPC] Enable CR bits support for Power8 and above.

Author: Amy Kwan Date: 2022-05-02T12:06:15-05:00 New Revision: 2534dc120a4c9468d9a0044665a50361089f0a4d URL: https://github.com/llvm/llvm-project/commit/2534dc120a4c9468d9a0044665a50361089f0a4d DIFF: https://github.com/llvm/llvm-project/commit/2534dc120a4c9468d9a0044665a50361089f0a4d.diff

[clang] 3d09c9b - [Driver][test] Avoiding producing object file in the current directory

Author: Fangrui Song Date: 2022-05-02T10:00:57-07:00 New Revision: 3d09c9b30fe6484717181a926e14b2ee36747d13 URL: https://github.com/llvm/llvm-project/commit/3d09c9b30fe6484717181a926e14b2ee36747d13 DIFF: https://github.com/llvm/llvm-project/commit/3d09c9b30fe6484717181a926e14b2ee36747d13.diff

[PATCH] D123810: [Cuda] Add initial support for wrapping CUDA images in the new driver.

jhuber6 updated this revision to Diff 426437. jhuber6 added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123810/new/ https://reviews.llvm.org/D123810 Files: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp

[PATCH] D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:598-599 + auto UnlessNotLHS = unless(hasLHS(NotOp)); + // match !(!a || b) +

[PATCH] D124621: [Analyzer] Fix assumptions about const field with member-initializer

r.stahl accepted this revision. r.stahl added a comment. I can confirm the issue with my patch, so this piece of code needs to be removed. As long as the following test still succeeds, this looks good to me. Back then, the analyzer was not able to cover that case without that addition.

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:99 + + if (!Current->isLiteral() || isStringLiteral(Current->getKind()) || + !isIntegralConstant(*Current)) { aaron.ballman

[PATCH] D124669: [flang][driver] Add support for -save-temps

unterumarmung added inline comments. Comment at: clang/include/clang/Driver/Options.td:4131 def : Flag<["-"], "no-integrated-as">, Alias, - Flags<[CC1Option, NoXarchOption]>; + Flags<[CC1Option,FlangOption,NoXarchOption]>; rovka wrote: > awarzynski

[PATCH] D124702: [MSVC] Add support for pragma function

steplong updated this revision to Diff 426433. steplong edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124702/new/ https://reviews.llvm.org/D124702 Files: clang/include/clang/Parse/Parser.h

[clang] 46cc04d - [Driver][test] Add back some -no-canonical-prefixes

Author: Fangrui Song Date: 2022-05-02T09:35:58-07:00 New Revision: 46cc04de341bceef319144fa11b0d421d29c5451 URL: https://github.com/llvm/llvm-project/commit/46cc04de341bceef319144fa11b0d421d29c5451 DIFF: https://github.com/llvm/llvm-project/commit/46cc04de341bceef319144fa11b0d421d29c5451.diff

[PATCH] D119296: KCFI sanitizer

joaomoreira added a comment. In D119296#3483176 , @nickdesaulniers wrote: > In D119296#3481573 , @joaomoreira > wrote: > >> I'm not an expert on LLVM's pipeline, but it just feels a little awkward and >>

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

cor3ntin added a comment. note to self. @aaron.ballman noticed this patch doesn't handle leading attributes correctly constexpr int asp = 5; [=] [[gnu::regparm(asp)]] () {}; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/

[PATCH] D124708: Fix "the the" typo in documentation and user facing strings

Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land. I see some test time-outs, but they seem to happen quite often. LGTM, but please wait a few days before landing this patch to give other reviewers time to have a look. Repository: rG

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

LegalizeAdulthood added a comment. In D124500#3485462 , @aaron.ballman wrote: > In D124500#3483328 , > @LegalizeAdulthood wrote: > >> In D124500#3483224 , >>

[PATCH] D124621: [Analyzer] Fix assumptions about const field with member-initializer

steakhal added a comment. In D124621#3485799 , @mantognini wrote: > Thanks for the tip. I had to fix a thing or two to get SATest.py working with > my setup (I'll try to upstream those fixes at some point). However, these > projects do not highlight

  1   2   3   >