[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

echristo accepted this revision. echristo added a comment. Explicitly still ok with this as well. Thanks for continuing here. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86310/new/ https://reviews.llvm.org/D86310

[PATCH] D141547: Fix format for `case` in .proto files

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141547/new/ https://reviews.llvm.org/D141547

[PATCH] D127812: [AArch64] Function multiversioning support added.

echristo added a comment. In D127812#3616603 , @danielkiss wrote: > In D127812#3602688 , @aaron.ballman > wrote: > >> In D127812#3602645 , @erichkeane >> wrote: >> >>>

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

echristo added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPUtility.cpp:119-133 + // Add MC directives to embed target binaries. We ensure that each + // section and image is 16-byte aligned. This is not mandatory, but + // increases the likelihood of data to

[PATCH] D51650: Implement target_clones multiversioning

echristo added a comment. FWIW I'm a bit rusty in this area myself, but thanks for doing this. Let's see if we can't get Aaron to continue reviewing :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51650/new/ https://reviews.llvm.org/D51650

[PATCH] D103125: [Clang][WIP] Allow renaming of "clang"

echristo added a comment. I'm also not a fan of this change. From a project perspective the binary is clang and while people may wish to change the name for their own product teams it seems like that onus should be on them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101867: [clang][test] Update -fc++-abi tests

echristo added a comment. Couple cleanups, but should be better now. Thanks! -eric Comment at: clang/test/Driver/cxx-abi-flag.cpp:3 +// RUN: %clang -### -fc++-abi=itanium -target x86_64-unknown-linux-gnu %s \ +// RUN: |& FileCheck %s -check-prefix=ITANIUM +// RUN: %clang

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

echristo added inline comments. Comment at: clang/test/Frontend/invalid-cxx-abi.cpp:1 +// These should succeed. +// RUN: %clang -c -fc++-abi=itanium %s Following up on an offline conversation :) This should be a driver test rather than (what it ended up being)

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

echristo added a comment. In D100776#2699603 , @thakis wrote: > In D100776#2699565 , @rnk wrote: > >> Of the three people who commented on D17183 >> , you and I are on the only

[PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

echristo added a comment. In D17183#2656771 , @jyknight wrote: > In general, I think it's extremely unfortunate that Clang and LLVM have > different copies of the same information. It's a problem for way more than > just this one situation. So, I really

[PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

echristo added a comment. In addition to the bikeshed below, I'm not a huge fan of this in general. I think we should assume that the libc we link is complete and thus it would just be named "libc." and in a sysroot somewhere. Another option is perhaps looking at the rtlib option, but I'd want

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

echristo added a comment. Exclusion list? or exclude? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96203/new/ https://reviews.llvm.org/D96203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96906: [AMDGPU] gfx90a support

echristo added a comment. In D96906#2572842 , @msearles wrote: > In D96906#2572749 , @kzhuravl wrote: > >>> The point is that nobody upstream even got a chance to chime in. >> >> We are and will be taking care of

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

echristo added a reviewer: vitalybuka. echristo added a comment. In D96203#2548495 , @aaron.ballman wrote: > In D96203#2548471 , @mibintc wrote: > >> In D96203#2546856 ,

[PATCH] D63852: [Clang] Move assembler into a separate file

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Thanks for the explanation, lgtm. -eric Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63852/new/ https://reviews.llvm.org/D63852

[PATCH] D89158: [NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0

echristo added a comment. In D89158#2363220 , @aeubanks wrote: > Looking at BackendUtil.cpp in Clang as well as the Rust code, I'm back to > thinking that we should provide a way to to all callbacks. Then in the case > of passes added via TargetMachine,

[PATCH] D89184: Support complex target features combinations

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Let's go ahead and unblock you, but getting a lot of this refactored would be great if you can. I think it's hitting the limits of the original design. :) CHANGES SINCE LAST ACTION

[PATCH] D89184: Support complex target features combinations

echristo added a comment. I'll take a look tomorrow, sorry for the delay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89184/new/ https://reviews.llvm.org/D89184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89184: Support complex target features combinations

echristo requested changes to this revision. echristo added a comment. This revision now requires changes to proceed. Mark as requesting changes :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89184/new/ https://reviews.llvm.org/D89184 ___

[PATCH] D89184: Support complex target features combinations

echristo added a comment. Hi Peng, Looks interesting, but I think the language support needs some more comments about what's expected and in addition through everything else please? I've added some inline comments with places I think could use it for sure. -eric Comment

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

echristo added a comment. Hi All, I'd really like to avoid depending on any program other than clang installing something into clang's working directory. I think this needs to be written from the perspective of specifying another directory to look for things. -eric CHANGES SINCE LAST ACTION

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

echristo added a comment. In D83273#2194842 , @nickdesaulniers wrote: > In D83273#2194832 , @craig.topper > wrote: > >> It's a pretty nasty revert in our downstream tree where we have prototyped >> future ISAs.

[PATCH] D84058: Pass -rtlib=libgcc in tests conditioned on the default.

echristo added a reviewer: saugustine. echristo added a comment. (Adding Sterling as well) I think this will be an OK workaround for now, go ahead and reply on the main thread as I think they'll want to set the default runtime library as part of the toolchain. I'm surprised at this behavior as

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

echristo added a comment. In D83360#2154637 , @aqjune wrote: > In D83360#2154584 , @echristo wrote: > > > It's that even before the msan instrumentation the IR doesn't look correct > > - thus a miscompile. > > >

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

echristo added a comment. It's that even before the msan instrumentation the IR doesn't look correct - thus a miscompile. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

echristo added a comment. We're starting to see miscompiles as we do more testing as well, just nothing smaller at the moment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

echristo added a comment. This seems like something that we should then revert until we know that instsimplify can be updated with a fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360

[PATCH] D83897: [X86] Add a generic 32-bit CPU with sse2 with modern tuning flags to be used as the default for the 32-bit targets instead of pentium4

echristo added a comment. Did you want to just change the pentium4 tuning? Otherwise naming things is hard and this feels awkward, but I don't have any better ideas :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83897/new/ https://reviews.llvm.org/D83897

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

echristo added a comment. Some inline nits. I see you've already committed and that's fine - I still don't think we should do it, but we can delete it again soon :) Comment at: clang/lib/CodeGen/BackendUtil.cpp:623 PMBuilder.LoopVectorize = CodeGenOpts.VectorizeLoop; +

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Works for me :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83273/new/ https://reviews.llvm.org/D83273 ___ cfe-commits mailing

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

echristo added reviewers: chandlerc, asbirlea. echristo added a comment. Adding Chandler and Alina here as well. In general, I don't think that this is such a great idea. Being able to have this sort of thing work more reliably is one of the reasons for the new pass manager. I think I'd like

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo closed this revision. echristo added a comment. Committed a while back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 ___ cfe-commits mailing list

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

echristo added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict sanitizer coverage instrumentation exclusively to modules and functions that match the provided special case list, except the blacklisted ones MaskRay wrote:

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Couple of inline comments then looks good to go. Thank you so much for your effort here. -eric Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

echristo added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:313-316 +.. option:: -mharden-sls= + +Select straight-line speculation hardening scope + Miss merge? Comment at: clang/docs/ClangCommandLineReference.rst:891

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

echristo added a reviewer: HAPPY. echristo added a comment. You'll want to grab blacklist/whitelist in the comments around as well. We've been talking about having a need for deprecated aliases file for these options - it's probably worth bringing this patch up on cfe-dev and cc'ing

[PATCH] D63852: [Clang] Move assembler into a separate file

echristo added a comment. Hmm. In general I'd like to hear more about what you're trying. Can you give an idea of how you'd like to invoke the library to assemble something via clang? Why not just call into llvm directly? I'm not necessarily against changing the layering here fwiw, just wanted

[PATCH] D80883: [Driver] Add multiclass OptInFlag and OptOutFlag to simplify boolean option definition

echristo accepted this revision. echristo added a comment. This looks good to me. Might want to open a project around migrating everything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80883/new/ https://reviews.llvm.org/D80883

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo updated this revision to Diff 267424. echristo marked an inline comment as done. echristo added a comment. Update and restructure some test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo marked 7 inline comments as done. echristo added a comment. Done. New diff incoming. Comment at: clang/test/Misc/loop-opt-setup.c:12 +// Check br i1 to make sure that the loop is fully unrolled // CHECK-NOT: br i1 chandlerc wrote: > This is dead

[PATCH] D79117: [clang] [Darwin] Add reverse mappings for aarch64/aarch64_32 to darwin arch names

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This seems ok to me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79117/new/ https://reviews.llvm.org/D79117

[PATCH] D43002: Emit S_OBJNAME symbol in CodeView

echristo added a comment. First question: Since split dwarf has to do some similar things can we not use the same support? This seems to be a lot of changes for this. Second question: and if we can't use the same support can we make split dwarf use this? Having two separate methods for

[PATCH] D79916: Map -O to -O1 instead of -O2

echristo accepted this revision. echristo added a reviewer: dexonsmith. echristo added a comment. This revision is now accepted and ready to land. I'm totally down, but you knew that already :) Duncan: Do you have any concerns? I doubt it, but just checking. Repository: rG LLVM Github

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo marked 6 inline comments as done. echristo added a comment. OK, ready again :) Comment at: llvm/test/Transforms/LoopUnroll/FullUnroll.ll:4-6 +; We don't end up deleting the loop, but we remove everything inside of it so checking for any +; reasonable instruction from

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo updated this revision to Diff 262458. echristo added a comment. Update and reduce testcase a bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 Files: clang/test/Misc/loop-opt-setup.c

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo updated this revision to Diff 261928. echristo edited the summary of this revision. echristo added a comment. Herald added a subscriber: zzheng. Add a testcase with opt and command line option so we can enable it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79210: Let clang print registered targets for --version

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Yeah, it's fine. We might want to put it behind a "long information" option, but for now it's ok. Keep an eye open if someone complains please. CHANGES SINCE LAST ACTION

[PATCH] D79210: Let clang print registered targets for --version

echristo added a comment. LGTM if it works? Can you post the output into the commit message so we can review that here? I guess clang -v or something? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79210/new/ https://reviews.llvm.org/D79210

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

echristo added a subscriber: erichkeane. echristo added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9749 + if (isBetterMultiversionCandidate(Cand1, Cand2)) +return true; + rjmccall wrote: > yaxunl wrote: > > rjmccall wrote: > > > If we move

[PATCH] D76297: [clang][AArch64] readd support for 'p' inline asm constraint

echristo added inline comments. Comment at: clang/test/CodeGen/inline-asm-p-constraint.c:1 +// RUN: %clang_cc1 -emit-llvm %s -o - -triple aarch64-linux-gnu | FileCheck %s +void foo(void* ptr) { nickdesaulniers wrote: > Does this need `REQUIRES:

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo updated this revision to Diff 250232. echristo added a comment. Fix comments around full unroller. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 Files: clang/test/Misc/loop-opt-setup.c

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo updated this revision to Diff 250229. echristo added a comment. Fixed the clang test. Tried to get something that I could reduce down and duplicate with just opt but it's been... difficult. Even the small clang testcase in isolation won't duplicate via something like: clang -O0

[PATCH] D75152: Fix typo

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This probably qualifies as "obvious" :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75152/new/ https://reviews.llvm.org/D75152

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

echristo added a comment. In D70172#1879481 , @jpienaar wrote: > This seems to result in triggering clang/lib/CodeGen/CGExpr.cpp:2626 when > compiling mlir/lib/Transforms/AffineDataCopyGeneration.cpp with clang build > with assertions on (clean build at

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

echristo added a comment. Sadly I'm just noticing this: I don't really agree with the rationale for adding fortran support to the clang driver. My proposed design here would be to move the aspects you need out of clang and into a separate library in llvm that you can use instead. I don't

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo added a comment. Ping ping goes the trolley. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo created this revision. echristo added reviewers: chandlerc, hfinkel, asbirlea. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, mcrosier. Herald added projects: clang, LLVM. echristo updated this revision to Diff 234656. echristo added a comment. Formatting and parens

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo updated this revision to Diff 234656. echristo added a comment. Formatting and parens changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 Files: clang/test/Misc/loop-opt-setup.c

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

echristo updated this revision to Diff 233857. echristo added a comment. Fix for some slightly better API uses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71486/new/ https://reviews.llvm.org/D71486 Files:

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5623bd52acd3: Fix -Wswitch-coverage warning in clang-tidy after ak_addrspace introduction. (authored by echristo).

[PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

echristo created this revision. echristo added reviewers: Anastasia, sammccall. echristo added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mcrosier. Herald added a project: clang. echristo added a subscriber: rdhindsa. ... I think this is right? Add support in the switch

[PATCH] D71393: Default to -fno-use-init-array

echristo added a comment. Fan of this change, but let's definitely wait for more reviews :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71393/new/ https://reviews.llvm.org/D71393 ___ cfe-commits

[PATCH] D71320: [IR] Split out target specific intrinsic enums into separate headers

echristo accepted this revision. echristo added a comment. SGTM and thank you :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71320/new/ https://reviews.llvm.org/D71320 ___ cfe-commits mailing list

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rGfd39b1bb20ce: Revert Revert As a follow-up to my initial mail to llvm-dev heres a first… (authored by echristo). Herald

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ff85ed905a7: As a follow-up to my initial mail to llvm-dev heres a first pass at the O1… (authored by echristo). Changed prior to commit: https://reviews.llvm.org/D65410?vs=228339=230987#toc

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

echristo added a comment. In D62731#1749916 , @mibintc wrote: > Thanks I see it, I'm working on a patch. Previously there was no support for > frounding-math (unimplemented). This patch enables the option. In the IR > builder, there's a call to a

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

echristo added a comment. Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65410/new/ https://reviews.llvm.org/D65410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

echristo updated this revision to Diff 228339. echristo added a comment. Update to remove comments around SROA addition. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65410/new/ https://reviews.llvm.org/D65410 Files: clang/test/CodeGen/2008-07-30-implicit-initialization.c

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

echristo updated this revision to Diff 228338. echristo marked an inline comment as done. echristo added a comment. Herald added subscribers: aheejin, sbc100, nhaehnle, jvesely. I've gone ahead and enabled SROA here. In the testing I've done so far it's helped execute time quite a bit and

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

echristo added a comment. I kinda want the option to be encoded in the triple for earlier testing of linking issues, but for now this is probably OK. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795

[PATCH] D68255: [X86] Remove AVX/AVX512 check from validateOperandSize, just always accept 512

echristo added a comment. The idea was that we'd have a much more graceful error message as well as a way for the front end to do the diagnosis. The code is being called out of SemaStmtAsm.cpp and I'm pretty sure we can probably accumulate the target attributes there? -eric CHANGES SINCE

[PATCH] D68535: Fix loop unrolling initialization in the new pass manager

echristo created this revision. echristo added reviewers: chandlerc, hfinkel. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, mcrosier. Herald added projects: clang, LLVM. In the new pass manager use PTO.LoopUnrolling to determine when and how we will unroll loops. Also comment a

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

echristo added reviewers: mboehme, krasimir. echristo added a comment. Martin should know who should look at this... maybe Krasimir? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67627/new/ https://reviews.llvm.org/D67627

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

echristo added a comment. In D65410#1613555 , @hfinkel wrote: > Thanks for starting on this. Can you go ahead and replace the sroa calls with > mem2reg calls for `O1` and then see what that does to the performance? That > strikes me as a major change,

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

echristo created this revision. echristo added reviewers: chandlerc, hfinkel. Herald added subscribers: cfe-commits, jfb, dexonsmith, steven_wu, hiraditya, javed.absar, mcrosier, mehdi_amini. Herald added projects: clang, LLVM. As a follow-up to my initial mail to llvm-dev here's a first pass at

[PATCH] D64540: [CGDebugInfo] Simplfiy EmitFunctionDecl parameters, NFC

echristo added a comment. Not a huge fan of boolean parameters like this, perhaps factor out the context as well into the caller and then we don't need it at all? Something else? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64540/new/ https://reviews.llvm.org/D64540

[PATCH] D62133: test/CodeGen/builtin-stackaddress.c duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL362462: Remove test/CodeGen/builtin-stackaddress.c as it duplicates (authored by echristo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62133: test/CodeGen/builtin-stackaddress.c duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c

echristo added a comment. done thusly: echristo@jhereg ~/s/llvm-project> git llvm push Pushing 1 commit: d91813ca8c7 Remove test/CodeGen/builtin-stackaddress.c as it duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c. Deleting cfe/trunk/test/CodeGen/builtin-stackaddress.c

[PATCH] D62133: test/CodeGen/builtin-stackaddress.c duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62133/new/ https://reviews.llvm.org/D62133 ___

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

echristo added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1104-1105 // which is just that always inlining occurs. - MPM.addPass(AlwaysInlinerPass()); + // We always pass false here since according to the legacy PM logic for + // enabling

[PATCH] D61464: [RiscV] Typo in register aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rL360104: Fix typo in risc-v register aliases. (authored by echristo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

echristo added reviewers: saugustine, cmatthews. echristo added a comment. Adding Sterling and Chris to this to take a look at the new layout :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59168/new/ https://reviews.llvm.org/D59168 ___

[PATCH] D61464: [RiscV] Typo in register aliases

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Sorry I didn't notice this earlier. -eric CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61464/new/ https://reviews.llvm.org/D61464

[PATCH] D56181: [CMake][Fuchsia] Include check-lld in the list of bootstrap targets

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This seems like the sort of thing that you can just commit in the future. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56181/new/

[PATCH] D56043: [Driver] Don't pass default value to getCompilerRTArgString

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56043/new/ https://reviews.llvm.org/D56043 ___

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. OK, that makes sense. I'm not a huge fan of how this set of code looks, but it also seems unfair to require you to extensively refactor it for this. Any issues with crtbegin/end and where

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

echristo added a comment. Is something passing compiler-rt in as a -r link output or something? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56044/new/ https://reviews.llvm.org/D56044 ___ cfe-commits mailing list

[PATCH] D51554: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support.

echristo accepted this revision. echristo added a comment. LGTM. I'm quite a bit happier with this now. Thanks for going through the back and forth. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51554/new/ https://reviews.llvm.org/D51554

[PATCH] D51554: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support.

echristo added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:282-285 enum DebugInfoKind { - NoDebug, /// No debug info. - LineTableOnly, /// Line tables only. - FullDebug /// Full debug info. + NoDebug, /// No debug info. +

[PATCH] D55016: Correctly support -shared-libgcc.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. -eric Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55016/new/ https://reviews.llvm.org/D55016 ___

[PATCH] D51554: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support.

echristo added a comment. The llvm backend patch here has discussion around debug info kinds that we should iron out first. Comment at: lib/Driver/ToolChains/Cuda.cpp:292 + bool IsDebugEnabled = !A || A->getOption().matches(options::OPT_O0) || +

[PATCH] D54243: DebugInfo: Add a driver flag for DWARF debug_ranges base address specifier use.

echristo added a comment. I have no other bikeshed colors here. :) Repository: rC Clang https://reviews.llvm.org/D54243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52296: [Clang] - Add -gsingle-file-split-dwarf option.

echristo added a comment. In https://reviews.llvm.org/D52296#1285328, @grimar wrote: > In https://reviews.llvm.org/D52296#1284130, @probinson wrote: > > > In https://reviews.llvm.org/D52296#1283691, @grimar wrote: > > > > > Nice :) > > > So seems the last unresolved question left is the naming

[PATCH] D53919: [X86] Don't allow illegal vector types to return by direct value on x86-64.

echristo added a comment. In https://reviews.llvm.org/D53919#1282994, @hjl.tools wrote: > In https://reviews.llvm.org/D53919#1282952, @efriedma wrote: > > > With both 3.3 and trunk (I don't have a 7.0 handy; I can build it if it > > would be helpful): > > > Please try clang 2.6 on both

[PATCH] D52296: [Clang] - Add -gsingle-file-split-dwarf option.

echristo added a comment. In https://reviews.llvm.org/D52296#1246142, @grimar wrote: > In https://reviews.llvm.org/D52296#1243688, @echristo wrote: > > > In https://reviews.llvm.org/D52296#1241928, @probinson wrote: > > > > > Do we generate the .dwo file directly these days? If not, I can

[PATCH] D53586: Implement Function Multiversioning for Non-ELF Systems.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. All of the target specific stuff looks fine to me. I'm going to defer to rnk about the windows side of things and aaron for the attributes. https://reviews.llvm.org/D53586

[PATCH] D52441: [CodeGen] Update min-legal-vector width based on function argument and return types

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D52441#1271545, @rnk wrote: > In https://reviews.llvm.org/D52441#1258317, @craig.topper wrote: > > > Address Reid's comments. Add a comment with a list of all

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

echristo added a reviewer: aprantl. echristo added a comment. I think Adrian has looked at this more recently than I have. Adding him here. Repository: rC Clang https://reviews.llvm.org/D38061 ___ cfe-commits mailing list

[PATCH] D53248: [Driver] Support direct split DWARF emission for Fuchsia

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. I'm ok with the "here are a bunch of fuchsia tests" file :) -eric Repository: rC Clang https://reviews.llvm.org/D53248 ___ cfe-commits

[PATCH] D52920: Introduce code_model macros

echristo added a comment. LGTM as well. Thanks! Repository: rL LLVM https://reviews.llvm.org/D52920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   >