[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

SouraVX added a comment. In D104118#2813358 , @stuart wrote: > Note: there is currently no DWARF language code defined for //C++ for > OpenCL//, so we must use DW_LANG_C_plus_plus* if we wish to be able to > determine whether output has been generated

[PATCH] D96777: [clang][driver] Set the input type to Fortran when reading from stdin

SouraVX accepted this revision. SouraVX added a comment. This revision is now accepted and ready to land. Thanks! for the patch. This code touches some of the `clang` part, Anyway changes are pretty self-explanatory. I'll leave this one to you, if you want land it or wait from someone from

[PATCH] D96864: [flang][driver] Add -Xflang and make -test-io a frontend-only flag

SouraVX added inline comments. Comment at: flang/test/Frontend/input-output-file.f90:6 !-- +! NOTE: We need `-E` below in order to instruct the compiler driver to create a job representing a fronted compiler invocation ! TEST 1: Print to stdout

[PATCH] D96864: [flang][driver] Add -Xflang and make -test-io a frontend-only flag

SouraVX added inline comments. Comment at: flang/test/Frontend/input-output-file.f90:6 !-- +! NOTE: We need `-E` below in order to instruct the compiler driver to create a job representing a fronted compiler invocation ! TEST 1: Print to stdout

[PATCH] D96864: [flang][driver] Add -Xflang and make -test-io a frontend-only flag

SouraVX added a comment. Thanks! for the patch @awarzynski . I support this enhancement. LGTM(Not accepting formally :) ), Let's wait and hear from others also, what's their take on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96864/new/

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

SouraVX accepted this revision. SouraVX added a comment. LGTM! - Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93301/new/ https://reviews.llvm.org/D93301 ___ cfe-commits mailing list

[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`

SouraVX added a comment. Thanks! for the patch, some minor comments inlined. Rest LGTM. Let others also have a look. Comment at: clang/include/clang/Driver/Options.td:4329 HelpText<"Generate machine code, but discard output">; -def emit_obj : Flag<["-"], "emit-obj">, -

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

SouraVX accepted this revision. SouraVX added a comment. This revision is now accepted and ready to land. Thanks for your patience. LGTM! at least the part I reviewed. Though I would vote for having another approval(From some senior folks in community) Repository: rG LLVM Github Monorepo

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

SouraVX added a comment. Thanks for the patch! Overall it's in pretty nice state and conformant to design highlighted. Could you please `clang-format` this patch, There are lot of `lint` warning that causes lot of noise while reviewing. Couple of NIT comments inline. I've tried marking all

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

SouraVX added inline comments. Comment at: flang/tools/flang-driver/fc1_main.cpp:1 +//===-- fc1_main.cpp - Flang FC1 Compiler Frontend ===// +// This file-name seems odd considering LLVM style. How about just `Flang.cpp` or

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

SouraVX accepted this revision. SouraVX added a comment. This revision is now accepted and ready to land. In D82470#2118814 , @jdoerfert wrote: > In D82470#2116581 , @SouraVX wrote: > > > Overall this seems great

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

SouraVX added a comment. Overall this seems great Thanks! I have one minor concern: This patch seems to do 2 things: Support for nested parallel regions(which was crashing earlier) and some infrastructure change(introducing AllocBuilder..). I'm not sure of this, but is it possible to separate

[PATCH] D80197: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rGd20bf5a7258d: [DebugInfo] Upgrade DISubrange to support Fortran dynamic arrays (authored by alok, committed by SouraVX). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

This revision was automatically updated to reflect the committed changes. Closed by commit rG7a42babeb83e: Reland [DebugInfo][clang][DWARF5]: Added support for debuginfo generation for… (authored by awpandey, committed by SouraVX). Changed prior to commit:

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2b437d53d40: [DebugInfo][clang][DWARF5]: Added support for debuginfo generation for… (authored by awpandey, committed by SouraVX). Changed prior to commit:

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

SouraVX added a comment. Thanks @sammccall , for the test case. Seems like, this implementation doesn't address the lambda functions returning "auto". We're looking into this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70524/new/

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc958639098a8: [DWARF5][DebugInfo]: Added support for DebugInfo generation for auto return… (authored by awpandey, committed by SouraVX). Changed prior to commit:

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

SouraVX added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:169 +* C DebugInfo API ``LLVMDIBuilderCreateTypedef`` is updated to include an extra +argument ``AlignInBits``, to facilitate / propagate specified Alignment information

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

SouraVX added a comment. > It looks like this implementation is a bit buggy in one way and incomplete in > another: > > 1. even if the auto-returning function is defined, that function definition > doesn't describe the concrete return type. Compare GCC and Clang's output for > your example

[PATCH] D71185: [DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb4d8fe1a862: Recommit [DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified. (authored by SouraVX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71185: [DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified.

SouraVX updated this revision to Diff 232896. SouraVX added a comment. Thank you Paul, for reviewing this. I've addressed your comments in this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71185/new/ https://reviews.llvm.org/D71185 Files:

[PATCH] D71185: [DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified.

SouraVX created this revision. SouraVX added reviewers: aprantl, dblaikie. SouraVX added projects: debug-info, LLVM. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya, mehdi_amini. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

SouraVX added a comment. In D70111#1765223 , @dblaikie wrote: > Looks OK to me - please recommit when you're ready. Thank you @awpandey . As requested, I've recommited this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

SouraVX added a comment. In D70696#1765843 , @dblaikie wrote: > In D70696#1765823 , @SouraVX wrote: > > > @dblaikie , If you try switching to C compiler. then the DW_TAG_variable > > is their. for C++ . It's not

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

SouraVX added a comment. @dblaikie , If you try switching to C compiler. then the DW_TAG_variable is their. for C++ . It's not generated. Please check godbolt again. -- though strange Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70696/new/

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

SouraVX added a comment. In D70696#1765675 , @yonghong-song wrote: > @probinson for the question, > > > Does bpf require debug info for the declaration of global_var in noref.c ? > > No, bpf only cares the referenced external global variables. So my

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

SouraVX added a comment. In D70696#1764306 , @umesh.kalappa0 wrote: > @SouraVX and @yonghong-song > > cat extern.c > int global_var = 2; > > compile as an extern.c shared a library ,then final executable a.out doesn't > have debugInfo for global_var.

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

SouraVX added a comment. In D70696#1764043 , @yonghong-song wrote: > If I remove `!D->isUsed()`, I should be able to generate the debuginfo for > `global_var` and eventually in dwarf in your above case. > What exactly your use case here for these

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

SouraVX added a comment. Hi @yonghong-song , Thanks for doing this. I have a doubt, regarding clang behavior, is this relevant to this. Consider the following test case -- extern global_var; int main(){} Now when compiled with clang -g test.c, In file ELF[DWARF] file their is no,

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

SouraVX added a comment. In D70111#1751981 , @aprantl wrote: > There are two options here: > > - leave the C bindings as is (fine with me) > - add an overloaded function to the C bindings that has the extra argument > (also fine with me). In my opinon,

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

SouraVX added a comment. Some how, this{eric response} doesn't got it's way to phabricator, anyways FYI > The C bindings, in general, don't have stability guarantees outside of a few > cases. > Whitequark owns all of this now though :) > -eric Repository: rG LLVM Github Monorepo

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

This revision was automatically updated to reflect the committed changes. Closed by commit rG423f541c1a32: [DWARF5]Addition of alignment atrribute in typedef DIE. (authored by SouraVX). Changed prior to commit: https://reviews.llvm.org/D70111?vs=229544=229697#toc Repository: rG LLVM Github

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

SouraVX added a comment. In D70111#1748765 , @awpandey wrote: > Hi @aprantl. I had made the changes and my team member will commit this. Thanks @awpandey for working on this! as requested, I've committed / closed this. Repository: rG LLVM Github

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

SouraVX added a comment. In D69935#1738563 , @ekatz wrote: > In D69935#1738311 , @SouraVX wrote: > > > I created that patch, for purpose of emitting C++ language standards C++11, > > C++14 in the debug information

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

SouraVX added a comment. I created that patch, for purpose of emitting C++ language standards C++11, C++14 in the debug information to be available for consumer's[GDB,LLDB]. DW_TAG_lang_c_plus_plus_11 .. 14 --new tags for languages in DWARF5. Sorry, I think, I missed this unintended additions

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX updated this revision to Diff 226867. SouraVX added a comment. Updated doc. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69215/new/ https://reviews.llvm.org/D69215 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-deleted.cpp

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX added a comment. Hi Adrian, Thanks for taking out time for reviewing this. I've again updated doc. Currently we're in process of getting commit access, discussion with Tom in progress So, could you please commit these changes. Thank you so much! CHANGES SINCE LAST ACTION

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX added a comment. Hi @aprantl, could you please review these changes, while I rework on the other one. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69215/new/ https://reviews.llvm.org/D69215 ___ cfe-commits mailing list

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX abandoned this revision. SouraVX added a comment. Will work on this later! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX updated this revision to Diff 226004. SouraVX added a comment. Updated the documentation for this new flag. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69215/new/ https://reviews.llvm.org/D69215 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX marked 4 inline comments as done. SouraVX added a comment. Thanks Adrian for reviewing this! I've addressed your comments. Please have a look. Working on the adding documentation part. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1624 + case Decl::CXXMethod: +if

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX updated this revision to Diff 225926. SouraVX added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69215/new/ https://reviews.llvm.org/D69215 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-deleted.cpp

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX updated this revision to Diff 225749. SouraVX added a comment. Corrected typo in test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69215/new/ https://reviews.llvm.org/D69215 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-deleted.cpp

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX created this revision. SouraVX added reviewers: probinson, dblaikie, aprantl. SouraVX added a project: debug-info. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. SouraVX marked an inline comment as done. SouraVX added inline comments.

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

SouraVX marked an inline comment as done. SouraVX added inline comments. Comment at: llvm/test/DebugInfo/X86/DW_AT_deleted.ll:68 + +attributes #0 = { noinline nounwind optnone uwtable } +attributes #1 = { nounwind readnone speculatable willreturn } Removed all

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX added a comment. Hi @probinson @dblaikie @aprantl , I've was investigating and working on your inputs regarding the problem with DW_at_defaulted once. I think clang has also some issues. Though I'm not able to precisely point out. I ranned into some problems in CFE while marking

[PATCH] D68697: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions.

SouraVX updated this revision to Diff 225159. SouraVX added a comment. Added test case in CFE for checking expected LLVM IR emission. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68697/new/ https://reviews.llvm.org/D68697 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D68697: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions.

SouraVX marked an inline comment as done. SouraVX added a comment. In D68697#1709680 , @SouraVX wrote: > Thanks Adrian for review! > Addressing your review comments. Could you please commit these changes for me, Thanks! CHANGES SINCE LAST ACTION

[PATCH] D68697: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions.

SouraVX updated this revision to Diff 225052. SouraVX added a comment. Thanks Adrian for review! Addressing your review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68697/new/ https://reviews.llvm.org/D68697 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D68697: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions.

SouraVX marked 2 inline comments as done. SouraVX added inline comments. Comment at: llvm/test/DebugInfo/X86/noreturn_cpp11.ll:59 -attributes #0 = { noreturn } +attributes #0 = { noinline noreturn optnone uwtable "correctly-rounded-divide-sqrt-fp-math"="false"

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX added a comment. In D68117#1708115 , @dblaikie wrote: > In D68117#1708114 , @SouraVX wrote: > > > In D68117#1707680 , @dblaikie > > wrote: > > > > > In

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX added a comment. In D68117#1707680 , @dblaikie wrote: > In D68117#1707578 , @SouraVX wrote: > > > In D68117#1702595 , @probinson > > wrote: > > > > > We really do

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX added a comment. In D68117#1702595 , @probinson wrote: > We really do want to pack the four mutually exclusive cases into two bits. I > have tried to give more explicit comments inline to explain how you would do > this. It really should work

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX marked 2 inline comments as done. SouraVX added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-defaulted-out-of-class.cpp:25 + + //FIXME -- clang will not mark above member funtions, excluding constructors + // as out of class. If we did not mark

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX marked 3 inline comments as done. SouraVX added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1619 + else { +SPFlags |= llvm::DISubprogram::SPFlagNotDefaulted; + } Previously SPFlagNotDefaulted is setted to SPFlagZero

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX updated this revision to Diff 223954. SouraVX added a comment. Addressed comments, regarding flags. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX marked 7 inline comments as done. SouraVX added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1610 + if (const auto *CXXC = dyn_cast(Method)) { +if (CXXC->getCanonicalDecl()->isDeleted()) + SPFlags |= llvm::DISubprogram::SPFlagDeleted;

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX updated this revision to Diff 223240. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/dbg-info-all-calls-described.cpp

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX marked 2 inline comments as done. SouraVX added a comment. Will be adding llvm-dwarfdump tests soon. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1608 + if (CGM.getCodeGenOpts().DwarfVersion >= 5) { +// DWARF-5 support for, defaulted, deleted member functions

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX updated this revision to Diff 222701. SouraVX added a comment. Added test cases for debug info Clang frontend. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX updated this revision to Diff 86. SouraVX added a comment. Minor refactor for context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX marked 2 inline comments as done. SouraVX added a comment. In D68117#1686235 , @aprantl wrote: > This needs a lot more test coverage: The frontend cases aren't all covered by > frontend checks and neither is the dwarf output. Do you mean to add

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX updated this revision to Diff 222079. SouraVX added a comment. Minor refactor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/dbg-info-all-calls-described.cpp

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX created this revision. SouraVX added reviewers: aprantl, dblaikie, probinson. SouraVX added projects: LLVM, clang, debug-info. Herald added a subscriber: hiraditya. This patch provides DWARF5 support for C++11 defaulted, deleted member. Added support in clang C++ frontend, llvm, and

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX added a comment. In D67613#1680176 , @uabelho wrote: > In D67613#1679879 , @xbolva00 wrote: > > >

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX added a comment. In D67613#1674597 , @aprantl wrote: > Please be sure the watch the lldb (and other debugger) bots after committing > this.. Could you please commit these changes. Thanks! CHANGES SINCE LAST ACTION

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX added a comment. In D67613#1674902 , @SouraVX wrote: > In D67613#1674597 , @aprantl wrote: > > > Please be sure the watch the lldb (and other debugger) bots after > > committing this.. > > > Thanks a lot!

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX added a comment. In D67613#1674597 , @aprantl wrote: > Please be sure the watch the lldb (and other debugger) bots after committing > this.. Thanks a lot! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX updated this revision to Diff 220613. SouraVX added a comment. Updated AST to use DWARF language enums. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/ https://reviews.llvm.org/D67613 Files: include/clang/AST/DeclCXX.h lib/AST/DeclPrinter.cpp

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX marked 2 inline comments as done. SouraVX added inline comments. Comment at: include/clang/AST/DeclCXX.h:2931 +lang_cxx_11 = /* DW_LANG_C_plus_plus_11 */ 0x001a, +lang_cxx_14 = /* DW_LANG_C_plus_plus_14 */ 0x0021 }; aprantl wrote: > SouraVX

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX marked an inline comment as done. SouraVX added inline comments. Comment at: include/clang/AST/DeclCXX.h:2931 +lang_cxx_11 = /* DW_LANG_C_plus_plus_11 */ 0x001a, +lang_cxx_14 = /* DW_LANG_C_plus_plus_14 */ 0x0021 }; aprantl wrote: > SouraVX

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX updated this revision to Diff 220472. SouraVX set the repository for this revision to rC Clang. SouraVX added a comment. Removed underscores from names. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/ https://reviews.llvm.org/D67613 Files:

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX updated this revision to Diff 220435. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/ https://reviews.llvm.org/D67613 Files: include/clang/AST/DeclCXX.h lib/AST/DeclPrinter.cpp lib/AST/JSONNodeDumper.cpp lib/AST/TextNodeDumper.cpp lib/CodeGen/CGDebugInfo.cpp

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX marked 3 inline comments as done. SouraVX added inline comments. Comment at: include/clang/AST/DeclCXX.h:2931 +lang_cxx_11 = /* DW_LANG_C_plus_plus_11 */ 0x001a, +lang_cxx_14 = /* DW_LANG_C_plus_plus_14 */ 0x0021 }; aprantl wrote: > I

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX created this revision. SouraVX added reviewers: aprantl, dblaikie. SouraVX added a project: debug-info. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch provides support for DW_LANG_C_plus_plus_11, DW_LANG_C_plus_plus_14 tags in clang C++ frontend.