[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea abandoned this revision. gtbercea added a comment. In https://reviews.llvm.org/D29660#1250333, @Hahnfeld wrote: > Going through my list of reviews, this patch was reverted because of memory > leaks in other changes. However, I don't think we need this anymore because > Clang is

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

Hahnfeld added a comment. Herald added subscribers: llvm-commits, guansong. Going through my list of reviews, this patch was reverted because of memory leaks in other changes. However, I don't think we need this anymore because Clang is raising the PTX level as needed for that CUDA version. Can

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea reopened this revision. gtbercea added a comment. This revision is now accepted and ready to land. Open Repository: rL LLVM https://reviews.llvm.org/D29660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

Hahnfeld added a comment. In https://reviews.llvm.org/D29660#839736, @alekseyshl wrote: > In https://reviews.llvm.org/D29660#839728, @alekseyshl wrote: > > > Bad news, the bot is still red: > > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7114 > > > Disabled

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. In https://reviews.llvm.org/D29660#839736, @alekseyshl wrote: > In https://reviews.llvm.org/D29660#839728, @alekseyshl wrote: > > > In https://reviews.llvm.org/D29660#839550, @alekseyshl wrote: > > > > >

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. In https://reviews.llvm.org/D29660#839728, @alekseyshl wrote: > In https://reviews.llvm.org/D29660#839550, @alekseyshl wrote: > > > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7109 > > failed on r310718, please fix. > > > > > In

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. In https://reviews.llvm.org/D29660#839550, @alekseyshl wrote: > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7109 > failed on r310718, please fix. In https://reviews.llvm.org/D29660#839647, @gtbercea wrote: > In

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. In https://reviews.llvm.org/D29660#839550, @alekseyshl wrote: > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7109 > failed on r310718, please fix. Couldn't fix/find the actual error so for now, just moving the flag patch tests to

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. In https://reviews.llvm.org/D29660#839275, @alekseyshl wrote: > In https://reviews.llvm.org/D29660#839209, @gtbercea wrote: > > > I have re-enabled the previous offloading tests and moved the new GPU > > offloading tests to a new file which is disabled for linux (for

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7109 failed on r310718, please fix. Repository: rL LLVM https://reviews.llvm.org/D29660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. In https://reviews.llvm.org/D29660#839209, @gtbercea wrote: > I have re-enabled the previous offloading tests and moved the new GPU > offloading tests to a new file which is disabled for linux (for now). > > 310718 > > Alex thanks so much for the logs, they have been

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. I have re-enabled the previous offloading tests and moved the new GPU offloading tests to a new file which is disabled for linux (for now). 310718 Alex thanks so much for the logs, they have been very useful to understand what's going on. Aleksey, I have since tried

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. In https://reviews.llvm.org/D29660#838305, @alekseyshl wrote: > In https://reviews.llvm.org/D29660#838219, @gtbercea wrote: > > > In https://reviews.llvm.org/D29660#838194, @arphaman wrote: > > > > > The failures were very widespread, e.g. there's a linux buildbot

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. In https://reviews.llvm.org/D29660#838219, @gtbercea wrote: > In https://reviews.llvm.org/D29660#838194, @arphaman wrote: > > > The failures were very widespread, e.g. there's a linux buildbot that was > > red until the revert:

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. In https://reviews.llvm.org/D29660#838185, @alekseyshl wrote: > In https://reviews.llvm.org/D29660#838150, @gtbercea wrote: > > > First of all, I apologize if I've upset you with my previous post. I am > > actively working on understanding what is causing these issues.

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

arphaman added a comment. I've traced the output across all the reverted commits: F5233517: testFailures.md Note that after r310549 the last 9 RUN lines started failing because of the same crash: clang version 6.0.0 (http://llvm.org/git/llvm.git

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. In https://reviews.llvm.org/D29660#838194, @arphaman wrote: > The failures were very widespread, e.g. there's a linux buildbot that was red > until the revert: http://bb.pgr.jp/builders/test-clang-i686-linux-RA. If you > have access to a linux machine you should be

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

jtbandes added a comment. @gtbercea Hi, I just saw your comment on my gist. (Unfortunately github does not send email notifications about gist comments; commenting here is probably better.) If you have Docker installed, it should be easy to get whatever output you like — just change the

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

arphaman added a comment. The failures were very widespread, e.g. there's a linux buildbot that was red until the revert: http://bb.pgr.jp/builders/test-clang-i686-linux-RA. If you have access to a linux machine you should be able to reproduce the failures that the bot experienced by using the

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. In https://reviews.llvm.org/D29660#838150, @gtbercea wrote: > First of all, I apologize if I've upset you with my previous post. I am > actively working on understanding what is causing these issues. It is not my > intention to write tests that work on local

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

hfinkel added a comment. In https://reviews.llvm.org/D29660#838150, @gtbercea wrote: > First of all, I apologize if I've upset you with my previous post. I am > actively working on understanding what is causing these issues. It is not my > intention to write tests that work on local

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. First of all, I apologize if I've upset you with my previous post. I am actively working on understanding what is causing these issues. It is not my intention to write tests that work on local configurations only. I am upset to see that these tests keep failing for

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. Even after all the reverts in r310580, our tests are still failing (http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7080). not surprising, but very disrupting. Please have a plan to fix it soon, otherwise I'll have to revert it even further.

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. While I do get the time pressure and such, doing it at the expense of others is not cool. Many teams work process is broken for days, folks are busy looking into it, investigating and reverting, other breakages are masked by these failures etc. If your test depend

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. Hi Alex, I have no idea what the errors you mention are. I worked until very late last night to fix the previous error with the compute capability. Maybe fixing that unlocked some other errors. I would need a lot of help to figure out what's going on since I probably

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

arphaman added a comment. 1. I'm sorry, but I had to revert r310489 and follow-up commits r310505, r310519, r310537 and r310549 since it looks like the failures are accumulating. The revert commit was r310580. The following run lines were failing for me because of various assertion failures

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

jtbandes added a comment. I'm still seeing a failure after r301549: https://gist.github.com/jtbandes/de6118abaadc6c5a5c9b4223a62f596c Repository: rL LLVM https://reviews.llvm.org/D29660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. 310549 should solve this problem by using a default architecture that is supported by the current device version. Repository: rL LLVM https://reviews.llvm.org/D29660 ___ cfe-commits mailing list

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

jtbandes added a comment. FWIW, I'm able to reproduce the failure using Docker: Dockerfile: FROM ubuntu:xenial RUN apt-get update RUN apt-get install -y build-essential ca-certificates subversion python cmake --no-install-recommends WORKDIR / RUN svn co -q -r 310537

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. Thanks for running the test on your machine! This is very useful. I see what the problem is now: "clang: error: cannot find libdevice for sm_20. Provide path to different CUDA installation via --cuda-path, or pass -nocudalib to build without linking with libdevice."

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

dyung added a comment. Hi, we are seeing this test fail on our internal linux build bot. I built/ran your latest change r310537 and here is the test result: /home/dyung/src/upstream/llvm_clean/tools/clang/test/Driver/openmp-offload.c:722:23: error: expected string not found in input

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. I've removed that test. Let's see if the other two tests pass or not. I can't reproduce the error locally so it's hard to figure out what's failing. If you have a machine with that configuration and can run the command I would appreciate seeing the output of the

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. r310519 did not fix the problem, see http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7062. I would suggest to revert and fix it properly, our bots are broken for a few days already. Repository: rL LLVM https://reviews.llvm.org/D29660

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. In https://reviews.llvm.org/D29660#837298, @alekseyshl wrote: > Even after r310505, openmp-offload.c continues to haunt our bots, for example > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/2012. > Can you please fix this test? Preparing

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. Even after r310505, openmp-offload.c continues to haunt our bots, for example http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/2012. Can you please fix this test? Repository: rL LLVM https://reviews.llvm.org/D29660

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. Revision 310505 fixes the tests for this patch. Repository: rL LLVM https://reviews.llvm.org/D29660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. In https://reviews.llvm.org/D29660#836927, @arphaman wrote: > Looks like this test is failing on macOS again after this change: > > http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/39231/testReport/Clang/Driver/openmp_offload_c/ > > Can you

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

arphaman added a comment. Looks like this test is failing on macOS again after this change: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/39231/testReport/Clang/Driver/openmp_offload_c/ Can you please take a look? Repository: rL LLVM

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea updated this revision to Diff 95126. gtbercea added a comment. Fix. Repository: rL LLVM https://reviews.llvm.org/D29660 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D29660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea updated this revision to Diff 94842. gtbercea added a comment. Run clang format. Repository: rL LLVM https://reviews.llvm.org/D29660 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea updated this revision to Diff 94841. gtbercea added a comment. Refactor. Repository: rL LLVM https://reviews.llvm.org/D29660 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:499 +options::OPT_fopenmp_ptx_EQ); +CC1Args.back() = (!PtxVersion.empty()) ? PtxVersion.data() : "+ptx42"; + } else No, use `CC1Args.push_back()` here, or

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea updated this revision to Diff 94824. gtbercea added a comment. Integrate review. Repository: rL LLVM https://reviews.llvm.org/D29660 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:495-506 + + StringRef PtxVersion = DriverArgs.getLastArgValue( +options::OPT_fopenmp_ptx_EQ); + CC1Args.push_back("+ptx42"); + if (DeviceOffloadingKind == Action::OFK_OpenMP &&

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea updated this revision to Diff 93901. gtbercea added a comment. Update test. Repository: rL LLVM https://reviews.llvm.org/D29660 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea updated this revision to Diff 93244. gtbercea added a comment. Herald added a subscriber: rengolin. Update patch to reflect latest source code changes. Repository: rL LLVM https://reviews.llvm.org/D29660 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Cuda.cpp

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea created this revision. This flag "--fopenmp-ptx=" enables the overwriting of the default PTX version used for GPU offloaded OpenMP target regions: "+ptx42". Repository: rL LLVM https://reviews.llvm.org/D29660 Files: include/clang/Driver/Options.td lib/Driver/ToolChains.cpp