[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

tra added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:281 + // get name from the module to generate unique ctor name for every module + SmallString<128> ModuleName rjmccall wrote: > Please explain in the comment *why* you're doing this. It's just

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:63 + + Detects inappropriate seeding of C++ random generators and C srand function. + Please replace srand with ``srand ()``. Comment at:

r327434 - Serialize the NonTrivialToPrimitive* flags I added in r326307.

Author: ahatanak Date: Tue Mar 13 11:58:25 2018 New Revision: 327434 URL: http://llvm.org/viewvc/llvm-project?rev=327434=rev Log: Serialize the NonTrivialToPrimitive* flags I added in r326307. rdar://problem/38421774 Modified: cfe/trunk/include/clang/AST/Decl.h

[PATCH] D39050: Add index-while-building support to Clang

malaperle added a comment. In https://reviews.llvm.org/D39050#1021204, @malaperle wrote: > For computing the start/end-loc of function bodies, I tried the > SingleFileParseMode and SkipFunctionBodies separately ( as a start). The > source I use this on looks like this: > > Given the

[PATCH] D44233: Set dso_local on external rtti GVs

espindola added a comment. ping https://reviews.llvm.org/D44233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

juliehockett updated this revision to Diff 138241. juliehockett marked 8 inline comments as done. juliehockett retitled this revision from "[clang-tidy] Add Fuchsia checker for temporary objects" to "[clang-tidy] Add Zircon module to clang-tidy". juliehockett edited the summary of this revision.

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138242. gtbercea added a comment. Address comments. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

echristo added inline comments. Comment at: test/Sema/attr-print.cpp:3 +// This file is also used as input for %S/../Frontend/ast-attr.cpp. + Relatedly I don't think we use files as input files to other directories and I don't think we should really. What are

[PATCH] D44445: CodeGen: Reduce LValue and CallArgList memory footprint before recommitting r326946

rjmccall added inline comments. Comment at: lib/CodeGen/CGValue.h:234 this->Quals = Quals; this->Alignment = Alignment.getQuantity(); assert(this->Alignment == Alignment.getQuantity() && Please saturate Alignment here instead of allowing it to be

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

aaron.ballman added inline comments. Comment at: clang-tidy/tool/ClangTidyMain.cpp:527 -// This anchor is used to force the linker to link the GoogleModule. +// This anchor is used to force the linker to link the FuchsiaModule. extern volatile int FuchsiaModuleAnchorSource;

[PATCH] D44408: Move DraftMgr from ClangdServer to ClangdLSPServer

simark updated this revision to Diff 138253. simark added a comment. Rebase Non-trivial rebase on today's master. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44408 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp

[PATCH] D44445: CodeGen: Reduce LValue and CallArgList memory footprint before recommitting r326946

yaxunl updated this revision to Diff 138252. yaxunl marked an inline comment as done. yaxunl added a comment. Saturate alignment when it is too large. https://reviews.llvm.org/D5 Files: lib/CodeGen/CGCall.h lib/CodeGen/CGValue.h test/CodeGenCXX/deep-ast-tree.cpp Index:

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added inline comments. Comment at: test/Sema/attr-print.cpp:3 +// This file is also used as input for %S/../Frontend/ast-attr.cpp. + echristo wrote: > Relatedly I don't think we use files as input files to other directories and > I don't think we

Re: [PATCH] D30170: Function definition may have uninstantiated body

On Wed, Feb 28, 2018 at 8:21 PM, Richard Smith - zygoloid via Phabricator via cfe-commits wrote: > > Comment at: lib/Sema/SemaDecl.cpp:11986 > + !FD->isDefined(Definition) > + && FD->getDeclContext()->isFileContext()) { > +// If this is a

[PATCH] D44445: CodeGen: Reduce LValue and CallArgList memory footprint before recommitting r326946

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thank you. LGTM. https://reviews.llvm.org/D5 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39050: Add index-while-building support to Clang

nathawes added a comment. In https://reviews.llvm.org/D39050#1036249, @malaperle wrote: > In https://reviews.llvm.org/D39050#1021204, @malaperle wrote: > > > For computing the start/end-loc of function bodies, I tried the > > SingleFileParseMode and SkipFunctionBodies separately ( as a start).

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 138254. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis marked an inline comment as done and an inline comment as not done. zinovy.nis added inline comments. Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:115 + int virt_1() override { return A::virt_1(); } + // CHECK-MESSAGES: :[[@LINE-1]]:34: warning:

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 138139. yvvan added a comment. Return possibly required corrections in the string form https://reviews.llvm.org/D41537 Files: include/clang-c/Index.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/CodeCompleteConsumer.h

r327383 - clang-import-test: fix build with clang-3.8

Author: labath Date: Tue Mar 13 04:28:27 2018 New Revision: 327383 URL: http://llvm.org/viewvc/llvm-project?rev=327383=rev Log: clang-import-test: fix build with clang-3.8 clang-3.8 complains that constructor for '...' must explicitly initialize the const object. Newer clangs and gcc seem to be

[PATCH] D44381: [mips] Change the way how Clang chooses relocation mode

sdardis added a comment. This patch looks mostly ok, but I think there are some small issues with it. Can you separate the new warnings/error relating to -fno-pic / -mabicalls into another patch from the change which alters the behaviour of __PIC__ / __pic__ ? The title of the patch is

[PATCH] D16008: [clang-tidy] Add calling virtual functions in constructors/destructors check.

alexfh added a comment. Aaron, WDYT? Repository: rL LLVM https://reviews.llvm.org/D16008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44293: [clangd] Fix irrelevant declaratations in goto definition (on macros).

ilya-biryukov added inline comments. Comment at: clangd/XRefs.cpp:201 std::vector MacroInfos = DeclMacrosFinder->takeMacroInfos(); + if (!MacroInfos.empty()) { +for (auto Item : MacroInfos) { hokein wrote: > ilya-biryukov wrote: > > I wonder whether we

[PATCH] D44293: [clangd] Fix irrelevant declaratations in goto definition (on macros).

hokein updated this revision to Diff 138147. hokein marked an inline comment as done. hokein added a comment. Address review comment. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44293 Files: clangd/XRefs.cpp unittests/clangd/XRefsTests.cpp Index:

[PATCH] D44293: [clangd] Fix irrelevant declaratations in goto definition (on macros).

hokein added inline comments. Comment at: clangd/XRefs.cpp:201 std::vector MacroInfos = DeclMacrosFinder->takeMacroInfos(); + if (!MacroInfos.empty()) { +for (auto Item : MacroInfos) { ilya-biryukov wrote: > hokein wrote: > > ilya-biryukov wrote: > > > I

[PATCH] D16008: [clang-tidy] Add calling virtual functions in constructors/destructors check.

alexfh added a comment. If the CSA checker is still in alpha, I'd proceed with this check instead of investing time in polishing the CSA implementation. Repository: rL LLVM https://reviews.llvm.org/D16008 ___ cfe-commits mailing list

[clang-tools-extra] r327386 - [clangd] Remove extra ";", NFC.

Author: hokein Date: Tue Mar 13 05:26:28 2018 New Revision: 327386 URL: http://llvm.org/viewvc/llvm-project?rev=327386=rev Log: [clangd] Remove extra ";", NFC. Modified: clang-tools-extra/trunk/unittests/clangd/ClangdUnitTests.cpp Modified:

[PATCH] D16008: [clang-tidy] Add calling virtual functions in constructors/destructors check.

aaron.ballman added a comment. In https://reviews.llvm.org/D16008#1035683, @alexfh wrote: > If the CSA checker is still in alpha, I'd proceed with this check instead of > investing time in polishing the CSA implementation. Do you know why the CSA checker is still in alpha? As best I can tell,

[PATCH] D44423: [clangd] Use the macro name range as the definition range.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: ioeric, jkorous-apple, ilya-biryukov, klimek. This also aligns with the behavior of declarations. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44423 Files: clangd/XRefs.cpp

[PATCH] D42684: clang-format: Allow optimizer to break template declaration.

Typz added a comment. ping? Repository: rC Clang https://reviews.llvm.org/D42684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43015: clang-format: Introduce BreakInheritanceList option

Typz added a comment. ping? Repository: rC Clang https://reviews.llvm.org/D43015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43650: [ARM] Add ARMv8.2-A FP16 vector intrinsics

SjoerdMeijer added a comment. Hi @mstorsjo, thanks for reporting this! I was waiting for @az, and only had a quick look myself, but I don't think it's going to be a quick fix. So that would suggest indeed that a revert is a best. Perhaps we can wait a few more hours to give the guys in the US

[PATCH] D44426: Fix llvm + clang build with Intel compiler

yvvan created this revision. yvvan added reviewers: bkramer, klimek. Herald added subscribers: JDevlieghere, nhaehnle, arsenm. Herald added a reviewer: deadalnix. I've tested it on Windows with 64-bit icl These are mostly workarounds for https://software.intel.com/en-us/comment/1919743 ,

[PATCH] D44293: [clangd] Fix irrelevant declaratations in goto definition (on macros).

ilya-biryukov added inline comments. Comment at: clangd/XRefs.cpp:137 + // + // FIXME: Exclude declarations from macros. + Decls.clear(); NIT: the fixme was a bit hard to follow for me. Maybe make it more clear where the problem

[PATCH] D44293: [clangd] Fix irrelevant declaratations in goto definition (on macros).

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM with a small nit about the comment. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44293 ___ cfe-commits

[PATCH] D44293: [clangd] Fix irrelevant declaratations in goto definition (on macros).

hokein updated this revision to Diff 138160. hokein marked an inline comment as done. hokein added a comment. Rephrase the fixme. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44293 Files: clangd/XRefs.cpp unittests/clangd/XRefsTests.cpp Index:

r327393 - [Hexagon] Clang side of r327302 in LLVM

Author: kparzysz Date: Tue Mar 13 06:30:43 2018 New Revision: 327393 URL: http://llvm.org/viewvc/llvm-project?rev=327393=rev Log: [Hexagon] Clang side of r327302 in LLVM Add option -m[no-]packets to control generation of instruction packets (enabled by default). Added:

[clang-tools-extra] r327387 - [clangd] Fix irrelevant declaratations in goto definition (on macros).

Author: hokein Date: Tue Mar 13 05:30:59 2018 New Revision: 327387 URL: http://llvm.org/viewvc/llvm-project?rev=327387=rev Log: [clangd] Fix irrelevant declaratations in goto definition (on macros). Summary: DeclrationAndMacrosFinder will find some declarations (not macro!) that are referened

[PATCH] D44293: [clangd] Fix irrelevant declaratations in goto definition (on macros).

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE327387: [clangd] Fix irrelevant declaratations in goto definition (on macros). (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D44293?vs=138160=138162#toc

[PATCH] D43290: clang-format: tweak formatting of variable initialization blocks

Typz added a comment. ping? Repository: rC Clang https://reviews.llvm.org/D43290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43650: [ARM] Add ARMv8.2-A FP16 vector intrinsics

mstorsjo added a comment. In https://reviews.llvm.org/D43650#1034009, @mstorsjo wrote: > This change broke building Qt for armv7, see PR36683 for details. Ping - any update on looking into this? Should we revert this change for now, until the breakage is handled?

[PATCH] D38216: [C++17] Fix class template argument deduction for default constructors without an initializer

Rakete updated this revision to Diff 138187. Rakete added a comment. Addressed review comments :) Thanks! https://reviews.llvm.org/D38216 Files: lib/Sema/SemaDecl.cpp test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.type.class.deduct/p1.cpp

[PATCH] D44305: [clangd] Add an interface that finds symbol by SymbolID in SymbolIndex.

ioeric updated this revision to Diff 138204. ioeric marked 6 inline comments as done. ioeric added a comment. - - Addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44305 Files: clangd/index/FileIndex.cpp clangd/index/FileIndex.h

[PATCH] D44305: [clangd] Add an interface that finds symbol by SymbolID in SymbolIndex.

ioeric added a comment. Thanks for the review! Comment at: clangd/index/Index.h:268 + virtual bool + getSymbol(const SymbolID , +llvm::function_ref Callback) const = 0; sammccall wrote: > sammccall wrote: > > sammccall

[clang-tools-extra] r327401 - [clangd] Use the macro name range as the definition range.

Author: hokein Date: Tue Mar 13 07:31:31 2018 New Revision: 327401 URL: http://llvm.org/viewvc/llvm-project?rev=327401=rev Log: [clangd] Use the macro name range as the definition range. Summary: This also aligns with the behavior of declarations. Reviewers: sammccall Reviewed By: sammccall

[PATCH] D16008: [clang-tidy] Add calling virtual functions in constructors/destructors check.

malcolm.parsons added a comment. In https://reviews.llvm.org/D16008#1035789, @aaron.ballman wrote: > Do you know why the CSA checker is still in alpha? It isn't - https://reviews.llvm.org/D26768 moved it to optin. I don't know why https://reviews.llvm.org/D34275 didn't turn it on by default.

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

This revision was automatically updated to reflect the committed changes. jdenny marked 8 inline comments as done. Closed by commit rC327405: Reland [Attr] Fix parameter indexing for several attributes (authored by jdenny, committed by ). Changed prior to commit:

[PATCH] D44423: [clangd] Use the macro name range as the definition range.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE327401: [clangd] Use the macro name range as the definition range. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D44423?vs=138163=138189#toc Repository:

r327405 - Reland "[Attr] Fix parameter indexing for several attributes"

Author: jdenny Date: Tue Mar 13 07:51:22 2018 New Revision: 327405 URL: http://llvm.org/viewvc/llvm-project?rev=327405=rev Log: Reland "[Attr] Fix parameter indexing for several attributes" Relands r326602 (reverted in r326862) with new test and fix for PR36620. Differential Revision:

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

SimeonEhrig created this revision. SimeonEhrig added reviewers: karies, v.g.vassilev, rsmith, rjmccall. This allows multi-module / incremental compilation environments to have unique global CUDA constructor and destructor function names. Repository: rC Clang https://reviews.llvm.org/D44435

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:595-596 +// Add user defined library paths from LIBRARY_PATH. +if (llvm::Optional LibPath = + llvm::sys::Process::GetEnv("LIBRARY_PATH")) { + SmallVector Frags;

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

rjmccall added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:281 + // get name from the module to generate unique ctor name for every module + SmallString<128> ModuleName Please explain in the comment *why* you're doing this. It's just for

[PATCH] D44439: [Sema] Pop function scope when instantiating a func with skipped body

ilya-biryukov created this revision. ilya-biryukov added reviewers: bkramer, sammccall, sepavloff. By calling ActOnFinishFunctionBody(). Previously we were only calling ActOnSkippedFunctionBody, which didn't pop the function scope. This causes a crash when running on our internal code. No

[PATCH] D44449: [Parser] Fix assertion-on-invalid for unexpected typename.

vsapsai added a comment. I had performance considerations regarding this change because `ConsumeAnyToken` is heavier than `ConsumeToken`. But I didn't notice any problems. If you know this is a hot path that deserves more attention, please let me know. Comment at:

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138275. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/Inputs/libomptarget/libomptarget-nvptx-sm_20.bc test/Driver/openmp-offload-gpu.c Index:

Re: r327447 - Revert revision 327438.

On Tue, Mar 13, 2018 at 4:50 PM, Gheorghe-Teodor Bercea via cfe-commits wrote: > Author: gbercea > Date: Tue Mar 13 13:50:12 2018 > New Revision: 327447 > > URL: http://llvm.org/viewvc/llvm-project?rev=327447=rev > Log: > Revert revision 327438. Can you give some

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

aaron.ballman added a comment. In https://reviews.llvm.org/D43248#1036409, @jdenny wrote: > I'd prefer to move it than to expect people to obey such a comment. Let's > see what Aaron says. I have a slight preference for moving the tests now that I know they're causing problems, unless that

[PATCH] D44447: Treat libclang_rt.* as normal library if the user uses --sysroot=

trixirt created this revision. trixirt added reviewers: rsmith, atanasyan, vkalintiris. trixirt added a project: clang. Herald added a subscriber: cfe-commits. In cross compiling, one normally assumes that the user supplied sysroot contains all of the libraries needed in the link. And so the

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138260. gtbercea added a comment. Improve test robustness for the case when CUDA libdevice cannot be found. Check that the warning is not emitted when the bc lib is found. Repository: rC Clang https://reviews.llvm.org/D43197 Files:

r327453 - [Analysis] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Tue Mar 13 14:32:01 2018 New Revision: 327453 URL: http://llvm.org/viewvc/llvm-project?rev=327453=rev Log: [Analysis] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified:

r327455 - [ARM] ACLE FP16 feature test macros

Author: sjoerdmeijer Date: Tue Mar 13 15:11:06 2018 New Revision: 327455 URL: http://llvm.org/viewvc/llvm-project?rev=327455=rev Log: [ARM] ACLE FP16 feature test macros This is a partial recommit of r327189 that was reverted due to test issues. I.e., this recommits minimal functional change,

[PATCH] D43898: Preliminary refactoring in service of -Wreturn-std-move. NFC.

rtrieu added a comment. Everything looks good and ready for commit. Repository: rC Clang https://reviews.llvm.org/D43898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138274. gtbercea added a comment. - Revert - Add back. - Improve tests. - Add bclib. - Fix. - Fix. Repository: rC Clang https://reviews.llvm.org/D43197 Files: test/Driver/openmp-offload-gpu.c Index: test/Driver/openmp-offload-gpu.c

r327460 - [OpenMP] Add flag for linking runtime bitcode library

Author: gbercea Date: Tue Mar 13 16:19:52 2018 New Revision: 327460 URL: http://llvm.org/viewvc/llvm-project?rev=327460=rev Log: [OpenMP] Add flag for linking runtime bitcode library Summary: This patch adds an additional flag to the OpenMP device offloading toolchain to link in the runtime

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

This revision was automatically updated to reflect the committed changes. Closed by commit rL327460: [OpenMP] Add flag for linking runtime bitcode library (authored by gbercea, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

r327464 - Check that a field is not annotated with attribute "unavailable" before

Author: ahatanak Date: Tue Mar 13 16:37:51 2018 New Revision: 327464 URL: http://llvm.org/viewvc/llvm-project?rev=327464=rev Log: Check that a field is not annotated with attribute "unavailable" before setting the NonTrivialToPrimitive* flags of a record. Union fields that have non-trivial

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added a comment. I'd prefer to move it than to expect people to obey such a comment. Let's see what Aaron says. Repository: rC Clang https://reviews.llvm.org/D43248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

echristo added a comment. In https://reviews.llvm.org/D43248#1036426, @aaron.ballman wrote: > In https://reviews.llvm.org/D43248#1036409, @jdenny wrote: > > > I'd prefer to move it than to expect people to obey such a comment. Let's > > see what Aaron says. > > > I have a slight preference for

[clang-tools-extra] r327452 - [clang-tidy] Fixing incorrect comment

Author: juliehockett Date: Tue Mar 13 14:24:08 2018 New Revision: 327452 URL: http://llvm.org/viewvc/llvm-project?rev=327452=rev Log: [clang-tidy] Fixing incorrect comment Modified: clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMain.cpp Modified:

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138261. gtbercea added a comment. Add bclib. Repository: rC Clang https://reviews.llvm.org/D43197 Files: test/Driver/openmp-offload-gpu.c Index: test/Driver/openmp-offload-gpu.c ===

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added a comment. In https://reviews.llvm.org/D43248#1036427, @echristo wrote: > In https://reviews.llvm.org/D43248#1036426, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D43248#1036409, @jdenny wrote: > > > > > I'd prefer to move it than to expect people to obey such a comment.

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138262. gtbercea added a comment. Test. Repository: rC Clang https://reviews.llvm.org/D43197 Files: test/Driver/openmp-offload-gpu.c Index: test/Driver/openmp-offload-gpu.c === ---

r327447 - Revert revision 327438.

Author: gbercea Date: Tue Mar 13 13:50:12 2018 New Revision: 327447 URL: http://llvm.org/viewvc/llvm-project?rev=327447=rev Log: Revert revision 327438. Removed: cfe/trunk/test/Driver/Inputs/libomptarget/libomptarget-nvptx-sm_20.bc Modified:

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

echristo added inline comments. Comment at: test/Sema/attr-print.cpp:3 +// This file is also used as input for %S/../Frontend/ast-attr.cpp. + jdenny wrote: > echristo wrote: > > Relatedly I don't think we use files as input files to other directories > > and

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

juliehockett updated this revision to Diff 138264. juliehockett marked 6 inline comments as done. juliehockett added a comment. Addressing comments https://reviews.llvm.org/D44346 Files: clang-tidy/CMakeLists.txt clang-tidy/tool/CMakeLists.txt clang-tidy/tool/ClangTidyMain.cpp

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:77 +- New `zircon-temporary-objects + `_ check Please sort new checks in alphabetical order.

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138266. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp test/Driver/Inputs/libomptarget/libomptarget-nvptx-sm_20.bc test/Driver/openmp-offload-gpu.c Index:

[PATCH] D43650: [ARM] Add ARMv8.2-A FP16 vector intrinsics

SjoerdMeijer added a comment. FYI: I have partially recommitted this in r327455; I have separated out the minimal functional change related to the FP16 macros. https://reviews.llvm.org/D43650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added a comment. In https://reviews.llvm.org/D43248#1036439, @jdenny wrote: > So, I'm planning to remove test/Frontend/ast-attr.cpp, rename > test/Sema/attr-print.cpp to test/Misc/attr-print-emit.cpp, and change its run > lines to: > > // RUN: %clang_cc1 %s -ast-print | FileCheck %s >

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

gtbercea updated this revision to Diff 138265. gtbercea added a comment. Update patch manually. Repository: rC Clang https://reviews.llvm.org/D43197 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Cuda.cpp

r327456 - [Attr] Merge two dependent tests from different directories

Author: jdenny Date: Tue Mar 13 15:18:29 2018 New Revision: 327456 URL: http://llvm.org/viewvc/llvm-project?rev=327456=rev Log: [Attr] Merge two dependent tests from different directories Suggested at: https://reviews.llvm.org/D43248 Added: cfe/trunk/test/Misc/attr-print-emit.cpp -

[PATCH] D44449: [Parser] Fix assertion-on-invalid for unexpected typename.

vsapsai created this revision. vsapsai added reviewers: rsmith, arphaman. Herald added a subscriber: jkorous-apple. In `ParseDeclarationSpecifiers` for the code class A typename A; we were able to annotate token `kw_typename` because it refers to existing type. But later during processing

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

SimeonEhrig updated this revision to Diff 138224. SimeonEhrig added a comment. change comment of the example function for TEST(IncrementalProcessing, EmitCUDAGlobalInitFunc) Repository: rC Clang https://reviews.llvm.org/D44435 Files: lib/CodeGen/CGCUDANV.cpp

[PATCH] D44305: [clangd] Add an interface that finds symbol by SymbolID in SymbolIndex.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/Index.h:253 +struct LookupRequest { + std::set IDs; +}; nit: DenseSet? we already have the traits

r327426 - [analyzer] Fix the matcher for GCDAntipattern to look for "signal" call in all parameters

Author: george.karpenkov Date: Tue Mar 13 10:27:01 2018 New Revision: 327426 URL: http://llvm.org/viewvc/llvm-project?rev=327426=rev Log: [analyzer] Fix the matcher for GCDAntipattern to look for "signal" call in all parameters rdar://38405904 Modified:

r327471 - [hwasan] update docs

Author: kcc Date: Tue Mar 13 18:55:49 2018 New Revision: 327471 URL: http://llvm.org/viewvc/llvm-project?rev=327471=rev Log: [hwasan] update docs Modified: cfe/trunk/docs/HardwareAssistedAddressSanitizerDesign.rst Modified: cfe/trunk/docs/HardwareAssistedAddressSanitizerDesign.rst URL:

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

ABataev accepted this revision. ABataev added a comment. LG Repository: rC Clang https://reviews.llvm.org/D43197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r327437 - This reverts "r327189 - [ARM] Add ARMv8.2-A FP16 vector intrinsic"

Author: sjoerdmeijer Date: Tue Mar 13 12:38:56 2018 New Revision: 327437 URL: http://llvm.org/viewvc/llvm-project?rev=327437=rev Log: This reverts "r327189 - [ARM] Add ARMv8.2-A FP16 vector intrinsic" This is causing problems in testing, and PR36683 was raised. Reverting it until we have sorted

r327438 - [OpenMP] Add flag for linking runtime bitcode library

Author: gbercea Date: Tue Mar 13 12:39:19 2018 New Revision: 327438 URL: http://llvm.org/viewvc/llvm-project?rev=327438=rev Log: [OpenMP] Add flag for linking runtime bitcode library Summary: This patch adds an additional flag to the OpenMP device offloading toolchain to link in the runtime

[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

This revision was automatically updated to reflect the committed changes. Closed by commit rC327438: [OpenMP] Add flag for linking runtime bitcode library (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D43197?vs=138242=138245#toc Repository: rC Clang

[PATCH] D43650: [ARM] Add ARMv8.2-A FP16 vector intrinsics

SjoerdMeijer added a comment. Reverted in r327437. https://reviews.llvm.org/D43650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44445: CodeGen: Reduce LValue and CallArgList memory footprint before recommitting r326946

yaxunl created this revision. yaxunl added reviewers: rsmith, rjmccall. Recent change r326946 (https://reviews.llvm.org/D34367) causes regression in Eigen due to increased memory footprint of CallArg. This patch reduces LValue size from 112 to 96 bytes and reduces inline argument count of

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

aaron.ballman added a comment. I dreamed up some test cases that may or may not make sense. I think they boil down to a few things: - Does inheriting from a prohibited type still diagnose when the derived type is used to construct a temporary? - Should it still be prohibited if the temporary

[PATCH] D16008: [clang-tidy] Add calling virtual functions in constructors/destructors check.

aaron.ballman added a comment. In https://reviews.llvm.org/D16008#1035948, @malcolm.parsons wrote: > In https://reviews.llvm.org/D16008#1035789, @aaron.ballman wrote: > > > Do you know why the CSA checker is still in alpha? > > > It isn't - https://reviews.llvm.org/D26768 moved it to optin. > >

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

aaron.ballman added inline comments. Comment at: test/clang-tidy/zircon-temporary-objects.cpp:86 +Ty make_ty() { return Ty(); } +// CHECK-MESSAGES: :[[@LINE-1]]:23: warning: creating a temporary object of type 'Bar' is prohibited +// CHECK-MESSAGES: :[[@LINE-2]]:23: warning:

[PATCH] D43898: Preliminary refactoring in service of -Wreturn-std-move. NFC.

Quuxplusone added a comment. @rtrieu thanks! I don't have commit privileges; could I ask you to commit this on my behalf? (Or if not, please say no, and I'll know to go looking for someone else to ask.) Once/if https://reviews.llvm.org/D43898 hits master, I'll rebase

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:24-25 + const CXXRecordDecl *ThisClass) { + assert(Parent); + assert(ThisClass); + if (Parent->getCanonicalDecl() == ThisClass->getCanonicalDecl())

[PATCH] D44346: [clang-tidy] Add Zircon module to clang-tidy

juliehockett updated this revision to Diff 138286. juliehockett marked 3 inline comments as done. juliehockett added a comment. Addomg tests amd fixing documentation https://reviews.llvm.org/D44346 Files: clang-tidy/CMakeLists.txt clang-tidy/tool/CMakeLists.txt