r358151 - [OpenCL] Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

Author: alexeysotkin Date: Wed Apr 10 23:18:17 2019 New Revision: 358151 URL: http://llvm.org/viewvc/llvm-project?rev=358151=rev Log: [OpenCL] Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function Summary: https://reviews.llvm.org/D53809 fixed

[PATCH] D59985: [OpenCL] Re-fix invalid address space generation for clk_event_t arguments of enqueue_kernel builtin function

This revision was automatically updated to reflect the committed changes. Closed by commit rL358151: [OpenCL] Re-fix invalid address space generation for clk_event_t arguments of… (authored by AlexeySotkin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

r358152 - Add { } to silence compiler warning [NFC]

Author: uabelho Date: Wed Apr 10 23:57:12 2019 New Revision: 358152 URL: http://llvm.org/viewvc/llvm-project?rev=358152=rev Log: Add { } to silence compiler warning [NFC] At least clang 3.6 warns on the original code: ../tools/clang/lib/CodeGen/CGNonTrivialStruct.cpp:829:34: error: suggest

[clang-tools-extra] r358157 - [clangd] Include compile command heuristic in logs

Author: sammccall Date: Thu Apr 11 01:17:15 2019 New Revision: 358157 URL: http://llvm.org/viewvc/llvm-project?rev=358157=rev Log: [clangd] Include compile command heuristic in logs Modified: clang-tools-extra/trunk/clangd/TUScheduler.cpp

[PATCH] D57464: Generalize method overloading on addr spaces to C++

ebevhan added a comment. In D57464#1438213 , @Anastasia wrote: > > I think I would lean towards the latter since it means less fudging around > > with a whole bunch of unrelated methods. Do @rjmccall or @rsmith have any > > further opinions on this? > >

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

jhenderson added a comment. I've not looked at the implementation in depth, but cl::DefaultOption seems like a nice way of handling this. Please make sure that there is testing in llvm-readobj and llvm-objdump that test their own short alias interpretation somewhere though. Repository: rG

[PATCH] D60126: [clangd] Use identifiers in file as completion candidates when build is not ready.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE358159: [clangd] Use identifiers in file as completion candidates when build is not… (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D60126?vs=194652=194653#toc

[PATCH] D59639: [clangd] Print template arguments helper

kadircet updated this revision to Diff 194658. kadircet added a comment. - Update file comment for PrintASTTests.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59639/new/ https://reviews.llvm.org/D59639 Files:

[PATCH] D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics

LukeGeeson added a comment. couple of nits, besides from that LGTM Comment at: lib/CodeGen/CGBuiltin.cpp:7813 } + case NEON::BI__builtin_neon_vduph_lane_f16:{ +return Builder.CreateExtractElement(Ops[0], EmitScalarExpr(E->getArg(1)), nit: spacing

[PATCH] D60561: [clang] fixing diagnostics of constexpr callstack

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. this is a bugfix for this added a constant copy of argument to CallStackFrame. and use it in describeCall instead of

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60408/new/ https://reviews.llvm.org/D60408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59641: [clangd] Show template argument list in workspacesymbols and documentsymbols responses

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:112 if (!Out.str().empty()) { -// FIXME(ibiryukov): do not show args not explicitly written by the user. -if (auto *ArgList =

[PATCH] D60560: [clangd] Enable clang-tidy by default.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. We have turned on the flag internally for a while, and we don't receive complains. Should be good to turn it on

[PATCH] D59639: [clangd] Print template arguments helper

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang-tools-extra/clangd/AST.cpp:139 + // location information. + printTemplateArgumentList(OS, Cls->getTemplateArgs().asArray(), Policy); +}

[PATCH] D59641: [clangd] Show template argument list in workspacesymbols and documentsymbols responses

ilya-biryukov added a comment. LG, just have a simple clarifying question. Comment at: clang-tools-extra/clangd/AST.cpp:112 if (!Out.str().empty()) { -// FIXME(ibiryukov): do not show args not explicitly written by the user. -if (auto *ArgList =

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. I have one question, once it is resolved I am fine with committing this. Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:352 +return true; +}

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r358159 - [clangd] Use identifiers in file as completion candidates when build is not ready.

Author: ioeric Date: Thu Apr 11 02:36:36 2019 New Revision: 358159 URL: http://llvm.org/viewvc/llvm-project?rev=358159=rev Log: [clangd] Use identifiers in file as completion candidates when build is not ready. Summary: o Lex the code to get the identifiers and put them into a "symbol" index. o

[PATCH] D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics

dnsampaio added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60272/new/ https://reviews.llvm.org/D60272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59639: [clangd] Print template arguments helper

kadircet added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:133 +printTemplateArgumentList(OS, *Args, Policy); + else if (auto *Cls = llvm::dyn_cast()) { +if (const TypeSourceInfo *TSI = Cls->getTypeAsWritten()) { ioeric wrote: >

[PATCH] D59639: [clangd] Print template arguments helper

kadircet updated this revision to Diff 194657. kadircet marked 7 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59639/new/ https://reviews.llvm.org/D59639 Files:

[PATCH] D60126: [clangd] Use identifiers in file as completion candidates when build is not ready.

ioeric updated this revision to Diff 194652. ioeric marked 2 inline comments as done. ioeric added a comment. - address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60126/new/ https://reviews.llvm.org/D60126 Files:

[PATCH] D60558: [clang-format] Fix indent of trailing raw string param after newline

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently clang-format uses ContinuationIndent to indent the contents of a raw string literal that is the last parameter of the function call. This is to achieve formatting similar to trailing:

[PATCH] D59465: [analyzer] Add example plugin for checker option handling

Szelethus planned changes to this revision. Szelethus added a comment. I'll move this, and the already existing plugin to test/ or unittest/. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59465/new/ https://reviews.llvm.org/D59465

[PATCH] D60126: [clangd] Use identifiers in file as completion candidates when build is not ready.

ioeric updated this revision to Diff 194647. ioeric marked 14 inline comments as done. ioeric added a comment. - address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60126/new/ https://reviews.llvm.org/D60126 Files:

[PATCH] D60126: [clangd] Use identifiers in file as completion candidates when build is not ready.

ioeric added inline comments. Comment at: clangd/CodeComplete.cpp:1360 getQueryScopes(Recorder->CCContext, *Recorder->CCSema, Opts); if (!QueryScopes.empty()) ScopeProximity.emplace(QueryScopes); sammccall wrote: > add this to the non-sema

[PATCH] D60541: [clang-format] Use SpacesBeforeTrailingComments for "option" directive

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60541/new/ https://reviews.llvm.org/D60541 ___

[PATCH] D60126: [clangd] Use identifiers in file as completion candidates when build is not ready.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/CodeComplete.cpp:345 + Completion.Origin |= SymbolOrigin::Identifier; + Completion.Name = C.IdentifierResult->Name; +}

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay added a comment. > -gsplit-dwarf -gmlt -fno-split-dwarf-inlining => 1 > > This last one currently produces split-dwarf (if there's any DWARF worth > splitting - if there are any subprogram descriptions, etc, otherwise it saves > the indirection and produces an empty .dwo file). Thanks

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay updated this revision to Diff 194673. MaskRay edited the summary of this revision. MaskRay added a comment. Update description Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923 Files:

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

aaron.ballman added a comment. In D60151#1454802 , @hintonda wrote: > In D60151#1454741 , @alexfh wrote: > > > In D60151#1454105 , @hintonda > > wrote: > > > > > - Rename

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

klimek added a comment. In D54881#1462804 , @russellmcc wrote: > Thanks for the explanation! I do understand your philosophy on this, and > agree with the desired behavior case you brought up where you have put in new > braces. > > After thinking about

[PATCH] D60542: Add support for attributes on @implementations in Objective-C

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60542/new/ https://reviews.llvm.org/D60542 ___

[PATCH] D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check

aaron.ballman added a comment. In D60139#1461269 , @DennisL wrote: > In D60139#1460233 , @JonasToth wrote: > > > Hey Dennis, > > > > my 2cents on the check. I think it is very good to have! Did you check > >

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

klimek added a comment. In D54881#1462893 , @MyDeveloperDay wrote: > > I agree and would be happy with the change if it would only change the > > line-filtered workflow, but this afaict (unless I'm missing something :) > > will also affect the workflow

[PATCH] D58573: [analyzer] Move UninitializedObjectChecker out of alpha

Szelethus updated this revision to Diff 194667. Szelethus retitled this revision from "[analyzer] Move UninitializedObject out of alpha" to "[analyzer] Move UninitializedObjectChecker out of alpha". Szelethus added a comment. Moved the checker to `optin.cplusplus`. CHANGES SINCE LAST ACTION

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

hintonda updated this revision to Diff 194669. hintonda added a comment. - Delay actually adding default options until ParseCommandLineOptions which simplifies handling and makes it easy to only add them to the correct SubCommand. Add simple tests. Repository: rG LLVM Github Monorepo

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

ostannard requested changes to this revision. ostannard added a comment. This revision now requires changes to proceed. The document you linked in the LLVM change (https://docs.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=vs-2019#return-values) says that small POD types are

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay updated this revision to Diff 194672. MaskRay added a comment. Update the description Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/split-debug.c Index:

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

hintonda added a comment. In D59746#1462352 , @jhenderson wrote: > I've not looked at the implementation in depth, but cl::DefaultOption seems > like a nice way of handling this. Please make sure that there is testing in > llvm-readobj and llvm-objdump

[PATCH] D59639: [clangd] Print template arguments helper

kadircet updated this revision to Diff 194686. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59639/new/ https://reviews.llvm.org/D59639 Files:

[PATCH] D59639: [clangd] Print template arguments helper

kadircet added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:139 + // location information. + printTemplateArgumentList(OS, Cls->getTemplateArgs().asArray(), Policy); +} ioeric wrote: > Could you also add a test case for this with

[PATCH] D60544: Support objc_nonlazy_class attribute on Objective-C implementations

rjmccall added a comment. Should we have a special `has_feature` test to check that this attribute is allowed on implementations? We've done that in the past when expanding the set of subjects for an attribute. But that's not necessary if we haven't made this attribute part of a public Xcode

[PATCH] D59605: [clangd] Introduce background-indexer

kadircet marked an inline comment as done. kadircet added a comment. Looking at the current state of `BackgroundIndex`, it has the following implementation details: - Loading of shards from storage - Storing of shards to storage - Collecting symbols from a TU - Sharding of symbol information

[PATCH] D60542: Add support for attributes on @implementations in Objective-C

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a question. Comment at: clang/test/FixIt/fixit-pragma-attribute.cpp:19-20 #pragma clang attribute push (__attribute__((annotate("subRuleContradictions"))), apply_to = any(variable,

[PATCH] D60561: [clang] fixing diagnostics of constexpr callstack

Quuxplusone added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:486 +/// diagnostics +ConstArgs ConstantArgs; + Please don't use a typedef for this. Follow the style of the surrounding lines. const APValue *ConstantArgs; (The pointer

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 194682. ilya-biryukov added a comment. - Fix header comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59887/new/ https://reviews.llvm.org/D59887 Files:

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov added a comment. The new version address most of the comments, there are just a few left in the code doing the mapping from Dmitri, I'll look into simplifying and removing the possibly redundant checks. Please take a look at this version, this is very close to the final state.

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

russellmcc added a comment. Thanks for the explanation! I do understand your philosophy on this, and agree with the desired behavior case you brought up where you have put in new braces. After thinking about this more, the thing I really care about is that clang-format is idempotent with a

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

hintonda updated this revision to Diff 194708. hintonda added a comment. - Add unittest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59746/new/ https://reviews.llvm.org/D59746 Files: clang/lib/Tooling/CommonOptionsParser.cpp

[PATCH] D59605: [clangd] Introduce background-indexer

ilya-biryukov added a subscriber: sammccall. ilya-biryukov added a comment. To reiterate the offline discussion: the tool seems useful to me, but it would be best to keep the client code simpler, it's currently fighting with `BackgroundIndex` because it's trying to hijack some of its

[PATCH] D60544: Support objc_nonlazy_class attribute on Objective-C implementations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, modulo the `__has_feature` question. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60544/new/ https://reviews.llvm.org/D60544

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

MyDeveloperDay added a comment. > I agree and would be happy with the change if it would only change the > line-filtered workflow, but this afaict (unless I'm missing something :) will > also affect the workflow where the provided range is 0-length range, which > has an implicit "format

[libunwind] r358164 - [libunwind] Fix the typo in unw_save_vfp_as_X alias

Author: phosek Date: Thu Apr 11 06:08:44 2019 New Revision: 358164 URL: http://llvm.org/viewvc/llvm-project?rev=358164=rev Log: [libunwind] Fix the typo in unw_save_vfp_as_X alias This was accidentaly introduced in r357640. Modified: libunwind/trunk/src/libunwind.cpp Modified:

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 194680. ilya-biryukov marked 19 inline comments as done. ilya-biryukov added a comment. - Remove a spamy debug tracing output. - Less debug output, move stuff around, more comments. - Add methods that map expanded tokens to raw tokens. - Rename

[PATCH] D60561: [clang] fixing diagnostics of constexpr callstack

Tyker updated this revision to Diff 194684. Tyker added a comment. @Quuxplusone edited based of feedback i simplified the test but didn't put the original because this one test arguments for variable and literal and there may be corner case differences CHANGES SINCE LAST ACTION

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea created this revision. gtbercea added reviewers: ABataev, AlexEichenberger, caomhin. Herald added subscribers: cfe-commits, jdoerfert, jfb, guansong, jholewinski. Herald added a project: clang. This patch adds support for the registration of the requires directives with the runtime.

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:2576 void CodeGenModule::EmitOMPRequiresDecl(const OMPRequiresDecl *D) { - getOpenMPRuntime().checkArchForUnifiedAddressing(D); } You don't need to pass the reference to CodeGenModule to

[PATCH] D60541: [clang-format] Use SpacesBeforeTrailingComments for "option" directive

dchai removed a subscriber: cfe-commits. dchai added a comment. Can someone please merge this for me? I don't have commit access. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60541/new/ https://reviews.llvm.org/D60541

[PATCH] D58749: [index-while-building] IndexRecordHasher

jkorous added a comment. We did performance tests of alternative approach - just hashing the serialized bit code representation. There's a performance regression in the sense that while the current implementation costs approx. extra 2.2% in build time the alternative approach costs 3.8%. We

[PATCH] D59756: [clangd] Support dependent bases in type hierarchy

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/unittests/clangd/TypeHierarchyTests.cpp:405 + *Result, + AllOf(WithName("S"), WithKind(SymbolKind::Struct), +Parents(AllOf(WithName("S"),

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

hintonda added a comment. In D60151#1463484 , @MyDeveloperDay wrote: > >> I suppose we could keep the names and directory structure and just change > >> the namespace. That would just be a special case in the scripts. Haven't > >> looked into it yet,

r358243 - Variable auto-init: also auto-init alloca

Author: jfb Date: Thu Apr 11 17:11:27 2019 New Revision: 358243 URL: http://llvm.org/viewvc/llvm-project?rev=358243=rev Log: Variable auto-init: also auto-init alloca Summary: alloca isn’t auto-init’d right now because it’s a different path in clang that all the other stuff we support (it’s a

[PATCH] D60548: Variable auto-init: also auto-init alloca

This revision was automatically updated to reflect the committed changes. Closed by commit rC358243: Variable auto-init: also auto-init alloca (authored by jfb, committed by ). Changed prior to commit: https://reviews.llvm.org/D60548?vs=194762=194787#toc Repository: rC Clang CHANGES SINCE

[PATCH] D60548: Variable auto-init: also auto-init alloca

jfb added a comment. I got an lgtm from @pcc on IRC, so I'll commit this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60548/new/ https://reviews.llvm.org/D60548 ___ cfe-commits mailing list

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

hintonda marked 2 inline comments as done. hintonda added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:282 else { - for (auto SC : O->Subs) -updateArgStr(O, NewName, SC); + if (O->isInAllSubCommands()) { +for (auto SC :

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 194683. ilya-biryukov added a comment. - Store a source manager in a token buffer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59887/new/ https://reviews.llvm.org/D59887 Files:

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

MyDeveloperDay added a comment. are we supporting "-llvm-*" in existing .clang-tidy files? If people selectively turn checkers off, won't all of a sudden everyone start getting llvm-project checks and fixes turned back on? https://github.com/search?q=-llvm-%2A=Code maybe we need to add

[PATCH] D59605: [clangd] Introduce background-indexer

ilya-biryukov added a comment. To make it clear, I think the question is not just "which part of functionality is missing in BackgroundIndex", it's rather "which part of BackgroundIndex we **don't** need". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

rjmccall added a comment. In D60573#1463641 , @riccibruno wrote: > In D60573#1463569 , @rjmccall wrote: > > > Hmm. Does this never impact code that's just using a locally-defined type > > within its scope? I

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1000 +def SYCLDevice : InheritableAttr { + let Spellings = [GNU<"sycl_device">]; + let Subjects = SubjectList<[Function, Var]>; keryell wrote: > Fznamznon wrote: > >

r358200 - Add support for attributes on @implementations in Objective-C

Author: epilk Date: Thu Apr 11 10:55:30 2019 New Revision: 358200 URL: http://llvm.org/viewvc/llvm-project?rev=358200=rev Log: Add support for attributes on @implementations in Objective-C We want to make objc_nonlazy_class apply to implementations, but ran into this. There doesn't seem to be

r358201 - Support objc_nonlazy_class attribute on Objective-C implementations

Author: epilk Date: Thu Apr 11 10:55:34 2019 New Revision: 358201 URL: http://llvm.org/viewvc/llvm-project?rev=358201=rev Log: Support objc_nonlazy_class attribute on Objective-C implementations Fixes rdar://49523079 Differential revision: https://reviews.llvm.org/D60544 Modified:

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1479 +/// \endcode +AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOfInterface, + internal::Matcher, stephanemoore wrote: > I am still uncertain about the

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

hintonda added a comment. In D60151#1462850 , @MyDeveloperDay wrote: > are we supporting "-llvm-*" in existing .clang-tidy files? > > If people selectively turn checkers off, won't all of a sudden everyone start > getting llvm-project checks and fixes

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-self-assignment.rst:10 + +This check corresponds to the CERT C++ Coding Standard rule +`OOP54-CPP. Gracefully handle self-copy assignment Eugene.Zelenko

[PATCH] D55411: [clang-tidy] check for flagging using declarations not in the inner most namespace

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/SafelyScopedCheck.cpp:37 + diag(MatchedDecl->getLocation(), + "using declaration %0 not declared in the innermost namespace.") + << MatchedDecl; You should remove the full stop at the

[PATCH] D60544: Support objc_nonlazy_class attribute on Objective-C implementations

erik.pilkington added a comment. In D60544#1462869 , @rjmccall wrote: > Should we have a special `has_feature` test to check that this attribute is > allowed on implementations? We've done that in the past when expanding the > set of subjects for an

[PATCH] D60542: Add support for attributes on @implementations in Objective-C

aaron.ballman added inline comments. Comment at: clang/test/FixIt/fixit-pragma-attribute.cpp:19-20 #pragma clang attribute push (__attribute__((annotate("subRuleContradictions"))), apply_to = any(variable, variable(is_parameter), function(is_member), variable(is_global))) -//

Re: [PATCH] D59605: [clangd] Introduce background-indexer

Thanks - I think there's quite a lot of background missing here: what/who is this for, why a separate binary from clangd-indexer (or and how do they relate, how much of the BackgroundIndex code structure makes sense with multiple users. I assume there's been some offline discussion about this,

[PATCH] D60572: creduce-clang-crash: Use `!` instead of `not`

akhuang added a comment. Looks good- if we remove `not` there are a few other things that should be removed Comment at: clang/utils/creduce-clang-crash.py:138 if "fatal error:" in msg_re: self.is_crash = False break also wouldn't

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/PreferIsaOrDynCastInConditionalsCheck.cpp:125 +diag(MatchedDecl->getBeginLoc(), + "isa_and_nonnull<> is cleaner and more efficient") +<<

[PATCH] D55409: [clang-tidy] check for using declarations not in an anonymous namespace when there exists one

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/AnonymousEnclosedAliasesCheck.cpp:41 +// to the vector containing all candidate using declarations. +if (AnonymousNamespaceDecl) { + diag(MatchedUsingDecl->getLocation(),

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

riccibruno created this revision. riccibruno added reviewers: rjmccall, Quuxplusone. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. The goal here is to exercise each rule in [basic.lookup.argdep] at least once. These new tests expose what I believe are 2 issues: 1.

[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

lebedev.ri added a comment. In D60151#1462976 , @hintonda wrote: > In D60151#1462850 , @MyDeveloperDay > wrote: > > > are we supporting "-llvm-*" in existing .clang-tidy files? > > > > If people selectively turn

[PATCH] D60548: Variable auto-init: also auto-init alloca

pcc added a comment. I probably wouldn't do anything about suppressing init on alloca for now, but if we did do something I think I'd be in favour of the separate builtin for uninitialized alloca. I also considered the alternative of allowing `__attribute__((uninitialized))` to appear on a

[PATCH] D60572: creduce-clang-crash: Use `!` instead of `not`

thakis created this revision. thakis added a reviewer: akhuang. The run script runs in bash, so no need to depend on llvm's `not` binary. https://reviews.llvm.org/D60572 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clang-crash.py

[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

riccibruno created this revision. riccibruno added reviewers: rjmccall, Quuxplusone. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. riccibruno added a parent revision: D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup. CWG 1691 changed

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

hintonda updated this revision to Diff 194729. hintonda added a comment. Enhance Option::reset to reset the default value and remove the option if it's a cl::DefaultOption. Also, make sure removeOption only removes an option if both the name and the Option matches, not just the name -- different

[libunwind] r358191 - [NFC] Correct outdated links to the Itanium C++ ABI documentation

Author: ldionne Date: Thu Apr 11 09:37:07 2019 New Revision: 358191 URL: http://llvm.org/viewvc/llvm-project?rev=358191=rev Log: [NFC] Correct outdated links to the Itanium C++ ABI documentation Those are now hosted on GitHub. rdar://problem/36557462 Modified:

[PATCH] D60542: Add support for attributes on @implementations in Objective-C

erik.pilkington marked an inline comment as done. erik.pilkington added inline comments. Comment at: clang/test/FixIt/fixit-pragma-attribute.cpp:19-20 #pragma clang attribute push (__attribute__((annotate("subRuleContradictions"))), apply_to = any(variable,

[PATCH] D60544: Support objc_nonlazy_class attribute on Objective-C implementations

rjmccall accepted this revision. rjmccall added a comment. Great, SGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60544/new/ https://reviews.llvm.org/D60544 ___ cfe-commits mailing list

[PATCH] D60544: Support objc_nonlazy_class attribute on Objective-C implementations

This revision was automatically updated to reflect the committed changes. Closed by commit rL358201: Support objc_nonlazy_class attribute on Objective-C implementations (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D60542: Add support for attributes on @implementations in Objective-C

This revision was automatically updated to reflect the committed changes. Closed by commit rC358200: Add support for attributes on @implementations in Objective-C (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D60542?vs=194594=194716#toc Repository: rC

[PATCH] D60572: creduce-clang-crash: Use `!` instead of `not`

thakis abandoned this revision. thakis added a comment. This seems to break the script, nevermind! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60572/new/ https://reviews.llvm.org/D60572 ___ cfe-commits mailing list

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

hintonda added a comment. @klimek, this patch is now ready for review. Thanks... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59746/new/ https://reviews.llvm.org/D59746 ___ cfe-commits mailing list

[PATCH] D60548: Variable auto-init: also auto-init alloca

jfb added a comment. In D60548#1462124 , @jfb wrote: > One downside to alloca is that we can's use `__attribute__((uninitialized))` > because it's a builtin. Maybe we need a separate uninitialized alloca? What > do you all think? Actually I'm

[PATCH] D60548: Variable auto-init: also auto-init alloca

jfb added a comment. In D60548#1463181 , @jfb wrote: > In D60548#1462124 , @jfb wrote: > > > One downside to alloca is that we can's use > > `__attribute__((uninitialized))` because it's a builtin. Maybe we need a

[PATCH] D60548: Variable auto-init: also auto-init alloca

jfb updated this revision to Diff 194736. jfb added a comment. Herald added a subscriber: mgorny. - Move patternFor to a shared file as requested by @rjmccall Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60548/new/ https://reviews.llvm.org/D60548 Files:

  1   2   >