[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3197 +by the pragma behaves as though the command-line option + ``-ffp-exception-behavior=strict`` is enabled, +when ``pragma float_control(precise, off)`` is en

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. Mark as accepted to make Phabricator/arc happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 ___

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. In D77229#2005413 , @baloghadamsoftware wrote: > llvm-project/clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:333: > clang::ento::ProgramStateRef > clang::ento::ExprEngine::createTemporaryRegionIfNeeded(clang::ento::Pr

[PATCH] D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms.

amccarth added a comment. In D78508#2005311 , @aaron.ballman wrote: > Personally, I don't consider those to be useless casts. They appropriately > ensure that the types match between the arguments and the format specifiers, > rather than relying on unde

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7363ffe95f0a: [Matrix] Add draft specification for matrix support in Clang. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D76612?vs=258269&id=260367#toc Repository: rG LLVM G

[clang] 0852bab - Fix test/Misc/warning-flags.c after 5c03beefa720bddb3e3f53c595a76bce7ad50f37

Author: Fangrui Song Date: 2020-04-27T10:18:48-07:00 New Revision: 0852babc3052b39a99be86c7075d975e1e89e5c2 URL: https://github.com/llvm/llvm-project/commit/0852babc3052b39a99be86c7075d975e1e89e5c2 DIFF: https://github.com/llvm/llvm-project/commit/0852babc3052b39a99be86c7075d975e1e89e5c2.diff

[clang] 580a9f2 - Fix test without built AMDGPU

Author: Matt Arsenault Date: 2020-04-27T13:32:00-04:00 New Revision: 580a9f2c307f8d475277f20999ad5820d171beba URL: https://github.com/llvm/llvm-project/commit/580a9f2c307f8d475277f20999ad5820d171beba DIFF: https://github.com/llvm/llvm-project/commit/580a9f2c307f8d475277f20999ad5820d171beba.diff

[PATCH] D78760: Check a class has a definition before iterating over its base classes

ahatanak added a comment. I think the non-dependent base class you mention in this case is `B0`, but it seems that the type of `B0` in the AST is dependent as `isDependentType` returns true. Should we fix this? Or does `isDependentType` mean something different? Repository: rG LLVM Github M

[PATCH] D78944: [libc++][test] Disable test for extension that's unsupportable in C++20

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. Could you add a short comment explaining the `#if`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78944/new/ https://reviews.llvm.or

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

Quuxplusone added inline comments. Comment at: llvm/include/llvm/Support/BinaryStreamRef.h:124 - bool operator==(const RefType &Other) const { -if (BorrowedImpl != Other.BorrowedImpl) + friend bool operator==(const RefType &Self, const RefType &Other) { +if (Self.Borr

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

erichkeane added a comment. @rjmccall : can you comment on the CallExpr's trailing storage issue? And give advice as to what you meant in the last review? Comment at: clang/include/clang/AST/Expr.h:2122 +return *getTrailingObjects(); + } + const FPOptions &getTrailingF

[PATCH] D78190: Add Bfloat IR type

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/docs/LangRef.rst:2896 + * - ``bfloat`` + - 16-bit brain floating-point value (8-bit mantissa) + scanon wrote: > rjmccall wrote: > > rjmccall wrote: > > > scanon wrote: > >

[PATCH] D78190: Add Bfloat IR type

stuij updated this revision to Diff 260373. stuij marked an inline comment as done. stuij added a comment. updated bfloat documentation as per comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190 Files:

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78915: [clang-format] Improved parser for C# properties

MyDeveloperDay added a comment. I think if this code is only used by C# which the first if suggests, we should be OK, just tidy up a bit with the old code and I think this is fine. Thank you, so great to have other C#'ers doing this ;-) "Clang format all the things..." Com

[PATCH] D78827: Add support for #pragma clang fp allow_reassociation(on|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 260381. mibintc retitled this revision from "Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations" to "Add support for #pragma clang fp allow_reassociation(on|off) -- floating point control of associa

[PATCH] D78915: [clang-format] Improved parser for C# properties

krasimir added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1508 bool HasGetOrSet = false; + bool IsTrivialPropertyAccessor = true; while (!eof()) { Add a comment illustrating is what is a trivial property accessor. CHANGES SINCE

[PATCH] D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78534/new/ https://reviews.llvm.org/D78534 ___

[PATCH] D78903: [Driver] Add option -fproc-stat-report

aganea added inline comments. Comment at: clang/docs/UsersManual.rst:770 + $ cat abc + clang-11,"/tmp/foo-123456.o",92000,84000,87536 + ld,"a.out",900,8000,53568 Please add a header to the output .CSV, specifying the units of measure where relevant.

[PATCH] D78755: [SveEmitter] Add builtins for svlen

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78755/new/ https://reviews.llvm.org/D78755 ___

[clang] dab1326 - Strip -showIncludes in getClangStripDependencyFileAdjuster()

Author: Arthur Eubanks Date: 2020-04-27T11:20:08-07:00 New Revision: dab1326a5ae32ffd2dc277027e1ae68d8b5124d5 URL: https://github.com/llvm/llvm-project/commit/dab1326a5ae32ffd2dc277027e1ae68d8b5124d5 DIFF: https://github.com/llvm/llvm-project/commit/dab1326a5ae32ffd2dc277027e1ae68d8b5124d5.diff

[PATCH] D78760: Check a class has a definition before iterating over its base classes

ahatanak added a comment. `TagDecl::isDependentType()` is returning true. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78760/new/ https://reviews.llvm.org/D78760 ___ cfe-commits mailing list cfe-commi

[PATCH] D78944: [libc++][test] Disable test for extension that's unsupportable in C++20

CaseyCarter updated this revision to Diff 260391. CaseyCarter added a comment. Review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78944/new/ https://reviews.llvm.org/D78944 Files: libcxx/test/std/containers/associative/map/map.cons/default_recursive.pass.cpp libcxx/tes

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 260387. baloghadamsoftware added a comment. I implemented the basic `isLive()` and `getBinding()` functions which reduced the number of failing tests by `0`. I also implemented dynamic calculation of the type which increased the number of failing

[PATCH] D78939: Strip -showIncludes in getClangStripDependencyFileAdjuster()

This revision was automatically updated to reflect the committed changes. Closed by commit rGdab1326a5ae3: Strip -showIncludes in getClangStripDependencyFileAdjuster() (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78939/new/

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

rsmith added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:64-67 +return Value == unsigned(V); + } + bool operator!=(OpenMPDirectiveKindExWrapper V) const { +return Value != unsigned(V); Comparing against `V.Value` here would seem more id

[PATCH] D78827: Add support for #pragma clang fp allow_reassociation(on|off) -- floating point control of associative math transformations

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1336 + "%select{invalid|missing}0 option%select{ %1|}0; expected contract or reassoc">; +def err_pragma_fp_contract_invalid_argument : Error< + "unexpected argument '%0' to '#pragma

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn updated this revision to Diff 260402. fhahn added a comment. Ping. Now that the draft specification is committed, I think it would be great if we could move on to review of the patches in detail. I've split the implementation into a few distinct parts (initial type support, [][] operators

[PATCH] D78909: [clang-format] NFC clang-format the clang-format sources

Wawha accepted this revision. Wawha added a comment. Thank for the changes ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78909/new/ https://reviews.llvm.org/D78909 ___ cfe-commits mailing list cfe-co

[clang] 5c8c990 - make sure to not warn about unused macros from -D

Author: Luboš Luňák Date: 2020-04-27T21:26:13+02:00 New Revision: 5c8c9905c2496a38a17f1b2a180601e790e45db9 URL: https://github.com/llvm/llvm-project/commit/5c8c9905c2496a38a17f1b2a180601e790e45db9 DIFF: https://github.com/llvm/llvm-project/commit/5c8c9905c2496a38a17f1b2a180601e790e45db9.diff L

[clang] f594e3d - [clang-format] NFC clang-format the clang-format sources

Author: mydeveloperday Date: 2020-04-27T20:41:37+01:00 New Revision: f594e3d2ab92fc4e00359d017a7ea3c8deb771ce URL: https://github.com/llvm/llvm-project/commit/f594e3d2ab92fc4e00359d017a7ea3c8deb771ce DIFF: https://github.com/llvm/llvm-project/commit/f594e3d2ab92fc4e00359d017a7ea3c8deb771ce.diff

[PATCH] D69585: Add option to instantiate templates already in the PCH

llunak added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69585/new/ https://reviews.llvm.org/D69585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D78953: [libcxx][docs][dfsan] Fix rst rendering related typos

zbrid created this revision. zbrid added reviewers: ldionne, EricWF. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. - Fix the code block disappearance problem by adding a new line - Fix the typo where I forgot a space Repository: rG LLVM Github Monorepo http

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

llunak added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74846/new/ https://reviews.llvm.org/D74846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 5 inline comments as done. mibintc added a comment. A couple replies to @erichkeane Comment at: clang/include/clang/AST/Expr.h:2251 + /// allocated in Trailing Storage + void setHasStoredFPFeatures(bool B) { UnaryOperatorBits.HasFPFeatures = B; } + bool hasSto

[PATCH] D78958: [SVE] Update EmitSVEPredicateCast to take a ScalableVectorType

ctetreau created this revision. Herald added subscribers: cfe-commits, psnobl, rkruppe, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a reviewer: efriedma. Herald added a project: clang. Removes usage of VectorType::getNumElements identified by test located at CodeGen/aa

[PATCH] D73846: [PCH] make sure to not warn about unused macros from -D

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c8c9905c249: make sure to not warn about unused macros from -D (authored by llunak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73846/new/ https://revie

[PATCH] D78909: [clang-format] NFC clang-format the clang-format sources

This revision was automatically updated to reflect the committed changes. Closed by commit rGf594e3d2ab92: [clang-format] NFC clang-format the clang-format sources (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78909/new/

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added a comment. If your change causes a crash, please debug it. That's a completely normal thing that programmers do every day. Unfortunately, I can't afford to spoon-feed you the solution step-by-step. Comment at: clang/lib/StaticAnalyzer/Core/SymbolManager.cpp:601-603

[clang] ce7eb72 - Thread safety analysis: Reword warning after D72635

Author: Aaron Puchert Date: 2020-04-27T22:23:52+02:00 New Revision: ce7eb72a3c87a9d15ba4962fa7a23aad24f98156 URL: https://github.com/llvm/llvm-project/commit/ce7eb72a3c87a9d15ba4962fa7a23aad24f98156 DIFF: https://github.com/llvm/llvm-project/commit/ce7eb72a3c87a9d15ba4962fa7a23aad24f98156.diff

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

aganea added a comment. If I understand correctly, this patch reverts the behavior to what it was before your changes, to only handle modules, but not PCH? Is that correct? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74846/new/ https://reviews.llvm.org/D74846

[PATCH] D78853: [Sema] Fix null pointer dereference warnings [1/n]

mgrang added a comment. In D78853#2003866 , @efriedma wrote: > Please don't add null checks for pointers that can't be null. It makes the > code slower and harder to understand. And least one of the checks you added > is actively breaking the code. > >

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

dblaikie accepted this revision. dblaikie added a comment. Seems good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.llvm.org/D77621 ___ cfe-commits mailing list cfe-co

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

dblaikie added a comment. In D76801#2005264 , @labath wrote: > In D76801#1997451 , @dblaikie wrote: > > > Yeah, points all taken - as for this actual issue... I'm kind of inclined > > to say "hey, our template name

[PATCH] D78960: [SveEmitter] Add builtins for ternary ops (fmla, fmad, etc)

sdesmalen added a comment. Now that most of the functionality has been added to SveEmitter.cpp and CGBuiltin.cpp, the patches are becoming simpler and simpler. This patch is such an example, which is basically "builtin definitions + tests". This is probably a good point to ask for some feedback

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

sconstab updated this revision to Diff 260439. sconstab added a comment. Removed the `-x86-lvi-no-fixed` CLI flag. This change simplifies the code flow quite a bit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75936/new/ https://reviews.llvm.org/D75936 Files: clang/include/clang/Dr

[PATCH] D78958: [SVE] Update EmitSVEPredicateCast to take a ScalableVectorType

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78958/new/ https://reviews.llvm.org/D78958 ___

[PATCH] D78944: [libc++][test] Disable test for extension that's unsupportable in C++20

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4437992ecce: [libc++][test] Disable test for extension that's unsupportable in C++20 (authored by CaseyCarter). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

smeenai added a comment. @zhuhan0, do you need someone to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78534/new/ https://reviews.llvm.org/D78534 ___ cfe-commits mailing list cfe-

[clang] e4872d7 - [SveEmitter] Add builtins for svlen

Author: Sander de Smalen Date: 2020-04-27T21:27:32+01:00 New Revision: e4872d7f08a1d6f657aaf3bd83b2e3b65fccebd4 URL: https://github.com/llvm/llvm-project/commit/e4872d7f08a1d6f657aaf3bd83b2e3b65fccebd4 DIFF: https://github.com/llvm/llvm-project/commit/e4872d7f08a1d6f657aaf3bd83b2e3b65fccebd4.di

[PATCH] D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

zhuhan0 added a comment. @smeenai Yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78534/new/ https://reviews.llvm.org/D78534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D78755: [SveEmitter] Add builtins for svlen

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4872d7f08a1: [SveEmitter] Add builtins for svlen (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78755/new/ https://reviews.llvm.org

[clang] f8990fe - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

Author: Han Zhu Date: 2020-04-27T13:37:07-07:00 New Revision: f8990feb125a0f8d3f2892a589bc6fad3c430858 URL: https://github.com/llvm/llvm-project/commit/f8990feb125a0f8d3f2892a589bc6fad3c430858 DIFF: https://github.com/llvm/llvm-project/commit/f8990feb125a0f8d3f2892a589bc6fad3c430858.diff LOG:

[clang] 612720d - [hip] Remove test using `hip_pinned_shadow` attribute. NFC.

Author: Michael Liao Date: 2020-04-27T16:44:59-04:00 New Revision: 612720db874d06a50b793c301e5b3b857e3e7c70 URL: https://github.com/llvm/llvm-project/commit/612720db874d06a50b793c301e5b3b857e3e7c70 DIFF: https://github.com/llvm/llvm-project/commit/612720db874d06a50b793c301e5b3b857e3e7c70.diff

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

aganea added a comment. @llunak : It seems @hans already reverted this in rG7ea9a6e0220da36ff2fd1fbc29c2755be23e5166 , could you please ensure this patch is still relevant? Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

zhuhan0 added a comment. @smeenai Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78534/new/ https://reviews.llvm.org/D78534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

smeenai added a comment. Committed. Please forward any buildbot failure emails to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78534/new/ https://reviews.llvm.org/D78534 ___ cfe-commits mailing li

[PATCH] D78767: [Sema] Teach -Wcast-align to compute a more accurate alignment when the source expression has array subscript or pointer arithmetic operators

ahatanak planned changes to this revision. ahatanak added a comment. The method has to compute the correct alignment for variables captured by lambdas or blocks too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78767/new/ https://reviews.llvm.org

[PATCH] D78960: [SveEmitter] Add builtins for ternary ops (fmla, fmad, etc)

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM For patches that only touch arm_sve.td, I trust that you've written it correctly; if there were any mistakes, it would be very hard to catch them in review anyway. However you prefe

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:186-188 + NameLookup(const NamedDecl *ND) : Data(ND, false) {} + NameLookup(llvm::NoneType) : Data(nullptr, true) {} + NameLookup(std::nullptr_t) : Data(nullptr, false

[PATCH] D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8990feb125a: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON (authored by zhuhan0, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D78223: [clang-tidy] performance-range-for-copy only for copy.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some small nits Comment at: clang-tools-extra/clang-tidy/performance/ForRangeCopyCheck.cpp:68 +// loop index because it's less clear than copying the temporary. +static bool isCopyConstructedFr

[PATCH] D78900: [HIP][AMDGPU] Enable structurizer workarounds

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:158 Args.MakeArgString(Twine("-filetype=") + (OutputIsAsm ? "asm" : "obj"))); + LlcArgs.push_back("--amdgpu-enable-structurizer-workarounds"); We should just flip this in the

[PATCH] D78965: [clang][OpenMP] Fix mangling of linear parameters.

fpetrogalli created this revision. fpetrogalli added reviewers: ABataev, andwar. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. The linear parameter token in the mangling function must be multiplied by the pointee size in

[PATCH] D78890: [clang-tidy] Add check callee-namespace.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:22-23 +const DeclContext *getOutermostNamespace(const DeclContext *Decl) { + if (Decl->isTranslationUnit()) +return Decl; + if (Decl->getParent() && Decl->getPare

[PATCH] D78762: build: use `find_package(Python3)` if available

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I talked to Saleem and he cleared up some of my concerns. Given that the community seems to have agreed to support only Python 3, this change seems a lot more reasonable. My earlie

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

MaskRay closed this revision. MaskRay added a comment. @browneee Hi, it seems that you did not attach `Differential Revision: ` to the commit dda3c19a3618dce9492687f8e880e7a73486ee98 so the differential was not closed automat

[PATCH] D78842: [SVE][NFC] Use ScalableVectorType in CGBuiltin

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78842/new/ https://reviews.llvm.org/D78842 ___

[PATCH] D78563: [AIX] Port power alignment rules to clang

Xiangling_L abandoned this revision. Xiangling_L added a comment. Current implementation conflicts with __AlignOf behavior as we discussed in [RFC] Adding AIX power alignment rule in clang front end (http://lists.llvm.org/pipermail/cfe-dev/2020-April/065324.html) . Drop this revision and a ne

[PATCH] D77621: ADT: SmallVector size/capacity use word-size integers when elements are small

MaskRay added a comment. I guess this fixes https://bugs.llvm.org/show_bug.cgi?id=45289 as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.llvm.org/D77621 ___ cfe-commits

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hubert.reinterpretcast added a comment. In D78350#1988416 , @hokein wrote: > @ebevhan, @hubert.reinterpretcast, the patch is based on > fd7a34186137168064ffe2ca536823559b92d939 > , it

[PATCH] D78953: [libcxx][docs][dfsan] Fix rst rendering related typos

This revision was automatically updated to reflect the committed changes. Closed by commit rGc750847e0c3b: [libcxx][docs][dfsan] Fix rst rendering related typos (authored by zbrid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78953/new/ https://re

[clang] c750847 - [libcxx][docs][dfsan] Fix rst rendering related typos

Author: Zola Bridges Date: 2020-04-27T15:07:11-07:00 New Revision: c750847e0c3b07944f5ad6e18f2a37a523964c35 URL: https://github.com/llvm/llvm-project/commit/c750847e0c3b07944f5ad6e18f2a37a523964c35 DIFF: https://github.com/llvm/llvm-project/commit/c750847e0c3b07944f5ad6e18f2a37a523964c35.diff

[PATCH] D78762: build: use `find_package(Python3)` if available

smeenai added a comment. In D78762#2006406 , @JDevlieghere wrote: > I talked to Saleem and he cleared up some of my concerns. Given that the > community seems to have agreed to support only Python 3, this change seems a > lot more reasonable. My earlier

[PATCH] D78842: [SVE][NFC] Use ScalableVectorType in CGBuiltin

ctetreau updated this revision to Diff 260472. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78842/new/ https://reviews.llvm.org/D78842 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CodeGenFunction.h

[PATCH] D78760: Check a class has a definition before iterating over its base classes

jkorous added a comment. In D78760#2003118 , @rsmith wrote: > If so, we'll need to make sure that all code that iterates over base classes > checks for this condition (I bet there are more cases than the two that you > found). Just a potentially relate

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin updated this revision to Diff 260477. BRevzin added a comment. More idiomatic comparison implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78938/new/ https://reviews.llvm.org/D78938 Files: clang/lib/Parse/ParseOpenMP.cpp In

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

fpetrogalli created this revision. fpetrogalli added a reviewer: ABataev. Herald added subscribers: cfe-commits, danielkiss, guansong, kristof.beyls, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. fpetrogalli added a comment. Hello reviewers, I know this is not how th

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin marked 2 inline comments as done. BRevzin added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:69-70 + } bool operator==(OpenMPDirectiveKind V) const { return Value == unsigned(V); } bool operator!=(OpenMPDirectiveKind V) const { return Value != unsig

[PATCH] D78958: [SVE] Update EmitSVEPredicateCast to take a ScalableVectorType

ctetreau updated this revision to Diff 260474. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78958/new/ https://reviews.llvm.org/D78958 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CodeGenFunction.h

[PATCH] D78969: [clang][OpenMP] Fix getNDSWDS for aarch64.

fpetrogalli added a comment. Hello reviewers, I know this is not how the fix should be tested (`fprintf` in debug builds...). This function would benefit of some unitests in the `unittests` folder of clang, but I don't have a way to export it there as it is private to this module. I would lik

[PATCH] D78970: [CUDA][HIP] Fix ambiguity of new operator

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. https://reviews.llvm.org/D77954 caused a regression about ambiguity of new operator in file scope. This patch recovered the previous behavior for comparison without a caller. This is a workaround. For real fix we need D71227

[PATCH] D78842: [SVE][NFC] Use ScalableVectorType in CGBuiltin

ctetreau updated this revision to Diff 260491. ctetreau added a comment. fix syntax error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78842/new/ https://reviews.llvm.org/D78842 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CodeGen

[clang] da8918f - [SVE][NFC] Use ScalableVectorType in CGBuiltin

Author: Christopher Tetreault Date: 2020-04-27T16:29:45-07:00 New Revision: da8918f27e3020ea5d16c6e266f8916d022d41e0 URL: https://github.com/llvm/llvm-project/commit/da8918f27e3020ea5d16c6e266f8916d022d41e0 DIFF: https://github.com/llvm/llvm-project/commit/da8918f27e3020ea5d16c6e266f8916d022d41

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

yaxunl added a comment. LGTM. Can we get this in? There are other fixes depending on this. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 ___ cfe-commi

[PATCH] D78970: [CUDA][HIP] Fix ambiguity of new operator

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This really has nothing to do with the `new` operator specifically, but it looks like a good fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78970/new/ https://reviews.llvm.or

[PATCH] D78842: [SVE][NFC] Use ScalableVectorType in CGBuiltin

This revision was automatically updated to reflect the committed changes. Closed by commit rGda8918f27e30: [SVE][NFC] Use ScalableVectorType in CGBuiltin (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78842/new/ https://review

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin added a comment. Wtf, where'd my other changes go? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78938/new/ https://reviews.llvm.org/D78938 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

hubert.reinterpretcast added a comment. In D78938#2006715 , @BRevzin wrote: > Wtf, where'd my other changes go? I've hit this before, use `arc diff --update D78938 `. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D78762: build: use `find_package(Python3)` if available

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: llvm/CMakeLists.txt:696 +message(WARNING "Python3 not found, using python2 as a fallback") +find_package(Python3 COMPONENTS Interpreter REQUIRED) +if(Python2_VERSION VERSION_LESS 2.

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

yaxunl added a comment. In D77954#2005313 , @gribozavr2 wrote: > Sorry -- this change broke overload resolution for `operator new`, as it is > declared in system headers. I'm reverting the patch. > > $ cat /tmp/in.cu.cc > #define __device__ __attribut

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin added a comment. In D78938#2006758 , @hubert.reinterpretcast wrote: > In D78938#2006715 , @BRevzin wrote: > > > Wtf, where'd my other changes go? > > > I've hit this before, use `arc diff --update D78938 `.

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin updated this revision to Diff 260521. BRevzin added a comment. Trying this again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78938/new/ https://reviews.llvm.org/D78938 Files: clang/include/clang/AST/StmtIterator.h clang/lib/Parse/Pa

[clang] cd84bfb - build: use `find_package(Python3)` if available

Author: Saleem Abdulrasool Date: 2020-04-28T01:33:10Z New Revision: cd84bfb8142bc7ff3a07a188ffb809f1d86d1fd7 URL: https://github.com/llvm/llvm-project/commit/cd84bfb8142bc7ff3a07a188ffb809f1d86d1fd7 DIFF: https://github.com/llvm/llvm-project/commit/cd84bfb8142bc7ff3a07a188ffb809f1d86d1fd7.diff

[PATCH] D78979: OpenCL: Include builtin header by default

arsenm created this revision. arsenm added reviewers: Anastasia, yaxunl. Herald added subscribers: kerbowa, nhaehnle, wdng, jvesely. arsenm added a comment. I'm also wondering if using -nogpulib for the corresponding linker purpose was correct, since in the OpenCL case it's not really an offload

[PATCH] D78762: build: use `find_package(Python3)` if available

compnerd closed this revision. compnerd added a comment. rGcd84bfb8142bc7ff3a07a188ffb809f1d86d1fd7 (with the Python2 fixes) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78762/

[PATCH] D78979: OpenCL: Include builtin header by default

arsenm added a comment. I'm also wondering if using -nogpulib for the corresponding linker purpose was correct, since in the OpenCL case it's not really an offload target. Maybe this should switch to -nostdlib? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78979/new/ https://reviews.l

[PATCH] D78890: [clang-tidy] Add check callee-namespace.

PaulkaToast updated this revision to Diff 260524. PaulkaToast marked 8 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78890/new/ https://reviews.llvm.org/D78890 Files: clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt

[PATCH] D78980: Elaborate more on --rocm-path flag.

arsenm created this revision. arsenm added reviewers: yaxunl, t-tye. Herald added a subscriber: wdng. I'm not sure what the conventions are for this documentation. The format seems limiting. I don't see how to refer to other flags, or mark flags as deprecated. The rst I believe these generate seem

[PATCH] D78762: build: use `find_package(Python3)` if available

thakis added a comment. Is there more background on this somewhere? What's the advantage of using Python3_EXECUTABLE instead of just PYTHON_EXECUTABLE? Having Python3_EXECUTABLE be python 2 seems pretty surprising to me. Also, this doesn't update some PYTHON_EXECUTABLEs, e.g. the one in lld/tes

<    1   2   3   >