[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

Abpostelnicu requested changes to this revision. Abpostelnicu added a comment. This revision now requires changes to proceed. As per what @sammccall said. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79201/new/ https://reviews.llvm.org/D79201

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 updated this revision to Diff 261740. jcai19 added a comment. Issue a warning when the proposed flag is used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77168/new/ https://reviews.llvm.org/D77168 Files:

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen updated this revision to Diff 261741. khchen added a comment. address kito's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71124/new/ https://reviews.llvm.org/D71124 Files: clang/lib/Basic/Targets/RISCV.cpp

[PATCH] D79160: [AST] Preserve the type in RecoveryExprs for broken function calls.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ComputeDependence.cpp:488 ExprDependence clang::computeDependence(RecoveryExpr *E) { + // Even we know the concrete type of the

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 261826. baloghadamsoftware added a comment. Only 4 tests failing, but still lot to do. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://reviews.llvm.org/D77229 Files:

[PATCH] D79276: [FileCheck] Support comment directives

jdenny marked 4 inline comments as done. jdenny added a comment. Thanks for the review. I've replied to a few comments, and I'll address the rest later. In D79276#2017101 , @jhenderson wrote: > I hesitate to suggest this, but is it worth using `REM` as

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

jyknight added a comment. Hi, it seems that this change is incompatible with the `[NSItemProvider loadItemForTypeIdentifier:options:completionHandler:]` method's expected (but extremely weird and unusual!) usage. Per

[PATCH] D79334: [clang-tidy]: Add cert-str34-c alias for bugprone-signed-char-misuse.

ztamas created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. ztamas edited the summary of this revision. ztamas edited the summary of this revision. ztamas edited the summary of this revision. ztamas added a reviewer: aaron.ballman. Added

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69088/new/ https://reviews.llvm.org/D69088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79315: [clangd] Get rid of Inclusion::R

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is only used by documentlink and go-to-definition. We are pushing range detection logic from

[PATCH] D77598: Integral template argument suffix printing

reikdas updated this revision to Diff 261774. reikdas added a comment. Sorry my earlier update did not include the changes from the earlier revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/lib/AST/TemplateBase.cpp

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

awarzynski added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:71 const auto& D = C.getDriver(); - const std::string = D.getFFCGenericFortranName(); + const std::string = D.getGenericFortranFE(); const char *FortranName; [nit]

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

awarzynski added a comment. @CarolineConcatto thank you for the updates! - It looks like you accidentally pushed two commits in one patch :) Could you please squash and resubmit? (this should clean-up the diff). Ta! - Perhaps `CFCGenericFlangName` instead of `GenericFortranFE`? This would

[PATCH] D77598: Integral template argument suffix printing

reikdas updated this revision to Diff 261772. reikdas added a comment. Addresses @rsmith 's inline comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/lib/AST/TemplateBase.cpp clang/test/CXX/dcl.decl/dcl.decomp/p3.cpp

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

erichkeane marked 15 inline comments as done. erichkeane added a comment. Thanks for the review @rjmccall . Updated patch coming momentarily. I audited my 'byval' use as well. I still have 1 open, the 'array' comment which I wasn't clear what you meant. Comment at:

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang.

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

vsavchenko updated this revision to Diff 261833. vsavchenko marked an inline comment as done. vsavchenko added a comment. Now `getRange` is more likely to return unfeasible range. Calling `Intersect` and `pin` methods from such ranges might cause a crash. Check for unfeasible ranges.

[PATCH] D79276: [FileCheck] Support comment directives

jdenny added a comment. In D79276#2017742 , @jdenny wrote: > Thanks for the review. I've replied to a few comments, and I'll address the > rest later. > > In D79276#2017101 , @jhenderson > wrote: > > > I

[PATCH] D79315: [clangd] Get rid of Inclusion::R

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Headers.cpp:45 Inc.HashOffset = SM.getFileOffset(HashLoc); + // Line numbers are only computed once per SM, it is

[PATCH] D78655: [HIP] Add -fhip-lambda-host-device

yaxunl updated this revision to Diff 261811. yaxunl retitled this revision from "[HIP] Let lambda be host device by default" to "[HIP] Add -fhip-lambda-host-device". yaxunl edited the summary of this revision. yaxunl added a comment. Revised. CHANGES SINCE LAST ACTION

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

martong added inline comments. Comment at: clang/test/Analysis/vla.c:107 + if (x == BIGINDEX) { +size_t s = sizeof(int[x][x][x][x]); // expected-warning{{Declared variable-length array (VLA) has too large size}} +return s; I think we could make the

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 261837. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. Rebased patch to include latest changes in trunk. Removed that it depended on https://reviews.llvm.org/D73290 in the summary, as that patch has been landed. Repository: rG

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

balazske added a comment. Question: Is there a way to check for overflow in the symbolic domain (that is the `ArrSize` value)? Or get the maximal possible value of a `SVal` if it is constrained? (The `ArrSize` that is a multiplication of every dimension size can not be checked simply for too

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. Herald added a reviewer: DavidTruby. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342

[PATCH] D79302: [clangd] Propogate context in LSPServer tests

kadircet abandoned this revision. kadircet added a comment. as discussed offline there is no real use case for this now and it is unclear whether there will be. dropping it, until we've got a use case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79326: [clang-format] ensure dump_format_style.py works with Python3 correctly

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, mitchell-stellar, sammccall, owenpan. MyDeveloperDay added projects: clang, clang-format. Python2 has been removed from cygwin, this means anyone running the dump_format_style.py in a cygwin shell could pick up

[PATCH] D79325: [clang-format] [PR42164] Add Option to Break before While

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, mitchell-stellar, sammccall. MyDeveloperDay added projects: clang, clang-format. Its currently not possible to recreate the GNU style using the `BreakBeforeBraces: Custom` style due to a lack of missing `BeforeWhile`

[PATCH] D77940: [AArch64] Add NVIDIA Carmel support

This revision was automatically updated to reflect the committed changes. Closed by commit rG0863e94ebd87: [AArch64] Add NVIDIA Carmel support (authored by tambre, committed by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77940/new/

[clang] 7cbb495 - Fix LABEL match for test case for D72841 #pragma float_control

Author: Melanie Blower Date: 2020-05-04T07:27:40-07:00 New Revision: 7cbb495ab452877496df270678f9b0a8d57ab7e7 URL: https://github.com/llvm/llvm-project/commit/7cbb495ab452877496df270678f9b0a8d57ab7e7 DIFF:

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

martong accepted this revision. martong added a comment. > ... This draws a pattern that we should recursively descend down to the top > most base region. I.e. the different check*RegionAlign methods should call > into each other until we reach the top level base region. > The observation

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

CarolineConcatto updated this revision to Diff 261806. CarolineConcatto marked 7 inline comments as done. CarolineConcatto added a comment. Rename the flag and fix reviews comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73951/new/

[PATCH] D75430: [analyzer][NFC] Introduce CXXDeallocatorCall, deploy it in MallocChecker

Szelethus added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75430/new/ https://reviews.llvm.org/D75430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

ASDenysPetrov updated this revision to Diff 261784. ASDenysPetrov added a comment. @NoQ updated the patch. Review, please. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77802/new/ https://reviews.llvm.org/D77802 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp

[clang-tools-extra] 3c2c776 - Fix building with GCC5 after e64f99c51a8e

Author: Hans Wennborg Date: 2020-05-04T11:12:39+02:00 New Revision: 3c2c7760d9eea0236c5c54e8939b3901f4208835 URL: https://github.com/llvm/llvm-project/commit/3c2c7760d9eea0236c5c54e8939b3901f4208835 DIFF: https://github.com/llvm/llvm-project/commit/3c2c7760d9eea0236c5c54e8939b3901f4208835.diff

[PATCH] D78429: [clangd] Metric tracking through Tracer

hans added a comment. For anyone running into the same problem, this broke the build with GCC 5: /work/llvm.monorepo/clang-tools-extra/clangd/ClangdServer.cpp:374:75: error: could not convert ‘(const char*)""’ from ‘const char*’ to ‘llvm::StringLiteral’

[PATCH] D79160: [AST] Preserve the type in RecoveryExprs for broken function calls.

hokein updated this revision to Diff 261762. hokein marked 13 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79160/new/ https://reviews.llvm.org/D79160 Files:

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet updated this revision to Diff 261765. kadircet marked an inline comment as done. kadircet added a comment. - Perform line mapping only for includes found through built-in file. - Drop filename range mapping. - Make use of FileChanged events to track being in built-in file. Repository:

[PATCH] D79160: [AST] Preserve the type in RecoveryExprs for broken function calls.

hokein added inline comments. Comment at: clang/lib/AST/ComputeDependence.cpp:491 + auto D = + toExprDependence(E->getType()->getDependence()) | ExprDependence::Error; for (auto *S : E->subExpressions()) sammccall wrote: > Dropping type-dependence seems

[PATCH] D78740: [clangd] Handle PresumedLocations in IncludeCollector

kadircet marked 5 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:44 +PreLoc.getColumn()); + PreLoc = SM.getPresumedLoc(FilenameRange.getBegin()); + auto

[PATCH] D79087: [SVE][Codegen] Lower legal min & max operations

This revision was automatically updated to reflect the committed changes. Closed by commit rG19f5da9c1d69: [SVE][Codegen] Lower legal min max operations (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D79087?vs=261462=261787#toc Repository: rG LLVM Github

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

ASDenysPetrov marked 4 inline comments as done. ASDenysPetrov added a comment. Thank you for the feedback. I'll update the patch soon. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:261-262 +// remove adjacent ranges +newRanges =

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

yvvan added a comment. @mgehre From your comment it seems that `clang-apply-replacements` handles the YAML wrong and does not make the proper conversion back from "\n\n" to "\n" Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63482/new/

[PATCH] D63482: [clang-tidy] Fix the YAML created for checks like modernize-pass-by-value

mgehre added a comment. Could be - did it handle it correctly for your include case here? And if this is a general yaml string thing, shouldn't the replacement of newlines (for both ways) happen in the yaml parser/writer instead of clang/Tooling? Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D79320: [clang-format [PR45791] BeforeLambdaBody is confused by comment inside lambda

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, sammccall, Wawha, duncan-llvm. MyDeveloperDay added projects: clang, clang-format. https://bugs.llvm.org/show_bug.cgi?id=45791 Lambda with line comment is incorrectly formatted auto k = []() // comment { return;

[clang] 0863e94 - [AArch64] Add NVIDIA Carmel support

Author: Raul Tambre Date: 2020-05-04T13:52:30+01:00 New Revision: 0863e94ebd87f4dea7a457c8441979ec4151fedb URL: https://github.com/llvm/llvm-project/commit/0863e94ebd87f4dea7a457c8441979ec4151fedb DIFF: https://github.com/llvm/llvm-project/commit/0863e94ebd87f4dea7a457c8441979ec4151fedb.diff

Re: [PATCH] D78429: [clangd] Metric tracking through Tracer

thanks Hans! On Mon, May 4, 2020 at 12:38 PM Hans Wennborg via Phabricator < revi...@reviews.llvm.org> wrote: > hans added a comment. > > For anyone running into the same problem, this broke the build with GCC 5: > > /work/llvm.monorepo/clang-tools-extra/clangd/ClangdServer.cpp:374:75: >

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

MyDeveloperDay updated this revision to Diff 261768. MyDeveloperDay added a comment. Remove extraneous cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79201/new/ https://reviews.llvm.org/D79201 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

sepavloff created this revision. sepavloff added reviewers: andrew.w.kaylor, kpn, craig.topper, RKSimon, asb, hfinkel. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, jdoerfert, s.egerton, lenary, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2015214 , @arsenm wrote: > In D78979#2010739 , @Anastasia wrote: > > > In D78979#2010527 , @svenvh wrote: > > > > > In D78979#2007643

[PATCH] D78655: [HIP] Add -fhip-lambda-host-device

yaxunl updated this revision to Diff 261869. yaxunl added a comment. add one more test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78655/new/ https://reviews.llvm.org/D78655 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/Options.td

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:77 + assert(!isEmpty()); + // NOTE: It's a shame that we can't implement 'getMaxValue' without scanning + // the whole tree to get to the last element.

[clang] f01ac8c - A test commit as a new contributor to verify commit access is OK.

Author: Denys Petrov Date: 2020-05-04T21:36:18+03:00 New Revision: f01ac8c6574344e9bc30fdf9aa357a51bb607961 URL: https://github.com/llvm/llvm-project/commit/f01ac8c6574344e9bc30fdf9aa357a51bb607961 DIFF: https://github.com/llvm/llvm-project/commit/f01ac8c6574344e9bc30fdf9aa357a51bb607961.diff

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

hliao created this revision. hliao added reviewers: tra, rjmccall, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. hliao added a comment. That test code just passed compilation on clang trunk if only assembly code is generated, https://godbolt.org/z/XYjRcT. But

[PATCH] D77542: [PowerPC] Treat 'Z' inline asm constraint as a true memory constraint

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77542/new/ https://reviews.llvm.org/D77542

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

rjmccall added a comment. Just minor requests now. Comment at: clang/docs/LanguageExtensions.rst:3177 +Both floating point reassociation and floating point contraction can be +controlled with this pragma. +``#pragma clang fp reassoc`` allows control over the reassociation

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

hliao added a comment. That test code just passed compilation on clang trunk if only assembly code is generated, https://godbolt.org/z/XYjRcT. But NVCC generates errors on all cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79344/new/

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

scanon added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3182 +enabled for the translation unit with the ``-fassociative-math`` flag. +The pragma can take two values: ``on`` and ``off``. + rjmccall wrote: > Do you want to add an example here?

[PATCH] D79210: Let clang print registered targets for --version

This revision was automatically updated to reflect the committed changes. Closed by commit rG66041187c902: Let clang print registered targets for --version (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij updated this revision to Diff 261851. stuij added a comment. I've amended this patch to conform to the general Bfloat -> BFloat convention changes requested in the dependent BFloat IR patch (D78190 ). I also folded in two other downstream patches, which

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. vsavchenko added

[PATCH] D79315: [clangd] Get rid of Inclusion::R

kadircet updated this revision to Diff 261845. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79315/new/ https://reviews.llvm.org/D79315 Files:

[PATCH] D79315: [clangd] Get rid of Inclusion::R

kadircet marked 4 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:610 +auto FileRange = +syntax::FileRange(SM, FileTok->location(), Inc.Written.length()) +.toCharRange(SM); sammccall

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

vsavchenko added a comment. Here is a little proof I've put together (using Z3): https://gist.github.com/SavchenkoValeriy/9ad6ca72e7420fd5612e618187bd4f76 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79336/new/ https://reviews.llvm.org/D79336

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

sdesmalen updated this revision to Diff 261853. sdesmalen added a comment. - Use CreateTempAlloca instead of CreateAlloca - Added checks for alignment to the stores. - Added test with control-flow to check the alloca is added to the entry-block. CHANGES SINCE LAST ACTION

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:340-345 +// TODO #2: We didn't go into the nested expressions before, so it +// might cause us spending much more time doing the inference. +// This can be a problem

[PATCH] D78190: Add Bfloat IR type

stuij added a comment. Hi all. Are you OK for me to commit this change? It was about a week ago since we resolved the last outstanding issues, and in general it looks like our noses have been pointing in the same direction on this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

zhuhan0 updated this revision to Diff 261866. zhuhan0 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79059/new/ https://reviews.llvm.org/D79059 Files: clang/cmake/modules/AddClang.cmake Index:

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78750/new/ https://reviews.llvm.org/D78750 ___ cfe-commits mailing list

[PATCH] D78756: [SveEmitter] Add builtins for svreinterpret

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7880 +return Builder.CreateBitCast(Val, Ty); + } + efriedma wrote: > sdesmalen wrote: > > efriedma wrote: > > > sdesmalen wrote: > > > > efriedma wrote: > > > > > I'm vaguely

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

aaron.ballman added a comment. In D79236#2018190 , @rsandifo-arm wrote: > OK, I'll leave the file as-is in that case. I think it's preferable to commit the file in its updated state so that the public documentation is kept up to date rather than being

[PATCH] D79121: Add nomerge function attribute to clang

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2755-2756 +def warn_nomerge_attribute_ignored_in_stmt: Warning< + "%0 attribute is ignored because there exists no call expression inside the " + "statement">; def

[PATCH] D78655: [HIP] Add -fhip-lambda-host-device

pfultz2 added a comment. Is it possible to add a test like this? kernel<<<1,1>>>([=](){ auto f = [&]{ hd(); }; f(); }); That should not have a compiler error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78655/new/ https://reviews.llvm.org/D78655

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

NoQ added inline comments. Comment at: clang/test/Analysis/constant-folding.c:127-128 + if (a > 10) { +clang_analyzer_eval((a & 1) <= 1); // expected-warning{{FALSE}} +clang_analyzer_eval((a & 1) > 1); // expected-warning{{FALSE}} + } How can both of

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:385 + + RangeSet VisitAndOperator(RangeSet LHS, RangeSet RHS, QualType T) { +// TODO: generalize for the ranged RHS. I always get surprised when I read

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

martong marked 7 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:234-236 + // The signature of a function we want to describe with a summary. This is a + // concessive signature, meaning

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

martong updated this revision to Diff 261855. martong marked 2 inline comments as done. martong added a comment. - Better encapsulate the data in a 'Summary' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77658/new/ https://reviews.llvm.org/D77658

[PATCH] D79337: Silence warnings when compiling x86 with latest MSVC

aganea created this revision. aganea added reviewers: bkramer, john.brawn, vsk. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. When using Visual Studio 2019 16.5.4, and targetting 32-bit, before this patch we were seeing: [1378/3007]

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

sdesmalen marked 4 inline comments as done. sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8054 + +Value *Alloca = Builder.CreateAlloca(EltTy, Builder.getInt32(NumOpnds)); +for (unsigned I = 0; I < NumOpnds; ++I) efriedma

[PATCH] D79274: Fix template class debug info for Visual Studio visualizers

aprantl added a comment. This should be testable with a -emit-llvm test FileChecking the generated IR? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79274/new/ https://reviews.llvm.org/D79274 ___ cfe-commits mailing list

[clang] 6604118 - Let clang print registered targets for --version

Author: Yaxun (Sam) Liu Date: 2020-05-04T12:26:18-04:00 New Revision: 66041187c9028f730c41597fe5ea6a63fda1ccad URL: https://github.com/llvm/llvm-project/commit/66041187c9028f730c41597fe5ea6a63fda1ccad DIFF:

[clang] cb78376 - Test commit. Modified comment to add a period at the end.

Author: Zarko Date: 2020-05-04T13:06:21-04:00 New Revision: cb7837643389d5f314cc27cbcb7863daeee8ec84 URL: https://github.com/llvm/llvm-project/commit/cb7837643389d5f314cc27cbcb7863daeee8ec84 DIFF: https://github.com/llvm/llvm-project/commit/cb7837643389d5f314cc27cbcb7863daeee8ec84.diff LOG:

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 261875. mibintc retitled this revision from "Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations" to "Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative

[PATCH] D79343: [libc++][test] Adjust move_iterator tests to allow C++20

CaseyCarter created this revision. CaseyCarter added reviewers: ldionne, EricWF, mclow.lists. Herald added subscribers: libcxx-commits, broadwaylamb, dexonsmith. Herald added a project: libc++. Herald added a reviewer: libc++. These tests fail due to a couple of changes to `move_iterator` for

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram added a comment. @rnk Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78655: [HIP] Add -fhip-lambda-host-device

tra accepted this revision. tra added a comment. LGTM. Thank you for adding the checks for capturing lambdas and for putting this behind the flag. I've asked @rsmith to chime in in case there's anything else about the lambdas we need to deal with. Please wait a day or two before landing the

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

mibintc marked 4 inline comments as done. mibintc added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:186 +FPM_Fast }; rjmccall wrote: > I'm not sure I think this fusion was an improvement; the net effect was to > remove a few

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

russellmcc added a comment. Still waiting for feedback on this change! We've been happily using this patch at my company for some time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54881/new/ https://reviews.llvm.org/D54881 ___

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

rsandifo-arm abandoned this revision. rsandifo-arm added a comment. OK, I'll leave the file as-is in that case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79236/new/ https://reviews.llvm.org/D79236

[clang] 54fa46a - [SveEmitter] Add builtins for Int & FP reductions

Author: Sander de Smalen Date: 2020-05-04T19:50:16+01:00 New Revision: 54fa46aa0a82bd281d0ba31fad69a227de4a622c URL: https://github.com/llvm/llvm-project/commit/54fa46aa0a82bd281d0ba31fad69a227de4a622c DIFF:

[PATCH] D79320: [clang-format [PR45791] BeforeLambdaBody is confused by comment inside lambda

Wawha accepted this revision. Wawha added a comment. This revision is now accepted and ready to land. Thanks for the patch ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79320/new/ https://reviews.llvm.org/D79320

[clang] 6b90a68 - [SveEmitter] Add builtins for svdupq and svdupq_lane

Author: Sander de Smalen Date: 2020-05-04T20:38:47+01:00 New Revision: 6b90a6887d25e3375bb916a3ed09f7ccec819d0c URL: https://github.com/llvm/llvm-project/commit/6b90a6887d25e3375bb916a3ed09f7ccec819d0c DIFF:

[PATCH] D79344: [cuda] Start diagnosing variables with bad target.

hliao added a comment. In D79344#2018561 , @tra wrote: > This has a good chance of breaking existing code. It would be great to add an > escape hatch option to revert to the old behavior if we run into problems. > The change is relatively simple, so

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn updated this revision to Diff 261911. fhahn marked 9 inline comments as done. fhahn added a comment. Address comments, thanks: - Use MatrixType as base class for ConstantMatrixType and DependentSizedMatrixType. - Handle both ConstantMatrixType and DependentSizedMatrixType arguments in

[PATCH] D78750: [SveEmitter] Add builtins for svdupq and svdupq_lane

This revision was automatically updated to reflect the committed changes. sdesmalen marked an inline comment as done. Closed by commit rG6b90a6887d25: [SveEmitter] Add builtins for svdupq and svdupq_lane (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4938 +if (EIT->getNumBits() > 128) + return getNaturalAlignIndirect(Ty, /*ByVal=*/true); + erichkeane wrote: > rjmccall wrote: > > Does this need to consider the

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

erichkeane updated this revision to Diff 261820. erichkeane marked 5 inline comments as done. Herald added a reviewer: jdoerfert. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79118/new/ https://reviews.llvm.org/D79118 Files: clang/lib/Basic/Targets/AArch64.h

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/include/clang/Basic/TypeNodes.td:73 def ExtVectorType : TypeNode; +def MatrixType : TypeNode; def FunctionType : TypeNode; rjmccall wrote: > I think some parts of your life

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

rjmccall added a comment. In D79236#2018661 , @rsmith wrote: > In D79236#2015982 , @rjmccall wrote: > > > There's no good reason for this file to exist; documenting the warning > > options is useful, but the file

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

vsavchenko marked 3 inline comments as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:77 + assert(!isEmpty()); + // NOTE: It's a shame that we can't implement 'getMaxValue' without scanning + // the whole

  1   2   >