[PATCH] D70603: Change while to do-while

MaskRay added a comment. In D70603#2114361 , @pi1024e wrote: > @MaskRay it's been months yet this hasn't landed yet. Why? It is usually assumed that the patch author pushes this commit. In this case, it seems that you don't have commit access. You'll ne

[clang] 7f7f856 - Add `BoolLiteralExpression` to SyntaxTree

Author: Eduardo Caldas Date: 2020-06-25T15:37:53Z New Revision: 7f7f8564808b51aa62744edf75c07c0df102056a URL: https://github.com/llvm/llvm-project/commit/7f7f8564808b51aa62744edf75c07c0df102056a DIFF: https://github.com/llvm/llvm-project/commit/7f7f8564808b51aa62744edf75c07c0df102056a.diff LOG

[clang] 15edd7a - [FPEnv] PowerPC-specific builtin constrained FP enablement

Author: Andrew Wock Date: 2020-06-25T11:42:58-04:00 New Revision: 15edd7aaa7142e5db2a6cf9b81e4514967431824 URL: https://github.com/llvm/llvm-project/commit/15edd7aaa7142e5db2a6cf9b81e4514967431824 DIFF: https://github.com/llvm/llvm-project/commit/15edd7aaa7142e5db2a6cf9b81e4514967431824.diff L

[clang] 1650178 - [Clang] Add support for -Wno-inline-namespace-reopened-noninline

Author: Elvina Yakubova Date: 2020-06-25T18:48:50+03:00 New Revision: 16501782c8d849bc1812d527dc8466574700663d URL: https://github.com/llvm/llvm-project/commit/16501782c8d849bc1812d527dc8466574700663d DIFF: https://github.com/llvm/llvm-project/commit/16501782c8d849bc1812d527dc8466574700663d.dif

[PATCH] D82386: [clangd] Config: Fragments and parsing from YAML

kadircet marked 5 inline comments as done. kadircet added a comment. LGTM with couple of nits. Regarding clang-format, I was mostly confused by `template class Located {` being on a single line, but apparently that's the style :D Comment at: clang-tools-extra/clangd/ConfigFr

[PATCH] D70603: Change while to do-while

pi1024e added a comment. How do I do that, if I may ask? Sorry for the rude tone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___ cfe-commits mailing list c

[PATCH] D82535: [CodeComplete] Add code completion for using alias.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Will land this one too. In the meantime feel free to apply for commit access, as explained in https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access (IIRC, you

[PATCH] D82429: [sve][acle] Add some C intrinsics for brain float types.

c-rhodes accepted this revision. c-rhodes added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/aarch64-sve2-intrinsics/acle_sve2_tbl2-bfloat.c:7 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_SVE2 -D__ARM_FEATURE_BF16_SC

[PATCH] D82568: [clang][CrossTU] Invalidate parent map after get cross TU definition.

balazske created this revision. Herald added subscribers: cfe-commits, martong, gamesh411, Szelethus, dkrupp. Herald added a project: clang. balazske added reviewers: gamesh411, martong. Herald added a subscriber: rnkovacs. Parent map of ASTContext is built once. If this happens and later the TU i

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

laytonio added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:838 +if (isValidTRECandidate(CI)) + HasValidCandidates = true; + } avl wrote: > laytonio wrote: > > Is there any reason to find and validate

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap updated this revision to Diff 273393. Conanap added a comment. Addressed Amy's comments regarding documentation of the changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://reviews.llvm.org/D82502 Files: clang/lib/Hea

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

fpetrogalli updated this revision to Diff 273399. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. @david-arm, at the end I decided to add the `ASM-NOT` test, it was easy and came for free. Also, I have moved the IR tests in the file with all other bitcasts, using a fu

[PATCH] D82020: PowerPC-specific builtin constrained FP enablement

This revision was automatically updated to reflect the committed changes. Closed by commit rG15edd7aaa714: [FPEnv] PowerPC-specific builtin constrained FP enablement (authored by ajwock, committed by kpn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D81825: [Clang] Add support for -Wno-inline-namespace-reopened-noninline

This revision was automatically updated to reflect the committed changes. Closed by commit rG16501782c8d8: [Clang] Add support for -Wno-inline-namespace-reopened-noninline (authored by Elvina, committed by andreybokhanko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f7f8564808b: Add `BoolLiteralExpression` to SyntaxTree (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82310/new/ https://reviews.l

[PATCH] D77062: [analyzer] Improved zero assumption in CStringChecke::assumeZero

ASDenysPetrov added a comment. @NoQ gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77062/new/ https://reviews.llvm.org/D77062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[libunwind] c55051e - [libunwind] Allow specifying custom Lit config files

Author: Louis Dionne Date: 2020-06-25T12:15:15-04:00 New Revision: c55051eea5d3cd57abfd9727f519b670517704d9 URL: https://github.com/llvm/llvm-project/commit/c55051eea5d3cd57abfd9727f519b670517704d9 DIFF: https://github.com/llvm/llvm-project/commit/c55051eea5d3cd57abfd9727f519b670517704d9.diff

[clang] 772f482 - Change while to do-while

Author: Seija Kijin Date: 2020-06-25T09:30:30-07:00 New Revision: 772f4826465de80d8c7f11b2fb35b92f9fe58f45 URL: https://github.com/llvm/llvm-project/commit/772f4826465de80d8c7f11b2fb35b92f9fe58f45 DIFF: https://github.com/llvm/llvm-project/commit/772f4826465de80d8c7f11b2fb35b92f9fe58f45.diff L

[clang] 7200fa3 - [sve][acle] Add some C intrinsics for brain float types.

Author: Francesco Petrogalli Date: 2020-06-25T16:31:01Z New Revision: 7200fa38a912d0d9ec407ccdd7c4d924979da160 URL: https://github.com/llvm/llvm-project/commit/7200fa38a912d0d9ec407ccdd7c4d924979da160 DIFF: https://github.com/llvm/llvm-project/commit/7200fa38a912d0d9ec407ccdd7c4d924979da160.dif

[PATCH] D81825: [Clang] Add support for -Wno-inline-namespace-reopened-noninline

andreybokhanko added a comment. Fix committed in https://reviews.llvm.org/rG16501782c8d849bc1812d527dc8466574700663d. Thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81825/new/ https://reviews.llvm.org/D81825

[PATCH] D82391: [AArch64][SVE] Add bfloat16 support to svext intrinsic

sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:1479 + let Predicates = [IsLE, HasBF16] in { +def : Pat<(nxv16i8 (bitconvert (nxv8bf16 ZPR:$src))), (nxv16i8 ZPR:$src)>; + These patterns are missing tests in llvm/te

[PATCH] D82575: [OpenMP] Additional OpenMP test without version string after upgrading to 5.0

saiislam created this revision. saiislam added reviewers: ABataev, jdoerfert, gregrodgers. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. saiislam added a commit: rG2bfce22a924a: [OpenMP] Upgrade default version of OpenMP to 5.0. saiislam removed

[PATCH] D70603: Change while to do-while

pi1024e added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests

amyk created this revision. amyk added reviewers: power-llvm-team, PowerPC, Conanap, saghir, nemanjai, lei. amyk added projects: LLVM, clang, PowerPC. Herald added a subscriber: shchenz. This patch aims to add the following function prototypes: vector signed int vec_mod (vector signed int a, ve

[PATCH] D82429: [sve][acle] Add some C intrinsics for brain float types.

fpetrogalli marked 2 inline comments as done. fpetrogalli added inline comments. Comment at: clang/test/CodeGen/aarch64-sve2-intrinsics/acle_sve2_tbl2-bfloat.c:7 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_SVE2 -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -triple aarch64-n

[PATCH] D82429: [sve][acle] Add some C intrinsics for brain float types.

fpetrogalli updated this revision to Diff 273411. fpetrogalli added a comment. Removed the run lines that didn't work, as described in https://reviews.llvm.org/D82429#inline-759371 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82429/new/ https://r

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D82578: [AArch64][SVE2] Guard while intrinsics on scalar bfloat feature macro

c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, fpetrogalli, kmclaughlin. Herald added subscribers: danielkiss, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a reviewer: efriedma. Herald added a project: clang. `svwhilerw_bf16` and `svwhilewr_bf16` i

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

hliao added a comment. ping for code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81938/new/ https://reviews.llvm.org/D81938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D82429: [sve][acle] Add some C intrinsics for brain float types.

This revision was automatically updated to reflect the committed changes. fpetrogalli marked an inline comment as done. Closed by commit rG7200fa38a912: [sve][acle] Add some C intrinsics for brain float types. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] 37c1bf2 - [analyzer] Enable constructor support in evalCall event.

Author: Nithin Vadukkumchery Rajendrakumar Date: 2020-06-25T09:47:13-07:00 New Revision: 37c1bf21d1da85c164638efc32e8c7cfbf713ac5 URL: https://github.com/llvm/llvm-project/commit/37c1bf21d1da85c164638efc32e8c7cfbf713ac5 DIFF: https://github.com/llvm/llvm-project/commit/37c1bf21d1da85c164638efc3

[clang] f79a66b - Ensure that default value for -triple is correctly normalizedvalues

Author: Daniel Grumberg Date: 2020-06-25T17:49:59+01:00 New Revision: f79a66ba69628db471d559f0f182f476bf49ac90 URL: https://github.com/llvm/llvm-project/commit/f79a66ba69628db471d559f0f182f476bf49ac90 DIFF: https://github.com/llvm/llvm-project/commit/f79a66ba69628db471d559f0f182f476bf49ac90.dif

[clang] 408efff - [Clang][SourceManager] optimize getFileIDLocal()

Author: Nick Desaulniers Date: 2020-06-25T09:59:41-07:00 New Revision: 408efffbe4a52bae05f1677a47eb3ccfd5cdc1d3 URL: https://github.com/llvm/llvm-project/commit/408efffbe4a52bae05f1677a47eb3ccfd5cdc1d3 DIFF: https://github.com/llvm/llvm-project/commit/408efffbe4a52bae05f1677a47eb3ccfd5cdc1d3.di

[clang] 221d7bb - Add `CharLiteral` to SyntaxTree

Author: Eduardo Caldas Date: 2020-06-25T17:05:08Z New Revision: 221d7bbe49cceb0e408f0f46d9f8371e6c9fee2c URL: https://github.com/llvm/llvm-project/commit/221d7bbe49cceb0e408f0f46d9f8371e6c9fee2c DIFF: https://github.com/llvm/llvm-project/commit/221d7bbe49cceb0e408f0f46d9f8371e6c9fee2c.diff LOG

[clang] 466e8b7 - Add StringLiteral to SyntaxTree

Author: Eduardo Caldas Date: 2020-06-25T17:05:08Z New Revision: 466e8b7ea6e162d48cac42ccda210bdeb11080e3 URL: https://github.com/llvm/llvm-project/commit/466e8b7ea6e162d48cac42ccda210bdeb11080e3 DIFF: https://github.com/llvm/llvm-project/commit/466e8b7ea6e162d48cac42ccda210bdeb11080e3.diff LOG

[clang] 7b404b6 - Add `FloatingLiteral` to SyntaxTree

Author: Eduardo Caldas Date: 2020-06-25T17:05:08Z New Revision: 7b404b6d003181e990f53d27866ee98d5151c4f3 URL: https://github.com/llvm/llvm-project/commit/7b404b6d003181e990f53d27866ee98d5151c4f3 DIFF: https://github.com/llvm/llvm-project/commit/7b404b6d003181e990f53d27866ee98d5151c4f3.diff LOG

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

efriedma added inline comments. Comment at: compiler-rt/lib/builtins/CMakeLists.txt:142 powisf2.c powitf2.c subdf3.c Missed powitf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81282/new/ https://reviews

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7849-7851 +if (&Component != &*Components.begin()) { + ElementType = ElementType->getPointeeOrArrayElementType(); +} No need for braces here ==

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap updated this revision to Diff 273421. Conanap marked 9 inline comments as done. Conanap added a comment. Fixed return signature for the open coded functions in altivec.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://revie

[PATCH] D82506: [HIP] Add missing options for lto

yaxunl updated this revision to Diff 273424. yaxunl marked an inline comment as done. yaxunl added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. Fix issue about -mattr. Also use generic LTO option translation and use -plugin-opt. CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D82579: [NFC] Extract unifyTargetFeatures

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl added a child revision: D82506: [HIP] Add missing options for lto. extract unifyTargetFeatures to be used by lld. https://reviews.llvm.org/D82579 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChains/Commo

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

arsenm added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:66 +// COMMON-LABEL: define amdgpu_kernel void @_Z7kernel41S(%struct.S.coerce %s.coerce) +// OPT: %0 = extractvalue %struct.S.coerce %s.coerce, 0 +// OPT: %1 = extractvalue %struct

[PATCH] D82497: [Clang][SourceManager] optimize getFileIDLocal()

This revision was automatically updated to reflect the committed changes. Closed by commit rG408efffbe4a5: [Clang][SourceManager] optimize getFileIDLocal() (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82497/new/ https

[PATCH] D82506: [HIP] Add missing options for lto

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:76 +MAttrString.append(Args.MakeArgString(OneFeature)); +if (OneFeature != Features.back()) + MAttrString.append(","); tra wrote: >

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rG221d7bbe49cc: Add `CharLiteral` to SyntaxTree (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D82312?vs=273343&id=273436#toc Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D82318: Add `FloatingLiteral` to SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b404b6d0031: Add `FloatingLiteral` to SyntaxTree (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D82318?vs=273347&id=273437#toc Repository: rG LLVM Github Monorepo CHANG

[PATCH] D82256: [analyzer] Enable constructor support in evalCall event

This revision was automatically updated to reflect the committed changes. Closed by commit rG37c1bf21d1da: [analyzer] Enable constructor support in evalCall event. (authored by vrnithinkumar, committed by Artem Dergachev ). Changed prior to commit: https://reviews.llvm.or

[PATCH] D82360: Add StringLiteral to SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rG466e8b7ea6e1: Add StringLiteral to SyntaxTree (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D82360?vs=273346&id=273438#toc Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

guiand marked an inline comment as done. guiand added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2082 + const Type *RetTyPtr = RetTy.getTypePtr(); + if (!RetTy->isVoidType() && !RetTyPtr->isRecordType() && + RetAI.getKind() != ABIArgInfo::Indirect) { ---

[PATCH] D82415: [Coroutines] Special handle __builtin_coro_resume for final_suspend nothrow check

lewissbaker accepted this revision. lewissbaker added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/SemaCoroutine.cpp:621 +// returns a handle. In that case, even __builtin_coro_resume is not +// declared as noexcept

[PATCH] D82506: [HIP] Add missing options for lto

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82506/new/ https://reviews.llvm.org/D82506 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl marked an inline comment as done. avl added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:838 +if (isValidTRECandidate(CI)) + HasValidCandidates = true; + } laytonio wrote: > avl wrote: > > laytonio

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73186/new/ https://reviews.llvm.org/D73186 _

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

ctetreau created this revision. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. ctetreau added a child revision: D78127: [SVE] Mark VectorType::getNumElements() deprecated. Repository: rG LLVM Github Monorepo h

[PATCH] D82498: [SourceManager] don't check invalid param of getLocalSLocEntry()

nickdesaulniers updated this revision to Diff 273449. nickdesaulniers added a comment. - drop `Invalid` param from getLocalSLocEntry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82498/new/ https://reviews.llvm.org/D82498 Files: clang/include/cl

[PATCH] D82579: [NFC] Extract unifyTargetFeatures

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:93 +StringRef Name = Features[I]; +assert(Name[0] == '-' || Name[0] == '+'); +LastOpt[Name.drop_front(1)] = I; I don't think assert should be used for something that may

[clang] 3661595 - [Coroutines] Special handle __builtin_coro_resume for final_suspend nothrow check

Author: Xun Li Date: 2020-06-25T10:49:50-07:00 New Revision: 366159566df3a980d3e34f3ec9609e77cdb4df8b URL: https://github.com/llvm/llvm-project/commit/366159566df3a980d3e34f3ec9609e77cdb4df8b DIFF: https://github.com/llvm/llvm-project/commit/366159566df3a980d3e34f3ec9609e77cdb4df8b.diff LOG: [

[PATCH] D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, dcoughlin, vsavchenko, martong, balazske, baloghadamsoftware. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.s

[clang] c61ef1f - [Sema][CodeComplete][ObjC] Don't split the first selector fragment

Author: David Goldman Date: 2020-06-25T13:58:27-04:00 New Revision: c61ef1f25c7fe774e68d20beb956a3b12a353b95 URL: https://github.com/llvm/llvm-project/commit/c61ef1f25c7fe774e68d20beb956a3b12a353b95 DIFF: https://github.com/llvm/llvm-project/commit/c61ef1f25c7fe774e68d20beb956a3b12a353b95.diff

[PATCH] D82332: [Coroutines] Handle dependent promise types for final_suspend non-throw check

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82332/new/ https://reviews.llvm.org/D82332 ___

[PATCH] D82586: [HIP] Improve check patterns to avoid test failures in case string "opt", etc. happens to be in the command path.

yamauchi created this revision. yamauchi added reviewers: arsenm, yaxunl. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Similarly to D82046 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82586 Files: clang/test

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

atrosinenko updated this revision to Diff 273452. atrosinenko added a comment. Move missed `powitf2.c` source as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81282/new/ https://reviews.llvm.org/D81282 Files: compiler-rt/lib/builtins/CMake

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

atrosinenko marked an inline comment as done. atrosinenko added inline comments. Comment at: compiler-rt/lib/builtins/CMakeLists.txt:142 powisf2.c powitf2.c subdf3.c efriedma wrote: > Missed powitf? Fixed, thank you. Repository: rG LLVM Github Monore

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl updated this revision to Diff 273457. avl added a comment. removed early check for TRE candidates from canTRE(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82085/new/ https://reviews.llvm.org/D82085 Files: llvm/lib/Transforms/Scalar/TailR

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We need to add a test for the symbols added target notification. See my previous comment on stripping a.out to a.out.stripped and then using "a.out.stripped" as the main executab

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

gribozavr updated this revision to Diff 273464. gribozavr added a comment. Added calls to default implementations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82485/new/ https://reviews.llvm.org/D82485 Files: clang/unittests/Tooling/CMakeLists

[PATCH] D82306: [Sema][CodeComplete][ObjC] Don't split the first selector fragment

This revision was automatically updated to reflect the committed changes. Closed by commit rGc61ef1f25c7f: [Sema][CodeComplete][ObjC] Don't split the first selector fragment (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82306/

[PATCH] D82415: [Coroutines] Special handle __builtin_coro_resume for final_suspend nothrow check

This revision was automatically updated to reflect the committed changes. lxfind marked an inline comment as done. Closed by commit rG366159566df3: [Coroutines] Special handle __builtin_coro_resume for final_suspend nothrow… (authored by lxfind). Changed prior to commit: https://reviews.llvm.or

[clang] 636d31a - [X86] Don't imply -mprfchw when -m3dnow is specified. Enable prefetchw in the backend with 3dnow feature.

Author: Craig Topper Date: 2020-06-25T11:25:35-07:00 New Revision: 636d31a5c341ff2ca5eefd6075ff059eb60b5a80 URL: https://github.com/llvm/llvm-project/commit/636d31a5c341ff2ca5eefd6075ff059eb60b5a80 DIFF: https://github.com/llvm/llvm-project/commit/636d31a5c341ff2ca5eefd6075ff059eb60b5a80.diff

[clang] c25acec - [Coroutines] Handle dependent promise types for final_suspend non-throw check

Author: Xun Li Date: 2020-06-25T11:27:27-07:00 New Revision: c25acec84594ca15748553341969f8e579290e27 URL: https://github.com/llvm/llvm-project/commit/c25acec84594ca15748553341969f8e579290e27 DIFF: https://github.com/llvm/llvm-project/commit/c25acec84594ca15748553341969f8e579290e27.diff LOG: [

[clang] 01c18f9 - Revert "[X86] Don't imply -mprfchw when -m3dnow is specified. Enable prefetchw in the backend with 3dnow feature."

Author: Craig Topper Date: 2020-06-25T11:43:02-07:00 New Revision: 01c18f9199ace4cb15a7c82a4163c9ef84972342 URL: https://github.com/llvm/llvm-project/commit/01c18f9199ace4cb15a7c82a4163c9ef84972342 DIFF: https://github.com/llvm/llvm-project/commit/01c18f9199ace4cb15a7c82a4163c9ef84972342.diff

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand marked an inline comment as done. guiand added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2082 + const Type *RetTyPtr = RetTy.getTypePtr(); + if (!RetTy->isVoidType() && !RetTyPtr->isRecordType() && + RetAI.getKind() != ABIArgInfo::Indirect) { ---

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand updated this revision to Diff 273456. guiand retitled this revision from "Introduce frozen attribute at call sites for stricter poison analysis" to "Introduce noundef attribute at call sites for stricter poison analysis". guiand edited the summary of this revision. guiand added a comment.

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg added a comment. Here is a makefile that does stripping: llvm-project/lldb/test/API/lang/objc/objc-ivar-stripped/Makefile Then when creating the target, use a.out.stripped: exe = self.getBuildArtifact("a.out.stripped") symbols = exe = self.getBuildArtifact("a.out") target = self.

[PATCH] D82579: [NFC] Extract unifyTargetFeatures

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:93 +StringRef Name = Features[I]; +assert(Name[0] == '-' || Name[0] == '+'); +LastOpt[Name.drop_front(1)] = I; tra wrote: > I

[PATCH] D82332: [Coroutines] Handle dependent promise types for final_suspend non-throw check

This revision was automatically updated to reflect the committed changes. Closed by commit rGc25acec84594: [Coroutines] Handle dependent promise types for final_suspend non-throw check (authored by lxfind). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D82579: [NFC] Extract unifyTargetFeatures

yaxunl updated this revision to Diff 273473. yaxunl marked 2 inline comments as done. yaxunl added a comment. return the unified features. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82579/new/ https://reviews.llvm.org/D82579 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib

[clang] 9da93f5 - [HIP] Improve check patterns to avoid test failures in case string "opt", etc. happens to be in the command path.

Author: Hiroshi Yamauchi Date: 2020-06-25T12:18:43-07:00 New Revision: 9da93f590414ae3b7be20061d8a97695b263482e URL: https://github.com/llvm/llvm-project/commit/9da93f590414ae3b7be20061d8a97695b263482e DIFF: https://github.com/llvm/llvm-project/commit/9da93f590414ae3b7be20061d8a97695b263482e.di

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81282/new/ https://reviews.llvm.org/D81282 ___

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

hliao updated this revision to Diff 273477. hliao added a comment. Revise Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81938/new/ https://reviews.llvm.org/D81938 Files: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu llvm/lib/Transfo

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/tools/driver/driver.cpp:515 + + llvm::dbgs() << llvm::getBugReportMsg(); } MaskRay wrote: > Why ` llvm::dbgs() << llvm::getBugReportMsg();` when -gen-reprod

[PATCH] D82579: [NFC] Extract unifyTargetFeatures

tra marked an inline comment as done. tra added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:93 +StringRef Name = Features[I]; +assert(Name[0] == '-' || Name[0] == '+'); +LastOpt[Name.drop_front(1)] = I; yaxunl wrote: > tra

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

jasonliu accepted this revision. jasonliu added a comment. LGTM. I have no further comments on this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79719/new/ https://reviews.llvm.org/D79719 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D82586: [HIP] Improve check patterns to avoid test failures in case string "opt", etc. happens to be in the command path.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9da93f590414: [HIP] Improve check patterns to avoid test failures in case string "opt", etc. (authored by yamauchi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] 6673d69 - [X86] Don't imply -mprfchw when -m3dnow is specified. Enable prefetchw in the backend with 3dnow feature.

Author: Craig Topper Date: 2020-06-25T12:46:52-07:00 New Revision: 6673d69226d86f4906dca4b627d6e0582486d072 URL: https://github.com/llvm/llvm-project/commit/6673d69226d86f4906dca4b627d6e0582486d072 DIFF: https://github.com/llvm/llvm-project/commit/6673d69226d86f4906dca4b627d6e0582486d072.diff

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

MaskRay added inline comments. Comment at: clang/tools/driver/driver.cpp:515 + + llvm::dbgs() << llvm::getBugReportMsg(); } john.brawn wrote: > MaskRay wrote: > > Why ` llvm::dbgs() << llvm::getBugReportMsg();` when -gen-reproducer is > > specified? Th

[PATCH] D82592: [libTooling] Rename overloaded `range` range selector.

ymandel created this revision. ymandel added a reviewer: tdl-g. Herald added a project: clang. tdl-g accepted this revision. This revision is now accepted and ready to land. Renames the overloaded `RangeSelector` combinator `range` to the more descriptive `enclose` and `encloseNodes`. The old over

[PATCH] D82563: [Sema][NFC] Remove Redundant Condition

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82563/new/ https://reviews.llvm.org/D82563

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 273484. cchen added a comment. Fix coding style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/CGOpen

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8781 MappableExprsHandler::MapFlagsArrayTy &MapTypes, - CGOpenMPRuntime::TargetDataInfo &Info) { + MappableExprsHandler::MapDimArrayTy &D

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

This revision was automatically updated to reflect the committed changes. Closed by commit rGa931ec7ca0ee: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list (authored by atrosinenko, committed by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8781 MappableExprsHandler::MapFlagsArrayTy &MapTypes, - CGOpenMPRuntime::TargetDataInfo &Info) { +

[PATCH] D82579: [NFC] Extract unifyTargetFeatures

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:93 +StringRef Name = Features[I]; +assert(Name[0] == '-' || Name[0] == '+'); +LastOpt[Name.drop_front(1)] = I; tra wrote: > y

[PATCH] D82345: [sve][acle] Implement some of the C intrinsics for brain float.

fpetrogalli updated this revision to Diff 273498. fpetrogalli marked 5 inline comments as done. fpetrogalli added a comment. This patch needed some love... @c-rhodes, I have addressed your feedback, thank you. I have also predicated all the instruction selection pattern for `-mattr=+bf16`, and

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16624 + if (IsPointer && !AllowAnotherPtr) +SemaRef.Diag(ELoc, diag::err_omp_section_length_undefined) << true; + else ABataev wrote:

[clang-tools-extra] e9fb150 - [clangd] Config: Fragments and parsing from YAML

Author: Sam McCall Date: 2020-06-25T22:55:45+02:00 New Revision: e9fb1506b83d001082dc535af12acf45050a527c URL: https://github.com/llvm/llvm-project/commit/e9fb1506b83d001082dc535af12acf45050a527c DIFF: https://github.com/llvm/llvm-project/commit/e9fb1506b83d001082dc535af12acf45050a527c.diff LO

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel updated this revision to Diff 273503. aardappel added a comment. - Fixed ISEL for FrameIndex - Fixed 64-bit conditions in branches (thanks @aheejin!) - Made the FrameIndex generation code in WebAssemblyRegisterInfo work. - Made userstack.ll and stack-alignment.ll pass in wasm64. - Code r

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16624 + if (IsPointer && !AllowAnotherPtr) +SemaRef.Diag(ELoc, diag::err_omp_section_length_undefined) << true; + else cchen wrote: > ABataev wrote: > > Better to use integ

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

arsenm added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:238-239 +return false; + // Check it's really safe to treat that pair of `ptrtoint`/`inttoptr` is a + // no-op cast. Besides checking both of them are no-op casts, as the + // reint

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, vsavchenko, martong, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, balo

<    1   2   3   >