[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implement N2418 for C2x. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119221 Files:

[PATCH] D119224: [clang][tests] Add a testcase for C++ DR2406

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. DR2406 is in "unknown" state according to https://clang.llvm.org/cxx_dr_status.html. The described defects do

[PATCH] D119225: [clang] Add core papers adopted at the february plenary.

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 2 papers are added to the status page, one targeting C++23, the other added to the batch of C++20 concept papers. Repository: rG LLVM Github

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StandardLibrary.h:56 +// C++ and C Standard Library symbols are considered distinct: e.g. std::printf +// and ::printf are not treated as the same symbol. The callers have to act +// accordingly

[PATCH] D119218: [clang-format] Honour "// clang-format off" when using QualifierOrder.

HazardyKnusperkeks added a comment. Let's me wonder if it was respected in the block separator... Comment at: clang/unittests/Format/QualifierFixerTest.cpp:879 + "// clang-format on\n" + "int const inline static a = 0;\n", + Style);

[clang] c00db97 - [Clang] Add elementwise saturated add/sub builtins

Author: Simon Pilgrim Date: 2022-02-08T11:22:01Z New Revision: c00db971597557e952901eac4be131157d1d5eb9 URL: https://github.com/llvm/llvm-project/commit/c00db971597557e952901eac4be131157d1d5eb9 DIFF: https://github.com/llvm/llvm-project/commit/c00db971597557e952901eac4be131157d1d5eb9.diff

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGc00db9715975: [Clang] Add elementwise saturated add/sub builtins (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D117898?vs=406264=406756#toc Repository: rG LLVM Github

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

kiranchandramohan accepted this revision. kiranchandramohan added a comment. LGTM. Comment at: flang/lib/Frontend/FrontendActions.cpp:419 + + // ... otherwise, print to a file. + auto os{ci.CreateDefaultOutputFile( awarzynski wrote: > kiranchandramohan

[clang] 508b3f4 - Attempt to fix sphinx 'Malformed table' warning.

Author: Simon Pilgrim Date: 2022-02-08T11:48:37Z New Revision: 508b3f437dae99518d8e325a7a32d3d80613462b URL: https://github.com/llvm/llvm-project/commit/508b3f437dae99518d8e325a7a32d3d80613462b DIFF: https://github.com/llvm/llvm-project/commit/508b3f437dae99518d8e325a7a32d3d80613462b.diff

[PATCH] D119225: [clang] Add core papers adopted at the february plenary.

aaron.ballman added inline comments. Comment at: clang/www/cxx_status.html:1394 + https://wg21.link/P2173R1;>P2173R1 + No + We support this one. I implemented it in

[PATCH] D119224: [clang][tests] Add a testcase for C++ DR2406

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for spotting this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119224/new/ https://reviews.llvm.org/D119224

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

kiranchandramohan added a comment. The tests added are failing in the windows CI. Comment at: flang/lib/Frontend/FrontendActions.cpp:421 + // Set-up the MLIR pass manager + fir::setTargetTriple(*mlirModule_, "native"); + auto =

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

sameerds added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:566 + return false; +}; + jdoerfert wrote: > You can use AAPointerInfo for the call site return IRPosition. It will > (through the iterations) gather all accesses

[PATCH] D119231: [clang][lex][minimizer] Ensure whitespace between squashed lines

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The minimizer tries to squash multi-line macro definitions into single line. For that to

[PATCH] D119157: [NVPTX] Add ex2 f16 support

npmiller added a comment. Yes, it should be good to be reviewed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119157/new/ https://reviews.llvm.org/D119157 ___ cfe-commits mailing list

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

lebedev.ri added a comment. In D84225#3303771 , @pengfei wrote: > In D84225#3302142 , @rnk wrote: > >> I think LLVM already doesn't do some tail merging optimizations on inline >> asm, but allowing the use of the

[PATCH] D119172: [pseudo] Implement LRGraph

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, thank you! Bunch of nits, up to you what you want to do with them. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/LRGraph.h:10 +// LR parsers are bottom-up

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kbobyrev updated this revision to Diff 406741. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files:

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kbobyrev added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StandardLibrary.h:37 + static llvm::Optional named(llvm::StringRef Scope, + llvm::StringRef Name); + kadircet wrote: > should scope have

[PATCH] D119218: [clang-format] Honour "// clang-format off" when using QualifierOrder.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Perfect thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119218/new/ https://reviews.llvm.org/D119218

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

pengfei added a comment. In D84225#3302142 , @rnk wrote: > I think LLVM already doesn't do some tail merging optimizations on inline > asm, but allowing the use of the attribute is more principled, and will block > more optimizations (CSE). IIRC, the

[PATCH] D119226: [clang][lex][minimizer] Avoid treating path separators as comments

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The minimizer strips out single-line comments (introduced by `//`). This sequence of

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kbobyrev added a comment. In D119130#3300780 , @kadircet wrote: > Regarding the include mapping generator, I think it would've been better if > we had some sort of list directly from libc++ (as this is now being part of > clang rather than just

[PATCH] D119230: [clang] Add test for C++ DR2390

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119230/new/ https://reviews.llvm.org/D119230

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

aaron.ballman added a comment. In D118104#3303665 , @JesApp wrote: > Thanks for accepting. Do I need to do anything to get this merged or is this > basically done? Oops, sorry for failing to ask if you needed this committed on your behalf. :-) What

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

pengfei added a comment. In D84225#3303821 , @lebedev.ri wrote: > In D84225#3303771 , @pengfei wrote: > >> In D84225#3302142 , @rnk wrote: >> >>> I think LLVM already

[PATCH] D119218: [clang-format] Honour "// clang-format off" when using QualifierOrder.

curdeius marked an inline comment as done. curdeius added inline comments. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:875 + "// clang-format on\n" + "inline static const int a = 0;\n", + "// clang-format off\n"

[PATCH] D119230: [clang] Add test for C++ DR2390

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. DR2390 clarifies that the argument to `__has_cpp_attribute()` needs to be macro-expanded. Clang already

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

balazske added a comment. @martong Ping We do not have possibility currently to check all LLDB tests. I think we can commit this and observe the buildbots for failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116155/new/

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

balazske added a comment. (The current code does not work, the mentioned fixes must be applied first.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116155/new/ https://reviews.llvm.org/D116155 ___

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

jdoerfert added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:566 + return false; +}; + You can use AAPointerInfo for the call site return IRPosition. It will (through the iterations) gather all accesses and put them into

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. LGTM, thanks! I just have a minor nit, feel free to ignore it. Comment at: flang/lib/Frontend/FrontendActions.cpp:471 + + if (!ci.IsOutputStreamNull()) { +

[clang] 06e4259 - [clang-format] Comment unused parameters. NFC.

Author: Marek Kurdej Date: 2022-02-08T09:33:55+01:00 New Revision: 06e42590a5275fb8f6f7f225968620b5efe5b6f5 URL: https://github.com/llvm/llvm-project/commit/06e42590a5275fb8f6f7f225968620b5efe5b6f5 DIFF: https://github.com/llvm/llvm-project/commit/06e42590a5275fb8f6f7f225968620b5efe5b6f5.diff

[clang] 7d63973 - [clang-format] Fix typo. NFC.

Author: Marek Kurdej Date: 2022-02-08T09:33:54+01:00 New Revision: 7d6397348e453a0c941bca0f3a30087680d2f14c URL: https://github.com/llvm/llvm-project/commit/7d6397348e453a0c941bca0f3a30087680d2f14c DIFF: https://github.com/llvm/llvm-project/commit/7d6397348e453a0c941bca0f3a30087680d2f14c.diff

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. Thanks for accepting. Do I need to do anything to get this merged or is this basically done? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 ___ cfe-commits mailing list

[PATCH] D119218: [clang-format] Honour "// clang-format off" when using QualifierOrder.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/53643. Repository: rG

[PATCH] D118333: [RISCV] Use computeTargetABI from llc as well as clang

khchen added a comment. clang will calculate the default target-abi if -mabi is empty and encode the it in LLVM IR module flag. then if llc has no target-abi option (`Options.MCOptions.ABIName` is empty), in getSubtargetImpl it uses different way to compute the default target-abi, then the

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

kees added a comment. I can build and boot with this. Nice! :) One issue I see is in instruction sequence ordering. Looking at the end of `__startup_64` without the feature enabled, everything looks "normal": 31 c0 xor%eax,%eax 5b pop%rbx 41 5e pop%r14 41

[clang] 90d2291 - [NFC] Fix comment.

Author: Clement Courbet Date: 2022-02-08T09:42:44+01:00 New Revision: 90d2291fbb4a382d8a36dfbb2bcfcc55f21b2bdc URL: https://github.com/llvm/llvm-project/commit/90d2291fbb4a382d8a36dfbb2bcfcc55f21b2bdc DIFF:

[PATCH] D119094: [clang] Don't emit redundant warnings for 'return;'

sammccall added a comment. In D119094#3302452 , @Quuxplusone wrote: > Fix the two failing test cases (in one case by fixing what seems to have been > a typo in the test). I think you forgot to upload these changes. CHANGES SINCE LAST ACTION

[PATCH] D119207: [CUDA][SPIRV] Convert CUDA kernels to SPIR-V kernels

jlebar added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10322 ABIArgInfo SPIRVABIInfo::classifyKernelArgumentType(QualType Ty) const { - if (getContext().getLangOpts().HIP) { + if (getContext().getLangOpts().CUDAIsDevice) { // Coerce pointer arguments

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

aaron.ballman added a comment. In D118804#3303004 , @jyknight wrote: > In D118804#3302675 , @rsmith wrote: > >> I support this revert. > > Having received enough support, I'll go ahead and commit, and then

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

urnathan added a comment. While C2X has blessed such smaller alignments, the x86_64 ABI (in particular), has not. However, using that ABI to justify 'It. Is. 16. Bytes.', is really an exercise in reality denial at this point. just thought I'd make it clear we have conflicting standards and

[PATCH] D119166: [clang][ARM] Re-word PACBTI warning.

amilendra updated this revision to Diff 406780. amilendra added a comment. [clang][ARM] Re-word PACBTI warning. Fix grammar error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119166/new/ https://reviews.llvm.org/D119166 Files:

[PATCH] D118383: [OpenMP] Enable inoutset dependency-type in depend clause.

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in 0a7cc078ac2be36beb605f08d98ee70065352c7b , thank you! I think it's entirely appropriate for you to obtain commit privileges

[PATCH] D119225: [clang] Add core papers adopted at the february plenary.

cor3ntin updated this revision to Diff 406792. cor3ntin added a comment. I missed that, sorry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119225/new/ https://reviews.llvm.org/D119225 Files: clang/www/cxx_status.html Index:

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kbobyrev updated this revision to Diff 406794. kbobyrev added a comment. Add a comment for the helper function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files:

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:198 +const auto *STI = TM.getMCSubtargetInfo(); +return llvm::AMDGPU::getHostcallImplicitArgPosition(STI); + } The ABI should not be a property of the subtarget, and

[clang] 09857a4 - [X86] Remove __builtin_ia32_padd/psub saturated intrinsics and use generic __builtin_elementwise_add/sub_sat

Author: Simon Pilgrim Date: 2022-02-08T15:00:10Z New Revision: 09857a4bd166ca62a9610629731dfbf8f62cd955 URL: https://github.com/llvm/llvm-project/commit/09857a4bd166ca62a9610629731dfbf8f62cd955 DIFF: https://github.com/llvm/llvm-project/commit/09857a4bd166ca62a9610629731dfbf8f62cd955.diff

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

sameerds updated this revision to Diff 406785. sameerds added a comment. eliminated NeedsHostcall by simply checking the return value of the walk over all calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119216/new/

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

jwakely added a comment. > GCC 12 should have proper support for IEEE-754 compliant 128-bit floating > point in libstdc++. Yes, but it's unconditionally disabled when including the headers with Clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6c174ab - [X86] Remove __builtin_ia32_padd/psub saturated intrinsics and use generic __builtin_elementwise_add/sub_sat

Author: Simon Pilgrim Date: 2022-02-08T14:21:20Z New Revision: 6c174ab2ad0676b295f11f6c3913eff9289fa6b9 URL: https://github.com/llvm/llvm-project/commit/6c174ab2ad0676b295f11f6c3913eff9289fa6b9 DIFF: https://github.com/llvm/llvm-project/commit/6c174ab2ad0676b295f11f6c3913eff9289fa6b9.diff

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I spent some more time looking at this, and don't see anything suspicious, and since the others didn't have anything to say (AND it is early in the cycle), I think I'm OK accepting

[clang] a59faf2 - Revert rG6c174ab2ad0676b295f11f6c3913eff9289fa6b9 "[X86] Remove __builtin_ia32_padd/psub saturated intrinsics and use generic __builtin_elementwise_add/sub_sat"

Author: Simon Pilgrim Date: 2022-02-08T14:45:28Z New Revision: a59faf272e57c1a3dabda89fc22f9f9e61a350fe URL: https://github.com/llvm/llvm-project/commit/a59faf272e57c1a3dabda89fc22f9f9e61a350fe DIFF: https://github.com/llvm/llvm-project/commit/a59faf272e57c1a3dabda89fc22f9f9e61a350fe.diff

[PATCH] D72404: [ThinLTO/FullLTO] Support Os and Oz

aykevl added a comment. Herald added a reviewer: MaskRay. I would be very interested in this patch, because for me to use ThinLTO without size regressions I need to set the optimization size level in the linker (`PassManagerBuilder.SizeLevel` etc). This patch seems mostly correct to me, except

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

urnathan added a comment. In D118804#3304280 , @aaron.ballman wrote: > In D118804#3304261 , @urnathan > wrote: > >> While C2X has blessed such smaller alignments, the x86_64 ABI (in >> particular), has not.

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in 0851970af5771f6721c29d066c88a72db823ba83 , thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/

[PATCH] D119225: [clang] Add core papers adopted at the february plenary.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119225/new/ https://reviews.llvm.org/D119225

[clang] 3c17f39 - Add core papers adopted at the february plenary.

Author: Corentin Jabot Date: 2022-02-08T09:13:04-05:00 New Revision: 3c17f3955c8b18da658ccb2fafde0759210b3f17 URL: https://github.com/llvm/llvm-project/commit/3c17f3955c8b18da658ccb2fafde0759210b3f17 DIFF:

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:521 + + while (!WorkList.empty()) { +auto UseInfo = WorkList.back(); Can you use checkForAllUses instead of creating your own worklist? Repository: rG LLVM

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev updated this revision to Diff 406800. kbobyrev added a comment. Fix the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files: clang-tools-extra/clangd/CSymbolMap.inc

[PATCH] D111100: enable plugins for clang-tidy

cristian.adam requested changes to this revision. cristian.adam added a comment. I had on Windows two uses cases that failed due to this patch. 1. MSVC2019 with `-D LLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON` FAILED: bin/CTTestTidyModule.dll cmd.exe /C "cd . && C:\tools\cmake\bin\cmake.exe -E

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

aaron.ballman added inline comments. Comment at: clang/test/Sema/aix-attr-align.c:34-35 + baz(s.a); // no-warning + baz(s.b); // expected-warning {{requesting an alignment of 16 bytes or greater for struct members is not binary compatible with IBM XL C/C++ for AIX 16.1.0 and

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

aaron.ballman added a comment. In D118804#3304261 , @urnathan wrote: > While C2X has blessed such smaller alignments, the x86_64 ABI (in > particular), has not. However, using that ABI to justify 'It. Is. 16. > Bytes.', is really an exercise in

[PATCH] D115610: [C++20] [Modules] Don't create multiple global module fragment

urnathan added a comment. the landed version is good, with Richard's suggested member name change. Can't see a way of post-commit accepting? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115610/new/ https://reviews.llvm.org/D115610

[clang-tools-extra] 0851970 - Make run-clang-tidy.py print the configured checks correctly

Author: Jesko Appelfeller Date: 2022-02-08T08:32:04-05:00 New Revision: 0851970af5771f6721c29d066c88a72db823ba83 URL: https://github.com/llvm/llvm-project/commit/0851970af5771f6721c29d066c88a72db823ba83 DIFF:

[clang] 9b8a93e - [OpenCL] opencl-c.h: remove arg names from arm_dot; NFC

Author: Sven van Haastregt Date: 2022-02-08T13:42:24Z New Revision: 9b8a93e3b6d36ad4f96c93a6c41ca4b0ef6d3d22 URL: https://github.com/llvm/llvm-project/commit/9b8a93e3b6d36ad4f96c93a6c41ca4b0ef6d3d22 DIFF: https://github.com/llvm/llvm-project/commit/9b8a93e3b6d36ad4f96c93a6c41ca4b0ef6d3d22.diff

[PATCH] D119225: [clang] Add core papers adopted at the february plenary.

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in 3c17f3955c8b18da658ccb2fafde0759210b3f17 , thanks for the update! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kbobyrev updated this revision to Diff 406793. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files:

[PATCH] D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs

steakhal resigned from this revision. steakhal added a comment. Herald added a subscriber: steakhal. I think I don't have much to add. I still haven't changed my mind, but let's go with what the majority of people want. To make the whole stack consistent, consider mocking the variadic free

[PATCH] D119218: [clang-format] Honour "// clang-format off" when using QualifierOrder.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:879 + "// clang-format on\n" + "int const inline static a = 0;\n", + Style);

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

cristian.adam requested changes to this revision. cristian.adam added a comment. This revision now requires changes to proceed. This patch is having problems on Windows with MSVC 2019 and `-D LLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON` and `-D "LLVM_ENABLE_PROJECTS=clang;clang-tools-extra"`. CMake

[PATCH] D117391: [AST] Ignore implicit nodes in CastExpr::getConversionFunction

aaron.ballman added a comment. In D117391#3301696 , @kimgr wrote: > @aaron.ballman Thanks for the valuable feedback! > >> Assuming that the `to_lvalue_ref(A{})` case should diagnose, then yes, I >> agree, I think the `ret_a()` portion should as well. >

[PATCH] D119234: [clang] [MinGW] Recognize -lcrtdll as a library replacing -lmsvcrt

mstorsjo created this revision. mstorsjo added reviewers: mati865, rnk. mstorsjo requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119234 Files: clang/lib/Driver/ToolChains/MinGW.cpp

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. No problem. :) Jesko Appelfeller, je...@appelfeller.eu please. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

sameerds added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:589 +A.checkForAllCallLikeInstructions(CheckForHostcallAccess, *this, + UsedAssumedInformation); + jdoerfert wrote: > Always check

[PATCH] D118104: Make run-clang-tidy.py print the configured checks correctly

JesApp added a comment. Thank you! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118104/new/ https://reviews.llvm.org/D118104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

xbolva00 added a comment. >> I think we need to deal with the reality that there are non-ABI conforming >> [system-dependent] allocators out there, Definitely not a good thing, just ticking bomb. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev added a comment. Oh, and also regarding the Python generator scripts: they don't seem to work with the latest archives :( 2018 mentioned in the docs (works perfectly) but 2019 crashes. Probably not very relevant if we switch to libc++ eventually. Repository: rG LLVM Github Monorepo

[PATCH] D118894: [OpenCL] Mark kernel arguments as ABI aligned

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18834dca2d78: [OpenCL] Mark kernel arguments as ABI aligned (authored by nikic). Herald added subscribers: cfe-commits, ldrumm. Herald added a

[clang] 18834dc - [OpenCL] Mark kernel arguments as ABI aligned

Author: Nikita Popov Date: 2022-02-08T16:12:51+01:00 New Revision: 18834dca2d787fb46532c0b688e396613e132020 URL: https://github.com/llvm/llvm-project/commit/18834dca2d787fb46532c0b688e396613e132020 DIFF: https://github.com/llvm/llvm-project/commit/18834dca2d787fb46532c0b688e396613e132020.diff

[PATCH] D118804: Revert "[Clang] Propagate guaranteed alignment for malloc and others"

aaron.ballman added a comment. In D118804#3304337 , @urnathan wrote: > In D118804#3304280 , @aaron.ballman > wrote: > >> In D118804#3304261 , @urnathan >> wrote: >> >>>

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev updated this revision to Diff 406827. kbobyrev added a comment. Fix the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files: clang-tools-extra/clangd/CSymbolMap.inc

[PATCH] D118985: [flang][driver] Add support for `-emit-mlir`

awarzynski updated this revision to Diff 406828. awarzynski added a comment. - Add a test to verify that an `.mlir` file is created - Set the target triple to `native` (as opposed to relying on it being set elsewhere, e.g.

[PATCH] D119250: [RISCV][NFC] Refactor RISCVISAInfo.

khchen created this revision. khchen added reviewers: asb, kito-cheng, craig.topper, jrtc27. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, dexonsmith, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX,

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski updated this revision to Diff 406832. awarzynski added a comment. Disable the LIT test on Windows, simplify how output is dumped in `EmitLLVMAction::ExecuteAction`, remove `auto` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119012/new/

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

aaron.ballman added a comment. Thanks! I think we're pretty close, just some wording nits with the diagnostics. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3299-3301 +: Warning<" %0 byte requested alignment for a struct member used as an" + "

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 406843. ZarkoCA added a comment. - Shorten warning message - Add new note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118350 Files:

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118350

[clang] eaac0e8 - [NFC][clang] Autogenerate checklines in CodeGenCXX/nrvo.cpp

Author: Roman Lebedev Date: 2022-02-08T18:27:54+03:00 New Revision: eaac0e87fb0249f9b87b9929b1afa24504db9792 URL: https://github.com/llvm/llvm-project/commit/eaac0e87fb0249f9b87b9929b1afa24504db9792 DIFF: https://github.com/llvm/llvm-project/commit/eaac0e87fb0249f9b87b9929b1afa24504db9792.diff

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 406822. ZarkoCA added a comment. - Warn on declaration of struct member and add note for call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118350 Files:

[PATCH] D119012: [flang][driver] Add support for the `-emit-llvm` option

awarzynski added a comment. I believe that Windows failures are due to the missing support here: https://github.com/llvm/llvm-project/blob/81cde474e2c5a6280cb693b777ddcf473825ae8a/flang/lib/Optimizer/CodeGen/Target.cpp#L290. I can disable the LIT test on Windows, but I'm not sure how to do it

[PATCH] D118690: [analyzer] Prevent misuses of -analyze-function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG841817b1ed26: [analyzer] Prevent misuses of -analyze-function (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 841817b - [analyzer] Prevent misuses of -analyze-function

Author: Balazs Benics Date: 2022-02-08T17:27:57+01:00 New Revision: 841817b1ed26c1fbb709957d54c0e2751624fbf8 URL: https://github.com/llvm/llvm-project/commit/841817b1ed26c1fbb709957d54c0e2751624fbf8 DIFF: https://github.com/llvm/llvm-project/commit/841817b1ed26c1fbb709957d54c0e2751624fbf8.diff

[PATCH] D119184: [clang] [concepts] Check constrained-auto return types for void-returning functions

Quuxplusone updated this revision to Diff 406847. Quuxplusone added a comment. Update one additional test where the expected output has changed: auto& f() { } now produces "can't make a reference to void" instead of "can't deduce `auto&` from no return statements." I think this is a mild

[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

jchlanda updated this revision to Diff 406851. jchlanda added a comment. Add sm/ptx version guard to f16{x2} builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118977/new/ https://reviews.llvm.org/D118977 Files:

[PATCH] D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute

aaron.ballman added a comment. I still have some naming issues that need to be corrected, but functionally I think this is good to go. I presume you don't have commit privileges @steffenlarsen? If that's accurate, what name and email address would you like me to use for patch attribution after

[clang] 620d99b - Revert "[analyzer] Prevent misuses of -analyze-function"

Author: Balazs Benics Date: 2022-02-08T17:42:46+01:00 New Revision: 620d99b7edc64ee87b1ce209f179305e6a919006 URL: https://github.com/llvm/llvm-project/commit/620d99b7edc64ee87b1ce209f179305e6a919006 DIFF: https://github.com/llvm/llvm-project/commit/620d99b7edc64ee87b1ce209f179305e6a919006.diff

[PATCH] D113319: [clang-format] Improve require and concept handling

Mordante added inline comments. Comment at: clang/lib/Format/Format.cpp:1212 LLVMStyle.ReferenceAlignment = FormatStyle::RAS_Pointer; + // This is open for discussions! When will LLVM adapt C++20? + LLVMStyle.RequiresClausePositionForClasses = FormatStyle::RCPS_OwnLine;

[PATCH] D119216: [AMDGPU] replace hostcall module flag with function attribute

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:198 +const auto *STI = TM.getMCSubtargetInfo(); +return llvm::AMDGPU::getHostcallImplicitArgPosition(STI); + } arsenm wrote: > The ABI should not be a property of the

  1   2   3   >