[PATCH] D134369: [Clang] Support constexpr builtin fmax

Izaron updated this revision to Diff 464990. Izaron added a comment. Fix corner case with pos/neg zeroes Fix tests for pos/neg zeroes with __builtin_copysign Thanks to @efriedma and @jcranmer-intel! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

royjacobson added a comment. Is there consensus that applying this DR resolution is distruptive enough that it's actually an issue? If clang-abi-compat is not a good way to offer backwards compatibility in this case, maybe we should just leave it be. FWIW, I worry that applying it according to

[PATCH] D135090: [Clang] fix -Wvoid-ptr-dereference for gnu89

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135090/new/ https://reviews.llvm.org/D135090

[PATCH] D135115: [clang-format] update --files help description

probinson added inline comments. Comment at: clang/docs/ClangFormat.rst:72-73 Used only with --dry-run or -n ---files= - Provide a list of files to run clang-format +--files= - Accept a list of response

[PATCH] D135025: [clang][Interp] Support base class constructors

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:263 +QualType T = E->getType(); +if (const auto *PT = dyn_cast(T)) + T = PT->getPointeeType(); erichkeane wrote: > We are

[PATCH] D133817: MSVC ABI: Looks like even non-aarch64 uses the MSVC/14 definition for pod/aggregate passing

hans added a comment. > Right, we did have a record layout fuzzer which worked pretty well. I think > it only ever ran on a workstation, it relied on custom tools and the like. I > think it's lost to the sands of time. (The code still exists: https://github.com/dberlin/superfuzz I've never run

[PATCH] D134947: [analyzer] Fix liveness of Symbols for values in regions reffered by LazyCompoundVal

steakhal added a comment. First of all, thanks for the feedback! In D134947#3830995 , @xazax.hun wrote: > If we end up going with this approach, I wonder if it would be a great time > to update some of the docs here: >

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

cjdb updated this revision to Diff 465048. cjdb added a comment. uploading for archival purposes, will abandon the review in a moment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116280/new/ https://reviews.llvm.org/D116280 Files:

[PATCH] D135169: [LLDB] Fix printing a static bool struct member when using "image lookup -t"

shafik added inline comments. Comment at: clang/include/clang/AST/ExprCXX.h:733 + static CXXBoolLiteralExpr *Create(const ASTContext , bool Val, QualType Ty, +SourceLocation Loc) { I think this makes sense but if we are

[PATCH] D134654: [clang] Detect header loops

philnik added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:323 "whitespace recommended after macro name">; +def warn_include_cycle : Warning<"#include cycle">, + InGroup>, DefaultIgnore; aaron.ballman wrote: > urnathan wrote:

[clang] 6842d35 - [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive

Author: Dominik Adamski Date: 2022-10-04T08:30:00-05:00 New Revision: 6842d35012668d5dc3846fcbde136326e6e09bb3 URL: https://github.com/llvm/llvm-project/commit/6842d35012668d5dc3846fcbde136326e6e09bb3 DIFF:

[PATCH] D134654: [clang] Detect header loops

urnathan marked 2 inline comments as done. urnathan added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:323 "whitespace recommended after macro name">; +def warn_include_cycle : Warning<"#include cycle">, + InGroup>, DefaultIgnore;

[PATCH] D135012: [clang][Interp] Implement bitwise and operations

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/AST/Interp/literals.cpp:289 + static_assert((1337 & -1) == 1337, ""); + static_assert((0 & gimme(12)) == 0, ""); +}; Why

[PATCH] D135025: [clang][Interp] Support base class constructors

shafik added a comment. This looks good to me but I would like one other set of eyes on it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135025/new/ https://reviews.llvm.org/D135025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135161: [clang][Lex] Fix a crash on malformed string literals

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D135161 Files:

[PATCH] D135012: [clang][Interp] Implement bitwise and operations

tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:289 + static_assert((1337 & -1) == 1337, ""); + static_assert((0 & gimme(12)) == 0, ""); +}; shafik wrote: > Why `gimme(12)` and not just `12`? I just thought it might be useful to

[PATCH] D135171: FreeBSD: enable __float128 on x86

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 ___

[PATCH] D135171: FreeBSD: enable __float128 on x86

arichardson accepted this revision. arichardson added a comment. Could you add a RUN: line to `clang/test/CodeGenCXX/float128-declarations.cpp? Code LGTM. // RUN: %clang_cc1 -no-opaque-pointers -emit-llvm -triple x86_64-unknown-freebsd -std=c++11 \ // RUN: %s -o - | FileCheck %s

[PATCH] D135175: [clang] adds `__is_bounded_array` and `__is_unbounded_array` as builtins

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is information that the compiler already has, and should be exposed so that the

[PATCH] D135154: Keep inherited dllimport/export attrs for explicit specialization of template class member functions

hans created this revision. hans added a reviewer: thakis. Herald added a subscriber: mstorsjo. Herald added a project: All. hans requested review of this revision. Herald added a project: clang. Previously we were stripping these normally inherited attributes during explicit specialization.

[PATCH] D135115: [clang-format] update --files help description

MyDeveloperDay added a comment. Its Is a minor point, but when using --files, the shell will allow me to autocomplete.. clang-format -verbose -n -files ./cla clang-format -verbose -n -files ./clang/d etc... all the way to the file clang-format -verbose -n -files

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

qiongsiwu1 updated this revision to Diff 464998. qiongsiwu1 added a comment. Address review comments. Remove unnecessary `Twine`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134820/new/ https://reviews.llvm.org/D134820 Files:

[PATCH] D135161: [clang][Lex] Fix a crash on malformed string literals

tahonermann added subscribers: cor3ntin, tahonermann. tahonermann added a reviewer: cor3ntin. tahonermann added a comment. I think this looks right, but it would be good for @cor3ntin to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135025: [clang][Interp] Support base class constructors

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:165 + +class A : public Base { +public: erichkeane wrote: > tbaeder wrote: > > erichkeane wrote: > > > shafik wrote: > > > > How about also

[PATCH] D135170: [LLDB] Fix crash when printing a struct with a static signed char member

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. As with static bool for whatever reason printing them on their own worked fine but wasn't

[PATCH] D135169: [LLDB] Fix printing a static bool struct member when using "image lookup -t"

DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. For https://github.com/llvm/llvm-project/issues/58135. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135169/new/ https://reviews.llvm.org/D135169

[clang] 42ad305 - Modify the qualified/unqualified getter for TypeOfType; NFC

Author: Aaron Ballman Date: 2022-10-04T12:14:38-04:00 New Revision: 42ad305bdbb87d567d4d365ec5ede8be4d2a4210 URL: https://github.com/llvm/llvm-project/commit/42ad305bdbb87d567d4d365ec5ede8be4d2a4210 DIFF: https://github.com/llvm/llvm-project/commit/42ad305bdbb87d567d4d365ec5ede8be4d2a4210.diff

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Type.h:4564 + /// Returns true if this is a typeof_unqual type. + bool isUnqual() const { return TypeOfBits.IsUnqual; } + mizvekov wrote: > I only noticed this after rebasing some of my

[PATCH] D135115: [clang-format] update --files help description

probinson added a comment. The option handling in clang-format itself would need to be updated as well. Comment at: clang/docs/ClangFormat.rst:29 USAGE: clang-format [options] [ ...] MyDeveloperDay wrote: > if response files are so common place why not

[PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. Sorry for the long delay, the size of this makes it tough to review, and I've been trying to make sure my concepts patch didn't get reverted. This generally looks good to me, however, I really don't like the number of bits to represent 'template parameter' being

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

mizvekov added inline comments. Comment at: clang/include/clang/AST/Type.h:4564 + /// Returns true if this is a typeof_unqual type. + bool isUnqual() const { return TypeOfBits.IsUnqual; } + I only noticed this after rebasing some of my patches, I missed this

[PATCH] D135025: [clang][Interp] Support base class constructors

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:263 +QualType T = E->getType(); +if (const auto *PT = dyn_cast(T)) + T = PT->getPointeeType(); We are de-pointering here, why not de-referencing? If we are OK

[PATCH] D135161: [clang][Lex] Fix a crash on malformed string literals

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Yes, this looks reasonable. The additional warning is somewhat unfortunate, and we could avoid it, but at the same time i don't expect it would bother anyone given how unlikely the

[PATCH] D135025: [clang][Interp] Support base class constructors

erichkeane added inline comments. Comment at: clang/test/AST/Interp/records.cpp:165 + +class A : public Base { +public: tbaeder wrote: > erichkeane wrote: > > shafik wrote: > > > How about also testing `private` and `virtual` as well as multiple bases. > > I

[PATCH] D135169: [LLDB] Fix printing a static bool struct member when using "image lookup -t"

DavidSpickett created this revision. Herald added a reviewer: shafik. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Fixes #58135 Somehow lldb was able to print the member on

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Floating.h:27-29 + template struct Repr; + template <> struct Repr<32> { using Type = float; }; + template <> struct Repr<64> { using Type = double; }; tbaeder wrote: > jcranmer-intel

[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

njames93 updated this revision to Diff 465045. njames93 added a comment. Rebase to trunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134549/new/ https://reviews.llvm.org/D134549 Files: clang/docs/ReleaseNotes.rst

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

mizvekov added inline comments. Comment at: clang/include/clang/AST/Type.h:4564 + /// Returns true if this is a typeof_unqual type. + bool isUnqual() const { return TypeOfBits.IsUnqual; } + aaron.ballman wrote: > mizvekov wrote: > > I only noticed this after

[PATCH] D134654: [clang] Detect header loops

urnathan updated this revision to Diff 465006. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134654/new/ https://reviews.llvm.org/D134654 Files: clang/include/clang/Basic/FileEntry.h clang/lib/Lex/PPDirectives.cpp clang/lib/Lex/PPLexerChange.cpp Index:

[PATCH] D134791: [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr

aaron.ballman added a comment. In general, this looks reasonable to me. Comment at: clang/include/clang/AST/Expr.h:529 + /// When IgnoreTemplateOrMacroSubstitution is set, it doesn't consider sizes + /// resulting from substitution of macro or template as special sizes. +

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

hubert.reinterpretcast added a comment. In D128745#3833291 , @aaron.ballman wrote: > @rjmccall is correct about us not being required to apply DRs when they're > disruptive, but at the same time, WG21 DRs are intended to be handled as if > the

[PATCH] D135171: FreeBSD: enable __float128 on x86

brooks created this revision. brooks added reviewers: arichardson, emaste, dim. Herald added a subscriber: krytarowski. Herald added a project: All. brooks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a prerequisite for proper

[PATCH] D134654: [clang] Detect header loops

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:323 "whitespace recommended after macro name">; +def warn_include_cycle : Warning<"#include cycle">, + InGroup>, DefaultIgnore; urnathan wrote: > aaron.ballman

[clang] 4409a83 - [clang] Correct handling of lambdas in lambda default arguments in dependent contexts.

Author: Tom Honermann Date: 2022-10-04T09:04:54-07:00 New Revision: 4409a83c293537e22da046b54e9f69454cdd3dca URL: https://github.com/llvm/llvm-project/commit/4409a83c293537e22da046b54e9f69454cdd3dca DIFF: https://github.com/llvm/llvm-project/commit/4409a83c293537e22da046b54e9f69454cdd3dca.diff

[PATCH] D134549: [clang] Add fix-it note to defaulted-function-deleted warning

njames93 updated this revision to Diff 465042. njames93 added a comment. Address @martong's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134549/new/ https://reviews.llvm.org/D134549 Files: clang/docs/ReleaseNotes.rst

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

aaron.ballman added a reviewer: hubert.reinterpretcast. aaron.ballman added a subscriber: hubert.reinterpretcast. aaron.ballman added a comment. In D128745#3832598 , @ychen wrote: > In D128745#3832432 , @rjmccall

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

erichkeane added a comment. Is there any ability here to diagnose the difference? It would probably be helpful if at any point (in both directions!) we diagnose that our behavior changes. We did something similar for the reversible operators at one point (but WG21 might have fixed it

[PATCH] D134046: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive

This revision was automatically updated to reflect the committed changes. Closed by commit rG6842d3501266: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for… (authored by domada). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134654: [clang] Detect header loops

urnathan updated this revision to Diff 465007. urnathan marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134654/new/ https://reviews.llvm.org/D134654 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/include/clang/Lex/Preprocessor.h

[PATCH] D135159: [clang-tools-extra] [test] Use CLANG_NO_DEFAULT_CONFIG=1

mgorny created this revision. mgorny added reviewers: sammccall, MaskRay, sepavloff. Herald added subscribers: StephenFan, kadircet, arphaman. Herald added a project: All. mgorny requested review of this revision. Herald added a project: clang-tools-extra. Set CLANG_NO_DEFAULT_CONFIG=1 for

[PATCH] D133500: [clang] Correct handling of lambdas in lambda default arguments in dependent contexts.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tahonermann marked an inline comment as done. Closed by commit rG4409a83c2935: [clang] Correct handling of lambdas in lambda default arguments in dependent… (authored

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

cjdb added a comment. This commit is suffering from feature creep, which has a whole host of problems associated with it. I'm going to dump everything that I've got related to the patch here for archival purposes, abandon it, and then spin out tiny CLs, some of which are hopefully trivial to

[PATCH] D135025: [clang][Interp] Support base class constructors

tbaeder updated this revision to Diff 464915. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135025/new/ https://reviews.llvm.org/D135025 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp

[PATCH] D132855: [OpenMP] Extend the lit test for uses_allocators in target region

animeshk-amd updated this revision to Diff 464932. animeshk-amd added a comment. Rebased the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132855/new/ https://reviews.llvm.org/D132855 Files: clang/test/OpenMP/target_map_codegen_10.cpp

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

ilya-biryukov added a comment. In D119130#3829816 , @thakis wrote: > This makes clang-format depend on clang's AST library Oops, definitely an unintended outcome. Ping @kadircet, in case he missed this. He should know best who can fix this.

[PATCH] D134947: [analyzer] Fix liveness of Symbols for values in regions reffered by LazyCompoundVal

steakhal added inline comments. Comment at: clang/test/Analysis/trivial-copy-struct.cpp:58 + clang_analyzer_warnIfReached(); // no-warning: Dead code. +}; + Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135136: [analyzer] Make directly bounded LazyCompoundVal as lazily copied

steakhal updated this revision to Diff 464961. steakhal added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135136/new/ https://reviews.llvm.org/D135136 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

aaron.ballman added a subscriber: mizvekov. aaron.ballman added a comment. In D134813#3826991 , @aaron.ballman wrote: > The clangd test failure found by precommit CI is stumping me as to how to > resolve it. @sammccall -- can you help me out? The issue

[PATCH] D132855: [OpenMP] Extend the lit test for uses_allocators in target region

jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_map_codegen_10.cpp:19 +// RUN: %clang_cc1 -no-opaque-pointers -DCK11 -fopenmp -fopenmp-targets=i386-pc-linux-gnu -x c++ -std=c++11 -triple i386-unknown-unknown -emit-pch -o %t %s +// RUN: %clang_cc1

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134699/new/ https://reviews.llvm.org/D134699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Floating.h:27-29 + template struct Repr; + template <> struct Repr<32> { using Type = float; }; + template <> struct Repr<64> { using Type = double; }; jcranmer-intel wrote: > tbaeder wrote: > >

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

domada updated this revision to Diff 464924. domada added a comment. Add assert to ensure that alignment value is always specified. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133578/new/ https://reviews.llvm.org/D133578 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D134797: [X86][vectorcall] Make floating-type passed by value to match with MSVC

pengfei updated this revision to Diff 464892. pengfei added a comment. Add HFA test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134797/new/ https://reviews.llvm.org/D134797 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D134797: [X86][vectorcall] Make floating-type passed by value to match with MSVC

pengfei added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1858-1859 } -return getIndirectResult(Ty, /*ByVal=*/false, State); +bool ByVal = IsVectorCall && Ty->isFloatingType(); +return getIndirectResult(Ty, ByVal, State); }

[PATCH] D134942: [Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation.

hokein added a comment. In D134942#3828449 , @nickdesaulniers wrote: > In D134942#3827216 , @hokein wrote: > >> Some more perf data on building linux kernel (x86_64) >> >> before: getFileID 2.4% (1.10% on

[PATCH] D134788: [ARM64EC][clang-cl] Add arm64EC test; NFC

bcl5980 updated this revision to Diff 464909. bcl5980 retitled this revision from "[ARM64EC][clang-cl] Add /arm64EC flag" to "[ARM64EC][clang-cl] Add arm64EC test; NFC". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134788/new/ https://reviews.llvm.org/D134788 Files:

[PATCH] D135025: [clang][Interp] Support base class constructors

tbaeder updated this revision to Diff 464913. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135025/new/ https://reviews.llvm.org/D135025 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/test/AST/Interp/records.cpp Index:

[PATCH] D135136: [analyzer] Make directly bounded LazyCompoundVal as lazily copied

steakhal created this revision. steakhal added reviewers: NoQ, martong, xazax.hun. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a reviewer: Szelethus. Herald added a project: All.

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

fx-carton added a comment. Great check! Would it be possible to add an option to show the warning if a `using` directive is used? As in: namespace ns { struct s {}; void func(const s&) { } } using ns::s; using ns::func; // without this the check is triggered

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3832432 , @rjmccall wrote: > Pinging this thread because it has more reviewers who probably have opinions > about this. > > https://reviews.llvm.org/D134507 is a patch that adds `-fclang-abi-compat` > support around

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

python3kgae added a comment. In D135011#3831452 , @craig.topper wrote: > Does these support scalable vector types from ARM SVE or RISC-V? I can't > remember what the rest of the __builtin_elementwise do. I ask because the > backends will probably

[PATCH] D135012: [clang][Interp] Implement bitwise and operations

tbaeder updated this revision to Diff 464902. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135012/new/ https://reviews.llvm.org/D135012 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Integral.h

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

tschuett added a comment. The OpenMP frontend is mainly an IRBuilder. It is a different layering than for HLSL. Are there plans for an HLSL(IR)Builder? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135110/new/ https://reviews.llvm.org/D135110

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov updated this revision to Diff 464937. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp

[PATCH] D134046: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive

domada updated this revision to Diff 464952. domada added a comment. Remove custom enum for mapping `order(concurrent)` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134046/new/ https://reviews.llvm.org/D134046 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D135115: [clang-format] update --files help description

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormat.rst:29 USAGE: clang-format [options] [ ...] if response files are so common place why not say it here `clang-format [options] [@file]` I personally don't believe we need to

[clang-tools-extra] 6d9eb53 - [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'.

Author: Balázs Kéri Date: 2022-10-04T09:14:46+02:00 New Revision: 6d9eb533291377979882ac9674431eddd1248445 URL: https://github.com/llvm/llvm-project/commit/6d9eb533291377979882ac9674431eddd1248445 DIFF: https://github.com/llvm/llvm-project/commit/6d9eb533291377979882ac9674431eddd1248445.diff

[PATCH] D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d9eb5332913: [clang-tidy] Add checker bugprone-suspicious-realloc-usage. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133119/new/

[PATCH] D20401: [Lexer] Don't merge macro args from different macro files

hokein added a comment. >> Meanwhile, I think besides evaluating the high level logic in in TokenLexer >> and how it might be improved, I think there's potentially an opportunity for >> a "AOS vs. SOA" speedup in SourceManager. >> SourceManager::LoadedSLocEntryTable is a >> llvm::SmallVector.

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2976 + const int DefaultAlignment = 16; + domada wrote: > jdoerfert wrote: > > domada wrote: > > > jdoerfert wrote: > > > > This doesn't work. Use the data layout for any

[PATCH] D134046: [OpenMP][OMPIRBuilder] Add support for order(concurrent) to OMPIRBuilder for SIMD directive

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134046/new/ https://reviews.llvm.org/D134046 ___ cfe-commits mailing list

[PATCH] D134947: [analyzer] Fix liveness of Symbols for values in regions reffered by LazyCompoundVal

tomasz-kaminski-sonarsource added inline comments. Comment at: clang/test/Analysis/trivial-copy-struct.cpp:98 + // w->head.next and n->next are equal + clang_analyzer_warnIfReached(); // expected-warning {{REACHABLE}} +} NoQ wrote: > martong wrote:

[PATCH] D135136: [analyzer] Make directly bounded LazyCompoundVal as lazily copied

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:2290 List.insert(List.end(), InnerList.begin(), InnerList.end()); - continue; } Here is the `continue` which previously prevented `getInterestingValues()`

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

steakhal added a comment. The StaticAnalyzer changes seem to be correct. Comment at: clang/include/clang/Basic/LangOptions.h:369-376 +/// Any trailing array memeber is a FAM. +Default = 0, +/// Any trailing array member of undefined, 0, or 1 size is a FAM. +

[PATCH] D133586: [clang] initialize type qualifiers for FunctionNoProtoType

aaron.ballman added a comment. In D133586#3831624 , @rmaz wrote: > In D133586#3831618 , @vsapsai wrote: > >> How correct is it to access `isConst`, `isVolatile`, `isRestrict` for >> `FunctionNoProtoType`? Yes,

[PATCH] D134942: [Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation.

hokein updated this revision to Diff 464905. hokein added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134942/new/ https://reviews.llvm.org/D134942 Files: clang/lib/Lex/TokenLexer.cpp Index: clang/lib/Lex/TokenLexer.cpp

[PATCH] D135132: [SourceManager] Improve getFileIDLocal.

hokein created this revision. hokein added reviewers: sammccall, nickdesaulniers. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Prune the search space -- If we know offset(LastFileIDLookup) < SearchOffset, we can prune the initial

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jeanPerier accepted this revision. jeanPerier added a comment. In D130513#3832241 , @jpenix-quic wrote: > Thank you @jeanPerier for looking over the lowering portion! Regarding moving > the header (I'm replying to the comment here since the inline one

[PATCH] D135142: Use TI.hasBuiltinAtomic() when setting ATOMIC_*_LOCK_FREE values. NFCI

arichardson created this revision. arichardson added reviewers: rprichard, efriedma, hfinkel. Herald added a project: All. arichardson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I noticed that the values for

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

carlosgalvezp added a comment. @njames93 Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132461/new/ https://reviews.llvm.org/D132461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135099: [C2x] Implement support for nullptr and nullptr_t

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/PrettyPrinter.h:68 SuppressDefaultTemplateArgs(true), Bool(LO.Bool), -Nullptr(LO.CPlusPlus11), Restrict(LO.C99), Alignof(LO.CPlusPlus11), +Nullptr(LO.CPlusPlus11),

[PATCH] D135099: [C2x] Implement support for nullptr and nullptr_t

aaron.ballman updated this revision to Diff 464973. aaron.ballman marked 8 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135099/new/ https://reviews.llvm.org/D135099 Files:

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Floating.h:27-29 + template struct Repr; + template <> struct Repr<32> { using Type = float; }; + template <> struct Repr<64> { using Type = double; }; aaron.ballman wrote: > tbaeder wrote: > >

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kadircet added a comment. yeah sorry for the mess here. i agree that we should move StandardLibrary to its own library. i'll try to take a stab at this tomorrow, if no one does it before then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7d85f6b - [clang][driver][darwin] Ensure that the SDK version passed to -platform_version has a minor version number 0

Author: Alex Lorenz Date: 2022-10-04T10:23:38-07:00 New Revision: 7d85f6b1af26c8f749f0c217d7aae694cc3931eb URL: https://github.com/llvm/llvm-project/commit/7d85f6b1af26c8f749f0c217d7aae694cc3931eb DIFF: https://github.com/llvm/llvm-project/commit/7d85f6b1af26c8f749f0c217d7aae694cc3931eb.diff

[PATCH] D135154: Keep inherited dllimport/export attrs for explicit specialization of template class member functions

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lg Comment at: clang/lib/Sema/SemaDecl.cpp:7047 +NewDecl->getLocation(), +diag::err_attribute_dllimport_function_specialization_definition); +

[PATCH] D134369: [Clang] Support constexpr builtin fmax

Izaron updated this revision to Diff 465106. Izaron added a comment. Fix comment wording. Thanks to @aaron.ballman! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134369/new/ https://reviews.llvm.org/D134369 Files:

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 updated this revision to Diff 465112. jansvoboda11 added a comment. Squash the original macro with its `_IMPL` counterpart Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135128/new/ https://reviews.llvm.org/D135128 Files:

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

dblaikie added a comment. >> OK, so it sounds like the printing behavior change (not necessarily with a >> policy flag) necessary for diagnostics (make it non-ambiguous/not invalid >> code which is what is currently emitted) would be a good bug fix both for >> diagnostics and for ast-print?

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

void updated this revision to Diff 465127. void marked 3 inline comments as done. void added a comment. Fix typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135107/new/ https://reviews.llvm.org/D135107 Files:

  1   2   3   >