Re: [PATCH] D10365: Add cmd to compilation database file format

klimek added a comment. Cool, looks good! If you need me to land it let me know. http://reviews.llvm.org/D10365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D12026: Decorating vptr load & stores with !invariant.group

Prazek created this revision. Prazek added reviewers: rsmith, majnemer, pcc. Prazek added a subscriber: cfe-commits. Adding !invariant.group to vptr load/stores for devirtualization purposes. For more goto: http://lists.llvm.org/pipermail/cfe-dev/2015-July/044227.htm http://reviews.llvm.org/D120

r245028 - [modules] Add an experimental -cc1 feature to embed the contents of an input

Author: rsmith Date: Fri Aug 14 00:02:58 2015 New Revision: 245028 URL: http://llvm.org/viewvc/llvm-project?rev=245028&view=rev Log: [modules] Add an experimental -cc1 feature to embed the contents of an input file in the .pcm files. This allows a smaller set of files to be sent to a remote build

Re: [PATCH] D7642: Introduce the idea of a minimum libc version

majnemer added a comment. In http://reviews.llvm.org/D7642#224225, @compnerd wrote: > AIUI, ucrt is absolutely relevant since msvcrt itself has been split out into > the ucrt. msvcrt is the "shared" common bits, while the ucrt is more > "platform" specific bits. > > But really, the point is: s

Re: [PATCH] D11808: Driver: Fix include and lib dirs when not using gcc under mingw

Hi Hans, Is this bugfix something that can be merged into 3.7 ? Kind Regards Martell On Thu, Aug 13, 2015 at 4:42 PM, Martell Malone wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL244902: Driver: Fix include directories when not using >

Re: [PATCH] D7642: Introduce the idea of a minimum libc version

We could support that by allowing the MSVC version in the triple to be different from the -fms-compatibility-version on the command line. Today, this might even with with --target. That said, I don't imagine many people are doing this. Microsoft makes it hard for you to do this, and lots of code a

Re: [PATCH] D11859: Generating vptr assume loads

Prazek updated this revision to Diff 32122. Prazek marked an inline comment as done. http://reviews.llvm.org/D11859 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/ItaniumCXXABI.cpp lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGen/available-

Re: [PATCH] D11859: Generating vptr assume loads

Prazek marked 3 inline comments as done. Comment at: lib/CodeGen/CGClass.cpp:1832 @@ +1831,3 @@ + // Generate vtable assumptions if we are calling dynamic class ctor + // and we are not in another ctor. + if (CGM.getCodeGenOpts().OptimizationLevel > 0 && rsmith

Re: [PATCH] D11297: PR17829: Functions declared extern "C" with a name matching a mangled C++ function are allowed

rjmccall added a comment. In http://reviews.llvm.org/D11297#223622, @andreybokhanko wrote: > John, > > Thank you for the quick reply! > > Let me make sure I understand what you said, using my test as an example > (BTW, sorry if this is a dumb question -- I asked our local Clang experts, > but n

Re: [PATCH] D11859: Generating vptr assume loads

rsmith added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1832 @@ +1831,3 @@ + // Generate vtable assumptions if we are calling dynamic class ctor + // and we are not in another ctor. + if (CGM.getCodeGenOpts().OptimizationLevel > 0 && Prazek wrote: > r

Re: [PATCH] D7642: Introduce the idea of a minimum libc version

compnerd added a comment. AIUI, ucrt is absolutely relevant since msvcrt itself has been split out into the ucrt. msvcrt is the "shared" common bits, while the ucrt is more "platform" specific bits. But really, the point is: supporting an older version with a newer compiler is what doing this

Re: [PATCH] D11859: Generating vptr assume loads

Prazek marked an inline comment as done. Comment at: lib/CodeGen/CGClass.cpp:1832 @@ +1831,3 @@ + // Generate vtable assumptions if we are calling dynamic class ctor + // and we are not in another ctor. + if (CGM.getCodeGenOpts().OptimizationLevel > 0 && rsmith

r244998 - unique_ptrify ConsumedBlockInfo analysis to make it move assignable

Author: dblaikie Date: Thu Aug 13 20:26:19 2015 New Revision: 244998 URL: http://llvm.org/viewvc/llvm-project?rev=244998&view=rev Log: unique_ptrify ConsumedBlockInfo analysis to make it move assignable ConsumedBlockInfo objects were move assigned, but only in a state where the dtor was a no-op a

Re: [PATCH] D11859: Generating vptr assume loads

Prazek marked 5 inline comments as done. Prazek added a comment. http://reviews.llvm.org/D11859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11832: [Patch] [Analyzer] false positive: Potential leak connected with memcpy (PR 22954)

dcoughlin added a comment. I'm still looking at this. Higher-level comments coming soon. Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1110 @@ +1109,3 @@ + assert(RO.getOffset() >= 0 && "Offset should not be negative"); + uint64_t LowerOffset = RO.getOffset(); +

Re: [PATCH] D11859: Generating vptr assume loads

rsmith added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1832 @@ +1831,3 @@ + // Generate vtable assumptions if we are calling dynamic class ctor + // and we are not in another ctor. + if (CGM.getCodeGenOpts().OptimizationLevel > 0 && Prazek wrote: > h

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

> > > > Apologies, I'm really resistant to more things being used in > > TargetOptions and I was (perhaps mistakenly) under the impression > > that you wanted to move it to TargetOptions without an IR > > serialization. We need all options to have that sort of > > serialization right? :) > > Absolu

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

Perhaps the comments I left weren't very clear, but the plan was to add a subtarget feature to all targets for now and remove it later when we add support for "generic" subtarget features, which I believe will be something that will belong to TargetSubtargetInfo (Eric has probably spent more time t

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

- Original Message - > From: "Eric Christopher" > To: reviews+d11815+public+324fadcdaae02...@reviews.llvm.org, > ahata...@gmail.com, dexonsm...@apple.com, > hfin...@anl.gov > Cc: cfe-commits@lists.llvm.org > Sent: Thursday, August 13, 2015 7:39:53 PM > Subject: Re: [PATCH] D11815: Pass su

Re: [PATCH] D11859: Generating vptr assume loads

Prazek added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1832 @@ +1831,3 @@ + // Generate vtable assumptions if we are calling dynamic class ctor + // and we are not in another ctor. + if (CGM.getCodeGenOpts().OptimizationLevel > 0 && hfinkel wrote: >

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

On Thu, Aug 13, 2015 at 5:16 PM hfin...@anl.gov wrote: > hfinkel added a comment. > > In http://reviews.llvm.org/D11815#224169, @echristo wrote: > > > No, RESET_OPTION isn't the right way to do this either. For exactly this > sort of reason. You can't actually represent all of the code and option

r244991 - This test was still failing for me after r244925, fix it harder.

Author: rsmith Date: Thu Aug 13 19:16:05 2015 New Revision: 244991 URL: http://llvm.org/viewvc/llvm-project?rev=244991&view=rev Log: This test was still failing for me after r244925, fix it harder. Modified: cfe/trunk/test/CodeGenCXX/new.cpp Modified: cfe/trunk/test/CodeGenCXX/new.cpp URL:

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

hfinkel added a comment. In http://reviews.llvm.org/D11815#224169, @echristo wrote: > No, RESET_OPTION isn't the right way to do this either. For exactly this sort > of reason. You can't actually represent all of the code and options this way > in the IR. If you can't do that then it's a non-st

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

echristo added a comment. No, RESET_OPTION isn't the right way to do this either. For exactly this sort of reason. You can't actually represent all of the code and options this way in the IR. If you can't do that then it's a non-starter. -eric http://reviews.llvm.org/D11815 ___

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

hfinkel added a comment. In http://reviews.llvm.org/D11815#224161, @echristo wrote: > Hi Hal, > > No, TargetOptions is exactly the wrong place to handle this due to wanting to > have various functions compiled with and without a force aligned stack at the > IR level that might not hold up at LT

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

echristo added a comment. Hi Hal, No, TargetOptions is exactly the wrong place to handle this due to wanting to have various functions compiled with and without a force aligned stack at the IR level that might not hold up at LTO time. -eric http://reviews.llvm.org/D11815 _

Re: r244923 - [modules] Change the way we deal with .d output for explicitly-specified module

On Thu, Aug 13, 2015 at 10:57 AM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Thu Aug 13 12:57:10 2015 > New Revision: 244923 > > URL: http://llvm.org/viewvc/llvm-project?rev=244923&view=rev > Log: > [modules] Change the way we deal with .d output fo

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

hfinkel added a subscriber: hfinkel. hfinkel requested changes to this revision. hfinkel added a reviewer: hfinkel. hfinkel added a comment. This revision now requires changes to proceed. As I've said in the review for http://reviews.llvm.org/D11814, this should be added to TargetOptions, and con

Re: r244912 - [Modules] Add Darwin-specific compatibility module map parsing hacks

On Thu, Aug 13, 2015 at 4:47 PM, Ben Langmuir wrote: > Yep, that should be it! > Great! -- Sean Silva > > On Aug 13, 2015, at 4:45 PM, Sean Silva wrote: > > This was the last thing blocking http://reviews.llvm.org/D10423 on your > side, right? > > -- Sean Silva > > On Thu, Aug 13, 2015 at 10

Re: [PATCH] D12002: Initial WebAssembly support in clang

sunfish marked 2 inline comments as done. Comment at: lib/Basic/Targets.cpp:6935 @@ +6934,3 @@ + +public: + explicit WebAssemblyTargetInfo(const llvm::Triple &T) : TargetInfo(T) { I've now removed this (for now; we can discuss what to do in a later patch). Repo

r244990 - Wdeprecated: ByrefHelpers are copy constructed by the ::buildByrefHelpers helper, make sure they're safely copyable

Author: dblaikie Date: Thu Aug 13 18:53:09 2015 New Revision: 244990 URL: http://llvm.org/viewvc/llvm-project?rev=244990&view=rev Log: Wdeprecated: ByrefHelpers are copy constructed by the ::buildByrefHelpers helper, make sure they're safely copyable Make the copy/move ctors protected and defaul

Re: [PATCH] D11629: APValues and Constants and MaterializedTemporaryExpr need to have stable maps

This revision was automatically updated to reflect the committed changes. Closed by commit rL244989: Avoid iteration invalidation issues around MaterializedTemporaryExpr (authored by majnemer). Changed prior to commit: http://reviews.llvm.org/D11629?vs=32106&id=32111#toc Repository: rL LLVM

r244989 - Avoid iteration invalidation issues around MaterializedTemporaryExpr

Author: majnemer Date: Thu Aug 13 18:50:15 2015 New Revision: 244989 URL: http://llvm.org/viewvc/llvm-project?rev=244989&view=rev Log: Avoid iteration invalidation issues around MaterializedTemporaryExpr We risk iterator invalidation issues if we use a DenseMap to hold the backing storage for an

r244988 - [modules] When writing a module file built with -fmodule-map-file-home-is-cwd,

Author: rsmith Date: Thu Aug 13 18:47:44 2015 New Revision: 244988 URL: http://llvm.org/viewvc/llvm-project?rev=244988&view=rev Log: [modules] When writing a module file built with -fmodule-map-file-home-is-cwd, via a module map found by -fmodule-map-file=, the home directory of the module is the

Re: r244912 - [Modules] Add Darwin-specific compatibility module map parsing hacks

Yep, that should be it! > On Aug 13, 2015, at 4:45 PM, Sean Silva wrote: > > This was the last thing blocking http://reviews.llvm.org/D10423 > on your side, right? > > -- Sean Silva > > On Thu, Aug 13, 2015 at 10:13 AM, Ben Langmuir via cfe-commits > mailto:c

Re: r244961 - [SPARC] Fix types of size_t, intptr_t, and ptrdiff_t on OpenBSD.

On 08/13/15 18:01, Hans Wennborg wrote: On Thu, Aug 13, 2015 at 2:45 PM, Brad Smith via cfe-commits wrote: Author: brad Date: Thu Aug 13 16:45:57 2015 New Revision: 244961 URL: http://llvm.org/viewvc/llvm-project?rev=244961&view=rev Log: [SPARC] Fix types of size_t, intptr_t, and ptrdiff_t on

Re: r244912 - [Modules] Add Darwin-specific compatibility module map parsing hacks

This was the last thing blocking http://reviews.llvm.org/D10423 on your side, right? -- Sean Silva On Thu, Aug 13, 2015 at 10:13 AM, Ben Langmuir via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: benlangmuir > Date: Thu Aug 13 12:13:33 2015 > New Revision: 244912 > > URL: http://llv

[libclc] r244987 - Remove files accidentally not removed in r244310

Author: jketema Date: Thu Aug 13 18:43:12 2015 New Revision: 244987 URL: http://llvm.org/viewvc/llvm-project?rev=244987&view=rev Log: Remove files accidentally not removed in r244310 Removed: libclc/trunk/generic/lib/LLVM3.6/ libclc/trunk/generic/lib/SOURCES_LLVM3.6 Removed: libclc/trunk

Re: r244912 - [Modules] Add Darwin-specific compatibility module map parsing hacks

This was the last thing blocking http://reviews.llvm.org/D10423, right? -- Sean Silva On Thu, Aug 13, 2015 at 10:13 AM, Ben Langmuir via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: benlangmuir > Date: Thu Aug 13 12:13:33 2015 > New Revision: 244912 > > URL: http://llvm.org/viewvc/

Re: [PATCH] D11859: Generating vptr assume loads

hfinkel added a subscriber: hfinkel. Comment at: lib/CodeGen/CGClass.cpp:1832 @@ +1831,3 @@ + // Generate vtable assumptions if we are calling dynamic class ctor + // and we are not in another ctor. + if (CGM.getCodeGenOpts().OptimizationLevel > 0 && I think th

Re: [PATCH] D12002: Initial WebAssembly support in clang

sunfish updated this revision to Diff 32109. sunfish added a comment. - use more default values in WebAssemblyTargetInfo etc. - add a comment about using ARM-C++-ABI-style guard variables (for now) - fix diff to include context for Phabricator Repository: rL LLVM http://reviews.llvm.org/D1200

r244986 - Wdeprecated: Ensure CheckNames are copy assignable (used in setCurrentCheckName) by removing the unnecessary copy ctor

Author: dblaikie Date: Thu Aug 13 18:38:46 2015 New Revision: 244986 URL: http://llvm.org/viewvc/llvm-project?rev=244986&view=rev Log: Wdeprecated: Ensure CheckNames are copy assignable (used in setCurrentCheckName) by removing the unnecessary copy ctor Modified: cfe/trunk/include/clang/Stat

r244985 - Remove test cases, which rely on the default sanitizer blacklists.

Author: krasin Date: Thu Aug 13 18:37:28 2015 New Revision: 244985 URL: http://llvm.org/viewvc/llvm-project?rev=244985&view=rev Log: Remove test cases, which rely on the default sanitizer blacklists. Summary: The default blacklists may vary across different architectures and configurations. It wa

Re: [PATCH] D12021: Remove test cases, which rely on the default sanitizer blacklists.

pcc accepted this revision. pcc added a reviewer: pcc. pcc added a comment. This revision is now accepted and ready to land. LGTM Yes, this can be a separate driver test. http://reviews.llvm.org/D12021 ___ cfe-commits mailing list cfe-commits@lists

Re: [PATCH] D12021: Remove test cases, which rely on the default sanitizer blacklists.

krasin added a comment. In http://reviews.llvm.org/D12021#224102, @pcc wrote: > You could create a fake resource directory which contains only the > `asan_blacklist.txt` file. See `test/Driver/Inputs/resource_dir` for an > example of this kind of thing. I believe it's unnecessary. The default

Re: [PATCH] D12021: Remove test cases, which rely on the default sanitizer blacklists.

pcc added a comment. You could create a fake resource directory which contains only the `asan_blacklist.txt` file. See `test/Driver/Inputs/resource_dir` for an example of this kind of thing. http://reviews.llvm.org/D12021 ___ cfe-commits mailing l

Re: [PATCH] D11629: APValues and Constants and MaterializedTemporaryExpr need to have stable maps

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D11629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: r244867 - Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

I have created http://reviews.llvm.org/D12021, please take a look. On Thu, Aug 13, 2015 at 4:13 PM, Ivan Krasin wrote: > Hi there, > > I will remove both test cases, which rely on the existence of the default > blacklist. It's handled by the driver anyway, and the code I changed is in > the fron

[PATCH] D12021: Remove test cases, which rely on the default sanitizer blacklists.The default blacklists may vary across different architectures andconfigurations. It was not wise to include into http

krasin created this revision. krasin added a reviewer: chapuni. krasin added subscribers: pcc, cfe-commits. http://reviews.llvm.org/D12021 Files: test/Frontend/dependency-gen.c Index: test/Frontend/dependency-gen.c === --- test/Fr

Re: [PATCH] D11629: APValues and Constants and MaterializedTemporaryExpr need to have stable maps

majnemer updated this revision to Diff 32106. majnemer added a comment. - Address Richard's latest review comments. http://reviews.llvm.org/D11629 Files: include/clang/AST/ASTContext.h lib/AST/ASTContext.cpp lib/CodeGen/CodeGenModule.cpp test/CodeGenCXX/PR24289.cpp Index: test/CodeGenC

r244983 - Wdeprecated: Make Filter safely move constructible.

Author: dblaikie Date: Thu Aug 13 18:15:20 2015 New Revision: 244983 URL: http://llvm.org/viewvc/llvm-project?rev=244983&view=rev Log: Wdeprecated: Make Filter safely move constructible. makeFilter returns Filters by value which seems to be only safe when the copy doesn't occur and RVO kicks in.

Re: r244867 - Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

Hi there, I will remove both test cases, which rely on the existence of the default blacklist. It's handled by the driver anyway, and the code I changed is in the frontend; at this point, there's no such a thing, as a default blacklist, all of them are explicit. Just a sec. krasin On Thu, Aug 13

r244981 - Wdeprecated: Make the SecKeychainBugVisitor copyable (for the clone support in the CRTP base) my removing the user-declared dtor

Author: dblaikie Date: Thu Aug 13 18:09:18 2015 New Revision: 244981 URL: http://llvm.org/viewvc/llvm-project?rev=244981&view=rev Log: Wdeprecated: Make the SecKeychainBugVisitor copyable (for the clone support in the CRTP base) my removing the user-declared dtor The implicit dtor is just as goo

Re: r244867 - Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

Tweaked a test in r244970. Could you split it out if you would like to run it for the default target? On Fri, Aug 14, 2015 at 5:07 AM Ivan Krasin via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Thank you, Yaron. Understood. > > On Thu, Aug 13, 2015 at 11:04 AM, Yaron Keren > wrote: > >> Th

r244980 - Fix the MSVC build which cannot manifest default move ops

Author: dblaikie Date: Thu Aug 13 18:05:58 2015 New Revision: 244980 URL: http://llvm.org/viewvc/llvm-project?rev=244980&view=rev Log: Fix the MSVC build which cannot manifest default move ops Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitor.h Modified: c

r244978 - Follow up r244975: The ctors of an abstract class don't need to be protected - the object isn't directly constructible/doesn't present a slicing risk

Author: dblaikie Date: Thu Aug 13 17:58:35 2015 New Revision: 244978 URL: http://llvm.org/viewvc/llvm-project?rev=244978&view=rev Log: Follow up r244975: The ctors of an abstract class don't need to be protected - the object isn't directly constructible/doesn't present a slicing risk Modified:

r244979 - Wdeprecated: BugReporterVisitors are copied for cloning (BugReporterVisitorImpl), make sure such copies are safe

Author: dblaikie Date: Thu Aug 13 17:58:37 2015 New Revision: 244979 URL: http://llvm.org/viewvc/llvm-project?rev=244979&view=rev Log: Wdeprecated: BugReporterVisitors are copied for cloning (BugReporterVisitorImpl), make sure such copies are safe Make the copy/move ctors defaulted in the base c

Re: [PATCH] D11629: APValues and Constants and MaterializedTemporaryExpr need to have stable maps

rsmith added inline comments. Comment at: lib/AST/ASTContext.cpp:8557 @@ +8556,3 @@ + if (MayCreate) { +auto *MTVI = &MaterializedTemporaryValues[E]; +if (*MTVI == nullptr) { Maybe use a reference here rather than a pointer. Comment at:

Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

kulpreet updated this revision to Diff 32102. kulpreet added a comment. Fixed memory corruption bug with temporary std::string - found with address sanitizer. Now, all regression tests pass with MallocScribble on. http://reviews.llvm.org/D11572 Files: lib/StaticAnalyzer/Checkers/CMakeLists.

r244975 - Wdeprecated: CollectReachableSymbolsCallback are move constructed/returned by value, so make sure they're copy/moveable

Author: dblaikie Date: Thu Aug 13 17:50:09 2015 New Revision: 244975 URL: http://llvm.org/viewvc/llvm-project?rev=244975&view=rev Log: Wdeprecated: CollectReachableSymbolsCallback are move constructed/returned by value, so make sure they're copy/moveable (return by value is in ExprEngine::proces

Re: [PATCH] D11629: APValues and Constants and MaterializedTemporaryExpr need to have stable maps

majnemer updated this revision to Diff 32100. majnemer added a comment. - Address Justin's review comments. - Address Richard's review comments. http://reviews.llvm.org/D11629 Files: include/clang/AST/ASTContext.h lib/AST/ASTContext.cpp lib/CodeGen/CodeGenModule.h test/CodeGenCXX/PR2428

r244974 - Wdeprecated: RegionBindingsRef are copy constructed, make sure that's safe by removing the unnecessary user-declared copy assignment operator

Author: dblaikie Date: Thu Aug 13 17:33:24 2015 New Revision: 244974 URL: http://llvm.org/viewvc/llvm-project?rev=244974&view=rev Log: Wdeprecated: RegionBindingsRef are copy constructed, make sure that's safe by removing the unnecessary user-declared copy assignment operator The user-defined co

Re: [PATCH] D10365: Add cmd to compilation database file format

diltsman updated this revision to Diff 32099. diltsman marked an inline comment as done. diltsman added a comment. Added test for command and arguments in same object. Fixed bug where parse failed if command and argument resolved to empty lists. http://reviews.llvm.org/D10365 Files: ../llvm/t

r244973 - Wdeprecated: PathPieces are copied, make them safely implicitly copyable by removing the unnecessary user declared dtor.

Author: dblaikie Date: Thu Aug 13 17:23:53 2015 New Revision: 244973 URL: http://llvm.org/viewvc/llvm-project?rev=244973&view=rev Log: Wdeprecated: PathPieces are copied, make them safely implicitly copyable by removing the unnecessary user declared dtor. Modified: cfe/trunk/include/clang/St

r244971 - Wdeprecated: StoredDiagnostics are stored in a SmallVector, so make sure they're copy/movable

Author: dblaikie Date: Thu Aug 13 17:20:14 2015 New Revision: 244971 URL: http://llvm.org/viewvc/llvm-project?rev=244971&view=rev Log: Wdeprecated: StoredDiagnostics are stored in a SmallVector, so make sure they're copy/movable Removing the no-op dtor makes these objects safely implicitly copya

r244970 - clang/test/Frontend/dependency-gen.c: Add explicit -target x86_64-linux-gnu for -fsanitize.

Author: chapuni Date: Thu Aug 13 17:17:34 2015 New Revision: 244970 URL: http://llvm.org/viewvc/llvm-project?rev=244970&view=rev Log: clang/test/Frontend/dependency-gen.c: Add explicit -target x86_64-linux-gnu for -fsanitize. Modified: cfe/trunk/test/Frontend/dependency-gen.c Modified: cfe/

r244968 - Wdeprecated: Make BumpVectorContext movable

Author: dblaikie Date: Thu Aug 13 17:12:21 2015 New Revision: 244968 URL: http://llvm.org/viewvc/llvm-project?rev=244968&view=rev Log: Wdeprecated: Make BumpVectorContext movable Turns out the one place that relied on the implicit copy ctor was safe because it created an object in a state where t

Re: [PATCH] D11629: APValues and Constants and MaterializedTemporaryExpr need to have stable maps

rsmith added inline comments. Comment at: include/clang/AST/ASTContext.h:180 @@ -179,3 +179,3 @@ /// that appear in constant initializers to their evaluated values. - llvm::DenseMap + std::map MaterializedTemporaryValues; I would prefer a `DenseMap`, wit

Re: [PATCH] D11629: APValues and Constants and MaterializedTemporaryExpr need to have stable maps

On Thu, Aug 13, 2015 at 5:15 PM, Justin Bogner wrote: > David Majnemer writes: > > majnemer created this revision. > > majnemer added a reviewer: rsmith. > > majnemer added a subscriber: cfe-commits. > > > > We risk iterator invalidation issues if we use DenseMap structures for > > MaterializedT

r244962 - Removed one too many braces.

Author: brad Date: Thu Aug 13 17:00:53 2015 New Revision: 244962 URL: http://llvm.org/viewvc/llvm-project?rev=244962&view=rev Log: Removed one too many braces. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/tr

Re: r244961 - [SPARC] Fix types of size_t, intptr_t, and ptrdiff_t on OpenBSD.

On Thu, Aug 13, 2015 at 2:45 PM, Brad Smith via cfe-commits wrote: > Author: brad > Date: Thu Aug 13 16:45:57 2015 > New Revision: 244961 > > URL: http://llvm.org/viewvc/llvm-project?rev=244961&view=rev > Log: > [SPARC] Fix types of size_t, intptr_t, and ptrdiff_t on OpenBSD. > > Modified: > c

r244961 - [SPARC] Fix types of size_t, intptr_t, and ptrdiff_t on OpenBSD.

Author: brad Date: Thu Aug 13 16:45:57 2015 New Revision: 244961 URL: http://llvm.org/viewvc/llvm-project?rev=244961&view=rev Log: [SPARC] Fix types of size_t, intptr_t, and ptrdiff_t on OpenBSD. Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/test/Preprocessor/init.c Modified: cfe/t

r244959 - Fix some coding standard issues and delete a dead conditional.

Author: echristo Date: Thu Aug 13 16:34:35 2015 New Revision: 244959 URL: http://llvm.org/viewvc/llvm-project?rev=244959&view=rev Log: Fix some coding standard issues and delete a dead conditional. Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp UR

r244958 - Wdeprecated: CommentVerifiers are returned by value, make sure they're correctly copy/moveable

Author: dblaikie Date: Thu Aug 13 16:24:08 2015 New Revision: 244958 URL: http://llvm.org/viewvc/llvm-project?rev=244958&view=rev Log: Wdeprecated: CommentVerifiers are returned by value, make sure they're correctly copy/moveable Modified: cfe/trunk/unittests/Tooling/CommentHandlerTest.cpp

r244957 - Wdeprecated: LambdaScopeInfos are copied in TreeTransform, so make sure they're copyable.

Author: dblaikie Date: Thu Aug 13 16:23:08 2015 New Revision: 244957 URL: http://llvm.org/viewvc/llvm-project?rev=244957&view=rev Log: Wdeprecated: LambdaScopeInfos are copied in TreeTransform, so make sure they're copyable. Partly addressed by r244843, but the explicit dtor in LambdaScopeInfo w

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

chandlerc added a comment. I agree with both Marshall and Hal. However, I'm also not opposed to platforms opting out if this if they want to. If a particular platform wants to define the behavior of null pointers passed to these functions, that seems like a reasonable thing to support here. The

r244956 - Wdeprecated: Replace deprecated throw() with LLVM_NOEXCEPT which expands to 'noexcept' where available (and throw() otherwise)

Author: dblaikie Date: Thu Aug 13 16:15:23 2015 New Revision: 244956 URL: http://llvm.org/viewvc/llvm-project?rev=244956&view=rev Log: Wdeprecated: Replace deprecated throw() with LLVM_NOEXCEPT which expands to 'noexcept' where available (and throw() otherwise) Modified: cfe/trunk/include/cl

Re: [PATCH] D11629: APValues and Constants and MaterializedTemporaryExpr need to have stable maps

David Majnemer writes: > majnemer created this revision. > majnemer added a reviewer: rsmith. > majnemer added a subscriber: cfe-commits. > > We risk iterator invalidation issues if we use DenseMap structures for > MaterializedTemporaryExprs. Use a std::map to ensure that they don't > move around

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

On Thu, Aug 13, 2015 at 4:53 PM, Stephen Hines via cfe-commits wrote: > I don't see anywhere in the C standard that says that a memcpy() with NULL > for either pointer is UB (which would only be valid for the case where n == > 0). This seems like a particularly aggressive (mis)optimization in the

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

I don't see anywhere in the C standard that says that a memcpy() with NULL for either pointer is UB (which would only be valid for the case where n == 0). This seems like a particularly aggressive (mis)optimization in the general case. It should only be acceptable if the length is guaranteed to be

Re: [PATCH] RE: [cfe-dev] missing return statement for non-void functions in C++

Please make such programs crash early and often. They are a nightmare to maintain. Make them blow in the face of the original authors; not after they are gone. -- Gaby On Thu, Aug 13, 2015 at 11:18 AM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, Aug 13, 2015 at

Re: [PATCH] D11948: Add some macros to abstract marking of parameters as "not null", and use them in

Because we consider the fact that clang and gcc do this when those functions are not marked with nonnull by the libc to be a bug. Adding it to libc++ would just make another place that we have to fix that bug. What is the objection to using _Nullable instead of __attribute__(nonnull)? The original

Re: r244867 - Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

Thank you, Yaron. Understood. On Thu, Aug 13, 2015 at 11:04 AM, Yaron Keren wrote: > There is great variety of OSs, compilers, configs in the bots. You can't > get the smae with try bots unless everything is duplicated which is a > waste. You test locally, commit, watch the bots here: > > http:

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

sepavloff updated this revision to Diff 32085. sepavloff added a comment. Updated patch Thanks to all for fruitful discussion! The new version tries to addresses review notes. It differs from the previous version in: - Method tryParseMisplacedModuleImport now depends only on current token and

Re: [PATCH] D10365: Add cmd to compilation database file format

diltsman added a comment. Where/how does documentation (http://clang.llvm.org/docs/JSONCompilationDatabase.html) get updated? http://reviews.llvm.org/D10365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

Re: [PATCH] D12017: Fix IncludeInserter/IncludeSorter bug.

klimek added a comment. Please add a regression test. http://reviews.llvm.org/D12017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r244933 - Fix previous commit: poison only class members, simpler tests

Author: nmusgrave Date: Thu Aug 13 13:35:11 2015 New Revision: 244933 URL: http://llvm.org/viewvc/llvm-project?rev=244933&view=rev Log: Fix previous commit: poison only class members, simpler tests Summary: Poisoning applied to only class members, and before dtors for base class invoked Impleme

Re: [PATCH] D10365: Add cmd to compilation database file format

klimek accepted this revision. klimek added a reviewer: klimek. klimek added a comment. This revision is now accepted and ready to land. LG with a happy path test. Comment at: ../llvm/tools/clang/unittests/Tooling/CompilationDatabaseTest.cpp:45 @@ -41,1 +44,3 @@ + expectFailure

r244931 - [modules] For explicit module file dependencies, only list direct dependency module files.

Author: rsmith Date: Thu Aug 13 13:30:25 2015 New Revision: 244931 URL: http://llvm.org/viewvc/llvm-project?rev=244931&view=rev Log: [modules] For explicit module file dependencies, only list direct dependency module files. Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp cfe/trun

Re: [PATCH] RE: [cfe-dev] missing return statement for non-void functions in C++

On Thu, Aug 13, 2015 at 1:52 AM, Sjoerd Meijer wrote: > Hi Richard, > > Thanks for reviewing. Agree, that was a bit confusing. More specifically, > > the warning message was confusing (i.e. wrong). This patch is for > compiling .c > > input in C++ mode. The new flag should be ignored for C++ **in

Re: r244926 - Try to fix the build after r244923

On Thu, Aug 13, 2015 at 11:10 AM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Thu Aug 13 13:10:34 2015 > New Revision: 244926 > > URL: http://llvm.org/viewvc/llvm-project?rev=244926&view=rev > Log: > Try to fix the build after r244923 > Thanks! I thoug

r244927 - Fix wrong expected test output in r244923.

Author: rsmith Date: Thu Aug 13 13:11:20 2015 New Revision: 244927 URL: http://llvm.org/viewvc/llvm-project?rev=244927&view=rev Log: Fix wrong expected test output in r244923. Modified: cfe/trunk/test/Modules/dependency-gen.modulemap Modified: cfe/trunk/test/Modules/dependency-gen.modulemap

r244928 - Remove and forbid raw_svector_ostream::flush() calls.

Author: yrnkrn Date: Thu Aug 13 13:12:56 2015 New Revision: 244928 URL: http://llvm.org/viewvc/llvm-project?rev=244928&view=rev Log: Remove and forbid raw_svector_ostream::flush() calls. After r244870 flush() will only compare two null pointers and return, doing nothing but wasting run time. The c

Re: [PATCH] D11859: Generating vptr assume loads

rsmith added inline comments. Comment at: lib/CodeGen/CGCXXABI.h:349-357 @@ -348,1 +348,11 @@ + virtual bool + isVirtualOffsetNeededForVTableField(CodeGenFunction &CGF, + const CXXRecordDecl *NearestVBase) = 0; + + virtual bool canInitiali

r244925 - Try to fix new.cpp after r244920 to make it pass

Author: rnk Date: Thu Aug 13 13:10:32 2015 New Revision: 244925 URL: http://llvm.org/viewvc/llvm-project?rev=244925&view=rev Log: Try to fix new.cpp after r244920 to make it pass Modified: cfe/trunk/test/CodeGenCXX/new.cpp Modified: cfe/trunk/test/CodeGenCXX/new.cpp URL: http://llvm.org/vie

r244926 - Try to fix the build after r244923

Author: rnk Date: Thu Aug 13 13:10:34 2015 New Revision: 244926 URL: http://llvm.org/viewvc/llvm-project?rev=244926&view=rev Log: Try to fix the build after r244923 Modified: cfe/trunk/lib/Frontend/DependencyFile.cpp Modified: cfe/trunk/lib/Frontend/DependencyFile.cpp URL: http://llvm.org/v

Re: r244867 - Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

There is great variety of OSs, compilers, configs in the bots. You can't get the smae with try bots unless everything is duplicated which is a waste. You test locally, commit, watch the bots here: http://lab.llvm.org:8011/grid or wait for buildbot failure e-mails which arrive a bit slower. Break

r244922 - Turn off __has_feature(cxx_rtti) when -fno-rtti-data is present

Author: rnk Date: Thu Aug 13 12:56:49 2015 New Revision: 244922 URL: http://llvm.org/viewvc/llvm-project?rev=244922&view=rev Log: Turn off __has_feature(cxx_rtti) when -fno-rtti-data is present -fno-rtti-data makes it so that vtables emitted in the current TU lack RTTI data. This means that dynam

r244923 - [modules] Change the way we deal with .d output for explicitly-specified module

Author: rsmith Date: Thu Aug 13 12:57:10 2015 New Revision: 244923 URL: http://llvm.org/viewvc/llvm-project?rev=244923&view=rev Log: [modules] Change the way we deal with .d output for explicitly-specified module files: include the .pcm file itself in the .d output, rather than including its own i

Re: [PATCH] D10365: Add cmd to compilation database file format

diltsman updated this revision to Diff 32082. diltsman marked an inline comment as done. diltsman added a comment. Arguments and Command can now be in the same compilation database for the same file. Arguments are preferred when both are present. http://reviews.llvm.org/D10365 Files: ../llv

  1   2   >