Re: r353590 - This reverts commit 1440a848a635849b97f7a5cfa0ecc40d37451f5b.

On Sat, Feb 9, 2019 at 3:45 AM Mikhail R. Gadelha via cfe-commits wrote: > > Author: mramalho > Date: Fri Feb 8 16:46:12 2019 > New Revision: 353590 > > URL: http://llvm.org/viewvc/llvm-project?rev=353590=rev > Log: > This reverts commit 1440a848a635849b97f7a5cfa0ecc40d37451f5b. > and commit

[PATCH] D57896: Variable names rule

zturner added a comment. Is this actually any better? Whereas before we can’t differentiate type names and variable names, under this proposal we can’t differentiate type names and function names. So it seems a bit of “6 of 1, half dozen of another” Repository: rG LLVM Github Monorepo

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added inline comments. Comment at: lib/Driver/ToolChains/WebAssembly.cpp:29 + Pthread = + DriverArgs.hasFlag(options::OPT_pthread, options::OPT_no_pthread, false); + ThreadModel = aheejin wrote: > tlively wrote: > > Shouldn't every use of

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57532/new/ https://reviews.llvm.org/D57532

[PATCH] D57930: [Driver] Verify GCCInstallation is valid

tstellar added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:259-260 if (GCCInstallation.getParentLibPath().find("opt/rh/devtoolset") != StringRef::npos) // With devtoolset on RHEL, we want to add a bin directory that is relative

[PATCH] D57207: [clang-tidy] Make google-objc-function-naming ignore implicit functions 

stephanemoore marked an inline comment as done. stephanemoore added inline comments. Comment at: test/clang-tidy/google-objc-function-naming.m:3 +#import + aaron.ballman wrote: > stephanemoore wrote: > > It turns out importing is problematic and breaks the

r353599 - [StaticAnalyzer] Add missing include to SMTAPI.h. [NFC]

Author: dlj Date: Fri Feb 8 18:41:55 2019 New Revision: 353599 URL: http://llvm.org/viewvc/llvm-project?rev=353599=rev Log: [StaticAnalyzer] Add missing include to SMTAPI.h. [NFC] This include is needed for types within SMTAPI.h. (It's very possible that compilation would succeed without it,

[PATCH] D57860: [analyzer] Validate checker option names and values

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. > (already in the works!) Document the frontend of the analyzer, sneak peak > here. Whoa!! *celebrates the graphomania epidemic* Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I think this is awesome! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___

Re: r353590 - This reverts commit 1440a848a635849b97f7a5cfa0ecc40d37451f5b.

I was gonna point to the directions for using llvm/utils/git-svn/git-svnrevert, but it looks like that script only works with git svn and not with the git monorepo. James, was updating the revert script something on your roadmap? If not, I'd be happy to take a stab at it (and I'm wondering if

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin marked 4 inline comments as done. aheejin added inline comments. Comment at: lib/Driver/ToolChains/WebAssembly.cpp:29 + Pthread = + DriverArgs.hasFlag(options::OPT_pthread, options::OPT_no_pthread, false); + ThreadModel = tlively wrote: >

RE: r353569 - [Sema] Make string literal init an rvalue.

Fixed in r353598. -Eli > -Original Message- > From: cfe-commits On Behalf Of Eli > Friedman via cfe-commits > Sent: Friday, February 8, 2019 6:06 PM > To: douglas.y...@sony.com > Cc: cfe-commits@lists.llvm.org > Subject: [EXT] RE: r353569 - [Sema] Make string literal init an rvalue. >

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin updated this revision to Diff 186093. aheejin added a comment. - Address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 Files: include/clang/Driver/Options.td include/clang/Driver/ToolChain.h

r353598 - Fix buildbot failure from r353569.

Author: efriedma Date: Fri Feb 8 18:22:17 2019 New Revision: 353598 URL: http://llvm.org/viewvc/llvm-project?rev=353598=rev Log: Fix buildbot failure from r353569. I assumed lvalue-to-rvalue conversions of array type would never happen, but apparently clang-tidy tries in some cases. Modified:

[PATCH] D57850: [analyzer] Emit an error rather than assert on invalid checker option input

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks cool, thanks!! Comment at: include/clang/Basic/DiagnosticDriverKinds.td:304-305 def err_analyzer_config_unknown : Error<"unknown analyzer-config '%0'">; +def

RE: r353569 - [Sema] Make string literal init an rvalue.

Looking. It looks like this only fails with clang-tidy, so I'll give myself a few minutes to look before reverting. -Eli > -Original Message- > From: douglas.y...@sony.com > Sent: Friday, February 8, 2019 3:58 PM > To: Eli Friedman > Cc: cfe-commits@lists.llvm.org > Subject: [EXT]

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added inline comments. Comment at: lib/Driver/ToolChains/WebAssembly.cpp:29 + Pthread = + DriverArgs.hasFlag(options::OPT_pthread, options::OPT_no_pthread, false); + ThreadModel = Shouldn't every use of `hasFlag` be `getLastArgValue` instead?

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin added a comment. In D57874#1389981 , @sunfish wrote: > > - `-matomics` means `-mthread-model posix` > > The others sound reasonable, though this one seems a little surprising -- a > user might have -matomics enabled because they're targeting a VM

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin updated this revision to Diff 186090. aheejin added a comment. - Replace -matomics with -mthread-model posix in preprocessor test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 Files:

[PATCH] D57991: [Driver][Darwin] Emit an error when using -pg on OS without support for it.

vsapsai created this revision. vsapsai added reviewers: dexonsmith, bob.wilson, steven_wu. Herald added a subscriber: jkorous. Instead of letting a program fail at runtime, emit an error during compilation. rdar://problem/12206955 https://reviews.llvm.org/D57991 Files:

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin updated this revision to Diff 186088. aheejin marked 8 inline comments as done. aheejin added a comment. I had an offline discussion with @tlively and @dschuff and decided to remove `-atomics` option in the driver. Instead, `clang -cc1`'s `-target-feature +atomics` will be either of

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

ahatanak added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2953 + "have bases of non-trivial class types|have virtual bases|" + "have __weak fields under ARC|have fields of non-trivial class types}0">; Quuxplusone wrote: >

[PATCH] D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted

ahatanak updated this revision to Diff 186083. ahatanak marked 4 inline comments as done. ahatanak added a comment. Improve diagnostic messages. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57626/new/ https://reviews.llvm.org/D57626 Files:

Re: r353590 - This reverts commit 1440a848a635849b97f7a5cfa0ecc40d37451f5b.

On Fri, 8 Feb 2019 at 16:45, Mikhail R. Gadelha via cfe-commits wrote: > Author: mramalho > Date: Fri Feb 8 16:46:12 2019 > New Revision: 353590 > > URL: http://llvm.org/viewvc/llvm-project?rev=353590=rev > Log: > This reverts commit 1440a848a635849b97f7a5cfa0ecc40d37451f5b. > and commit

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added a comment. In D57874#1391384 , @aheejin wrote: > In D57874#1391133 , @tlively wrote: > > > In D57874#1389953 , @aheejin wrote: > > > > > Anyway, moved all

r353592 - [analyzer] Add a comment that FunctionCodeRegions may also need canonicalization

Author: dergachev Date: Fri Feb 8 17:00:32 2019 New Revision: 353592 URL: http://llvm.org/viewvc/llvm-project?rev=353592=rev Log: [analyzer] Add a comment that FunctionCodeRegions may also need canonicalization Modified: cfe/trunk/lib/StaticAnalyzer/Core/MemRegion.cpp Modified:

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho added a comment. Hi everyone, I just saw your messages and reverted the commits. Sorry for the inconvenience, but for some reason I didn't get any email from the bots. Could you send me the link with the failure? @brzycki, I'm using Ubuntu 18.04.2 and I'll try to reproduce the

r353590 - This reverts commit 1440a848a635849b97f7a5cfa0ecc40d37451f5b.

Author: mramalho Date: Fri Feb 8 16:46:12 2019 New Revision: 353590 URL: http://llvm.org/viewvc/llvm-project?rev=353590=rev Log: This reverts commit 1440a848a635849b97f7a5cfa0ecc40d37451f5b. and commit a1853e834c65751f92521f7481b15cf0365e796b. They broke arm and aarch64 Added:

[PATCH] D57986: [ProfileData] Remove non-determinism: Change DenseMap to MapVector

mgrang added a comment. tools/llvm-profdata/instr-remap.test is failing in the reverse iteration bot. See http://lab.llvm.org:8011/builders/reverse-iteration/builds/10546/steps/check_all/logs/stdio. This is because FunctionData is iterated in InstrProfWriter to output function counts, etc.

r353588 - [AMDGPU] Split dot-insts feature

Author: rampitec Date: Fri Feb 8 16:34:41 2019 New Revision: 353588 URL: http://llvm.org/viewvc/llvm-project?rev=353588=rev Log: [AMDGPU] Split dot-insts feature Differential Revision: https://reviews.llvm.org/D57972 Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def

[PATCH] D57986: [ProfileData] Remove non-determinism: Change DenseMap to MapVector

mgrang created this revision. mgrang added reviewers: rsmith, bogner. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D57986 Files: include/llvm/ProfileData/InstrProfWriter.h Index: include/llvm/ProfileData/InstrProfWriter.h

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin added a comment. In D57874#1391133 , @tlively wrote: > In D57874#1389953 , @aheejin wrote: > > > Anyway, moved all logic to the driver layer and did this: > > > > - `-matomics` means `-mthread-model posix`

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

sbc100 added inline comments. Comment at: lib/Driver/ToolChains/WebAssembly.cpp:50 + bool HasNoPthread = + !Pthread && DriverArgs.hasArg(clang::driver::options::OPT_no_pthread); + tlively wrote: > Should this logic use `getLastArg` or perhaps

[PATCH] D57540: [C++17] Don't crash while diagnosing different access specifier of a deduction guide.

rsmith added inline comments. Comment at: test/SemaCXX/cxx1z-class-template-argument-deduction.cpp:360-361 + struct Type { +Typo(); // expected-error{{deduction guide must be declared in the same scope}} +// expected-error@-1{{deduction guide declaration without

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

sbc100 added inline comments. Comment at: lib/Driver/ToolChains/WebAssembly.cpp:66 +if (Args.hasFlag(clang::driver::options::OPT_pthread, + clang::driver::options::OPT_no_pthread), +false) aheejin wrote: > tlively wrote: > >

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added inline comments. Comment at: lib/Driver/ToolChains/WebAssembly.cpp:50 + bool HasNoPthread = + !Pthread && DriverArgs.hasArg(clang::driver::options::OPT_no_pthread); + Should this logic use `getLastArg` or perhaps `getLastArgNoClaim` to check

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin added a comment. I only added those test routines in `wasm-toolchain.c` and not `wasm-toolchain.cpp`, because they are basically the same. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin updated this revision to Diff 186068. aheejin added a comment. - Initialized ThreadModel vairables with "" Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 Files: include/clang/Driver/ToolChain.h

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin added a comment. In D57874#1389981 , @sunfish wrote: > > - `-matomics` means `-mthread-model posix` > > The others sound reasonable, though this one seems a little surprising -- a > user might have -matomics enabled because they're targeting a VM

[PATCH] D57984: PR40642: Fix determination of whether the final statement of a statementexpression is a discarded-value expression.

rsmith created this revision. rsmith added reviewers: aaron.ballman, rjmccall. Herald added a project: clang. We used to get this wrong in three ways: 1. During parsing, an expression-statement followed by the }) ending a statement expression was always treated as producing the value of the

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin updated this revision to Diff 186065. aheejin added a comment. - Small fix Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 Files: include/clang/Driver/ToolChain.h lib/Driver/Driver.cpp

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin marked an inline comment as done. aheejin added inline comments. Comment at: lib/Driver/ToolChains/WebAssembly.cpp:66 +if (Args.hasFlag(clang::driver::options::OPT_pthread, + clang::driver::options::OPT_no_pthread), +false)

[PATCH] D57981: [analyzer] strlcat() syntax check: Fix an off-by-one error.

This revision was automatically updated to reflect the committed changes. Closed by commit rL353583: [analyzer] CStringSyntaxChecks: Fix an off-by-one error in the strlcat() check. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

aheejin updated this revision to Diff 186063. aheejin added a comment. - Fix some bugs - Make the driver error out when explicitly given options don't match, such as `-no-pthread` and `-matomics` are given at the same time Repository: rC Clang CHANGES SINCE LAST ACTION

r353583 - [analyzer] CStringSyntaxChecks: Fix an off-by-one error in the strlcat() check.

Author: dergachev Date: Fri Feb 8 15:59:52 2019 New Revision: 353583 URL: http://llvm.org/viewvc/llvm-project?rev=353583=rev Log: [analyzer] CStringSyntaxChecks: Fix an off-by-one error in the strlcat() check. oth strlcat and strlcpy cut off their safe bound for the argument value at

RE: r353569 - [Sema] Make string literal init an rvalue.

Hi Eli, Your commit is causing a failure on the PS4 linux bot, can you please take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/43625 FAIL: Clang Tools :: clang-tidy/bugprone-string-constructor.cpp (14325 of 46835) TEST 'Clang

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

kzhuravl added a comment. https://github.com/llvm-mirror/clang/blob/master/lib/Driver/ToolChains/AMDGPU.cpp#L52 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977 ___

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

kzhuravl added a comment. Can you handle all features as follows instead of checking a particular option? ‘handleTargetFeaturesGroup( Args, Features, options::OPT_m_amdgpu_Features_Group);’ ? There is code in AMDGPU tool chain you can use as a reference. Repository: rC Clang CHANGES

[PATCH] D57981: [analyzer] strlcat() syntax check: Fix an off-by-one error.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57981/new/ https://reviews.llvm.org/D57981

[PATCH] D57976: -gmodules: Don't emit incomplete breadcrumbs pointing to nonexistant PCM files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL353578: -gmodules: Dont emit incomplete breadcrumbs pointing to nonexistant PCM files. (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r353578 - -gmodules: Don't emit incomplete breadcrumbs pointing to nonexistant PCM files.

Author: adrian Date: Fri Feb 8 15:15:42 2019 New Revision: 353578 URL: http://llvm.org/viewvc/llvm-project?rev=353578=rev Log: -gmodules: Don't emit incomplete breadcrumbs pointing to nonexistant PCM files. When a module name is specified as -fmodule-name, that module gets a clang::Module

[PATCH] D57976: -gmodules: Don't emit incomplete breadcrumbs pointing to nonexistant PCM files.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. This makes sense to me, just one nit. Comment at: lib/CodeGen/CGDebugInfo.cpp:2304 +assert((!M || (M->Name == CGM.getLangOpts().ModuleName)) && +

[PATCH] D57427: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects.

This revision was automatically updated to reflect the committed changes. Closed by commit rL353577: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

r353577 - [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects.

Author: vsapsai Date: Fri Feb 8 15:02:13 2019 New Revision: 353577 URL: http://llvm.org/viewvc/llvm-project?rev=353577=rev Log: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects. When we are calling `__builtin_constant_p` with ObjC objects of different classes, we

[PATCH] D57981: [analyzer] strlcat() syntax check: Fix an off-by-one error.

NoQ created this revision. NoQ added reviewers: dcoughlin, george.karpenkov, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, devnexen. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. That's a fix on top

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

Meinersbur created this revision. Meinersbur added reviewers: hfinkel, aaron.ballman, hsaito, dmgreen, anemet, rjmccall, Anastasia, pekka.jaaskelainen, meheff, tyler.nowicki. Herald added a subscriber: zzheng. Herald added a project: clang. Before this patch, CGLoop would dump all

[PATCH] D57427: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects.

ahatanak accepted this revision. ahatanak added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57427/new/ https://reviews.llvm.org/D57427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

ashi1 created this revision. ashi1 added reviewers: yaxunl, kzhuravl. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch allows the compile option -mcode-object-v3 to be set by default, unless the -mno-code-object-v3 is added to the compile options. Repository:

[PATCH] D57976: -gmodules: Don't emit incomplete breadcrumbs pointing to nonexistant PCM files.

aprantl created this revision. aprantl added reviewers: JDevlieghere, bruno. When a module name is specified as -fmodule-name, that module gets a clang::Module object, but it won't actually be built or imported; it will be textual. CGDebugInfo wouldn't detect this and them emit a DICompileUnit

[PATCH] D57966: [clang-tidy] add camelBackOrCase casing style to readability-identifier-naming to support change to variable naming policy (if adopted)

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/readability-identifier-naming.rst:30 +``camelBackOrCase`` allows for both `camelBack` or `CamelCase` cased +identifiers to be used to match prior LLVM code style Please fix double space.

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added a comment. In D57874#1390014 , @sbc100 wrote: > In D57874#1389981 , @sunfish wrote: > > > > - `-matomics` means `-mthread-model posix` > > > > The others sound reasonable, though this one seems a

[PATCH] D57427: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects.

vsapsai added a comment. In D57427#1386781 , @hans wrote: > What's the status of this patch? Is it something we should merge onto the 8.0 > release branch? Waiting on a one more review iteration from @ahatanak and hope that afterwards the patch should

r353571 - [CodeGen][NFC] Update comments in CGExprConstant.cpp.

Author: efriedma Date: Fri Feb 8 13:36:04 2019 New Revision: 353571 URL: http://llvm.org/viewvc/llvm-project?rev=353571=rev Log: [CodeGen][NFC] Update comments in CGExprConstant.cpp. Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp URL:

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added a comment. In D57874#1389953 , @aheejin wrote: > Anyway, moved all logic to the driver layer and did this: > > - `-matomics` means `-mthread-model posix` > - `-mthread-model posix` means `-matomics` > - `-pthread` means both `-matomics` and

[PATCH] D57427: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects.

vsapsai added a comment. @ahatanak, can you please take a look again? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57427/new/ https://reviews.llvm.org/D57427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57935: [Sema] Make string literal init an rvalue.

efriedma closed this revision. efriedma added a comment. https://reviews.llvm.org/rC353569 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57935/new/ https://reviews.llvm.org/D57935 ___ cfe-commits mailing list

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added a comment. In D57874#1391116 , @tlively wrote: > In D57874#1389953 , @aheejin wrote: > > > - `-matomics` means `-mthread-model posix` > > > Why should this be the case? Atomic instructions are

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added a comment. In D57874#1389953 , @aheejin wrote: > - `-matomics` means `-mthread-model posix` Why should this be the case? Atomic instructions are necessary for multithreading, but I wouldn't think multithreading would be necessary for

r353569 - [Sema] Make string literal init an rvalue.

Author: efriedma Date: Fri Feb 8 13:18:46 2019 New Revision: 353569 URL: http://llvm.org/viewvc/llvm-project?rev=353569=rev Log: [Sema] Make string literal init an rvalue. This allows substantially simplifying the expression evaluation code, because we don't have to special-case lvalues which

[PATCH] D57874: [WebAssembly] Make thread-related options consistent

tlively added inline comments. Comment at: lib/Driver/ToolChains/WebAssembly.cpp:66 +if (Args.hasFlag(clang::driver::options::OPT_pthread, + clang::driver::options::OPT_no_pthread), +false) sbc100 wrote: > aheejin wrote: > > This

r353568 - Fix typo

Author: adrian Date: Fri Feb 8 13:13:25 2019 New Revision: 353568 URL: http://llvm.org/viewvc/llvm-project?rev=353568=rev Log: Fix typo Modified: cfe/trunk/include/clang/Basic/LangOptions.h Modified: cfe/trunk/include/clang/Basic/LangOptions.h URL:

[PATCH] D57270: [ObjC] Fix non-canonical types preventing type arguments substitution.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57270/new/ https://reviews.llvm.org/D57270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57628: [index] Improve indexing support for MSPropertyDecl.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57628/new/ https://reviews.llvm.org/D57628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57261: [analyzer] [WIP] Opt-in C Style Cast Checker for OSObject pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rC353566: [analyzer] Opt-in C Style Cast Checker for OSObject pointers (authored by george.karpenkov, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to

r353566 - [analyzer] Opt-in C Style Cast Checker for OSObject pointers

Author: george.karpenkov Date: Fri Feb 8 13:09:00 2019 New Revision: 353566 URL: http://llvm.org/viewvc/llvm-project?rev=353566=rev Log: [analyzer] Opt-in C Style Cast Checker for OSObject pointers Differential Revision: https://reviews.llvm.org/D57261 Added:

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

riccibruno added a comment. > FWIW, I was rather disappointed in a recent review to learn that > IgnoreParens() means "ignore parens... and a whole bunch of other stuff like > generic selection expressions". +1 Indeed. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

aaron.ballman added a comment. In D57267#1391101 , @riccibruno wrote: > > I don't think there was an explicit reason beyond "I didn't need to do it > > at the time". So probably just an oversight on my part. I don't know the > > code nearly as well as

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

riccibruno added a comment. > I don't think there was an explicit reason beyond "I didn't need to do it at > the time". So probably just an oversight on my part. I don't know the code > nearly as well as @rnk, so I could be wrong, but I think the existing tests > should tell you if something

[PATCH] D57935: [Sema] Make string literal init an rvalue.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, this is a much cleaner model than having two different `APValue` representations for arrays. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57935/new/

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

rnk added a comment. In D57267#1390484 , @riccibruno wrote: > @void @rnk Perhaps you can comment on this: currently `Expr::IgnoreImpCasts` > skips `FullExpr`s, but `Expr::IgnoreParenImpCasts` only skips (via > `IgnoreParens`) `ConstantExpr`s. Is there

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:987 + +Only a specific set of standard library functions are supported: + - memcpy aaron.ballman wrote: > And we don't have Annex K versions for any of these, like

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

erik.pilkington updated this revision to Diff 186028. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. Describe what the arguments do in the docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57918/new/ https://reviews.llvm.org/D57918 Files:

[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*

void added a comment. In D57267#1390484 , @riccibruno wrote: > @void @rnk Perhaps you can comment on this: currently `Expr::IgnoreImpCasts` > skips `FullExpr`s, but `Expr::IgnoreParenImpCasts` only skips (via > `IgnoreParens`) `ConstantExpr`s. Is there

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1572 + let Spellings = [Clang<"fortify_stdlib">]; + let Args = [IntArgument<"Type">, IntArgument<"Flag">]; + let Subjects = SubjectList<[Function]>; Nothing in the docs

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

xur updated this revision to Diff 186023. xur added a comment. Updated the patch to sync with D54175 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54176/new/ https://reviews.llvm.org/D54176 Files: include/clang/Basic/CodeGenOptions.h

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/include/clang/Basic/AttrDocs.td:986 + } + }]; +} erik.pilkington wrote: > rjmccall wrote: > > Probably worth

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

erik.pilkington updated this revision to Diff 186013. erik.pilkington marked 5 inline comments as done. erik.pilkington added a comment. Address John's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57918/new/ https://reviews.llvm.org/D57918 Files:

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:986 + } + }]; +} rjmccall wrote: > Probably worth clarifying somewhere in here that only a specific set of > stdlib functions are supported. I don't know that it's

r353556 - Pass the base element type of an array type to the visit method instead

Author: ahatanak Date: Fri Feb 8 11:46:53 2019 New Revision: 353556 URL: http://llvm.org/viewvc/llvm-project?rev=353556=rev Log: Pass the base element type of an array type to the visit method instead of the array type itself. This fixes a bug found by inspection that was introduced in r353459.

[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

This revision was automatically updated to reflect the committed changes. Closed by commit rC353555: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching… (authored by ctopper, committed by ). Changed prior to commit:

r353555 - [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

Author: ctopper Date: Fri Feb 8 11:45:08 2019 New Revision: 353555 URL: http://llvm.org/viewvc/llvm-project?rev=353555=rev Log: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack. Summary: With MSVC, #pragma pack is ignored when

[clang-tools-extra] r353554 - [clang-tidy] Don't use assignment for value-initialized enums

Author: malcolm.parsons Date: Fri Feb 8 11:44:42 2019 New Revision: 353554 URL: http://llvm.org/viewvc/llvm-project?rev=353554=rev Log: [clang-tidy] Don't use assignment for value-initialized enums Summary: The modernize-use-default-member-init check crashes when trying to create an assignment

[PATCH] D57852: [clang-tidy] Don't use assignment for value-initialized enums

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353554: [clang-tidy] Dont use assignment for value-initialized enums (authored by malcolm.parsons, committed by ). Changed prior to commit: https://reviews.llvm.org/D57852?vs=185649=186014#toc

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

rsmith added a comment. You'll also need to update `TreeTransform::TransformCompoundStmt`. (And please add some tests for template instantiation.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57086/new/ https://reviews.llvm.org/D57086

[PATCH] D57966: [clang-tidy] add camelBackOrCase casing style to readability-identifier-naming to support change to variable naming policy (if adopted)

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: michaelplatings, aaron.ballman, JonasToth, hokein. MyDeveloperDay added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Herald added a project: clang. Introduction of a new variable policy (as outlined in

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman created this revision. Herald added subscribers: cfe-commits, jfb, arphaman. Herald added a project: clang. - `@property(attr, attr2)` instead of `@property ( attr,attr2 )`. - Change priority of attributes (see code/comments inline). - Support for printing weak and unsafe_unretained

[PATCH] D54978: Move the SMT API to LLVM

george.karpenkov added a comment. > There is at least one other conflicting commit rL353465 > on top of this code already. Sorry about that. I think it would be fine to revert both or to replay the other commit on top of reverted version of this one.

[PATCH] D54978: Move the SMT API to LLVM

brzycki added a comment. In D54978#1390698 , @thakis wrote: > Thanks for the analysis. I think it's fine if you revert, given that. I'm running in to conflict dependency issues when attempting to revert rL353373 .

[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.

rnk accepted this revision. rnk added a subscriber: rjmccall. rnk added a comment. Sounds good. This change reminded me of D46042 , https://crbug.com/849251, and rL333791 , which I had to revert, and I don't think it relanded.

Re: r328173 - Improve -Winfinite-recursion

Hi Robert I ping'ed this commit on Phabricator with an example of false positive introduced by this patch. Can you take a look? Thanks Steven > On Mar 21, 2018, at 8:16 PM, Robert Widmann via cfe-commits > wrote: > > Author: codafi > Date: Wed Mar 21 20:16:23 2018 > New Revision: 328173 >

  1   2   >