[PATCH] D61817: [analyzer] Add a prunable note for skipping virtual base initializers in subclasses.

NoQ added a comment. This is how it looks: F8864205: Screen Shot 2019-05-10 at 8.23.34 PM.png CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61817/new/ https://reviews.llvm.org/D61817 ___ cfe-commits mai

[PATCH] D61817: [analyzer] Add a prunable note for skipping virtual base initializers in subclasses.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. NoQ updated this revision to Diff 199121

[PATCH] D61817: [analyzer] Add a prunable note for skipping virtual base initializers in subclasses.

NoQ updated this revision to Diff 199121. NoQ added a comment. Fix formatting in tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61817/new/ https://reviews.llvm.org/D61817 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h clang/include/clang/StaticAnalyz

[PATCH] D61816: [CFG] [analyzer] pr41300: Add a branch to skip virtual base initializers when they are handled by the superclass.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. A copy-paste from https://bugs.llvm.org

[PATCH] D61815: [CFG] NFC: Modernize test/Analysis/initializers-cfg-output.cpp.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move FileCheck directives around as we're used to, so that it was easy to un

[PATCH] D61814: [CFG] NFC: Remove implicit conversion from CFGTerminator to Stmt *, make it a variant class instead.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, zzheng, whisperity. Herald added a project: clang. This conversion does indeed save some code, but i plan to

r360499 - Reject attempts to call non-static member functions on objects outside

Author: rsmith Date: Fri May 10 19:00:06 2019 New Revision: 360499 URL: http://llvm.org/viewvc/llvm-project?rev=360499&view=rev Log: Reject attempts to call non-static member functions on objects outside their lifetime in constant expressions. This is undefined behavior per [class.cdtor]p2. We c

[PATCH] D61809: [BPF] Preserve original struct/union type name/access index and array subscripts

efriedma added a comment. > The size you allocate here will presumably need to vary as the struct layout > changes, and you have no way of knowing which allocas will need their sizes > to be changed. Your example is just a pointer; the size of a pointer won't change. That said, yes, address co

[PATCH] D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools

thakis added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2877 +OCET_EncodePointerToObjCTypedef = 1 << 7, + }; + void getObjCEncodingForTypeImpl(QualType t, std::string &S, unsigned Options, rjmccall wrote: > thakis wrote: > > rjmccall

[PATCH] D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools

thakis updated this revision to Diff 199116. thakis marked 4 inline comments as done. thakis added a comment. comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61788/new/ https://reviews.llvm.org/D61788 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp

[PATCH] D61777: [cc1as] Change -compress-debug-sections= to use --

MaskRay abandoned this revision. MaskRay added a comment. Sorry, I have to commit this rC360495 now to unbreak our internal builds. Not sure whether the single dash form is necessary, but rC360495 keeps it. Repository: r

r360495 - [cc1as] Change -compress-debug-sections= to use --

Author: maskray Date: Fri May 10 18:14:50 2019 New Revision: 360495 URL: http://llvm.org/viewvc/llvm-project?rev=360495&view=rev Log: [cc1as] Change -compress-debug-sections= to use -- The double dash form is documented by GNU as, used by gcc, and accepted by llvm-mc. Modified: cfe/trunk/in

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

jdoerfert updated this revision to Diff 199114. jdoerfert added a comment. Rebase on newest Attributor design Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59919/new/ https://reviews.llvm.org/D59919 Files: clang/test/CodeGenOpenCL/as_type.cl l

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 199112. plotfi added a comment. Adding lit test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td clang/include/cla

[PATCH] D61756: Add a __FILE_NAME__ macro.

kristina added a comment. Need @rsmith to bless this as it's introducing a nonstandard extension, however small it may be. The original diff did have a consensus on it, so I didn't really put up a formal RFC on `cfe-dev`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D61809: [BPF] Preserve original struct/union type name/access index and array subscripts

rsmith added a comment. If I understand correctly, you want to be able to compile a program against some `struct` and `union` layouts, and then at load time "update" the program to cope with the actual layouts for those types being something else, but containing (at least) the set of members yo

r360483 - [Darwin] Introduce a new flag, -fapple-link-rtlib that forces linking of the builtins library.

Author: aemerson Date: Fri May 10 16:24:20 2019 New Revision: 360483 URL: http://llvm.org/viewvc/llvm-project?rev=360483&view=rev Log: [Darwin] Introduce a new flag, -fapple-link-rtlib that forces linking of the builtins library. This driver flag is useful when users want to link against the com

[PATCH] D58320: [Darwin] Introduce a new flag, -fapple-link-rtlib that forces linking of the builtins library.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL360483: [Darwin] Introduce a new flag, -fapple-link-rtlib that forces linking of the… (authored by aemerson, committed by

[PATCH] D60593: [GwpAsan] Introduce GWP-ASan.

morehouse added a comment. This diff is helpful to get an overall idea of how things fit together, but it is very difficult to review thoroughly. Let's start splicing off pieces for individual review. I suggest: - Individual reviews for each prereq (mutex, random, etc.) - Review for base GPA

[PATCH] D61756: Add a __FILE_NAME__ macro.

kristina updated this revision to Diff 199104. kristina edited the summary of this revision. kristina added a comment. Actually I got it wrong, the path is normalized to use regular slashes at that point, so there is no point in handling backslashes in paths at all even with Microsoft extensions

[PATCH] D61809: [BPF] Preserve original struct/union type name/access index and array subscripts

yonghong-song added a comment. @lebedev.ri Thanks for the comment. This patch is not ready to land yet. Yes, tests are missing and I am going to add tests later. More importantly, I want to get a sense whether what I am implementing here is the right direction or not. The following two other pat

[PATCH] D58320: [Darwin] Introduce a new flag, -fapple-link-rtlib that forces linking of the builtins library.

aemerson marked an inline comment as done. aemerson added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2084 AddLinkRuntimeLib(Args, CmdArgs, CompilerRT, RLO_IsEmbedded); } ab wrote: > This is different from 'builtins'. Are you OK wit

[PATCH] D61809: [BPF] Preserve original struct/union type name/access index and array subscripts

lebedev.ri added a comment. Tests seems to be missing? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61809/new/ https://reviews.llvm.org/D61809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D61809: [BPF] Preserve original struct/union type name/access index and array subscripts

yonghong-song created this revision. yonghong-song added reviewers: eli.friedman, ast. Herald added subscribers: cfe-commits, arphaman, kosarev. Herald added a project: clang. For background of BPF CO-RE project, please refer to http://vger.kernel.org/bpfconf2019.html In summary, BPF CO-RE int

r360474 - [CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when

Author: ahatanak Date: Fri May 10 14:54:16 2019 New Revision: 360474 URL: http://llvm.org/viewvc/llvm-project?rev=360474&view=rev Log: [CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when necessary. Prior to r349952, clang used to call objc_msgSend when sending a release messag

[PATCH] D61803: [CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when necessary.

This revision was automatically updated to reflect the committed changes. Closed by commit rL360474: [CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when (authored by ahatanak, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

NoQ added a comment. Also, for CodeChecker purposes wouldn't you rather have a machine-readable dump? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

tra added inline comments. Comment at: lib/Headers/__clang_cuda_math_forward_declares.h:30-38 +#ifndef _OPENMP +__DEVICE__ long abs(long); +__DEVICE__ long long abs(long long); +#else +#ifndef __cplusplus __DEVICE__ long abs(long); __DEVICE__ long long abs(long long); -

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

NoQ added a comment. Let's land this together with @Szelethus's proposed solution of hiding hidden options (like checkers in D60925 ). I'm still in favor of hiding alpha checkers (as they are for development only, much like debug flags; i'd recommend hiding them

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Headers/__clang_cuda_math_forward_declares.h:30-38 +#ifndef _OPENMP +__DEVICE__ long abs(long); +__DEVICE__ long long abs(long long); +#else +#ifndef __cplusplus __DEVICE__ long abs(long);

[PATCH] D60593: [GwpAsan] Introduce GWP-ASan.

hctim added a comment. In D60593#1495428 , @gribozavr wrote: > What does GWP stand for? Google Wide Profiling . We use the name GWP-ASan, even though it's "technically neit

[PATCH] D60593: [GwpAsan] Introduce GWP-ASan.

hctim updated this revision to Diff 199083. hctim marked an inline comment as done. hctim added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Updated tests to use unittests rather than expose a public interface and exercise that. Minor perf improvements to sh

[PATCH] D61743: New clang option -MD-filter=prefix to filter files from make dependencies

mibintc updated this revision to Diff 199082. mibintc added a comment. respond to suggestion from @xbolva00 (thanks). Added a test case where prefix fails to match CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61743/new/ https://reviews.llvm.org/D61743 Files: docs/ClangCommandLineR

[PATCH] D61803: [CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when necessary.

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61803/new/ https://reviews.llvm.org/D61803 ___

[PATCH] D61803: [CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when necessary.

ahatanak updated this revision to Diff 199081. ahatanak marked an inline comment as done. ahatanak added a comment. Just call `EmitCallOrInvoke`. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61803/new/ https://reviews.llvm.org/D61803 Files: lib/CodeGen/CGObjC

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1498604 , @compnerd wrote: > This really needs more tests. Please add a positive/negative test for the > driver argument. Please try to organise the tests a bit to show what it is > that they are testing, emission of p

[PATCH] D60974: Clang IFSO driver action.

compnerd added a comment. This really needs more tests. Please add a positive/negative test for the driver argument. Please try to organise the tests a bit to show what it is that they are testing, emission of public functions, not of protected functions or hidden functions. Behaviour with C

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1498240 , @jakehehrlich wrote: > This shouldn't emit the .tbe format at all, the .tbe format is meant to be in > near 1-1 correspondence with .so files, not with .o files. It has things like > DT_NEEDED, and DT_SONAME r

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

tra added inline comments. Comment at: lib/Headers/__clang_cuda_math_forward_declares.h:30-38 +#ifndef _OPENMP +__DEVICE__ long abs(long); +__DEVICE__ long long abs(long long); +#else +#ifndef __cplusplus __DEVICE__ long abs(long); __DEVICE__ long long abs(long long); -

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

gtbercea updated this revision to Diff 199080. gtbercea added a comment. - Error if not in OpenMP. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61765/new/ https://reviews.llvm.org/D61765 Files: lib/Driver/ToolChains/Clang.cpp lib/Headers/CMakeLists.txt li

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

tra added inline comments. Comment at: lib/Headers/__clang_cuda_math_forward_declares.h:30-38 +#ifndef _OPENMP +__DEVICE__ long abs(long); +__DEVICE__ long long abs(long long); +#else +#ifndef __cplusplus __DEVICE__ long abs(long); __DEVICE__ long long abs(long long); -

[PATCH] D57860: [analyzer] Validate checker option names and values

NoQ accepted this revision. NoQ added a comment. In D57860#1432728 , @dcoughlin wrote: > Setting compatibility mode to be true in the driver is not sufficient since > many build systems call the frontend directly. This doesn't seem to be the case; all b

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Headers/__clang_cuda_math_forward_declares.h:30-38 +#ifndef _OPENMP +__DEVICE__ long abs(long); +__DEVICE__ long long abs(long long); +#else +#ifndef __cplusplus __DEVICE__ long abs(long);

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

jdoerfert added a comment. Last issue I have (in addition to the check @tra suggested) is the order in which we include math.h and cstdlib. can you flip it in one of the test cases? Comment at: lib/Headers/__clang_cuda_math_forward_declares.h:30-38 +#ifndef _OPENMP +__DEVICE__

[PATCH] D61803: [CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when necessary.

erik.pilkington added inline comments. Comment at: lib/CodeGen/CGObjC.cpp:2634-2646 + ASTContext &Ctx = getContext(); + const ImplicitParamDecl *paramDecl = + ImplicitParamDecl::Create(Ctx, nullptr, SourceLocation(), nullptr, +Ctx.VoidPtrTy,

[PATCH] D61749: [clang-tidy] initial version of readability-static-const-method

lebedev.ri added a comment. In D61749#1498541 , @mgehre wrote: > ... Still, this is two separate checks, logically. You can put the `FindUsageOfThis` e.g. into a new file in `clang-tidy/utils`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D61804: Support building shared and static libraries simultaneously

winksaville created this revision. winksaville added reviewers: tstellar, morehouse, gottesmm, chapuni. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. I ran into the need for both while trying to compile zig (https://ziglang.org) on my Arch Linux s

[PATCH] D61749: [clang-tidy] initial version of readability-static-const-method

mgehre added a comment. I have thought about splitting the check into separate `static` & `const`, but kept it together because the analysis for both cases is very similar, i.e. finding the usage of `this`. Also, both checks share many preconditions, e.g. not applying them to virtual methods or

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Headers/__clang_cuda_math_forward_declares.h:30-38 +#ifndef _OPENMP +__DEVICE__ long abs(long); +__DEVICE__ long long abs(long long); +#else +#ifndef __cplusplus __DEVICE__ long abs(long);

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

gtbercea updated this revision to Diff 199075. gtbercea added a comment. - Simplify conditions. Add guards. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61765/new/ https://reviews.llvm.org/D61765 Files: lib/Driver/ToolChains/Clang.cpp lib/Headers/CMakeLists

r360468 - [ThinLTO] Clang test changes for new CanAutoHide flag

Author: tejohnson Date: Fri May 10 13:38:31 2019 New Revision: 360468 URL: http://llvm.org/viewvc/llvm-project?rev=360468&view=rev Log: [ThinLTO] Clang test changes for new CanAutoHide flag Modified: cfe/trunk/test/CodeGen/thinlto-distributed-cfi-devirt.ll cfe/trunk/test/CodeGen/thinlto-d

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

mwyman accepted this revision. mwyman added a comment. I don't have commit access, so if somebody could submit them that would be wonderful! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61350/new/ https://reviews.llvm.org/D61350 ___ cfe-c

[PATCH] D61803: [CodeGen][ObjC] Emit invoke instead of call to call `objc_release` when necessary.

ahatanak created this revision. ahatanak added reviewers: pete, rjmccall. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. Prior to r349952, clang used to call `objc_msgSend` when sending a release messages, emitting an invoke instruction instead of a call instructi

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

gtbercea updated this revision to Diff 199073. gtbercea added a comment. - Add tests. Exclude additional abs definition. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61765/new/ https://reviews.llvm.org/D61765 Files: lib/Driver/ToolChains/Clang.cpp lib/Heade

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

tra added inline comments. Comment at: lib/Headers/__clang_cuda_math_forward_declares.h:30-38 +#ifndef _OPENMP +__DEVICE__ long abs(long); +__DEVICE__ long long abs(long long); +#else +#ifndef __cplusplus __DEVICE__ long abs(long); __DEVICE__ long long abs(long long); -

r360465 - Add target triple to test.

Author: leonardchan Date: Fri May 10 13:07:47 2019 New Revision: 360465 URL: http://llvm.org/viewvc/llvm-project?rev=360465&view=rev Log: Add target triple to test. Modified: cfe/trunk/test/Frontend/macro_defined_type.cpp Modified: cfe/trunk/test/Frontend/macro_defined_type.cpp URL: http://

[PATCH] D61496: Fixed tests where grep was not matching the linefeed

This revision was automatically updated to reflect the committed changes. Closed by commit rC360467: Fixed tests where grep was not matching the linefeed (authored by aganea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61496?vs=197990&id=199069#toc Repository: rC Clang

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

gtbercea updated this revision to Diff 199064. gtbercea added a comment. - Mock cstdlib header's abs functions. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61765/new/ https://reviews.llvm.org/D61765 Files: lib/Driver/ToolChains/Clang.cpp lib/Headers/CMakeL

r360467 - Fixed tests where grep was not matching the linefeed

Author: aganea Date: Fri May 10 13:11:36 2019 New Revision: 360467 URL: http://llvm.org/viewvc/llvm-project?rev=360467&view=rev Log: Fixed tests where grep was not matching the linefeed When files are synchronized locally as CRLF on Windows, grep didn't match the newline. Switched to FileCheck i

r360463 - Improve interface of APValuePathEntry.

Author: rsmith Date: Fri May 10 13:05:31 2019 New Revision: 360463 URL: http://llvm.org/viewvc/llvm-project?rev=360463&view=rev Log: Improve interface of APValuePathEntry. Modified: cfe/trunk/include/clang/AST/APValue.h cfe/trunk/lib/AST/APValue.cpp cfe/trunk/lib/AST/ExprConstant.cpp

r360464 - Fix handling of objects under construction during constant expression

Author: rsmith Date: Fri May 10 13:05:32 2019 New Revision: 360464 URL: http://llvm.org/viewvc/llvm-project?rev=360464&view=rev Log: Fix handling of objects under construction during constant expression evaluation. It's not enough to just track the LValueBase that we're evaluating, we need to als

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

jdoerfert added inline comments. Comment at: lib/Headers/openmp_wrappers/__clang_openmp_math_declares.h:17 + #include + #include +#endif gtbercea wrote: > jdoerfert wrote: > > Why do we need the stdlib includes again? > They are both prone to abs inclusion. >

[PATCH] D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools

rjmccall added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2877 +OCET_EncodePointerToObjCTypedef = 1 << 7, + }; + void getObjCEncodingForTypeImpl(QualType t, std::string &S, unsigned Options, thakis wrote: > rjmccall wrote: > > I like

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

gtbercea updated this revision to Diff 199062. gtbercea added a comment. - Clean test header. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61765/new/ https://reviews.llvm.org/D61765 Files: lib/Driver/ToolChains/Clang.cpp lib/Headers/CMakeLists.txt lib/Hea

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/Headers/openmp_wrappers/__clang_openmp_math_declares.h:17 + #include + #include +#endif jdoerfert wrote: > Why do we need the stdlib includes again? They are both prone

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 199058. plotfi added a comment. Changing !tapi-tbe to !experimental-tapi-elf-v1, removing Endianness field from tapi-tbe. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

jdoerfert added a comment. What about `abs` tests? Comment at: lib/Headers/openmp_wrappers/__clang_openmp_math_declares.h:17 + #include + #include +#endif Why do we need the stdlib includes again? Comment at: test/Headers/Inputs/include/c

[PATCH] D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools

thakis marked 2 inline comments as done. thakis added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2877 +OCET_EncodePointerToObjCTypedef = 1 << 7, + }; + void getObjCEncodingForTypeImpl(QualType t, std::string &S, unsigned Options, rjmc

[PATCH] D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools

thakis updated this revision to Diff 199056. thakis edited the summary of this revision. thakis added a comment. Now with more boilerplate! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61788/new/ https://reviews.llvm.org/D61788 Files: clang/include/clang/AST/ASTContext.h clang/lib

[PATCH] D61709: [NewPM] Port HWASan and Kernel HWASan

philip.pfaffe accepted this revision. philip.pfaffe added a comment. This revision is now accepted and ready to land. Nit aside, looks good! Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:179 - bool runOnFunction(Function &F) override; - bool doIniti

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

efriedma added a comment. > -fno-builtin* is about preventing clang/llvm from recognizing that a piece of > code has the same semantic as a particular IR intrinsic, it has nothing to do > with preventing the compiler from generating runtime calls. It has a dual purpose for C library functions.

[PATCH] D60974: Clang IFSO driver action.

plotfi marked an inline comment as done. plotfi added a comment. In D60974#1498240 , @jakehehrlich wrote: > This shouldn't emit the .tbe format at all, the .tbe format is meant to be in > near 1-1 correspondence with .so files, not with .o files. It has

[PATCH] D60974: Clang IFSO driver action.

plotfi marked 2 inline comments as done. plotfi added inline comments. Comment at: llvm/include/llvm/TextAPI/ELF/ELFStub.h:58 ELFArch Arch; + Optional Endian; std::vector NeededLibs; jakehehrlich wrote: > Why do we need or want this? If it is needed can it

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

rsmith added inline comments. Comment at: include/clang/AST/Decl.h:4281 + class DeclSpecUuidDecl : public Decl { + StringRef StrUuid; + public: Can we store a `StringLiteral*` here instead? Comment at: include/clang/Sema/Sema.h:393-394 + /

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

gtbercea updated this revision to Diff 199043. gtbercea added a comment. - Move back functions. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61765/new/ https://reviews.llvm.org/D61765 Files: lib/Driver/ToolChains/Clang.cpp lib/Headers/CMakeLists.txt lib/H

r360452 - Replace 'REQUIRES: nozlib' with '!zlib' because we don't need two ways

Author: probinson Date: Fri May 10 11:32:53 2019 New Revision: 360452 URL: http://llvm.org/viewvc/llvm-project?rev=360452&view=rev Log: Replace 'REQUIRES: nozlib' with '!zlib' because we don't need two ways to say the same thing. Modified: cfe/trunk/test/Driver/nozlibcompress.c Modified: cfe

[clang-tools-extra] r360451 - Removing an unused member variable; NFC.

Author: aaronballman Date: Fri May 10 11:29:10 2019 New Revision: 360451 URL: http://llvm.org/viewvc/llvm-project?rev=360451&view=rev Log: Removing an unused member variable; NFC. Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp Modified: clang-tools-ext

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360450: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check' (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D60629?vs=196531&id=199

[clang-tools-extra] r360450 - [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

Author: dhinton Date: Fri May 10 11:27:09 2019 New Revision: 360450 URL: http://llvm.org/viewvc/llvm-project?rev=360450&view=rev Log: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check' Summary: Change the namespace for llvm checkers from 'llvm' to 'llvm_check', and mo

[PATCH] D61765: [OpenMP][Clang][BugFix] Split declares and math functions inclusion.

gtbercea updated this revision to Diff 199041. gtbercea added a comment. - Fix cstdlib issue. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61765/new/ https://reviews.llvm.org/D61765 Files: lib/Driver/ToolChains/Clang.cpp lib/Headers/CMakeLists.txt lib/Hea

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

leonardchan added a comment. In D51329#1498193 , @miyuki wrote: > This caused https://bugs.llvm.org/show_bug.cgi?id=41835 > Could you please look into it? Sorry for the delay. I submitted r360448 as a fix for this. Repository: rC Clang CHANGES SINC

r360448 - Fix and test for assertion error in P41835.

Author: leonardchan Date: Fri May 10 11:05:15 2019 New Revision: 360448 URL: http://llvm.org/viewvc/llvm-project?rev=360448&view=rev Log: Fix and test for assertion error in P41835. Modified: cfe/trunk/lib/AST/ASTContext.cpp cfe/trunk/test/Frontend/macro_defined_type.cpp Modified: cfe/tr

[PATCH] D61749: [clang-tidy] initial version of readability-static-const-method

lebedev.ri added a reviewer: lebedev.ri. lebedev.ri added a comment. In D61749#1497162 , @Eugene.Zelenko wrote: > @JonasToth tried to implement const check, so probably const and static part > should be split. I agree, there is D54943

r360447 - Replace 'REQUIRES: not_?san' with 'UNSUPPORTED: ?san' as that better

Author: probinson Date: Fri May 10 10:57:22 2019 New Revision: 360447 URL: http://llvm.org/viewvc/llvm-project?rev=360447&view=rev Log: Replace 'REQUIRES: not_?san' with 'UNSUPPORTED: ?san' as that better expresses the intent of the exclusion. Modified: cfe/trunk/test/Index/annotate-deep-stat

[PATCH] D59885: [Lex] Allow to consume tokens while preprocessing

rsmith added a comment. In D59885#1496734 , @ilya-biryukov wrote: > Overall, the performance cost in empty-callback case seems to be lower than > `5%`. This is significant, but hopefully acceptable. 5% is a lot to pay for something that we won't be usi

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

This revision was automatically updated to reflect the committed changes. Closed by commit rL360446: [Sema] Mark array element destructors referenced during initialization (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

r360446 - [Sema] Mark array element destructors referenced during initialization

Author: epilk Date: Fri May 10 10:52:26 2019 New Revision: 360446 URL: http://llvm.org/viewvc/llvm-project?rev=360446&view=rev Log: [Sema] Mark array element destructors referenced during initialization This fixes a crash where we would neglect to mark a destructor referenced for an __attribute__

[PATCH] D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools

rjmccall added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2877 +OCET_EncodePointerToObjCTypedef = 1 << 7, + }; + void getObjCEncodingForTypeImpl(QualType t, std::string &S, unsigned Options, I like the idea of doing this, but can you

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. This shouldn't emit the .tbe format at all, the .tbe format is meant to be in near 1-1 correspondence with .so files, not with .o files. It has things like DT_NEEDED, and DT_SONAME related information that don't make sense for .o files for instance. If we put thin

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. @jakehehrlich What else are you looking for here? Can the patch for merging tbe files come later? @compnerd @rupprecht thoughts? I think this is a reasonable compromise: a minimal subset of what the yaml2obj and llvm-elfabi (with the addition of the Endian field) tools c

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

miyuki added a comment. This caused https://bugs.llvm.org/show_bug.cgi?id=41835 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51329/new/ https://reviews.llvm.org/D51329 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D61700: [clang-tidy] readability-redundant-declaration: fix false positive with C "extern inline"

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with some testing nits. Comment at: clang-tools-extra/test/clang-tidy/readability-redundant-declaration.c:32 +extern inline void g(); \ No newline at end

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman closed this revision. aaron.ballman added a comment. In D56160#1497473 , @bernhardmgruber wrote: > - fixed formatting > - fixed function names in tests > - added `-fexceptions` to test arguments > - fixed typo in release notes Thanks! I co

[clang-tools-extra] r360438 - Recommit r360345 with fixes (was reverted in r360348).

Author: aaronballman Date: Fri May 10 09:24:28 2019 New Revision: 360438 URL: http://llvm.org/viewvc/llvm-project?rev=360438&view=rev Log: Recommit r360345 with fixes (was reverted in r360348). Add the modernize-use-trailing-return check to rewrite function signatures to use trailing return type

[PATCH] D61790: [C++20] add consteval specifier

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: clang. Herald added a subscriber: cfe-commits. this revision adds the consteval specifier as specified by http://www.open-std.org/jtc1/sc22/wg21/

[PATCH] D61627: [clang driver] Allow -fembed-bitcode combined with -mno-red-zone

steven_wu added a comment. In D61627#1497919 , @wanders wrote: > > Why are you interested in expending this list? > > I have a (kernel) that is compiled with `-mno-red-zone` and `-mcmodel=large` > which I want to compile with `-fembed-bitcode` for a debug

[PATCH] D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools

thakis created this revision. thakis added a reviewer: rjmccall. Slightly less code, uses slightly less stack space, and makes it impossible to mix up the order of all those bools. No behavior change. https://reviews.llvm.org/D61788 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. @klimek responded via the mailing list http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20190506/270976.html CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2846

[PATCH] D61786: [ASTImporter] Separate unittest files

martong created this revision. martong added a reviewer: a_sidorin. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs, mgorny. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Move generic redecl chain tests and visibi

  1   2   >