[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1787265 , @hfinkel wrote: > In D71241#1786959 , @jdoerfert wrote: > > > In D71241#1786530 , @ABataev wrote: > > > > > Most probably, we

[PATCH] D71588: [objc_direct] fix uniquing when re-declaring a readwrite-direct property

MadCoder created this revision. MadCoder added reviewers: arphaman, rjmccall, dexonsmith. MadCoder added a project: clang. Herald added a subscriber: cfe-commits. MadCoder added a reviewer: liuliu. ObjCMethodDecl::getCanonicalDecl() for re-declared readwrite properties, only looks in the

[PATCH] D71455: [NFC] Fix typos in Clangd and Clang

MaskRay added a comment. Renaming `handleDeclOccurence`, `handleMacroOccurence` and `handleModuleOccurence` are definitely not NFC because they are public APIs that can be used by downstream projects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1786959 , @jdoerfert wrote: > In D71241#1786530 , @ABataev wrote: > > > Most probably, we can use this solution without adding a new expression. > > `DeclRefExpr` class can

[PATCH] D70157: Align branches within 32-Byte boundary

annita.zhang added a comment. In D70157#1787139 , @reames wrote: > Here are the minutes from our phone call a few minutes ago. Thanks for coordinating the meeting and having a clear summary. It helps a lot to accelerate the patch review. I really

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

gparker42 accepted this revision. gparker42 added a comment. This revision is now accepted and ready to land. Good. `REQUIRES-ANY` was preserved when the boolean expressions were added because libc++ was still using it. libc++ has since changed their tests so removing it should be fine now.

[PATCH] D71541: [Clang]: fix spelling mistake in assert message

Jim added a comment. Could you add "[NFC]" in the title. That means No Function Change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71541/new/ https://reviews.llvm.org/D71541 ___ cfe-commits mailing list

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

Jim added a comment. This patch is only for RISCV. The title should have prefix "[RISCV]". Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:585 +const llvm::opt::ArgList , +llvm::opt::ArgStringList ) { + //

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

compnerd added inline comments. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:60 + if (const auto *MD = dyn_cast_or_null(Parent)) +return true; +} Use `isa` rather than `dyn_cast_or_null`. Furthermore, the

[PATCH] D66839: Fix stack address builtin for negative numbers

zoecarver added a comment. @Jim Thanks, I'll move it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66839/new/ https://reviews.llvm.org/D66839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

kamleshbhalui added a comment. In D71508#1786799 , @aprantl wrote: > Are we sure we want to canonicalize *before* applying -fdebug-prefix-map in > `remapDIPath()`? Honest question, the answer could be yes :-) it canonicalizes before apply

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

jdoerfert added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70258/new/ https://reviews.llvm.org/D70258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

kamleshbhalui added a comment. In D71508#1786804 , @dblaikie wrote: > In D71508#1786212 , @kamleshbhalui > wrote: > > > In D71508#1786148 , @probinson > > wrote: > > > > >

[PATCH] D71572: [ItaniumCXXABI] Use linkonce_odr instead of weak_odr for tls wrappers on Windows

rsmith added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2522 + if (CGM.getTriple().isOSWindows()) +return llvm::GlobalValue::LinkOnceODRLinkage; return llvm::GlobalValue::WeakODRLinkage; I think the thread wrapper should probably be

[PATCH] D71576: [c++20] Add deprecation warnings for the expression forms deprecated by P1120R0.

rsmith marked 3 inline comments as done. rsmith added inline comments. Comment at: clang/lib/AST/Type.cpp:1865-1866 // enumeration type in the sense required here. // C++0x: However, if the underlying type of the enum is fixed, it is // considered complete. if (const

[PATCH] D71586: [clangd] Add a test case that verifies -fimplicit-modules work in Clangd when building the AST

arphaman created this revision. arphaman added reviewers: sammccall, jkorous. Herald added subscribers: usaxena95, ributzka, kadircet, dexonsmith, MaskRay, ilya-biryukov. Herald added a project: clang. This patch adds a test case that verifies that `-fmodules -fimplicit-modules` work in Clangd

[clang] eea8ba0 - Check whether the destination is a complete type in a static_cast (or

Author: Richard Smith Date: 2019-12-16T18:33:35-08:00 New Revision: eea8ba097c4a86632b88291bea51eb710f8ae4fb URL: https://github.com/llvm/llvm-project/commit/eea8ba097c4a86632b88291bea51eb710f8ae4fb DIFF: https://github.com/llvm/llvm-project/commit/eea8ba097c4a86632b88291bea51eb710f8ae4fb.diff

[PATCH] D70157: Align branches within 32-Byte boundary

MaskRay added a comment. In D70157#1787139 , @reames wrote: > Here are the minutes from our phone call a few minutes ago. > > Attendees: Andy Kaylor, Craig Topper, Annita Zhang, Tom Stellard, Chandler > Carruth, Fedor Sergeev, Philip Reames, Yuanake Luo

[PATCH] D71576: [c++20] Add deprecation warnings for the expression forms deprecated by P1120R0.

rsmith closed this revision. rsmith marked 4 inline comments as done. rsmith added a comment. Committed as rG4b0029995853fe37d1dc95ef96f46697c743fcad . Comment at: clang/lib/AST/Type.cpp:1865-1866 //

[clang] 4b00299 - [c++20] Add deprecation warnings for the expression forms deprecated by P1120R0.

Author: Richard Smith Date: 2019-12-16T17:49:45-08:00 New Revision: 4b0029995853fe37d1dc95ef96f46697c743fcad URL: https://github.com/llvm/llvm-project/commit/4b0029995853fe37d1dc95ef96f46697c743fcad DIFF: https://github.com/llvm/llvm-project/commit/4b0029995853fe37d1dc95ef96f46697c743fcad.diff

[clang] 4e9f137 - If constant evaluation fails due to an unspecified pointer comparison,

Author: Richard Smith Date: 2019-12-16T17:49:45-08:00 New Revision: 4e9f1379b9cd7ddce8cf182707e976ebceb72b05 URL: https://github.com/llvm/llvm-project/commit/4e9f1379b9cd7ddce8cf182707e976ebceb72b05 DIFF: https://github.com/llvm/llvm-project/commit/4e9f1379b9cd7ddce8cf182707e976ebceb72b05.diff

[PATCH] D70157: Align branches within 32-Byte boundary

reames added a comment. Here are the minutes from our phone call a few minutes ago. Attendees: Andy Kaylor, Craig Topper, Annita Zhang, Tom Stellard, Chandler Carruth, Fedor Sergeev, Philip Reames, Yuanake Luo Status Summary == Performance data has been posted to llvm-dev. We had

[PATCH] D71585: [perf-training] Change profile file pattern string to use %4m instead of %p

xinxinw1 created this revision. xinxinw1 added reviewers: beanz, phosek, xiaobai, smeenai. Herald added a project: clang. Herald added a subscriber: cfe-commits. With %p, each test file that we're using to generate profile data will make its own profraw file which is around 60 MB in size. If we

[PATCH] D70157: Align branches within 32-Byte boundary

skan marked an inline comment as done. skan added inline comments. Comment at: llvm/lib/MC/MCFragment.cpp:426 + case MCFragment::FT_MachineDependent: { +const MCMachineDependentFragment *MF = +cast(this); MaskRay wrote: > `const auto *`. The type is

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

delcypher added inline comments. Comment at: compiler-rt/lib/ubsan/ubsan_value.cpp:29 +const char *__ubsan::getObjCClassName(ValueHandle Pointer) { +#if defined(__APPLE__) + // We need to query the ObjC runtime for some information, but do not want vsk wrote: >

[PATCH] D71566: New checks for fortified sprintf

erik.pilkington added a comment. Thanks for working on this! I think this would be a really useful diagnostic to have. Comment at: clang/lib/Sema/SemaChecking.cpp:311 } +class EstimateSizeFormatHandler +: public analyze_format_string::FormatStringHandler {

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

jdoerfert added a comment. In D71475#1784312 , @cchen wrote: > In D71475#1784284 , @jdoerfert wrote: > > > What is the output when you run the example with `k` in `lastprivate` or > > `reduction`? > > > I actually

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. SGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71579/new/ https://reviews.llvm.org/D71579

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

dblaikie added subscribers: JDevlieghere, aprantl. dblaikie added a comment. Yeah, GCC's debug info for this is... not good. I don't think it's anything we'd need to be inspired by. Here's the tags and names: DW_TAG_compile_unit DW_AT_name ("templ2.cpp") DW_TAG_structure_type

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2530 + return "ios"; +// FIXME: Add macCatalyst support here ("\"mac catalyst\""). +llvm_unreachable("macCatalyst isn't yet supported");

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh marked 4 inline comments as done. lildmh added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:4918 const OMPMappableExprListSizeTy ) - : OMPMappableExprListClause(OMPC_map, Locs, Sizes, , -

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

steven_wu added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2530 + return "ios"; +// FIXME: Add macCatalyst support here ("\"mac catalyst\""). +llvm_unreachable("macCatalyst isn't yet supported"); arphaman wrote: > steven_wu

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

rnk added a comment. Thanks! I made some comments. This code is convoluted. I don't think I can reason through all the edge cases, but this seems like an improvement. I'd suggest adding the recommended tests and any other corner case inputs you can think of, and after another round of review

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1786530 , @ABataev wrote: > Most probably, we can use this solution without adding a new expression. > `DeclRefExpr` class can contain 2 decls: FoundDecl and the Decl being used. > You can use FoundDecl to point to

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman marked 2 inline comments as done. arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:339 // Add the deployment target. - MachOTC.addMinVersionArgs(Args, CmdArgs); + if (!Version[0] || Version[0] >= 520) +

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

steven_wu added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:339 // Add the deployment target. - MachOTC.addMinVersionArgs(Args, CmdArgs); + if (!Version[0] || Version[0] >= 520) +MachOTC.addPlatformVersionArgs(Args, CmdArgs); Why

[PATCH] D70157: Align branches within 32-Byte boundary

chandlerc added a comment. Just wanted to say thanks for the performance data! I know it was hard to get, but it is really, really useful to help folks evaluate these kinds of changes with actual data around the options available. CHANGES SINCE LAST ACTION

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman created this revision. arphaman added reviewers: steven_wu, dexonsmith. Herald added subscribers: llvm-commits, ributzka, jkorous. Herald added projects: clang, LLVM. In Xcode 11, ld added a new flag called `-platform_version` that can be used instead of the old `-_version_min` flags.

[PATCH] D71503: New warning on for-loops that never run because condition is false on the first iteration

rtrieu updated this revision to Diff 234180. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71503/new/ https://reviews.llvm.org/D71503 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/Sema/SemaStmt.cpp

[PATCH] D71576: [c++20] Add deprecation warnings for the expression forms deprecated by P1120R0.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I have no blocking concerns, just some idle thoughts. Up to you if you want Aaron's feedback before landing. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6235 +

[PATCH] D71503: New warning on for-loops that never run because condition is false on the first iteration

rtrieu added a comment. In D71503#1784697 , @lebedev.ri wrote: > Thank you for working on this! > This seems to be missing tests. My bad, still getting used to git. Updated with a test now. CHANGES SINCE LAST ACTION

[PATCH] D70157: Align branches within 32-Byte boundary

MaskRay added a comment. Haven't looked into too many details yet but made some suggestions anyway... Comment at: llvm/include/llvm/MC/MCFragment.h:634 + + uint64_t getBoundarySize() const { +return AlignBoundarySize; Store AlignBoundarySize as a shift

[PATCH] D70157: Align branches within 32-Byte boundary

reames added a comment. Noting another issue we found in local testing (with an older version of this patch). This interacts badly with the implicit exception mechanism in LLVM. For that mechanism, we end up generating assembly which looks more or less like this: Ltmp: cmp %rsi, (%rdi)

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

sidneym updated this revision to Diff 234174. sidneym added a comment. Remove quotes. Also add ld.lld file so that configurations that don't enable lld will still pass this test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70919/new/

[PATCH] D71576: [c++20] Add deprecation warnings for the expression forms deprecated by P1120R0.

rsmith created this revision. rsmith added reviewers: aaron.ballman, rnk. Herald added a project: clang. This covers: - usual arithmetic conversions (comparisons, arithmetic, conditionals) between different enumeration types - usual arithmetic conversions between enums and floating-point types

[PATCH] D70579: [coroutines][PR41909] Generalize fix from D62550

modocache added a comment. Thanks for the review! Much appreciated :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70579/new/ https://reviews.llvm.org/D70579 ___ cfe-commits mailing list

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

dblaikie added a comment. Yeah, this is working around a more fundamental representational issue. Like member function templates, member variable templates shouldn't be pre-emptively built or ever appear in the "members" list of the type (because that list isn't closed - we don't know what

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

dblaikie added a comment. In D71508#1786212 , @kamleshbhalui wrote: > In D71508#1786148 , @probinson wrote: > > > In D71508#1786122 , @kamleshbhalui > > wrote: > > > > >

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks great to me. This has the potential to break some existing code, though. I would suggest either landing it early in the day, watching for breakage, and hoping for the best, or you could try

[PATCH] D71508: [DebugInfo] Duplicate file names in debug info

aprantl added a comment. Are we sure we want to canonicalize *before* applying -fdebug-prefix-map in `remapDIPath()`? Honest question, the answer could be yes :-) Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:412 + if (!llvm::sys::path::is_absolute(FileName)) { +

Re: [clang] 00bc76e - Move Basic{Reader,Writer} emission into ASTPropsEmitter; NFC.

Thanks John, the bot has recovered. > On Dec 16, 2019, at 1:08 PM, John McCall via cfe-commits > wrote: > > On 16 Dec 2019, at 15:11, John McCall wrote: >> On 16 Dec 2019, at 15:07, Vedant Kumar wrote: >>> Hi John, >>> >>> The lldb bot went red after your clang AST changes landed: >>>

[PATCH] D71572: [ItaniumCXXABI] Use linkonce_odr instead of weak_odr for tls wrappers on Windows

rnk added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2519-2520 return VarLinkage; + // On Windows, WeakODR is a no-op, boiling down to the same as normal external + // linkage. + if (CGM.getTriple().isOSWindows()) mstorsjo wrote:

[PATCH] D71493: [WebAssembly] Setting export_name implies no_dead_strip

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a1e349a7933: [WebAssembly] Setting export_name implies llvm.used (authored by sbc100). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71493/new/

[clang] 0a1e349 - [WebAssembly] Setting export_name implies llvm.used

Author: Sam Clegg Date: 2019-12-16T14:48:38-08:00 New Revision: 0a1e349a7933f7880971533175e11b4bfd22bd53 URL: https://github.com/llvm/llvm-project/commit/0a1e349a7933f7880971533175e11b4bfd22bd53 DIFF: https://github.com/llvm/llvm-project/commit/0a1e349a7933f7880971533175e11b4bfd22bd53.diff

[PATCH] D71493: [WebAssembly] Setting export_name implies no_dead_strip

sbc100 updated this revision to Diff 234160. sbc100 added a comment. - revert part Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71493/new/ https://reviews.llvm.org/D71493 Files: clang/lib/Sema/SemaDeclAttr.cpp

[PATCH] D70579: [coroutines][PR41909] Generalize fix from D62550

This revision was automatically updated to reflect the committed changes. Closed by commit rG376cf43729c8: [coroutines][PR41909] Generalize fix from D62550 (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70579/new/

[PATCH] D71201: [ObjC][DWARF] Emit DW_AT_APPLE_objc_direct for methods marked as __attribute__((objc_direct))

aprantl added a comment. Thanks. This is good to go! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71201/new/ https://reviews.llvm.org/D71201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

cchen updated this revision to Diff 234157. cchen added a comment. Apply @ABataev's patch, add some code to support the patch and some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71475/new/ https://reviews.llvm.org/D71475 Files:

[PATCH] D71475: [WIP][OPENMP] Try to fix linear clause crash by emitting alloca for step

cchen added a comment. > It will still crash for something like `target simd`, need to move the code > around a little bit, move it out of `if`. I tried making `target simd ` crash but it seems work (target_simd_ast_print.cpp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71493: [WebAssembly] Setting export_name implies no_dead_strip

sbc100 marked an inline comment as done. sbc100 added inline comments. Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:725 TOut.emitExportName(WasmSym, ExportName); + Out.EmitSymbolAttribute(WasmSym, MCSA_NoDeadStrip); }

[clang] 376cf43 - [coroutines][PR41909] Generalize fix from D62550

Author: Brian Gesiak Date: 2019-12-16T17:43:04-05:00 New Revision: 376cf43729c8025eecbd2969522c5687f2a3919f URL: https://github.com/llvm/llvm-project/commit/376cf43729c8025eecbd2969522c5687f2a3919f DIFF: https://github.com/llvm/llvm-project/commit/376cf43729c8025eecbd2969522c5687f2a3919f.diff

[PATCH] D71572: [ItaniumCXXABI] Use linkonce_odr instead of weak_odr for tls wrappers on Windows

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2519-2520 return VarLinkage; + // On Windows, WeakODR is a no-op, boiling down to the same as normal external + // linkage. + if

[PATCH] D71572: [ItaniumCXXABI] Use linkonce_odr instead of weak_odr for tls wrappers on Windows

rnk added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2519-2520 return VarLinkage; + // On Windows, WeakODR is a no-op, boiling down to the same as normal external + // linkage. + if (CGM.getTriple().isOSWindows()) I would say

[PATCH] D71572: [ItaniumCXXABI] Use linkonce_odr instead of weak_odr for tls wrappers on Windows

mstorsjo added a comment. Actually, this doesn't seem to be enough for the case at hand (used with `-ffunction-sections -fdata-sections`), I'll have to continue looking into it tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71572/new/

[PATCH] D71400: [RFC] [MinGW] Implicitly add .exe suffix if not provided

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71400/new/ https://reviews.llvm.org/D71400 ___ cfe-commits mailing list

[PATCH] D70527: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths

rnk added a comment. In D70527#1785552 , @ikudrin wrote: > Personally, I would prefer to see the file name and path to be changed as > little as possible because that would help to recognize the files better. We > cannot use `remove_dots()` on POSIX

[PATCH] D71400: [RFC] [MinGW] Implicitly add .exe suffix if not provided

mstorsjo added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71400/new/ https://reviews.llvm.org/D71400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71572: [ItaniumCXXABI] Use linkonce_odr instead of weak_odr for tls wrappers on Windows

mstorsjo created this revision. mstorsjo added reviewers: rnk, froydnj, compnerd. Herald added a project: clang. On Windows, weak_odr is a no-op, and thus a weak_odr tls wrapper function can result in linker errors due to multiply defined symbols. Therefore, use linkonce_odr instead of weak_odr

[PATCH] D70527: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths

rnk added a comment. From auditing the call sites, it seems that almost all of them could be simplified by using the new API: http://llvm-cs.pcc.me.uk/tools/clang/lib/Basic/FileManager.cpp/rgetCanonicalName Comment at: clang/include/clang/Basic/FileManager.h:226 /// The

[PATCH] D71493: [WebAssembly] Setting export_name implies no_dead_strip

sunfish added inline comments. Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:725 TOut.emitExportName(WasmSym, ExportName); + Out.EmitSymbolAttribute(WasmSym, MCSA_NoDeadStrip); } It feels like this is a little

[clang] 3f22b47 - Revert "[NFC-I] Remove hack for fp-classification builtins"

Author: Erich Keane Date: 2019-12-16T14:01:51-08:00 New Revision: 3f22b4721e6c9859c392d9891411cbc8d9e10c70 URL: https://github.com/llvm/llvm-project/commit/3f22b4721e6c9859c392d9891411cbc8d9e10c70 DIFF: https://github.com/llvm/llvm-project/commit/3f22b4721e6c9859c392d9891411cbc8d9e10c70.diff

[PATCH] D71493: [WebAssembly] Setting export_name implies no_dead_strip

sbc100 updated this revision to Diff 234144. sbc100 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71493/new/ https://reviews.llvm.org/D71493 Files: clang/lib/Sema/SemaDeclAttr.cpp clang/test/CodeGen/wasm-export-name.c

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

vsk updated this revision to Diff 234142. vsk added a comment. Ignore an objc-cast report at a given SourceLocation after it's been reported once. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71491/new/ https://reviews.llvm.org/D71491 Files:

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

vsk updated this revision to Diff 234139. vsk added a comment. Avoid a static initializer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71491/new/ https://reviews.llvm.org/D71491 Files: clang/docs/UndefinedBehaviorSanitizer.rst clang/include/clang/Basic/Sanitizers.def

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

vsk added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:953 + SanitizerKind::ImplicitConversion | SanitizerKind::Nullability | + SanitizerKind::LocalBounds | SanitizerKind::ObjCCast; if (getTriple().getArch() == llvm::Triple::x86 ||

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

vsk updated this revision to Diff 234136. vsk marked 3 inline comments as done. vsk added a comment. Address review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71491/new/ https://reviews.llvm.org/D71491 Files: clang/docs/UndefinedBehaviorSanitizer.rst

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71020/new/ https://reviews.llvm.org/D71020

[PATCH] D71566: New checks for fortified sprintf

serge-sans-paille created this revision. serge-sans-paille added a reviewer: erik.pilkington. serge-sans-paille added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. Implement a pessimistic evaluator of the minimal required size for a buffer based on the format string, and

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. Most probably, we can use this solution without adding a new expression. `DeclRefExpr` class can contain 2 decls: FoundDecl and the Decl being used. You can use FoundDecl to point to the original function and used decl to point to the function being called in this

[clang] 803403a - Fix a bug in the property-based serialization of

Author: John McCall Date: 2019-12-16T16:08:09-05:00 New Revision: 803403afc83f659be1c620eb1896dcf704b18b0a URL: https://github.com/llvm/llvm-project/commit/803403afc83f659be1c620eb1896dcf704b18b0a DIFF: https://github.com/llvm/llvm-project/commit/803403afc83f659be1c620eb1896dcf704b18b0a.diff

Re: [clang] 00bc76e - Move Basic{Reader,Writer} emission into ASTPropsEmitter; NFC.

On 16 Dec 2019, at 15:11, John McCall wrote: On 16 Dec 2019, at 15:07, Vedant Kumar wrote: Hi John, The lldb bot went red after your clang AST changes landed: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/4801/changes#detail0

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang added inline comments. Comment at: clang/include/clang/AST/Type.h:477-479 + ((isPtrSizeAddressSpace(A) && B == LangAS::Default) || +(isPtrSizeAddressSpace(B) && A == LangAS::Default) || +(isPtrSizeAddressSpace(A) &&

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

efriedma added a comment. My primary concern with this is that I'm not sure you should be passing this information separately, as opposed to encoding it into the bitcode. On ARM, the ABI for a file is generally derived from the target triple. For example, "arm-eabi" is soft-float,

[clang] b1e542f - [NFC-I] Remove hack for fp-classification builtins

Author: Erich Keane Date: 2019-12-16T12:22:55-08:00 New Revision: b1e542f302c1ed796ad9f703d4d36e010afcb914 URL: https://github.com/llvm/llvm-project/commit/b1e542f302c1ed796ad9f703d4d36e010afcb914 DIFF: https://github.com/llvm/llvm-project/commit/b1e542f302c1ed796ad9f703d4d36e010afcb914.diff

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang updated this revision to Diff 234125. akhuang marked 8 inline comments as done. akhuang added a comment. - Added docs for __ptr32, __ptr64, __sptr, __utr - Moved some functions into ASTContext - and addressed other comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

dblaikie added a comment. Do you have any particular users/use case for this? Might be best as two separate patches (one for the LLVM change, one for the Clang change) with tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71451/new/

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:4918 const OMPMappableExprListSizeTy ) - : OMPMappableExprListClause(OMPC_map, Locs, Sizes, , - ), + :

[PATCH] D71556: [AArch64][SVE] Implement intrinsic for non-faulting loads

efriedma added a comment. I'm not sure it's legal to transform a non-faulting load to a load with a non-faulting flag? At least, we'd need to consider the implications of that very carefully. In particular, I'm concerned about the interaction with intrinsics that read/write FFR. I mean, you

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh marked 5 inline comments as done. lildmh added a comment. Alexey, thanks for the review Comment at: clang/include/clang/AST/OpenMPClause.h:4918 const OMPMappableExprListSizeTy ) - : OMPMappableExprListClause(OMPC_map, Locs, Sizes, , -

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie added a comment. In D70524#1783363 , @probinson wrote: > > Hmm, maybe this feature/suggestion is broken or at least not exactly > > awesome when it comes to auto-returning functions that are eventually > > void-returning functions? Now the

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:4918 const OMPMappableExprListSizeTy ) - : OMPMappableExprListClause(OMPC_map, Locs, Sizes, , - ), + :

Re: [clang] 00bc76e - Move Basic{Reader,Writer} emission into ASTPropsEmitter; NFC.

On 16 Dec 2019, at 15:07, Vedant Kumar wrote: Hi John, The lldb bot went red after your clang AST changes landed: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/4801/changes#detail0 All of the test

[PATCH] D71500: [WebAssembly] Replace SIMD int min/max builtins with patterns

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a93756dfbb0: [WebAssembly] Replace SIMD int min/max builtins with patterns (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71500/new/

Re: [clang] 00bc76e - Move Basic{Reader,Writer} emission into ASTPropsEmitter; NFC.

Hi John, The lldb bot went red after your clang AST changes landed: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/4801/changes#detail0 All of the test failures were due to a clang assertion: Assertion

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c.h:14686 +#if defined(cl_khr_mipmap_image_writes) +#pragma OPENCL EXTENSION cl_khr_mipmap_image_writes : begin void __ovld write_imagef(write_only image1d_t image, int coord, int lod, float4 color);

[PATCH] D71476: [OpenCL] Add builtin function extension handling

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: clang/lib/Sema/OpenCLBuiltins.td:51 +// Extension associated to a builtin function. +class FunctionExtension : AbstractExtension<_Ext>; +

[PATCH] D71500: [WebAssembly] Replace SIMD int min/max builtins with patterns

tlively marked an inline comment as done. tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:189 + setOperationAction(Op, T, Legal); +} + aheejin wrote: > Just curious, what gets assigned we don't do

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh added a comment. I'll split the patch into 2 later Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7388 - llvm::Value *getExprTypeSize(const Expr *E) const { + llvm::Value *getExprTypeSize(const Expr *E, bool hasMapper) const { QualType ExprTy =

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh updated this revision to Diff 234113. lildmh marked 28 inline comments as done. lildmh added a comment. Rebase and address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D71500: [WebAssembly] Replace SIMD int min/max builtins with patterns

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:189 + setOperationAction(Op, T, Legal); +} + Just curious, what gets

  1   2   3   >