[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel added a comment. Could you please clarify what you mean by "regressions" here? Isn't the behaviour of this syntax broken to begin with? It doesn't change anything about lambdas without //requires-clause//s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

owenpan added a comment. In D145642#4186304 , @rymiel wrote: > In D145642#4183539 , @owenpan wrote: > >> Would this patch make the end result look worse without "making the requires >> clause formatting of

[PATCH] D145838: [clang][deps] Handle response files in dep scanner

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese. Herald added a project: All. benlangmuir requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Extract the code the driver uses to expand response

[PATCH] D138472: clang/cmake: Use installed gtest libraries for stand-alone builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG821691039585: clang/cmake: Use installed gtest libraries for stand-alone builds (authored by tstellar). Changed prior to commit:

[clang] 8216910 - clang/cmake: Use installed gtest libraries for stand-alone builds

Author: Tom Stellard Date: 2023-03-10T20:00:23-08:00 New Revision: 82169103958583d3320b3a9a1e6542e8d32ef8da URL: https://github.com/llvm/llvm-project/commit/82169103958583d3320b3a9a1e6542e8d32ef8da DIFF: https://github.com/llvm/llvm-project/commit/82169103958583d3320b3a9a1e6542e8d32ef8da.diff

[clang] e99ccd8 - Revert "Add install targets for gtest"

Author: Tom Stellard Date: 2023-03-10T19:59:20-08:00 New Revision: e99ccd8d03c44c17f797c046c2483e68ea7a2715 URL: https://github.com/llvm/llvm-project/commit/e99ccd8d03c44c17f797c046c2483e68ea7a2715 DIFF: https://github.com/llvm/llvm-project/commit/e99ccd8d03c44c17f797c046c2483e68ea7a2715.diff

[clang] cb38df4 - Add install targets for gtest

Author: Tom Stellard Date: 2023-03-10T19:43:07-08:00 New Revision: cb38df4c4d3aee53107219a68749dc94fe70ff68 URL: https://github.com/llvm/llvm-project/commit/cb38df4c4d3aee53107219a68749dc94fe70ff68 DIFF: https://github.com/llvm/llvm-project/commit/cb38df4c4d3aee53107219a68749dc94fe70ff68.diff

[PATCH] D145793: [clang][AST] Improve diagnostic for `nullptr` constexpr function pointer call

hazohelet updated this revision to Diff 504324. hazohelet edited the summary of this revision. hazohelet added a comment. Address comment from @aaron.ballman - Rewording the diagnostic CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145793/new/ https://reviews.llvm.org/D145793 Files:

[clang] 9aae408 - [NFC] fix typo `funciton` -> `function`

Author: Yuanfang Chen Date: 2023-03-10T18:05:25-08:00 New Revision: 9aae408d551083bbbac96ecc512d45c30358e4b9 URL: https://github.com/llvm/llvm-project/commit/9aae408d551083bbbac96ecc512d45c30358e4b9 DIFF: https://github.com/llvm/llvm-project/commit/9aae408d551083bbbac96ecc512d45c30358e4b9.diff

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel added a comment. In D145642#4183539 , @owenpan wrote: > Would this patch make the end result look worse without "making the requires > clause formatting of lambdas > match the formatting for functions"? If yes, then we should not land it just >

[PATCH] D145834: typo statment to statement

HerrCai0907 created this revision. HerrCai0907 added a reviewer: aaron.ballman. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. fix typo in some comments Repository: rG LLVM Github Monorepo

[PATCH] D145833: Switch ABI references to env/environment

lamb-j created this revision. Herald added a project: All. lamb-j requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To be consistent with Triple.h, we update references to the optional fourth triple field from ABI to env or enviornment

[PATCH] D145793: [clang][AST] Improve diagnostic for `nullptr` constexpr function pointer call

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. LGTM pending other reviewers' commentary. Thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145793/new/

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j marked an inline comment as done. lamb-j added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:2 // REQUIRES: x86-registered-target -// REQUIRES: powerpc-registered-target // UNSUPPORTED: target={{.*}}-darwin{{.*}}, target={{.*}}-aix{{.*}}

[PATCH] D145439: PLEASE DO NOT COMMENT ON THIS PATCH

cjdb added a comment. D145438 was merged into D145284 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145439/new/ https://reviews.llvm.org/D145439

[PATCH] D145438: PLEASE DO NOT COMMENT ON THIS PATCH

cjdb abandoned this revision. cjdb added a comment. Merged into D145284 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145438/new/ https://reviews.llvm.org/D145438 ___

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j updated this revision to Diff 504310. lamb-j added a comment. Herald added a reviewer: alexander-shaposhnikov. Adding another test, updating existing large test, and switching from ABI to env Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145284: WIP [clang] adds capabilities for SARIF to be written to file

cjdb updated this revision to Diff 504309. cjdb added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. merges in D145438 . This patch is ready for review now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j added a comment. In D145770#4186142 , @yaxunl wrote: > In D145770#4185658 , @lamb-j wrote: > >> In D145770#4184996 , @yaxunl wrote: >> >>> The description needs

[PATCH] D145822: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG100a3c397c20: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 100a3c3 - [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

Author: Kirill Stoimenov Date: 2023-03-11T00:14:27Z New Revision: 100a3c397c2009d008ed4d26e124af43805184a0 URL: https://github.com/llvm/llvm-project/commit/100a3c397c2009d008ed4d26e124af43805184a0 DIFF: https://github.com/llvm/llvm-project/commit/100a3c397c2009d008ed4d26e124af43805184a0.diff

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

rsmith added a comment. In D124351#4185007 , @aaron.ballman wrote: > In the reproducer from Sam, there are three lambdas: > `create::Create([] {});` in `main.cpp`, but this does not participate in > AST merging because it's within the main source file

[PATCH] D130303: Fix include order in CXType.cpp

collinbaker added a comment. Collin Baker collinba...@chromium.org This should also be in the author field of the commits Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

yaxunl added a comment. In D145770#4185658 , @lamb-j wrote: > In D145770#4184996 , @yaxunl wrote: > >> The description needs fix. "ABI field" should be "environment component". >> >> Also, we need a

[PATCH] D145737: PR60985: Fix merging of lambda closure types across modules.

rsmith updated this revision to Diff 504296. rsmith added a comment. - Add some missing recursive deserialization guards. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145737/new/ https://reviews.llvm.org/D145737 Files:

[clang] c380156 - [NFC] [CMake] Add misssing dependencies

Author: Chris Bieneman Date: 2023-03-10T17:13:09-06:00 New Revision: c3801568ef2b7f923f9116f72a6b0bb382bcaa41 URL: https://github.com/llvm/llvm-project/commit/c3801568ef2b7f923f9116f72a6b0bb382bcaa41 DIFF:

[PATCH] D145793: [clang][AST] Improve diagnostic for `nullptr` constexpr function pointer call

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:7673 +Info.FFDiag(Callee, diag::note_constexpr_null_callee) +<< const_cast(Callee); +return false; hazohelet wrote: > tbaeder wrote: > > Is the `const_cast`

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

yaxunl added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8634 +def warn_hip_omp_target_directives : Warning< + "HIP does not support OpenMP target directives; directive has been ignored">, + InGroup; jdoerfert wrote: > mhalk

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

royjacobson added a comment. In D140996#4185795 , @bolshakov-a wrote: > @royjacobson, I've added some test cases for using the new NTTP arguments in > clang modules. It uses serialization, in principle. Or more specialized tests > are still needed?

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

ManuelJBrito added a comment. Reverted. I'll reassess what can be done here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144903/new/ https://reviews.llvm.org/D144903 ___ cfe-commits mailing list

[clang] 6a02cd4 - Revert "[X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS"

Author: ManuelJBrito Date: 2023-03-10T22:24:01Z New Revision: 6a02cd45a51945cbe6b9f85629805c38e6009271 URL: https://github.com/llvm/llvm-project/commit/6a02cd45a51945cbe6b9f85629805c38e6009271 DIFF: https://github.com/llvm/llvm-project/commit/6a02cd45a51945cbe6b9f85629805c38e6009271.diff LOG:

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

jdoerfert added a comment. I would emit an error. A warning only if we can ensure the code does something sensible. Right now, I doubt that is the case, similarly I doubt we actually ignore things. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8634 +def

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 added a comment. Making use of this in LLDB (see https://reviews.llvm.org/D145078) was a bit too finicky for my taste, so I prepared an alternative which doesn't require adding a new attribute and no LLDB changes. I *think* this is what @aprantl and @dblaikie had in mind couple of

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 added a comment. Michael137 updated this revision to Diff 504274. Michael137 updated this revision to Diff 504276. Michael137 edited the summary of this revision. Michael137 added a

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 504275. DmitryPolukhin added a comment. Fix test on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files:

[PATCH] D144058: [clang][deps] Split lookupModuleOutput out of DependencyConsumer NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG296ba5bbd387: [clang][deps] Split lookupModuleOutput out of DependencyConsumer NFC (authored by benlangmuir). Repository: rG LLVM Github Monorepo

[clang] 296ba5b - [clang][deps] Split lookupModuleOutput out of DependencyConsumer NFC

Author: Ben Langmuir Date: 2023-03-10T13:14:49-08:00 New Revision: 296ba5bbd387e7f3edb0131054183fa7913a091e URL: https://github.com/llvm/llvm-project/commit/296ba5bbd387e7f3edb0131054183fa7913a091e DIFF: https://github.com/llvm/llvm-project/commit/296ba5bbd387e7f3edb0131054183fa7913a091e.diff

[clang] 13a10e7 - [Driver][FreeBSD] Simplify ARM handling

Author: Brad Smith Date: 2023-03-10T16:10:44-05:00 New Revision: 13a10e7ec90a71c3665491231d468772c19a4b59 URL: https://github.com/llvm/llvm-project/commit/13a10e7ec90a71c3665491231d468772c19a4b59 DIFF: https://github.com/llvm/llvm-project/commit/13a10e7ec90a71c3665491231d468772c19a4b59.diff

[PATCH] D144823: [Driver][FreeBSD] Simplify ARM handling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG13a10e7ec90a: [Driver][FreeBSD] Simplify ARM handling (authored by brad). Changed prior to commit:

[PATCH] D145822: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

kstoimenov marked an inline comment as done. kstoimenov added a comment. In D145822#4185801 , @vitalybuka wrote: > what is about detect_leaks? Yes. I had to revert only this file because it broke a bunch of bots. Repository: rG LLVM Github Monorepo

[PATCH] D145822: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

kstoimenov updated this revision to Diff 504264. kstoimenov edited the summary of this revision. kstoimenov added a comment. Moved UNSUPPORTED to one line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145822/new/ https://reviews.llvm.org/D145822

[PATCH] D145146: [Driver][NFC] Remove some redundant code in Driver.cpp.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. `computeTargetTriple` has several users. You probably want to check all these code paths do not need `if (const Arg *A = Args.getLastArg(options::OPT_target))`. For the uses in

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

ychen abandoned this revision. ychen added a comment. Superseded by D127233 , D127259 , rG7f8d844df5e9 Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D145817: [RISCV] Consistently place single quotes around extension names in error messages.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde76c016f722: [RISCV] Consistently place single quotes around extension names in error… (authored by craig.topper). Repository: rG LLVM Github

[clang] de76c01 - [RISCV] Consistently place single quotes around extension names in error messages.

Author: Craig Topper Date: 2023-03-10T12:36:37-08:00 New Revision: de76c016f722fb27a2b966e860a99966e91c3216 URL: https://github.com/llvm/llvm-project/commit/de76c016f722fb27a2b966e860a99966e91c3216 DIFF: https://github.com/llvm/llvm-project/commit/de76c016f722fb27a2b966e860a99966e91c3216.diff

[PATCH] D145822: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

vitalybuka added a comment. what is about detect_leaks? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145822/new/ https://reviews.llvm.org/D145822 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145822: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

vitalybuka added inline comments. Comment at: clang/test/Index/crash-recovery-modules.m:14 // REQUIRES: crash-recovery // UNSUPPORTED: libstdcxx-safe-mode // UNSUPPORTED: libstdcxx-safe-mode, hwasan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D145820: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead of the launch point.

jdoerfert added a comment. Check the other functions around, they take an AllocaIP, which is on the user side not necessarily the entry block. We need to follow that scheme here too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145820/new/

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added a comment. @royjacobson, I've added some test cases for using the new NTTP arguments in clang modules. It uses serialization, in principle. Or more specialized tests are still needed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504255. bolshakov-a added a comment. Add relnote and update C++ status. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504254. bolshakov-a added a comment. Fix constness issue in `TemplateArgument` for `ASTContext`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504253. bolshakov-a added a comment. Add some testcases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504251. bolshakov-a added a comment. Add `ODRHash` calculation for `UncommonValue` (and test it). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504250. bolshakov-a added a comment. Herald added a subscriber: ChuanqiXu. Add `ODRHash` calculation for UncommonValue (and test it). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files:

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504249. bolshakov-a added a comment. Refactor `TemplateArgument` constructors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504248. bolshakov-a added a comment. Fix after rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504247. bolshakov-a added a comment. Fix after rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang/include/clang/AST/PropertiesBase.td Index:

[PATCH] D145822: [HWASAN][LSAN] Exclude crash-recovery-modules.m from HWASAN tests

kstoimenov created this revision. Herald added a subscriber: arphaman. Herald added a project: All. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145822 Files:

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 504242. bolshakov-a added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D145820: Insert alloca for kernel args at function entry block instead of the launch point.

dhruvachak added a comment. In D145820#4185695 , @jhuber6 wrote: > No tests updated? That's a TODO, coming soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145820/new/ https://reviews.llvm.org/D145820

[PATCH] D145820: Insert alloca for kernel args at function entry block instead of the launch point.

jhuber6 added a comment. No tests updated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145820/new/ https://reviews.llvm.org/D145820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145813: [clang-format] Respect Cpp11BraceListStyle when aligning array of structures

hch12907 updated this revision to Diff 504238. hch12907 added a comment. Added unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145813/new/ https://reviews.llvm.org/D145813 Files: clang/lib/Format/WhitespaceManager.cpp

[PATCH] D145820: Insert alloca for kernel args at function entry block instead of the launch point.

dhruvachak added a comment. TODOs: Update existing LIT tests, add a new one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145820/new/ https://reviews.llvm.org/D145820 ___ cfe-commits mailing list

[PATCH] D145820: Insert alloca for kernel args at function entry block instead of the launch point.

dhruvachak created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. dhruvachak requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. If an inlined

[clang] 2f12642 - Revert "Currently the control of the eval-method is mixed with fast-math."

Author: Zahira Ammarguellat Date: 2023-03-10T14:44:06-05:00 New Revision: 2f1264260b37e9bd79737181e459ae20e10c5fea URL: https://github.com/llvm/llvm-project/commit/2f1264260b37e9bd79737181e459ae20e10c5fea DIFF:

[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

lamb-j added a comment. In D145770#4184996 , @yaxunl wrote: > The description needs fix. "ABI field" should be "environment component". > > Also, we need a clang-offload-bundler test which bundles with a non-canonical > triple and unbundles with a

[PATCH] D145818: [Fuchsia] Add LLDB to CLANG_BOOTSTRAP_TARGETS.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2998a5551e29: [Fuchsia] Add LLDB to CLANG_BOOTSTRAP_TARGETS. (authored by mysterymath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 2998a55 - [Fuchsia] Add LLDB to CLANG_BOOTSTRAP_TARGETS.

Author: Daniel Thornburgh Date: 2023-03-10T11:35:32-08:00 New Revision: 2998a5551e29e8340cbdf9fcb3680cc2dedeb208 URL: https://github.com/llvm/llvm-project/commit/2998a5551e29e8340cbdf9fcb3680cc2dedeb208 DIFF:

[PATCH] D145817: [RISCV] Consistently place single quotes around extension names in erro messages.

asb added a comment. erro => error in the patch title though! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145817/new/ https://reviews.llvm.org/D145817 ___ cfe-commits mailing list

[PATCH] D145818: [Fuchsia] Add LLDB to CLANG_BOOTSTRAP_TARGETS.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145818/new/ https://reviews.llvm.org/D145818

[PATCH] D145817: [RISCV] Consistently place single quotes around extension names in erro messages.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145817/new/ https://reviews.llvm.org/D145817

[PATCH] D145818: [Fuchsia] Add LLDB to CLANG_BOOTSTRAP_TARGETS.

mysterymath created this revision. mysterymath added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. mysterymath requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stage2-check-lldb should be run in a

[PATCH] D145809: [RISCV] Error if F and Zfinx extensions are specified together.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2800d57e124a: [RISCV] Error if F and Zfinx extensions are specified together. (authored by craig.topper). Repository: rG LLVM Github Monorepo

[clang] 2800d57 - [RISCV] Error if F and Zfinx extensions are specified together.

Author: Craig Topper Date: 2023-03-10T11:26:00-08:00 New Revision: 2800d57e124a605c069a4d4024e73089b2783250 URL: https://github.com/llvm/llvm-project/commit/2800d57e124a605c069a4d4024e73089b2783250 DIFF: https://github.com/llvm/llvm-project/commit/2800d57e124a605c069a4d4024e73089b2783250.diff

[PATCH] D145817: [RISCV] Consistently place single quotes around extension names in erro messages.

craig.topper created this revision. craig.topper added reviewers: asb, luismarques, reames, kito-cheng. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D143466: [clang][Interp] Fix initializing base class members

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143466/new/ https://reviews.llvm.org/D143466 ___ cfe-commits mailing

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

nlopes added a comment. In D144903#4182498 , @efriedma wrote: > I think the point of the hasOneUse check is to avoid a possible miscompile; > if a FREEZE has more than one use, all users need to see the same value. So > not sure dropping the check is

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon created this revision. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. agozillon requested review of this revision. Herald added subscribers: cfe-commits, sstefan1,

[PATCH] D145369: Emit const globals with constexpr destructor as constant LLVM values

aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added a comment. This seems reasonable to me, but adding the codegen code owners in case they disagree. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145369/new/

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added a comment. I have some problems with Arcanist... It tries to open a new PR instead of updating this one. Probably because I've re-cloned my local repository. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/

[PATCH] D145814: Release notes and C++ status

bolshakov-a added a comment. Occasional PR, sorry. I'm still learning Arcanist... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145814/new/ https://reviews.llvm.org/D145814 ___ cfe-commits mailing list

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:3036 if (!std::is_trivially_destructible::value) { - auto DestroyPtr = [](void *V) { static_cast(V)->~T(); }; - AddDeallocation(DestroyPtr, Ptr); + auto DestroyPtr = [](void

[PATCH] D145814: Release notes and C++ status

bolshakov-a created this revision. Herald added a project: All. bolshakov-a requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145814 Files: clang/docs/ReleaseNotes.rst

[PATCH] D145809: [RISCV] Error if F and Zfinx extensions are specified together.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145809/new/ https://reviews.llvm.org/D145809

[PATCH] D145809: [RISCV] Error if F and Zfinx extensions are specified together.

craig.topper updated this revision to Diff 504203. craig.topper added a comment. Add test for D and Zdinx which will produce the same error as F and Zfinx. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145809/new/ https://reviews.llvm.org/D145809

[PATCH] D145813: [clang-format] Respect Cpp11BraceListStyle when aligning array of structures

hch12907 created this revision. hch12907 added a reviewer: owenpan. Herald added a project: All. hch12907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When Cpp11BraceListStyle is set to false and AlignArrayOfStructures is set, the first

[PATCH] D145793: [clang][AST] Improve diagnostic for `nullptr` constexpr function pointer call

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:131 +def note_constexpr_null_callee : Note< + "function pointer '%0' evaluates to a null pointer">; def note_constexpr_function_param_value_unknown : Note< Small

[PATCH] D145809: [RISCV] Error if F and Zfinx extensions are specified together.

craig.topper added a comment. In D145809#4185320 , @asb wrote: > The change itself looks good to me, but we have the same issue for D and > Zdinx as well. D implies F and Zdinx implies Zfinx so it should still trigger this error. I can add a test?

[PATCH] D144058: [clang][deps] Split lookupModuleOutput out of DependencyConsumer NFC

benlangmuir updated this revision to Diff 504196. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144058/new/ https://reviews.llvm.org/D144058 Files: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h

[PATCH] D145809: [RISCV] Error if F and Zfinx extensions are specified together.

asb added a comment. The change itself looks good to me, but we have the same issue for D and Zdinx as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145809/new/ https://reviews.llvm.org/D145809

[PATCH] D142420: [Flang] Add support to use LTO specific pipelines

mnadeem added a comment. In D142420#4184825 , @tblah wrote: > In D142420#4080619 , @mnadeem wrote: > >> We have tried full LTO on Aarch64 (without this patch) and have seen a few >> 3-8% improvements in SPEC and

[PATCH] D145809: [RISCV] Error if F and Zfinx extensions are specified together.

craig.topper created this revision. craig.topper added reviewers: reames, jrtc27, kito-cheng, asb. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D144003: [clang][analyzer] Improve bug reports of StdLibraryFunctionsChecker.

balazske updated this revision to Diff 504185. balazske added a comment. Change format of bug reports. Now the problem is shown first, then the acceptable values. Sometimes the messages can become too verbose (in case of "should be NULL") or grammatically not totally correct, I can not tell if

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

mhalk added inline comments. Herald added a subscriber: sunshaoce. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8634 +def warn_hip_omp_target_directives : Warning< + "HIP does not support OpenMP target directives; directive has been ignored">, + InGroup;

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit flag

RKSimon added a comment. In D145715#4185070 , @thetruestblue wrote: > This looks good to me. I'm not sure the policy on what should be added to the > release notes. But this was a temporary flag only added to slowly deprecate > this, and was noted

[PATCH] D145781: [AArch64] Don't #define __ARM_FP when there's no FPU.

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145781/new/ https://reviews.llvm.org/D145781

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit flag

wrotki added a comment. LGTM, perhaps with addressing @RKSimon remark about release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145715/new/ https://reviews.llvm.org/D145715 ___ cfe-commits

[clang] 326c135 - [NFC] [CMake] Cleanup clang tool dependencies

Author: Chris Bieneman Date: 2023-03-10T10:56:07-06:00 New Revision: 326c13531af32df8361cb4c98d2cc1355b0f8c48 URL: https://github.com/llvm/llvm-project/commit/326c13531af32df8361cb4c98d2cc1355b0f8c48 DIFF:

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit flag

thetruestblue accepted this revision. thetruestblue added a comment. This revision is now accepted and ready to land. This looks good to me. I'm not sure the policy on what should be added to the release notes. But this was a temporary flag only added to slowly deprecate this, and was noted

[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute

wanders added a comment. In D144405#4184964 , @erichkeane wrote: > So here's a potential idea for future development: It isn't > uncommon/untypical for an attribute to want to return something other than > '1', for 'version' (usually an integral

  1   2   3   >