[PATCH] D147266: [AArch64] Sink operands to allow for bitselect instructions

pranavk updated this revision to Diff 521545. pranavk added a comment. More concise pattern matching Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147266/new/ https://reviews.llvm.org/D147266 Files:

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

thetruestblue added inline comments. Comment at: compiler-rt/test/asan_abi/lit.cfg.py:83 +# Only run the tests on supported OSs. +if config.host_os not in ['Darwin']: + config.unsupported = True MaskRay wrote: > `!=` The thought here was to leave basic lit

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

thesamesam added a comment. Adding to the concerns raised above, I don't think we're there yet. See https://bugs.gentoo.org/buglist.cgi?quicksearch=enum-constexpr-conversion_id=6843355 and keep in mind that a bunch of stuff isn't buildable with Clang 16 yet anyway so I expect a bunch more to

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

SixWeining updated this revision to Diff 521541. SixWeining added a comment. Only allow non-prefixed names for GPRs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136436/new/ https://reviews.llvm.org/D136436 Files:

[PATCH] D146188: [Clang][DOC] Add documentation in for __builtin_flt_rounds and __builtin_set_flt_rounds

This revision was automatically updated to reflect the committed changes. xiongji90 marked an inline comment as done. Closed by commit rG2ed77846a916: This patch adds doc for __builtin_flt_rounds and __builtin_set_flt_rounds (authored by xiongji90). Repository: rG LLVM Github Monorepo CHANGES

[clang] 2ed7784 - This patch adds doc for __builtin_flt_rounds and __builtin_set_flt_rounds

Author: jinge90 Date: 2023-05-12T11:12:36+08:00 New Revision: 2ed77846a9161106a26d1efa9b68a3122856b434 URL: https://github.com/llvm/llvm-project/commit/2ed77846a9161106a26d1efa9b68a3122856b434 DIFF: https://github.com/llvm/llvm-project/commit/2ed77846a9161106a26d1efa9b68a3122856b434.diff LOG:

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

manojgupta added a comment. We also use Wno-enum-constexpr-conversion in ChromeOS. There are many packages that break with this warning. One of them is boost which is used in many other packages. The errors in boost were: ./boost/mpl/aux_/integral_wrapper.hpp:73:31: error: integer value -1

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1789-1791 +SemaDiagnosticBuilder =(SemaDiagnosticBuilder &) = delete; SemaDiagnosticBuilder(const SemaDiagnosticBuilder &) = default; +SemaDiagnosticBuilder =(const SemaDiagnosticBuilder &) =

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

rupprecht added a comment. We're still using `-Wno-enum-constexpr-conversion`, although I'm not sure if we need that or if we just forgot to remove it after doing some cleanup. I'm trying it out now. (Sorry, I'm not sure we were aware that having a way to turn this off was just temporary).

[PATCH] D150411: [NFC][Clang] Fix Static Code Analysis Concerns

Manna updated this revision to Diff 521529. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Analysis/Analyses/Consumed.h

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon added a comment. In the last commit I believe I addressed the last review comments and I added an OMPIRBuilderTest testing some of the functionality of the registerTargetGlobalVariable and getAddrOfDeclareTargetVar functionality! Just to maintain the standard of making tests for

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

tangyouling added a comment. The patch will continue to be updated by @SixWeining . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136436/new/ https://reviews.llvm.org/D136436 ___ cfe-commits mailing

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon updated this revision to Diff 521528. agozillon added a comment. - [Clang][OpenMP][IRBuilder] Tidy up function calls with helpful reviewer advice - [Clang][OpenMP][IRBuilder] Replace all getTargetEntryUniqueInfo with IRBuilder version - [Clang][OpenMP][IRBuilder] Run clang-format and

[PATCH] D148654: Modify BoundsSan to improve debuggability

oskarwirga updated this revision to Diff 521525. oskarwirga added a comment. clang-format  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148654/new/ https://reviews.llvm.org/D148654 Files: clang/lib/CodeGen/CGExpr.cpp

[PATCH] D150411: [NFC][Clang] Fix Static Code Analysis Concerns

Manna abandoned this revision. Manna added a comment. Wrong patch. Closing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 ___ cfe-commits mailing list

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

ychen added a comment. Sorry for the long delay guys. I'll update the patch this weekend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 ___ cfe-commits

[PATCH] D150411: [NFC][Clang] Fix Static Code Analysis Concerns

Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: steakhal, arphaman. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch adds missing assignment operator to the

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

MaskRay added a comment. In D143675#4310904 , @vitalybuka wrote: > In D143675#4310734 , @rsundahl > wrote: > >> @kcc @eugenis @MaskRay @vitalybuka Ok to go with this? All new functionality >> is under the

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

MaskRay added a comment. In D143675#4336365 , @rsundahl wrote: > In D143675#4310903 , @eugenis wrote: > >> I'm fine with it in general. Is asan_abi.cpp meant as a temporary stub? It's >> not even link anywhere

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:2537 -TEST(TransferTest, DerefDependentPtr) { std::string Code = R"( This `DerefDependentPtr` test was originally added in

[PATCH] D149816: [clang][Interp] Implement __builtin_strcmp

shafik accepted this revision. shafik added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149816/new/ https://reviews.llvm.org/D149816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149816: [clang][Interp] Implement __builtin_strcmp

shafik added inline comments. Comment at: clang/test/AST/Interp/builtin-functions.cpp:8 + + static_assert(__builtin_strcmp("abab", "abab") == 0); + static_assert(__builtin_strcmp("abab", "abba") == -1); Both empty strings `""` would be good as well. CHANGES

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

MaskRay added inline comments. Comment at: compiler-rt/lib/asan_abi/asan_abi_shim.cpp:14 +extern "C" { +// Globals +void __asan_register_image_globals(uptr *flag) { Comments are usually a complete sentence with a period. There are exceptions, but a "Globals"

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

shafik updated this revision to Diff 521507. shafik added a comment. - Adding release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150226/new/ https://reviews.llvm.org/D150226 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticASTKinds.td

[clang] ba566ff - [NFC][AST] Return void from setUseQualifiedLookup

Author: Vitaly Buka Date: 2023-05-11T17:13:19-07:00 New Revision: ba566fffb205a338c0a6e382b64d84b3a1e21fb6 URL: https://github.com/llvm/llvm-project/commit/ba566fffb205a338c0a6e382b64d84b3a1e21fb6 DIFF: https://github.com/llvm/llvm-project/commit/ba566fffb205a338c0a6e382b64d84b3a1e21fb6.diff

[PATCH] D147266: [AArch64] Sink operands to allow for bitselect instructions

pranavk updated this revision to Diff 521505. pranavk added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147266/new/ https://reviews.llvm.org/D147266 Files: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

vitalybuka added inline comments. Comment at: compiler-rt/lib/asan_abi/asan_abi_shim.cpp:62 +void __asan_init(void) { +assert(sizeof(uptr) == 8); +assert(sizeof(u64) == 8); static_assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl added a comment. In D143675#4310903 , @eugenis wrote: > I'm fine with it in general. Is asan_abi.cpp meant as a temporary stub? It's > not even link anywhere in the current version. We now use it during testing to close the loop on the

[PATCH] D147266: [AArch64] Sink operands to allow for bitselect instructions

pranavk added a comment. tests coming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147266/new/ https://reviews.llvm.org/D147266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148490: [AIX] use system assembler for assembly files

MaskRay added a comment. In D148490#4334476 , @shchenz wrote: >> I am not sure you need 6 RUN lines to test this. Whether a target uses >> integrated assembler has an existing test file and you can reuse that. > > I don't have strong prefer which one we

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl updated this revision to Diff 521482. rsundahl added a comment. Fixed nits (missing newlines at end of files) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675 Files:

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok looks great to me now! Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:2364 + Node->getBeginLoc())) { + UnsafeBufferUsageReporter R(S); +

[PATCH] D149809: [Clang][Docs] Fix man page build

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149809/new/ https://reviews.llvm.org/D149809

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl updated this revision to Diff 521479. rsundahl added a comment. Added testing. Removed asan_abi_shim.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675 Files:

[PATCH] D149809: [Clang][Docs] Fix man page build

aidengrossman added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149809/new/ https://reviews.llvm.org/D149809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147266: [AArch64] Sink operands to allow for bitselect instructions

pranavk updated this revision to Diff 521474. pranavk edited the summary of this revision. pranavk added a comment. Address reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147266/new/ https://reviews.llvm.org/D147266 Files:

[PATCH] D147266: [AArch64] Sink operands to allow for bitselect instructions

pranavk planned changes to this revision. pranavk marked 2 inline comments as done. pranavk added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:14343 +// passed to this function. Starting pattern matching with any other +// instruction

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

Maetveis accepted this revision. Maetveis added a comment. This revision is now accepted and ready to land. I don't see anything in here that would block later extension for supporting offloading, so LGTM from my POV. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa

jyu2 updated this revision to Diff 521465. jyu2 added a comment. Address Eli's comment. Thanks for review!. :-( Sorry, You are right!! It is seems EmitSehTryScopeBegin is not called anywhere. Changed. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

galenelias created this revision. galenelias added reviewers: cpplearner, HazardyKnusperkeks, MyDeveloperDay. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, owenpan. galenelias requested review of this revision. This is a

[PATCH] D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGException.cpp:650 +llvm::FunctionCallee SehCppScope = getSehTryBeginFn(CGM); +EmitSehScope(SehCppScope); + } jyu2 wrote: > efriedma wrote: > > Do we need to make the same change

[clang] 62c4c61 - Remove outdated sentence in SourceBasedCodeCoverage.rst

Author: Zequan Wu Date: 2023-05-11T17:17:57-04:00 New Revision: 62c4c614eea8078918d04cb33ce54ef8f9987766 URL: https://github.com/llvm/llvm-project/commit/62c4c614eea8078918d04cb33ce54ef8f9987766 DIFF: https://github.com/llvm/llvm-project/commit/62c4c614eea8078918d04cb33ce54ef8f9987766.diff

[PATCH] D149800: [WIP][PGO] Add ability to mark cold functions as optsize/minsize/optnone

yamauchi added a comment. In D149800#4330831 , @davidxl wrote: > This patch uses a cleaner method than the previous effort. There is some > differences: > > 1. yamauchi's patch works for both iFDO and autoFDO, while this patch limits > to iFDO > 2.

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

scott.linder added inline comments. Comment at: clang/include/clang/Driver/Compilation.h:279 + void addTimeTraceFile(const char *Name, const JobAction *JA) { +TimeTraceFiles[JA] = Name; + } MaskRay wrote: > scott.linder wrote: > > If this is overriding

[PATCH] D150013: [Clang] Respect `-L` options when compiling directly for AMDGPU

This revision was automatically updated to reflect the committed changes. Closed by commit rG027aeec7da67: [Clang] Respect `-L` options when compiling directly for AMDGPU (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 027aeec - [Clang] Respect `-L` options when compiling directly for AMDGPU

Author: Joseph Huber Date: 2023-05-11T16:02:54-05:00 New Revision: 027aeec7da67afe33b159f5e42dec57488897454 URL: https://github.com/llvm/llvm-project/commit/027aeec7da67afe33b159f5e42dec57488897454 DIFF: https://github.com/llvm/llvm-project/commit/027aeec7da67afe33b159f5e42dec57488897454.diff

[PATCH] D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGException.cpp:650 +llvm::FunctionCallee SehCppScope = getSehTryBeginFn(CGM); +EmitSehScope(SehCppScope); + } efriedma wrote: > Do we need to make the same change in

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

MaskRay added a comment. In D150282#4335568 , @scott.linder wrote: > Does GCC have the same `-ftime-trace=` option? It seems like it doesn't, as > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92396 is still open? You found it! I am trying to collect

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize/use-std-print.rst:117 + +.. option:: PrintFunction + Is `PrintFunction` (and the soon-to-arrive `PrintlnFunction`) distinct enough from `PrintfLikeFunctions` and

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

MaskRay updated this revision to Diff 521427. MaskRay marked an inline comment as done. MaskRay edited the summary of this revision. MaskRay added a comment. add an assert to addTimeTraceFile. improve a -dumpdir test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:36 + /// `S` resides. `D.isTemplated()` must be false. + static llvm::Expected build(const Decl , Stmt , +

[PATCH] D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGException.cpp:650 +llvm::FunctionCallee SehCppScope = getSehTryBeginFn(CGM); +EmitSehScope(SehCppScope); + } Do we need to make the same change in EmitSEHTryStmt/ExitSEHTryStmt?

[PATCH] D150258: [clang][parser] Fix namespace dropping after malformed declarations

aaron.ballman added a comment. Thank you for working on this! FWIW, I verified that the precommit CI failures are unrelated to this patch. Can you add a release note to `clang/docs/ReleaseNotes.rst` about the fix? Comment at: clang/lib/Parse/ParseDecl.cpp:2179-2180 -

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 updated this revision to Diff 521409. ziqingluo-90 added a comment. Address comments: refactor the callable-definition visitor to take a lambda Callback, who calls various analyses that need whole-TU information.If one needs to add a new such analysis later, just add a call

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 521406. void added a comment. Use strings for the attribute argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files: clang/include/clang/Basic/Attr.td

[PATCH] D150321: [clang] Document extensions from later standards

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. philnik marked an inline comment as done. Closed by commit rGb09fad7f8e9c: [clang] Document extensions from later standards (authored by philnik). Changed prior to

[clang] b09fad7 - [clang] Document extensions from later standards

Author: Nikolas Klauser Date: 2023-05-11T11:54:46-07:00 New Revision: b09fad7f8e9ce5b88fb467be012ea379efa3659d URL: https://github.com/llvm/llvm-project/commit/b09fad7f8e9ce5b88fb467be012ea379efa3659d DIFF:

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE__`

yaxunl updated this revision to Diff 521396. yaxunl retitled this revision from "[AMDGPU] Emit predefined macro `__AMDGCN_CUMODE`" to "[AMDGPU] Emit predefined macro `__AMDGCN_CUMODE__`". yaxunl edited the summary of this revision. yaxunl added a comment. rename the macro to be consistent with

[PATCH] D150321: [clang] Document extensions from later standards

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, this is awesome -- thank you for the improved docs! Comment at: clang/docs/LanguageExtensions.rst:1373 +Language extensions back-ported to previous

[PATCH] D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941

scott.linder added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIMemoryLegalizer.cpp:517-529 + bool tryForceStoreSC0SC1(const SIMemOpInfo , + MachineBasicBlock::iterator ) const override { +if (ST.hasForceStoreSC0SC1() && +

[PATCH] D149158: [clang][analyzer] Cleanup tests of StdCLibraryFunctionsChecker (NFC)

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM, premerge checks are green AFAICT. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149158/new/ https://reviews.llvm.org/D149158

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

dblaikie added a comment. In D147844#4329497 , @aaron.ballman wrote: > In general, I think this is incremental progress on the diagnostic behavior. > However, it's clear that there is room for interpretation on what is or is > not a false positive

[PATCH] D150139: [clang-repl] Enable basic multiline support.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/Interpreter/multiline.cpp:12-17 +void f(int x) \ +{ \ + printf("x=\ +

[PATCH] D149642: [RISCV] Support vreinterpret intrinsics between vector boolean type and m1 vector integer type

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2042 + + SmallVector Operands; + if (ResultType->isIntOrIntVectorTy(1)) { This SmallVector is unused Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

scott.linder added a comment. Does GCC have the same `-ftime-trace=` option? It seems like it doesn't, as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92396 is still open? If so, I am happy with unifying more of the dump/aux handling, and I imagine when/if GCC adds the option it will behave

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

MaskRay updated this revision to Diff 521379. MaskRay marked an inline comment as done. MaskRay edited the summary of this revision. MaskRay added a comment. Add a warning test. Report -Wunused-command-line-argument warning for -ftime-trace-granularity=0 if unused as well. Repository: rG

[PATCH] D150191: [clang][Diagnostics] Provide a source range for 'use of undeclared identifier' diagnostics

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:2187 else - SemaRef.Diag(TypoLoc, DiagnosticID) << Typo; + SemaRef.Diag(TypoRange.getEnd(), DiagnosticID) << Typo; return; tbaeder wrote: > I'm not passing the

[PATCH] D150321: [clang] Document extensions from later standards

philnik updated this revision to Diff 521375. philnik marked 5 inline comments as done. philnik added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150321/new/ https://reviews.llvm.org/D150321 Files:

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

MaskRay marked an inline comment as done. MaskRay added a comment. In D150282#4334927 , @Maetveis wrote: > LGTM, but I don't feel like I have the experience to "formally" approve. I > left a nice-to have suggestion too, but feel free to ignore, if you

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added a subscriber: efriedma. bolshakov-a added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4397 +// argument. +// As proposed in https://github.com/itanium-cxx-abi/cxx-abi/issues/111. +auto *SNTTPE = cast(E); erichkeane

[PATCH] D150209: [clang][Interp] Add more shift error checking

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/shifts.cpp:165-171 + constexpr int negativeShift() { // cxx17-error {{never produces a constant expression}} \ + // ref-cxx17-error {{never produces a constant expression}}

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

aaron.ballman added a comment. In D147844#4333407 , @ldionne wrote: > Code changes in libc++ and libc++abi LGTM. I am neutral on whether the > diagnostic is worth adding, but don't consider libc++ and libc++abi as > blockers for this patch. Thank you

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs added a comment. In D150291#4335352 , @tahonermann wrote: > Thanks for all the updates @codemzs! I'm going to go ahead and accept. But > please wait a few days for recently subscribed folks to have a chance to > comment before landing this.

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs updated this revision to Diff 521363. codemzs marked an inline comment as done. codemzs added a comment. Addressing feedback from @barannikov88 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150291/new/ https://reviews.llvm.org/D150291 Files: clang/include/clang-c/Index.h

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

aaron.ballman added a comment. In D144943#4334500 , @tbaeder wrote: > Pig  Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:74 + // FIXME: Diagnostics. + if (ToType->isArrayType() || ToType->isPointerType()) +return false;

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

barannikov88 added a comment. In D150291#4335414 , @codemzs wrote: > I've provided the git log message that I see on my end below. I ensured that > it is split into multiple lines, with each line not exceeding the character > limit. Please let me know

[PATCH] D150318: [clang][deps] NFC: Pass around the whole scanning service

benlangmuir added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h:69 + /// The preprocessing mode used for scanning. + ScanningMode Mode; + /// The output format. jansvoboda11 wrote: > benlangmuir

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs marked an inline comment as done. codemzs added a comment. In D150291#4335360 , @barannikov88 wrote: > The summary as it is will be hard to read in git log. Please split it into > multiple lines 72~80 chars each. >

[PATCH] D150318: [clang][deps] NFC: Pass around the whole scanning service

jansvoboda11 added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h:69 + /// The preprocessing mode used for scanning. + ScanningMode Mode; + /// The output format. benlangmuir wrote: > Why drop `const`?

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

barannikov88 added a comment. The summary as it is will be hard to read in git log. Please split it into multiple lines 72~80 chars each. https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Thanks for all the updates @codemzs! I'm going to go ahead and accept. But please wait a few days for recently subscribed folks to have a chance to comment before landing this.

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

barannikov88 added inline comments. Comment at: clang/lib/AST/Type.cpp:2187 + BT->getKind() <= BuiltinType::Ibm128 && + BT->getKind() != BuiltinType::BF16; if (const auto *ET = dyn_cast(CanonicalType)) Looks like another clang-format

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs updated this revision to Diff 521353. codemzs marked 2 inline comments as done. codemzs set the repository for this revision to rG LLVM Github Monorepo. codemzs added a comment. Update comments as per feedback from @tahonermann Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

tahonermann added a subscriber: clang-vendors. tahonermann added a comment. Heads up @clang-vendors. This patch changes the names of many internal identifiers for enumerators, class data members, and functions (including virtual functions) that are related to support for the `__bf16` type. The

[PATCH] D149816: [clang][Interp] Implement __builtin_strcmp

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:22-23 + +static bool interp__builtin_strcmp(InterpState , CodePtr OpPC, +

[PATCH] D150364: [clang][Interp] Add 'Unsupported' opcode and use it for throw stmts

aaron.ballman added a comment. In D150364#4335261 , @tbaeder wrote: > In D150364#4335221 , @aaron.ballman > wrote: > >> "Unsupported" is a bit of a loaded term -- it could mean "this operation is >> not

[PATCH] D149816: [clang][Interp] Implement __builtin_strcmp

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:22-23 + +static bool interp__builtin_strcmp(InterpState , CodePtr OpPC, + InterpFrame *Frame) { + const Pointer = getParam(Frame, 0);

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

tahonermann added subscribers: lenary, foad. tahonermann added a comment. > I was following the LLVM contribution guidelines to use git clang-format, but > I understand the importance of maintaining existing code styles that may be > altered by git-clang format. The guidelines are slightly in

[PATCH] D150364: [clang][Interp] Add 'Unsupported' opcode and use it for throw stmts

tbaeder updated this revision to Diff 521346. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150364/new/ https://reviews.llvm.org/D150364 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp

[PATCH] D149816: [clang][Interp] Implement __builtin_strcmp

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:22-23 + +static bool interp__builtin_strcmp(InterpState , CodePtr OpPC, + InterpFrame *Frame) { + const Pointer = getParam(Frame, 0);

[PATCH] D150364: [clang][Interp] Add 'Unsupported' opcode and use it for throw stmts

tbaeder added a comment. In D150364#4335221 , @aaron.ballman wrote: > "Unsupported" is a bit of a loaded term -- it could mean "this operation is > not supported, YET" or it could mean "this operation is not and will not be > supported, EVER". Perhaps

[PATCH] D150326: [WPD] Update llvm.public.type.test after importing functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa40b0c3e77a2: [WPD] Update llvm.public.type.test after importing functions (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D150326: [WPD] Update llvm.public.type.test after importing functions

tejohnson updated this revision to Diff 521340. tejohnson marked an inline comment as done. tejohnson added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150326/new/ https://reviews.llvm.org/D150326 Files:

[PATCH] D150326: [WPD] Update llvm.public.type.test after importing functions

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: llvm/test/ThinLTO/X86/public-type-test.ll:31 ; HIDDEN-NOT: call {{.*}}@llvm.public.type.test ; HIDDEN: call {{.*}}@llvm.type.test aeubanks wrote: > should this be

[PATCH] D150364: [clang][Interp] Add 'Unsupported' opcode and use it for throw stmts

aaron.ballman added a comment. "Unsupported" is a bit of a loaded term -- it could mean "this operation is not supported, YET" or it could mean "this operation is not and will not be supported, EVER". Perhaps something more like "InvalidInConstantExpr" would be more descriptive?

[PATCH] D150321: [clang] Document extensions from later standards

aaron.ballman added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1386 +Relaxed constexpr __cpp_constexpr C++14 C++11 +Designated initializers __cpp_designated_initializersC++20 C++03

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 521330. chaitanyav added a comment. Rebase with upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D149158: [clang][analyzer] Cleanup tests of StdCLibraryFunctionsChecker (NFC)

balazske updated this revision to Diff 521326. balazske added a comment. Change of some type definitions, using `restrict` again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149158/new/ https://reviews.llvm.org/D149158 Files:

[PATCH] D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941

kzhuravl added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIMemoryLegalizer.cpp:524 + SIAtomicAddrSpace::NONE) + return enableSC0Bit(MI) | enableSC1Bit(MI); +return false; Pierre-vh wrote: > kzhuravl wrote: > > jmmartinez wrote: > > >

[PATCH] D150321: [clang] Document extensions from later standards

philnik added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1386 +Relaxed constexpr __cpp_constexpr C++14 C++11 +Designated initializers __cpp_designated_initializersC++20 C++03 +Attributes on

  1   2   >