[PATCH] D150253: [RISCV] Add Zvfhmin extension.

jacquesguan added a comment. In D150253#4343699 , @craig.topper wrote: > In D150253#4341545 , @jacquesguan > wrote: > >> To enable specific EEW for specific insturction in instruction selection, I >> will

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

pengfei added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:1043 +///corresponding byte of the 256-bit integer vector result (overflow is +///ignored). For each byte, computes result = __a - __b . +/// It better to move it to

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

hubert.reinterpretcast added a comment. In D150221#4343546 , @efriedma wrote: > It's not unprecedented to add flags to copy the behavior of other compilers, > to make porting easier, especially when it doesn't place much burden on > compiler

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz added a comment. Requesting for some advice Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:1666 + +$anon[[struct { + int x; This is unwanted behavior from my understanding. Do you guys have any insight how we could fix

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz updated this revision to Diff 522434. daiyousei-qz added a comment. minor naming fix2 (last fix breaks builds) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150635/new/ https://reviews.llvm.org/D150635 Files:

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz updated this revision to Diff 522432. daiyousei-qz edited the summary of this revision. daiyousei-qz added a comment. minor naming fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150635/new/ https://reviews.llvm.org/D150635 Files:

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. daiyousei-qz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl marked 2 inline comments as done. rsundahl added a comment. Suggestions for compiler-rt/docs/asan_abi.md are captured in the successor file compiler-rt/docs/ASanABI.rst and marked complete. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl marked 4 inline comments as done. rsundahl added a comment. Suggestions for compiler-rt/docs/asan_abi.md are captured in the successor file compiler-rt/docs/ASanABI.rst and marked complete. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl marked 22 inline comments as done. rsundahl added a comment. Thank you for your review and thoughtful input @eugenis, @MaskRay and @vitalybuka. I think we're close to having everything incorporated. (@MaskRay, the doc files went from .md to .rst and I implemented all of your

[PATCH] D150597: [clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150597/new/ https://reviews.llvm.org/D150597

[clang] 88a720d - [NFC] [C++20] [Modules] Rename ASTContext::getNamedModuleForCodeGen to ASTContext::getCurrentNamedModule

Author: Chuanqi Xu Date: 2023-05-16T11:24:35+08:00 New Revision: 88a720d19479e4cad186f00a9911714c3d77303a URL: https://github.com/llvm/llvm-project/commit/88a720d19479e4cad186f00a9911714c3d77303a DIFF: https://github.com/llvm/llvm-project/commit/88a720d19479e4cad186f00a9911714c3d77303a.diff

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl updated this revision to Diff 522417. rsundahl added a comment. Applied suggestions from reviewers Cleaned up options parsing Moved test into stanalone file fsanitize-stable-abi.c Changed target triple to arm64-apple-darwin Changed documentation style from proposal to specification

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG369e8762b4d6: [clang-format] Stop comment disrupting indentation of Verilog ports (authored by sstwcw). Repository: rG LLVM Github Monorepo

[clang] 369e876 - [clang-format] Stop comment disrupting indentation of Verilog ports

Author: sstwcw Date: 2023-05-16T02:56:58Z New Revision: 369e8762b4d658e6e8f8310200aadf043bd7f01e URL: https://github.com/llvm/llvm-project/commit/369e8762b4d658e6e8f8310200aadf043bd7f01e DIFF: https://github.com/llvm/llvm-project/commit/369e8762b4d658e6e8f8310200aadf043bd7f01e.diff LOG:

[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ddae8b94139: [clangd] Fix test failure when its built with compiler flags unknown by clang (authored by xry111, committed by thesamesam).

[clang-tools-extra] 4ddae8b - [clangd] Fix test failure when it's built with compiler flags unknown by clang

Author: Xi Ruoyao Date: 2023-05-16T03:56:26+01:00 New Revision: 4ddae8b941398a6579d3a6f25aa39a260e441371 URL: https://github.com/llvm/llvm-project/commit/4ddae8b941398a6579d3a6f25aa39a260e441371 DIFF: https://github.com/llvm/llvm-project/commit/4ddae8b941398a6579d3a6f25aa39a260e441371.diff

[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. (I even struggled to find docs for the fix we used for clang-tidy, although it obviously works.) Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146054: [RISCV] Add --print-supported-extensions and -march=help support

4vtomat updated this revision to Diff 522411. 4vtomat added a comment. Resolved MaskRay's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 Files: clang/include/clang/Driver/Options.td

[clang] 7f37066 - Revert "[NFC] [C++20] [Modules] Refactor Sema::isModuleUnitOfCurrentTU into"

Author: Chuanqi Xu Date: 2023-05-16T10:47:53+08:00 New Revision: 7f37066915ab330f153ede708ddc610cf2cb7bdf URL: https://github.com/llvm/llvm-project/commit/7f37066915ab330f153ede708ddc610cf2cb7bdf DIFF: https://github.com/llvm/llvm-project/commit/7f37066915ab330f153ede708ddc610cf2cb7bdf.diff

[clang] 40c3054 - [NFC] [C++20] [Modules] Refactoring b6c7177145bc to make it not

Author: Chuanqi Xu Date: 2023-05-16T10:34:02+08:00 New Revision: 40c30543892aa6441eea075ba69864e79f5de82e URL: https://github.com/llvm/llvm-project/commit/40c30543892aa6441eea075ba69864e79f5de82e DIFF: https://github.com/llvm/llvm-project/commit/40c30543892aa6441eea075ba69864e79f5de82e.diff

[PATCH] D150614: [clang-format] Ignore first token when finding MustBreak

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:891-895 +for (const FormatToken *Tok = Line->First; Tok; Tok = Tok->Next) { + // Ignore the first token, because in this situation, it applies more + // to the last token of the

[PATCH] D150629: [clang-format] Don't allow template to be preceded by closing brace

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:10682 verifyFormat("a < 0 ? b : a > 0 ? c : d;"); + verifyFormat("ratio{-1, 2} < ratio{-1, 3} == -1 / 3 > -1 / 2;"); verifyFormat("void f() {\n" Do we need to add a token

[PATCH] D150629: [clang-format] Don't allow template to be preceded by closing brace

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. This check is similar to the right paren

[PATCH] D150539: [clang-format] Handle ud suffixes in IntegerLiteralSeparator

owenpan updated this revision to Diff 522397. owenpan added a comment. Addressed the review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150539/new/ https://reviews.llvm.org/D150539 Files: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp

[PATCH] D150539: [clang-format] Handle ud suffixes in IntegerLiteralSeparator

owenpan added inline comments. Comment at: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp:116-117 if (Style.isCpp()) { - if (const auto Pos = Text.find_first_of("_i"); Pos != StringRef::npos) { + // FIXME: This doesn't work for ud-suffix d from

[PATCH] D150615: [clang][deps] Do not cache PCM files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94d22b09bbb2: [clang][deps] Do not cache PCM files (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 94d22b0 - [clang][deps] Do not cache PCM files

Author: Jan Svoboda Date: 2023-05-15T17:43:54-07:00 New Revision: 94d22b09bbb212773a226726ee03a44edbbe98c7 URL: https://github.com/llvm/llvm-project/commit/94d22b09bbb212773a226726ee03a44edbbe98c7 DIFF: https://github.com/llvm/llvm-project/commit/94d22b09bbb212773a226726ee03a44edbbe98c7.diff

[clang] 09c5d69 - Revert "[clang][deps] Only cache files with specific extension"

Author: Jan Svoboda Date: 2023-05-15T17:43:53-07:00 New Revision: 09c5d69592f7df4db62063e4dd231a7e154bdac6 URL: https://github.com/llvm/llvm-project/commit/09c5d69592f7df4db62063e4dd231a7e154bdac6 DIFF: https://github.com/llvm/llvm-project/commit/09c5d69592f7df4db62063e4dd231a7e154bdac6.diff

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

barannikov88 added a comment. In D150608#4344170 , @jdoerfert wrote: > LG, assuming these are stable now. > > We should move them to the update scripts though... I'm not sure what you mean by this? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

craig.topper added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:156 +///A 256-bit vector containing one of the source operands. +/// \returns A 256-bit vector containing the sums. static __inline__ __m256i __DEFAULT_FN_ATTRS256 Why do some

[PATCH] D146773: [-Wunsafe-buffer-usage] Make raw (ungrouped) warnings a bit more verbose.

NoQ added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11786 + "%select{" +"unsafe operation on raw pointer in expression|" +"unsafe arithmetic on raw pointer|" malavikasamak wrote: > NoQ wrote: > > The first mode

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

denizevrenci updated this revision to Diff 522386. denizevrenci added a comment. a_shouldNotDiag -> b_shouldNotDiag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147417/new/ https://reviews.llvm.org/D147417 Files:

[PATCH] D149642: [RISCV] Support vreinterpret intrinsics between vector boolean type and m1 vector integer type

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149642/new/ https://reviews.llvm.org/D149642

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

denizevrenci updated this revision to Diff 522381. denizevrenci added a comment. Herald added a project: clang. Address comments. Implement a special case for coroutines in ExceptionAnalyzer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147417/new/

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, assuming these are stable now. We should move them to the update scripts though... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149119: [CMake] Use LLVM own tools in extract_symbols.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGf649599ea933: [CMake] Use LLVM own tools in extract_symbols.py (authored by ikudrin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149119/new/

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @erichkeane - I took your example and tried to reduce it further https://godbolt.org/z/jEx9vdj7K It's kind of a difficult situation - both gcc and msvc accept it, yet /* very very cautiously */ it might happen that the code is actually invalid ... (i'd

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

barannikov88 added a comment. I first manually converted a few tests (mostly with regexes), then I checked that the script produces the same result. The result was identical to the letter. The rest of

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

yonghong-song added a comment. @dblaikie could you help take a look at this patch? Similar to https://reviews.llvm.org/D143966, this patch is the clang frontend change to support new btf_type_tag format, as we discussed and agreed with gcc community

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

jdoerfert added a comment. Did you manually update these tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150608/new/ https://reviews.llvm.org/D150608 ___ cfe-commits mailing list

[PATCH] D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM... but I don't think the IR we're generating is really correct overall; see https://github.com/llvm/llvm-project/issues/62723 On a side-note, other open issues related to -EHa/__try:

[PATCH] D150615: [clang][deps] Do not cache PCM files

jansvoboda11 created this revision. jansvoboda11 added a reviewer: Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On incremental scan, caching an

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. I see nothing wrong with this patch alone as it currently stands, since it's a quite simple change to the LineJoiner, and I see it as one of the final stopgaps in clang-format's support for

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

barannikov88 updated this revision to Diff 522342. barannikov88 added a comment. Throw in a few more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150608/new/ https://reviews.llvm.org/D150608 Files:

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 updated this revision to Diff 522338. eddyz87 edited the summary of this revision. eddyz87 added a comment. Changes to avoid attaching type tags to DWARF derived types for const/volatile/restrict qualifiers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150614: [clang-format] Ignore first token when finding MustBreak

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. When in ColumnLimit 0, the formatter looks

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

galenelias added a comment. Thanks @HazardyKnusperkeks! I don't have commit access, so will need someone to land this for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150403/new/ https://reviews.llvm.org/D150403 ___ cfe-commits

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

barannikov88 added inline comments. Comment at: clang/test/OpenMP/task_firstprivate_codegen.cpp:264 -// CHECK: alloca i32*, -// CHECK: [[PRIV_T_VAR_ADDR:%.+]] = alloca i32*, -// CHECK: [[PRIV_S_ARR_ADDR:%.+]] = alloca [2 x [[S_DOUBLE_TY]]]*, -// CHECK: [[PRIV_VEC_ADDR:%.+]] =

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

craig.topper added a subscriber: michaelmaitland. craig.topper added a comment. In D150253#4341545 , @jacquesguan wrote: > To enable specific EEW for specific insturction in instruction selection, I > will create some parent revisions. Here is the

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

barannikov88 added inline comments. Comment at: clang/test/OpenMP/task_firstprivate_codegen.cpp:264 -// CHECK: alloca i32*, -// CHECK: [[PRIV_T_VAR_ADDR:%.+]] = alloca i32*, -// CHECK: [[PRIV_S_ARR_ADDR:%.+]] = alloca [2 x [[S_DOUBLE_TY]]]*, -// CHECK: [[PRIV_VEC_ADDR:%.+]] =

[PATCH] D150494: [clang][modules] NFC: Only sort interesting identifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf60cc473b82b: [clang][modules] NFC: Only sort interesting identifiers (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[clang] f60cc47 - [clang][modules] NFC: Only sort interesting identifiers

Author: Jan Svoboda Date: 2023-05-15T13:28:10-07:00 New Revision: f60cc473b82b16edc448199c84e612c1e5c3014c URL: https://github.com/llvm/llvm-project/commit/f60cc473b82b16edc448199c84e612c1e5c3014c DIFF: https://github.com/llvm/llvm-project/commit/f60cc473b82b16edc448199c84e612c1e5c3014c.diff

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Thanks for putting so much efforts into this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148997/new/

[PATCH] D150539: [clang-format] Handle ud suffixes in IntegerLiteralSeparator

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp:116-117 if (Style.isCpp()) { - if (const auto Pos =

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. There is probably more reduction work to be done, but I hit the end of my day here: https://godbolt.org/z/Tzfx31asK Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178

[PATCH] D148995: [clang-tidy] Extract areStatementsIdentical

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ccb8061724f: [clang-tidy] Extract areStatementsIdentical (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148995/new/

[clang-tools-extra] 6ccb806 - [clang-tidy] Extract areStatementsIdentical

Author: Piotr Zegar Date: 2023-05-15T20:05:12Z New Revision: 6ccb8061724fb6ee0b2598764656410ce3f2472c URL: https://github.com/llvm/llvm-project/commit/6ccb8061724fb6ee0b2598764656410ce3f2472c DIFF: https://github.com/llvm/llvm-project/commit/6ccb8061724fb6ee0b2598764656410ce3f2472c.diff LOG:

[PATCH] D147266: [AArch64] Sink operands to allow for bitselect instructions

pranavk added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:14361-14363 + for (unsigned Idx = 0; Idx < MainAnd->getNumOperands(); Idx++) { +if (MainAnd->getOperand(Idx) != IA) { +

[PATCH] D147266: [AArch64] Sink operands to allow for bitselect instructions

pranavk added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:14361-14363 + for (unsigned Idx = 0; Idx < MainAnd->getNumOperands(); Idx++) { +if (MainAnd->getOperand(Idx) != IA) { +

[PATCH] D147266: [AArch64] Sink operands to allow for bitselect instructions

pranavk updated this revision to Diff 522309. pranavk marked 3 inline comments as done. pranavk added a comment. address reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147266/new/ https://reviews.llvm.org/D147266 Files:

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

efriedma added a comment. It's not unprecedented to add flags to copy the behavior of other compilers, to make porting easier, especially when it doesn't place much burden on compiler maintainers. But what compiler preserves the names/values of static variables by default? It's not the sort

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

MaskRay added a comment. In D150490#4343442 , @craig.topper wrote: > In D150490#4343145 , @enh wrote: > >> In D150490#4343128 , @hiraditya >> wrote: >> Is there

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. In D146178#4343477 , @alexander-shaposhnikov wrote: > @erichkeane - I'll have stable internet ~soon and will try to look into the > reported issue (but help would be greatly appreciated). > To the best of my knowledge there

[PATCH] D150603: adding bf16 support to NVPTX

kushanam abandoned this revision. kushanam added a comment. redundant revision again on D144911 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150603/new/ https://reviews.llvm.org/D150603

[PATCH] D150603: adding bf16 support to NVPTX

kushanam created this revision. Herald added subscribers: mattd, gchakrabarti, asavonic, hiraditya. Herald added a project: All. kushanam requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, jholewinski. Herald added projects: clang, LLVM. Currently,

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @erichkeane - I'll have stable internet ~soon and will try to look into the reported issue (but help would be greatly appreciated). To the best of my knowledge there are other problems with libstdc++'s ranges (even without this diff), but yeah, this

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

mikecrowe created this revision. mikecrowe added reviewers: njames93, carlosgalvezp, PiotrZSL. Herald added a subscriber: xazax.hun. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. I'd

[PATCH] D132247: [clang] Fix emitVoidPtrVAArg for non-zero default alloca address space

This revision was automatically updated to reflect the committed changes. Closed by commit rG74f207883bc5: [clang] Fix emitVoidPtrVAArg for non-zero default alloca address space (authored by jrtc27). Changed prior to commit: https://reviews.llvm.org/D132247?vs=454033=522295#toc Repository:

[clang] 74f2078 - [clang] Fix emitVoidPtrVAArg for non-zero default alloca address space

Author: Jessica Clarke Date: 2023-05-15T20:26:49+01:00 New Revision: 74f207883bc5fe2a7300c4b4f1ff080a107ab148 URL: https://github.com/llvm/llvm-project/commit/74f207883bc5fe2a7300c4b4f1ff080a107ab148 DIFF:

[PATCH] D149612: [Sema] avoid merge error type

erichkeane added a comment. In D149612#4343440 , @HerrCai0907 wrote: > Maybe return `QualType()` as a temporary solution to avoid crash? @erichkeane I'm not sure at the moment... I'd like to have aaron take a look and chat it over with him.

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

tlively added a comment. Thanks for the ping, will take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 ___ cfe-commits mailing list

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

craig.topper added a comment. In D150490#4343145 , @enh wrote: > In D150490#4343128 , @hiraditya > wrote: > >>> Is there more context on why Android enables the frame pointer? >> >> From what i gathered, this is

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 added a comment. Maybe return `QualType()` as a temporary solution to avoid crash? @erichkeane Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D149612 ___

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 86c7e33 - Re-land "[-Wunsafe-buffer-usage] Remove an unnecessary const-qualifier"

Author: ziqingluo-90 Date: 2023-05-15T12:10:13-07:00 New Revision: 86c7e33b3fd0cc231b09b5af21ef42842f0ff97b URL: https://github.com/llvm/llvm-project/commit/86c7e33b3fd0cc231b09b5af21ef42842f0ff97b DIFF: https://github.com/llvm/llvm-project/commit/86c7e33b3fd0cc231b09b5af21ef42842f0ff97b.diff

[PATCH] D149976: adding bf16 support to NVPTX

kushanam updated this revision to Diff 522290. kushanam added a comment. Adressing review changes and removing bf16 registers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149976/new/ https://reviews.llvm.org/D149976 Files:

[PATCH] D148827: -fsanitize=function: support C

MaskRay updated this revision to Diff 522287. MaskRay added a comment. rebase the final patch in the series Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148827/new/ https://reviews.llvm.org/D148827 Files:

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay updated this revision to Diff 522286. MaskRay marked 2 inline comments as done. MaskRay added a comment. rename a variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148785/new/ https://reviews.llvm.org/D148785 Files:

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

mboehme added a subscriber: amyk. mboehme added a comment. In D150352#4342480 , @uabelho wrote: > Hello, > > > ../../clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:43:27: > error: 'build' is deprecated: Use the version that

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay marked 2 inline comments as done. MaskRay added a comment. In D148785#4343112 , @peter.smith wrote: > Should `HANDLER(__ubsan_handle_function_type_mismatch,"function")` be added > to ubsan_minimal_runtime if this is supported in the minimal

[clang] f39fd75 - Revert "[-Wunsafe-buffer-usage] Remove an unnecessary const-qualifier"

Author: ziqingluo-90 Date: 2023-05-15T11:47:00-07:00 New Revision: f39fd750ab59cb2482688168b25db303dbebdb09 URL: https://github.com/llvm/llvm-project/commit/f39fd750ab59cb2482688168b25db303dbebdb09 DIFF: https://github.com/llvm/llvm-project/commit/f39fd750ab59cb2482688168b25db303dbebdb09.diff

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added subscribers: efriedma, rjmccall. aaron.ballman added a comment. In D150221#4338500 , @qianzhen wrote: > This is useful in keeping the static variables in a patchable function >

[PATCH] D149976: adding bf16 support to NVPTX

kushanam updated this revision to Diff 522284. kushanam added a comment. Addressing review changed and removing bf16 registers Depends on D144911 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149976/new/

[PATCH] D150479: [clang][modules][deps] Allow skipping submodule definitions

benlangmuir added inline comments. Comment at: clang/test/ClangScanDeps/modules-private-framework-submodule.c:43 // CHECK-NEXT: "context-hash": "{{.*}}", -// CHECK-NEXT: "module-name": "FW2_Private" +// CHECK-NEXT: "module-name": "FW2"

[PATCH] D150494: [clang][modules] NFC: Only sort interesting identifiers

jansvoboda11 added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:3646 // file. SmallVector IIs; for (const auto : PP.getIdentifierTable()) ributzka wrote: > Would it make sense to reduce the size of the SmallVector too? That

[PATCH] D149976: adding bf16 support to NVPTX

kushanam abandoned this revision. kushanam added a comment. Redundant to D144911 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149976/new/ https://reviews.llvm.org/D149976

[PATCH] D150479: [clang][modules][deps] Allow skipping submodule definitions

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/modules-private-framework-submodule.c:43 // CHECK-NEXT: "context-hash": "{{.*}}", -// CHECK-NEXT: "module-name": "FW2_Private" +// CHECK-NEXT: "module-name": "FW2"

[PATCH] D149976: adding bf16 support to NVPTX

kushanam updated this revision to Diff 522283. kushanam added a comment. Addressing the review changed adn removing bf16 specific registers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149976/new/ https://reviews.llvm.org/D149976 Files:

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Did you end up requesting commit access? If not, now is probably a good time: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Comment

[PATCH] D150479: [clang][modules][deps] Allow skipping submodule definitions

benlangmuir added inline comments. Comment at: clang/test/ClangScanDeps/modules-private-framework-submodule.c:43 // CHECK-NEXT: "context-hash": "{{.*}}", -// CHECK-NEXT: "module-name": "FW2_Private" +// CHECK-NEXT: "module-name": "FW2"

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

donat.nagy planned changes to this revision. donat.nagy added a comment. I started to create tests to demonstrate the differences from the baseline, and it turns out that my patch is handling multidimensional arrays incorrectly. I'll debug this issue and upload a fixed version of this patch.

[PATCH] D150478: [clang][modules][deps] Parse "FW_Private" module map even after loading "FW" PCM

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM. I ran into a similar issue in a downstream branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150478/new/

[PATCH] D150494: [clang][modules] NFC: Only sort interesting identifiers

ributzka added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:3646 // file. SmallVector IIs; for (const auto : PP.getIdentifierTable()) Would it make sense to reduce the size of the SmallVector too? Repository: rG LLVM

[PATCH] D149160: [clang][analyzer] Handle special value AT_FDCWD in affected standard functions

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149160/new/ https://reviews.llvm.org/D149160

[PATCH] D150597: [clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: hubert.reinterpretcast, stephenpeckham. qiongsiwu1 added a project: clang. Herald added a subscriber: nemanjai. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe-commits.

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

yaxunl added a comment. In D147732#4343146 , @jrbyrnes wrote: > Hi @yaxunl thanks for the comment. > > I looked into AutoUpgrade, and it catches upgrades of this type (unmangled -> > mangled) by default (via remangleIntrinsicFunction). I've included

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:1121-1138 +static unsigned getNumDisplayWidth(unsigned N) { + if (N < 10) +return 1; + if (N < 100) +return 2; + if (N < 1'000) +return 3; aaronpuchert wrote: >

[PATCH] D150111: [clang][Interp] Implement lambda static invokers

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:100-103 + bool IsEligibleForCompilation = + FuncDecl->isConstexpr() || + (isa(FuncDecl) && + cast(FuncDecl)->isLambdaStaticInvoker()); I don't like the

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

enh added a comment. In D150490#4343128 , @hiraditya wrote: >> Is there more context on why Android enables the frame pointer? > > From what i gathered, this is more of an effort to have parity such that > existing build flag overrides continue to be

  1   2   3   >