[PATCH] D47592: [AArch64] Corrected FP16 Intrinsic range checks in Clang + added Sema tests

This revision was automatically updated to reflect the committed changes. LukeGeeson marked an inline comment as done. Closed by commit rL334489: [AArch64] Corrected FP16 Intrinsic range checks in Clang + added Sema tests (authored by LukeGeeson, committed by ). Herald added a subscriber:

[PATCH] D48119: [AArch64] Added support for the vcvta_u16_f16 instrinsic for FP16 Armv8.2-A

LukeGeeson marked an inline comment as done. LukeGeeson added a comment. address Nit's and code comments, please see above. Comment at: CodeGen/arm-v8.2a-neon-intrinsics.c:170 +// CHECK: ret <4 x i16> [[VCVT]] +int16x4_t test_vcvta_u16_f16 (float16x4_t a) { + return

[PATCH] D48119: [AArch64] Added Clang Codegen+Test Support for FP16 VCVTA_U16 intrinsic

LukeGeeson created this revision. LukeGeeson added a reviewer: SjoerdMeijer. Herald added a reviewer: javed.absar. Herald added a subscriber: kristof.beyls. -Added support for existing IP for vcvta_u16_f16 instrinsic for Arm v8.2a -CGBuiltin simply adds cases for this intrinsic to gen the clang

[PATCH] D47592: [AArch64] Corrected FP16 Intrinsic range checks in Clang + added Sema tests

LukeGeeson marked 2 inline comments as done. LukeGeeson added inline comments. Comment at: lib/Sema/SemaChecking.cpp:1409 - switch (BuiltinID) { -#define GET_NEON_OVERLOAD_CHECK -#include "clang/Basic/arm_neon.inc" SjoerdMeijer wrote: > Why do we need to remove

[PATCH] D47592: [AArch64] Corrected FP16 Intrinsic range checks in Clang + added Sema tests

LukeGeeson created this revision. LukeGeeson added a reviewer: SjoerdMeijer. Herald added a reviewer: javed.absar. Herald added a subscriber: kristof.beyls. This fixes the ranges for the vcvth family of FP16 intrinsics in the clang front end. Previously it was accepting incorrect ranges -Changed

[PATCH] D60272: [Aarch64] Add v8.2-a half precision element extract intrinsics

LukeGeeson added a comment. couple of nits, besides from that LGTM Comment at: lib/CodeGen/CGBuiltin.cpp:7813 } + case NEON::BI__builtin_neon_vduph_lane_f16:{ +return Builder.CreateExtractElement(Ops[0], EmitScalarExpr(E->getArg(1)), nit: spacing

[PATCH] D74483: [AArch64] Add Cortex-A34 Support for clang and llvm

LukeGeeson updated this revision to Diff 244377. LukeGeeson marked an inline comment as done. LukeGeeson added a comment. - Added MIDR to Host.cpp - Fixed a clang test I missed (copy/paste error) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74483/new/ https://reviews.llvm.org/D74483

[PATCH] D74483: [AArch64] Add Cortex-A34 Support for clang and llvm

LukeGeeson created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch upstreams support for the AArch64 Armv8-A cpu Cortex-A34.

[PATCH] D74966: [PATCH] [ARM] Add Cortex-M55 Support for clang and llvm

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d594cf003d1: [ARM] Add Cortex-M55 Support for clang and llvm (authored by LukeGeeson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74966/new/

[PATCH] D74966: [PATCH] [ARM] Add Cortex-M55 Support for clang and llvm

LukeGeeson updated this revision to Diff 246427. LukeGeeson marked an inline comment as done. LukeGeeson added a comment. - Addressed dmgreen's comments (removed whitespace, added m55 test) - Added CPU Part number to Host.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74966/new/

[PATCH] D74966: [PATCH] [ARM] Add Cortex-M55 Support for clang and llvm

LukeGeeson created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch upstreams support for the ARM Armv8.1m cpu Cortex-M55. In detail adding support for: - mcpu option in clang - Arm Target Features in

[PATCH] D74483: [AArch64] Add Cortex-A34 Support for clang and llvm

LukeGeeson closed this revision. LukeGeeson marked an inline comment as not done. LukeGeeson added inline comments. Comment at: llvm/unittests/Support/TargetParserTest.cpp:784 EXPECT_TRUE(testAArch64CPU( + "cortex-a34", "armv8-a", "crypto-neon-fp-armv8", +

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

LukeGeeson created this revision. LukeGeeson added reviewers: SjoerdMeijer, stuij, rjmccall, rsmith, liutianle, RKSimon, craig.topper. Herald added subscribers: cfe-commits, danielkiss, arphaman, kristof.beyls. Herald added a project: clang. LukeGeeson added a parent revision: D76062: [PATCH]

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

LukeGeeson created this revision. LukeGeeson added reviewers: SjoerdMeijer, craig.topper, rjmccall. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, dexonsmith, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. LukeGeeson edited the summary of this revision. LukeGeeson

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

LukeGeeson added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.h:39 bool HasTME; + unsigned HasMatMul; DavidSpickett wrote: > Why is this feature a number for AArch64, does >1 mean something? It seems this was an artifact from how this is

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

LukeGeeson added a comment. apologies please ignore adding here, added reviewers to the wrong diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/ https://reviews.llvm.org/D76062 ___

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

LukeGeeson marked 2 inline comments as done. LukeGeeson added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:284 + if (HasMatMul) +Builder.defineMacro("__ARM_FEATURE_MATMUL_INT8", "1"); + DavidSpickett wrote: > I don't see specific tests

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

LukeGeeson added a comment. In D77540#1969873 , @fhahn wrote: > This patch is quite big and I think it would be easier to review if it would > be split up into distinct clang/llvm parts and maybe NEON/SVE parts on the > LLVM side. That's a good

[PATCH] D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson created this revision. LukeGeeson added reviewers: ostannard, t.p.northover. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a reviewer: rengolin. Herald added a project: clang. LukeGeeson added a parent revision: D77540: [PATCH] [ARM]:

[PATCH] D77875: [ARM] Armv8.6-a Matrix Mul cmd line support

LukeGeeson created this revision. LukeGeeson added a reviewer: t.p.northover. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. LukeGeeson added a parent revision: D77874: [AArch32] Armv8.6a Matrix Mul Assembly. This patch upstreams support for the

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson created this revision. LukeGeeson added a reviewer: t.p.northover. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. LukeGeeson added a parent revision: D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics. LukeGeeson

[PATCH] D77875: [ARM] Armv8.6-a Matrix Mul cmd line support

LukeGeeson added a comment. harbour master builds, unit tests passing, failures down to linting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77875/new/ https://reviews.llvm.org/D77875 ___ cfe-commits

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

LukeGeeson added a comment. Hi folks, Thank you for your help, I have split the patches up as follows: 1. https://reviews.llvm.org/D77871 [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics 2. https://reviews.llvm.org/D77872 [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics 3.

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson added a comment. Harbourmaster now biulds, and unit tests pass, errors related to linting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77872/new/ https://reviews.llvm.org/D77872 ___

[PATCH] D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson added a comment. Removed reliance on parent revision, harbormaster now builds with unit tests passing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77871/new/ https://reviews.llvm.org/D77871

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson marked 3 inline comments as done. LukeGeeson added inline comments. Comment at: clang/test/CodeGen/arm-v8.6a-neon-intrinsics.c:3 +// RUN: -fallow-half-arguments-and-returns -S -disable-O0-optnone -emit-llvm -o - %s \ +// RUN: | opt -S -mem2reg \ +// RUN: | FileCheck

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson updated this revision to Diff 258030. LukeGeeson added a comment. - added -sroa to arm-v8.6a-neon-intrinsics test, updated test to remove redundant memory accesses - made class vusdot for new vusdot instructions with hasNoSchedulinginfo for new instructions. Existing instructions

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

LukeGeeson added a comment. build failures related to linting, unit tests passing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77540/new/ https://reviews.llvm.org/D77540 ___ cfe-commits mailing list

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

LukeGeeson added a comment. In D76077#1919861 , @rjmccall wrote: > I don't understand why you wouldn't add a new IR type for this; doing so > should be totally mechanical. We had a few reasons for doing it this way. By adding a new IR type we would

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

LukeGeeson marked an inline comment as done. LukeGeeson added inline comments. Comment at: clang/test/CodeGen/arm-mangle-16bit-float.cpp:4 + +// CHECK64: define {{.*}}void @_Z3foou6__bf16(half %b) +// CHECK32: define {{.*}}void @_Z3foou6__bf16(i32 %b.coerce)

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

LukeGeeson added a comment. In D76077#1919897 , @rjmccall wrote: > Note that we have an IR type for the PPC double-double format, which isn't > even hardware-supported. This is literally just an IEEE floating-point > format with non-standard

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

LukeGeeson updated this revision to Diff 250267. LukeGeeson added a comment. Added a file from a downstream cleanup of the branch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077 Files: clang/docs/LanguageExtensions.rst

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson marked an inline comment as done. LukeGeeson added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrNEON.td:4846 + VDOT { + let hasNoSchedulingInfo = 1; + dmgreen wrote: > I don't think that hasNoSchedulingInfo is necessarily the best

[PATCH] D77540: [PATCH] [ARM]: Armv8.6-a Matrix Mul Asm and Intrinsics Support

LukeGeeson abandoned this revision. LukeGeeson added a comment. Sub-issues all closed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77540/new/ https://reviews.llvm.org/D77540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77872: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics

This revision was automatically updated to reflect the committed changes. LukeGeeson marked an inline comment as done. Closed by commit rG7da190512532: [AArch32] Armv8.6-a Matrix Mult Assembly + Intrinsics (authored by LukeGeeson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77875: [ARM] Armv8.6-a Matrix Mul cmd line support

This revision was automatically updated to reflect the committed changes. Closed by commit rG740a1dd050ee: [ARM] Armv8.6-a Matrix Mul cmd line support (authored by LukeGeeson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77875/new/

[PATCH] D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG832cd749131b: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics (authored by LukeGeeson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77871/new/

[PATCH] D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics

LukeGeeson updated this revision to Diff 259327. LukeGeeson marked 5 inline comments as done. LukeGeeson added a comment. - fixed typos - added sroa as mem2reg arg to reduce redundant mem accesses in tests, refactored test - addressed other comments CHANGES SINCE LAST ACTION

[PATCH] D77875: [ARM] Armv8.6-a Matrix Mul cmd line support

LukeGeeson added a comment. In D77875#1979980 , @DavidSpickett wrote: > > Note: +f32mm and +f64mm are optional and so have to be enabled by default > > I think I know what you mean, but "and so are not enabled by default" would > be clearer. > > Also to

[PATCH] D77875: [ARM] Armv8.6-a Matrix Mul cmd line support

LukeGeeson updated this revision to Diff 257362. LukeGeeson added a comment. - updated commit message to reflect sve=>f32/64 implication - added comment in AArch64.cpp to that effect CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77875/new/ https://reviews.llvm.org/D77875 Files:

[PATCH] D79869: [clang][BFloat] Add reinterpret cast intrinsics

LukeGeeson added a comment. As I was an author of this patch (among others) please could you add a list of authors to the commit message. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79869/new/ https://reviews.llvm.org/D79869

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

LukeGeeson added a comment. I was an author for part of this patch. Please add all authors as a list of authors to this commit message. Thanks! As an aside, it would be worth doing this for all the patches in this series Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

LukeGeeson added a comment. I authored some of the code for this patch, please update the commit message with my name on the list :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

LukeGeeson added a comment. Can you update the commit message in this differential as well please? Same for the other commits :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79710/new/ https://reviews.llvm.org/D79710

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

LukeGeeson added inline comments. Comment at: clang/test/CodeGen/arm-mangle-16bit-float.cpp:4 + +// CHECK64: define {{.*}}void @_Z3foou6__bf16(half %b) +// CHECK32: define {{.*}}void @_Z3foou6__bf16(i32 %b.coerce) SjoerdMeijer wrote: > LukeGeeson wrote: > >

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson created this revision. LukeGeeson added reviewers: fpetrogalli, SjoerdMeijer. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. LukeGeeson added a parent revision: D79869: [clang][BFloat] Add reinterpret cast

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

LukeGeeson created this revision. LukeGeeson added reviewers: SjoerdMeijer, t.p.northover, sdesmalen, labrinea. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. LukeGeeson added a parent revision: D80716: [AArch64]:

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

LukeGeeson added a comment. A few nits, it looks largely uncontroversial but I'll let someone else give the ok since an external eye is always good :) Comment at: clang/utils/TableGen/NeonEmitter.cpp:1066 if (Name == "vcvt_f16_f32" || Name == "vcvt_f32_f16" || +

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson updated this revision to Diff 267896. LukeGeeson marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80716/new/ https://reviews.llvm.org/D80716 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson added a subscriber: pratlucas. LukeGeeson added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10366 +auto Alignment = CGM.getNaturalPointeeTypeAlignment( +E->getArg(0)->IgnoreParenCasts()->getType()); Ops[0] =

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson added a comment. In D80716#2059977 , @stuij wrote: > We need testing for the backend code. @stuij I have added `aarch64-bf16-ldst-intrinsics.ll` to test the backend. Please let me know if this is ok :) CHANGES SINCE LAST ACTION

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

LukeGeeson updated this revision to Diff 267909. LukeGeeson added a comment. Added CHECK-NEXT lines, tested whole functions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/ https://reviews.llvm.org/D80752 Files: clang/include/clang/Basic/arm_neon.td

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson marked an inline comment as done. LukeGeeson added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10366 +auto Alignment = CGM.getNaturalPointeeTypeAlignment( +E->getArg(0)->IgnoreParenCasts()->getType()); Ops[0] =

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

LukeGeeson marked an inline comment as done. LukeGeeson added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-dotprod-intrinsics.ll:4 +; CHECK-LABEL: test_vbfdot_f32 +; CHECK: bfdot v0.2s, v1.4h, v2.4h +define <2 x float> @test_vbfdot_f32(<2 x float> %r, <4

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

LukeGeeson marked an inline comment as done. LukeGeeson added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-dotprod-intrinsics.ll:4 +; CHECK-LABEL: test_vbfdot_f32 +; CHECK: bfdot v0.2s, v1.4h, v2.4h +define <2 x float> @test_vbfdot_f32(<2 x float> %r, <4

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

LukeGeeson added a comment. In D85009#2187621 , @jfb wrote: > In D85009#2187603 , @simon_tatham > wrote: > >> In D85009#2187549 , @jfb wrote: >> >>> Is that true of all

[PATCH] D85009: [Sema][BFloat] Forbid arithmetic on vectors of bfloat.

LukeGeeson accepted this revision. LukeGeeson added a comment. This revision is now accepted and ready to land. This seems sensible and benign, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85009/new/ https://reviews.llvm.org/D85009

[PATCH] D82887: [ARM] Add Cortex-A77 Support for Clang and LLVM

LukeGeeson updated this revision to Diff 274791. LukeGeeson marked 5 inline comments as done. LukeGeeson added a comment. - Added A77 CPU Part Number to Host.cpp - added case to AArch64Subtarget::initializeProperties - moved a77 test up in AArch64-cpu - formatted line for AArch64 Target Parser -

[PATCH] D82887: [ARM] Add Cortex-A77 Support for Clang and LLVM

LukeGeeson created this revision. LukeGeeson added a reviewer: t.p.northover. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch upstreams support for the Arm-v8 Cortex-A77 processor for AArch64 and ARM. In

[PATCH] D82887: [ARM] Add Cortex-A77 Support for Clang and LLVM

LukeGeeson added a comment. In D82887#2123364 , @dmgreen wrote: > Please make sure the switch in AArch64Subtarget::initializeProperties has an > entry too. > > Do you happen to know the cpu id for host.cpp? do you mean the CPU part number used in e.g

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

LukeGeeson updated this revision to Diff 276383. LukeGeeson marked 2 inline comments as done. LukeGeeson added a comment. Addressed Mikhail's feedback: Sorted CPU lists accordingly CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83206/new/ https://reviews.llvm.org/D83206 Files:

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

LukeGeeson updated this revision to Diff 276977. LukeGeeson marked 3 inline comments as done. LukeGeeson added a comment. - Addresses dmgreens comments - reordered CPUs in the right places - added code/tests in all files that exist in the a77 patch made minor adjustments including: - adding

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

LukeGeeson updated this revision to Diff 277033. LukeGeeson marked an inline comment as done. LukeGeeson added a comment. - removed missed RAS CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83206/new/ https://reviews.llvm.org/D83206 Files: clang/test/Driver/aarch64-cpus.c

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

LukeGeeson updated this revision to Diff 277032. LukeGeeson added a comment. - removed RAS as it's in 8.2a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83206/new/ https://reviews.llvm.org/D83206 Files: clang/test/Driver/aarch64-cpus.c clang/test/Driver/arm-cortex-cpus.c

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

LukeGeeson updated this revision to Diff 277036. LukeGeeson added a comment. - Added FP16 to ARM a78 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83206/new/ https://reviews.llvm.org/D83206 Files: clang/test/Driver/aarch64-cpus.c clang/test/Driver/arm-cortex-cpus.c

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

LukeGeeson updated this revision to Diff 277019. LukeGeeson added a comment. - Added FP16 to Cortex-X1 set of features CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83206/new/ https://reviews.llvm.org/D83206 Files: clang/test/Driver/aarch64-cpus.c

[PATCH] D82887: [ARM] Add Cortex-A77 Support for Clang and LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bf99f1e6f0f: [ARM] Add Cortex-A77 Support for Clang and LLVM (authored by LukeGeeson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82887/new/

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

LukeGeeson updated this revision to Diff 277074. LukeGeeson added a comment. removed FP16FML feature CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83206/new/ https://reviews.llvm.org/D83206 Files: clang/test/Driver/aarch64-cpus.c clang/test/Driver/arm-cortex-cpus.c

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rG954db63cd149: [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM (authored by LukeGeeson). Changed prior to commit: https://reviews.llvm.org/D83206?vs=277074=277093#toc Repository: rG

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

LukeGeeson created this revision. LukeGeeson added a reviewer: t.p.northover. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch adds support for the Arm-v8 Cortex-A78 and Cortex-X1 processors for AArch64 and

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG10b6567f4977: [AArch64]: BFloat MatMul IntrinsicsCodeGen (authored by LukeGeeson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/

[PATCH] D81847: [ARM] Improve diagnostics message when Neon is unsupported

LukeGeeson accepted this revision. LukeGeeson added a comment. This revision is now accepted and ready to land. Very simple change, looks good to me. Please wait a week or so before submitting, so that non-arm folks have time to raise issues Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D81740: [AArch32]: BFloat MatMul Intrinsics

LukeGeeson updated this revision to Diff 270720. LukeGeeson added a comment. removed redundancy in patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81740/new/ https://reviews.llvm.org/D81740 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/arm-bf16-dotprod-intrinsics.c

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson marked 2 inline comments as done. LukeGeeson added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> }

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

LukeGeeson updated this revision to Diff 269833. LukeGeeson added a comment. addressed review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/ https://reviews.llvm.org/D80752 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson marked 2 inline comments as done. LukeGeeson added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-ldst-intrinsics.ll:264 +; Function Attrs: argmemonly nounwind readonly +declare { <8 x bfloat>, <8 x bfloat> }

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

LukeGeeson updated this revision to Diff 268520. LukeGeeson added a comment. - used `update_cc_test_checks.py` to generate correct checks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/ https://reviews.llvm.org/D80752 Files: clang/include/clang/Basic/arm_neon.td

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

LukeGeeson added a comment. In D80752#2074882 , @stuij wrote: > For the backend tests, I suggest using `-asm-verbose=0` with llc to only > print instructions and get rid of `// kill: ..` and friends. Use > `update_cc_test_checks.py` again to regenerate

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson added a comment. In D80716#2074883 , @stuij wrote: > In D80716#2073251 , @LukeGeeson > wrote: > > > Besides from rebasing to get @pratlucas changes upstream. > > > > @stuij please could you confirm if

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson added a comment. In D80716#2082356 , @LukeGeeson wrote: > In D80716#2074883 , @stuij wrote: > > > In D80716#2073251 , @LukeGeeson > > wrote: > > > > > Besides

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

LukeGeeson marked an inline comment as done. LukeGeeson added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-dotprod-intrinsics.ll:4 +; CHECK-LABEL: test_vbfdot_f32 +; CHECK: bfdot v0.2s, v1.4h, v2.4h +define <2 x float> @test_vbfdot_f32(<2 x float> %r, <4

[PATCH] D80752: [AArch64]: BFloat MatMul Intrinsics

LukeGeeson updated this revision to Diff 268165. LukeGeeson added a comment. ran `llvm/utils/update_llc_test_checks.py` on test to get proper `CHECK`s CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/ https://reviews.llvm.org/D80752 Files:

[PATCH] D81740: [AArch32]: BFloat MatMul Intrinsics

LukeGeeson created this revision. LukeGeeson added reviewers: stuij, t.p.northover, SjoerdMeijer, sdesmalen, fpetrogalli. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. LukeGeeson added a parent revision: D81486: [ARM][BFloat]

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson updated this revision to Diff 270387. LukeGeeson added a comment. - removed unnecessary contents of test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80716/new/ https://reviews.llvm.org/D80716 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics

LukeGeeson added a comment. Besides from rebasing to get @pratlucas changes upstream. @stuij please could you confirm if you are happy with this, so I can merge CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80716/new/ https://reviews.llvm.org/D80716