[PATCH] D116827: Don't pass uninitialized QueryKind

This revision was automatically updated to reflect the committed changes. Closed by commit rG244dd2913a43: Dont pass uninitialized QueryKind (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116827/new/

[PATCH] D116827: Don't pass uninitialized QueryKind

vitalybuka updated this revision to Diff 398271. vitalybuka added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116827/new/ https://reviews.llvm.org/D116827 Files: clang-tools-extra/clangd/XRefs.cpp Index:

[PATCH] D116827: Don't pass uninitialized QueryKind

kda added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1313 } + if (IDs.empty()) +return {}; vitalybuka wrote: > kda wrote: > > It seems like the first line of 'findImplementors' is 'if (IDs.empty() || > > !Index)`. > > I wonder if

[PATCH] D116827: Don't pass uninitialized QueryKind

vitalybuka added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:311 llvm::StringRef MainFilePath) { if (IDs.empty() || !Index) return {}; here Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D116827: Don't pass uninitialized QueryKind

vitalybuka added a comment. In D116827#3228594 , @vitalybuka wrote: > In D116827#3228524 , @kda wrote: > >> This seems to introduce a new branch, should there be a new unit test in: >> XRefsTests.cpp? > > It's

[PATCH] D116827: Don't pass uninitialized QueryKind

vitalybuka added a comment. In D116827#3228524 , @kda wrote: > This seems to introduce a new branch, should there be a new unit test in: > XRefsTests.cpp? It's not functional change, test should not be able to see a difference after this patch.

[PATCH] D116827: Don't pass uninitialized QueryKind

kda requested changes to this revision. kda added a comment. This revision now requires changes to proceed. I think I forgot to 'Request Changes'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116827/new/ https://reviews.llvm.org/D116827

[PATCH] D116827: Don't pass uninitialized QueryKind

kda added a comment. This seems to introduce a new branch, should there be a new unit test in: XRefsTests.cpp? Comment at: clang-tools-extra/clangd/XRefs.cpp:1313 } + if (IDs.empty()) +return {}; It seems like the first line of 'findImplementors' is

[PATCH] D116827: Don't pass uninitialized QueryKind

vitalybuka created this revision. vitalybuka added reviewers: kda, eugenis. Herald added subscribers: usaxena95, kadircet, arphaman. vitalybuka requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Even if findImplementors does not