[PATCH] D30773: Make git-clang-format python 3 compatible

EricWF updated this revision to Diff 96025. EricWF added a comment. I've committed all but the `str` vs `byte` changes upstream. https://reviews.llvm.org/D30773 Files: tools/clang-format/git-clang-format Index: tools/clang-format/git-clang-format

[PATCH] D29904: [OpenMP] Prevent emission of exception handling code when using OpenMP to offload to NVIDIA devices.

ABataev accepted this revision. ABataev added a comment. LG Repository: rL LLVM https://reviews.llvm.org/D29904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32192: Enable leak sanitizer builds for darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rL300894: Enable leak sanitizer builds for darwin (authored by fjricci). Changed prior to commit: https://reviews.llvm.org/D32192?vs=95986=96019#toc Repository: rL LLVM

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

BillyONeal added a comment. In https://reviews.llvm.org/D32265#732657, @jfb wrote: > It looks like Billy is going to do something somewhat similar when he > rewrites it: https://twitter.com/jfbastien/status/855168230918307840 > For now it's kinda `#define IS_LOCK_FREE ¯\_(ツ)_/¯` Note that my

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

ABataev added a comment. Tests? Comment at: lib/Driver/Driver.cpp:556 else { -const ToolChain = getToolChain(C.getInputArgs(), TT); -C.addOffloadDeviceToolChain(, Action::OFK_OpenMP); +const ToolChain *TC = nullptr; +

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

jfb added a comment. In https://reviews.llvm.org/D32265#731710, @EricWF wrote: > In https://reviews.llvm.org/D32265#731709, @jfb wrote: > > > Is it a goal to support Microsoft's STL with this? If so, how does MSVC's > > STL implement `is_always_lock_free` at the moment? CL 19 2017 RTW doesn't

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

jfb added a comment. It looks like Billy is going to do something somewhat similar when he rewrites it: https://twitter.com/jfbastien/status/855168230918307840 For now it's kinda `#define IS_LOCK_FREE ¯\_(ツ)_/¯` https://reviews.llvm.org/D32265 ___

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

rsmith added a comment. In https://reviews.llvm.org/D32199#732189, @hfinkel wrote: > In https://reviews.llvm.org/D32199#731472, @rsmith wrote: > > > 1. C's "effective type" rule allows writes to set the type pretty much > > unconditionally, unless the storage is for a variable with a declared

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

BillyONeal added a comment. In https://reviews.llvm.org/D32265#731709, @jfb wrote: > Is it a goal to support Microsoft's STL with this? If so, how does MSVC's STL > implement `is_always_lock_free` at the moment? CL 19 2017 RTW doesn't seem to > have anything ?

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

kuhar marked 2 inline comments as done. kuhar added inline comments. Comment at: clang-tidy/tool/run-clang-tidy.py:100 + except: +print >>sys.stderr, "Unable to run clang-apply-replacements." +sys.exit(1) kimgr wrote: > alexfh wrote: > > "Unable to run

r300891 - Begin making git-clang-format python3 compatible.

Author: ericwf Date: Thu Apr 20 16:05:58 2017 New Revision: 300891 URL: http://llvm.org/viewvc/llvm-project?rev=300891=rev Log: Begin making git-clang-format python3 compatible. This patch fixes most of the python3 incompatabilities within git-clang-format while keeping the script python2

r300895 - Fix Python 2 vs 3 incompatability with dict.items() vs iteritems()

Author: ericwf Date: Thu Apr 20 16:23:58 2017 New Revision: 300895 URL: http://llvm.org/viewvc/llvm-project?rev=300895=rev Log: Fix Python 2 vs 3 incompatability with dict.items() vs iteritems() Modified: cfe/trunk/tools/clang-format/git-clang-format Modified:

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

BillyONeal added a comment. (sorry for double post) And of course since you folks don't care about supporting pre-Vista you probably also don't care about supporting Opterons from 2005, in which case you'd want unconditional cmpxchg16b on amd64 :). In our next major version I added a

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

EricWF added a comment. In https://reviews.llvm.org/D32265#732649, @jfb wrote: > In https://reviews.llvm.org/D32265#731710, @EricWF wrote: > > > In https://reviews.llvm.org/D32265#731709, @jfb wrote: > > > > > Is it a goal to support Microsoft's STL with this? If so, how does MSVC's > > > STL

[PATCH] D29659: [OpenMP] Add flag for disabling the default generation of relocatable OpenMP target code for NVIDIA GPUs.

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:297 + !Args.hasFlag(options::OPT_fnoopenmp_relocatable_target, +options::OPT_fopenmp_relocatable_target, false)) CmdArgs.push_back("-c"); 1. Add a comment

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

rnk added inline comments. Comment at: include/clang/Basic/SourceLocation.h:336 + bool hasManager() const { return SrcMgr != nullptr; } /// \pre This FullSourceLoc has an associated SourceManager. SrcMgr is only non-null when the location is invalid,

[PATCH] D32313: [clang-tidy] Don't turn .push_back({1, 2}) into .emplace_back(1, 2) for pairs

kuhar created this revision. kuhar added a project: clang-tools-extra. This patch prevents modernize-use-emplace from changing push_backs of brace initialized pairs (`.push_back({1, 2})`) to `.emplace_back(1, 2)`. Pair's constructor doesn't have any interesting logic and basically performs

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. SGTM provided this continues to work with python 2. https://reviews.llvm.org/D32294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r300881 - Fix comment and remove incorrect linker flags in test configuration

Author: ericwf Date: Thu Apr 20 15:22:19 2017 New Revision: 300881 URL: http://llvm.org/viewvc/llvm-project?rev=300881=rev Log: Fix comment and remove incorrect linker flags in test configuration Modified: libcxx/trunk/utils/libcxx/test/config.py Modified:

r300873 - [Driver] Add a missing -no-canonical-prefixes to test.

Author: d0k Date: Thu Apr 20 14:06:24 2017 New Revision: 300873 URL: http://llvm.org/viewvc/llvm-project?rev=300873=rev Log: [Driver] Add a missing -no-canonical-prefixes to test. Modified: cfe/trunk/test/Driver/avr-mmcu.c Modified: cfe/trunk/test/Driver/avr-mmcu.c URL:

Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

On Thu, Apr 20, 2017 at 11:06 AM, Mehdi Amini wrote: > > On Apr 20, 2017, at 12:39 AM, Eric Fiselier wrote: > > > > On Wed, Apr 19, 2017 at 11:19 PM, Mehdi Amini > wrote: > >> What would be the status of these buildbots? Is it for

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

kuhar updated this revision to Diff 96001. kuhar added a comment. Use python3 printing. Move exception handling out of apply_fixes. Now, the code prints the following on failure: Applying fixes ... Error applying fixes. Is clang-apply-replacements binary correctly specified? Traceback

[PATCH] D32291: [analyzer] Implement handling array subscript into null pointer, improve null dereference checks for array subscripts

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D32291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32322: Use __CLANG_ATOMIC_TYPE_LOCK_FREE macros in `stdatomic.h`

EricWF created this revision. This patch makes the header `stdatomic.h` work when `-fms-compatibility` is specified. https://reviews.llvm.org/D32322 Files: lib/Headers/stdatomic.h test/Headers/stdatomic.c Index: test/Headers/stdatomic.c

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

kuhar updated this revision to Diff 96045. kuhar added a comment. After thinking about Piotr's comment, I think that a better way to perform the check would be te invoking clang-apply-replacements with `--version` and seeing if it fails even before running clang-tidy. This way it is possible to

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

Prazek added a comment. In https://reviews.llvm.org/D32294#732861, @kuhar wrote: > After thinking about Piotr's comment, I think that a better way to perform > the check would be te invoking clang-apply-replacements with `--version` and > seeing if it fails even before running clang-tidy. >

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

alexfh added a comment. In https://reviews.llvm.org/D32294#732986, @Prazek wrote: > In https://reviews.llvm.org/D32294#732861, @kuhar wrote: > > > After thinking about Piotr's comment, I think that a better way to perform > > the check would be te invoking clang-apply-replacements with

[PATCH] D32328: [analyzer] Fix assert in ExprEngine::processSwitch

zaks.anna added a comment. Do you have commit access? Repository: rL LLVM https://reviews.llvm.org/D32328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32328: [analyzer] Fix assert in ExprEngine::processSwitch

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thank you! Repository: rL LLVM https://reviews.llvm.org/D32328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32332: Add support for transparent overloadable functions in clang

george.burgess.iv created this revision. One of the common use-cases for the `overloadable` attribute is to create small wrapper functions around an existing function that was previously not overloadable. For example: // C Library v1 void foo(int i); // C Library v2 // Note the

[PATCH] D32333: [clang-tidy] Update IdentifierNamingCheck to remove extra leading/trailing underscores

jtbandes created this revision. The goal of this change is to fix the following suboptimal replacements currently suggested by clang-tidy: // with MemberPrefix == "_" int __foo; // accepted without complaint // with MemberPrefix == "m_" int _foo; ^~ m__foo I fixed

[PATCH] D32231: [CMake] Enable ARM target in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rL300917: [CMake] Enable ARM target in Fuchsia toolchain (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D32231?vs=95766=96048#toc Repository: rL LLVM

r300919 - Use __CLANG_ATOMIC_TYPE_LOCK_FREE macros in `stdatomic.h`

Author: ericwf Date: Thu Apr 20 18:07:38 2017 New Revision: 300919 URL: http://llvm.org/viewvc/llvm-project?rev=300919=rev Log: Use __CLANG_ATOMIC_TYPE_LOCK_FREE macros in `stdatomic.h` Summary: This patch makes the header `stdatomic.h` work when `-fms-compatibility` is specified. Reviewers:

[PATCH] D32320: [libc++] Default to vcruntime when targeting MSVC

smeenai added inline comments. Comment at: CMakeLists.txt:119 +set(LIBCXX_CXX_ABI_LIBNAME "vcruntime") else() +find_path( EricWF wrote: > Nit: I would rather see this be > ``` > elseif ((NOT LIBCXX_STANDALONE_BUILD OR HAVE_LIBCXXABI) AND >

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

alexfh added inline comments. Comment at: clang-tidy/tool/run-clang-tidy.py:226 +print('Applying fixes ...') +successfully_applied = True + ` = False` here and ` = True` after `apply_fixes()` inside `try`. https://reviews.llvm.org/D32294

[PATCH] D32328: [analyzer] Fix assert in ExprEngine::processSwitch

alexshap added a comment. Thanks, i do. Repository: rL LLVM https://reviews.llvm.org/D32328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31856: Headers: Make the type of SIZE_MAX the same as size_t

dexonsmith added a comment. Hmm... presumably, this test should pass: $ ./bin/clang -nostdinc -isystem ./lib/clang/5.0.0/include -std=c++1z -fsyntax-only t.cpp t.cpp:3:1: error: static_assert failed static_assert(__is_same(intptr_t, __INTPTR_TYPE__)); ^

[PATCH] D31856: Headers: Make the type of SIZE_MAX the same as size_t

dexonsmith added a comment. It looks like `__INTPTR_TYPE__` was introduced in r64495 in order to help define `intptr_t`, and then they diverged in r89237. Changing `intptr_t` would change the mangling of symbols in libcxx, so that doesn't seem safe. Is it safe to change `__INTPTR_TYPE__`?

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

Prazek accepted this revision. Prazek added a comment. LGTM, but please leave the FIXME comment about the running of apply replacement https://reviews.llvm.org/D32294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32320: [libc++] Default to vcruntime when targeting MSVC

smeenai created this revision. Herald added a subscriber: mgorny. libc++abi is never the right option for LIBCXX_TARGETING_MSVC, since it targets the Itanium ABI, whereas MSVC uses the Microsoft ABI. Make the default ABI be vcruntime when targeting MSVC even if libc++abi is present in the tree.

[PATCH] D32329: [libc++abi] Disable libc++ extern templates project-wide

smeenai created this revision. Herald added a subscriber: mgorny. libc++abi can't depend on libc++, so disable extern templates in libc++ headers project-wide. This was previously done in cxa_demangle.cpp, but I consider it more appropriate to do at the cmake level (since none of libc++abi's

[PATCH] D30805: [OpenCL] Add intel_reqd_sub_group_size attribute support

pxli168 added a comment. @Anastasia is this test added OK? https://reviews.llvm.org/D30805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r300909 - Sema: protect against ObjC++ typo-correction failure

Author: compnerd Date: Thu Apr 20 17:23:10 2017 New Revision: 300909 URL: http://llvm.org/viewvc/llvm-project?rev=300909=rev Log: Sema: protect against ObjC++ typo-correction failure ObjC++ has two different types of "pointer" types (ObjCClassPointerType and PointerType). Both can be indirected

[libcxx] r300942 - Mark exception_ptr tests as XFAIL on Windows for now

Author: ericwf Date: Thu Apr 20 21:13:33 2017 New Revision: 300942 URL: http://llvm.org/viewvc/llvm-project?rev=300942=rev Log: Mark exception_ptr tests as XFAIL on Windows for now Modified: libcxx/trunk/test/std/language.support/support.exception/except.nested/assign.pass.cpp

Buildbot numbers for the week of 04/02/2017 - 04/08/2017

Hello everyone, Below are some buildbot numbers for the week of 04/02/2017 - 04/08/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 04/09/2017 - 04/15/2017

Hello everyone, Below are some buildbot numbers for the last week of 04/09/2017 - 04/15/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status

Re: r300650 - [modules] Properly look up the owning module for an instantiation of a merged template.

On 18 April 2017 at 22:41, Chandler Carruth wrote: > Reverted in r300658. > For posterity, the above has an off-by-one error, the revert was r300659. > On Tue, Apr 18, 2017 at 8:30 PM Chandler Carruth > wrote: > >> Consider code like the following:

Re: r300650 - [modules] Properly look up the owning module for an instantiation of a merged template.

Re-committed with fix in r300938. On 20 April 2017 at 17:06, Richard Smith wrote: > On 18 April 2017 at 22:41, Chandler Carruth wrote: > >> Reverted in r300658. >> > > For posterity, the above has an off-by-one error, the revert was r300659. > > >>

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai updated this revision to Diff 96084. xiangzhai added a comment. Further reduce redundant code. Repository: rL LLVM https://reviews.llvm.org/D30771 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/gmalloc.c Index: test/Analysis/gmalloc.c

[PATCH] D32147: [PR32479] Avoid newlib vasprintf, since it requires gnu extensions

EricWF resigned from this revision. EricWF added a comment. The bug relating to this patch was closed as WONTFIX. This review should be closed. https://reviews.llvm.org/D32147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. I'm not thrilled about adding yet more predefined macros, but it really doesn't make sense for libc++ to depend on `__GCC_*` macros when targeting Windows, nor for these to be Windows-only,

r300908 - Parse: cleanup some bleeding whitespace

Author: compnerd Date: Thu Apr 20 17:23:07 2017 New Revision: 300908 URL: http://llvm.org/viewvc/llvm-project?rev=300908=rev Log: Parse: cleanup some bleeding whitespace Clean up some bleeding whitespace that I noticed. NFC Modified: cfe/trunk/lib/Parse/ParseExpr.cpp Modified:

Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

> On Apr 20, 2017, at 12:30 PM, Eric Fiselier wrote: > > > > On Thu, Apr 20, 2017 at 11:06 AM, Mehdi Amini > wrote: > >> On Apr 20, 2017, at 12:39 AM, Eric Fiselier > > wrote: >> >>

[PATCH] D31856: Headers: Make the type of SIZE_MAX the same as size_t

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. This is sadly not a correct change. The relevant requirements (C11 7.20.3/2) on these macros are: > Each instance of these macros shall be replaced by a constant expression >

[PATCH] D31856: Headers: Make the type of SIZE_MAX the same as size_t

dexonsmith added a comment. Thanks for the review. `__SIZE_MAX__` makes sense to me; and better even if not for the `#if` requirement. I'll do that for both `SIZE_MAX` and `PTRDIFF_MAX` when I get a chance. Comment at: clang/test/Preprocessor/stdint.c:1411 //

[libcxx] r300921 - [libc++] Default to vcruntime when targeting MSVC

Author: smeenai Date: Thu Apr 20 18:33:49 2017 New Revision: 300921 URL: http://llvm.org/viewvc/llvm-project?rev=300921=rev Log: [libc++] Default to vcruntime when targeting MSVC Summary: libc++abi is never the right option for LIBCXX_TARGETING_MSVC, since it targets the Itanium ABI, whereas

[PATCH] D32320: [libc++] Default to vcruntime when targeting MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rL300921: [libc++] Default to vcruntime when targeting MSVC (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D32320?vs=96055=96056#toc Repository: rL LLVM

[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

alexfh added a comment. In https://reviews.llvm.org/D24892#732243, @malcolm.parsons wrote: > In https://reviews.llvm.org/D24892#732217, @alexfh wrote: > > > In https://reviews.llvm.org/D24892#723536, @malcolm.parsons wrote: > > > > > Is there any way for multiple checks to share an option? > > >

[libcxx] r300934 - Fix 'verify-support' available feature

Author: ericwf Date: Thu Apr 20 19:43:07 2017 New Revision: 300934 URL: http://llvm.org/viewvc/llvm-project?rev=300934=rev Log: Fix 'verify-support' available feature Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test/config.py URL:

r300936 - [analyzer] Fix assert in ExprEngine::processSwitch

Author: alexshap Date: Thu Apr 20 20:05:26 2017 New Revision: 300936 URL: http://llvm.org/viewvc/llvm-project?rev=300936=rev Log: [analyzer] Fix assert in ExprEngine::processSwitch This diff replaces getTypeSize(CondE->getType())) with getIntWidth(CondE->getType())) in

[PATCH] D32328: [analyzer] Fix assert in ExprEngine::processSwitch

This revision was automatically updated to reflect the committed changes. Closed by commit rL300936: [analyzer] Fix assert in ExprEngine::processSwitch (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D32328?vs=96060=96070#toc Repository: rL LLVM

r300938 - [modules] Properly look up the owning module for an instantiation of a merged template.

Author: rsmith Date: Thu Apr 20 20:15:13 2017 New Revision: 300938 URL: http://llvm.org/viewvc/llvm-project?rev=300938=rev Log: [modules] Properly look up the owning module for an instantiation of a merged template. When looking for the template instantiation pattern of a templated entity,

[libcxx] r300941 - XFAIL Windows test failures under test/libcxx

Author: ericwf Date: Thu Apr 20 20:48:02 2017 New Revision: 300941 URL: http://llvm.org/viewvc/llvm-project?rev=300941=rev Log: XFAIL Windows test failures under test/libcxx This patch XFAIL's a number of tests under test/libcxx when on Windows. These failures need more investigation or patches

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

bruno marked 6 inline comments as done. bruno added inline comments. Comment at: lib/Parse/ParseDecl.cpp:4236-4237 Sema::SkipBodyInfo SkipBody; + Sema::CheckCompatTagInfo CheckCompatTag; if (!Name && TUK == Sema::TUK_Definition && Tok.is(tok::l_brace) &&

Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

> On Apr 20, 2017, at 7:03 PM, Eric Fiselier wrote: > > > > On Thu, Apr 20, 2017 at 4:55 PM, Mehdi Amini > wrote: > >> On Apr 20, 2017, at 12:30 PM, Eric Fiselier > > wrote: >> >> >>

[libcxx] r300944 - update XFAIL comments with more details

Author: ericwf Date: Thu Apr 20 22:09:40 2017 New Revision: 300944 URL: http://llvm.org/viewvc/llvm-project?rev=300944=rev Log: update XFAIL comments with more details Modified: libcxx/trunk/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

xiangzhai updated this revision to Diff 96088. xiangzhai added a comment. Hi Richard, Thanks for your review! I updated my patch as you suggested: add some test coverage for these triples, and I run `make check-clang-driver` for verification, please point out my fault, thanks! Regards,

[PATCH] D32320: [libc++] Default to vcruntime when targeting MSVC

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Comment at: CMakeLists.txt:119 +set(LIBCXX_CXX_ABI_LIBNAME "vcruntime") else() +find_path( Nit: I would rather see this be ``` elseif ((NOT

r300894 - Enable leak sanitizer builds for darwin

Author: fjricci Date: Thu Apr 20 16:11:51 2017 New Revision: 300894 URL: http://llvm.org/viewvc/llvm-project?rev=300894=rev Log: Enable leak sanitizer builds for darwin Summary: Support for leak sanitizer on darwin has been added to compiler-rt, this patch adds compiler support. Reviewers:

Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

On Thu, Apr 20, 2017 at 4:55 PM, Mehdi Amini wrote: > > On Apr 20, 2017, at 12:30 PM, Eric Fiselier wrote: > > > > On Thu, Apr 20, 2017 at 11:06 AM, Mehdi Amini > wrote: > >> >> On Apr 20, 2017, at 12:39 AM, Eric Fiselier

[PATCH] D31856: Headers: Make the type of SIZE_MAX the same as size_t

dexonsmith updated this revision to Diff 96078. dexonsmith added a comment. Here's an updated patch that uses `__SIZE_MAX__` and also handles the other pointer-like integers. However, the first three static asserts fail, because `intptr_t` and `__INTPTR_TYPE__` are different types (same for

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

bruno updated this revision to Diff 96080. bruno marked 2 inline comments as done. bruno added a comment. Update the patch after Richard's suggestions https://reviews.llvm.org/D31778 Files: include/clang/AST/ASTStructuralEquivalence.h include/clang/Basic/DiagnosticASTKinds.td

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

kuhar updated this revision to Diff 96097. kuhar added a comment. Minor change to success detection logic. https://reviews.llvm.org/D32294 Files: clang-tidy/tool/run-clang-tidy.py Index: clang-tidy/tool/run-clang-tidy.py ===

[PATCH] D31739: Add markup for libc++ dylib availability

mehdi_amini marked 5 inline comments as done. mehdi_amini added inline comments. Comment at: utils/libcxx/test/config.py:289 +def configure_availability(self): +# FIXME doc +self.with_availability = self.get_lit_bool('with_availability', False)

r300949 - [index] Take advantage of 'external_source_symbol' attribute for indexing purposes

Author: akirtzidis Date: Fri Apr 21 00:42:46 2017 New Revision: 300949 URL: http://llvm.org/viewvc/llvm-project?rev=300949=rev Log: [index] Take advantage of 'external_source_symbol' attribute for indexing purposes - Ignore decls marked as 'generated_declaration' - Include the 'defined_in' in

[PATCH] D32111: [modules] Attempt to fix PR31905 - #include "stddef.h" breaks module map search paths; causes redefinitions.

EricWF planned changes to this revision. EricWF added a comment. I've got a better, actually correct, solution incoming. https://reviews.llvm.org/D32111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r300948 - [index] For 'transparent' tag typedefs, ignore their tag reference

Author: akirtzidis Date: Fri Apr 21 00:42:40 2017 New Revision: 300948 URL: http://llvm.org/viewvc/llvm-project?rev=300948=rev Log: [index] For 'transparent' tag typedefs, ignore their tag reference Modified: cfe/trunk/lib/Index/IndexDecl.cpp cfe/trunk/test/Index/Core/index-source.m

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

EricWF updated this revision to Diff 96043. EricWF added a comment. - Address inline comments. https://reviews.llvm.org/D32265 Files: lib/Frontend/InitPreprocessor.cpp test/Preprocessor/init.c test/Sema/atomic-ops.c Index: test/Sema/atomic-ops.c

r300914 - Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

Author: ericwf Date: Thu Apr 20 17:53:57 2017 New Revision: 300914 URL: http://llvm.org/viewvc/llvm-project?rev=300914=rev Log: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode. Summary: Libc++ currently implements the `ATOMIC__LOCK_FREE` macros using the

r300917 - [CMake] Enable ARM target in Fuchsia toolchain

Author: phosek Date: Thu Apr 20 18:06:53 2017 New Revision: 300917 URL: http://llvm.org/viewvc/llvm-project?rev=300917=rev Log: [CMake] Enable ARM target in Fuchsia toolchain This is still used by some users of Fuchsia toolchain. Also include llc and opt which is useful for development and

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

rsmith added a comment. Please add some test coverage for these triples. Repository: rL LLVM https://reviews.llvm.org/D32269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32320: [libc++] Default to vcruntime when targeting MSVC

smeenai updated this revision to Diff 96055. smeenai added a comment. Reduce nesting (address comments) https://reviews.llvm.org/D32320 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@

[PATCH] D31561: cmath: Skip Libc for integral types in isinf, etc.

dexonsmith added a comment. Marshall, are you fine with figuring this out in-tree? Or should I revert to using `std::is_floating_point` for now? https://reviews.llvm.org/D31561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r300937 - Resolve unused local typedef warning in test.

Author: bion Date: Thu Apr 20 20:10:04 2017 New Revision: 300937 URL: http://llvm.org/viewvc/llvm-project?rev=300937=rev Log: Resolve unused local typedef warning in test. Modified: libcxx/trunk/test/std/strings/basic.string/string.cons/T_size_size.pass.cpp Modified:

[PATCH] D32307: [libcxx] [test] Resolve everyone's favorite warning, unused local typedef

BillyONeal closed this revision. BillyONeal added a comment. Committed r300937 https://reviews.llvm.org/D32307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

hfinkel added a comment. In https://reviews.llvm.org/D32199#732382, @rjmccall wrote: > If you're going to try to enforce the declared type of memory, you'll also > need something like the C effective type rule to handle char buffers in C++. > As far as I can tell, it's not actually legal

[PATCH] D31650: [Analyzer] Detect when function pointer is freed

AndersRonnholm updated this revision to Diff 95929. AndersRonnholm added a comment. Updated after comments Repository: rL LLVM https://reviews.llvm.org/D31650 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/malloc.c Index: test/Analysis/malloc.c

[PATCH] D32020: [indexer] The relationship between the declarations in template specializations that 'override' declarations in the base template should be recorded

arphaman updated this revision to Diff 95940. arphaman added a comment. Updated the relationship to be 'overrideOf | specializationOf' to differentiate it from regular 'overrideOf'. Repository: rL LLVM https://reviews.llvm.org/D32020 Files: lib/Index/IndexDecl.cpp

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. I don't see anything wrong with this, I think you can commit it in a couple of days if nobody comes up with a reason why the DiagnosticRenderer shouldn't use FullSourceLoc.

Re: Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

@Sylvestre Thanks! After getting the permissions setup libc++ now has a new Windows builder! https://ci.appveyor.com/project/EricWF/libcxx /Eric On Thu, Apr 20, 2017 at 2:30 AM, Sylvestre Ledru wrote: > > > > On Wed, Apr 19, 2017 at 5:50 PM, Eric Fiselier

r300832 - [index] Record class template specializations using a new 'SpecializationOf'

Author: arphaman Date: Thu Apr 20 05:43:22 2017 New Revision: 300832 URL: http://llvm.org/viewvc/llvm-project?rev=300832=rev Log: [index] Record class template specializations using a new 'SpecializationOf' relationship rdar://31603531 Differential Revision: https://reviews.llvm.org/D32010

[PATCH] D32010: [indexer] Record class template specializations using a new 'SpecializationOf' relationship

This revision was automatically updated to reflect the committed changes. Closed by commit rL300832: [index] Record class template specializations using a new 'SpecializationOf' (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D32010?vs=95112=95927#toc Repository:

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

hfinkel added a comment. In https://reviews.llvm.org/D32199#731472, @rsmith wrote: > > As I've currently implemented it, both reads and writes set the type of > > previously-unknown storage, and after that it says fixed (unless you memcpy > > to it, memset it, or its lifetime ends (the type

[PATCH] D31975: [Analyzer] Iterator Checkers

baloghadamsoftware added a comment. Hello! I am not sure how to split it to incremental patches. As I mentioned in the description, the state of the iterator position is always tracked. So if I remove some of the checks it does not make the patch much smaller, since the checking part is quite

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

danielmarjamaki added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:337 + const Expr *BlockBytes, + ProgramStateRef State); static ProgramStateRef CallocMem(CheckerContext , const

[PATCH] D31568: Add Python 3 support to clang.cindex

This revision was automatically updated to reflect the committed changes. Closed by commit rL300829: Add Python 3 support to clang.cindex (authored by jbcoe). Changed prior to commit: https://reviews.llvm.org/D31568?vs=94120=95918#toc Repository: rL LLVM https://reviews.llvm.org/D31568

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:337 + const Expr *BlockBytes, + ProgramStateRef State); static ProgramStateRef CallocMem(CheckerContext , const

[PATCH] D32113: Add path from clang to doxygen document include header

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D32113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r300825 - PR19260: Teach doxygen to spell correctly the include paths.

Author: vvassilev Date: Thu Apr 20 03:57:41 2017 New Revision: 300825 URL: http://llvm.org/viewvc/llvm-project?rev=300825=rev Log: PR19260: Teach doxygen to spell correctly the include paths. Currently we have #include in the doxygen page documenting Sema. The patch changes it ot #include

[PATCH] D32113: Add path from clang to doxygen document include header

v.g.vassilev added a comment. Landed in r300825. Maybe we should do something like that for LLVM documentation, too. https://reviews.llvm.org/D32113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >