[PATCH] D41054: Teach clang/NetBSD about additional dependencies for sanitizers

eugenis added a comment. One problem with interceptors is that any sanitized binary looks (to a configure-like script) as if it implements forkpty. But an attempt to use forkpty without actually linking -lutil will fail at runtime, because interceptors are just wrappers. Repository: rL

[PATCH] D41054: Teach clang/NetBSD about additional dependencies for sanitizers

eugenis added a comment. Yes, I support adding -lutil - sorry I was not clear about that. By dlerror() errors, do you mean the warnings about missing interceptors that appear with verbosity=1 (non-fatal), or something else? Repository: rL LLVM https://reviews.llvm.org/D41054

[PATCH] D40925: Add option -fkeep-static-consts

rnk added a comment. This isn't sufficient, GlobalDCE will remove the internal constant. It's also unlikely that the constant will survive `--gc-sections / -fdata-sections`. A better solution would be to add a new attribute (`__attribute__((nondiscardable))`? too close to `nodiscard`?) that

r320747 - Revert "[ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style"

Author: benhamilton Date: Thu Dec 14 13:44:11 2017 New Revision: 320747 URL: http://llvm.org/viewvc/llvm-project?rev=320747=rev Log: Revert "[ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style" This reverts commit 37e69667f748e1458b46483b7c1b8f9ba33eec44. We're

[PATCH] D41259: [debuginfo] Remove temporary FIXME.

hintonda created this revision. hintonda added reviewers: zturner, aprantl. Herald added a subscriber: JDevlieghere. Now that r320495, "[debuginfo-tests] Support moving debuginfo-tests to llvm/projects," has landed, remove temporary FIXME that supported the old mechanism. Repository: rC Clang

[PATCH] D41232: [clangd] Add a FileSymbols container that manages symbols from multiple files.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/FileSymbols.h:39 + + /// \brief Removes snapshots of \p Path. + void remove(PathRef Path); Consider just accepting

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle requested changes to this revision. malaperle added a comment. This revision now requires changes to proceed. Herald added a subscriber: mgrang. Needs to be rebased. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D35894

[PATCH] D40489: [clangd] Changed tracing interfaces

ilya-biryukov added inline comments. Comment at: clangd/Trace.cpp:134 + Callback = T->beginSpan(Ctx, Name); + if (!Callback) +return; sammccall wrote: > I'm not sure this is useful. Tracers that aren't interested in args can't opt > out by providing a

[PATCH] D41232: [clangd] Add a FileSymbols container that manages symbols from multiple files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL320701: [clangd] Add a FileSymbols container that manages symbols from multiple files. (authored by ioeric, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41232 Files:

[clang-tools-extra] r320701 - [clangd] Add a FileSymbols container that manages symbols from multiple files.

Author: ioeric Date: Thu Dec 14 06:50:58 2017 New Revision: 320701 URL: http://llvm.org/viewvc/llvm-project?rev=320701=rev Log: [clangd] Add a FileSymbols container that manages symbols from multiple files. Reviewers: sammccall Reviewed By: sammccall Subscribers: klimek, mgorny, ilya-biryukov,

[PATCH] D40488: [clangd] Implemented tracing using Context

ilya-biryukov updated this revision to Diff 126951. ilya-biryukov added a comment. - Renamed TracingSession to Session (it is always used qualified via trace::Session anyway) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40488 Files: clangd/ClangdUnit.cpp

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz updated this revision to Diff 126953. saar.raz added a comment. Previous updated diff mistakenly included https://reviews.llvm.org/D40381, fixed that. Repository: rC Clang https://reviews.llvm.org/D41217 Files: include/clang/AST/DeclTemplate.h include/clang/AST/ExprCXX.h

r320697 - Warn if we find a Unicode homoglyph for a symbol in an identifier.

Author: rsmith Date: Thu Dec 14 05:15:08 2017 New Revision: 320697 URL: http://llvm.org/viewvc/llvm-project?rev=320697=rev Log: Warn if we find a Unicode homoglyph for a symbol in an identifier. Specifically, warn if: * we find a character that the language standard says we must treat as an

[PATCH] D41102: Setup clang-doc frontend framework

JDevlieghere added inline comments. Comment at: tools/clang-doc/ClangDoc.h:40 + + void ParseUnattachedComments(); + bool ParseNewDecl(const NamedDecl *D); I know it's confusing given the amount of existing code that uses UpperCamelCase for functions, but I

r320702 - Renamed test file to use proper naming convention

Author: ibiryukov Date: Thu Dec 14 06:51:17 2017 New Revision: 320702 URL: http://llvm.org/viewvc/llvm-project?rev=320702=rev Log: Renamed test file to use proper naming convention Also changed the order of CHECK statements. CHEKC-NOT must come before CHECK in skipped-function-bodies.cpp Added:

[PATCH] D41237: [Frontend] Handle skipped bodies in template instantiations

ilya-biryukov created this revision. ilya-biryukov added reviewers: sepavloff, bkramer. - Fixed an assert in Sema::InstantiateFunctionDefinition and added support for instantiating a function template with skipped body. - Properly call setHasSkippedBody for FunctionTemplateDecl passed to

[PATCH] D41050: Fix over-release of return value of lambda implicitly converted to block/function pointer

danzimm added a comment. Also, I don't have commit access. Could someone else commit this for me? Repository: rC Clang https://reviews.llvm.org/D41050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz updated this revision to Diff 126950. saar.raz added a comment. - Fixed indentation problems Repository: rC Clang https://reviews.llvm.org/D41217 Files: include/clang/AST/DeclTemplate.h include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor.h

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added inline comments. Comment at: include/clang/Frontend/ASTUnit.h:196 + /// \brief Counter indicating how often the preamble was build in total. + unsigned PreambleCounter; + ilya-biryukov wrote: > nik wrote: > > Any better name for this one? Otherwise I

[PATCH] D41217: [Concepts] Concept Specialization Expressions

saar.raz marked 2 inline comments as done. saar.raz added a comment. Fixed indentations. Repository: rC Clang https://reviews.llvm.org/D41217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41189: [Frontend] Treat function with skipped body as definition

This revision was automatically updated to reflect the committed changes. Closed by commit rC320696: [Frontend] Treat function with skipped body as definition (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D41189?vs=126787=126932#toc Repository: rC

r320696 - [Frontend] Treat function with skipped body as definition

Author: ibiryukov Date: Thu Dec 14 05:00:33 2017 New Revision: 320696 URL: http://llvm.org/viewvc/llvm-project?rev=320696=rev Log: [Frontend] Treat function with skipped body as definition Summary: This fixes an invalid warning about missing definition of a function when parsing with

Re: r320697 - Warn if we find a Unicode homoglyph for a symbol in an identifier.

On Thu, Dec 14, 2017 at 8:15 AM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Thu Dec 14 05:15:08 2017 > New Revision: 320697 > > URL: http://llvm.org/viewvc/llvm-project?rev=320697=rev > Log: > Warn if we find a Unicode homoglyph for a symbol in an

[PATCH] D41232: [clangd] Add a FileSymbols container that manages symbols from multiple files.

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, ilya-biryukov, mgorny, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41232 Files: clangd/CMakeLists.txt clangd/index/FileSymbols.cpp clangd/index/FileSymbols.h

[PATCH] D40488: [clangd] Implemented tracing using Context

This revision was automatically updated to reflect the committed changes. Closed by commit rL320706: [clangd] Implemented tracing using Context (authored by ibiryukov, committed by ). Repository: rL LLVM https://reviews.llvm.org/D40488 Files: clang-tools-extra/trunk/clangd/ClangdUnit.cpp

[clang-tools-extra] r320706 - [clangd] Implemented tracing using Context

Author: ibiryukov Date: Thu Dec 14 07:04:59 2017 New Revision: 320706 URL: http://llvm.org/viewvc/llvm-project?rev=320706=rev Log: [clangd] Implemented tracing using Context Reviewers: sammccall, ioeric, hokein Reviewed By: sammccall Subscribers: klimek, luckygeck, cfe-commits Differential

r320707 - [c++20] P0515R3: Parsing support and basic AST construction for operator <=>.

Author: rsmith Date: Thu Dec 14 07:16:18 2017 New Revision: 320707 URL: http://llvm.org/viewvc/llvm-project?rev=320707=rev Log: [c++20] P0515R3: Parsing support and basic AST construction for operator <=>. Adding the new enumerator forced a bunch more changes into this patch than I would have

[PATCH] D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble.

malaperle requested changes to this revision. malaperle added inline comments. This revision now requires changes to proceed. Comment at: include/clang/Frontend/PrecompiledPreamble.h:263 const MacroDirective *MD); + /// Adds list of

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in r320713. https://reviews.llvm.org/D40671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r320708 - [clangd] Changed tracing interfaces

Author: ibiryukov Date: Thu Dec 14 07:33:38 2017 New Revision: 320708 URL: http://llvm.org/viewvc/llvm-project?rev=320708=rev Log: [clangd] Changed tracing interfaces Summary: EventTracer interface now contains two methods: - spanEvent for events that have duration, - instant for events that are

[PATCH] D41239: Turn a config macro (_LIBCPP_HAS_NO_INLINE_VARIABLES) into an attribute macro (_LIBCPP_INLINE_VAR)

mclow.lists created this revision. mclow.lists added a reviewer: EricWF. We're going to be defining a lot of inline variables going forward, and the current way of doing it is ... long-winded. Add an attribute macro which we can put everywhere we need, and handles the conditional. Instead of

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

ro added a comment. I forgot: this patch is on top of https://reviews.llvm.org/D35755. Repository: rC Clang https://reviews.llvm.org/D41240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

rsmith added a comment. Mechanically, the code change looks fine, but I can't comment on whether this is a correct change for Solaris, or whether the type provided by `__float128` would use the right floating-point representation. You will also need to provide a test for this change.

[PATCH] D41195: [ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style

This revision was automatically updated to reflect the committed changes. Closed by commit rC320714: [ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style (authored by benhamilton, committed by ). Changed prior to commit:

r320714 - [ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style

Author: benhamilton Date: Thu Dec 14 08:17:38 2017 New Revision: 320714 URL: http://llvm.org/viewvc/llvm-project?rev=320714=rev Log: [ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style Summary: If we write the following code, it goes over 100 columns, so we need to

[PATCH] D40548: [clangd] Symbol index interfaces and an in-memory index implementation.

malaperle added a comment. In https://reviews.llvm.org/D40548#947081, @ioeric wrote: > Hi Marc, the patch is not ready for review yet. I am still cleaning up the > prototype and will let you know when it's ready for review. I guess it was ready to review since it was submitted? ;)

[PATCH] D40489: [clangd] Changed tracing interfaces

ilya-biryukov updated this revision to Diff 126957. ilya-biryukov added a comment. Merged with head Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40489 Files: clangd/Trace.cpp clangd/Trace.h Index: clangd/Trace.h

[clang-tools-extra] r320713 - Add support for NOLINT and NOLINTNEXTLINE comments mentioning specific check names.

Author: aaronballman Date: Thu Dec 14 08:13:57 2017 New Revision: 320713 URL: http://llvm.org/viewvc/llvm-project?rev=320713=rev Log: Add support for NOLINT and NOLINTNEXTLINE comments mentioning specific check names. Supports a comma-separated list of check names to be disabled on the given

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

cameron314 added a comment. Ping? The patch is ready to go, just needs a final approval... https://reviews.llvm.org/D20124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

aaron.ballman added inline comments. Comment at: test/clang-tidy/fuchsia-virtual-inheritance.cpp:34-36 + // CHECK-MESSAGES: [[@LINE-1]]:28: warning: constructing a class that inherits a virtual base class is disallowed [fuchsia-virtual-inheritance] + // CHECK-NEXT: D(int

[PATCH] D41239: Turn a config macro (_LIBCPP_HAS_NO_INLINE_VARIABLES) into an attribute macro (_LIBCPP_INLINE_VAR)

mclow.lists added a comment. There are no tests because this should not change any functionality. https://reviews.llvm.org/D41239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40489: [clangd] Changed tracing interfaces

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE320708: [clangd] Changed tracing interfaces (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D40489?vs=126957=126959#toc Repository: rCTE Clang Tools Extra

r320709 - When attempting to complete an incomplete array bound type in an expression,

Author: rsmith Date: Thu Dec 14 07:40:16 2017 New Revision: 320709 URL: http://llvm.org/viewvc/llvm-project?rev=320709=rev Log: When attempting to complete an incomplete array bound type in an expression, update the type from the definition even if we didn't instantiate a definition. We may have

[PATCH] D41242: [Solaris] Silence -pthread warning on Solaris

ro created this revision. ro added a reviewer: rsmith. Herald added a subscriber: fedor.sergeev. During make check-all on Solaris, I see several instances of this warning: clang-6.0: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument] Since Solaris 10,

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

aaron.ballman added a comment. In https://reviews.llvm.org/D40671#954906, @xgsa wrote: > In https://reviews.llvm.org/D40671#954661, @alexfh wrote: > > > In https://reviews.llvm.org/D40671#953888, @aaron.ballman wrote: > > > > > FWIW, I think we should do something about unknown check names in

[PATCH] D41195: [ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style

benhamilton updated this revision to Diff 126969. benhamilton marked an inline comment as done. benhamilton added a comment. - Use 40 column limit for test. Repository: rC Clang https://reviews.llvm.org/D41195 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index:

[PATCH] D41195: [ClangFormat] IndentWrappedFunctionNames should be true in the google ObjC style

benhamilton added inline comments. Comment at: unittests/Format/FormatTestObjC.cpp:388 + // Wrapped method parameters should be indented. + verifyFormat("- (VeryLongReturnTypeName)\n" + "veryLongMethodParameter:(VeryLongParameterName)"

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

Nebiroth updated this revision to Diff 126980. Nebiroth marked 5 inline comments as done. Nebiroth added a comment. Removed test file Added mutex lock when changing CDB Minor code cleanup Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D39571 Files: clangd/ClangdLSPServer.cpp

[PATCH] D41240: [Solaris] __float128 is supported on Solaris/x86

ro created this revision. ro added a reviewer: rsmith. Herald added a subscriber: fedor.sergeev. When rebasing https://reviews.llvm.org/D40898 with GCC 5.4 on Solaris 11.4, I ran into a few instances of In file included from

[PATCH] D41241: [Solaris] Only define _REENTRANT if -pthread

ro created this revision. ro added a reviewer: rsmith. Herald added a subscriber: fedor.sergeev. When looking at lib/Basic/Targets/OSTargets.h, I noticed that _REENTRANT is defined unconditionally on Solaris, unlike all other targets and what either Studio cc (only define it with -mt) or gcc

r320717 - [OPENMP] Add codegen for target data constructs with `nowait` clause.

Author: abataev Date: Thu Dec 14 09:00:17 2017 New Revision: 320717 URL: http://llvm.org/viewvc/llvm-project?rev=320717=rev Log: [OPENMP] Add codegen for target data constructs with `nowait` clause. Added codegen for the `nowait` clause in target data constructs. Modified:

[PATCH] D40743: Make rehash(0) work with ubsan's unsigned-integer-overflow.

mclow.lists accepted this revision. mclow.lists added inline comments. This revision is now accepted and ready to land. Comment at: include/__hash_table:2141 __n = 2; else if (__n & (__n - 1)) __n = __next_prime(__n); danalbert wrote: >

[PATCH] D40548: [clangd] Symbol index interfaces and an in-memory index implementation.

ioeric added a comment. In https://reviews.llvm.org/D40548#955289, @malaperle wrote: > In https://reviews.llvm.org/D40548#947081, @ioeric wrote: > > > Hi Marc, the patch is not ready for review yet. I am still cleaning up the > > prototype and will let you know when it's ready for review. > > >

[clang-tools-extra] r320694 - [clangd] Construct SymbolSlab from YAML format.

Author: hokein Date: Thu Dec 14 04:17:14 2017 New Revision: 320694 URL: http://llvm.org/viewvc/llvm-project?rev=320694=rev Log: [clangd] Construct SymbolSlab from YAML format. Summary: This will be used together with D40548 for the global index source (experimental). Reviewers: sammccall

[clang-tools-extra] r320695 - [clangd] Fix a potential use-after-move bug.

Author: ioeric Date: Thu Dec 14 04:31:04 2017 New Revision: 320695 URL: http://llvm.org/viewvc/llvm-project?rev=320695=rev Log: [clangd] Fix a potential use-after-move bug. Modified: clang-tools-extra/trunk/unittests/clangd/IndexTests.cpp Modified:

[PATCH] D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr

lebedev.ri added a comment. Hi. I don't want to hijack the thread, but is PR32954 likely unrelated to this fix, and the problem (if it is a bug) is likely elsewhere? Repository: rC Clang https://reviews.llvm.org/D41224

[PATCH] D40561: [libclang] Fix cursors for functions with trailing return type

nik added a comment. Ping..."Please submit as I don't have the permissions for this." https://reviews.llvm.org/D40561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41232: [clangd] Add a FileSymbols container that manages symbols from multiple files.

ioeric updated this revision to Diff 126944. ioeric added a comment. - fix HEADER_GUARD Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41232 Files: clangd/CMakeLists.txt clangd/index/FileSymbols.cpp clangd/index/FileSymbols.h unittests/clangd/CMakeLists.txt

[PATCH] D41050: Fix over-release of return value of lambda implicitly converted to block/function pointer

danzimm added a comment. @dexonsmith Here are my results after passing those extra flags with `-O3` (/Users/danzimm/oss/build/bin/clang -cc1 -internal-isystem /Users/danzimm/oss/build/lib/clang/6.0.0/include -nostdsysteminc -triple x86_64-apple-macosx10.12.0 -emit-llvm -disable-llvm-passes -O3

[PATCH] D39903: [libclang] Allow pretty printing declarations

nik added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D39903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

nik added a comment. Ping. https://reviews.llvm.org/D40481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41250: [analyzer] Model implied cast around operator new().

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs, eraman. C++ overridable `operator new()` has the following prototype: void *operator new(size_t size, user-defined arguments...); The

Re: [PATCH] D39622: Fix type name generation in DWARF for template instantiations with enum types and template specializations

On Thu, Dec 14, 2017 at 2:21 AM Anton via Phabricator < revi...@reviews.llvm.org> wrote: > xgsa added a comment. > > In https://reviews.llvm.org/D39622#954585, @probinson wrote: > > > Philosophically, mangled names and DWARF information serve different > purposes, and I don't think you will find

[PATCH] D41253: [analyzer] WIP: trackNullOrUndefValue: track last store to symbolic pointers.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs, eraman. `bugreporter::trackNullOrUndefValue()` checker API function extends a bug report with a recursive family of bug report visitors

[PATCH] D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM, but you should wait to commit for a few days in case @delesley has any concerns. Repository: rC Clang https://reviews.llvm.org/D41224

Re: Status of CET support? (Re: [PATCH] D40224:...)

On Thu, Dec 14, 2017 at 2:39 AM, Pavel Chupin wrote: > Hi Kostya, > Long time no see. :) > Yey!! Thanks for the update! --kcc > I would estimate that everything (glibc, kernel, loader, simulator) > should be available approx. February 2018 as soon as implementation

r320734 - [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like

Author: arphaman Date: Thu Dec 14 11:22:02 2017 New Revision: 320734 URL: http://llvm.org/viewvc/llvm-project?rev=320734=rev Log: [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like builtin macros This patch implements the __is_target_arch, __is_target_vendor,

[PATCH] D41087: [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like builtin macros

This revision was automatically updated to reflect the committed changes. Closed by commit rC320734: [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like (authored by arphaman, committed by ). Changed prior to commit:

[PATCH] D40548: [clangd] Symbol index interfaces and an in-memory index implementation.

malaperle added inline comments. Comment at: clangd/index/Index.h:134 + virtual bool + fuzzyFind(Context , const FuzzyFindRequest , +std::function Callback) const = 0; ioeric wrote: > malaperle wrote: > > I think a more

[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

erichkeane updated this revision to Diff 127005. erichkeane added a comment. Fix error message per @aaron.ballman s suggestion. https://reviews.llvm.org/D40819 Files: include/clang/AST/Decl.h include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D39994: Loosen MSVC 2017 path requirements

dmajor added a comment. > Anyway, I'm just venting. If rnk@ wants to lgtm this, I'm fine. @rnk, any objection to this patch? https://reviews.llvm.org/D39994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36952: [libclang] Add support for checking abstractness of records

arphaman added a comment. Sure, I'll do it today. https://reviews.llvm.org/D36952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40478: Added Instrument Control Flow Flag

oren_ben_simhon updated this revision to Diff 127008. oren_ben_simhon added a comment. Implemented all comments posted until 12/14 (Thanks Peter) Repository: rL LLVM https://reviews.llvm.org/D40478 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def

[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9333-9335 + "multiversion function would have identical mangling to a previous " + "definition. Duplicate declarations must have identical target attribute " + "values">;

[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

erichkeane added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9333 +def err_multiversion_duplicate : Error< + "multiversion function duplicate declarations require identical target " + "attributes">; aaron.ballman wrote: > instead of

[PATCH] D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr

kongyi added a comment. In https://reviews.llvm.org/D41224#955213, @lebedev.ri wrote: > Hi. > I don't want to hijack the thread, but is PR32954 > likely unrelated to this fix, > and the problem (if it is a bug) is likely elsewhere? Should be

Re: r320734 - [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like

Sorry, I forgot to add the tests in SVN. I committed them in 320735 On 14 December 2017 at 11:22, Alex Lorenz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: arphaman > Date: Thu Dec 14 11:22:02 2017 > New Revision: 320734 > > URL:

r320735 - Commit missing tests for r320734

Author: arphaman Date: Thu Dec 14 11:22:41 2017 New Revision: 320735 URL: http://llvm.org/viewvc/llvm-project?rev=320735=rev Log: Commit missing tests for r320734 Added: cfe/trunk/test/Preprocessor/is_target.c cfe/trunk/test/Preprocessor/is_target_arm.c

[PATCH] D41054: Teach clang/NetBSD about additional dependencies for sanitizers

joerg added a comment. I'm not really a fan of linking libutil into all binaries. Why is this code using forkpty in first place and not posix_openpt/grantpt? Repository: rL LLVM https://reviews.llvm.org/D41054 ___ cfe-commits mailing list

[PATCH] D41054: Teach clang/NetBSD about additional dependencies for sanitizers

krytarowski added a comment. In https://reviews.llvm.org/D41054#955755, @joerg wrote: > I'm not really a fan of linking libutil into all binaries. Why is this code > using forkpty in first place and not posix_openpt/grantpt? pid_t forkpty(int *amaster, char *name, struct termios *term,

[PATCH] D40651: Implement most of P0451 - Constexpr for std::complex

mclow.lists updated this revision to Diff 126986. mclow.lists added a comment. More context in the diff, and removed some tabs. Also commented out the constexpr tests for divide, since they fail at the moment. https://reviews.llvm.org/D40651 Files: include/complex

[PATCH] D41103: [CMake] Allow passing extra CMake arguments to custom libc++

vitalybuka added a comment. Can you please add some details about why someone wants to customize LIBXX here? Or even better attach a patch which uses this. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D41103 ___ cfe-commits mailing

[PATCH] D41050: Fix over-release of return value of lambda implicitly converted to block/function pointer

rjmccall closed this revision. rjmccall added a comment. Sure, r320721. Repository: rC Clang https://reviews.llvm.org/D41050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r320721 - In an ARC lambda-to-block conversion thunk, reclaim the return value of

Author: rjmccall Date: Thu Dec 14 10:21:14 2017 New Revision: 320721 URL: http://llvm.org/viewvc/llvm-project?rev=320721=rev Log: In an ARC lambda-to-block conversion thunk, reclaim the return value of the lambda so that we don't over-release it. Patch by Dan Zimmerman! Added:

[PATCH] D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble.

Nebiroth updated this revision to Diff 126984. Nebiroth marked an inline comment as done. Nebiroth added a comment. Minor code cleanup Repository: rC Clang https://reviews.llvm.org/D39375 Files: include/clang/Frontend/PrecompiledPreamble.h lib/Frontend/PrecompiledPreamble.cpp Index:

[PATCH] D41248: [libcxx] Suppress unused warning on apple.

hintonda created this revision. hintonda added a reviewer: EricWF. This warning is already suppressed on non-apple platforms, so this change just suppresses it on apple as well. Repository: rCXX libc++ https://reviews.llvm.org/D41248 Files: src/experimental/filesystem/operations.cpp

r320730 - [CodeGen][X86] Implement _InterlockedCompareExchange128 intrinsic

Author: rnk Date: Thu Dec 14 11:00:21 2017 New Revision: 320730 URL: http://llvm.org/viewvc/llvm-project?rev=320730=rev Log: [CodeGen][X86] Implement _InterlockedCompareExchange128 intrinsic Summary: InterlockedCompareExchange128 is a bit more complicated than the other

[PATCH] D41032: [CodeGen][X86] Implement _InterlockedCompareExchange128 intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rC320730: [CodeGen][X86] Implement _InterlockedCompareExchange128 intrinsic (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D41032?vs=126641=126997#toc Repository:

[clang-tools-extra] r320743 - [clangd] Put all #includes in one block in clangd source files. NFC

Author: ioeric Date: Thu Dec 14 13:22:03 2017 New Revision: 320743 URL: http://llvm.org/viewvc/llvm-project?rev=320743=rev Log: [clangd] Put all #includes in one block in clangd source files. NFC Clang-format categorizes and sorts #includes with style. It doesn't make sense to manually managing

[PATCH] D41054: Teach clang/NetBSD about additional dependencies for sanitizers

krytarowski added a comment. `-lutil` is just the same case as `-lrt` or `-lm` here. The potential problem with with autoconf and similar is the design problem, not NetBSD linking here with -lutil. Without this -lutil, every sanitizer with interceptors will generate spurious dlerror() errors

[PATCH] D41258: [analyzer] trackNullOrUndefValue: deduplicate path pieces for each node.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. This addresses the regression in https://reviews.llvm.org/D41254 in `inlining/path-notes.cpp` by adding a new straightforward mechanism that

r320752 - Harmonize GNU- and C++-style attribute spellings.

Author: aaronballman Date: Thu Dec 14 14:17:09 2017 New Revision: 320752 URL: http://llvm.org/viewvc/llvm-project?rev=320752=rev Log: Harmonize GNU- and C++-style attribute spellings. Most attributes will now use the Clang<"name"> construct to provide both __attribute__((name)) and

[PATCH] D36790: [ObjC] Messages to 'self' in class methods that return 'instancetype' should use the pointer to the class as the result type of the message

arphaman added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D36790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r320748 - [libclang] Add support for checking abstractness of records

Author: arphaman Date: Thu Dec 14 14:01:50 2017 New Revision: 320748 URL: http://llvm.org/viewvc/llvm-project?rev=320748=rev Log: [libclang] Add support for checking abstractness of records This patch allows checking whether a C++ record declaration is abstract through libclang and clang.cindex

[PATCH] D36952: [libclang] Add support for checking abstractness of records

This revision was automatically updated to reflect the committed changes. Closed by commit rL320748: [libclang] Add support for checking abstractness of records (authored by arphaman, committed by ). Changed prior to commit: https://reviews.llvm.org/D36952?vs=126298=127021#toc Repository:

[PATCH] D41259: [debuginfo] Remove temporary FIXME.

This revision was automatically updated to reflect the committed changes. Closed by commit rC320751: [debuginfo] Remove temporary FIXME. (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D41259?vs=127019=127025#toc Repository: rC Clang

r320751 - [debuginfo] Remove temporary FIXME.

Author: dhinton Date: Thu Dec 14 14:12:46 2017 New Revision: 320751 URL: http://llvm.org/viewvc/llvm-project?rev=320751=rev Log: [debuginfo] Remove temporary FIXME. Summary: Now that r320495, "[debuginfo-tests] Support moving debuginfo-tests to llvm/projects," has landed, remove temporary FIXME

[PATCH] D40625: Harmonizing attribute GNU/C++ spellings

aaron.ballman closed this revision. aaron.ballman added a comment. Committed (with additional comments on deviating attributes) in r320752. https://reviews.llvm.org/D40625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41054: Teach clang/NetBSD about additional dependencies for sanitizers

krytarowski added a comment. In particular, this issue has been detected with dtls_test.c (MSan test), but it is valid to every program checking dlerror(). I've pluged more missing symbols through https://reviews.llvm.org/D41053, there are still few but I'm now busy with teaching sanitizers

[PATCH] D40929: Unblock Swift Calling Convention Mangling on Windows

rnk added a comment. @compnerd's suggestion is still a decent one: https://reviews.llvm.org/D31372 Which, I think is just adding something wacky like `@swiftcc@__Swift@@` which would demangle as `__Swift::swiftcc` if the demangler expected an NNS there. Of course, it doesn't, so it won't

  1   2   >