Re: r329882 - ObjCGNU: Fix empty v3 protocols being emitted two fields short

This is missing an attribution of changes, right? From: cfe-commits on behalf of David Chisnall via cfe-commits Reply-To: David Chisnall Date: Wednesday, April 11, 2018 at 11:49 PM To:

[PATCH] D45555: Fix a link failure in applyChanges()

aheejin created this revision. aheejin added a reviewer: jdemeule. Herald added subscribers: cfe-commits, mgorny, klimek. This call (https://github.com/llvm-mirror/clang-tools-extra/blob/e6bfa666d96c0d3010bb7d572f6240424ebd1cff/clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp#L228-L229)

Re: r329882 - ObjCGNU: Fix empty v3 protocols being emitted two fields short

It does seem to be. I used arc to apply the change, so I’m not sure what happened - I thought it normally set the author correctly. David > On 12 Apr 2018, at 08:09, Shoaib Meenai wrote: > > This is missing an attribution of changes, right? > > From: cfe-commits

Re: [clang-tools-extra] r329873 - [clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself

Yes, a test that should fail, did not fail with old code. And it's a problem) чт, 12 апр. 2018 г. в 10:35, Roman Lebedev : > On Thu, Apr 12, 2018 at 10:30 AM, Zinovy Nis wrote: > > Yes, due to to incorrect token length returned by the old code, the

Re: r329882 - ObjCGNU: Fix empty v3 protocols being emitted two fields short

AFAIK you need to add the "Patch by …" line manually. I don't know if arc is supposed to preserve the original commit author information, though I would suspect the version control system itself plays a role there. From: David Chisnall on behalf of David Chisnall

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

whisperity requested changes to this revision. whisperity added subscribers: gsd, dkrupp, o.gyorgy. whisperity added a comment. This revision now requires changes to proceed. Sorry, one comment has gone missing meanwhile, I'm still getting used to this interface and hit //Submit// early.

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

lebedev.ri added a comment. @alexfh i'm waiting for some comment from you. there was no comment added when you removed yourself as a reviewer, so i *assume* the usual message of that time was meant - "removing from my review queue, re-add when others have accepted.". Repository: rCTE Clang

Re: [clang-tools-extra] r329873 - [clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself

On Thu, Apr 12, 2018 at 10:30 AM, Zinovy Nis wrote: > Yes, due to to incorrect token length returned by the old code, the test was > passing. I fixed it. Let me rephrase. If i revert just the clang-tools-extra/trunk/clang-tidy/modernize/UseAutoCheck.cpp change, will the

Re: [clang-tools-extra] r329873 - [clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself

Also, i guess you now can remove linking to clangTooling that was required to unbreak the build. I'm guessing clangLex contains Lexer::MeasureTokenLength() ? On Thu, Apr 12, 2018 at 10:22 AM, Roman Lebedev wrote: > Test? > > On Thu, Apr 12, 2018 at 8:41 AM, Zinovy Nis via

Re: [clang-tools-extra] r329873 - [clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself

Yes, due to to incorrect token length returned by the old code, the test was passing. I fixed it. Hm, you are right, clangTooling is not requirted anymore. чт, 12 апр. 2018 г. в 10:25, Roman Lebedev : > Also, i guess you now can remove linking to clangTooling that was >

[PATCH] D45557: [Analyzer] Fix for SValBuilder expressions rearrangement

baloghadamsoftware created this revision. baloghadamsoftware added a reviewer: NoQ. Herald added subscribers: dkrupp, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a reviewer: george.karpenkov. Expression rearrangement in SValBuilder (see https://reviews.llvm.org/rL329780)

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

whisperity added a comment. @NoQ Do you reckon these tests files are too long? Perhaps the one about this inheritance, that inheritance, diamond inheritance, etc. could be split into multiple files. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:317 +def

Re: [clang-tools-extra] r329873 - [clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself

Test? On Thu, Apr 12, 2018 at 8:41 AM, Zinovy Nis via cfe-commits wrote: > Author: zinovy.nis > Date: Wed Apr 11 22:41:24 2018 > New Revision: 329873 > > URL: http://llvm.org/viewvc/llvm-project?rev=329873=rev > Log: > [clang-tidy] [modernize-use-auto] Get only a

[PATCH] D45561: NFC - Indentation fixes in predefined-arch-macros.c

GBuella created this revision. GBuella added a reviewer: craig.topper. Herald added subscribers: cfe-commits, fedor.sergeev. Consistently separating tests with empty lines. Helps while navigating this file. Repository: rC Clang https://reviews.llvm.org/D45561 Files:

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

lebedev.ri added a comment. Third commit introducing linking errors. Did no buildbot catch those? Repository: rL LLVM https://reviews.llvm.org/D43764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45311: [X86] Introduce wbinvd intrinsic

GBuella updated this revision to Diff 142142. GBuella retitled this revision from "Introduce wbinvd intrinsic" to "[X86] Introduce wbinvd intrinsic". https://reviews.llvm.org/D45311 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/ia32intrin.h test/CodeGen/builtin-wbinvd.c Index:

[PATCH] D45564: [analyzer] Fix null deref in AnyFunctionCall::getRuntimeDefinition

r.stahl added a comment. I encountered this with a construct like this: struct S { void (*fp)(); }; int main() { struct S s; s.fp(); } Repository: rC Clang https://reviews.llvm.org/D45564 ___ cfe-commits mailing

[PATCH] D45564: [analyzer] Fix null deref in AnyFunctionCall::getRuntimeDefinition

r.stahl created this revision. r.stahl added reviewers: xazax.hun, dcoughlin, a.sidorin, george.karpenkov. Herald added subscribers: cfe-commits, rnkovacs, szepet. In https://reviews.llvm.org/D30691 code was added to getRuntimeDefinition that does not handle the case when FD==nullptr.

r329904 - Allow [[maybe_unused]] on static data members; these are considered variables and the attribute should appertain to them.

Author: aaronballman Date: Thu Apr 12 05:21:41 2018 New Revision: 329904 URL: http://llvm.org/viewvc/llvm-project?rev=329904=rev Log: Allow [[maybe_unused]] on static data members; these are considered variables and the attribute should appertain to them. Patch by S. B. Tam. Modified:

[clang-tools-extra] r329894 - [clang-apply-replacements] Always initialize FormatStyle.

Author: d0k Date: Thu Apr 12 03:35:24 2018 New Revision: 329894 URL: http://llvm.org/viewvc/llvm-project?rev=329894=rev Log: [clang-apply-replacements] Always initialize FormatStyle. The cleanup logic reads from this for cleanups even if reformatting is not requested. Found by msan. Modified:

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

alexfh added a comment. In https://reviews.llvm.org/D44602#1065331, @lebedev.ri wrote: > @alexfh i'm waiting for some comment from you. there was no comment added > when you removed yourself as a reviewer, > so i *assume* the usual message of that time was meant - "removing from my > review

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

alexfh added inline comments. Comment at: test/clang-tidy/readability-identifier-naming-objc.m:8-9 +// RUN: ]}' -- -fno-delayed-template-parsing \ +// RUN: -I%S/Inputs/readability-identifier-naming \ +// RUN: -isystem %S/Inputs/readability-identifier-naming/system +

[clang-tools-extra] r329902 - [clang-tidy] readability-function-size: add VariableThreshold param.

Author: lebedevri Date: Thu Apr 12 05:06:42 2018 New Revision: 329902 URL: http://llvm.org/viewvc/llvm-project?rev=329902=rev Log: [clang-tidy] readability-function-size: add VariableThreshold param. Summary: Pretty straight-forward, just count all the variable declarations in the function's

r329823 - bpf: accept all asm register names

Author: yhs Date: Wed Apr 11 09:08:00 2018 New Revision: 329823 URL: http://llvm.org/viewvc/llvm-project?rev=329823=rev Log: bpf: accept all asm register names Sometimes when people compile bpf programs with "clang ... -target bpf ...", the kernel header files may contain host arch inline

[PATCH] D45403: Make [[maybe_unused]] work with static data members

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in r329904, thank you for the patch! https://reviews.llvm.org/D45403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r329892 - [clang-apply-replacements] Don't forget to link to clangToolingRefactor

Author: lebedevri Date: Thu Apr 12 03:01:20 2018 New Revision: 329892 URL: http://llvm.org/viewvc/llvm-project?rev=329892=rev Log: [clang-apply-replacements] Don't forget to link to clangToolingRefactor Fixes build: [1/3] Linking CXX shared library lib/libclangApplyReplacements.so.7svn FAILED:

[PATCH] D45555: [clang-apply-replacements] Fix a link failure in applyChanges()

aheejin abandoned this revision. aheejin added a comment. Looks like the same patch https://reviews.llvm.org/rL329892 has already landed. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D4 ___ cfe-commits mailing list

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

malcolm.parsons added a comment. In https://reviews.llvm.org/D43764#1065345, @lebedev.ri wrote: > Third commit introducing linking errors. > Did no buildbot catch those? 2 buildbots sent me an email, but they were unrelated failures. Repository: rL LLVM https://reviews.llvm.org/D43764

[PATCH] D45555: [clang-apply-replacements] Fix a link failure in applyChanges()

lebedev.ri added a comment. In https://reviews.llvm.org/D4#1065387, @aheejin wrote: > Looks like the same patch https://reviews.llvm.org/rL329892 has already > landed. Sorry, somehow i missed this differential. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D4

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

lebedev.ri added a comment. In https://reviews.llvm.org/D44602#1065366, @alexfh wrote: > In https://reviews.llvm.org/D44602#1065331, @lebedev.ri wrote: > > > @alexfh i'm waiting for some comment from you. there was no comment added > > when you removed yourself as a reviewer, > > so i *assume*

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE329902: [clang-tidy] readability-function-size: add VariableThreshold param. (authored by lebedevri, committed by ). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44602 Files:

r329848 - [x86] wbnoinvd intrinsic

Author: gbuella Date: Wed Apr 11 13:09:09 2018 New Revision: 329848 URL: http://llvm.org/viewvc/llvm-project?rev=329848=rev Log: [x86] wbnoinvd intrinsic The WBNOINVD instruction writes back all modified cache lines in the processor’s internal cache to main memory but does not invalidate (flush)

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

miyuki updated this revision to Diff 142165. miyuki added a comment. Updated the test case https://reviews.llvm.org/D45255 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CodeGenModule.cpp

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

miyuki added a comment. One use case for this is debugging: this flag makes it easier to find out which revisions of LLVM introduce changes in codegen and/or debug information without having to filter out .ident/producer metadata. Some users can also use this flag (or an equivalent,

[PATCH] D45513: [clangd] Add line and column number to the index symbol.

hokein updated this revision to Diff 142170. hokein marked 5 inline comments as done. hokein added a comment. Address review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45513 Files: clangd/index/Index.cpp clangd/index/Index.h clangd/index/SymbolCollector.cpp

Re: r329804 - [Sema] Fix built-in decrement operator overload resolution

Hi Richard, Here you are: https://reviews.llvm.org/D45569 I am now thinking if it makes sense to output this warning for pre-17 standards: warning: incrementing expression of type bool is deprecated and incompatible with C++17 Produced in: SemaExpr.cpp

[PATCH] D45570: [XRay] [clang] use compiler-rt's symbol visibility rules

pelikan created this revision. pelikan added a reviewer: dberris. Depends on https://reviews.llvm.org/D38993. Repository: rC Clang https://reviews.llvm.org/D45570 Files: lib/Driver/ToolChains/CommonArgs.cpp Index: lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D45513: [clangd] Add line and column number to the index symbol.

sammccall added inline comments. Comment at: clangd/index/Index.h:27 struct SymbolLocation { + struct Position { +// Line position in a document (zero-based). sammccall wrote: > There are 4 of these per symbol, if we can keep line + character to 32 bits >

[PATCH] D45570: [XRay] [clang] use compiler-rt's symbol visibility rules

pelikan updated this revision to Diff 142174. pelikan added a comment. while there, clang-format the code I touched Repository: rC Clang https://reviews.llvm.org/D45570 Files: lib/Driver/ToolChains/CommonArgs.cpp Index: lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

sammccall added a comment. Still LG, thanks! I'll look into the testing issue. Comment at: clangd/ClangdLSPServer.cpp:113 + auto KindVal = static_cast(Kind); + if (KindVal >= SymbolKindMin && KindVal <= SymbolKindMax) +SupportedSymbolKinds.set(KindVal);

r329914 - Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Author: malcolm.parsons Date: Thu Apr 12 07:48:48 2018 New Revision: 329914 URL: http://llvm.org/viewvc/llvm-project?rev=329914=rev Log: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency Summary: This patch adds two new diagnostics, which are off by default:

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

This revision was automatically updated to reflect the committed changes. Closed by commit rC329914: Diagnose cases of return x that should be return std::move(x) for efficiency (authored by malcolm.parsons, committed by ). Repository: rC Clang https://reviews.llvm.org/D43322 Files:

Re: [PATCH] D45526: [clang-format] Prefer breaking after ObjC category close paren

True. I will reword the description to clarify. On Thu, Apr 12, 2018, 07:58 Daniel Jasper via Phabricator < revi...@reviews.llvm.org> wrote: > djasper added a comment. > > I understand that, but the test example does not break after the closing > paren. It breaks after the subsequent "<". > > >

[PATCH] D45526: [clang-format] Prefer breaking after ObjC category close paren

djasper added a comment. I understand that, but the test example does not break after the closing paren. It breaks after the subsequent "<". Repository: rC Clang https://reviews.llvm.org/D45526 ___ cfe-commits mailing list

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

rogfer01 added a comment. There is a flag `-fno-ident` that has the same effect in GCC https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#index-fno-ident although it involves also ignoring the `#ident`. A quick look seems to suggest that #ident is just ignored in the usual PP callbacks

[PATCH] D45569: [Sema] Disable built-in increment operator for bool in overload resolution in C++17

jkorous-apple created this revision. jkorous-apple added a reviewer: rsmith. Herald added a subscriber: cfe-commits. Following: https://llvm.org/svn/llvm-project/cfe/trunk@329804 For C++17 the wording of [over.built] p4 excluded bool: For every pair (T , vq), where T is an arithmetic type other

r329911 - [OpenCL] Added -std/-cl-std=c++

Author: stulova Date: Thu Apr 12 07:17:04 2018 New Revision: 329911 URL: http://llvm.org/viewvc/llvm-project?rev=329911=rev Log: [OpenCL] Added -std/-cl-std=c++ This is std option for OpenCL C++ v1.0. Differential Revision: https://reviews.llvm.org/D45363 Modified:

[PATCH] D45363: [OpenCL] Added -std/-cl-std=CL2.2/CLC++

This revision was automatically updated to reflect the committed changes. Closed by commit rC329911: [OpenCL] Added -std/-cl-std=c++ (authored by stulova, committed by ). Repository: rC Clang https://reviews.llvm.org/D45363 Files: include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D45363: [OpenCL] Added -std/-cl-std=CL2.2/CLC++

This revision was automatically updated to reflect the committed changes. Closed by commit rL329911: [OpenCL] Added -std/-cl-std=c++ (authored by stulova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45363?vs=141975=142171#toc

[PATCH] D45513: [clangd] Add line and column number to the index symbol.

hokein added inline comments. Comment at: clangd/index/Index.h:39 // using half-open range, [StartOffset, EndOffset). + // FIXME(hokein): remove these fields in favor of Position. unsigned StartOffset = 0; sammccall wrote: > I don't think we should remove

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle added a comment. In https://reviews.llvm.org/D44882#1065622, @sammccall wrote: > Still LG, thanks! > I'll look into the testing issue. I thought about it after... I think it was because I was trying to test with std::unordered_map (to prevent multiple results) which needs

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

sammccall added a comment. In https://reviews.llvm.org/D44882#1065631, @malaperle wrote: > In https://reviews.llvm.org/D44882#1065622, @sammccall wrote: > > > Still LG, thanks! > > I'll look into the testing issue. > > > I thought about it after... I think it was because I was trying to test

[PATCH] D45526: [clang-format] Prefer breaking after ObjC category close paren

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Comment at: lib/Format/TokenAnnotator.cpp:2276 + // In Objective-C type declarations, prefer breaking after the category's + // close paren instead of after

[PATCH] D45004: [clang-format] Always indent wrapped Objective-C selector names

djasper accepted this revision. djasper added inline comments. This revision is now accepted and ready to land. Comment at: unittests/Format/FormatTest.cpp:7666 FormatStyle Style = getLLVMStyle(); + // ObjC ignores IndentWrappedFunctionNames when wrapping methods.

[PATCH] D45526: [clang-format] Prefer breaking after ObjC category close paren

djasper added a comment. Both patch and comment inside patch say "break after closing paren" and yet that's not what the test or example in the description actually do. Why is that? Repository: rC Clang https://reviews.llvm.org/D45526 ___

[PATCH] D45544: [AAch64] Add the __ARM_FEATURE_DOTPROD macro definition

SjoerdMeijer added a comment. Hi, thanks for adding this. Also wanted to confirm that macro __ARM_FEATURE_DOTPROD will defined/included in the next release of the ACLE. Comment at: lib/Basic/Targets/AArch64.h:36 unsigned HasFullFP16; + unsigned HasDotProd;

[PATCH] D45237: [RISCV] Fix logic to check if frame pointer should be used

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. Thanks, looks good to me. https://reviews.llvm.org/D45237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45284: [RISCV] More validations on the input value of -march=

asb added a comment. I've added a few comments on tweaking the error messages based on your tests. Comment at: test/Driver/riscv-arch.c:157 +// RV32-STR: error: invalid arch name 'rv32', +// RV32-STR: string must begin with rv32 or rv64 + But the given string

[PATCH] D44888: [RISCV] Default enable linker relaxation and add -mrelax, -mno-relax flags

asb added a comment. Looks good to me, just missing help text on the command line options. Repository: rL LLVM https://reviews.llvm.org/D44888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

alexfh added a comment. BTW, it looks like the http://clang.llvm.org/extra/clang-tidy/checks/objc-property-declaration.html check could also be replaced with readability-identifier-naming (not in this patch). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45392

[PATCH] D44970: [XRay][clang] Add flag to choose instrumentation bundles

pelikan accepted this revision. pelikan added a comment. This revision is now accepted and ready to land. Most of my comments are minor enough I'd be OK if this went in. But please consider them before committing. Comment at: clang/include/clang/Driver/XRayArgs.h:29

[PATCH] D45521: [clang-format] Improve ObjC guessing heuristic by supporting all @keywords

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Repository: rC Clang https://reviews.llvm.org/D45521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45498: [clang-format] Don't insert space between ObjC class and lightweight generic

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Comment at: lib/Format/TokenAnnotator.cpp:2357 + return false; +else + // Protocol list -> space if configured. @interface Foo : Bar

Re: [PATCH] D45526: [clang-format] Prefer breaking after ObjC category close paren

Fair point. I'll update the diff description. The net effect of the patch is to break after the closing paren; the way I implemented that was to raise the penalty for breaking after the opening paren. On Thu, Apr 12, 2018, 06:37 Daniel Jasper via Phabricator < revi...@reviews.llvm.org> wrote: >

[PATCH] D45578: Add a command line option 'fregister_dtor_with_atexit' to register destructor functions annotated with __attribute__((destructor)) using __cxa_atexit or atexit.

ahatanak created this revision. ahatanak added reviewers: arphaman, steven_wu, rjmccall. The command line option makes IRGen register destructor functions annotated with __attribute__((destructor)) calling __cxa_atexit in a synthesized constructor function instead of emitting references to the

[clang-tools-extra] r329927 - [Documentation] Order of changes in existing checks in Release Notes.

Author: eugenezelenko Date: Thu Apr 12 10:19:09 2018 New Revision: 329927 URL: http://llvm.org/viewvc/llvm-project?rev=329927=rev Log: [Documentation] Order of changes in existing checks in Release Notes. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified:

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle added a comment. In https://reviews.llvm.org/D44882#1065787, @hokein wrote: > @malaperle, what's your plan of this patch? Are you going to land it before > https://reviews.llvm.org/D45513? With the Line info in the index, this > patch could be simplified. I'll address the last

[PATCH] D45109: Remove -cc1 option "-backend-option"

mcrosier accepted this revision. mcrosier added a comment. SGTM! Repository: rC Clang https://reviews.llvm.org/D45109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45561: NFC - Indentation fixes in predefined-arch-macros.c

This revision was automatically updated to reflect the committed changes. Closed by commit rC329932: NFC - Indentation fixes in predefined-arch-macros.c (authored by GBuella, committed by ). Changed prior to commit: https://reviews.llvm.org/D45561?vs=142138=142223#toc Repository: rC Clang

[PATCH] D45311: [X86] Introduce wbinvd intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rL329937: [X86] Introduce wbinvd intrinsic (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45311?vs=142142=142228#toc

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

hokein added a comment. @malaperle, what's your plan of this patch? Are you going to land it before https://reviews.llvm.org/D45513? With the Line info in the index, this patch could be simplified. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44882

r329930 - Fix the try_acquire_capability attribute to behave like the other try-lock functions. Fixes PR32954.

Author: aaronballman Date: Thu Apr 12 10:53:21 2018 New Revision: 329930 URL: http://llvm.org/viewvc/llvm-project?rev=329930=rev Log: Fix the try_acquire_capability attribute to behave like the other try-lock functions. Fixes PR32954. Modified: cfe/trunk/lib/Analysis/ThreadSafety.cpp

Re: [clang-tools-extra] r329873 - [clang-tidy] [modernize-use-auto] Get only a length of token, not the token itself

On Thu, Apr 12, 2018 at 7:44 AM Zinovy Nis via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: zinovy.nis > Date: Wed Apr 11 22:41:24 2018 > New Revision: 329873 > > URL: http://llvm.org/viewvc/llvm-project?rev=329873=rev > Log: > [clang-tidy] [modernize-use-auto] Get only a length of

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CtorUninitializedMemberChecker.cpp:187 + + if (isCalledByConstructor(Context)) +return; xazax.hun wrote: > Szelethus wrote: > > whisperity wrote: > > > I think somewhere there should

[PATCH] D43578: -ftime-report switch support in Clang

avt77 updated this revision to Diff 142198. avt77 added a reviewer: davezarzycki. avt77 added a comment. Herald added a subscriber: mgorny. I removed the dependence on TimePassesIsEnabled (as @davezarzycki sugested) and fixed the issue with failed test (tnx to @russell.gallop). As result the

[PATCH] D44079: [ASTImporter] Allow testing of import sequences; fix import of typedefs for anonymous decls

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Overall looks good, some minor nits inline. If those can be resolved trivially, I am ok with committing this without another round of reviews. Comment at:

r329924 - Correctly diagnose when a conversion function is declared with a type qualifier in the declaration specifiers rather than in the conversion type id. Fixes PR30595.

Author: aaronballman Date: Thu Apr 12 09:41:55 2018 New Revision: 329924 URL: http://llvm.org/viewvc/llvm-project?rev=329924=rev Log: Correctly diagnose when a conversion function is declared with a type qualifier in the declaration specifiers rather than in the conversion type id. Fixes

[PATCH] D45383: Limit types of builtins that can be redeclared.

compnerd added a comment. I know that the Windows SDK definitely declares the `__va_start` function. Did you try building something like swift against the Windows SDK with this change? https://reviews.llvm.org/D45383 ___ cfe-commits mailing list

[PATCH] D45383: Limit types of builtins that can be redeclared.

erichkeane added a comment. In https://reviews.llvm.org/D45383#1065999, @compnerd wrote: > I know that the Windows SDK definitely declares the `__va_start` function. > Did you try building something like swift against the Windows SDK with this > change? Are we sure it declares it, and not

[PATCH] D43578: -ftime-report switch support in Clang

davezarzycki added a comment. It wasn't my suggestion. @thakis wrote: "We probably should have a separate bool in clang and key this off that and make -ftime-report set both." https://reviews.llvm.org/D43578 ___ cfe-commits mailing list

[PATCH] D45578: Add a command line option 'fregister_dtor_with_atexit' to register destructor functions annotated with __attribute__((destructor)) using __cxa_atexit or atexit.

ahatanak updated this revision to Diff 142218. ahatanak edited the summary of this revision. ahatanak added a comment. Fix an error in emitGlobalDtorWithCXAAtExit and make sure @dso_handle is hidden. Repository: rC Clang https://reviews.llvm.org/D45578 Files:

[PATCH] D44155: Fix support for try_acquire_capability

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this code is ready to go in -- accepting my own revision so that I can close. If @delesley spots any issues, they can be address post commit.

[PATCH] D44155: Fix support for try_acquire_capability

aaron.ballman closed this revision. aaron.ballman added a comment. Committed the fix in r329930. https://reviews.llvm.org/D44155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43578: -ftime-report switch support in Clang

avt77 added a comment. In https://reviews.llvm.org/D43578#1065827, @davezarzycki wrote: > It wasn't my suggestion. @thakis wrote: "We probably should have a separate > bool in clang and key this off that and make -ftime-report set both." Sorry, but it's done now. Any comments, suggestions,

r329921 - [Test Fix] Fix broken test Index/comment-objc-parameterized-classes.m

Author: benhamilton Date: Thu Apr 12 09:00:05 2018 New Revision: 329921 URL: http://llvm.org/viewvc/llvm-project?rev=329921=rev Log: [Test Fix] Fix broken test Index/comment-objc-parameterized-classes.m I broke this test in D45498 when I changed the formatter to remove spaces before Objective-C

[PATCH] D45561: NFC - Indentation fixes in predefined-arch-macros.c

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D45561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard added inline comments. Comment at: test/clang-tidy/readability-identifier-naming-objc.m:4 +// RUN: [{key: readability-identifier-naming.ObjcIvarPrefix, value: '_'}]}' \ +// RUN: -- + alexfh wrote: > The `--` and the trailing backslash above can be

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

a.sidorin updated this revision to Diff 142226. a.sidorin added a comment. Rewrite the GCCAsmStmt in the CFG. Repository: rC Clang https://reviews.llvm.org/D45416 Files: include/clang/Analysis/CFG.h lib/Analysis/CFG.cpp lib/StaticAnalyzer/Core/ExprEngine.cpp test/Analysis/asm.cpp

[PATCH] D45513: [clangd] Add line and column number to the index symbol.

hokein updated this revision to Diff 142195. hokein marked 3 inline comments as done. hokein added a comment. Update the patch, address remaining issues. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45513 Files: clangd/index/Index.cpp clangd/index/Index.h

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

aprantl added a comment. One question, but otherwise this looks fine. Comment at: lib/CodeGen/CGStmt.cpp:535 + + // Emit debug info for the label only if it's reachable. + if (HaveInsertPoint()) { Shouldn't it be added to the list of labels/variables of the

[PATCH] D45513: [clangd] Add line and column number to the index symbol.

hokein added inline comments. Comment at: clangd/index/Index.h:32 +// Character offset on a line in a document (zero-based). +int Character = 0; + }; sammccall wrote: > sammccall wrote: > > Column? > > > > LSP calls this "character" but this is

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CtorUninitializedMemberChecker.cpp:31 +/// every other element is a field, and the element that precedes it is the +/// object that contains it. +class FieldChainInfo { As far as I

r329923 - [Hexagon] Enable auto-vectorization only when -fvectorize was given

Author: kparzysz Date: Thu Apr 12 09:25:35 2018 New Revision: 329923 URL: http://llvm.org/viewvc/llvm-project?rev=329923=rev Log: [Hexagon] Enable auto-vectorization only when -fvectorize was given Added: cfe/trunk/test/Driver/hexagon-vectorize.c Modified:

[PATCH] D45504: [MinGW] Look for a cross sysroot relative to the clang binary

mstorsjo added a comment. Ping, any comments on the change itself, or tips on how to create a test for it? https://reviews.llvm.org/D45504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r329958 - [clangd][nfc] Simplify readDelimitedMessage()

Author: jkorous Date: Thu Apr 12 14:33:24 2018 New Revision: 329958 URL: http://llvm.org/viewvc/llvm-project?rev=329958=rev Log: [clangd][nfc] Simplify readDelimitedMessage() istream::eof() is always false after successful getline() Modified:

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF marked 4 inline comments as done. EricWF added inline comments. Comment at: include/clang/AST/ComparisonCategories.h:68 + /// \brief A map containing the comparison category values built from the + /// standard library. The key is a value of ComparisonCategoryValue. +

[PATCH] D34848: Driver: Don't mix system tools with devtoolset tools on RHEL

tstellar updated this revision to Diff 142294. tstellar added a comment. Replaced the if (Distro.isRedhat()) check with a string compare on the GCC installation lib. This narrows the scope of the fix and also makes it possible to write a test case. The code that detects distros ignores sysroot

r329941 - [RISCV] Fix logic to check if frame pointer should be used

Author: mgrang Date: Thu Apr 12 12:31:37 2018 New Revision: 329941 URL: http://llvm.org/viewvc/llvm-project?rev=329941=rev Log: [RISCV] Fix logic to check if frame pointer should be used Summary: The logic was broken for Linux triples as it returns true in the switch for Triple.isOSLinux().

[libcxxabi] r329950 - [demangler] NFC: Some refactoring to support partial demangling.

Author: epilk Date: Thu Apr 12 13:41:06 2018 New Revision: 329950 URL: http://llvm.org/viewvc/llvm-project?rev=329950=rev Log: [demangler] NFC: Some refactoring to support partial demangling. I'm committing this to libcxxabi too so that the two demanglers remain as simular as possible.

[PATCH] D45513: [clangd] Add line and column number to the index symbol.

MaskRay added a comment. Just my 2 cents. Calculation of line/character for each occurrence may not take a lot of computation. cquery/ccls computes the Comment at: clangd/index/Index.h:39 // using half-open range, [StartOffset, EndOffset). + // FIXME(hokein): remove

  1   2   >