[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. sorry, I thought I've already LGTM'd it in previous iteration. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108556/new/

[clang] db4ff98 - DebugInfo: Add support for template parameters with qualifiers

Author: David Blaikie Date: 2021-09-14T00:04:40-07:00 New Revision: db4ff98bf9733605c713e75ab6677523e6d267cb URL: https://github.com/llvm/llvm-project/commit/db4ff98bf9733605c713e75ab6677523e6d267cb DIFF: https://github.com/llvm/llvm-project/commit/db4ff98bf9733605c713e75ab6677523e6d267cb.diff

[clang] 9aeecdf - Check supported architectures in sseXYZ/avxXYZ headers

Author: serge-sans-paille Date: 2021-09-14T09:57:54+02:00 New Revision: 9aeecdfa8e9104392b435444a5f978d2eb71e51a URL: https://github.com/llvm/llvm-project/commit/9aeecdfa8e9104392b435444a5f978d2eb71e51a DIFF:

[PATCH] D109686: Check supported architectures in sseXYZ/avxXYZ headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9aeecdfa8e91: Check supported architectures in sseXYZ/avxXYZ headers (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

pdhaliwal added a comment. Even with declare variant separated using ifdef's, the error is still there. So I don't think we have workaround for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109344/new/ https://reviews.llvm.org/D109344

[clang] e4b9f5e - DebugInfo: Add support for template parameters with reference qualifiers

Author: David Blaikie Date: 2021-09-14T00:39:47-07:00 New Revision: e4b9f5e851d1fe0ba93cbb11b2ed4558602c379e URL: https://github.com/llvm/llvm-project/commit/e4b9f5e851d1fe0ba93cbb11b2ed4558602c379e DIFF: https://github.com/llvm/llvm-project/commit/e4b9f5e851d1fe0ba93cbb11b2ed4558602c379e.diff

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

mizvekov updated this revision to Diff 372434. mizvekov edited the summary of this revision. mizvekov added a comment. include repro for analyzer crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109654/new/ https://reviews.llvm.org/D109654

[PATCH] D109557: Adds an AlignCloseBracket option

MyDeveloperDay added a comment. This isn't really `AlignCloseBracket` but `BreakBeforeClosingParen` isn't it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 372430. MyDeveloperDay added a comment. Allow more QualifierFixer functions to be directly tested, remove some older commented code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files:

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

pengfei added a comment. Forgot to say thanks @craig.topper and @RKSimon for the information. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109658/new/ https://reviews.llvm.org/D109658 ___ cfe-commits

[PATCH] D109366: [OpenCL] Tests C++ for OpenCL version macros

This revision was automatically updated to reflect the committed changes. Closed by commit rGad88632b6503: [OpenCL] Tests C++ for OpenCL version macros (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109366/new/

[clang] ad88632 - [OpenCL] Tests C++ for OpenCL version macros

Author: Justas Janickas Date: 2021-09-14T09:49:20+01:00 New Revision: ad88632b650325af755ae42ff29114c1f6eb2841 URL: https://github.com/llvm/llvm-project/commit/ad88632b650325af755ae42ff29114c1f6eb2841 DIFF:

[PATCH] D108045: [clangd] Fix clangd crash when including a header

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks a lot, LGTM! Do you want me to land this for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108045/new/ https://reviews.llvm.org/D108045

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2101 +**CVQualifierAlignment** (``CVQualifierAlignmentStyle``) + Different ways to arrange const/volatile qualifiers.

[PATCH] D109658: [X86][FP16] Change the order of the operands in complex FMA intrinsics to allow swap between the mul operands.

pengfei added a comment. > Do we have any builtins with the same name as gcc but different > operands/behaviours? Those are the only ones that I'd be worried about. I think it's rare in existing intrinsics. 1) The builtins are always straightforward passed the arguments in intrinsics in the

[PATCH] D109752: [clang-format] Top-level unwrapped lines don't follow a left brace

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch makes characterizing top-level unwrapped

[PATCH] D105701: [clang-format] test revision (NOT FOR COMMIT) to demonstrate east/west const fixer capability

MyDeveloperDay updated this revision to Diff 372460. MyDeveloperDay added a comment. Herald added subscribers: dexonsmith, jdoerfert, sstefan1, mgrang, martong, aheejin, dschuff. Herald added a reviewer: shafik. Herald added a reviewer: jdoerfert. Further Demonstration of D69764: [clang-format]

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

Szelethus added a comment. I'll attend to this ASAP. Thanks for the heads up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108695/new/ https://reviews.llvm.org/D108695 ___ cfe-commits mailing list

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

uabelho added a comment. Hi @Szelethus A couple of tests fail for me on trunk with this patch: Failed Tests (3): Clang-Unit :: StaticAnalyzer/./StaticAnalysisTests/FalsePositiveRefutationBRVisitorTestBase.UnSatAtErrorNodeDueToRefinedConstraintNoReport Clang-Unit ::

RE: [clang] bdce8d4 - Revert "[X86] Adjust Keylocker handle mem size"

Sorry, I’ll keep in mind. This revert is just for “wrong patch ID in commit comment” it should be D109488 not D109354. Sorry for my mistake! Thank you so much! From: Craig Topper Sent: Tuesday, September 14, 2021 5:52 AM To: Zhang, Xiang1 ; Xiang1 Zhang Cc: cfe-commits Subject: Re: [clang]

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

sherwin-dc added a comment. @tejohnson would you be able to take another look at this again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 ___ cfe-commits

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

steakhal added a comment. In D108695#2999378 , @uabelho wrote: > Hi @Szelethus > A couple of tests fail for me on trunk with this patch Uh, that's my unittest :D I suspect you are running some sort of CI where you set up Z3. I suspect we should

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

uabelho added a comment. In D108695#2999432 , @steakhal wrote: > In D108695#2999378 , @uabelho wrote: > >> Hi @Szelethus >> A couple of tests fail for me on trunk with this patch > > Uh, that's my unittest :D >

[clang] 09dc454 - [OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021

Author: Justas Janickas Date: 2021-09-14T13:05:42+01:00 New Revision: 09dc454b00b8ed0a19f766f760fa19e86a0b9059 URL: https://github.com/llvm/llvm-project/commit/09dc454b00b8ed0a19f766f760fa19e86a0b9059 DIFF:

[PATCH] D109370: [OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021

This revision was automatically updated to reflect the committed changes. Closed by commit rG09dc454b00b8: [OpenCL] Enables .rgba vector extension in C++ for OpenCL 2021 (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109721: [IR] Reduce max supported integer from 2^24-1 to 2^23.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109721/new/ https://reviews.llvm.org/D109721 ___ cfe-commits mailing list

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. yeluo@epyc-server:~/opt/openmp-target/tests/math$ clang++ -fopenmp -fopenmp-targets=nvptx64 -Xopenmp-target=nvptx64 -march=sm_80 modf.cpp -c yeluo@epyc-server:~/opt/openmp-target/tests/math$ clang-offload-bundler -type=o --inputs=modf.o --list openmp-nvptx64

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

vhscampos added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:413 - auto V8_6Pos = llvm::find(Features, "+v8.6a"); - if (V8_6Pos != std::end(Features)) -V8_6Pos = Features.insert(std::next(V8_6Pos), {"+i8mm", "+bf16"}); + const char *Archs[]

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

qiucf created this revision. qiucf added reviewers: PowerPC, hubert.reinterpretcast, nemanjai, jsji. Herald added a subscriber: shchenz. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam added a comment. In D105191#2998372 , @ye-luo wrote: > the modf test still doesn't work. The issue was from unbundle. > case 1 works. > > clang++ -fopenmp -fopenmp-targets=nvptx64 modf.cpp -c > clang++ -fopenmp -fopenmp-targets=nvptx64

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

aaron.ballman added a comment. LGTM modulo the testing request (I forgot to mention that when marking it yesterday, oops!). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org/D108893

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

vhscampos updated this revision to Diff 372473. vhscampos marked 3 inline comments as done. vhscampos added a comment. 1. Enable the SVE2 extension as default. 2. Remove out of date comments in tests. 3. Remove unrelated change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 601102d - Cleanup identifier parsing; NFC

Author: Corentin Jabot Date: 2021-09-14T09:12:22-04:00 New Revision: 601102d282d5e9a1429fea52ee17303aec8a7c10 URL: https://github.com/llvm/llvm-project/commit/601102d282d5e9a1429fea52ee17303aec8a7c10 DIFF:

[PATCH] D108308: Cleanup identifier parsing.

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the cleanup! I've landed in 601102d282d5e9a1429fea52ee17303aec8a7c10 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2d6829b - [clang] disable implicit moves when not in CPlusPLus

Author: Matheus Izvekov Date: 2021-09-14T11:29:47+02:00 New Revision: 2d6829bbbe6877920d9be1db93b9f3fc85b43d10 URL: https://github.com/llvm/llvm-project/commit/2d6829bbbe6877920d9be1db93b9f3fc85b43d10 DIFF:

[PATCH] D109654: [clang] disable implicit moves when not in CPlusPLus

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d6829bbbe68: [clang] disable implicit moves when not in CPlusPLus (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109654/new/

[PATCH] D109608: [clang][ASTImporter] Generic attribute import handling (first step).

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:656-671 +// Helper for chaining together multiple imports. If an error is detected, +// subsequent imports will return default constructed nodes, so that failure +// can be detected with a

[PATCH] D108560: [clang-tidy] Add support for NOLINTBEGIN ... NOLINTEND comments to suppress clang-tidy warnings over multiple lines

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend.cpp:6 + +// NOLINTEND +class B1 { B1(int i); }; salman-javed-nz wrote: > aaron.ballman wrote: > > Do you think this should be diagnosed as a sign of

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

arichardson added a comment. Merging this change broke our out-of-tree CHERI targets (and Arm Morello). We use addrspace(200) for *all* globals (including vtables). It would have been nice if I had been added to this review considering that I added line you are changing here. If vtables are

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

Eugene.Zelenko added a comment. What about adding `modernize`/`bugprone` aliases? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org/D108893 ___ cfe-commits mailing list

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

uweigand added a comment. Looking at the common code parts, it seems the behavior of MM_GOFF is actually identical to MM_ELF. Is this correct? If so, do we really need a different format type here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

aaron.ballman added a comment. In D108893#2999763 , @compnerd wrote: > @Eugene.Zelenko - sorry, I didn't see the additional comments before the > commit. I'm happy to do a follow up depending on the resolution. If there's a follow-up to add this to

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

erichkeane added a comment. > ! In D108643#2965852 , @rjmccall > wrote: > > The choice that high bits are unspecified rather than extended is an > interesting one. Can you speak to that? That's good for +, -, *, &, |, ^, > <<, and narrowing

[PATCH] D109770: [OpenMP] Declare variants for templates need to match # template args

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Ah, nice! Thanks for the fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109770/new/ https://reviews.llvm.org/D109770

[PATCH] D109770: [OpenMP] Declare variants for templates need to match # template args

jdoerfert created this revision. jdoerfert added reviewers: pdhaliwal, JonChesterfield. Herald added subscribers: guansong, bollu, yaxunl. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. A declare variant template is

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

tejohnson added inline comments. Comment at: clang/test/CodeGen/pgo-sample-thinlto-summary.c:1 -// RUN: %clang_cc1 -O2 -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -o - 2>&1 | FileCheck %s -check-prefix=SAMPLEPGO -// RUN: %clang_cc1 -O2

[PATCH] D109772: [clangd] Print current request context along with the stack trace

0x1eaf created this revision. 0x1eaf added reviewers: sammccall, ilya-biryukov, nridge. 0x1eaf added projects: clang, clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar, mgorny. 0x1eaf requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109362/new/ https://reviews.llvm.org/D109362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] fb4d590 - Fix a unittest file after D108695 when Z3 is enabled

Author: Kristóf Umann Date: 2021-09-14T16:11:11+02:00 New Revision: fb4d590a622f4031900516360c07ee6ace01c5e6 URL: https://github.com/llvm/llvm-project/commit/fb4d590a622f4031900516360c07ee6ace01c5e6 DIFF: https://github.com/llvm/llvm-project/commit/fb4d590a622f4031900516360c07ee6ace01c5e6.diff

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

Eugene.Zelenko added a comment. > So you'd like to see that extra functionality added now? (I don't think it > makes sense to have the check as-is in both `readability` and `modernize`.) There are plenty of other cross-module aliases

[PATCH] D109718: [HIP] Diagnose -fopenmp-targets for HIP programs

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:704 +C.getInputArgs().getLastArg(options::OPT_fopenmp_targets_EQ)) { + Diag(clang::diag::err_drv_unsupported_opt) << OMPTargetArg->getSpelling(); + return; tra wrote: >

[PATCH] D109718: [HIP] Diagnose -fopenmp-targets for HIP programs

yaxunl updated this revision to Diff 372495. yaxunl added a comment. revise diag message CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109718/new/ https://reviews.llvm.org/D109718 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/Driver.cpp

[PATCH] D109344: [AMDGPU][OpenMP] Use complex definitions from complex_cmath.h

jdoerfert added a comment. I'm fixing this, nothing to do with this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109344/new/ https://reviews.llvm.org/D109344 ___ cfe-commits mailing list

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

thakis added a comment. Reverted in 76dc8ac36d07 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org/D108893

[clang-tools-extra] 76dc8ac - Revert "clang-tidy: introduce readability-containter-data-pointer check"

Author: Nico Weber Date: 2021-09-14T12:37:10-04:00 New Revision: 76dc8ac36d07cebe8cfe8fe757323562bb36df94 URL: https://github.com/llvm/llvm-project/commit/76dc8ac36d07cebe8cfe8fe757323562bb36df94 DIFF: https://github.com/llvm/llvm-project/commit/76dc8ac36d07cebe8cfe8fe757323562bb36df94.diff

Re: [clang] 2bd8493 - Improve type printing of const arrays to normalize array-of-const and const-array

On Mon, 13 Sept 2021 at 19:24, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: David Blaikie > Date: 2021-09-13T19:17:05-07:00 > New Revision: 2bd84938470bf2e337801faafb8a67710f46429d > > URL: >

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

quinnp updated this revision to Diff 372479. quinnp added a comment. Fixing failing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109710/new/ https://reviews.llvm.org/D109710 Files: clang/lib/Headers/altivec.h

[clang] 2fd180b - [IR] Reduce max supported integer from 2^24-1 to 2^23.

Author: Craig Topper Date: 2021-09-14T07:52:10-07:00 New Revision: 2fd180bbb9a7bb8604a5aca31f1ca9dc5358a433 URL: https://github.com/llvm/llvm-project/commit/2fd180bbb9a7bb8604a5aca31f1ca9dc5358a433 DIFF: https://github.com/llvm/llvm-project/commit/2fd180bbb9a7bb8604a5aca31f1ca9dc5358a433.diff

[PATCH] D109721: [IR] Reduce max supported integer from 2^24-1 to 2^23.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fd180bbb9a7: [IR] Reduce max supported integer from 2^24-1 to

[clang-tools-extra] d0d9e6f - clang-tidy: introduce readability-containter-data-pointer check

Author: Saleem Abdulrasool Date: 2021-09-14T08:12:10-07:00 New Revision: d0d9e6f0849b2e76e980e2edf365302f47f4e35f URL: https://github.com/llvm/llvm-project/commit/d0d9e6f0849b2e76e980e2edf365302f47f4e35f DIFF:

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

This revision was automatically updated to reflect the committed changes. compnerd marked an inline comment as done. Closed by commit rGd0d9e6f0849b: clang-tidy: introduce readability-containter-data-pointer check (authored by compnerd). Changed prior to commit:

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

yaxunl added a comment. I am concerned that there may be more places which need handling, and passing exec config expr by function arguments may not scale. Is it possible to represent the kernel call expr by a derived class of call expr and add the exec config expr as member to it?

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

aaron.ballman added a comment. In D108893#2999645 , @Eugene.Zelenko wrote: > What about adding `modernize`/`bugprone` aliases? I'd be fine if we wanted to add aliases, but I'd sort of expect some extra functionality out of a check in those modules. I

[clang-tools-extra] 8401713 - [clangd] Ignore ObjC `id` and `instancetype` in FindTarget

Author: David Goldman Date: 2021-09-14T09:53:42-04:00 New Revision: 8401713b3ef1456a603874d96a99b2d5953df49c URL: https://github.com/llvm/llvm-project/commit/8401713b3ef1456a603874d96a99b2d5953df49c DIFF: https://github.com/llvm/llvm-project/commit/8401713b3ef1456a603874d96a99b2d5953df49c.diff

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

This revision was automatically updated to reflect the committed changes. Closed by commit rG8401713b3ef1: [clangd] Ignore ObjC `id` and `instancetype` in FindTarget (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108556/new/

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

yaxunl added a comment. In D103835#2999545 , @arichardson wrote: > Merging this change broke our out-of-tree CHERI targets (and Arm Morello). We > use addrspace(200) for *all* globals (including vtables). It would have been > nice if I had been added

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

aaron.ballman added a comment. In D108893#2999681 , @Eugene.Zelenko wrote: > In D108893#2999654 , @aaron.ballman > wrote: > >> In D108893#2999645 , >> @Eugene.Zelenko

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman added a comment. In D108643#2991995 , @hjl.tools wrote: >>> The choice that high bits are unspecified rather than extended is an >>> interesting one. Can you speak to that? That's good for +, -, *, &, |, ^, >>> <<, and narrowing

[PATCH] D103835: [CUDA][HIP] Fix store of vtbl in ctor

arichardson added a comment. In D103835#2999731 , @yaxunl wrote: > In D103835#2999545 , @arichardson > wrote: > >> Merging this change broke our out-of-tree CHERI targets (and Arm Morello). >> We use

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

compnerd added a comment. @Eugene.Zelenko - sorry, I didn't see the additional comments before the commit. I'm happy to do a follow up depending on the resolution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/

[PATCH] D109718: [HIP] Diagnose -fopenmp-targets for HIP programs

tra added inline comments. Comment at: clang/lib/Driver/Driver.cpp:704 +C.getInputArgs().getLastArg(options::OPT_fopenmp_targets_EQ)) { + Diag(clang::diag::err_drv_unsupported_opt) << OMPTargetArg->getSpelling(); + return; yaxunl wrote: >

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

thakis added a comment. This breaks tests: http://45.33.8.238/linux/55784/step_8.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108893/new/ https://reviews.llvm.org/D108893

[PATCH] D109128: [VFS] Use original path when falling back to external FS

dexonsmith added a comment. (BTW, does this problem affect OverlayFileSystem as well?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109128/new/ https://reviews.llvm.org/D109128 ___ cfe-commits mailing

[PATCH] D106550: [PowerPC] Allow MMA built-ins to accept restrict qualified pointers

saghir updated this revision to Diff 372505. saghir added a comment. update test case name to be consistent with existing ones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106550/new/ https://reviews.llvm.org/D106550 Files:

[PATCH] D108787: [CUDA] Pass ExecConfig through BuildCallToMemberFunction

tra added a comment. In D108787#243 , @yaxunl wrote: > I am concerned that there may be more places which need handling, and passing > exec config expr by function arguments may not scale. > Is it possible to represent the kernel call expr by a

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

Szelethus added a comment. rGfb4d590a622f4031900516360c07ee6ace01c5e6 should sort this out! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108695/new/

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

Eugene.Zelenko added a comment. In D108893#2999654 , @aaron.ballman wrote: > In D108893#2999645 , > @Eugene.Zelenko wrote: > >> What about adding `modernize`/`bugprone` aliases? > > I'd be fine if we wanted to

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

aaron.ballman added a comment. In D108893#2999698 , @Eugene.Zelenko wrote: >> So you'd like to see that extra functionality added now? (I don't think it >> makes sense to have the check as-is in both `readability` and `modernize`.) > > There are plenty

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

hjl.tools added a comment. In D108643#2999724 , @aaron.ballman wrote: > In D108643#2991995 , @hjl.tools > wrote: > The choice that high bits are unspecified rather than extended is an interesting

[PATCH] D108045: [clangd] Fix clangd crash when including a header

qdelacru added a comment. Yes please land this. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108045/new/ https://reviews.llvm.org/D108045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109128: [VFS] Use original path when falling back to external FS

dexonsmith added a comment. In D109128#2997588 , @JDevlieghere wrote: > Keith and I discussed this offline. My suggestion was to do the following: > > 1. Check the overlay for the canonicalized path > 2. Check the fall-through for the canonicalized

[PATCH] D109632: [clang] de-duplicate methods from AST files

manmanren added a comment. @dexonsmith @bruno: are you okay with this change? It looks good to me :] Thanks, Manman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109632/new/ https://reviews.llvm.org/D109632

[clang] 13e34f9 - Fixup some formatting from a recent commit

Author: David Blaikie Date: 2021-09-14T00:41:19-07:00 New Revision: 13e34f9fc13fbe08af69b206eacac2e0008dd126 URL: https://github.com/llvm/llvm-project/commit/13e34f9fc13fbe08af69b206eacac2e0008dd126 DIFF: https://github.com/llvm/llvm-project/commit/13e34f9fc13fbe08af69b206eacac2e0008dd126.diff

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

labrinea added a comment. @ostannard, can you explain what you meant with supporting LTO? I didn't quite undestand. Are you happy with the rest of the changes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109157/new/ https://reviews.llvm.org/D109157

[PATCH] D109506: [RFC] Print current request context along with the stack trance in clangd

0x1eaf updated this revision to Diff 372510. 0x1eaf added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109506/new/ https://reviews.llvm.org/D109506 Files: clang-tools-extra/clangd/JSONTransport.cpp

[PATCH] D109506: [clangd] Print current request context along with the stack trace

0x1eaf updated this revision to Diff 372515. 0x1eaf retitled this revision from "[RFC] Print current request context along with the stack trance in clangd" to "[clangd] Print current request context along with the stack trace". 0x1eaf edited the summary of this revision. 0x1eaf added a comment.

[clang] 66c6bbe - Put code that avoids heapifying local blocks behind a flag

Author: Walter Lee Date: 2021-09-14T14:06:05-04:00 New Revision: 66c6bbe7ff56441706d6cbb349fde9a02e248c9a URL: https://github.com/llvm/llvm-project/commit/66c6bbe7ff56441706d6cbb349fde9a02e248c9a DIFF: https://github.com/llvm/llvm-project/commit/66c6bbe7ff56441706d6cbb349fde9a02e248c9a.diff

[PATCH] D108243: Put code that avoids heapifying local blocks behind a flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66c6bbe7ff56: Put code that avoids heapifying local blocks behind a flag (authored by waltl). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

sfertile added a comment. I suggest we separate the clang change and testing into a standalone patch, and the llvm backend tests into a standalone patch which we can commit separately. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4646 + if (const ComplexType *CTy =

[PATCH] D108893: clang-tidy: introduce readability-containter-data-pointer check

MaskRay added a comment. 49992c04148e5327bef9bd2dff53a0d46004b4b4 relanded the change. It is useful to attach the original `Differential Revision: ` so that it is connected to this Differential. Repository: rG LLVM

[PATCH] D109635: [WIP][OpenMP] Support construct trait set for Clang

cchen updated this revision to Diff 372531. cchen added a comment. Remove braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109635/new/ https://reviews.llvm.org/D109635 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 updated this revision to Diff 372528. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. - set `GlobalOpt` parameter to false by default to disallow alias elimination when the options EarlyInlineAll and EnableFunctionCalls are true and false, respectively.

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

gandhi21299 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5069 // where aliases aren't supported. - if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX() && !RawTriple.isAMDGPU()) CmdArgs.push_back("-mconstructor-aliases");

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added inline comments. Comment at: clang/lib/Basic/Sarif.cpp:1 +#include "clang/Basic/Sarif.h" +#include "clang/Basic/LangOptions.h" lattner wrote: > THis nees the standard header boilerplate per the coding standards doc Ack, didn't grok the "all

[PATCH] D109128: [VFS] Use original path when falling back to external FS

vsapsai added a comment. In D109128#2999846 , @dexonsmith wrote: > In D109128#2997588 , @JDevlieghere > wrote: > >> Keith and I discussed this offline. My suggestion was to do the following: >> >> 1. Check the

[PATCH] D109128: [VFS] Use original path when falling back to external FS

dexonsmith added a comment. In D109128#3000374 , @vsapsai wrote: > In D109128#2999846 , @dexonsmith > wrote: > >> In D109128#2997588 , @JDevlieghere >> wrote: >> >>>

[PATCH] D106876: Remove non-affecting module maps from PCM files.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Please apply the lint suggestions; otherwise, looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA added inline comments. Comment at: clang/test/CodeGen/aix32-complex-varargs.c:2 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -emit-llvm -o - %s | FileCheck %s + sfertile wrote: > The code-gen for int and

[PATCH] D106876: Remove non-affecting module maps from PCM files.

ilyakuteev updated this revision to Diff 372563. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106876/new/ https://reviews.llvm.org/D106876 Files: clang/include/clang/Serialization/ASTWriter.h clang/lib/Serialization/ASTWriter.cpp

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty updated this revision to Diff 372566. daltenty added a comment. - Update check patttern to allow windows directory seperators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078 Files:

  1   2   >