[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

Michael137 added a comment. In D123319#3680169 , @aprantl wrote: > Sorry for the silence — I was out on vacation. > > @Michael137 has recently started looking into improving support for C++ > lambdas in LLDB. > Michael, would you be interested in taking

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

Michael137 added a comment. In D123319#3682929 , @dblaikie wrote: > In D123319#3681884 , @Michael137 > wrote: > >> In D123319#3680169 , @aprantl >> wrote: >> >>> Sorry

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

Michael137 added a comment. In D128830#3746153 , @aprantl wrote: > I think we can "fix" the test with the following patch: > > diff --git a/lldb/test/API/functionalities/unused-inlined-parameters/main.c >

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

Michael137 added a comment. Noted, thanks for the heads up AFAIK, the only test that'd now fail on the debug-info side is: https://reviews.llvm.org/D132664 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128830/new/

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

Michael137 added subscribers: aprantl, dblaikie. Michael137 added a comment. In D128830#3745069 , @psamolysov wrote: > @Michael137 Thank you very much for the information! > > I'm not sure, but it looks like the introduced change of the `readnone` >

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

Michael137 added a comment. FYI, this broke the LLDB build bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46324/execution/node/74/log/ Looks like we're testing that unused parameters optimise out but that's not the case anymore `AssertionError: '(void *) unused1 = ' not found

[PATCH] D133945: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into decl chain when regular lookup fails

This revision was automatically updated to reflect the committed changes. Closed by commit rGe456d2ba8bca: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133945: [clang][ASTImporter] Continue with slow lookup in DeclContext::localUncachedLookup when regular lookup fails

Michael137 created this revision. Michael137 added reviewers: aprantl, martong. Herald added a subscriber: rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLDB.

[PATCH] D133945: [clang][ASTImporter] Continue with slow lookup in DeclContext::localUncachedLookup when regular lookup fails

Michael137 added inline comments. Herald added a subscriber: JDevlieghere. Comment at: clang/lib/AST/DeclBase.cpp:1781 if (Name && !hasLazyLocalLexicalLookups() && !hasLazyExternalLexicalLookups()) { if (StoredDeclsMap *Map = LookupPtr) { Could

[PATCH] D133945: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into decl chain when regular lookup fails

Michael137 updated this revision to Diff 460429. Michael137 added a comment. - Undo incorrect previous change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133945/new/ https://reviews.llvm.org/D133945 Files: clang/lib/AST/DeclBase.cpp

[PATCH] D133945: [clang][ASTImporter] Continue with slow lookup in DeclContext::localUncachedLookup when regular lookup fails

Michael137 updated this revision to Diff 460420. Michael137 added a comment. - Merge if-blocks - Reword commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133945/new/ https://reviews.llvm.org/D133945 Files: clang/lib/AST/DeclBase.cpp

[PATCH] D133945: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into decl chain when regular lookup fails

Michael137 added inline comments. Comment at: clang/lib/AST/DeclBase.cpp:1781 if (Name && !hasLazyLocalLexicalLookups() && !hasLazyExternalLexicalLookups()) { if (StoredDeclsMap *Map = LookupPtr) { Michael137 wrote: > Could merge the two if-blocks

[PATCH] D133945: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into decl chain when regular lookup fails

Michael137 updated this revision to Diff 460718. Michael137 added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133945/new/ https://reviews.llvm.org/D133945 Files: clang/lib/AST/DeclBase.cpp

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

Michael137 added a comment. FYI, had an offline chat with @dblaikie and we decided that the best way forward would be to try stop emitting auto return types in DWARF, instead of relying on lambda/member-function specific hacks. Not sure what the timeline on this will be but tracking it

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 added a comment. Michael137 updated this revision to Diff 484341. Michael137 added a reviewer: labath. Michael137 edited the summary of this revision. Michael137 added a

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

Michael137 added a comment. In D127284#3969458 , @v.g.vassilev wrote: > In D127284#3969446 , @v.g.vassilev > wrote: > >>> UPDATE: fails with clean build too >>> >>> Might be best to revert it for now while we

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

Michael137 added a comment. In D127284#3969975 , @v.g.vassilev wrote: > In D127284#3969593 , @Michael137 > wrote: > >> In D127284#3969458 , @v.g.vassilev >> wrote: >>

[PATCH] D139988: [clang][DebugInfo] Simplify logic to determine DW_AT_default_value for template parameters

Michael137 updated this revision to Diff 483348. Michael137 added a comment. - Remove now redundant header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139988/new/ https://reviews.llvm.org/D139988 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Michael137 marked an inline comment as done. Michael137 added inline comments. Comment at: clang/test/CodeGenObjCXX/encode.mm:93-94 // FIXME: This difference is due to D76801. It was probably an unintentional change. Maybe we want to undo it? - // CHECKCXX98:

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Michael137 updated this revision to Diff 483476. Michael137 marked an inline comment as done. Michael137 added a comment. - Add comment re. ABI break Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139986/new/ https://reviews.llvm.org/D139986

[PATCH] D139989: [clang][DebugInfo] Add DW_AT_default_value support for template template parameters

Michael137 updated this revision to Diff 483477. Michael137 added a comment. - Split out LLVM changes into separate commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139989/new/ https://reviews.llvm.org/D139989 Files:

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Michael137 updated this revision to Diff 483478. Michael137 added a comment. - Fix commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139986/new/ https://reviews.llvm.org/D139986 Files: clang/lib/AST/TypePrinter.cpp

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1706f34d604e: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types (authored by Michael137). Repository: rG LLVM Github

[PATCH] D139988: [clang][DebugInfo] Simplify logic to determine DW_AT_default_value for template parameters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d3843badb8a: [clang][DebugInfo] Simplify logic to determine DW_AT_default_value for template… (authored by Michael137). Repository: rG LLVM

[PATCH] D139989: [clang][DebugInfo] Add DW_AT_default_value support for template template parameters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2dff41c320fc: [llvm][DebugInfo] Add IsDefault parameter to DIBuilder… (authored by Michael137). Changed prior to commit:

[PATCH] D139988: [clang][DebugInfo] Re-use clang::TemplateUtils to determine guide DW_AT_default_value for template parameters

Michael137 updated this revision to Diff 483344. Michael137 added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139988/new/ https://reviews.llvm.org/D139988 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D139989: [clang][DebugInfo] Add DW_AT_default_value support for template template parameters

Michael137 updated this revision to Diff 483346. Michael137 added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139989/new/ https://reviews.llvm.org/D139989 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D139988: [clang][DebugInfo] Re-use clang::TemplateUtils to determine guide DW_AT_default_value for template parameters

Michael137 added a comment. In D139988#3999115 , @dblaikie wrote: > Looks good to me, thanks! > > Patch description might need a tweak, this bit: > >> Type template parameters where the type is itself a template instantiation >> (e.g., `template>`) > >

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Michael137 updated this revision to Diff 483343. Michael137 added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139986/new/ https://reviews.llvm.org/D139986 Files: clang/lib/AST/TypePrinter.cpp

[PATCH] D139985: [clang][AST][NFC] Move isSubstitutedDefaultArgument out of TypePrinter into separate component

Michael137 updated this revision to Diff 483342. Michael137 added a comment. - Don't create separate component. Instead move API into Type.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139985/new/ https://reviews.llvm.org/D139985 Files:

[PATCH] D139985: [clang][AST][NFC] Move isSubstitutedDefaultArgument out of TypePrinter into separate component

Michael137 added a comment. committed in `98afcbab66505661045dccb85ee9acdbf9410047` Missed phab link in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139985/new/ https://reviews.llvm.org/D139985

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Michael137 added a comment. Missed couple of test cases in libcxx About to fix those Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139986/new/ https://reviews.llvm.org/D139986 ___ cfe-commits mailing

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:7 // RUN: %clang_cc1 -emit-llvm %std_cxx17- -dwarf-version=4 -triple x86_64 %s -O0 -disable-llvm-passes -debug-info-kind=standalone -o - | FileCheck %s

[PATCH] D139986: [WIP][clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 updated this revision to Diff 483168. Michael137 added a comment. Michael137 updated this revision to Diff 483184. Michael137 published this revision for review. Michael137 added a

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Michael137 added inline comments. Comment at: clang/test/CodeGenObjCXX/encode.mm:93-94 // FIXME: This difference is due to D76801. It was probably an unintentional change. Maybe we want to undo it? - // CHECKCXX98: @_ZN11rdar93574002ggE ={{.*}} constant [49 x i8] c"{vector

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a subscriber: hiraditya. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. **Summary**

[PATCH] D139928: [clang][DebugInfo] Backport emitting DW_AT_default_value for default template arguments

Michael137 updated this revision to Diff 482533. Michael137 added a comment. - Split clang and llvm changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139928/new/ https://reviews.llvm.org/D139928 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D139928: [clang][DebugInfo] Backport emitting DW_AT_default_value for default template arguments

Michael137 added a comment. In D139928#3992233 , @dblaikie wrote: > (This should be committed in two parts - the LLVM part first, then the Clang > part - since they can be separated, they should be - but happy to review it > altogether) Split the

[PATCH] D139928: [clang][DebugInfo] Backport emitting DW_AT_default_value for default template arguments

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a subscriber: hiraditya. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. With this

[PATCH] D139928: [clang][DebugInfo] Backport emitting DW_AT_default_value for default template arguments

Michael137 updated this revision to Diff 482419. Michael137 added a comment. - Fix test formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139928/new/ https://reviews.llvm.org/D139928 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9861e5718f6: [llvm][DebugInfo] Backport DW_AT_default_value for template args (authored by Michael137). Repository: rG LLVM Github Monorepo

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 added a comment. Ack, looking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139953/new/ https://reviews.llvm.org/D139953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 updated this revision to Diff 482995. Michael137 added a comment. - Fix label name - Add check for end of block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139953/new/ https://reviews.llvm.org/D139953 Files:

[PATCH] D140084: [llvm][test] Split DW_AT_default_value check out of clang/test/ Followup to D139953 to fix build failure on machines not configured for x86.

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie, chapuni. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:7 // RUN: %clang_cc1 -emit-llvm %std_cxx17- -dwarf-version=4 -triple x86_64 %s -O0 -disable-llvm-passes -debug-info-kind=standalone -o - | FileCheck %s

[PATCH] D140084: [llvm][test] Split DW_AT_default_value check out of clang/test/

Michael137 updated this revision to Diff 483065. Michael137 retitled this revision from "[llvm][test] Split DW_AT_default_value check out of clang/test/ Followup to D139953 to fix build failure on machines not configured for x86." to "[llvm][test] Split DW_AT_default_value check out of

[PATCH] D140084: [llvm][test] Split DW_AT_default_value check out of clang/test/

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG738bfbce09e7: [llvm][test] Split DW_AT_default_value check out of

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:37 +// STRICT-NOT: DW_AT_default_value (true) +// DWARF-DUMP: DW_TAG_template_value_parameter +// DWARF-DUMP-NEXT:DW_AT_type({{.*}} "bool")

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-template-parameter.cpp:37 +// STRICT-NOT: DW_AT_default_value (true) +// DWARF-DUMP: DW_TAG_template_value_parameter +// DWARF-DUMP-NEXT:DW_AT_type({{.*}} "bool")

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

Michael137 updated this revision to Diff 482664. Michael137 added a comment. - Use `CHECK-DAG` for attributes - Also compile with non-strict DWARFv4 - Widen the `STRICT-NOT` checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139953/new/

[PATCH] D139985: [clang][AST][NFC] Move isSubstitutedDefaultArgument out of TypePrinter into separate component

Michael137 added inline comments. Comment at: clang/include/clang/AST/TemplateUtils.h:19 +namespace clang { +namespace TemplateUtils { +/// Make a best-effort determination of whether the type T can be produced by dblaikie wrote: > aprantl wrote: > > It looks

[PATCH] D139989: [clang][DebugInfo] Add DW_AT_default_value support for template template parameters

Michael137 added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2095-2097 +NamedDecl const *ND = Args.TList->getParam(i); +defaultParameter = TemplateUtils::isSubstitutedDefaultArgument( +CGM.getContext(), TA, ND, Args.Args,

[PATCH] D139988: [clang][DebugInfo] Re-use clang::TemplateUtils to determine guide DW_AT_default_value for template parameters

Michael137 updated this revision to Diff 483155. Michael137 added a comment. - Hoist common code out of switch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139988/new/ https://reviews.llvm.org/D139988 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D139989: [clang][DebugInfo] Add DW_AT_default_value support for template template parameters

Michael137 updated this revision to Diff 483156. Michael137 added a comment. - Remove now redundant `isSubstitutedDefaultArgument` call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139989/new/ https://reviews.llvm.org/D139989 Files:

[PATCH] D139989: [clang][DebugInfo] Add DW_AT_default_value support for template template parameters

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a subscriber: hiraditya. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. After this

[PATCH] D139985: [clang][AST][NFC] Move isSubstitutedDefaultArgument out of TypePrinter into separate component

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A use-case has come up in DWARF CodeGen where we want to determine whether a

[PATCH] D139988: [clang][DebugInfo] Re-use clang::TemplateUtils to determine guide DW_AT_default_value for template parameters

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. DWARFv5 added support for labelling template parameters with

[PATCH] D140084: [llvm][test] Split DW_AT_default_value check out of clang/test/

Michael137 added a comment. In D140084#3997123 , @dblaikie wrote: > Sorry, should've caught this in review. The clang change needs test coverage > in clang, but should verify the emitted it, rather than going all the way > down to object code. > > The

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

Michael137 added a comment. FYI, looks like this broke the LLDB incremental buildbot. Following tests started failing: lldb-api.commands/expression/argument_passing_restrictions.TestArgumentPassingRestrictions.py

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

Michael137 added a comment. In D127284#3969308 , @v.g.vassilev wrote: > In D127284#3969249 , @v.g.vassilev > wrote: > >> In D127284#3969225 , @Michael137 >> wrote: >>

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 created this revision. Michael137 added reviewers: erichkeane, aaron.ballman, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. **Summary** This patch adds a `IsDefaulted` field

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

Michael137 added a comment. In D140423#4052442 , @aaron.ballman wrote: > In D140423#4052271 , @dblaikie > wrote: > >> In D140423#4051262 , >> @aaron.ballman wrote: >>

[PATCH] D141827: [WIP][clang][TypePrinter] Test TemplateArgument::IsDefaulted when omitting default arguments

Michael137 created this revision. Michael137 added reviewers: erichkeane, aaron.ballman, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. **Summary** This patch allows clients who can't

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

Michael137 updated this revision to Diff 491015. Michael137 added a comment. - Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142268/new/ https://reviews.llvm.org/D142268 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

Michael137 created this revision. Michael137 added reviewers: dblaikie, aprantl. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. **Summary** This patch

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

Michael137 added a comment. @dblaikie suggested that the best way to go about the recurring "how do we print template names" question is to turn on `-gsimple-template-names` on by default. For alias templates this means we would have to attach template parameters to their DIEs too.

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 added a comment. In D141826#4059088 , @erichkeane wrote: > In D141826#4059073 , @Michael137 > wrote: > >> In D141826#4058866 , @erichkeane >> wrote: >> >>>

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 491265. Michael137 added a comment. - Rename test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files: clang/include/clang/AST/PropertiesBase.td

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

Michael137 added a comment. In D142268#4072358 , @dblaikie wrote: > So @Michael137 and I talked about this offline, and a few extra details: > > - Generally it's important that types have identical names. Templates try to > do this, but get it wrong in

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 491251. Michael137 added a comment. - `setIsDefaulted` when constructing `ClassTemplateSpecializationDecl`s - Propagate `IsDefaulted` on serialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141827: [WIP][clang][TypePrinter] Test TemplateArgument::IsDefaulted when omitting default arguments

Michael137 updated this revision to Diff 491254. Michael137 added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141827/new/ https://reviews.llvm.org/D141827 Files: clang/lib/AST/TypePrinter.cpp Index:

[PATCH] D142333: [clang][DebugInfo] Check TemplateArgument::IsDefaulted

Michael137 created this revision. Michael137 added reviewers: dblaikie, aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since `ClassTemplateSpecializationDecl`s now set the

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbee8860525ac: [clang][DebugInfo] Dont canonicalize names in template argument list for alias… (authored by Michael137). Repository: rG LLVM

[PATCH] D142333: [clang][DebugInfo] Check TemplateArgument::IsDefaulted

Michael137 updated this revision to Diff 491257. Michael137 added a comment. - Make variable `const` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142333/new/ https://reviews.llvm.org/D142333 Files: clang/lib/CodeGen/CGDebugInfo.cpp Index:

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 492182. Michael137 added a comment. - Set `IsDefaulted` when checking template arguments in `clang::Sema` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files:

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 492184. Michael137 added a comment. - Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files: clang/include/clang/AST/PropertiesBase.td

[PATCH] D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 added a comment. Latest diff now sets the `IsDefaulted` flag from `Sema::CheckTemplateArgumentList`, which is the best point I could find for creation of `TemplateArgument` which are fed into the various specialization decls (and later on the `TypePrinter`). The review description

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 492187. Michael137 added a comment. - Don't need to pass flag to NewArgs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files:

[PATCH] D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 updated this revision to Diff 492306. Michael137 added a comment. - Remove redundant constructor call change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141826/new/ https://reviews.llvm.org/D141826 Files:

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

Michael137 updated this revision to Diff 492458. Michael137 added a comment. - Remove `dump()` leftover from debugging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142632/new/ https://reviews.llvm.org/D142632 Files:

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

Michael137 abandoned this revision. Michael137 added a comment. Abandoning in favour of https://reviews.llvm.org/D141826 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140423/new/ https://reviews.llvm.org/D140423

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

Michael137 created this revision. Michael137 added reviewers: erichkeane, aaron.ballman, aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds support for

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

Michael137 added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:2020 + Expr const *pattern_expr = Pattern.getAsExpr(); + pattern_expr->dump(); + if (pattern_expr->isValueDependent() || erichkeane wrote: > this left over from debugging? Yes! Good

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

Michael137 added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:2019 + // Can't evaluate value-dependent expressions so bail early + Expr const *pattern_expr = Pattern.getAsExpr(); + if (pattern_expr->isValueDependent() || aprantl wrote: > I

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

Michael137 added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:2031 +if (args_expr->isValueDependent() || !args_expr->isIntegerConstantExpr(Ctx)) + return false; + aprantl wrote: > Just for my own education: what's an example for a

[PATCH] D141826: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b4279b66fc2: [clang][TemplateBase] Add IsDefaulted bit to TemplateArgument (authored by Michael137). Repository: rG LLVM Github Monorepo

[PATCH] D142333: [clang][DebugInfo] Check TemplateArgument::IsDefaulted

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29ecf0e62cd7: [clang][DebugInfo] Check TemplateArgument::IsDefaulted (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D141827: [clang][TypePrinter] Test TemplateArgument::IsDefaulted when omitting default arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d7dcec5db2f: [clang][TypePrinter] Test TemplateArgument::IsDefaulted when omitting default… (authored by Michael137). Repository: rG LLVM Github

[PATCH] D142632: [clang][TypePrinter] Support expression template arguments when checking defaultedness

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG798494ed4f11: [clang][TypePrinter] Support expression template arguments when checking… (authored by Michael137). Repository: rG LLVM Github

[PATCH] D142713: [clang][ASTImporter] Propagate TemplateArgument::IsDefaulted during import

Michael137 updated this revision to Diff 492728. Michael137 added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142713/new/ https://reviews.llvm.org/D142713 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D142713: [clang][ASTImporter] Propagate TemplateArgument::IsDefaulted during import

Michael137 created this revision. Michael137 added reviewers: martong, aprantl. Herald added a subscriber: rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald

[PATCH] D141827: [clang][TypePrinter] Test TemplateArgument::IsDefaulted when omitting default arguments

Michael137 added a comment. This caused some LLDB test failures for the `import-std-module` setting. https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ We construct `TemplateArgument`s manually in the `CxxModuleHandler`. Fix is in-flight. Repository: rG LLVM Github Monorepo

[PATCH] D142713: [clang][ASTImporter] Propagate TemplateArgument::IsDefaulted during import

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd194d817b0b2: [clang][ASTImporter] Propagate TemplateArgument::IsDefaulted during import (authored by Michael137). Repository: rG LLVM Github

[PATCH] D141826: [WIP][clang][TemplateBase] Add IsDefaulted bit to TemplateArgument

Michael137 added a comment. In D141826#4058866 , @erichkeane wrote: > This seems innocuous enough/easy enough to use. I'd like a comment on the > functions at least and types in TemplateBase.h to specify that this is for > printing-policy only?

[PATCH] D142024: [clang] Optimize clang::Builtin::Info density

Michael137 added a comment. Seems like this broke the LLDB incremental build: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/50184/execution/node/43/log/?consoleFull We build with `LLVM_ENABLE_MODULES` by default While building module 'Clang_Basic' imported from

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. In D145803#4186805 , @dblaikie wrote: > Yeah, can't say this had occurred to me - but totally makes sense/reckon it's > OK. Any reason to limit this to lldb? I'd expect it'd probably "Just > Work(tm)" on any DWARF consumer?

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. Apparently some Objective-C/gmodules LLDB tests aren't happy with this change Investigating... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2640 if (!D || !D->isCompleteDefinition()) -return FwdDecl; +return {FwdDecl, nullptr}; aprantl wrote: > I'm curious if this works if we encounter a forward declaration,

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 added a comment. Michael137 updated this revision to Diff 504274. Michael137 updated this revision to Diff 504276. Michael137 edited the summary of this revision. Michael137 added a

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 added a comment. Making use of this in LLDB (see https://reviews.llvm.org/D145078) was a bit too finicky for my taste, so I prepared an alternative which doesn't require adding a new attribute and no LLDB changes. I *think* this is what @aprantl and @dblaikie had in mind couple of

  1   2   >